Re: r257260 - [vfs] Normalize working directory if requested.

2016-01-09 Thread Ismail Donmez via cfe-commits
Hi, > + NormalizedFS.setCurrentWorkingDirectory("/b/c"); > + NormalizedFS.setCurrentWorkingDirectory("."); > + ASSERT_EQ("/b/c", NormalizedFS.getCurrentWorkingDirectory().get()); > + NormalizedFS.setCurrentWorkingDirectory(".."); > + ASSERT_EQ("/b", NormalizedFS.getCurrentWorkingDirectory().g

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

2016-01-09 Thread Adrian Zgorzałek via cfe-commits
adek05 added a comment. I think this won't work. If there is a problem with the expression inside `throw` or `noexcept` specifier, it will be highlighted inside the parens, never trying to actually access the end location of the function declaration. It would be enough if there is a warning/err

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

2016-01-09 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. OK, thank you for the review. I'll commit this patch in a day or two unless someone comes up with a better solution. http://reviews.llvm.org/D15097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

2016-01-09 Thread guibufolo+l...@gmail.com via cfe-commits
RedX2501 added a comment. Ping http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r257267 - clang-format: Fix the counting of leading whitespace in tok::unknown tokens

2016-01-09 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Jan 9 15:12:45 2016 New Revision: 257267 URL: http://llvm.org/viewvc/llvm-project?rev=257267&view=rev Log: clang-format: Fix the counting of leading whitespace in tok::unknown tokens Previously, all whitespace characters would increase the starting column, which doesn't

r257260 - [vfs] Normalize working directory if requested.

2016-01-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jan 9 10:33:16 2016 New Revision: 257260 URL: http://llvm.org/viewvc/llvm-project?rev=257260&view=rev Log: [vfs] Normalize working directory if requested. FixedCompilationDatabase sets the working dir to "." by default. For chdir(".") this is a noop but this lead to InMemor

Re: r257259 - Make clang::format::reformat work with non 0-terminated strings.

2016-01-09 Thread Benjamin Kramer via cfe-commits
On Sat, Jan 9, 2016 at 4:56 PM, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Sat Jan 9 09:56:57 2016 > New Revision: 257259 > > URL: http://llvm.org/viewvc/llvm-project?rev=257259&view=rev > Log: > Make clang::format::reformat work with non 0-terminated strings. > > Modified: >

r257259 - Make clang::format::reformat work with non 0-terminated strings.

2016-01-09 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Jan 9 09:56:57 2016 New Revision: 257259 URL: http://llvm.org/viewvc/llvm-project?rev=257259&view=rev Log: Make clang::format::reformat work with non 0-terminated strings. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL: htt

r257258 - clang-format: Improve selective comment formatting.

2016-01-09 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Jan 9 09:56:53 2016 New Revision: 257258 URL: http://llvm.org/viewvc/llvm-project?rev=257258&view=rev Log: clang-format: Improve selective comment formatting. Starting here: int x; // Format this line only. int xx; // int x; // Before: int x; // Format

r257257 - clang-format: Fix incorrect line break in certain configurations.

2016-01-09 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Jan 9 09:56:47 2016 New Revision: 257257 URL: http://llvm.org/viewvc/llvm-project?rev=257257&view=rev Log: clang-format: Fix incorrect line break in certain configurations. Before: void aa(, vector

r257256 - clang-format: Support definitions/declarations of operator, .

2016-01-09 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Jan 9 09:56:40 2016 New Revision: 257256 URL: http://llvm.org/viewvc/llvm-project?rev=257256&view=rev Log: clang-format: Support definitions/declarations of operator,. Before: bool operator, (); After: bool operator,(); Modified: cfe/trunk/lib/Format/Continuat

r257255 - clang-format: [JS] Support semicolons in TypeScript's TypeMemberLists.

2016-01-09 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Sat Jan 9 09:56:28 2016 New Revision: 257255 URL: http://llvm.org/viewvc/llvm-project?rev=257255&view=rev Log: clang-format: [JS] Support semicolons in TypeScript's TypeMemberLists. Before: var x: { a: string; b: number; } = {}; After: var x: {a: string; b:

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-09 Thread Xiuli PAN via cfe-commits
pxli168 updated the summary for this revision. pxli168 updated this revision to Diff 44404. pxli168 added a comment. 1. Add tests for builtin function CodeGen and Semacheck 2. Add TODO for what we need to do about access qualifier 3. Fix some bugs found in writing Hope we cans squeeze these patch

r257254 - [OpenCL] Pipe type support

2016-01-09 Thread Xiuli Pan via cfe-commits
Author: pxl Date: Sat Jan 9 06:53:17 2016 New Revision: 257254 URL: http://llvm.org/viewvc/llvm-project?rev=257254&view=rev Log: [OpenCL] Pipe type support Summary: Support for OpenCL 2.0 pipe type. This is a bug-fix version for bader's patch reviews.llvm.org/D14441 Reviewers: pekka.jaaskelain

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-09 Thread Pekka Jääskeläinen via cfe-commits
pekka.jaaskelainen added a comment. In http://reviews.llvm.org/D15914#322917, @pxli168 wrote: > By the way, I just got the access to the llvm svn, can I just commit the pipe > type patch directly as I see you all accepted it. Or I should send it to the > cfe-commit first? I'm afraid we won'

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-09 Thread Xiuli PAN via cfe-commits
pxli168 added a comment. Then maybe I should hurry up to see if I can finish the Semacheck and this patch in time. By the way, I just got the access to the llvm svn, can I just commit the pipe type patch directly as I see you all accepted it. Or I should send it to the cfe-commit first? =

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-09 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: include/clang/Basic/Builtins.def:1260 @@ +1259,3 @@ + +LANGBUILTIN(reserve_read_pipe, "i.", "tn", OCLC_LANG) +LANGBUILTIN(reserve_write_pipe, "i.", "tn", OCLC_LANG) Anastasia wrote: > That's right! I am just saying that w

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

2016-01-09 Thread Pekka Jääskeläinen via cfe-commits
pekka.jaaskelainen added a comment. I wonder could we squeeze this in before the next week's LLVM 3.8 branching? It would be great. Comment at: lib/CodeGen/CGBuiltin.cpp:2033 @@ +2032,3 @@ +else if (BuiltinID == Builtin::BIwork_group_reserve_write_pipe) + Name = "_Z29w