Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

Ok, I'll abandon this. It wasn't meant to be contentious and this is a reasonable objection! James > On 12 Jan 2016, at 00:53, Mehdi Amini wrote: > > I’d fear the same thing. On our platform you have to use explicitly > -Wl,-mllvm (or -Xlinker -plugin-opt). > > — > Mehdi > > >> On Jan 11, 2

r257451 - clang-format: [JS] Support exporting abstract classes.

Author: djasper Date: Tue Jan 12 00:24:38 2016 New Revision: 257451 URL: http://llvm.org/viewvc/llvm-project?rev=257451&view=rev Log: clang-format: [JS] Support exporting abstract classes. Before: export abstract class X {y: number;} (and all sorts of other havoc in more complicated cases). Af

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood marked an inline comment as done. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4994 @@ +4993,3 @@ + EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;", + typedefDecl(hasUnderlyingType(asString("int"); + EXPECT_TRUE(matche

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

ABataev added a comment. You need to add the code/tests for nesting of regions. Comment at: include/clang-c/Index.h:2283 @@ +2282,3 @@ + */ + CXCursor_OMPTargetExitDataDirective= 262, + Target exit and target enter constructs must be implemented in differ

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 updated this revision to Diff 44601. pxli168 added a comment. Add negative tests to hint all paths in the Semacheck. http://reviews.llvm.org/D15914 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKinds.td lib/Basic/Builtin

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 44600. pxli168 added a comment. Fix destruct problem and fix style in inline comment. http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenFunction.cpp lib/Sema/SemaChecking.

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4934 @@ +4933,3 @@ +const Type *DeclTy = PDecl->getType().getCanonicalType().getTypePtr(); +if (AccessAttr->isReadWrite()) { + if (DeclTy->isPipeType() || Anastasia wrote: > In the c

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 updated this revision to Diff 44599. pxli168 added a comment. Remove some unused codes and add inline comment. http://reviews.llvm.org/D16047 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp lib/Sema/SemaType.c

Re: [PATCH] D15443: Fix getLocEnd for function declarations with exception specification.

adek05 updated this revision to Diff 44598. adek05 added a comment. Adding testcases in unittest/AST/SourceLocationTest.cpp as suggested by @aaronballman Interestingly, without my change tests for function declarations pass. Only member functions fail: tools/clang/unittests/AST/ASTTests ..

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5733 @@ +5732,3 @@ + +#if 0 + pekka.jaaskelainen wrote: > Is this intentionally included in the patch? My mistake, just want to check if this works. But find it is handled by something else. =

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

mjacob added a comment. In http://reviews.llvm.org/D15998#324354, @reames wrote: > Also, before this gets exposed through Clang, we really should > formalize/document the attribute. In practice, it implies the lack of a > safepoint poll site inside the called function. Annoyingly, it's not a

Re: [PATCH] D15791: Disable generating movt on FreeBSD

davide closed this revision. davide added a comment. Close, this went in a while ago. Repository: rL LLVM http://reviews.llvm.org/D15791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pxli168 added inline comments. Comment at: include/clang/Basic/Builtins.def:1260 @@ +1259,3 @@ + +LANGBUILTIN(reserve_read_pipe, "i.", "tn", OCLC_LANG) +LANGBUILTIN(reserve_write_pipe, "i.", "tn", OCLC_LANG) Anastasia wrote: > Ok, this way it means variable number

RE: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Duncan P. N. Exon Smith via cfe-commits > Sent: Monday, January 11, 2016 4:21 PM > To: Rafael Espíndola > Cc: Marshall Clow; CFE Commits > Subject: Re: [libcxx] r196411 - Give all members of

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna accepted this revision. zaks.anna added a comment. Laszlo, I am very excited about having the new and much improved scan-build in tree! It will serve as a solid foundation for moving forward. Thank you for all your hard work! Anna. http://reviews.llvm.org/D9600 __

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

majnemer added subscribers: aaron.ballman, majnemer. majnemer added a comment. This change looks fine modulo the documentation issue. Comment at: include/clang/Basic/Attr.td:2177 @@ +2176,3 @@ + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; +} -

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

reames added a comment. Neither Sanjoy or I are qualified to review a clang patch. You'll need to find clang reviewers. Also, before this gets exposed through Clang, we really should formalize/document the attribute. In practice, it implies the lack of a safepoint poll site inside the calle

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar updated this revision to Diff 44586. jlebar added a comment. Add test checking that sm_XX gets translated to compute_YY correctly. http://reviews.llvm.org/D16082 Files: include/clang/Driver/Action.h include/clang/Driver/Options.td include/clang/Driver/ToolChain.h include/clang/Dr

Re: [PATCH] D16097: [CUDA] Add explicit mapping from sm_XX to compute_YY.

jlebar updated this revision to Diff 44585. jlebar added a comment. Update to latest set of architectures, according to ptxas --help from cuda 7.5. http://reviews.llvm.org/D16097 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp test/Driver/cuda-bad-arch.cu Index: test/Driver/cu

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar added a comment. In http://reviews.llvm.org/D16082#324138, @tra wrote: > Make sure it works with -save-temps and -fintegrated-as/-fno-integrated-as. > They tend to throw wrenches into pipeline construction. Thanks. All of them worked except -fintegrated-as, which was causing us not to

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar updated this revision to Diff 44584. jlebar marked 8 inline comments as done. jlebar added a comment. Address tra, echristo's review comments. http://reviews.llvm.org/D16082 Files: include/clang/Driver/Action.h include/clang/Driver/Options.td include/clang/Driver/ToolChain.h incl

Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

I’d fear the same thing. On our platform you have to use explicitly -Wl,-mllvm (or -Xlinker -plugin-opt). — Mehdi > On Jan 11, 2016, at 4:11 PM, Rafael Espíndola > wrote: > > Maybe. I would like a second opinion on this one. The potential issue > I see is that we are using compiler options

[libcxx] r257422 - Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right place.

Author: marshall Date: Mon Jan 11 18:38:04 2016 New Revision: 257422 URL: http://llvm.org/viewvc/llvm-project?rev=257422&view=rev Log: Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right place. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/includ

[PATCH] D16097: [CUDA] Add explicit mapping from sm_XX to compute_YY.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. This is used by D16082 when it invokes fatbinary. http://reviews.llvm.org/D16097 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp test/Driver/cuda-bad-arch.cu Index

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

ping > On 2016-Jan-04, at 12:37, Duncan P. N. Exon Smith > wrote: > > ping > >> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith >>> wrote: >>> >>> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> On 2016-Jan-11, at 15:57, Rafael Espíndola wrote: > >> I'm not sure about GCC. Note that there is no linkage for -frtti, >> since the type info is deferred to the TU with the vtable. > > Yes, that is what I mean. It is odd that -frtti changes us from "this > is not available anywhere, use li

Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

Maybe. I would like a second opinion on this one. The potential issue I see is that we are using compiler options during linking. Normally they are just ignored. Is it surprising if LTO starts using them? Cheers, Rafael On 11 January 2016 at 06:47, James Molloy wrote: > jmolloy created this rev

Re: [PATCH] D15208: Patch for inline abort code generation

samsonov added a comment. Sorry for delay. Comment at: lib/CodeGen/CGExpr.cpp:2543 @@ +2542,3 @@ + // RE: Bug: 25682 + if(!CGM.getCodeGenOpts().MergeTraps || !CGM.getCodeGenOpts().OptimizationLevel || !TrapBB) { +// If we aren't merging traps, set the function to not be o

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> I'm not sure about GCC. Note that there is no linkage for -frtti, > since the type info is deferred to the TU with the vtable. Yes, that is what I mean. It is odd that -frtti changes us from "this is not available anywhere, use linkonce_odr" to "it is available elsewhere, use an external declar

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

samsonov added a comment. Sorry, lost track of this. Comment at: lib/Driver/ToolChains.cpp:368 @@ +367,3 @@ + StringRef OS = ""; + if (isTargetMacOS()) +OS = "osx"; zaks.anna wrote: > samsonov wrote: > > Wait, this looks horrible. Can we teach toolchain to

[PATCH] D16094: Debugger tuning via gold plugin

probinson created this revision. probinson added a reviewer: echristo. probinson added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. LTO via the gold plugin needs to be told about debugger tuning. http://reviews.llvm.org/D16094 Files: lib/Driver/Tools.cpp test/Driver/lto.c

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

> On 2016-Jan-11, at 15:40, Rafael Espíndola wrote: > > On 8 January 2016 at 19:50, Duncan P. N. Exon Smith via cfe-commits > wrote: >> [re-send to lists.llvm.org] >> [necromancy] >> >> This is causing some strangeness for users of libc++ headers that >> ship dylibs and build with -fno-rtti an

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

On 8 January 2016 at 19:50, Duncan P. N. Exon Smith via cfe-commits wrote: > [re-send to lists.llvm.org] > [necromancy] > > This is causing some strangeness for users of libc++ headers that > ship dylibs and build with -fno-rtti and -fvisibility=hidden. > > Strangely, -fno-rtti does *not* imply -f

Re: r257175 - Driver: Use the new ELF lld linker for AMDGPU

awesome! On 8 January 2016 at 10:14, Tom Stellard via cfe-commits wrote: > Author: tstellar > Date: Fri Jan 8 09:14:31 2016 > New Revision: 257175 > > URL: http://llvm.org/viewvc/llvm-project?rev=257175&view=rev > Log: > Driver: Use the new ELF lld linker for AMDGPU > > Summary: 'gnu-old' has be

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257413: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16079?vs=44564&id=44569#toc Repository: rL

r257413 - [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

Author: jlebar Date: Mon Jan 11 17:27:13 2016 New Revision: 257413 URL: http://llvm.org/viewvc/llvm-project?rev=257413&view=rev Log: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/. Reviewers: tra Subscribers: cfe-commits, jhen, echristo Differential Revision: http://

Buildbot numbers for week of 1/03/2016 - 1/09/2016

Hello everyone, Below are some buildbot numbers for the last week of 1/03/2016 - 01/09/2016. Thanks Galina Number of commits by project: project | commits ---+--- llvm | 266 cfe |9

Re: [PATCH] D16078: Add an Action* member to InputInfo.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257411: Add an Action* member to InputInfo. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16078?vs=44539&id=44568#toc Repository: rL LLVM http://reviews.llvm.org/D16078 Fi

r257411 - Add an Action* member to InputInfo.

Author: jlebar Date: Mon Jan 11 17:15:21 2016 New Revision: 257411 URL: http://llvm.org/viewvc/llvm-project?rev=257411&view=rev Log: Add an Action* member to InputInfo. Summary: The CUDA toolchain needs to know which Actions created which InputInfos, because it needs to attach GPU archs to the va

r257408 - Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam.

Author: jlebar Date: Mon Jan 11 17:09:32 2016 New Revision: 257408 URL: http://llvm.org/viewvc/llvm-project?rev=257408&view=rev Log: Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam. Summary: Explicit is better than implicit. Reviewers: echristo Subscribers: ll

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

echristo added a comment. Yep it's fine. Thanks! -eric http://reviews.llvm.org/D16079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257407: Move ownership of Action objects into Compilation. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D15911?vs=44379&id=44566#toc Repository: rL LLVM http://reviews.llvm

r257407 - Move ownership of Action objects into Compilation.

Author: jlebar Date: Mon Jan 11 17:07:27 2016 New Revision: 257407 URL: http://llvm.org/viewvc/llvm-project?rev=257407&view=rev Log: Move ownership of Action objects into Compilation. Summary: This makes constructing Action graphs which are DAGs much simpler. It also just simplifies in general t

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

jlebar added a comment. Oops, I added the new error to the generated file in my objdir, rather than in the source tree. It worked fine until I rebuilt... Eric, please have a look at the change to DiagnosticDriverKinds.td. http://reviews.llvm.org/D16079 _

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

jlebar updated this revision to Diff 44564. jlebar added a comment. Add missing change to DiagnosticDriverKinds.td. http://reviews.llvm.org/D16079 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp test/Driver/

r257406 - clang-format: [JS] Teach clang-format about "export interface".

Author: djasper Date: Mon Jan 11 16:57:40 2016 New Revision: 257406 URL: http://llvm.org/viewvc/llvm-project?rev=257406&view=rev Log: clang-format: [JS] Teach clang-format about "export interface". Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/unittests/Format/FormatTes

Re: [PATCH] D16065: Fix infinite recursion for invalid declaration

kcc accepted this revision. kcc added a reviewer: kcc. kcc added a comment. This revision is now accepted and ready to land. LGTM, and thanks! http://reviews.llvm.org/D16065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

jlebar added a comment. In http://reviews.llvm.org/D15960#324162, @echristo wrote: > So, how are you getting to the point where you're trying to create the same > action twice? > > -eric In the new CUDA world, we have the following graph, which I hope will render properly: foo.cu --> foo.s

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

jlebar added a comment. In http://reviews.llvm.org/D15960#324162, @echristo wrote: > So, how are you getting to the point where you're trying to create the same > action twice? > > -eric In the new CUDA world, we have the following graph, which I hope will render properly: foo.cu --> foo.s

Re: [PATCH] D15960: Don't build jobs for the same Action + ToolChain twice.

echristo added a comment. So, how are you getting to the point where you're trying to create the same action twice? -eric http://reviews.llvm.org/D15960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D15911: Move ownership of Action objects into Compilation.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks for doing this :) -eric http://reviews.llvm.org/D15911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping :] http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r257403 - When a tag is declared in prototype scope in C, if we've decided that it

Author: rsmith Date: Mon Jan 11 16:41:53 2016 New Revision: 257403 URL: http://llvm.org/viewvc/llvm-project?rev=257403&view=rev Log: When a tag is declared in prototype scope in C, if we've decided that it redeclares an existing tag but are creating a new declaration anyway (because it has attribu

Re: [PATCH] D16078: Add an Action* member to InputInfo.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sure. Seems reasonable. -eric http://reviews.llvm.org/D16078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

echristo added a comment. One question inline, one nit, and one more question here: You've got a couple of checks inline for null names/architectures, where do you expect those to come from and can you test for them? Or, another question, is if they're multiple architectures shouldn't we be abl

Re: [PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

tra added a comment. Make sure it works with -save-temps and -fintegrated-as/-fno-integrated-as. They tend to throw wrenches into pipeline construction. Comment at: lib/Driver/Driver.cpp:1380 @@ +1379,3 @@ + C.MakeAction(DeviceActions, types::TY_CUDA_FATBIN), + /* Gpu

Re: [PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric http://reviews.llvm.org/D16079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

> On Jan 11, 2016, at 2:13 PM, Benjamin Kramer wrote: > > On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson > wrote: >> >>> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >>> >>> >>> >>> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits >>> wrote: >

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson wrote: > >> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >> >> >> >> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits >> wrote: >> resistor created this revision. >> resistor added reviewers: chandlerc, bkramer, klimek. >> resis

[PATCH] D16087: Add some overview doxygen comments to lib/Format.

thakis created this revision. thakis added a reviewer: djasper. thakis added a subscriber: cfe-commits. Herald added a subscriber: klimek. It always takes me a while to understand how clang-format's pieces fit together -- hopefully this will save me some time the next time I need it. http://revi

r257392 - PR26087: Use nonstandard MSVC extension for VS2015 as well.

Author: jyknight Date: Mon Jan 11 16:00:22 2016 New Revision: 257392 URL: http://llvm.org/viewvc/llvm-project?rev=257392&view=rev Log: PR26087: Use nonstandard MSVC extension for VS2015 as well. In r256564, I had conditioned the workaround in has_getDecl to only be used for MSVC before the 2015 r

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. FOAD: Ball's in @mclow.lists's court, not mine. I don't feel comfortable signing off on this. http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. ping http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16082: [CUDA] Invoke ptxas and fatbinary during compilation.

jlebar created this revision. jlebar added reviewers: tra, echristo. jlebar added subscribers: jhen, cfe-commits. Previously we compiled CUDA device code to PTX assembly and embedded that asm as text in our host binary. Now we compile to PTX assembly and then invoke ptxas to assemble the PTX into

[PATCH] D16079: [CUDA] Reject values for --cuda-gpu-arch that are not of the form /sm_\d+/.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: echristo, jhen, cfe-commits. http://reviews.llvm.org/D16079 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp test/Driver/cuda-bad-arch.cu Index: test/Driver/cuda-bad-arch

[PATCH] D16081: [CUDA] Add test for compiling CUDA code with -S.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, cfe-commits. http://reviews.llvm.org/D16081 Files: test/Driver/cuda-options.cu test/Driver/cuda-output-asm.cu Index: test/Driver/cuda-output-asm.cu

[PATCH] D16080: [CUDA] Add tests for compiling CUDA files with -E.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, cfe-commits. http://reviews.llvm.org/D16080 Files: test/Driver/cuda-preprocess.cu Index: test/Driver/cuda-preprocess.cu === --- /dev/null

[PATCH] D16078: Add an Action* member to InputInfo.

jlebar created this revision. jlebar added a reviewer: echristo. jlebar added subscribers: cfe-commits, tra, jhen. Herald added subscribers: dschuff, jfb. The CUDA toolchain needs to know which Actions created which InputInfos, because it needs to attach GPU archs to the various InputInfos. http:

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

On Mon, Jan 11, 2016 at 12:28:36PM -0800, Akira Hatanaka via cfe-commits wrote: > It triggers in dead branches and so does an initialization of an integer > variable declared in a function. I'm more interested in the case of global initialisers here. There is a long standing history of not checki

Re: [PATCH] D16062: [analyzer] Rename kind-enumeration values of SVal, SymExpr, MemRegion classes, for consistency.

dcoughlin added a comment. Looks good to me. Thanks for making this more consistent! Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:102 @@ -103,1 +101,3 @@ +BEGIN_TYPED_REGIONS, +FunctionTextRegionKind = BEGIN_TYPED_REGIONS, BlockTextRegionK

r257383 - Fix -Wmicrosoft-enum-value warning

Author: rnk Date: Mon Jan 11 14:55:16 2016 New Revision: 257383 URL: http://llvm.org/viewvc/llvm-project?rev=257383&view=rev Log: Fix -Wmicrosoft-enum-value warning Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL: http://llvm.org/viewv

Re: [PATCH] D15921: [analyzer] Utility to match function calls.

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:312 @@ +311,3 @@ + /// calls. + bool isCalled(const CallEvent &Call, const CallDescription &CD); + The API is a bit awkward. Maybe it would be better if

Re: [PATCH] D15858: Warn undeclared identifiers in CUDA kernel calls

jhen updated this revision to Diff 44538. jhen added a comment. - Handle unexpanded parameter packs The changes for instantiation dependence also fix a bug with unexpanded parameter packs, so add a unit test for unexpanded parameter packs as well. http://reviews.llvm.org/D15858 Files: inc

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

It triggers in dead branches and so does an initialization of an integer variable declared in a function. I’ll look into fixing it. > On Jan 11, 2016, at 9:54 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Mon, Jan 11, 2016 at 05:22:01PM -, Akira Hatanaka via cfe-commits > wrote:

[libcxx] r257368 - Preemptively disable unsigned integer sanitization in 32 and 64 bit versions of __murmur2_or_cityhash. This lets people use the unsigned integer overflow checker in UBSAN w/o gettin

Author: marshall Date: Mon Jan 11 13:27:10 2016 New Revision: 257368 URL: http://llvm.org/viewvc/llvm-project?rev=257368&view=rev Log: Preemptively disable unsigned integer sanitization in 32 and 64 bit versions of __murmur2_or_cityhash. This lets people use the unsigned integer overflow checker

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: > > > > On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits > wrote: > resistor created this revision. > resistor added reviewers: chandlerc, bkramer, klimek. > resistor added a subscriber: cfe-commits. > resistor set the reposi

Re: [PATCH] D16062: [analyzer] Rename kind-enumeration values of SVal, SymExpr, MemRegion classes, for consistency.

zaks.anna added a comment. > MemSpaceRegion is now an abstract base What prevents it from being instantiated? http://reviews.llvm.org/D16062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

rnk added a subscriber: rnk. rnk added a comment. In http://reviews.llvm.org/D15363#321941, @samsonov wrote: > Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on > Windows? Seems so: I don't see an XFAIL there, and it also uses > suppressions, but with single quote, follo

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pekka.jaaskelainen added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2033 @@ +2032,3 @@ + *Arg1 = EmitScalarExpr(E->getArg(1)); +llvm::Type *ReservedIDTy = ConvertType(getContext().OCLReserveIDTy); + Anastasia wrote: > pekka.jaaskelainen wr

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2033 @@ +2032,3 @@ + *Arg1 = EmitScalarExpr(E->getArg(1)); +llvm::Type *ReservedIDTy = ConvertType(getContext().OCLReserveIDTy); + pekka.jaaskelainen wrote: > Anastasia wrote: > >

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

pekka.jaaskelainen added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2033 @@ +2032,3 @@ + *Arg1 = EmitScalarExpr(E->getArg(1)); +llvm::Type *ReservedIDTy = ConvertType(getContext().OCLReserveIDTy); + Anastasia wrote: > Why do we need to mod

Re: [PATCH] D12901: [Static Analyzer] Assertion "System is over constrained" after truncating 64 bits integers to 32 bits. (PR25078)

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Sounds good. Please, split this into 2 patches (each fixing the separate problem) and commit. Thanks! Anna. http://reviews.llvm.org/D12901 __

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pekka.jaaskelainen added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5733 @@ +5732,3 @@ + +#if 0 + Is this intentionally included in the patch? Comment at: lib/Sema/SemaDecl.cpp:6759 @@ +6758,3 @@ + +#if 0 + // OpenCL v2.0 s6.9.b ---

Re: r257357 - [Sema] Issue a warning for integer overflow in struct initializer

On Mon, Jan 11, 2016 at 05:22:01PM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Jan 11 11:22:01 2016 > New Revision: 257357 > > URL: http://llvm.org/viewvc/llvm-project?rev=257357&view=rev > Log: > [Sema] Issue a warning for integer overflow in struct initializer >

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

Any feedback? Thanks, --Serge 2015-12-11 20:24 GMT+06:00 Serge Pavlov : > sepavloff created this revision. > sepavloff added a subscriber: cfe-commits. > > Llvm module object is shared between CodeGenerator and BackendConsumer, > in both classes it is stored as std::unique_ptr, which is not a go

r257357 - [Sema] Issue a warning for integer overflow in struct initializer

Author: ahatanak Date: Mon Jan 11 11:22:01 2016 New Revision: 257357 URL: http://llvm.org/viewvc/llvm-project?rev=257357&view=rev Log: [Sema] Issue a warning for integer overflow in struct initializer Clang wasn't issuing a warning when compiling the following code: struct s { unsigned x; } s

Re: [PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rL257357: [Sema] Issue a warning for integer overflow in struct initializer (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D15097?vs=41451&id=44521#toc Repository: rL LLVM ht

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

rjmccall added a comment. Sorry, holidays. I'm comfortable with taking this patch as-is. http://reviews.llvm.org/D14980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r257347. http://reviews.llvm.org/D15796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r257347 - Add documentation redirects for clang-tidy checkers that are exposed under multiple checker names. Updates the Python script for adding checks to properly handle these al

Author: aaronballman Date: Mon Jan 11 10:48:26 2016 New Revision: 257347 URL: http://llvm.org/viewvc/llvm-project?rev=257347&view=rev Log: Add documentation redirects for clang-tidy checkers that are exposed under multiple checker names. Updates the Python script for adding checks to properly ha

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15796: [PATCH] clang-tidy documentation redirects

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D15796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL257341: [clang-format] Fix comment aligning when there are changes within the comment (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D16058?vs=44513&id=44517#toc Repository: rL L

r257341 - [clang-format] Fix comment aligning when there are changes within the comment

Author: d0k Date: Mon Jan 11 10:27:16 2016 New Revision: 257341 URL: http://llvm.org/viewvc/llvm-project?rev=257341&view=rev Log: [clang-format] Fix comment aligning when there are changes within the comment As soon as a comment had whitespace changes inside of the token, we couldn't identify the

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > resistor created this revision. > resistor added reviewers: chandlerc, bkramer, klimek. > resistor added a subscriber: cfe-commits. > resistor set the repository for this revision to rL LLVM. > H

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. lg Comment at: lib/Format/WhitespaceManager.h:113 @@ -113,1 +112,3 @@ + bool ContinuesPPDirective, bool IsStartOfDeclName, + bool IsInsideTrailingCommentToken);

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44513. bkramer added a comment. - Moved newline check into replaceWhitespaceInToken - Removed duplicated TokenLength computation http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/For

Re: [PATCH] D15823: Support virtual-near-miss check.

alexfh added a comment. A few minor comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:23 @@ +22,3 @@ +/// Finds out if the given method overrides some method. +bool isOverrideMethod(const CXXMethodDecl *MD) { + return MD->size_overridden_methods() > 0 || MD->hasAtt

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4934 @@ +4933,3 @@ +const Type *DeclTy = PDecl->getType().getCanonicalType().getTypePtr(); +if (AccessAttr->isReadWrite()) { + if (DeclTy->isPipeType() || In the case of failure, w

Re: [PATCH] D16063: [Analyzer] Use a wider integer type for an array index

xazax.hun added a comment. In http://reviews.llvm.org/D16063#323513, @a.sidorin wrote: > As I described before, PtrDiffType is signed and is limited to SIZE_MAX/2. > However, we are allowed to create arrays with the size more than SIZE_MAX/2 > (see testIndexTooBig() test for details). But we sh

  1   2   >