Re: [PATCH] D16394: Add an isVirtualAsWritten AST matcher.

aaron.ballman accepted this revision. aaron.ballman added a comment. FWIW, LGTM as well. http://reviews.llvm.org/D16394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11035: trivial patch, improve constness

danielmarjamaki marked an inline comment as done. danielmarjamaki added a comment. http://reviews.llvm.org/D11035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11035: trivial patch, improve constness

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D11035

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added a comment. In http://reviews.llvm.org/D16310#331538, @LegalizeAdulthood wrote: > If you state what the check does, then > > In http://reviews.llvm.org/D16310#331054, @danielmarjamaki wrote: > > > In http://reviews.llvm.org/D16310#330367, @LegalizeAdulthood wrote: > > > > >

[PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli. arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin. Accept depend clause on target enter data directive in sema and add test cases. http://reviews.llvm.org/D16400

r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

Author: abataev Date: Thu Jan 21 06:54:48 2016 New Revision: 258396 URL: http://llvm.org/viewvc/llvm-project?rev=258396=rev Log: Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

ABataev added a comment. Add tests for templates to test/OpenMP/target_enter_data_depend_messages.cpp http://reviews.llvm.org/D16400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16401: [OpenMP] Sema for depend clause on target exit data directive.

arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli. arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin. Accept depend clause on target exit data directive in sema and add test cases. http://reviews.llvm.org/D16401

r258394 - [OPENMP] Fix crash on reduction for complex variables.

Author: abataev Date: Thu Jan 21 06:35:58 2016 New Revision: 258394 URL: http://llvm.org/viewvc/llvm-project?rev=258394=rev Log: [OPENMP] Fix crash on reduction for complex variables. reworked codegen for reduction operation for complex types to avoid crash Modified:

[PATCH] D16396: Warn if variable cannot be implicitly instantiated

sepavloff created this revision. sepavloff added a reviewer: rsmith. sepavloff added subscribers: cfe-commits, silvas. Instantiation of static class members may be a source of user misunderstanding, especially in the case of using modules, PR24425 describes one of such examples. This patch

r258401 - When dumping documentation for AST matchers, do something more useful with \see doxygen commands. Ideally this would link to the target of \see, but for now it translates \see into "See also

Author: aaronballman Date: Thu Jan 21 09:18:25 2016 New Revision: 258401 URL: http://llvm.org/viewvc/llvm-project?rev=258401=rev Log: When dumping documentation for AST matchers, do something more useful with \see doxygen commands. Ideally this would link to the target of \see, but for now it

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders updated this revision to Diff 45531. dsanders added a comment. Added one more. It was also guarded by a check for ru_RU.UTF-8 so it was missed on the first sweep. http://reviews.llvm.org/D16406 Files: test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders added a comment. Thanks. I've added one more which came up after enabling all the missing locales except for en_US.UTF-8. I'll commit this and find the other 8 with grep afterwards. http://reviews.llvm.org/D16406 ___ cfe-commits mailing

Re: [PATCH] D16401: [OpenMP] Sema for depend clause on target exit data directive.

arpith-jacob updated this revision to Diff 45532. arpith-jacob added a comment. Added template instantiation test case for all feasible tests. http://reviews.llvm.org/D16401 Files: include/clang/Basic/OpenMPKinds.def test/OpenMP/target_exit_data_ast_print.cpp

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

aaron.ballman added subscribers: dblaikie, rsmith. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:51 @@ +50,3 @@ + + Diag << FixItHint::CreateInsertion(CCtorEnd, Insertion.str()); +} alexfh wrote: > aaron.ballman wrote: > > We probably do

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

bcraig added a subscriber: bcraig. bcraig added a comment. LGTM, but that doesn't mean much. I suspect that there are some tests that have snuck past this sweep, but I haven't done the work to figure out which ones. I base this statement off of these search results... LOCALE_en_US_UTF_8 found

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

arpith-jacob updated this revision to Diff 45525. arpith-jacob added a comment. Added template instantiation test case for all feasible tests. http://reviews.llvm.org/D16400 Files: include/clang/Basic/OpenMPKinds.def test/OpenMP/target_enter_data_ast_print.cpp

[PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders created this revision. dsanders added reviewers: mclow.lists, hans. dsanders added a subscriber: cfe-commits. http://reviews.llvm.org/D16406 Files: test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki marked an inline comment as done. Comment at: clang-tidy/misc/LongCastCheck.cpp:21 @@ +20,3 @@ + Finder->addMatcher( + returnStmt( + has(cStyleCastExpr(has(binaryOperator(anyOf(hasOperatorName("+"), alexfh wrote: > Any reason to

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258403: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8. (authored by dsanders). Changed prior to commit: http://reviews.llvm.org/D16406?vs=45531=45533#toc Repository:

[libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

Author: dsanders Date: Thu Jan 21 09:35:15 2016 New Revision: 258403 URL: http://llvm.org/viewvc/llvm-project?rev=258403=rev Log: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8. Reviewers: mclow.lists, hans Subscribers: bcraig, cfe-commits Differential

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki marked an inline comment as done. Comment at: clang-tidy/misc/LongCastCheck.cpp:43 @@ +42,3 @@ + +static unsigned getMaxCalculationWidth(ASTContext , const Expr *E) { + E = E->IgnoreParenImpCasts(); LegalizeAdulthood wrote: > Prefer anonymous

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

alexfh added inline comments. Comment at: clang-tidy/misc/LongCastCheck.cpp:21 @@ +20,3 @@ + Finder->addMatcher( + returnStmt( + has(cStyleCastExpr(has(binaryOperator(anyOf(hasOperatorName("+"), Any reason to limit this to returnStmt, varDecl and

Re: [PATCH] D16400: [OpenMP] Sema for depend clause on target enter data directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D16400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

aaron.ballman added inline comments. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:37 @@ +36,3 @@ + + DiagnosticBuilder Diag = diag(MatchedDecl->getLocation(), "class '%0' defines a copy-constructor but not an assignment operator") + << ClassName;

Re: [PATCH] D16406: [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

dsanders added a comment. Hi, I'd like to merge this to the 3.8 branch once it has been accepted. http://reviews.llvm.org/D16406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

alexfh added inline comments. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:32 @@ +31,3 @@ + + if (MatchedDecl->isImplicit()) +return; This check should be done in the matcher. Comment at:

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

alexfh added inline comments. Comment at: clang-tidy/misc/LongCastCheck.cpp:21 @@ +20,3 @@ + Finder->addMatcher( + returnStmt( + has(cStyleCastExpr(has(binaryOperator(anyOf(hasOperatorName("+"), danielmarjamaki wrote: > alexfh wrote: > > Any reason

[PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

dsanders created this revision. dsanders added reviewers: bcraig, mclow.lists, hans. dsanders added a subscriber: cfe-commits. These are the tests that didn't fail in the release candidate because they were covered by another 'REQUIRES' directive. http://reviews.llvm.org/D16408 Files:

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

> Daniel, I assume we want reviews.llvm.org/D16408 too when that lands, > right? Yes, the tests in D16408 aren't blocking any particular build that I know of but we should still merge it. > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf > Of Hans

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

Hi, It was LGTM'd by bcraig. From: Marshall Clow [mailto:mclow.li...@gmail.com] Sent: 21 January 2016 17:25 To: Hans Wennborg Cc: Daniel Sanders; cfe-commits Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8. On Thu, Jan 21, 2016 at

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

hans added a subscriber: dim. hans added a comment. +dim who said the locale tests were also failing for him on FreeBSD. Maybe this is relevant? http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

I'm fine with it. Alex, what do you think? On Wed, Jan 20, 2016 at 3:07 PM, Aaron Ballman wrote: > Uncertain whether this meets the bar for inclusion in 3.8. > clang-modernize was moved into clang-tidy and from what I can tell, it > did not suffer from this crash. I

Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

On Thu, Jan 21, 2016 at 9:05 AM, Hans Wennborg wrote: > Hi Marshall, > > Is this OK for 3.8? > I have no idea; this is the first I've seen of it. Apparently it was posted on phab, no one approved it, and it was committed. In an hour. -- Marshall > > Daniel, I assume we

Re: [PATCH][Modules][PR26179]

ping... (perhaps someone else with commit rights can check it it...) --Vassil On 18/01/16 22:07, Vassil Vassilev wrote: Thanks! Could you check it in? -- Vassil On 18/01/16 21:38, Richard Smith via cfe-commits wrote: LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev"

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

dsanders added a comment. There's only 7 instead of the 8 we were expecting because one match turned out to be the python script that checks for the availability of the locale. http://reviews.llvm.org/D16408 ___ cfe-commits mailing list

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

alexfh added inline comments. Comment at: docs/clang-tidy/checks/misc-user-defined-copy-without-assignment.rst:6 @@ +5,3 @@ + +MSVC 2015 will generate an assignment operator even if the user defines a copy constructor. +This check finds classes with a user-defined (including

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

I just took that as being humble. I'm happy to revert if you want. From: Marshall Clow [mailto:mclow.li...@gmail.com] Sent: 21 January 2016 17:29 To: Daniel Sanders Cc: Hans Wennborg; cfe-commits Subject: Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require

RE: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

I'm not sure why my reply-all dropped Hans from the recipients. Re-added him. From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Daniel Sanders via cfe-commits Sent: 21 January 2016 17:31 To: Marshall Clow Cc: cfe-commits Subject: RE: [libcxx] r258403 - [libcxx] Add

Re: [PATCH] D8940: Clang changes for indirect call target profiling

betulb updated this revision to Diff 45550. betulb added a comment. In this revision: - Clang no longer attaches function names as metadata. - Bug fixed in checking the getNumValueSites return value. - Addressed review comments. http://reviews.llvm.org/D8940 Files: lib/CodeGen/CGCall.cpp

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe marked 5 inline comments as done. Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.h:25 @@ +24,3 @@ +/// assignment operator to be `= delete`. +/// +/// For the user-facing documentation see: The standard says that compiler generation of

Re: [PATCH] D16413: Let RecursiveASTVisitor visit array index VarDecls

thakis updated this revision to Diff 45551. thakis added a comment. fix test name http://reviews.llvm.org/D16413 Files: include/clang/AST/RecursiveASTVisitor.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: include/clang/AST/RecursiveASTVisitor.h

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

I'm fine with including this to 3.8. BTW, I'm working on release notes. On Thu, Jan 21, 2016 at 6:01 PM, Hans Wennborg wrote: > I'm fine with it. Alex, what do you think? > > On Wed, Jan 20, 2016 at 3:07 PM, Aaron Ballman > wrote: > > Uncertain

Re: [PATCH] D8940: Clang changes for indirect call target profiling

betulb marked 3 inline comments as done. Comment at: lib/CodeGen/CodeGenPGO.cpp:768 @@ +767,3 @@ +}; +Builder.CreateCall( +CGM.getIntrinsic(llvm::Intrinsic::instrprof_value_profile), Args); I removed the if check instead. It was not needed since

Re: [PATCH] D16394: Add an isVirtualAsWritten AST matcher.

thakis closed this revision. thakis added a comment. r258415, thanks! http://reviews.llvm.org/D16394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r258356 - Make modernize-use-default tolerant of delayed template parsing; this code was previously causing failed assertions because dyn_cast was being passed a null pointer d

Thanks. Aaron, do you want to go ahead and merge this with utils/release/merge.sh? Or let me know if you'd prefer me to do the merge. On Thu, Jan 21, 2016 at 10:00 AM, Alexander Kornienko wrote: > I'm fine with including this to 3.8. BTW, I'm working on release notes. > > On

Re: [PATCH] D16376: clang-tidy check: User-defined copy without assignment

jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 45554. jbcoe added a comment. Made requested changes. http://reviews.llvm.org/D16376 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote: > thakis added a comment. > > After some more debugging, the only thing in this test that's still > faiilng on Windows is the "unsigned-integer-overflow:do_overflow" > suppression -- when llvm-symbolizer gets symbols from

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

zaks.anna added a comment. > I don't know, is there a way to install runtime components for ASan if your > distribution doesn't happen to have one (that must be tricky, as the version > of ASan should match the version of the compiler). Correct, there is no recommended way of installing the

r258425 - [OpenMP] Check for at least one map clause on target data directive.

Author: arpith Date: Thu Jan 21 13:57:55 2016 New Revision: 258425 URL: http://llvm.org/viewvc/llvm-project?rev=258425=rev Log: [OpenMP] Check for at least one map clause on target data directive. Summary: Adds the following restriction in the OpenMP specifications. OpenMP [2.10.1,

r258426 - [driver] Enable some static analyzer "unix" checkers on Windows.

Author: dcoughlin Date: Thu Jan 21 14:09:49 2016 New Revision: 258426 URL: http://llvm.org/viewvc/llvm-project?rev=258426=rev Log: [driver] Enable some static analyzer "unix" checkers on Windows. Many of the "unix" checkers are not actually unix-specific and would be valuable to run on Windows.

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur added a comment. Ping. Passmanagerbuilder change has been committed. Could you take a look at this command line option patch? Thanks, -Rong http://reviews.llvm.org/D15829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

xazax.hun added inline comments. Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:3 @@ -2,3 +2,3 @@ -misc-inefficient-algorithm +performance-inefficient-algorithm == Eugene.Zelenko wrote: > alexfh wrote: > >

Re: [libcxxabi] r258249 - Recommit r256322: Fix PR25898 - Check for incomplete pointers types in can_catch(...)

I'll merge all my commits tonight. Thanks Hans. /Eric On Wed, Jan 20, 2016 at 10:38 AM, Hans Wennborg wrote: > No problem. Please go ahead and merge with utils/release/merge.sh, or > let me know if you'd prefer me to do it. > > On Tue, Jan 19, 2016 at 7:09 PM, Eric Fiselier

Re: [PATCH] D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16430: Fix printing of nested variable declarations with suppressed specifiers

nick.sumner created this revision. nick.sumner added reviewers: bkramer, rsmith. nick.sumner added a subscriber: cfe-commits. Allow nested variable declarations to have their types printed correctly even when the incoming PrintingPolicy suppresses specifiers. This can happen when initializing a

r258447 - [MSVC Compat] Don't omit frame pointers if /Oy- is specified before /O2

Author: majnemer Date: Thu Jan 21 17:01:11 2016 New Revision: 258447 URL: http://llvm.org/viewvc/llvm-project?rev=258447=rev Log: [MSVC Compat] Don't omit frame pointers if /Oy- is specified before /O2 Microsoft's documentation states that specifying /Oy- after the /O[12x] options disables

r258441 - [OpenMP] Parsing + Sema for nowait clause on target directive

Author: arpith Date: Thu Jan 21 16:18:28 2016 New Revision: 258441 URL: http://llvm.org/viewvc/llvm-project?rev=258441=rev Log: [OpenMP] Parsing + Sema for nowait clause on target directive Summary: Allow nowait clause on target directive in sema and add test cases. Reviewers: ABataev

Re: [PATCH] D16358: [OpenMP] Parsing + Sema for nowait clause on target directive

This revision was automatically updated to reflect the committed changes. Closed by commit rL258441: [OpenMP] Parsing + Sema for nowait clause on target directive (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16358?vs=45399=45595#toc Repository: rL LLVM

[PATCH] D16433: Fix printing signed character literals

nick.sumner created this revision. nick.sumner added reviewers: bkramer, rsmith. nick.sumner added a subscriber: cfe-commits. Allow StmtPrinter to print signed character literals. Given the code: char c = '\200'; The character literal is presently printed as: char c = '\Uff80'; The

r258457 - [OpenMP] Parsing + Sema for nowait clause on target enter data directive.

Author: arpith Date: Thu Jan 21 18:03:50 2016 New Revision: 258457 URL: http://llvm.org/viewvc/llvm-project?rev=258457=rev Log: [OpenMP] Parsing + Sema for nowait clause on target enter data directive. Summary: Accept nowait clause on target enter data directive in sema and add test cases.

Re: [PATCH] D16361: [OpenMP] Parsing + Sema for nowait clause on target enter data directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258457: [OpenMP] Parsing + Sema for nowait clause on target enter data directive. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16361?vs=45409=45610#toc Repository: rL LLVM

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

bcraig added a comment. LGTM. May want to wait on mclow though considering the trouble I helped cause with the last one of these. http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

dsanders added a comment. Thanks. > May want to wait on mclow though considering the trouble I helped cause with > the last one of these. Sure. That wasn't your fault though, it was mine. I should have asked for clarification first. http://reviews.llvm.org/D16408

Re: [PATCH] D13420: Fix deduction of __atomic_load's parameter types.

EricWF added a comment. ping. http://reviews.llvm.org/D13420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16310#332200, @danielmarjamaki wrote: > Why is there a cast in the first place? It is unlikely that the programmer > added a useless cast for no reason. If this has universally been your experience on a code base, then I say you

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! http://reviews.llvm.org/D16179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r258394 - [OPENMP] Fix crash on reduction for complex variables.

Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this should be merged to 3.8. Alexey, you're the code owner here. OK for merging? If yes, do you want to go ahead and merge with utils/release/merge.sh? On Thu, Jan 21, 2016 at 4:35 AM, Alexey Bataev via cfe-commits

Re: r258396 - Fix crash for typedefs for arrays of runtime bounds in Lambdas/Captured Statements, used in sizeof() expression only.

Richard, it was suggested (in https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged to 3.8. I believe this falls under your ownership. On Thu, Jan 21, 2016 at 4:54 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Thu Jan 21 06:54:48

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this should be merged to 3.8. Alexey, you're the code owner here. OK for merging? If yes, do you want to go ahead and merge with utils/release/merge.sh? On Wed, Jan 20, 2016 at 4:29 AM, Alexey Bataev via cfe-commits

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

LegalizeAdulthood added inline comments. Comment at: clang-tidy/misc/LongCastCheck.cpp:97 @@ +96,3 @@ + + if (!CastType->isIntegerType() || !SubType->isIntegerType()) +return; danielmarjamaki wrote: > LegalizeAdulthood wrote: > > Why don't you check for

Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

manmanren added a subscriber: manmanren. manmanren added a comment. Thanks for working on this. This looks good to me overall, but I am not the expert on Sema :] Cheers, Manman Comment at: lib/Sema/SemaChecking.cpp:6985 @@ -6984,6 +6984,3 @@ SmallString<16>

Re: [PATCH] D16375: [OpenMP] Sema for depend clause on target directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258460: [OpenMP] Sema for depend clause on target directive. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16375?vs=45447=45616#toc Repository: rL LLVM

r258460 - [OpenMP] Sema for depend clause on target directive.

Author: arpith Date: Thu Jan 21 18:49:21 2016 New Revision: 258460 URL: http://llvm.org/viewvc/llvm-project?rev=258460=rev Log: [OpenMP] Sema for depend clause on target directive. Summary: Accept depend clause on target directive in sema and add test cases. Reviewers: ABataev Differential

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. This needs tests showing that the IR gen/use passes get run. Maybe use -debug-pass=Structure like test/CodeGen/thinlto_backend.c? My biggest concern is the naming and user visible parts. I can't come up with anything better than `-fprofile-ir-instr` TBH. Overall, from a

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

silvas added a comment. For the preview of all the changes, can you please put that in a separate patch from this one? Repository: rL LLVM http://reviews.llvm.org/D15999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r258459 - [OpenMP] Parsing + Sema for nowait clause on target exit data directive.

Author: arpith Date: Thu Jan 21 18:22:05 2016 New Revision: 258459 URL: http://llvm.org/viewvc/llvm-project?rev=258459=rev Log: [OpenMP] Parsing + Sema for nowait clause on target exit data directive. Summary: Accept nowait clause on target exit data directive in sema and add test cases.

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv updated this revision to Diff 45622. george.burgess.iv added a comment. - Rebased - Removed bits that were already upstreamed as part of http://reviews.llvm.org/D14877 - Added support for LLVM's `allocsize` attribute (under review at http://reviews.llvm.org/D14933 )

[libcxxabi] r258469 - Merging r258249:

Author: ericwf Date: Thu Jan 21 19:12:23 2016 New Revision: 258469 URL: http://llvm.org/viewvc/llvm-project?rev=258469=rev Log: Merging r258249: r258249 | ericwf | 2016-01-19 16:42:10 -0700 (Tue, 19 Jan 2016) | 7 lines

[libcxxabi] r258470 - Merging r258277:

Author: ericwf Date: Thu Jan 21 19:13:27 2016 New Revision: 258470 URL: http://llvm.org/viewvc/llvm-project?rev=258470=rev Log: Merging r258277: r258277 | ericwf | 2016-01-19 20:04:50 -0700 (Tue, 19 Jan 2016) | 1 line Fix

Re: [libcxxabi] r258249 - Recommit r256322: Fix PR25898 - Check for incomplete pointers types in can_catch(...)

Hi Hans, CC Marshall FYI All my pending libc++ and libc++abi commits have been pushed to the release_38 branch. /Eric On Thu, Jan 21, 2016 at 1:51 PM, Eric Fiselier wrote: > I'll merge all my commits tonight. Thanks Hans. > > /Eric > > On Wed, Jan 20, 2016 at 10:38 AM, Hans

Re: [PATCH] D16177: Adding missing intrinsics _cvtsh_ss and _cvtss_sh

kromanova updated this revision to Diff 45632. kromanova marked an inline comment as done. kromanova added a comment. Updated patch to address Craig's comments. Repository: rL LLVM http://reviews.llvm.org/D16177 Files: lib/Headers/f16cintrin.h test/CodeGen/f16c-builtins.c Index:

Re: [PATCH] D16177: Adding missing intrinsics _cvtsh_ss and _cvtss_sh

kromanova marked an inline comment as done. Comment at: lib/Headers/f16cintrin.h:47 @@ -34,1 +46,3 @@ + + #define _mm_cvtps_ph(a, imm) __extension__ ({ \ craig.topper wrote: > Can we do something like this to remove the last temporary? > > #define _cvtss_sh(a,

Re: r258394 - [OPENMP] Fix crash on reduction for complex variables.

Ok, will do Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 22.01.2016 0:10, Hans Wennborg пишет: > Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that > this should be merged to 3.8. > > Alexey, you're the code owner here. OK for merging? If yes,

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

Later today I will post another fix, that will fix all 'sections' related troubles, including this one. So I don't think it is necessary to merge it Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 22.01.2016 0:10, Hans Wennborg пишет: > Jack suggested

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. @slingn and I had a discussion offline about the potential names and came up with some ideas, but none is a clear winner. Overall, my feeling is that from a user's perspective, the frontend stuff is probably best referred to as "coverage-based". It's not as clear for

Re: [PATCH] D16362: [OpenMP] Parsing + Sema for nowait clause on target exit data directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258459: [OpenMP] Parsing + Sema for nowait clause on target exit data directive. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16362?vs=45410=45614#toc Repository: rL LLVM

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.def:108 @@ -107,2 +107,3 @@ ///< execution counts to use with PGO. +CODEGENOPT(ProfileIRInstr, 1, 0) ///< IR level code PGO instrumentation and use.

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. @bogner btw, did you say that at Apple you guys have a requirement of supporting existing profdata? I.e. users can pass older profdata to a newer compiler? Realistically, it would be nice if our PGO offering defaulted to the IR stuff (since it seems like it is going to

Re: [PATCH] D5031: [analyzer] Remove duplicate test case from MissingDealloc.m

dcoughlin abandoned this revision. dcoughlin added a comment. Abandoning because the test-case removal was incorporated into http://reviews.llvm.org/D5023. http://reviews.llvm.org/D5031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r258461 - [analyzer] Suppress nullability warning for defensive super initializer idiom.

Author: dcoughlin Date: Thu Jan 21 19:01:11 2016 New Revision: 258461 URL: http://llvm.org/viewvc/llvm-project?rev=258461=rev Log: [analyzer] Suppress nullability warning for defensive super initializer idiom. A common idiom in Objective-C initializers is for a defensive nil-check on the result

[libcxx] r258467 - Merging r258198:

Author: ericwf Date: Thu Jan 21 19:10:25 2016 New Revision: 258467 URL: http://llvm.org/viewvc/llvm-project?rev=258467=rev Log: Merging r258198: r258198 | ericwf | 2016-01-19 14:58:49 -0700 (Tue, 19 Jan 2016) | 1 line Add

[libcxxabi] r258468 - Merging r258201:

Author: ericwf Date: Thu Jan 21 19:11:34 2016 New Revision: 258468 URL: http://llvm.org/viewvc/llvm-project?rev=258468=rev Log: Merging r258201: r258201 | ericwf | 2016-01-19 15:07:10 -0700 (Tue, 19 Jan 2016) | 1 line Add

r258476 - [Docs] Slightly update LSan documentation.

Author: samsonov Date: Thu Jan 21 19:35:45 2016 New Revision: 258476 URL: http://llvm.org/viewvc/llvm-project?rev=258476=rev Log: [Docs] Slightly update LSan documentation. Modified: cfe/trunk/docs/AddressSanitizer.rst cfe/trunk/docs/LeakSanitizer.rst Modified:

[PATCH] D16437: Fix printing of enum casts with suppressed tags

nick.sumner created this revision. nick.sumner added reviewers: bkramer, rsmith. nick.sumner added a subscriber: cfe-commits. Allow C style casts of enums to be printed correctly when the incoming PrintingPolicy suppresses tags. This can happen, when casts to enums occur during the

Re: [PATCH] D12354: [libcxx] Add global assertion handler for debug mode.

EricWF added a comment. In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote: > This patch looks correct to me. Is there any reason it wasn't committed? I was concerned about using a function-local static in the library headers, I don't think libc++ does that anywhere else and I

Re: [PATCH] D16177: Adding missing intrinsics _cvtsh_ss and _cvtss_sh

kromanova updated this revision to Diff 45635. kromanova marked an inline comment as done. kromanova added a comment. I further simplified the macros by removing the statement for the define that I added (_cvtss_sh) and for the one that was there before (_mm_cvtps_ph). I also formatted

[PATCH] D16444: AMDGPU: Rename builtins to use amdgcn prefix

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. Keep the one still used by libclc that works around for now. Emit the new amdgcn intrinsic name if not targeting r600, in which case the old AMDGPU name is still used.

[libcxx] r258464 - Merging r258196:

Author: ericwf Date: Thu Jan 21 19:09:23 2016 New Revision: 258464 URL: http://llvm.org/viewvc/llvm-project?rev=258464=rev Log: Merging r258196: r258196 | ericwf | 2016-01-19 14:52:04 -0700 (Tue, 19 Jan 2016) | 1 line Add

r258466 - [OpenMP] Sema for depend clause on target enter data directive.

Author: arpith Date: Thu Jan 21 19:09:37 2016 New Revision: 258466 URL: http://llvm.org/viewvc/llvm-project?rev=258466=rev Log: [OpenMP] Sema for depend clause on target enter data directive. Summary: Accept depend clause on target enter data directive in sema and add test cases. Reviewers:

  1   2   >