Re: [PATCH] D16708: Add a new attribute CFNoRelease.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. It's a bit strange to add an attribute that has absolutely no semantic effect whatsoever. Where is this attribute intended to be queried within the compiler? Are there

Re: [PATCH] D16721: [clang-tidy] Move implicit-cast-in-loop check to upstream.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. I'll fix and commit the patch. Thank you! Comment at: clang-tidy/performance/ImplicitCastInLoopCheck.cpp:79 @@ +78,3 @@ + // code at the end). +

r259194 - Removing unnecessary casts; NFC.

Author: aaronballman Date: Fri Jan 29 07:53:26 2016 New Revision: 259194 URL: http://llvm.org/viewvc/llvm-project?rev=259194=rev Log: Removing unnecessary casts; NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp URL:

[libcxx] r259193 - [libcxx] Whitelist inclusion of sysctl.h instead of blacklisting

Author: bcraig Date: Fri Jan 29 07:53:23 2016 New Revision: 259193 URL: http://llvm.org/viewvc/llvm-project?rev=259193=rev Log: [libcxx] Whitelist inclusion of sysctl.h instead of blacklisting Instead of excluding all known operating systems that are not derived from BSD, I now include all

Re: [PATCH] D16721: [clang-tidy] Move implicit-cast-in-loop check to upstream.

alexfh added inline comments. Comment at: test/clang-tidy/performance_implicit_cast_in_loop.cpp:1 @@ +1,2 @@ +// RUN: %check_clang_tidy %s performance-implicit-cast-in-loop %t + Also, the name should use dashes, not underscores. I'll fix this as well.

Re: [PATCH] D16587: Fixed function params comparison. Updated docs and tests.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! I'll commit the patch for you. http://reviews.llvm.org/D16587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

Author: yrnkrn Date: Fri Jan 29 07:46:15 2016 New Revision: 259192 URL: http://llvm.org/viewvc/llvm-project?rev=259192=rev Log: Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump(). Modified: cfe/trunk/include/clang/AST/TemplateBase.h

[clang-tools-extra] r259197 - Fixed function params comparison. Updated docs and tests.

Author: alexfh Date: Fri Jan 29 09:22:10 2016 New Revision: 259197 URL: http://llvm.org/viewvc/llvm-project?rev=259197=rev Log: Fixed function params comparison. Updated docs and tests. Summary: "checkParamTypes" may fail if the the type of some parameter is not canonical. Fixed it by comparing

Re: [PATCH] D16587: Fixed function params comparison. Updated docs and tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259197: Fixed function params comparison. Updated docs and tests. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D16587?vs=46360=46382#toc Repository: rL LLVM

[clang-tools-extra] r259195 - [clang-tidy] Move implicit-cast-in-loop check to upstream.

Author: alexfh Date: Fri Jan 29 09:21:32 2016 New Revision: 259195 URL: http://llvm.org/viewvc/llvm-project?rev=259195=rev Log: [clang-tidy] Move implicit-cast-in-loop check to upstream. Summary: This is implemented originally by Alex Pilkiewicz (pi...@google.com). Reviewers: alexfh

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

vkalintiris added a comment. Is this okay to commit with the updated changes? http://reviews.llvm.org/D16613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16718: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

bkramer updated this revision to Diff 46370. bkramer added a comment. Fix comment. http://reviews.llvm.org/D16718 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp unittests/ASTMatchers/ASTMatchersTest.h Index: unittests/ASTMatchers/ASTMatchersTest.h

[PATCH] D16718: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This can be used as a way to modify argv[0] for a clang tool. http://reviews.llvm.org/D16718 Files: include/clang/Tooling/Tooling.h

Re: [PATCH] D16718: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D16718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16718: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259187: Add an optional ToolName argument to… (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D16718?vs=46370=46372#toc Repository: rL LLVM http://reviews.llvm.org/D16718

Re: [PATCH] D15603: [OpenCL] Pipe type support

uweigand added a comment. In http://reviews.llvm.org/D15603#338593, @Anastasia wrote: > Yes, I see that it happens only for some vector types. The CodeGen follows > quite different paths for both targets. And in the case of s390x-linux-gnu it > ends up in ABIArgInfo::Indirect case of the

r259187 - Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs.

Author: d0k Date: Fri Jan 29 05:29:02 2016 New Revision: 259187 URL: http://llvm.org/viewvc/llvm-project?rev=259187=rev Log: Add an optional ToolName argument to runToolOnCodeWithArgs/buildASTFromCodeWithArgs. This can be used as a way to modify argv[0] for a clang tool. Differential Revision:

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

bkramer added a subscriber: bkramer. bkramer added a comment. Why are you re-adding all those Makefiles? http://reviews.llvm.org/D16529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16721: [clang-tidy] Move implicit-cast-in-loop check to upstream.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259195: [clang-tidy] Move implicit-cast-in-loop check to upstream. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D16721?vs=46377=46381#toc Repository: rL LLVM

[clang-tools-extra] r259198 - [clang-tidy] Fix minor style issues. NFC

Author: alexfh Date: Fri Jan 29 09:22:20 2016 New Revision: 259198 URL: http://llvm.org/viewvc/llvm-project?rev=259198=rev Log: [clang-tidy] Fix minor style issues. NFC Modified: clang-tools-extra/trunk/clang-tidy/misc/VirtualNearMissCheck.cpp

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16529#339192, @bkramer wrote: > Why are you re-adding all those Makefiles? Ugh, I didn't even notice they were in there. It must have errantly slipped in from rebasing. http://reviews.llvm.org/D16529

[clang-tools-extra] r259199 - [clang-tidy] ForRangeCopyCheck that warns on and fixes unnecessary copies of loop variables.

Author: alexfh Date: Fri Jan 29 09:54:26 2016 New Revision: 259199 URL: http://llvm.org/viewvc/llvm-project?rev=259199=rev Log: [clang-tidy] ForRangeCopyCheck that warns on and fixes unnecessary copies of loop variables. Patch by Felix Berger! Differential revision:

Re: [PATCH] D8149: Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood added a comment. If someone could commit this for me, that would be great. I do not have commit access. Patch by Richard Thomson http://reviews.llvm.org/D8149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r259196 - [clang-tidy] Fix style issues. NFC

Author: alexfh Date: Fri Jan 29 09:21:43 2016 New Revision: 259196 URL: http://llvm.org/viewvc/llvm-project?rev=259196=rev Log: [clang-tidy] Fix style issues. NFC Added: clang-tools-extra/trunk/test/clang-tidy/performance-implicit-cast-in-loop.cpp - copied, changed from r259195,

Re: [PATCH] D16692: [OpenCL] Eliminate warning when declaring OpenCL builtin functions

yaxunl updated this revision to Diff 46395. yaxunl marked an inline comment as done. yaxunl added a comment. revised as Anastasia suggested. http://reviews.llvm.org/D16692 Files: lib/Sema/SemaLookup.cpp test/SemaOpenCL/builtin.cl Index: test/SemaOpenCL/builtin.cl

Re: [PATCH] D16692: [OpenCL] Eliminate warning when declaring OpenCL builtin functions

Anastasia added inline comments. Comment at: lib/Sema/SemaLookup.cpp:698 @@ +697,3 @@ +// tgmath.h, time.h, wchar.h and wctype.h are not available and cannot +// be included by a program. +if (S.getLangOpts().OpenCL && pxli168 wrote: > I

Re: [PATCH] D16697: Updating .debug_line section version information to match DWARF version.

> > There is now a public bot that runs the LLDB testsuite on Darwin > (http://lab.llvm.org:8080/green/job/LLDB/) so you’ll find out immediately :-) > LLDB can be fixed, I’m not too worried about it. > > There are, however, also DWARF consumers that are not debuggers that will > read the line

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: include/clang/Basic/Attr.td:661 @@ +660,3 @@ + let Args = [UnsignedArgument<"UnrollHint">]; + let Documentation = [Undocumented]; +} I think undocumented is not allowed any longer. I suggest you to check

Re: [PATCH] D8149: Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit as r259210. http://reviews.llvm.org/D8149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259210 - Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes.

Author: aaronballman Date: Fri Jan 29 11:03:11 2016 New Revision: 259210 URL: http://llvm.org/viewvc/llvm-project?rev=259210=rev Log: Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes.

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur updated this revision to Diff 46389. xur added a comment. This new patch adds the change the clang test cases (cc1 option -fprofile-instr-generate to -fprofile-instrument=Clang). It also replaces cc1 option -fprofile-instr-generate= to -fprofile-instrument-path=, as suggested by David.

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

On 29 Jan 2016 5:50 a.m., "Yaron Keren via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > Author: yrnkrn > Date: Fri Jan 29 07:46:15 2016 > New Revision: 259192 > > URL: http://llvm.org/viewvc/llvm-project?rev=259192=rev > Log: > Implement TemplateArgument::dump() method for debugging,

[clang-tools-extra] r259214 - [clang-tidy] Don't use delegating constructors, since they are not supported by MSVC 2013

Author: alexfh Date: Fri Jan 29 11:35:53 2016 New Revision: 259214 URL: http://llvm.org/viewvc/llvm-project?rev=259214=rev Log: [clang-tidy] Don't use delegating constructors, since they are not supported by MSVC 2013 Modified:

Re: [PATCH] D16694: [llvmlab] Enable clang tests that output to the console when we are on the buildbots

gkistanova added a comment. LGTM Thanks Galina http://reviews.llvm.org/D16694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r259210 - Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes.

In article , Aaron Ballman writes: > On Fri, Jan 29, 2016 at 1:28 PM, Hans Wennborg wrote: > > This broke tests: > > > >

Re: r259260 - [UBSan] Add documentation for runtime issue suppression.

Yes, that seems like a good idea. Go ahead and merge (or let me know if you'd prefer me to do it). On Fri, Jan 29, 2016 at 3:14 PM, Alexey Samsonov wrote: > Hans, do you think it makes sense to merge this patch into 3.8? > > On Fri, Jan 29, 2016 at 3:07 PM, Alexey Samsonov

r259271 - Improve -Wconstant-conversion

Author: rtrieu Date: Fri Jan 29 17:51:16 2016 New Revision: 259271 URL: http://llvm.org/viewvc/llvm-project?rev=259271=rev Log: Improve -Wconstant-conversion Switch the evaluation from isIntegerConstantExpr to EvaluateAsInt. EvaluateAsInt will evaluate more types of expressions than

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

yaxunl updated this revision to Diff 46434. yaxunl marked 17 inline comments as done. yaxunl added a comment. Revised as Anastasia and Xiuli suggested. http://reviews.llvm.org/D16686 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D16562: Adding doxygen comments to the LLVM intrinsics (part 3, __wmmintrin_aes.h)

This revision was automatically updated to reflect the committed changes. Closed by commit rL259275: This patch adds doxygen comments for the intrinsincs in the header file… (authored by kromanova). Changed prior to commit: http://reviews.llvm.org/D16562?vs=45924=46447#toc Repository: rL

r259275 - This patch adds doxygen comments for the intrinsincs in the header file __wmmintrin_aes.h.

Author: kromanova Date: Fri Jan 29 17:59:00 2016 New Revision: 259275 URL: http://llvm.org/viewvc/llvm-project?rev=259275=rev Log: This patch adds doxygen comments for the intrinsincs in the header file __wmmintrin_aes.h. The doxygen comments are automatically generated based on Sony's

Re: [PATCH] D16738: Fix invalid casts in .

EricWF added a comment. > This code triggers CFI warnings. What are CFI warnings? Sorry if that's a dumb question, I just don't recognize "CFI". Repository: rL LLVM http://reviews.llvm.org/D16738 ___ cfe-commits mailing list

Re: r259260 - [UBSan] Add documentation for runtime issue suppression.

Hans, do you think it makes sense to merge this patch into 3.8? On Fri, Jan 29, 2016 at 3:07 PM, Alexey Samsonov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: samsonov > Date: Fri Jan 29 17:07:14 2016 > New Revision: 259260 > > URL:

r259267 - Class Property: generate metadata for class properties in categories.

Author: mren Date: Fri Jan 29 17:45:01 2016 New Revision: 259267 URL: http://llvm.org/viewvc/llvm-project?rev=259267=rev Log: Class Property: generate metadata for class properties in categories. The list of class properties is saved in Old ABI: category->class_properties (category->size will be

[PATCH] D16738: Fix invalid casts in .

eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added subscribers: cfe-commits, pcc. eugenis set the repository for this revision to rL LLVM. static_cast of a pointer to object before the start of the object's lifetime has undefined behavior (c++14 p3.8) This

Re: [PATCH] D16705: Avoid overly large SmallPtrSet/SmallSet

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric Repository: rL LLVM http://reviews.llvm.org/D16705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

jlebar added a comment. Talking to echristo irl, he would like to know why we don't have this problem with mac universal binaries -- or, do we? He would like to be consistent; I'm onboard with that. http://reviews.llvm.org/D16514 ___ cfe-commits

r259287 - [SemaCXX] Fix crash-on-invalid while trying to deduce return type of a lambda.

Author: akirtzidis Date: Fri Jan 29 19:51:20 2016 New Revision: 259287 URL: http://llvm.org/viewvc/llvm-project?rev=259287=rev Log: [SemaCXX] Fix crash-on-invalid while trying to deduce return type of a lambda. rdar://22032373 Modified: cfe/trunk/lib/Sema/SemaStmt.cpp

Re: [PATCH] D16694: [llvmlab] Enable clang tests that output to the console when we are on the buildbots

This revision was automatically updated to reflect the committed changes. Closed by commit rL259248: [llvmlab] Enable clang tests that output to the console when we are on the… (authored by ygao). Changed prior to commit: http://reviews.llvm.org/D16694?vs=46313=46431#toc Repository: rL LLVM

r259268 - Class Property: generate metadata for class properties in protocols.

Author: mren Date: Fri Jan 29 17:46:55 2016 New Revision: 259268 URL: http://llvm.org/viewvc/llvm-project?rev=259268=rev Log: Class Property: generate metadata for class properties in protocols. The list of class properties is saved in Old ABI: protocol->ext->class_properties

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

jlebar added a comment. jingyue/jpienaar/rsmith - friendly ping? Without this, -O0 builds don't work, because they emit empty global initializers that don't get optimized out. http://reviews.llvm.org/D15305 ___ cfe-commits mailing list

Re: [PATCH] D15705: Adding a scripted test for PR25717

ygao closed this revision. ygao added a comment. The test is commited in http://reviews.llvm.org/rL258898 and http://reviews.llvm.org/rL258902, and it is enabled on buildbot in http://reviews.llvm.org/rL259248. Thanks! http://reviews.llvm.org/D15705

Re: [PATCH] D16738: Fix invalid casts in .

eugenis added a comment. http://clang.llvm.org/docs/ControlFlowIntegrity.html Basically it says that the cast to __base is done on a memory that does not contain an object of type __base (based on the vptr value). Repository: rL LLVM http://reviews.llvm.org/D16738

Re: [PATCH] D16705: Avoid overly large SmallPtrSet/SmallSet

This revision was automatically updated to reflect the committed changes. Closed by commit rL259284: Avoid overly large SmallPtrSet/SmallSet (authored by matze). Changed prior to commit: http://reviews.llvm.org/D16705?vs=46337=46457#toc Repository: rL LLVM http://reviews.llvm.org/D16705

r259284 - Avoid overly large SmallPtrSet/SmallSet

Author: matze Date: Fri Jan 29 19:27:06 2016 New Revision: 259284 URL: http://llvm.org/viewvc/llvm-project?rev=259284=rev Log: Avoid overly large SmallPtrSet/SmallSet These sets perform linear searching in small mode so it is never a good idea to use SmallSize/N bigger than 32. Differential

r259288 - [analyzer] Make suppression of macro defensive checks work with -analyzer-eagerly-assume.

Author: dcoughlin Date: Fri Jan 29 19:59:33 2016 New Revision: 259288 URL: http://llvm.org/viewvc/llvm-project?rev=259288=rev Log: [analyzer] Make suppression of macro defensive checks work with -analyzer-eagerly-assume. This is the default for the analyzer but the flag is added by the driver

Re: r259260 - [UBSan] Add documentation for runtime issue suppression.

On Fri, Jan 29, 2016 at 3:16 PM, Hans Wennborg wrote: > Yes, that seems like a good idea. Go ahead and merge (or let me know > if you'd prefer me to do it). > I'd appreciate if you could do it. Thanks! > > On Fri, Jan 29, 2016 at 3:14 PM, Alexey Samsonov

r259260 - [UBSan] Add documentation for runtime issue suppression.

Author: samsonov Date: Fri Jan 29 17:07:14 2016 New Revision: 259260 URL: http://llvm.org/viewvc/llvm-project?rev=259260=rev Log: [UBSan] Add documentation for runtime issue suppression. Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified:

LLVM buildmaster will be restarted in few minutes.

Hello everyone, LLVM buildmaster will be restarted in few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

rtrieu added a comment. Not sure what happened. Will check it out on Monday. http://reviews.llvm.org/D3976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16063: [Analyzer] Use a wider integer type for an array index

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks like all of Gabor's comments were addressed. LGTM. Thank you! http://reviews.llvm.org/D16063 ___ cfe-commits mailing list

[clang-tools-extra] r259289 - test/clang-tidy/performance-for-range-copy.cpp: Appease for targeting ms mode.

Author: chapuni Date: Fri Jan 29 20:15:19 2016 New Revision: 259289 URL: http://llvm.org/viewvc/llvm-project?rev=259289=rev Log: test/clang-tidy/performance-for-range-copy.cpp: Appease for targeting ms mode. Modified: clang-tools-extra/trunk/test/clang-tidy/performance-for-range-copy.cpp

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

LegalizeAdulthood marked 2 inline comments as done. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:77 @@ -74,3 +76,3 @@ /// implicit conversion of `i & 1` to `bool` and becomes -/// `bool b = static_cast(i & 1);`. +/// `bool b = i & 1 != 0;`. ///

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added a comment. Hi Alexander, Sorry for the delay! The patch should be rebased from the clang repo; for example, you could run "svn diff" from the clang directory. More comments inline. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:75 @@ -74,1

Re: [PATCH] D8149: Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood updated this revision to Diff 46464. LegalizeAdulthood added a comment. Fix RegistryTest unit test make check-all passes http://reviews.llvm.org/D8149 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D8149: Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood added a comment. It seems that phabricator hasn't been configured to allow me to reopen the revision, but I've updated the diff. http://reviews.llvm.org/D8149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

jlebar added a comment. Eric, are you OK with this going in, or do you want to consider alternatives? http://reviews.llvm.org/D16514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16562: Adding doxygen comments to the LLVM intrinsics (part 3, __wmmintrin_aes.h)

kromanova added a comment. Hi Eric, Could you please accept this revision also? I have already added missing article "the" in "This intrinsic corresponds to instruction" (as you requested in the other doxygen comments review). Thank you! Katya. Repository: rL LLVM

Re: [PATCH] D16562: Adding doxygen comments to the LLVM intrinsics (part 3, __wmmintrin_aes.h)

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. Yep. :) Repository: rL LLVM http://reviews.llvm.org/D16562 ___ cfe-commits mailing list

Re: r259210 - Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes.

This broke tests: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/44018/steps/test_clang/logs/Clang-Unit%20%3A%3A%20ASTMatchers__Dynamic__DynamicASTMatchersTests__RegistryTest.Errors I've reverted it in r259218. Thanks, Hans On Fri, Jan 29, 2016 at 9:03 AM, Aaron Ballman via

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

On 1/29/16 11:51 AM, Serge Pavlov via cfe-commits wrote: Can somebody have a look at this fix? Thank you! Testcase? --Serge 2016-01-11 23:50 GMT+06:00 Serge Pavlov >: Any feedback? Thanks, --Serge 2015-12-11 20:24

r259224 - Class Property: parse @dynamic (class).

Author: mren Date: Fri Jan 29 13:05:57 2016 New Revision: 259224 URL: http://llvm.org/viewvc/llvm-project?rev=259224=rev Log: Class Property: parse @dynamic (class). rdar://23891898 Modified: cfe/trunk/lib/Parse/ParseObjc.cpp cfe/trunk/test/SemaObjC/objc-class-property.m Modified:

r259229 - Class Property: generate metadata for class properties in classes.

Author: mren Date: Fri Jan 29 13:22:54 2016 New Revision: 259229 URL: http://llvm.org/viewvc/llvm-project?rev=259229=rev Log: Class Property: generate metadata for class properties in classes. The list of class properties is saved in Old ABI: cls->isa->ext->properties New ABI:

r259218 - Revert r259210 "Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes."

Author: hans Date: Fri Jan 29 12:24:34 2016 New Revision: 259218 URL: http://llvm.org/viewvc/llvm-project?rev=259218=rev Log: Revert r259210 "Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

OK. There are more un-annotated dump() methods such as TemplateName::dump(), NestedNameSpecifier::dump(), ASTReader::dump(), ModuleMap::dump(), MacroInfo::dump(), ... Annotate all dump() methods LLVM_DUMP_METHOD ? 2016-01-29 19:37 GMT+02:00 Richard Smith : > On 29 Jan

r259226 - Class Property: warn for synthesize on a class property.

Author: mren Date: Fri Jan 29 13:16:39 2016 New Revision: 259226 URL: http://llvm.org/viewvc/llvm-project?rev=259226=rev Log: Class Property: warn for synthesize on a class property. rdar://23891898 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

On Fri, Jan 29, 2016 at 11:13 AM, Yaron Keren wrote: > OK. There are more un-annotated dump() methods such as > TemplateName::dump(), NestedNameSpecifier::dump(), ASTReader::dump(), > ModuleMap::dump(), MacroInfo::dump(), ... > > Annotate all dump() methods

Re: r259210 - Extend hasType narrowing matcher for TypedefDecls, add functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes.

On Fri, Jan 29, 2016 at 1:28 PM, Hans Wennborg wrote: > This broke tests: > > http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/44018/steps/test_clang/logs/Clang-Unit%20%3A%3A%20ASTMatchers__Dynamic__DynamicASTMatchersTests__RegistryTest.Errors > > I've reverted it in

r259221 - [analyzer] Improve Nullability checker diagnostics

Author: zaks Date: Fri Jan 29 12:43:15 2016 New Revision: 259221 URL: http://llvm.org/viewvc/llvm-project?rev=259221=rev Log: [analyzer] Improve Nullability checker diagnostics - Include the position of the argument on which the nullability is violated - Differentiate between a 'method' and a

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

Can somebody have a look at this fix? Thank you! --Serge 2016-01-11 23:50 GMT+06:00 Serge Pavlov : > Any feedback? > > Thanks, > --Serge > > 2015-12-11 20:24 GMT+06:00 Serge Pavlov : > >> sepavloff created this revision. >> sepavloff added a subscriber:

r259222 - [analyzer] Suppress null reports from defensive checks in function-like macros.

Author: dcoughlin Date: Fri Jan 29 12:47:13 2016 New Revision: 259222 URL: http://llvm.org/viewvc/llvm-project?rev=259222=rev Log: [analyzer] Suppress null reports from defensive checks in function-like macros. We already do this for case splits introduced as a result of defensive null checks in

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur added a comment. To make the review easier, I split the cc1 names change part into a new NFC patch here. http://reviews.llvm.org/D16730 http://reviews.llvm.org/D15829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r259232 - Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment.

Author: yrnkrn Date: Fri Jan 29 13:38:18 2016 New Revision: 259232 URL: http://llvm.org/viewvc/llvm-project?rev=259232=rev Log: Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment. Modified: cfe/trunk/lib/AST/APValue.cpp

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

On 1/29/16 12:50 PM, Serge Pavlov wrote: Crash is observed when HandleTranslation unit is not called, clang always calls this method but a clang based project may don't call it if it is not needed. I saw the crash in such project and used this patch to fix it. I do not know how to make a

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

Crash is observed when HandleTranslation unit is not called, clang always calls this method but a clang based project may don't call it if it is not needed. I saw the crash in such project and used this patch to fix it. I do not know how to make a regression test, I am not even sure such test

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

This revision was automatically updated to reflect the committed changes. Closed by commit rL259239: This patch adds doxygen comments for the intrinsincs in the header file… (authored by kromanova). Changed prior to commit: http://reviews.llvm.org/D15999?vs=45902=46411#toc Repository: rL

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me. Test case could be simplified a bit further, but feel free to commit after that. Comment at: lib/CodeGen/CGDebugInfo.cpp:1479 @@ +1478,3 @@ +void

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

Committed clang part in r259232, LLVM part in r259240. 2016-01-29 21:22 GMT+02:00 Richard Smith : > On Fri, Jan 29, 2016 at 11:13 AM, Yaron Keren > wrote: > > OK. There are more un-annotated dump() methods such as > > TemplateName::dump(),

r259239 - This patch adds doxygen comments for the intrinsincs in the header file __wmmintrin_pclmul.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

Author: kromanova Date: Fri Jan 29 14:37:14 2016 New Revision: 259239 URL: http://llvm.org/viewvc/llvm-project?rev=259239=rev Log: This patch adds doxygen comments for the intrinsincs in the header file __wmmintrin_pclmul.h. The doxygen comments are automatically generated based on Sony's

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#337144, @nemanjai wrote: > Do you suggest that we need to allow operations (or at least assignments) > between the two types and take away the diagnostics that are part of this > patch? It appears that the conclusion