[clang-tools-extra] r260107 - [clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert.

Author: hokein Date: Mon Feb 8 09:59:42 2016 New Revision: 260107 URL: http://llvm.org/viewvc/llvm-project?rev=260107=rev Log: [clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added inline comments. Comment at: test/clang-tidy/misc-virtual-near-miss.cpp:1 @@ -1,2 +1,2 @@ // RUN: %check_clang_tidy %s misc-virtual-near-miss %t The check shouldn't make any changes to template classes based on any single instantiation. An easy

Re: [PATCH] D16979: [clang-tidy] Some improvements in 'misc-definitions-in-headers' check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260108: [clang-tidy] Some improvements in 'misc-definitions-in-headers' check. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D16979?vs=47178=47205#toc Repository: rL LLVM

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 8:15 AM, Jonathan Wakely wrote: > On 8 February 2016 at 16:05, H.J. Lu wrote: >> My understanding is >> >> A type that is standard-layout means that it orders and packs its >> members in a way that is compatible with C. >> >> What is the corresponding

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 7:02 AM, Jonathan Wakely wrote: > On 8 February 2016 at 13:54, H.J. Lu wrote: >> On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote: >> >> The standard-layout POD is well defined: >> >>

[clang-tools-extra] r260108 - [clang-tidy] Some improvements in 'misc-definitions-in-headers' check.

Author: hokein Date: Mon Feb 8 10:05:39 2016 New Revision: 260108 URL: http://llvm.org/viewvc/llvm-project?rev=260108=rev Log: [clang-tidy] Some improvements in 'misc-definitions-in-headers' check. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 16:05, H.J. Lu wrote: > My understanding is > > A type that is standard-layout means that it orders and packs its > members in a way that is compatible with C. > > What is the corresponding compatible type in C? An empty structure, such as struct A. One of the requirements

Re: [clang-tools-extra] r260108 - [clang-tidy] Some improvements in 'misc-definitions-in-headers' check.

On Mon, Feb 8, 2016 at 11:05 AM, Haojian Wu via cfe-commits wrote: > Author: hokein > Date: Mon Feb 8 10:05:39 2016 > New Revision: 260108 > > URL: http://llvm.org/viewvc/llvm-project?rev=260108=rev > Log: > [clang-tidy] Some improvements in

Re: [PATCH] D16953: Enhance clang-tidy modernize-redundant-void-arg check to apply fixes to header files

alexfh added a comment. Hi Richard, Thank you for working on this. The script has been begging for refactoring for a while ;) A couple of initial comments, and while I'm looking further into into this patch, could you find other possible usages (in currently existing tests) of the new

Re: [PATCH] D16926: [clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260107: [clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D16926?vs=47019=47204#toc Repository: rL

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

alexfh added a comment. Sorry for the long delay. Currently rather swamped. Haojian, could you take a look at this patch? http://reviews.llvm.org/D16535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16993: Add documentation for bitreverse builtins

arsenm created this revision. arsenm added a subscriber: cfe-commits. Description copied from intrinsic http://reviews.llvm.org/D16993 Files: docs/LanguageExtensions.rst Index: docs/LanguageExtensions.rst === ---

Re: [PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

ayartsev added a comment. Ping. http://reviews.llvm.org/D16317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely wrote: > On 8 February 2016 at 15:42, H.J. Lu wrote: >> On Mon, Feb 8, 2016 at 7:02 AM, Jonathan Wakely >> wrote: >>> On 8 February 2016 at 13:54, H.J. Lu

Re: [PATCH] D16524: [clang-format-vs] Fix sort include main include: Use current path for the '-assume-filename'

jeanphilippeD added a comment. Ping, Hi Daniel, Sorry, should I have put someone else as reviewer, I see the previous committers for this file where Manuel Klimek, Hans Wennborg and Marek Kurdej. Should have i added any or all of them. I thought it made sense to put you originally since you

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 15:42, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 7:02 AM, Jonathan Wakely wrote: >> On 8 February 2016 at 13:54, H.J. Lu wrote: >>> On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote: >>> >>>

Re: [PATCH] D16987: [clang-tidy] Correct IncorrectRoundings namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260105: [clang-tidy] Correct IncorrectRoundings namespace. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D16987?vs=47199=47202#toc Repository: rL LLVM

[PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff created this revision. sepavloff added a reviewer: rsmith. sepavloff added a subscriber: cfe-commits. Previously if a file-level function was defined inside befriending template class, it was treated as defined in the code like: ``` void func(int); template class C1 { friend

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood added a comment. I wrote: > Repeated searching of the string for the literal delimiter could be avoided > by changing the routine to search for the delimiter. If present, it could > examine the characters following the literal to make the literal more unique > and then

r260104 - Move static functions returning UDTs outside of the extern "C" block. Silences an MSVC warning, and reduces the number of exported symbols.

Author: aaronballman Date: Mon Feb 8 09:52:13 2016 New Revision: 260104 URL: http://llvm.org/viewvc/llvm-project?rev=260104=rev Log: Move static functions returning UDTs outside of the extern "C" block. Silences an MSVC warning, and reduces the number of exported symbols. Modified:

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good after fixing capitalization in comments. Thank you! Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:32 @@ +31,3 @@ +

Re: [PATCH] D16987: [clang-tidy] Correct IncorrectRoundings namespace.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D16987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r260106 - Re-apply for the 2nd-time r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

Author: sfantao Date: Mon Feb 8 09:59:20 2016 New Revision: 260106 URL: http://llvm.org/viewvc/llvm-project?rev=260106=rev Log: Re-apply for the 2nd-time r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices. This was reverted by r260036, but was not the

[clang-tools-extra] r260105 - [clang-tidy] Correct IncorrectRoundings namespace.

Author: hokein Date: Mon Feb 8 09:54:30 2016 New Revision: 260105 URL: http://llvm.org/viewvc/llvm-project?rev=260105=rev Log: [clang-tidy] Correct IncorrectRoundings namespace. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D16987 Modified:

Re: [PATCH] D16953: Enhance clang-tidy modernize-redundant-void-arg check to apply fixes to header files

LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:122 @@ -40,2 +121,3 @@ parser.add_argument('-resource-dir') + parser.add_argument('--header-filter') parser.add_argument('input_file_name') alexfh wrote: > There's no

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

The test is incompatible to i686-pc-win32. See also http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/5498 On Mon, Feb 8, 2016 at 6:33 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev > Date: Mon Feb 8 03:29:13 2016 > New Revision: 260077 > > URL:

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

a.sidorin added inline comments. Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:792 @@ +791,3 @@ + +const MemRegion* MemRegionManager::getMemSpaceForLocalVariable(const VarDecl *D, llvm::PointerUnion ) { + const StackFrameContext *STC = V.get();

Re: [PATCH] D16764: [clang-tidy] Move incorrect-roundings to upstream.

hokein updated this revision to Diff 47167. hokein marked 2 inline comments as done. hokein added a comment. Update test. http://reviews.llvm.org/D16764 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/IncorrectRoundings.cpp clang-tidy/misc/IncorrectRoundings.h

[clang-tools-extra] r260084 - [clang-tidy] Move incorrect-roundings to upstream.

Author: hokein Date: Mon Feb 8 04:16:13 2016 New Revision: 260084 URL: http://llvm.org/viewvc/llvm-project?rev=260084=rev Log: [clang-tidy] Move incorrect-roundings to upstream. Summary: This is originally implemented by Jacques Pienaar. Reviewers: alexfh Subscribers: cfe-commits, jpienaar

Re: [PATCH] D16764: [clang-tidy] Move incorrect-roundings to upstream.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260084: [clang-tidy] Move incorrect-roundings to upstream. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D16764?vs=47167=47169#toc Repository: rL LLVM

Re: [PATCH]: git-clang-format

I believe you forgot to add cfe-commits as subscriber on the patch. On Sun, Feb 7, 2016 at 12:51 PM Alexander Shukaev < cl...@alexander.shukaev.name> wrote: > On 12/14/2015 10:03 PM, Alexander Shukaev wrote: > > On 12/11/2015 04:40 PM, Daniel Jasper wrote: > >> Please submit patches to

r260080 - clang-format: Fix weird alignment when not aligning after brackets.

Author: djasper Date: Mon Feb 8 03:52:54 2016 New Revision: 260080 URL: http://llvm.org/viewvc/llvm-project?rev=260080=rev Log: clang-format: Fix weird alignment when not aligning after brackets. Before: (, // ccc(a, //

Re: [PATCH] D15040: [ARM] Add command-line options for ARMv8.2-A

olista01 added a comment. Ping? http://reviews.llvm.org/D15040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx added inline comments. Comment at: clang-tidy/misc/UninitializedFieldCheck.cpp:178 @@ +177,3 @@ + + SmallPtrSet FieldsToInit; + fieldsRequiringInit(MemberFields, FieldsToInit); alexfh wrote: > What about this? (relates to line 184 now) My comment on this

r260189 - Remove 'llvm::TrailingObjects::operator delete', clang side.

Author: rsmith Date: Mon Feb 8 19:57:24 2016 New Revision: 260189 URL: http://llvm.org/viewvc/llvm-project?rev=260189=rev Log: Remove 'llvm::TrailingObjects::operator delete', clang side. Modified: cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h Modified:

[libcxx] r260202 - Minor updates to failing tests. NFC

Author: marshall Date: Tue Feb 9 00:38:56 2016 New Revision: 260202 URL: http://llvm.org/viewvc/llvm-project?rev=260202=rev Log: Minor updates to failing tests. NFC Modified: libcxx/trunk/test/std/input.output/iostream.format/quoted.manip/quoted_char.fail.cpp

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx updated this revision to Diff 47280. flx added a comment. Renamed the check to: cppcoreguidelines-pro-type-member-init, note the extra dash between member and init to be consistent with the camelcase notation of the class name ProTypeMemberInitCheck. http://reviews.llvm.org/D16517 Files:

Re: r260048 - [Frontend] Make the memory management of FrontendAction pointers explicit by using unique_ptr.

Interesting, it seems that libTooling is decoupled from the particular API changes in r260048. > On Feb 8, 2016, at 5:39 PM, David Blaikie wrote: > > FWIW, I tried to do something like this, perhaps with some other > improvements, a few years ago. Not sure if things have

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

ariccio updated this revision to Diff 47289. http://reviews.llvm.org/D16873 Files: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp Index:

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Ping http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Ping http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 9:00 PM, Xinliang David Li wrote: > On Mon, Feb 8, 2016 at 8:46 PM, David Blaikie wrote: > > > > On Mon, Feb 8, 2016 at 7:39 PM, Xinliang David Li > > wrote: > >> > >> I took a look at the problem. The

[PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: fraggamuffin, caomhin, cfe-commits. This patch implements the launching of a target region in the presence of a nested teams region, i.e calls

r260203 - [CMake] Updating caches README with explanations of useful cache files.

Author: cbieneman Date: Tue Feb 9 00:49:08 2016 New Revision: 260203 URL: http://llvm.org/viewvc/llvm-project?rev=260203=rev Log: [CMake] Updating caches README with explanations of useful cache files. This is in response to silvas' post-commit suggestion. Modified:

Re: r260048 - [Frontend] Make the memory management of FrontendAction pointers explicit by using unique_ptr.

FWIW, I tried to do something like this, perhaps with some other improvements, a few years ago. Not sure if things have changed for the better since then, but maybe those old patches may provide some insight/other improvements/options:

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

- Original Message - > From: "Ulrich Weigand" > To: "Hal Finkel" > Cc: cfe-commits@lists.llvm.org > Sent: Monday, February 8, 2016 7:53:29 AM > Subject: Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP > macros > > Hal Finkel

[PATCH] SemaCXX: Support templates in availability attributes

This patch adds support for templates in availability attributes. - If the context for an availability diagnostic is a `FunctionTemplateDecl`, look through it to the `FunctionDecl`. - Add `__has_feature(attribute_availability_in_templates)`. Is there anything else I should be testing to

Re: r260201 - [CMake] Providing a CMake cache for 3-stage builds

Will do. That comment obviously is out of date as I keep adding files :-). This latest one is a special ball of evil clever cmake goop, I can’t wait till bogner spots it :-). -Chris > On Feb 8, 2016, at 10:38 PM, Sean Silva wrote: > > Neat! Besides the awesomeness of

Re: Linux-abi group

On Mon, Feb 8, 2016 at 3:08 PM, Joseph Myers wrote: > On Mon, 8 Feb 2016, H.J. Lu wrote: > >> >> I was referring to program properties: >> >> >> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8 >> > >> > This looks more like an ELF topic to me, not

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

ariccio marked 2 inline comments as done. ariccio added a comment. I've reformatted, and changed the `PointerUnion` to a `const StackFrameContext*`. Built successfully, etc... (I hope I don't sound too pushy!) Comment at:

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

Wrong in the sense the the coverage result for the default operators (the line where they are declared) is marked as if they are not called which can be confusing to the user. David On Mon, Feb 8, 2016 at 9:09 PM, David Blaikie wrote: > > > On Mon, Feb 8, 2016 at 9:00 PM,

r260201 - [CMake] Providing a CMake cache for 3-stage builds

Author: cbieneman Date: Tue Feb 9 00:01:47 2016 New Revision: 260201 URL: http://llvm.org/viewvc/llvm-project?rev=260201=rev Log: [CMake] Providing a CMake cache for 3-stage builds This cache file can be used to generate a 3-stage clang build. You can configure using the following CMake

r260194 - Avoid forcing emission of delayed dllexported classes on template instantiation

Author: rnk Date: Mon Feb 8 20:51:17 2016 New Revision: 260194 URL: http://llvm.org/viewvc/llvm-project?rev=260194=rev Log: Avoid forcing emission of delayed dllexported classes on template instantiation Fixes PR26490 Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

I took a look at the problem. The implicitly defaulted operators should not be instrumented as specified -- I actually I just added the new test case for that (checking profile counter not generated) right after my previous reply and it still passes with this patch. The reason is that those

[libcxx] r260195 - Use the reserved spellings for attributes

Author: compnerd Date: Mon Feb 8 22:05:37 2016 New Revision: 260195 URL: http://llvm.org/viewvc/llvm-project?rev=260195=rev Log: Use the reserved spellings for attributes Change the no_sanitize attribute to use the reserved spelling. Modified: libcxx/trunk/include/__config Modified:

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 8:46 PM, David Blaikie wrote: > > On Mon, Feb 8, 2016 at 7:39 PM, Xinliang David Li > wrote: >> >> I took a look at the problem. The implicitly defaulted operators >> should not be instrumented as specified -- I actually I just added

Re: r260201 - [CMake] Providing a CMake cache for 3-stage builds

Neat! Besides the awesomeness of the bootstrap, I didn't know about the -C option! (well, except that you told me about it at the social last week, but this is the first time I saw the actual usage). btw, the README.txt in cmake/caches says "The first two cache files in the directory" -- but it's

Re: [PATCH] D16926: [clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D16926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r260092 - [OPENMP] Fix test incompatibility with arm buildbots

Author: abataev Date: Mon Feb 8 07:47:46 2016 New Revision: 260092 URL: http://llvm.org/viewvc/llvm-project?rev=260092=rev Log: [OPENMP] Fix test incompatibility with arm buildbots Modified: cfe/trunk/test/OpenMP/parallel_private_codegen.cpp Modified:

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

aaron.ballman added a comment. This is causing build bot failures: http://bb.pgr.jp/builders/cmake-clang-tools-x86_64-linux/builds/23351 http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/492 http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/812 The failure is not obvious to

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added inline comments. Comment at: docs/clang-tidy/checks/misc-misplaced-widening-cast.rst:2 @@ +1,3 @@ +.. title:: clang-tidy - misc-misplaced-widening-cast + +misc-misplaced-widening-cast For information, it seem I had to use

Re: [PATCH] D12834: add gcc abi_tag support

DmitryPolukhin added a comment. Hi Stefan, What are your plans about this patch? The patch has number of comments about Sema part from Aaron and me but in general there are no major issues with Sema for the attribute. As for mangling part I think recursive approach looks reasonable because

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added inline comments. Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:31 @@ +30,3 @@ + + Finder->addMatcher(returnStmt(has(Cast)), this); + Finder->addMatcher(varDecl(has(Cast)), this); alexfh wrote: > FYI, these matchers can be

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r260096, sorry for the delay. You should speak to Chris Lattner about getting commit privileges so that you're not blocked on one of us being available to commit on your behalf again. http://reviews.llvm.org/D16308

r260091 - [OPENMP] Fixed test incompat with MSVC

Author: abataev Date: Mon Feb 8 07:02:00 2016 New Revision: 260091 URL: http://llvm.org/viewvc/llvm-project?rev=260091=rev Log: [OPENMP] Fixed test incompat with MSVC Modified: cfe/trunk/test/OpenMP/parallel_private_codegen.cpp Modified: cfe/trunk/test/OpenMP/parallel_private_codegen.cpp

Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

On 7 February 2016 at 17:29, Samuel F Antao wrote: > Hi Renato, > > This is not related with my patch, I'm afraid your buildbot won't go green > with the revert. This looks to be related with r259976. My patch > triggered the problem because it touched a CmakeList.txt. The

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

alexfh added a comment. Looks good apart from renaming and one comment that's still relevant. Comment at: clang-tidy/misc/UninitializedFieldCheck.cpp:178 @@ +177,3 @@ + + SmallPtrSet FieldsToInit; + fieldsRequiringInit(MemberFields, FieldsToInit); What about

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki updated this revision to Diff 47182. danielmarjamaki marked 9 inline comments as done. danielmarjamaki added a comment. Fixed review comments http://reviews.llvm.org/D16310 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added inline comments. Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:79 @@ +78,3 @@ + +void MisplacedWideningCastCheck::check(const MatchFinder::MatchResult ) { + const auto *Cast = Result.Nodes.getNodeAs("Cast"); I looked in

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

Thanks. It didn't pass with i686-mingw32. // LAMBDA: call // LAMBDA: call{{.*}} void [[OUTER_LAMBDA:@.+]]( call x86_thiscallcc void @_ZN2SSC1ERi(%struct.SS* %ss, i32* dereferenceable(4) @_ZZ4mainE5sivar) call x86_thiscallcc void @"_ZZ4mainENK3$_0clEv"(%class.anon* %temp.lvalue) The

[clang-tools-extra] r260096 - Expand the simplify boolean expression check to handle implicit conversion of integral types to bool and improve the handling of implicit conversion of member pointers to

Author: aaronballman Date: Mon Feb 8 08:25:25 2016 New Revision: 260096 URL: http://llvm.org/viewvc/llvm-project?rev=260096=rev Log: Expand the simplify boolean expression check to handle implicit conversion of integral types to bool and improve the handling of implicit conversion of member

Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

No worries, sure, I'll do that. Thanks! Samuel From: Renato Golin To: Samuel F Antao/Watson/IBM@IBMUS Cc: Clang Commits Date: 02/08/2016 09:57 AM Subject:Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 13:54, H.J. Lu wrote: > On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote: > > The standard-layout POD is well defined: > > https://en.wikipedia.org/wiki/C%2B%2B11#Modification_to_the_definition_of_plain_old_data > > Here is the

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

Yes, I know, will be fixed in few minutes Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 08.02.2016 15:43, NAKAMURA Takumi пишет: The test is incompatible to i686-pc-win32. See also http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/5498 On Mon, Feb 8,

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki updated this revision to Diff 47181. danielmarjamaki added a comment. Fixes according to review comments. http://reviews.llvm.org/D16310 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MisplacedWideningCastCheck.cpp

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Hal Finkel wrote on 05.02.2016 23:14:54: > Just a general comment: I believe we've now fixed this bug for at > least four different architectures (each time as a separate effort). Yes. Unfortunately I only noticed that after I'd already spent half a day debugging the problem

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Sun, Feb 7, 2016 at 12:52 PM, H.J. Lu wrote: > On Sun, Feb 7, 2016 at 12:48 PM, Florian Weimer wrote: >> * H. J. Lu: >> I tested GCC 5.3.1 and Clang 3.5.0. GCC Clang s0 non-emptynon-empty s1 non-empty

r260093 - clang/test/OpenMP/parallel_private_codegen.cpp: Fix an expression.

Author: chapuni Date: Mon Feb 8 08:04:28 2016 New Revision: 260093 URL: http://llvm.org/viewvc/llvm-project?rev=260093=rev Log: clang/test/OpenMP/parallel_private_codegen.cpp: Fix an expression. call x86_thiscallcc void @_ZN2SSC1ERi( It matched to: x86_this Modified:

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

Ok, thanks a lot! Hope it will fix win-based buildbots completely. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 08.02.2016 17:11, NAKAMURA Takumi пишет: Thanks. It didn't pass with i686-mingw32. // LAMBDA: call // LAMBDA: call{{.*}} void

[clang-tools-extra] r260097 - Reverting r260096; it causes build bot failures:

Author: aaronballman Date: Mon Feb 8 08:37:56 2016 New Revision: 260097 URL: http://llvm.org/viewvc/llvm-project?rev=260097=rev Log: Reverting r260096; it causes build bot failures: http://bb.pgr.jp/builders/cmake-clang-tools-x86_64-linux/builds/23351

[clang-tools-extra] r260100 - [clang-tidy] Reshuffled paragraphs a bit, added contents.

Author: alexfh Date: Mon Feb 8 09:09:39 2016 New Revision: 260100 URL: http://llvm.org/viewvc/llvm-project?rev=260100=rev Log: [clang-tidy] Reshuffled paragraphs a bit, added contents. Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified:

[clang-tools-extra] r260099 - [clang-tidy] Fix an error in .rst

Author: alexfh Date: Mon Feb 8 09:09:34 2016 New Revision: 260099 URL: http://llvm.org/viewvc/llvm-project?rev=260099=rev Log: [clang-tidy] Fix an error in .rst Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-incorrect-roundings.rst Modified:

Re: [PATCH]: git-clang-format

On 02/08/2016 12:32 PM, Manuel Klimek wrote: I believe you forgot to add cfe-commits as subscriber on the patch. On Sun, Feb 7, 2016 at 12:51 PM Alexander Shukaev < cl...@alexander.shukaev.name> wrote: On 12/14/2015 10:03 PM, Alexander Shukaev wrote: On 12/11/2015 04:40 PM, Daniel Jasper

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely wrote: >>> A type is a standard-layout type, or it isn't. >> >> How about "An empty record is standard-layout Plain Old Data (POD) >> type and ..."? > > That's redundant, all POD types are standard-layout types. > Apparently,

r260116 - Fix missing space (NFC)

Author: xur Date: Mon Feb 8 12:12:41 2016 New Revision: 260116 URL: http://llvm.org/viewvc/llvm-project?rev=260116=rev Log: Fix missing space (NFC) Fixed the inconsistently placed : (missing space) introduced in in r259811. Modified:

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 18:26, Jonathan Wakely wrote: > On 8 February 2016 at 17:58, H.J. Lu wrote: >> On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely >> wrote: > A type is a standard-layout type, or it isn't. How about "An empty record

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 18:31, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely > wrote: >> On 8 February 2016 at 18:26, Jonathan Wakely wrote: >>> On 8 February 2016 at 17:58, H.J. Lu wrote: On Mon, Feb 8,

[libcxx] r260115 - Clean up a test; get rid of hard-wired char/wchar_t code for template fns that take any char type. Prep work for PR#26503

Author: marshall Date: Mon Feb 8 11:38:23 2016 New Revision: 260115 URL: http://llvm.org/viewvc/llvm-project?rev=260115=rev Log: Clean up a test; get rid of hard-wired char/wchar_t code for template fns that take any char type. Prep work for PR#26503 Modified:

Re: [PATCH] D16934: [Coverage] Fix crash in VisitIfStmt

Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added a subscriber: cfe-commits. > > When handling 'if' statements, we crash if the condition and the consequent > branch are spanned by a single macro expansion. > > The crash occurs because

Re: r260002 - Add a missing call to MDNode::deleteTemporary().

> On Feb 6, 2016, at 12:38 PM, Duncan P. N. Exon Smith > wrote: > >> >> On 2016-Feb-06, at 10:39, Adrian Prantl via cfe-commits >> wrote: >> >> Author: adrian >> Date: Sat Feb 6 12:39:34 2016 >> New Revision: 260002 >> >> URL:

r260113 - Use llvm::TempDIScope instead of manually deleting a temporary MDNode.

Author: adrian Date: Mon Feb 8 11:03:28 2016 New Revision: 260113 URL: http://llvm.org/viewvc/llvm-project?rev=260113=rev Log: Use llvm::TempDIScope instead of manually deleting a temporary MDNode. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified:

[libclc] r260114 - math: Add frexp ported from amd-builtins

Author: awatry Date: Mon Feb 8 11:07:21 2016 New Revision: 260114 URL: http://llvm.org/viewvc/llvm-project?rev=260114=rev Log: math: Add frexp ported from amd-builtins The float implementation is almost a direct port from the amd-builtins, but instead of just having a scalar and float4

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

davidxl updated this revision to Diff 47217. davidxl added a comment. Simplified test case suggested by Vedant. http://reviews.llvm.org/D16947 Files: lib/CodeGen/CGClass.cpp test/Profile/def-assignop.cpp Index: test/Profile/def-assignop.cpp

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

vsk added a comment. Lgtm. http://reviews.llvm.org/D16947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 17:58, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely wrote: A type is a standard-layout type, or it isn't. >>> >>> How about "An empty record is standard-layout Plain Old Data (POD) >>> type and ..."? >> >> That's redundant, all

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely wrote: > On 8 February 2016 at 18:26, Jonathan Wakely wrote: >> On 8 February 2016 at 17:58, H.J. Lu wrote: >>> On Mon, Feb 8, 2016 at 7:59 AM, Jonathan Wakely >>> wrote:

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai updated this revision to Diff 47223. nemanjai added a comment. Fixed the naming, indentation and removed the use of dyn_cast for types. Repository: rL LLVM http://reviews.llvm.org/D15120 Files: bindings/python/clang/cindex.py include/clang-c/Index.h

Re: [PATCH] D16951: [MS ABI] dllimport'd class cannot have constexpr ctors

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Mon, Feb 8, 2016 at 10:46 AM, Jonathan Wakely wrote: > On 8 February 2016 at 18:31, H.J. Lu wrote: >> On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely >> wrote: >>> On 8 February 2016 at 18:26, Jonathan Wakely

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

Hi Eric, On 6 February 2016 at 16:36, Eric Fiselier via cfe-commits wrote: > Cleanup node-type handling in the unordered containers This seems to have broken __gnu_cxx::hash_map (used by hash.cpp and hash2.cpp in the test-suite). A smaller reproducer is: #include

  1   2   >