r262177 - [CLANG] [AVX512] [BUILTIN] Adding PSLL{V|W|Wi}{128|256|512} builtin

2016-02-27 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Sun Feb 28 01:39:34 2016 New Revision: 262177 URL: http://llvm.org/viewvc/llvm-project?rev=262177=rev Log: [CLANG] [AVX512] [BUILTIN] Adding PSLL{V|W|Wi}{128|256|512} builtin Differential Revision: http://reviews.llvm.org/D17685 Modified:

[PATCH] D17688: Fix missed leak from MSVC specific allocation functions

2016-02-27 Thread Alexander Riccio via cfe-commits
ariccio created this revision. ariccio added a subscriber: cfe-commits. I've found & fixed a leak that Clang misses when compiling on Windows. The leak was found by [[ https://samate.nist.gov/SARD/view_testcase.php?tID=149071 | SARD #149071 ]], mem1-bad.c. Clang misses it because MSVC uses

Re: [PATCH] D17253: Cleanup of analyzer scripts as suggested by pychecker and pep8

2016-02-27 Thread Alexander Riccio via cfe-commits
ariccio added inline comments. Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/SATestBuild.py:521 @@ -502,3 +520,3 @@ SummaryLog.write("See the first %d below.\n" - % (NumOfFailuresInSummary,)) +

Re: r250293 - Bring back r250262: PS4 toolchain

2016-02-27 Thread Nico Weber via cfe-commits
On Wed, Oct 14, 2015 at 5:25 AM, Filipe Cabecinhas via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: filcab > Date: Wed Oct 14 07:25:43 2015 > New Revision: 250293 > > URL: http://llvm.org/viewvc/llvm-project?rev=250293=rev > Log: > Bring back r250262: PS4 toolchain > > There was a

Re: [PATCH] D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references.

2016-02-27 Thread Felix Berger via cfe-commits
flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 49307. flx marked 6 inline comments as done. http://reviews.llvm.org/D17491 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/PerformanceTidyModule.cpp

Re: [PATCH] D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references.

2016-02-27 Thread Felix Berger via cfe-commits
flx added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:41 @@ +40,3 @@ + Function->parameters().begin(); + if (Index >= Function->getNumParams()) { +return; alexfh wrote: > Please add a comment about

Re: [PATCH] D17488: Extend UnnecessaryCopyInitialization check to trigger on non-const copies that can be safely converted to const references.

2016-02-27 Thread Felix Berger via cfe-commits
flx added inline comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.h:19 @@ -18,3 +18,3 @@ -// A check that detects const local variable declarations that are copy +// A check that detects local variable declarations that are copy // initialized with

Re: [PATCH] D17488: Extend UnnecessaryCopyInitialization check to trigger on non-const copies that can be safely converted to const references.

2016-02-27 Thread Felix Berger via cfe-commits
flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 49306. flx marked 5 inline comments as done. http://reviews.llvm.org/D17488 Files: clang-tidy/performance/ForRangeCopyCheck.cpp clang-tidy/performance/UnnecessaryCopyInitialization.cpp

[PATCH] D17682: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE

2016-02-27 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, andreadb. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. btver1 is a SSSE3/SSE4a only CPU - it doesn't have AVX and doesn't support XSAVE. This looks like some kind

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

2016-02-27 Thread Timon Van Overveldt via cfe-commits
timonvo added a comment. I don't have commit access. Can I land this CL myself somehow without commit access (e.g. using arc), or will you have to submit it for me? http://reviews.llvm.org/D15883 ___ cfe-commits mailing list

Re: [PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

2016-02-27 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 49295. hintonda added a comment. Improve efficiency by using pair<> to maintain counts instead of purging seen fields. http://reviews.llvm.org/D17407 Files: lib/Sema/SemaInit.cpp test/SemaCXX/cxx0x-initializer-constructor.cpp Index:

r262138 - Workaround doxygen bug https://bugzilla.gnome.org/show_bug.cgi?id=506243

2016-02-27 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Sat Feb 27 08:02:08 2016 New Revision: 262138 URL: http://llvm.org/viewvc/llvm-project?rev=262138=rev Log: Workaround doxygen bug https://bugzilla.gnome.org/show_bug.cgi?id=506243 Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst

r262136 - Correcting indentation for an RST code block.

2016-02-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Feb 27 07:13:16 2016 New Revision: 262136 URL: http://llvm.org/viewvc/llvm-project?rev=262136=rev Log: Correcting indentation for an RST code block. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL:

Re: [PATCH] D17586: Add a new check, readability-redundant-string-init, that checks unnecessary string initializations.

2016-02-27 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D17586#363466, @Eugene.Zelenko wrote: > Sorry for arriving late to party :-) > > Thank you for great check! I found a quite lot of such problems in my code > base, but I'd like to make suggestion for further improvements: PR26756. The full

r262126 - AMDGPU: Add builtins for recently added intrinsics

2016-02-27 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Sat Feb 27 03:54:43 2016 New Revision: 262126 URL: http://llvm.org/viewvc/llvm-project?rev=262126=rev Log: AMDGPU: Add builtins for recently added intrinsics Added: cfe/trunk/test/SemaOpenCL/builtins-amdgcn.cl Modified:

Re: [PATCH] D17515: AMDGPU: Add builtins for recently added intrinsics

2016-02-27 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r262126 http://reviews.llvm.org/D17515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17519: AMDGPU: Fix broken/confusing predefined macro

2016-02-27 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r262124 http://reviews.llvm.org/D17519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17520: AMDGPU: Fix inconsistent register name for flat_scratch

2016-02-27 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r262123 http://reviews.llvm.org/D17520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262123 - AMDGPU: Fix inconsistent register name for flat_scratch

2016-02-27 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Sat Feb 27 03:06:22 2016 New Revision: 262123 URL: http://llvm.org/viewvc/llvm-project?rev=262123=rev Log: AMDGPU: Fix inconsistent register name for flat_scratch Added: cfe/trunk/test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl Modified:

r262122 - Add __builtin_canonicalize

2016-02-27 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Sat Feb 27 03:06:18 2016 New Revision: 262122 URL: http://llvm.org/viewvc/llvm-project?rev=262122=rev Log: Add __builtin_canonicalize Modified: cfe/trunk/docs/LanguageExtensions.rst cfe/trunk/include/clang/Basic/Builtins.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp

Re: [PATCH] D17558: Add __builtin_canonicalize

2016-02-27 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r262122 http://reviews.llvm.org/D17558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262124 - AMDGPU: Fix broken/confusing predefined macro

2016-02-27 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Sat Feb 27 03:06:26 2016 New Revision: 262124 URL: http://llvm.org/viewvc/llvm-project?rev=262124=rev Log: AMDGPU: Fix broken/confusing predefined macro amdgcn should not be defining __R600__ Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D17645: AMDGPU: Add missing Volcanic Islands targets

2016-02-27 Thread Matt Arsenault via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org