Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r262576 - Caught and fixed a typo in r262572.

Is it possible to test this? On Mar 2, 2016 6:26 PM, "Sean Callanan via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: spyffe > Date: Wed Mar 2 20:22:05 2016 > New Revision: 262576 > > URL: http://llvm.org/viewvc/llvm-project?rev=262576=rev > Log: > Caught and fixed a typo in

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:9071 @@ +9070,3 @@ +/// 0 if it is inconclusive. +static int CheckArrayExpressionReferToWholeSize(Sema , const Expr *E, +QualType BaseQTy) { Don't

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:49-51 @@ -48,2 +48,5 @@ TargetRegion, +/// \brief Region that do not require function outlining and uses +/// information from a inner scope. +

r262587 - Semantic analysis for the swiftcall calling convention.

Author: rjmccall Date: Thu Mar 3 00:39:32 2016 New Revision: 262587 URL: http://llvm.org/viewvc/llvm-project?rev=262587=rev Log: Semantic analysis for the swiftcall calling convention. I've tried to keep the infrastructure behind parameter ABI treatments fairly general. Added:

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio added a comment. Hmm. This seems to be because `wchar_t` is enabled by `-fms-compatibility`. @aaron.ballman do you have any idea how to define `wchar_t` without `-fms-compatibility`? http://reviews.llvm.org/D17688 ___ cfe-commits mailing

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:49-51 @@ -48,2 +48,5 @@ TargetRegion, +/// \brief Region that do not require function outlining and uses +/// information from a inner scope. +InlinedInnerRegion, }; Do

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

sfantao updated this revision to Diff 49709. sfantao marked 3 inline comments as done. sfantao added a comment. - Allow array expressions whose memory contiguous checks are inconclusive. - Add C test to check the constant expressions no longer can prove bounds in array sections.

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

sfantao added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7787-7789 @@ -7786,5 +7786,5 @@ "bit fields cannot be used to specify storage in a map clause">; -def err_omp_array_section_in_rightmost_expression : Error< - "array section can only be

r262583 - [test] Re-enable asan on the test, stack usage should be lower.

Author: akirtzidis Date: Wed Mar 2 23:33:48 2016 New Revision: 262583 URL: http://llvm.org/viewvc/llvm-project?rev=262583=rev Log: [test] Re-enable asan on the test, stack usage should be lower. Modified: cfe/trunk/test/Index/index-many-logical-ops.c Modified:

r262584 - [index] Report references of ObjC super class/protocols in interfaces and protocols.

Author: akirtzidis Date: Wed Mar 2 23:33:54 2016 New Revision: 262584 URL: http://llvm.org/viewvc/llvm-project?rev=262584=rev Log: [index] Report references of ObjC super class/protocols in interfaces and protocols. Modified: cfe/trunk/lib/Index/IndexDecl.cpp

r262582 - [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

Author: abataev Date: Wed Mar 2 23:21:39 2016 New Revision: 262582 URL: http://llvm.org/viewvc/llvm-project?rev=262582=rev Log: [OPENMP 4.0] Initial support for 'omp declare reduction' construct. Add parsing, sema analysis and serialization/deserialization for 'declare reduction' construct.

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262582: [OPENMP 4.0] Initial support for 'omp declare reduction' construct. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D11182?vs=45149=49707#toc Repository: rL LLVM

r262578 - [OPENMP 4.5] Initial support for data members in 'linear' clause.

Author: abataev Date: Wed Mar 2 21:52:24 2016 New Revision: 262578 URL: http://llvm.org/viewvc/llvm-project?rev=262578=rev Log: [OPENMP 4.5] Initial support for data members in 'linear' clause. OpenMP 4.5 allows to privatize data members of current class in member functions. Patch adds initial

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

I will talk to someone about this tomorrow to see if I can get a better feel, thank you for the reminder. ~Aaron On Wed, Mar 2, 2016 at 8:44 PM, Reid Kleckner via cfe-commits wrote: > rnk accepted this revision. > rnk added a comment. > This revision is now accepted

r262576 - Caught and fixed a typo in r262572.

Author: spyffe Date: Wed Mar 2 20:22:05 2016 New Revision: 262576 URL: http://llvm.org/viewvc/llvm-project?rev=262576=rev Log: Caught and fixed a typo in r262572. I should have checked and imported D's in-class initializer. Instead I accidentally used ToField's in-class initializer, which is

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D17444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

zaks.anna added a comment. The second: you should not update the diff. When a patch is uploaded, the assumption is that all tests pass:) http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262572 - Fixed a problem where the ASTImporter mishandled in-class initializers.

Author: spyffe Date: Wed Mar 2 19:21:28 2016 New Revision: 262572 URL: http://llvm.org/viewvc/llvm-project?rev=262572=rev Log: Fixed a problem where the ASTImporter mishandled in-class initializers. Previously, the ASTImporter, when copying a FieldDecl, would make the new FieldDecl use the

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio added a comment. In http://reviews.llvm.org/D17688#366883, @zaks.anna wrote: > Please, do not submit patches for review before they pass all tests. Whoops, sorry. Should I been a bit clearer that check-all hadn't finished when I updated the diff, or should I not update the diff at all

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar updated this revision to Diff 49688. jpienaar added a comment. Removed unused variables in LanaiTargetInfo. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp

r262565 - This patch adds doxygen comments for all the intrinsincs in the header file tmmintrin.h.

Author: kromanova Date: Wed Mar 2 18:20:11 2016 New Revision: 262565 URL: http://llvm.org/viewvc/llvm-project?rev=262565=rev Log: This patch adds doxygen comments for all the intrinsincs in the header file tmmintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics

[libunwind] r262564 - Creating release candidate final from release_380 branch

Author: hans Date: Wed Mar 2 18:19:35 2016 New Revision: 262564 URL: http://llvm.org/viewvc/llvm-project?rev=262564=rev Log: Creating release candidate final from release_380 branch Added: libunwind/tags/RELEASE_380/final/ - copied from r262563, libunwind/branches/release_38/

[libcxxabi] r262558 - Creating release candidate final from release_380 branch

Author: hans Date: Wed Mar 2 18:19:17 2016 New Revision: 262558 URL: http://llvm.org/viewvc/llvm-project?rev=262558=rev Log: Creating release candidate final from release_380 branch Added: libcxxabi/tags/RELEASE_380/final/ (props changed) - copied from r262557,

r262552 - Serialize `pragma pointers_to_members` state.

Author: nico Date: Wed Mar 2 18:17:35 2016 New Revision: 262552 URL: http://llvm.org/viewvc/llvm-project?rev=262552=rev Log: Serialize `pragma pointers_to_members` state. Like r262539, but for pointers_to_members. Added: cfe/trunk/test/PCH/pragma-pointers_to_members.cpp Modified:

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

zaks.anna added a comment. Please, do not submit patches for review before they pass all tests. http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

zaks.anna added a comment. Generate a preprocessed file and keep copying the definitions from there until you reach the types compiler knows about. http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262551 - Improve some infrastructure for extended parameter infos and

Author: rjmccall Date: Wed Mar 2 18:10:03 2016 New Revision: 262551 URL: http://llvm.org/viewvc/llvm-project?rev=262551=rev Log: Improve some infrastructure for extended parameter infos and fix a bug with the instantiation of ns_consumed parameter attributes in ARC. Modified:

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio added a comment. Hmm, check-all produced a number of issues, which I think stem from the following warning: File C:\LLVM\llvm\tools\clang\test\Analysis\malloc.c Line 16: unknown type name 'wchar_t' (with a bunch of instances of that) ...so how do I declare/define `wchar_t`

Re: r262487 - test/Driver/cl-pch-errorhandling.cpp: Copy input file to a temporary

Ok, gave that a try in r262541. On Wed, Mar 2, 2016 at 1:20 PM, Daniel Jasper wrote: > Feel free to change. I have no idea what I am doing here. > > On Wed, Mar 2, 2016 at 12:55 PM, Nico Weber wrote: > >> (A different fix would've been to just add

r262541 - clang-cl pch test: Instead of copying the input, use /Fp to not write into the test directory.

Author: nico Date: Wed Mar 2 17:29:29 2016 New Revision: 262541 URL: http://llvm.org/viewvc/llvm-project?rev=262541=rev Log: clang-cl pch test: Instead of copying the input, use /Fp to not write into the test directory. Also fix a bug with /Fp and absolute paths uncovered by this. Follow-up to

r262539 - Serialize `pragma ms_struct` state.

Author: nico Date: Wed Mar 2 17:22:00 2016 New Revision: 262539 URL: http://llvm.org/viewvc/llvm-project?rev=262539=rev Log: Serialize `pragma ms_struct` state. pragma ms_struct has an effect on struct decls, and the effect is serialized correctly already. But the "is ms_struct currently on"

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thanks! I can commit this in your behalf. http://reviews.llvm.org/D17688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio updated this revision to Diff 49674. ariccio added a comment. Added newly checked variants to the malloc checks. (Running the check-all suite now, will update with results) http://reviews.llvm.org/D17688 Files: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

Re: [PATCH] D17688: Fix missed leak from MSVC specific allocation functions

ariccio added a comment. In http://reviews.llvm.org/D17688#366011, @ariccio wrote: > In http://reviews.llvm.org/D17688#365951, @zaks.anna wrote: > > > ls ./clang/test/Analysis/malloc* > > > Ah, ok. Would it be ok if (for _strdup & _alloca) I just do this at the > beginning: > > #if

Re: [PATCH] D17385: clang-format: [JS] re-quote single or double quoted strings.

djasper closed this revision. djasper added a comment. Submitted as r262534. http://reviews.llvm.org/D17385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262534 - clang-format: [JS] Optionally re-quote string literals.

Author: djasper Date: Wed Mar 2 16:44:03 2016 New Revision: 262534 URL: http://llvm.org/viewvc/llvm-project?rev=262534=rev Log: clang-format: [JS] Optionally re-quote string literals. Turns "foo" into 'foo' (or vice versa, depending on configuration). This makes it more convenient to follow the

Re: [PATCH] D17385: clang-format: [JS] re-quote single or double quoted strings.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lib/Format/Format.cpp:1140 @@ +1139,3 @@ + + void insertReplacement(SourceLocation Start, unsigned Length, + StringRef

r262526 - [analyzer] Move ObjCSuperDeallocChecker out of the alpha package.

Author: dcoughlin Date: Wed Mar 2 16:01:03 2016 New Revision: 262526 URL: http://llvm.org/viewvc/llvm-project?rev=262526=rev Log: [analyzer] Move ObjCSuperDeallocChecker out of the alpha package. It will now be on by default on Darwin. rdar://problem/6953275 Modified:

r262524 - [analyzer] Move ObjCDeallocChecker out of the alpha package.

Author: dcoughlin Date: Wed Mar 2 15:50:54 2016 New Revision: 262524 URL: http://llvm.org/viewvc/llvm-project?rev=262524=rev Log: [analyzer] Move ObjCDeallocChecker out of the alpha package. It will now be on by default on Darwin. rdar://problem/6927496 Modified:

r262520 - [analyzer] Fix capitalization in ObjCSuperDeallocChecker diagnostic.

Author: dcoughlin Date: Wed Mar 2 15:22:48 2016 New Revision: 262520 URL: http://llvm.org/viewvc/llvm-project?rev=262520=rev Log: [analyzer] Fix capitalization in ObjCSuperDeallocChecker diagnostic. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp

Re: Add hasInClassInitializer matcher

On Wed, Mar 2, 2016 at 4:14 PM, Julian Bangert wrote: > Here is a patch to SVN with the requested changes (documentation, renamed > and added to registry): LGTM! ~Aaron > > Index: docs/LibASTMatchersReference.html >

Re: Add hasInClassInitializer matcher

Here is a patch to SVN with the requested changes (documentation, renamed and added to registry): Index: docs/LibASTMatchersReference.html === --- docs/LibASTMatchersReference.html (revision 262512) +++

Re: Add hasInClassInitializer matcher

In case my MUA messed up the formatting, see the attached On Wed, Mar 2, 2016 at 1:14 PM Julian Bangert wrote: > Here is a patch to SVN with the requested changes (documentation, renamed > and added to registry): > > Index: docs/LibASTMatchersReference.html >

Re: r262487 - test/Driver/cl-pch-errorhandling.cpp: Copy input file to a temporary

Feel free to change. I have no idea what I am doing here. On Wed, Mar 2, 2016 at 12:55 PM, Nico Weber wrote: > (A different fix would've been to just add /Fp%.pch to set the output path > to be not next to the inputs.) > > On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via

r262516 - Fixed test failure platforms with name mangling different from Linux.

Author: tra Date: Wed Mar 2 15:03:20 2016 New Revision: 262516 URL: http://llvm.org/viewvc/llvm-project?rev=262516=rev Log: Fixed test failure platforms with name mangling different from Linux. * Run cc with -triple x86_64-linux-gnu to make symbol mangling predictable. * Use temporary file as a

Re: [PATCH] D17737: [PGO] change profile use cc1 option

This revision was automatically updated to reflect the committed changes. Closed by commit rL262515: [PGO] Change profile use cc1 option to handle IR level profiles (authored by xur). Changed prior to commit: http://reviews.llvm.org/D17737?vs=49655=49664#toc Repository: rL LLVM

r262515 - [PGO] Change profile use cc1 option to handle IR level profiles

Author: xur Date: Wed Mar 2 14:59:36 2016 New Revision: 262515 URL: http://llvm.org/viewvc/llvm-project?rev=262515=rev Log: [PGO] Change profile use cc1 option to handle IR level profiles This patch changes cc1 option for PGO profile use from -fprofile-instr-use= to

Re: r262487 - test/Driver/cl-pch-errorhandling.cpp: Copy input file to a temporary

Thanks! On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Wed Mar 2 08:26:59 2016 > New Revision: 262487 > > URL: http://llvm.org/viewvc/llvm-project?rev=262487=rev > Log: > test/Driver/cl-pch-errorhandling.cpp: Copy

Re: r262487 - test/Driver/cl-pch-errorhandling.cpp: Copy input file to a temporary

(A different fix would've been to just add /Fp%.pch to set the output path to be not next to the inputs.) On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Wed Mar 2 08:26:59 2016 > New Revision: 262487 > > URL:

Re: Add hasInClassInitializer matcher

On Wed, Mar 2, 2016 at 2:01 PM, Julian Bangert via cfe-commits wrote: > This adds a matcher for C++ in Class initializers. > > --- > include/clang/ASTMatchers/ASTMatchers.h | 14 ++ > unittests/ASTMatchers/ASTMatchersTest.cpp | 7 +++ > 2 files

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood added a comment. I need to update from review comments and upload a new diff. http://reviews.llvm.org/D7982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17820: Clang Code Completion Filtering

akyrtzi added a comment. In http://reviews.llvm.org/D17820#366638, @milianw wrote: > But, we currently always request code completion at a word start boundary so > nothing would change for us. That said, I see how this patch could be seen as > a breaking behavior change, and thus should

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

kzhuravl-AMD updated this revision to Diff 49652. kzhuravl-AMD added a comment. Review Feedback - Updated diff http://reviews.llvm.org/D17764 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D17820: Clang Code Completion Filtering

milianw added a comment. @akyrtzi raises a very valid point - I did not think about that. KDevelop uses the clang-c API and does fuzzy matching on top of the results, e.g. for camel-case matching. But, we currently always request code completion at a word start boundary so nothing would change

Re: [PATCH] D17820: Clang Code Completion Filtering

milianw added a subscriber: milianw. milianw added a comment. I'm not yet acquainted enough with the code at hand, but I wonder whether I'm understanding the code correctly: Could it be that you only filter before printing to the output stream? The other consumers, e.g. the one used by the

Add hasInClassInitializer matcher

This adds a matcher for C++ in Class initializers. --- include/clang/ASTMatchers/ASTMatchers.h | 14 ++ unittests/ASTMatchers/ASTMatchersTest.cpp | 7 +++ 2 files changed, 21 insertions(+) diff --git a/include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D17820: Clang Code Completion Filtering

akyrtzi added a comment. We should not bake-in filtering into the clang CodeComplete API. What kind of filtering to use should be on a higher level, different clients may want different filtering, e.g. prefix filtering, fuzzy filtering, etc. Repository: rL LLVM

Re: [PATCH] D17737: [PGO] change profile use cc1 option

davidxl accepted this revision. davidxl added a comment. lgtm http://reviews.llvm.org/D17737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262508 - fix test from r262506

Author: nico Date: Wed Mar 2 13:38:24 2016 New Revision: 262508 URL: http://llvm.org/viewvc/llvm-project?rev=262508=rev Log: fix test from r262506 Modified: cfe/trunk/test/PCH/pragma-detect_mismatch.c Modified: cfe/trunk/test/PCH/pragma-detect_mismatch.c URL:

Re: [PATCH] D17737: [PGO] change profile use cc1 option

xur updated this revision to Diff 49655. xur added a comment. Integrated with Sean's review comments. -Rong http://reviews.llvm.org/D17737 Files: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sorry, I've been waffling on this, but I think this is fine. Thanks! -eric http://reviews.llvm.org/D17183 ___ cfe-commits mailing list

Re: [PATCH] D17799: Serialize `#pragma comment`.

thakis added a comment. Also landed a very similar change for the very similar detect_mismatch pragma in r262506. (The other missing serialized pragmas will use a different approach.) http://reviews.llvm.org/D17799 ___ cfe-commits mailing list

r262506 - Serialize `#pragma detect_mismatch`.

Author: nico Date: Wed Mar 2 13:28:54 2016 New Revision: 262506 URL: http://llvm.org/viewvc/llvm-project?rev=262506=rev Log: Serialize `#pragma detect_mismatch`. This is like r262493, but for pragma detect_mismatch instead of pragma comment. The two pragmas have similar behavior, so use the

r262503 - [libFuzzer] allow -fsanitize-coverage=0 (disables all coverage)

Author: kcc Date: Wed Mar 2 13:16:54 2016 New Revision: 262503 URL: http://llvm.org/viewvc/llvm-project?rev=262503=rev Log: [libFuzzer] allow -fsanitize-coverage=0 (disables all coverage) Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia updated this revision to Diff 49651. Anastasia added a comment. Improved message text! http://reviews.llvm.org/D17345 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Parser/opencl-storage-class.cl test/SemaOpenCL/storageclass-cl20.cl

Re: [PATCH] D17737: [PGO] change profile use cc1 option

silvas added a comment. I agree, David's suggestion has simplified things. This LGTM (with a couple nits) but I'll let David give the final approval. Comment at: lib/CodeGen/CodeGenModule.cpp:153 @@ +152,3 @@ + if (CodeGenOpts.hasProfileClangUse()) { +

Re: [PATCH] D17299: [ASTReader] Report error when accessing corrupt record data

benlangmuir added a comment. This LGTM, but I would like Richard to take a look too. http://reviews.llvm.org/D17299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17772: [clang-tidy]: string_view of temporary string

jbcoe abandoned this revision. jbcoe added a comment. rendered obsolete by http://reviews.llvm.org/D17811 Repository: rL LLVM http://reviews.llvm.org/D17772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

On Wed, Mar 2, 2016 at 10:36 AM, Benjamin Kramer wrote: > In theory yes, in practice that needs a bit of build system tweaking > to either build clang-tidy into clang or as a shared library. Then it > can be used like any regular Clang plugin. > I haven't looked at this

Re: [PATCH] D17737: [PGO] change profile use cc1 option

xur updated this revision to Diff 49647. xur marked an inline comment as done. xur added a comment. I think David's suggestion to use one cc1 option -fprofile-instrument-use-path is a very good idea. I update the patch to get rid of -fprofille-instrument-use. The profile kind is now set by

Re: [PATCH] D17780: [CUDA] Do not generate unnecessary runtime init code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262499: [CUDA] Do not generate unnecessary runtime init code. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D17780?vs=49539=49646#toc Repository: rL LLVM

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

In theory yes, in practice that needs a bit of build system tweaking to either build clang-tidy into clang or as a shared library. Then it can be used like any regular Clang plugin. It will also slow down clang significantly, but I consider that a bug ;) On Wed, Mar 2, 2016 at 6:21 PM, David

Re: [PATCH] D17299: [ASTReader] Report error when accessing corrupt record data

vsk added a comment. Gentle ping. For context, we've had a few situations where corrupt pch files trigger surprising assertion failures in our world builds. http://reviews.llvm.org/D17299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262498 - [CUDA] Emit host-side 'shadows' for device-side global variables

Author: tra Date: Wed Mar 2 12:28:50 2016 New Revision: 262498 URL: http://llvm.org/viewvc/llvm-project?rev=262498=rev Log: [CUDA] Emit host-side 'shadows' for device-side global variables ... and register them with CUDA runtime. This is needed for commonly used cudaMemcpy*() APIs that use

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Does it make http://reviews.llvm.org/D17772 obsolete? http://reviews.llvm.org/D17811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262499 - [CUDA] Do not generate unnecessary runtime init code.

Author: tra Date: Wed Mar 2 12:28:53 2016 New Revision: 262499 URL: http://llvm.org/viewvc/llvm-project?rev=262499=rev Log: [CUDA] Do not generate unnecessary runtime init code. Differential Revision: http://reviews.llvm.org/D17780 Modified: cfe/trunk/lib/CodeGen/CGCUDANV.cpp

[PATCH] D17821: [OpenCL] Complete image types support

Anastasia created this revision. Anastasia added a reviewer: bader. Anastasia added subscribers: cfe-commits, pekka.jaaskelainen, yaxunl. Follow up from the earlier discussion via cfe-dev regarding incomplete images support in Clang:

[PATCH] D17820: Clang Code Completion Filtering

CrisCristescu created this revision. CrisCristescu added reviewers: clang-c, benlangmuir, akyrtzi. CrisCristescu added a subscriber: cfe-commits. CrisCristescu set the repository for this revision to rL LLVM. CrisCristescu changed the visibility of this Differential Revision from "Public (No

Re: [PATCH] D10013: Refactor: Simplify boolean conditional return statements in lib/Driver

LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Discarding due to inaction by reviewers. http://reviews.llvm.org/D10013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood added a comment. Squeak. This has been waiting on review for over two weeks http://reviews.llvm.org/D16529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17799: Serialize `#pragma comment`.

thakis closed this revision. thakis added a comment. r262493, thanks! http://reviews.llvm.org/D17799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262493 - Serialize `#pragma comment`.

Author: nico Date: Wed Mar 2 11:28:48 2016 New Revision: 262493 URL: http://llvm.org/viewvc/llvm-project?rev=262493=rev Log: Serialize `#pragma comment`. `#pragma comment` was handled by Sema calling a function on ASTConsumer, and CodeGen then implementing this function and writing things to

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

Would this also be usable as a way to run clang-tidy checks as part of normal compilation? (some things in clang-tidy aren't there because the FP is too high to be a hard error on old codebases (but might be viable once a codebase is able to be cleaned up (like several have been with LLVM)) or

[PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin created this revision. ikudrin added reviewers: mclow.lists, howard.hinnant, EricWF. ikudrin added a subscriber: cfe-commits. Throwing an exception for the first time may lead to calling calloc to allocate memory for __cxa_eh_globals. If the memory pool at that moment is exhausted, it

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaOverload.cpp:1658 @@ -1657,1 +1657,3 @@ } else if (FromType->isRealFloatingType() && ToType->isRealFloatingType()) { +// FIXME: disable conversions between long double and __float128 if +// their

[PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

sbenza created this revision. sbenza added a reviewer: alexfh. sbenza added a subscriber: cfe-commits. Add check misc-dangling-handle to detect dangling references in value handlers like std::experimental::string_view. It provides a configuration option to specify other handle types that should

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D15267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. http://reviews.llvm.org/D16628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17799: Serialize `#pragma comment`.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D17799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17761: Added applyAllReplacementsAndFormat that works for multiple files.

ioeric updated this revision to Diff 49620. ioeric added a comment. - Removed definitions that were forgotten. http://reviews.llvm.org/D17761 Files: include/clang/Basic/SourceManager.h include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h

Re: [PATCH] D17761: Added applyAllReplacementsAndFormat that works for multiple files.

ioeric updated this revision to Diff 49619. ioeric added a comment. - Removed all applyAllReplacementsAndFormat(*); added formatRewrittenCode in clangTooling. http://reviews.llvm.org/D17761 Files: include/clang/Basic/SourceManager.h include/clang/Format/Format.h

Re: [PATCH] D17567: [GCC] PR23529 Sema part of attrbute abi_tag support

DmitryPolukhin updated this revision to Diff 49617. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. Rebase http://reviews.llvm.org/D17567 Files: docs/ItaniumMangleAbiTags.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D17808: [libclang] Link clang-tidy plugin into libclang if present.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D17808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. For now I don't see a better path forward. http://reviews.llvm.org/D17807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17807: [clang-tidy] Add "clang-tidy as a clang plugin" skeleton.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This doesn't really do much at the moment. You can load it via libclang and set the -checks via an extra command line argument as illustrated in the test case. Support for other options

[PATCH] D17808: [libclang] Link clang-tidy plugin into libclang if present.

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This is a sad workaround for the lack of plugin support in libclang. Depends on D17807, a tools-extra change that also contains the test case. This is designed to be easy to remove again if

Re: [PATCH] D17567: [GCC] PR23529 Sema part of attrbute abi_tag support

sberg added a subscriber: sberg. Comment at: lib/Sema/SemaDeclAttr.cpp:4497 @@ +4496,3 @@ +static void handleAbiTagAttr(Sema , Decl *D, const AttributeList ) { + SmallVector Tags; + for (unsigned I = 0, E = Attr.getNumArgs(); I != E; ++I) {

r262487 - test/Driver/cl-pch-errorhandling.cpp: Copy input file to a temporary

Author: djasper Date: Wed Mar 2 08:26:59 2016 New Revision: 262487 URL: http://llvm.org/viewvc/llvm-project?rev=262487=rev Log: test/Driver/cl-pch-errorhandling.cpp: Copy input file to a temporary location as we cannot assume the location of the input file to be writable. Modified:

[clang-tools-extra] r262484 - [clang-tidy] Fix an assertion failure of "SLocEntry::getExpansion()" when IncludeInserter handles macro header file.

Author: hokein Date: Wed Mar 2 08:12:17 2016 New Revision: 262484 URL: http://llvm.org/viewvc/llvm-project?rev=262484=rev Log: [clang-tidy] Fix an assertion failure of "SLocEntry::getExpansion()" when IncludeInserter handles macro header file. Summary: Also Fixes PR24749. Reviewers: alexfh

  1   2   >