faisalv removed reviewers: nwilson, aaron.ballman, hubert.reinterpretcast,
doug.gregor.
faisalv updated this revision to Diff 49889.
faisalv marked 7 inline comments as done.
faisalv added a comment.
Incorporated Richard's feedback:
- constexpr now elicits an extension warning in pre-cxx1z
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262789: [Modules] Don't swallow errors when parsing optional
attributes. (authored by davide).
Changed prior to commit:
http://reviews.llvm.org/D17787?vs=49575=49888#toc
Repository:
rL LLVM
Author: davide
Date: Sat Mar 5 22:20:05 2016
New Revision: 262789
URL: http://llvm.org/viewvc/llvm-project?rev=262789=rev
Log:
[Modules] Don't swallow errors when parsing optional attributes.
Differential Revision: http://reviews.llvm.org/D17787
Added:
Author: alexfh
Date: Sat Mar 5 22:05:59 2016
New Revision: 262787
URL: http://llvm.org/viewvc/llvm-project?rev=262787=rev
Log:
[docs] Clean up doxygen comments a bit.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.h
Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.h
URL:
Author: rksimon
Date: Sat Mar 5 16:35:55 2016
New Revision: 262783
URL: http://llvm.org/viewvc/llvm-project?rev=262783=rev
Log:
Fixed -Wdocumentation warning - typo in a parameter name
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
URL:
ariccio added a subscriber: ariccio.
ariccio added a comment.
Side note: Has anybody ever considered just treating `fopen` and `fclose` like
`malloc` and `free`?
On Windows I use a trick that I discovered what I call "the
`_Post_ptr_invalid_` hack" because* the `_Post_ptr_invalid_` SAL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262781: [clang-tidy] Extend UnnecessaryCopyInitialization
check to trigger on non… (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D17488?vs=49884=49885#toc
Repository:
rL LLVM
Author: flx
Date: Sat Mar 5 15:17:58 2016
New Revision: 262781
URL: http://llvm.org/viewvc/llvm-project?rev=262781=rev
Log:
[clang-tidy] Extend UnnecessaryCopyInitialization check to trigger on non-const
copies that can be safely converted to const references.
Summary:
Move code shared between
Author: compnerd
Date: Sat Mar 5 15:12:33 2016
New Revision: 262780
URL: http://llvm.org/viewvc/llvm-project?rev=262780=rev
Log:
Misc: add a test for TargetParser usage
Ensure that an invalid value passed to target parser does not cause an assertion
in +Asserts builds.
Supporting test for
flx updated this revision to Diff 49884.
flx marked an inline comment as done.
http://reviews.llvm.org/D17488
Files:
clang-tidy/performance/ForRangeCopyCheck.cpp
clang-tidy/performance/UnnecessaryCopyInitialization.cpp
clang-tidy/performance/UnnecessaryCopyInitialization.h
mprobst updated this revision to Diff 49883.
mprobst added a comment.
- Handle unary !.
http://reviews.llvm.org/D17910
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added subscribers: cfe-commits, klimek.
Automatic Semicolon Insertion can only be properly handled by parsing
source code. However conservatively catching just a few, common
situations prevents breaking code during
ariccio added a comment.
In http://reviews.llvm.org/D17688#366780, @zaks.anna wrote:
> LGTM. Thanks!
>
> I can commit this in your behalf.
Oh, and yeah, I don't have privs.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
Author: djasper
Date: Sat Mar 5 12:34:26 2016
New Revision: 262776
URL: http://llvm.org/viewvc/llvm-project?rev=262776=rev
Log:
clang-format: [JS] Support destructuring assignments in for loops.
Before:
for (let { a, b } of x) {
}
After:
for (let {a, b} of x) {
}
Modified:
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This is the first of a series of patches to add additional Visual Studio native
visualizers for subclasses of clang::Type. For example,
milianw accepted this revision.
milianw added a reviewer: milianw.
milianw added a comment.
This revision is now accepted and ready to land.
Still good from my side. @klimek, @rsmith: Could you please review this as
well?
Thanks
http://reviews.llvm.org/D15729
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262772: [X86] AMD Bobcat CPU (btver1) doesn't support XSAVE
(authored by RKSimon).
Changed prior to commit:
http://reviews.llvm.org/D17682?vs=49552=49877#toc
Repository:
rL LLVM
Author: rksimon
Date: Sat Mar 5 08:35:44 2016
New Revision: 262772
URL: http://llvm.org/viewvc/llvm-project?rev=262772=rev
Log:
[X86] AMD Bobcat CPU (btver1) doesn't support XSAVE
btver1 is a SSSE3/SSE4a only CPU - it doesn't have AVX and doesn't support
XSAVE.
Differential Revision:
Author: jfb
Date: Sat Mar 5 08:22:02 2016
New Revision: 262771
URL: http://llvm.org/viewvc/llvm-project?rev=262771=rev
Log:
libc++: fix typo
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
dsanders added a comment.
In http://reviews.llvm.org/D16139#368217, @echristo wrote:
> This seems wrong. You should fix setCPU instead or set a default CPU.
We already set a default CPU in the constructor (e.g.
Mips32TargetInfoBase::Mips32TargetInfoBase() provides "mips32r2"). It's the CPU
20 matches
Mail list logo
