Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv updated this revision to Diff 50698. faisalv marked 3 inline comments as done. faisalv added a comment. Updated patch that should incorporate Richard's feedback. Thanks! http://reviews.llvm.org/D18139 Files: include/clang/AST/LambdaCapture.h

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv marked 14 inline comments as done. faisalv added a comment. Thanks for the review! An updated patch that should address your concerns will follow in a few mins. I'm still not entirely sure I follow your comment about the intialized-entity: 'directly pass the fact that the capture in

[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao created this revision. sfantao added reviewers: ABataev, jlebar, tra, echristo, hfinkel. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, cfe-commits. This patch proposes a new class to generate and record action dependences related with offloading. The builder provides

[PATCH] D18170: [CUDA][OpenMP] Create generic offload toolchains

sfantao created this revision. sfantao added reviewers: ABataev, jlebar, tra, echristo, hfinkel. sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, cfe-commits. This patch introduces the concept of offloading tool chain and offloading kind. Each tool chain may have associated an

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

manmanren updated this revision to Diff 50682. http://reviews.llvm.org/D17865 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/Lex/PPMacroExpansion.cpp lib/Sema/SemaDeclAttr.cpp test/SemaCXX/attr-deprecated-replacement-error.cpp

r263514 - [ThinLTO] Clang side of renaming of function index (NFC)

Author: tejohnson Date: Mon Mar 14 19:04:44 2016 New Revision: 263514 URL: http://llvm.org/viewvc/llvm-project?rev=263514=rev Log: [ThinLTO] Clang side of renaming of function index (NFC) This is the companion to an LLVM patch that renamed the function index data structures and files to use the

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

On Mon, Mar 14, 2016 at 8:55 AM, Evgenii Stepanov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Mar 14, 2016 at 8:48 AM, Benjamin Kramer > wrote: > > On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie > wrote: > >> Yeah - how are they

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

On Mon, Mar 14, 2016 at 9:50 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > > Author: d0k > > Date: Mon Mar 14 08:23:58 2016 > > New Revision: 263429 > > > > URL:

[libcxx] r263507 - Missed this file in previous checkin

Author: marshall Date: Mon Mar 14 18:07:58 2016 New Revision: 263507 URL: http://llvm.org/viewvc/llvm-project?rev=263507=rev Log: Missed this file in previous checkin Modified: libcxx/trunk/test/support/nasty_containers.hpp Modified: libcxx/trunk/test/support/nasty_containers.hpp URL:

[libcxx] r263506 - Implement LWG2577: {shared, unique}_lock should use std::addressof

Author: marshall Date: Mon Mar 14 18:07:32 2016 New Revision: 263506 URL: http://llvm.org/viewvc/llvm-project?rev=263506=rev Log: Implement LWG2577: {shared,unique}_lock should use std::addressof Modified: libcxx/trunk/include/__mutex_base libcxx/trunk/include/shared_mutex

r263505 - clang/test/CodeGenCXX/virtual-function-attrs.cpp: Appease i686-mingw32 to expect x86_thiscallcc.

Author: chapuni Date: Mon Mar 14 18:00:44 2016 New Revision: 263505 URL: http://llvm.org/viewvc/llvm-project?rev=263505=rev Log: clang/test/CodeGenCXX/virtual-function-attrs.cpp: Appease i686-mingw32 to expect x86_thiscallcc. Modified: cfe/trunk/test/CodeGenCXX/virtual-function-attrs.cpp

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

> Sure, that's fine. However, I think we should delete them in >> LookupResult, right? The implicit copy and assignment ops are wrong and >> leak otherwise. >> > > Yep. But I'm happy enough to wait for the correct fix from Marina there. > Sounds good, just wanted to get the diff out there.

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc updated this revision to Diff 50668. pcc added a comment. - Add a test for passing arguments to the attribute http://reviews.llvm.org/D17893 Files: include/clang/AST/DeclCXX.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc added a comment. > Missing some attribute-related tests like attaching the attribute to > something other than a record, or passing arguments to the attribute. Added. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8345 @@ +8344,3 @@ +def

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

pcc updated this revision to Diff 50667. pcc marked 3 inline comments as done. pcc added a comment. - Address review comments http://reviews.llvm.org/D17893 Files: include/clang/AST/DeclCXX.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

rnk added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:268-290 @@ -265,1 +267,25 @@ + // abi_tag is a gcc attribute, taking one or more strings called "tags". + // + // The goal is to annotate against which version of a library an object was + // build and to be

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Mon, Mar 14, 2016 at 3:30 PM, don hinton wrote: > > > On Mon, Mar 14, 2016 at 6:24 PM, David Blaikie wrote: > >> >> >> On Mon, Mar 14, 2016 at 3:07 PM, don hinton wrote: >> >>> UnresolvedSetImpl isn't even constructible, much less

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Mon, Mar 14, 2016 at 3:07 PM, don hinton wrote: > UnresolvedSetImpl isn't even constructible, much less copy constructible, > but it is a public base class to UnresolvedSet, it it is -- at least until > we turn it off by deleting the copy ctor. > > template class

[PATCH] D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner. mspertus added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This adds visualizers for PointerType and TemplateTypeParmType. As I have been using these visualizers, I have found the

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

UnresolvedSetImpl isn't even constructible, much less copy constructible, but it is a public base class to UnresolvedSet, it it is -- at least until we turn it off by deleting the copy ctor. template class UnresolvedSet : public UnresolvedSetImpl { SmallVector

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

aaron.ballman added a comment. In http://reviews.llvm.org/D17865#374939, @manmanren wrote: > In http://reviews.llvm.org/D17865#374659, @aaron.ballman wrote: > > > Aside from the missing attribute documentation, looks good to me. > > > Hi Aaron, > > Which document are you referring to?

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

mspertus closed this revision. mspertus added a comment. Committed as revision 262933 http://reviews.llvm.org/D17908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14737: Convert some ObjC msgSends to runtime calls

pete updated this revision to Diff 50651. pete added a comment. Thanks for the example John. I understand what you mean now. I've added this piece to the test case which verifies that the following IR has the correct bit cast in it. Similarly added cases for alloc and autorelease. @class A;

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

UNresolvedSetImpl isn't copy constructible, so should it really be copy assignable? (it looks like it only needs to be so because of LookupResult - so once LookupResult is fixed, UnresolvedSetImpl can go back to the way it was) Perhaps we should just wait for the fix for LookupResult copying in

r263494 - Revert "[ThinLTO] Clang side of renaming of function index (NFC)"

Author: tejohnson Date: Mon Mar 14 16:18:17 2016 New Revision: 263494 URL: http://llvm.org/viewvc/llvm-project?rev=263494=rev Log: Revert "[ThinLTO] Clang side of renaming of function index (NFC)" This reverts commit r263491. Missed a file on the LLVM side. Modified:

r263491 - [ThinLTO] Clang side of renaming of function index (NFC)

Author: tejohnson Date: Mon Mar 14 16:06:06 2016 New Revision: 263491 URL: http://llvm.org/viewvc/llvm-project?rev=263491=rev Log: [ThinLTO] Clang side of renaming of function index (NFC) This is the companion to an LLVM patch that renamed the function index data structures and files to use the

Re: r263464 - CodeGen: Mark functions used in vtables as unnamed_addr.

Yes, and r263477 was the fix. Peter On Mar 14, 2016 13:59, "Renato Golin" wrote: > On 14 March 2016 at 18:42, Peter Collingbourne via cfe-commits > wrote: > > Author: pcc > > Date: Mon Mar 14 13:41:59 2016 > > New Revision: 263464 > > > >

r263483 - [CMake] Updating Apple Clang CMake caches

Author: cbieneman Date: Mon Mar 14 15:23:21 2016 New Revision: 263483 URL: http://llvm.org/viewvc/llvm-project?rev=263483=rev Log: [CMake] Updating Apple Clang CMake caches This is a big update that gets the public configurations more in line with the ones we're actually using internally to

r263477 - Relax test introduced in r263464 to accept ARM ABI output.

Author: pcc Date: Mon Mar 14 15:13:59 2016 New Revision: 263477 URL: http://llvm.org/viewvc/llvm-project?rev=263477=rev Log: Relax test introduced in r263464 to accept ARM ABI output. Should fix ARM bots. Modified: cfe/trunk/test/CodeGenCXX/virtual-function-attrs.cpp Modified:

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

yaxunl added a comment. we can turn off inlining when we build lib_common.ll, then do optimization and inlining after linking with lib_common.ll and lib_opt.ll. Even if linkonce_odr allows inlining, it is still OK. Repository: rL LLVM http://reviews.llvm.org/D18095

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

hintonda added a comment. Btw, what do you think about making -Wdeprecated the default for llvm/clang builds? With this change, llvm/clang will be clean. However, libcxx and libcxxabi have a bunch of throw warnings. http://reviews.llvm.org/D18123

Re: [PATCH] D17910: clang-format: [JS] Handle certain cases of ASI.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Submitted as r263470. http://reviews.llvm.org/D17910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r263470 - clang-format: [JS] Handle certain cases of ASI.

Author: djasper Date: Mon Mar 14 14:21:36 2016 New Revision: 263470 URL: http://llvm.org/viewvc/llvm-project?rev=263470=rev Log: clang-format: [JS] Handle certain cases of ASI. Automatic Semicolon Insertion can only be properly handled by parsing source code. However conservatively catching just

Re: [PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

rjmccall added a comment. Member function comparisons of virtual functions aren't required to work anyway. Itanium just happens to implement them in a way that kindof gets it right (for simple cases). Repository: rL LLVM http://reviews.llvm.org/D18071

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

rjmccall added a comment. Well, your overriding definitions will be strong definitions. The question is whether you want to allow inning of the weak definitions, i.e. the possibly-overridden ones, and there I would assume not. Repository: rL LLVM http://reviews.llvm.org/D18095

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric updated this revision to Diff 50627. ioeric marked 10 inline comments as done. ioeric added a comment. - renamed calculateChangedRangesInFile to calculateChangedRanges; removed const from FileToReplacementsMap key type. http://reviews.llvm.org/D17852 Files:

Re: [PATCH] D17910: clang-format: [JS] Handle certain cases of ASI.

djasper added a comment. Looks good. Comment at: lib/Format/UnwrappedLineParser.cpp:667 @@ +666,3 @@ +return true; + // FIXME(martinprobst): This returns true for C/C++ keywords like 'struct'. + return FormatTok->is(tok::identifier) && We don't usually

Re: [PATCH] D18113: CodeGen: Use 32-bit gep offsets to address vtable address points.

This revision was automatically updated to reflect the committed changes. Closed by commit rL263469: CodeGen: Use 32-bit gep offsets to address vtable address points. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D18113?vs=50506=50626#toc Repository: rL LLVM

r263469 - CodeGen: Use 32-bit gep offsets to address vtable address points.

Author: pcc Date: Mon Mar 14 14:07:10 2016 New Revision: 263469 URL: http://llvm.org/viewvc/llvm-project?rev=263469=rev Log: CodeGen: Use 32-bit gep offsets to address vtable address points. The relative vtable ABI will use a struct rather than an array as the type of a vtable. LLVM only allows

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

yaxunl added a comment. Yes we want the overriding functions to be allowed to be inlined. Repository: rL LLVM http://reviews.llvm.org/D18095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

rjmccall added a comment. linkonce_odr would allow them to be dropped if unused by the library. In fact, we don't normally emit IR for functions that are linkonce and not used. Do you actually want code in lib_common to e.g. inline the common implementation instead of calling the optimized

Re: [PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

This revision was automatically updated to reflect the committed changes. Closed by commit rL263464: CodeGen: Mark functions used in vtables as unnamed_addr. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D18071?vs=50500=50622#toc Repository: rL LLVM

r263464 - CodeGen: Mark functions used in vtables as unnamed_addr.

Author: pcc Date: Mon Mar 14 13:41:59 2016 New Revision: 263464 URL: http://llvm.org/viewvc/llvm-project?rev=263464=rev Log: CodeGen: Mark functions used in vtables as unnamed_addr. This marks virtual function declarations, as well as runtime library functions __cxa_pure_virtual,

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe updated this revision to Diff 50623. jbcoe marked 15 inline comments as done. jbcoe added a comment. Apply requested fixes from review. Thanks for taking time to review this, the patch is much improved for the attention. http://reviews.llvm.org/D16962 Files:

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

faisalv updated this revision to Diff 50621. faisalv added a comment. Add warnings and extension diagnostics for C++1z, and refactor the codegen portion, simplifying it further. Thanks! http://reviews.llvm.org/D18139 Files: include/clang/AST/LambdaCapture.h

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz added a comment. In http://reviews.llvm.org/D17741#372098, @weimingz wrote: > rebased ping~ http://reviews.llvm.org/D17741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

yaxunl added a comment. My last example is not proper. In real cases, the functions are overridden by functions with the same name and semantics but optimized for speed. Besides, we want unused library functions in lib_common.ll and lib_opt.ll to be dropped, weak attribute does not achieve

Re: [PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D18071#373687, @pcc wrote: > Done (this also affects `_purecall` in the MS ABI; I don't think this change > should break anything there, but

Re: [PATCH] D17451: PR26448: [Sema] Fix determined type of ternary operator acting on two xvalue class types

erik.pilkington updated this revision to Diff 50617. erik.pilkington added a comment. Fix the ill-generated diff. Would someone mind taking a look at this? http://reviews.llvm.org/D17451 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/conditional-expr.cpp Index:

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

rjmccall added a comment. Your use case violates the "ODR" restriction on linkonce_odr. Do you maybe just want __attribute__((weak))? Repository: rL LLVM http://reviews.llvm.org/D18095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

On Mon, Mar 14, 2016 at 10:45 AM, Yaxun Liu via cfe-commits wrote: > yaxunl added a comment. > > Thanks for your comments. > > It works like this, e.g. > > $ cat prog.ll > declare i32 @foo() > > define void @use_foo() { > > %a = call i32 @foo() > ret void > > } > >

Re: [libcxx] r263036 - Implement LWG#2583: There is no way to supply an allocator for basic_string(str, pos)

On Fri, Mar 11, 2016 at 7:32 AM, Nico Weber wrote: > I reverted this in 263246 for now. I think the right fix is just to > add _LIBCPP_INLINE_VISIBILITY to the new constructor, but I'm not 100% sure. > > On Thu, Mar 10, 2016 at 10:21 AM, Nico Weber

[libcxx] r263451 - Add failing tests that I forgot to add to the last commit

Author: marshall Date: Mon Mar 14 12:58:54 2016 New Revision: 263451 URL: http://llvm.org/viewvc/llvm-project?rev=263451=rev Log: Add failing tests that I forgot to add to the last commit Added: libcxx/trunk/test/std/containers/container.adaptors/priority.queue/types.fail.cpp

[libcxx] r263450 - Implement LWG#2566: Requirements on the first template parameter of container adaptors

Author: marshall Date: Mon Mar 14 12:58:11 2016 New Revision: 263450 URL: http://llvm.org/viewvc/llvm-project?rev=263450=rev Log: Implement LWG#2566: Requirements on the first template parameter of container adaptors Modified: libcxx/trunk/include/queue libcxx/trunk/include/stack

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

majnemer added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:217-218 @@ -216,2 +216,4 @@ raw_ostream + bool NullOut = false; + bool DisableDerivedAbiTags = false; Please add a comment describe this state. Comment at:

Re: [PATCH] D18136: boost-use-to-string check

Prazek added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:76-81 @@ +75,8 @@ +// CHECK-FIXES: fun(std::to_string(f)); + fun(boost::lexical_cast(g)); +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::to_string instead of boost::lexical_cast

Re: [PATCH] D18136: boost-use-to-string check

Prazek added a comment. There is also big issue here - I don't check if the type of argument is builtinType. I don't know why but matcher "builtinType" didn't work when I tried to use it. (like I wrote in another email) Comment at: clang-tidy/boost/UseToStringCheck.cpp:33 @@

Re: r261372 - [modules] Flatten -fmodule-name= and -fmodule-implementation-of= into a single

Sorry for the delay, the past couple of weeks have been crazy with C++ committee stuff. Should be fixed in r263449. On Mon, Mar 14, 2016 at 8:00 AM, Argyrios Kyrtzidis via cfe-commits wrote: > If not addressing the issue with '-fmodule-name' could you revert removal

r263449 - [modules] Don't diagnose non-modular includes from modular files that are

Author: rsmith Date: Mon Mar 14 12:52:37 2016 New Revision: 263449 URL: http://llvm.org/viewvc/llvm-project?rev=263449=rev Log: [modules] Don't diagnose non-modular includes from modular files that are implementation units of modules rather than interface units. Added:

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D18025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18095: Add __attribute__((linkonce_odr_linkage))

yaxunl added a comment. Thanks for your comments. It works like this, e.g. $ cat prog.ll declare i32 @foo() define void @use_foo() { %a = call i32 @foo() ret void } $ cat lib_common.ll define linkonce_odr i32 @foo() { ret i32 1; } $ cat lib_opt.ll define linkonce_odr i32 @foo() {

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

aaron.ballman added a comment. Aside from the missing attribute documentation, looks good to me. http://reviews.llvm.org/D17865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

hintonda updated this revision to Diff 50611. hintonda added a comment. Add move ctor and assignment operator defauls to match UnresolvedSetImpl's contained SmallVector. Add FIXME note to LookupResult. Will address FIXME once Marina's pending change to Sema::LookupInlineAsmField() is available.

Re: [PATCH] D17709: [MSVC Compat] Support for '__unaligned' attribute in function declaration

rnk added a comment. Unless there is a compelling example of Microsoft or a popular third-party header relying on this behavior, I don't think we should implement it. Comment at: lib/Parse/ParseDecl.cpp:4813 @@ -4812,1 +4812,3 @@ + if ((AttrReqs &

r263442 - [OpenMP] Replace offloading option that start with -o with -fo.

Author: sfantao Date: Mon Mar 14 10:57:41 2016 New Revision: 263442 URL: http://llvm.org/viewvc/llvm-project?rev=263442=rev Log: [OpenMP] Replace offloading option that start with -o with -fo. Summary: The current offloading implementation is using -omptargets and -omp-host-ir-file-path options

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

On Mon, Mar 14, 2016 at 8:48 AM, Benjamin Kramer wrote: > On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie wrote: >> Yeah - how are they relying on them in a non-asserts build anyway? (were we >> naming certain things regardless of +/-Asserts? (well, I know

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

bcraig added a subscriber: bcraig. bcraig added a comment. LGTM. I don't know if that's good enough for a submit though :) In my opinion, requiring heap allocation during an exception is one of the worst parts of the Itanium ABI. At least this particular path isn't triggered for platforms

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

On Mon, Mar 14, 2016 at 3:59 PM, David Blaikie wrote: > Yeah - how are they relying on them in a non-asserts build anyway? (were we > naming certain things regardless of +/-Asserts? (well, I know we were naming > some things, but mostly down in LLVM, I thought Clang generally

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping?.. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r261372 - [modules] Flatten -fmodule-name= and -fmodule-implementation-of= into a single

If not addressing the issue with '-fmodule-name' could you revert removal of original ‘-fmodule-implementation-of’ since we are depending on it ? > On Mar 3, 2016, at 6:13 PM, Argyrios Kyrtzidis via cfe-commits > wrote: > > Hey Richard, > > -fmodule-name emits

Re: r263429 - [Frontend] Disable value name discarding for all sanitizers.

Yeah - how are they relying on them in a non-asserts build anyway? (were we naming certain things regardless of +/-Asserts? (well, I know we were naming some things, but mostly down in LLVM, I thought Clang generally used the IRBuilder & thus didn't name things in non-Asserts builds)) On Mon, Mar

r263436 - Revert "Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26715 at r263379."

Author: d0k Date: Mon Mar 14 09:58:28 2016 New Revision: 263436 URL: http://llvm.org/viewvc/llvm-project?rev=263436=rev Log: Revert "Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26715 at r263379." This reverts commit r263425. Breaks

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:237 @@ +236,3 @@ +/// related to the same file entry are put into the same vector. +FileToReplacementsMap groupReplacementsByFile(const Replacements , +

r263434 - Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

Author: hahnfeld Date: Mon Mar 14 09:34:04 2016 New Revision: 263434 URL: http://llvm.org/viewvc/llvm-project?rev=263434=rev Log: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB Also introduce -stdlib=platform to override the configured value and use it to make the tests always pass.

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

This revision was automatically updated to reflect the committed changes. Closed by commit rL263434: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB (authored by Hahnfeld). Changed prior to commit: http://reviews.llvm.org/D17286?vs=49459=50592#toc Repository: rL LLVM

r263435 - Fix some more tests with CLANG_DEFAULT_CXX_STDLIB

Author: hahnfeld Date: Mon Mar 14 09:34:10 2016 New Revision: 263435 URL: http://llvm.org/viewvc/llvm-project?rev=263435=rev Log: Fix some more tests with CLANG_DEFAULT_CXX_STDLIB Also use -stdlib=platform instead of -stdlib=libstdc++ when testing if Clang chooses the correct default for the

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

Friendly PING. @klimek Hi Manuel, what do you think about the return type for groupReplacementsByFile? Daniel suggests that instead of "std::map", it returns "std::vector". On Sun, Mar 6, 2016 at 9:32 PM Eric Liu wrote: > ioeric added inline

Re: [PATCH] D18136: boost-use-to-string check

hokein added a subscriber: hokein. hokein added a comment. > Is there any better solution for the basic_string problem? The current solution looks fine to me. I don't have a better solution. Maybe @alexfh has. Comment at: docs/clang-tidy/checks/boost-use-to-string.rst:6 @@

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

hokein added inline comments. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:24 @@ +23,3 @@ + + // C++ constructor.. + Finder->addMatcher(cxxConstructorDecl().bind("Ctor"), this); Extra `.` at the end. Comment at:

r263429 - [Frontend] Disable value name discarding for all sanitizers.

Author: d0k Date: Mon Mar 14 08:23:58 2016 New Revision: 263429 URL: http://llvm.org/viewvc/llvm-project?rev=263429=rev Log: [Frontend] Disable value name discarding for all sanitizers. ASan also relies on names on allocas and will emit unhelpful output if they're not present. Just force-enable

Re: [PATCH] D18141: [clang-tidy] Fix "Name is not a simple identifier" assertion in `modernize-loop-convert` check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL263426: [clang-tidy] Fix "Name is not a simple identifier" assertion in `modernize… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D18141?vs=50580=50582#toc Repository: rL

[clang-tools-extra] r263426 - [clang-tidy] Fix "Name is not a simple identifier" assertion in `modernize-loop-convert` check.

Author: hokein Date: Mon Mar 14 07:41:24 2016 New Revision: 263426 URL: http://llvm.org/viewvc/llvm-project?rev=263426=rev Log: [clang-tidy] Fix "Name is not a simple identifier" assertion in `modernize-loop-convert` check. Summary: Fix assertion failure: "Name is not a simple identifier".

Re: [PATCH] D17709: [MSVC Compat] Support for '__unaligned' attribute in function declaration

aaron.ballman added a subscriber: aaron.ballman. Comment at: lib/Parse/ParseDecl.cpp:4811 @@ -4810,2 +4810,3 @@ case tok::kw___unaligned: - if (AttrReqs & AR_DeclspecAttributesParsed) { + // Allow __unaligned in function definition after a parameter list + if

Re: [PATCH] D14146: Introduction of -miamcu option

aturetsk abandoned this revision. aturetsk added a comment. The patch will be completely reworked and extended to support compilation for MCU. http://reviews.llvm.org/D14146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r263425 - Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info."

Author: aaboud Date: Mon Mar 14 07:03:55 2016 New Revision: 263425 URL: http://llvm.org/viewvc/llvm-project?rev=263425=rev Log: Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26715 at r263379. Added:

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

hintonda added a comment. Sure, that would be great. Thanks. http://reviews.llvm.org/D18123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17709: [MSVC Compat] Support for '__unaligned' attribute in function declaration

olga.a.chupina added a comment. Reid, cloud you please review the patch. http://reviews.llvm.org/D17709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18141: [clang-tidy] Fix "Name is not a simple identifier" assertion in `modernize-loop-convert` check.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good. Repository: rL LLVM http://reviews.llvm.org/D18141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r263422 - [Driver] Enable --rtlib option for MSVC target

Author: aturetsk Date: Mon Mar 14 06:19:43 2016 New Revision: 263422 URL: http://llvm.org/viewvc/llvm-project?rev=263422=rev Log: [Driver] Enable --rtlib option for MSVC target This enables "--rtlib compiler-rt" option under MSVC environment. Patch by Roman Shirokiy. Differential Revision:

Re: [PATCH] D17453: [Driver] Enable --rtlib option for MSVC target

This revision was automatically updated to reflect the committed changes. Closed by commit rL263422: [Driver] Enable --rtlib option for MSVC target (authored by aturetsk). Changed prior to commit: http://reviews.llvm.org/D17453?vs=50260=50579#toc Repository: rL LLVM

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

myatsina added a comment. In http://reviews.llvm.org/D18123#374170, @hintonda wrote: > LookupResult's copy ctor and assignment operator are used in > Sema::LookupInlineAsmField(). Looks like these were added back in December. > > I'll remove the defaults, from this patch, but not sure how to

Re: [PATCH] D12834: add gcc abi_tag support

DmitryPolukhin added a comment. Hi Pavel, Code review is not a good place to discuss such type of things. There is no really good workaround for this issue if you already have libraries built with C++ 11 and GCC configured to use abi_tag. But if you are doing it only for testing and you are

Re: [PATCH] D12834: add gcc abi_tag support

Hi Pavel, Code review is not a good place to discuss such type of things. There is no really good workaround for this issue if you already have libraries built with C++ 11 and GCC configured to use abi_tag. But if you are doing it only for testing and you are willing to build Clang yourself, you

Re: r263394 - Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

Hi Mehdi, Just letting you know that I committed a bit of a workaround for -fsanitize-memory-track-origins after this, the backend instrumentation pass was depending on the name of the alloca as a way of getting the name of the variable. I figured though that reverting was probably a bit overkill

r263412 - Temporarily make discard value names depend on whether or not we're

Author: echristo Date: Mon Mar 14 03:10:47 2016 New Revision: 263412 URL: http://llvm.org/viewvc/llvm-project?rev=263412=rev Log: Temporarily make discard value names depend on whether or not we're trying to track origins in the memory sanitizer since the backend instrumentation pass currently

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. ping http://reviews.llvm.org/D13126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki added a comment. ping. http://reviews.llvm.org/D15332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

On Windows (VS2015 update1) two unit tests fail: ``` [ RUN ] ImportExpr.ImportGNUNullExpr input.cc:1:23: warning: expression result unused [-Wunused-value] void declToImport() { __null; } ^~ G:\arbeit\llvm2\llvm\tools\clang\unittests\AST\ASTImporterTest.cpp(149):

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

sepavloff added a subscriber: sepavloff. sepavloff added a comment. On Windows (VS2015 update1) two unit tests fail: [ RUN ] ImportExpr.ImportGNUNullExpr input.cc:1:23: warning: expression result unused [-Wunused-value] void declToImport() { __null; } ^~

r263410 - Give the test a temporary output so it can be cleaned up.

Author: echristo Date: Mon Mar 14 01:21:07 2016 New Revision: 263410 URL: http://llvm.org/viewvc/llvm-project?rev=263410=rev Log: Give the test a temporary output so it can be cleaned up. Modified: cfe/trunk/test/Driver/cl-pch-showincludes.cpp Modified:

  1   2   >