Re: [PATCH] D18276: [OpenMP] Allow reduction on pointer dereference

ABataev added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:913-929 @@ -912,9 +912,19 @@ }); - } else if (auto *ASE = dyn_cast(IRef)) { -auto *Base = ASE->getBase()->IgnoreParenImpCasts(); -while (auto *TempASE = dyn_cast(Base)) -

r263920 - clang-cl: Add a comment about /Oy- (see r245913).

Author: nico Date: Sun Mar 20 21:48:05 2016 New Revision: 263920 URL: http://llvm.org/viewvc/llvm-project?rev=263920=rev Log: clang-cl: Add a comment about /Oy- (see r245913). Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td Modified:

Re: [PATCH] D17746: Fix PR26741 -- __builtin_object_size is not consistently conservative with C++ inheritance

On Sun, Mar 20, 2016 at 6:25 AM, Joerg Sonnenberger via cfe-commits wrote: > On Fri, Mar 18, 2016 at 05:11:19PM +, Richard Smith via cfe-commits wrote: >> rsmith added a comment. >> >> Can you explain a bit more about the problem? It seems to me that if I have: >>

Re: r263895 - P0184R0: Allow types of 'begin' and 'end' expressions in range-based for loops to differ.

On Sun, Mar 20, 2016 at 7:05 AM, Renato Golin wrote: > On 20 March 2016 at 11:33, Richard Smith via cfe-commits > wrote: >> Author: rsmith >> Date: Sun Mar 20 05:33:40 2016 >> New Revision: 263895 >> >> URL:

Re: [PATCH] D18303: Visual Studio Visualizers for clang::FunctionDecl

mspertus closed this revision. mspertus added a comment. Closing accepted revision http://reviews.llvm.org/D18303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18303: Visual Studio Visualizers for clang::FunctionDecl

mspertus added a comment. Committed as revision 263915. http://reviews.llvm.org/D18303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263915 - Visual Studio Visualizers for clang::FunctionDecl

Author: mps Date: Sun Mar 20 15:15:23 2016 New Revision: 263915 URL: http://llvm.org/viewvc/llvm-project?rev=263915=rev Log: Visual Studio Visualizers for clang::FunctionDecl Readably displays a FunctionDecl in the Visual Studio Locals Window something like: void g(int, double d, struct A &&

Re: [PATCH] D18299: Better visualization of clang::BuiltinType in VisualStudio

mspertus closed this revision. mspertus added a comment. Closing committed revision http://reviews.llvm.org/D18299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18299: Better visualization of clang::BuiltinType in VisualStudio

mspertus accepted this revision. mspertus added a reviewer: mspertus. mspertus added a comment. This revision is now accepted and ready to land. Per Aaron, I want to close the committed diff, but I seem to need to accept it first. Further discussion as needed on mailing list

Re: [PATCH] D18297: Visualizer for clang::FunctionProtoType

mspertus closed this revision. mspertus added a comment. Closing committed revision. Further discussion as needed on mailing list http://reviews.llvm.org/D18297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18297: Visualizer for clang::FunctionProtoType

mspertus accepted this revision. mspertus added a reviewer: mspertus. mspertus added a comment. This revision is now accepted and ready to land. Accepting revision based on Aaron's LGTM email to reviews.llvm.org. http://reviews.llvm.org/D18297 ___

Re: [PATCH] D18280: [tsan] Allow -fsanitize=thread for iOS-style simulator targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL263913: [tsan] Allow -fsanitize=thread for iOS-style simulator targets (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D18280?vs=51076=51132#toc Repository: rL LLVM

r263913 - [tsan] Allow -fsanitize=thread for iOS-style simulator targets

Author: dcoughlin Date: Sun Mar 20 13:24:33 2016 New Revision: 263913 URL: http://llvm.org/viewvc/llvm-project?rev=263913=rev Log: [tsan] Allow -fsanitize=thread for iOS-style simulator targets Update the clang driver to allow -fsanitize=thread when targeting x86_64 iOS and tvOS simulators.

[PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno created this revision. bruno added reviewers: bob.wilson, dexonsmith. bruno added a subscriber: cfe-commits. Previously only 3 digits were valid. Increase it to 5. http://reviews.llvm.org/D18304 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp lib/Driver/Tools.cpp

r263909 - AST: Fix some bogus indentation. NFC

Author: bogner Date: Sun Mar 20 11:58:03 2016 New Revision: 263909 URL: http://llvm.org/viewvc/llvm-project?rev=263909=rev Log: AST: Fix some bogus indentation. NFC Noticed by Liu Xin. Thanks! Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL:

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

flx added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:94 @@ +93,3 @@ + bool Bool{false}; + // CHECK-FIXES: bool Bool{false}; +}; aaron.ballman wrote: > Why is this checking a fix? I thought that point was that this

r263908 - Fixed -Wdocumentation warning

Author: rksimon Date: Sun Mar 20 11:25:23 2016 New Revision: 263908 URL: http://llvm.org/viewvc/llvm-project?rev=263908=rev Log: Fixed -Wdocumentation warning Modified: cfe/trunk/include/clang/Frontend/FrontendAction.h Modified: cfe/trunk/include/clang/Frontend/FrontendAction.h URL:

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

sfantao added a comment. Hi Richard, Thanks for your review. I partitioned some of the stuff I am proposing here in smaller patches: http://reviews.llvm.org/D18170 http://reviews.llvm.org/D18171 http://reviews.llvm.org/D18172 These patches already try to incorporate the feedback I got in

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 added a comment. In http://reviews.llvm.org/D16965#377864, @dblaikie wrote: > Not sure I fully understand the issue with the existing diagnostic/change in > wording. > > '::' is a nested name specifier, even if it's a degenerate case, I think - so > the old wording doesn't seem wrong,

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

baloghadamsoftware updated this revision to Diff 50932. baloghadamsoftware added a comment. Previous patch generation failed. http://reviews.llvm.org/D17986 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTest.cpp

Re: [PATCH] D17951: Implement is_always_lock_free

bcraig added a comment. Visual Studio has a flag, /Zc:wchar_t-, that turns wchar_t into a short. This flag is for people that need to maintain ABI compatibility with ancient Visual Studios (MSVC6? MSVC5?). It is definitely non-conformant, and many things support it poorly. I still have

[PATCH] D18303: Visual Studio Visualizers for clang::FunctionDecl

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner. mspertus added a subscriber: cfe-commits. Displays a FunctionDecl in the Visual Studio Locals Window something like: void g(int, double d, struct A && arr) http://reviews.llvm.org/D18303 Files: clang.natvis

Re: [PATCH] D18297: Visualizer for clang::FunctionProtoType

On Sat, Mar 19, 2016 at 8:29 PM, Mike Spertus wrote: > mspertus added a comment. > > Based on Aaron's agreement to conducting post-commit reviews, I've committed > this as revision 263890. Please let me know if I should not have done so. > (This change is a lot smaller and

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:94 @@ +93,3 @@ + bool Bool{false}; + // CHECK-FIXES: bool Bool{false}; +}; Why is this

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

aaron.ballman added a subscriber: aaron.ballman. Comment at: cppcoreguidelines/ProTypeMemberInitCheck.cpp:183 @@ +182,3 @@ + // Skip delayed template instantiation declarations. + const auto *Body = Ctor->getBody(); + if (!Body) Please do not use auto here

Re: [PATCH] D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

mspertus added a comment. Committed as revision 263638. At Chandler's suggestion, I am going to send an announcement to cfe-dev letting people know of all of the recent improvements to native visualizers http://reviews.llvm.org/D18163 ___

[clang-tools-extra] r263900 - [clang-tidy] Update check for API change in r263895.

Author: d0k Date: Sun Mar 20 09:24:49 2016 New Revision: 263900 URL: http://llvm.org/viewvc/llvm-project?rev=263900=rev Log: [clang-tidy] Update check for API change in r263895. for range stmts now have split begin and ends, just apply OR to the condition. Should unbreak the build. Modified:

Re: r263895 - P0184R0: Allow types of 'begin' and 'end' expressions in range-based for loops to differ.

On 20 March 2016 at 11:33, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Sun Mar 20 05:33:40 2016 > New Revision: 263895 > > URL: http://llvm.org/viewvc/llvm-project?rev=263895=rev > Log: > P0184R0: Allow types of 'begin' and 'end' expressions in

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rnk added a comment. I'm not sure your example is in scope for -Wshadow, though. Any function call that takes a non-const reference to the parameter could modify it. I guess I'm thinking something like: void trim_in_place(std::string ); struct A { std::string s; A(std::string s) :

Re: [PATCH] D17950: Implement is_always_lock_free

On Fri, Mar 18, 2016 at 12:11:22PM -0500, Craig, Ben via cfe-commits wrote: > A lot of it is a frontend decision. What goes in the libcall feels an awful > lot like the 386 vs 486 example that I hear a lot. If I want one binary > that can run on both a 386 (very limited atomic support) and a 486

Re: [PATCH] D17746: Fix PR26741 -- __builtin_object_size is not consistently conservative with C++ inheritance

On Fri, Mar 18, 2016 at 05:11:19PM +, Richard Smith via cfe-commits wrote: > rsmith added a comment. > > Can you explain a bit more about the problem? It seems to me that if I have: > > struct Base { > char k[1]; > }; > struct Derived : Base {}; > > ... then the 'k' subobject of a

Re: r263893 - Reapply [2] [VFS] Add 'overlay-relative' field to YAML files

On Sun, Mar 20, 2016 at 3:08 AM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Sat Mar 19 21:08:48 2016 > New Revision: 263893 > > URL: http://llvm.org/viewvc/llvm-project?rev=263893=rev > Log: > Reapply [2] [VFS] Add 'overlay-relative' field to

Re: r263718 - Use a simpler set of mock headers for the vfs+modules crash recovery tests.

Nice! Thanks Benjamin On Thu, Mar 17, 2016 at 9:19 AM, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Thu Mar 17 11:19:51 2016 > New Revision: 263718 > > URL: http://llvm.org/viewvc/llvm-project?rev=263718=rev > Log: > Use a simpler set of mock headers

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Hi Daniel, I'm not sure I understand the logic behind modifying 'AlwaysBreak' to be 'AlwaysBreakExceptForSingleArgument'. AlwaysBreak is always going to lead to "wasted space". Some consider consistently break to not be a waste but actually contribute to readability, it seems that was what

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

JVApen accepted this revision. JVApen added a comment. This revision is now accepted and ready to land. I'm not sure if I'm the right person to do reviews, as I'm mostly a user of the tool and have not yet done any developments or bug fixes to it. However, from what I know from coding, this

r263895 - P0184R0: Allow types of 'begin' and 'end' expressions in range-based for loops to differ.

Author: rsmith Date: Sun Mar 20 05:33:40 2016 New Revision: 263895 URL: http://llvm.org/viewvc/llvm-project?rev=263895=rev Log: P0184R0: Allow types of 'begin' and 'end' expressions in range-based for loops to differ. Modified: cfe/trunk/include/clang/AST/StmtCXX.h

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

pxli168 updated this revision to Diff 51126. http://reviews.llvm.org/D17596 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl === --- /dev/null +++

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

pxli168 marked 2 inline comments as done. pxli168 added a comment. http://reviews.llvm.org/D17596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

pxli168 added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:15 @@ +14,2 @@ +// CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]} +// CL20: [[SPIR]] = !{i32 2, i32 0} Anastasia wrote: > Forgotten to check OpenCL version here? The metadate will be

Re: [PATCH] D18280: [tsan] Allow -fsanitize=thread for iOS-style simulator targets

samsonov added a comment. Cool, great to see this coming. I'll let Kuba sign this off. Comment at: test/Driver/fsanitize.c:220 @@ -219,1 +219,3 @@ +// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=thread %s -### 2>&1 | FileCheck %s

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek updated this revision to Diff 51087. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

r263785 - Make LookupResult movable again.

Author: d0k Date: Fri Mar 18 08:31:00 2016 New Revision: 263785 URL: http://llvm.org/viewvc/llvm-project?rev=263785=rev Log: Make LookupResult movable again. We lost copy semantics in r263730, because it only worked for a few very specific cases. Move semantics don't have this issue. Sadly the

Re: [PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

etienneb updated this revision to Diff 51046. etienneb marked 2 inline comments as done. etienneb added a comment. Added test. http://reviews.llvm.org/D18262 Files: ClangTidy.cpp misc-macro-parentheses-cmdline.cpp Index: misc-macro-parentheses-cmdline.cpp

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

rsmith added a comment. Note that the diagnostic wording has already been fixed compared with the diagnostic reported in that bug report. Do we actually need more changes here? http://reviews.llvm.org/D16965 ___ cfe-commits mailing list

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

hintonda updated this revision to Diff 50930. hintonda added a comment. Fixed comment per Dave's recommendation. http://reviews.llvm.org/D18123 Files: include/clang/AST/UnresolvedSet.h include/clang/Sema/Lookup.h Index: include/clang/Sema/Lookup.h

r263750 - Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files"

Author: bruno Date: Thu Mar 17 16:30:55 2016 New Revision: 263750 URL: http://llvm.org/viewvc/llvm-project?rev=263750=rev Log: Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files" Tests failing on http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/46102 This reverts commit

r263638 - Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

Author: mps Date: Wed Mar 16 09:27:50 2016 New Revision: 263638 URL: http://llvm.org/viewvc/llvm-project?rev=263638=rev Log: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types Created visualizer for PointerType, LValueReferenceType,

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

mspertus added a comment. I think the code is correct as written, see response in comment Comment at: clang.natvis:77 @@ +76,3 @@ + + + aaron.ballman wrote: > The only hard-wiring I see uses 3 bits, so is this comment still accurate? I think the code is

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc updated this revision to Diff 51061. pcc added a comment. - Use a vindex of 0 for non-virtuals http://reviews.llvm.org/D18199 Files: docs/UsersManual.rst lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGVTables.cpp lib/CodeGen/CGVTables.h lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

sfantao added a comment. Hi Alexey, I am sorry but I don't think I am following. So in your example: #pragma omp target map(to: this->A) []()->void {++A}(); the map clause is going to make sure the runtime library allocates the section of `this` that contains A and that is what is used in

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943 @@ +4934,11 @@ + + bool HasStableAttr = Record->hasAttr(); + bool HasUnstableAttr = Record->hasAttr(); + if (HasStableAttr && HasUnstableAttr) { +Diag(Record->getLocation(),

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

2016-03-18 0:35 GMT+06:00 Arthur O'Dwyer : > I'm not qualified to comment on the implementation, but I'm a bit > skeptical that this warning is appropriate in the first place. I've often > declared friend non-template functions, e.g. swap(). I've never intended to >