Re: [PATCH] D17955: [OpenCL] Fix pipe builtin bugs

pxli168 updated this revision to Diff 51629. pxli168 added a comment. Add test for correct case. http://reviews.llvm.org/D17955 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl Index:

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

faisalv updated this revision to Diff 51627. faisalv added a comment. An updated patch that incorporates Richard's feedback. Thanks! http://reviews.llvm.org/D14905 Files: include/clang/Basic/DiagnosticASTKinds.td include/clang/Basic/DiagnosticParseKinds.td include/clang/Sema/Sema.h

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

faisalv marked 8 inline comments as done. faisalv added a comment. Thanks for the review - will submit a updated patch with recommended changes, shortly. http://reviews.llvm.org/D14905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r264377 - [modules] Store a local offset to DeclContext lexical and visible contents. Saves a few bytes for each primary DeclContext.

Author: rsmith Date: Thu Mar 24 20:17:43 2016 New Revision: 264377 URL: http://llvm.org/viewvc/llvm-project?rev=264377=rev Log: [modules] Store a local offset to DeclContext lexical and visible contents. Saves a few bytes for each primary DeclContext. Modified:

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

jlebar added a comment. In http://reviews.llvm.org/D18458#383266, @rsmith wrote: > This makes the "`constexpr` implies `__host__` `__device__`" patch look > slightly questionable: two translation units defining the same `constexpr` > function will mangle that function differently depending on

r264372 - CGLoopInfo: Use the MD_loop metadata kind from r264371, NFC

Author: dexonsmith Date: Thu Mar 24 19:38:14 2016 New Revision: 264372 URL: http://llvm.org/viewvc/llvm-project?rev=264372=rev Log: CGLoopInfo: Use the MD_loop metadata kind from r264371, NFC Besides a small compile-time speedup, there should be no real functionality change here. Modified:

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

rsmith added a comment. This makes the "`constexpr` implies `__host__` `__device__`" patch look slightly questionable: two translation units defining the same `constexpr` function will mangle that function differently depending on whether the translation unit is built with CUDA support

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

Great, thanks! On Thu, Mar 24, 2016, 5:26 PM Adrian Prantl wrote: > I added a testcase that demonstrates the problem with this commit in > r264366. > > -- adrian > > On Feb 23, 2016, at 11:07 AM, Eric Christopher > wrote: > > > > Thanks Adrian! > > > > On

[clang-tools-extra] r264367 - 3rd attempt of fixup with -std=c++11

Author: chapuni Date: Thu Mar 24 19:24:35 2016 New Revision: 264367 URL: http://llvm.org/viewvc/llvm-project?rev=264367=rev Log: 3rd attempt of fixup with -std=c++11 Modified: clang-tools-extra/trunk/test/clang-tidy/readability-redundant-string-cstr.cpp Modified:

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

I added a testcase that demonstrates the problem with this commit in r264366. -- adrian > On Feb 23, 2016, at 11:07 AM, Eric Christopher wrote: > > Thanks Adrian! > > On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote: > --> r261657. > > Author: adrian

r264366 - Debug Info: Add a testcase for the bug introduced by r259975.

Author: adrian Date: Thu Mar 24 19:20:35 2016 New Revision: 264366 URL: http://llvm.org/viewvc/llvm-project?rev=264366=rev Log: Debug Info: Add a testcase for the bug introduced by r259975. In r259975 we rauw'ed the scope of enum declarations without taking into account that DIBuilder strips out

Re: [PATCH] D5041: Fix for clang_Cursor_getSpellingNameRange() reportage of C++ functions

rsmith added a subscriber: rsmith. rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D5041 ___ cfe-commits mailing list

[clang-tools-extra] r264365 - Fixup -- "-target x86_64-unknown -fno-ms-compatibility" didn't work as expected.

Author: chapuni Date: Thu Mar 24 19:16:13 2016 New Revision: 264365 URL: http://llvm.org/viewvc/llvm-project?rev=264365=rev Log: Fixup -- "-target x86_64-unknown -fno-ms-compatibility" didn't work as expected. Modified:

r264363 - Fix nondeterminism in computation of builtin operator overload sets.

Author: rsmith Date: Thu Mar 24 19:08:53 2016 New Revision: 264363 URL: http://llvm.org/viewvc/llvm-project?rev=264363=rev Log: Fix nondeterminism in computation of builtin operator overload sets. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp cfe/trunk/test/SemaCXX/diagnostic-order.cpp

[clang-tools-extra] r264362 - clang-tools-extra/test/clang-tidy/readability-redundant-string-cstr.cpp: Appease MS targets with -fno-ms-compatibility.

Author: chapuni Date: Thu Mar 24 19:05:33 2016 New Revision: 264362 URL: http://llvm.org/viewvc/llvm-project?rev=264362=rev Log: clang-tools-extra/test/clang-tidy/readability-redundant-string-cstr.cpp: Appease MS targets with -fno-ms-compatibility. FIXME: Add a test with -fms-compatibility.

Re: [PATCH] D5041: Fix for clang_Cursor_getSpellingNameRange() reportage of C++ functions

milianw added a comment. +1 from my side, but someone else has to approve. http://reviews.llvm.org/D5041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r264359 - [modules] Store offset to LOCAL_REDECLARATIONS record relative to the current

Author: rsmith Date: Thu Mar 24 18:41:14 2016 New Revision: 264359 URL: http://llvm.org/viewvc/llvm-project?rev=264359=rev Log: [modules] Store offset to LOCAL_REDECLARATIONS record relative to the current record rather than relative to the start of the bitcode file. Saves a couple of bytes per

Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

rjmccall added a comment. Oh, you know, this should really propagate all the dependence bits, not just instantiation-dependence. It would be safer, at least. You could probably find a contrived example involving value-dependence. http://reviews.llvm.org/D18461

Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

rjmccall added a comment. LGTM. http://reviews.llvm.org/D18461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17951: Implement is_always_lock_free

jfb updated this revision to Diff 51607. jfb added a comment. Herald added a subscriber: jfb. - Check feature test macro exists http://reviews.llvm.org/D17951 Files: include/atomic test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp Index:

RE: r264281 - Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info."

Hi Alexey, It will help to have a reproducer that fail without assertions. If I remove the assertion, the test failed in clang self-build will pass. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/11281 Thanks, Amjad From: Alexey Samsonov [mailto:vonos...@gmail.com]

Re: [PATCH] D17951: Implement is_always_lock_free

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r264342 - Attach profile summary information to Module.

Author: eraman Date: Thu Mar 24 16:32:25 2016 New Revision: 264342 URL: http://llvm.org/viewvc/llvm-project?rev=264342=rev Log: Attach profile summary information to Module. Differential Revision: http://reviews.llvm.org/D18289 Added: cfe/trunk/test/Profile/Inputs/profile-summary.proftext

Re: [PATCH] D16797: Update clang support on recent Haiku

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Please rebase against trunk. I'm surprised that no tests need updating due to this. Can you add some, please? Comment at: lib/Basic/Targets.cpp:387 @@ +386,3 @@ +

Re: r264281 - Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info."

I've been using no-asserts build, and it led to segfault, so probably it was required. I see that Reid already proceeded with the revert. I will still work on a reproducer. On Thu, Mar 24, 2016 at 1:43 PM, Aboud, Amjad wrote: > I believe it is safe to disable the

r264333 - Revert "Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26942 (the fix is included in this commit)."

Author: rnk Date: Thu Mar 24 15:38:43 2016 New Revision: 264333 URL: http://llvm.org/viewvc/llvm-project?rev=264333=rev Log: Revert "Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26942 (the fix is included in this commit)." This

[PATCH] D18461: ObjCXX: Warn undeclared identifiers.

manmanren created this revision. manmanren added reviewers: rsmith, rjmccall. manmanren added a subscriber: cfe-commits. Instantiation dependence were not being handled correctly for OpqaueValueExpr AST nodes. As a result, if an undeclared identifier was used in a CXXNewExpr that is assigned to a

Re: [PATCH] D18289: Attach profile summary information to module

davidxl accepted this revision. davidxl added a reviewer: davidxl. davidxl added a comment. lgtm http://reviews.llvm.org/D18289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18289: Attach profile summary information to module

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. This lgtm. IMO we'd get the same coverage if the C file contained `void foo() {}`, but that's just a nit :). It'd be good to follow up with David about what he thinks is lacking in

Re: [PATCH] D18289: Attach profile summary information to module

eraman added a comment. Since test case tests this change - that profile summary is attached to the module - I think it is sufficient. David and Vedant, does this sound reasonable? http://reviews.llvm.org/D18289 ___ cfe-commits mailing list

Re: r264281 - Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info."

Heads-up: I see segmentation faults in Clang following this revision. I will try to come up with a standalone reproducer and update https://llvm.org/bugs/show_bug.cgi?id=26942, possibly reverting this change. On Thu, Mar 24, 2016 at 6:30 AM, Amjad Aboud via cfe-commits <

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Hi Jean-Philippe, first off, sorry that this is causing you trouble. I am always happy to reconsider. However, I do think that this is a good change based on hundreds of examples I have looked at. Obviously, this is subjective and I won't even start to make an argument on whether this is wasted

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. Ping! http://reviews.llvm.org/D18296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Ping! http://reviews.llvm.org/D18304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar marked an inline comment as done. jlebar added a comment. Okay, just one more patch, http://reviews.llvm.org/D18458, then I think we're good here. (This is split up into two patches in my queue.) Thanks for your help, Richard. http://reviews.llvm.org/D18380

[PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. This is important because in a later patch, we will allow __host__ __device__ functions to be overloaded with __host__ / __device__ functions with the same signature, and we don't want a

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar marked 2 inline comments as done. Comment at: include/clang/Basic/LangOptions.def:175 @@ -174,2 +174,3 @@ LANGOPT(CUDAAllowVariadicFunctions, 1, 0, "Allow variadic functions in CUDA device code") +LANGOPT(CUDAHostDeviceConstexpr, 1, 1, "Treat unattributed constexpr

[clang-tools-extra] r264325 - [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

Author: etienneb Date: Thu Mar 24 14:42:36 2016 New Revision: 264325 URL: http://llvm.org/viewvc/llvm-project?rev=264325=rev Log: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker. Summary: The current checker is able to recognize std::string

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG now. Thanks! http://reviews.llvm.org/D18412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

etienneb marked an inline comment as done. etienneb added a comment. Tests are fine. PTAnL? Comment at: clang-tidy/readability/RedundantStringCStrCheck.cpp:103 @@ +102,3 @@ +callee(memberExpr().bind("member")), +

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

etienneb updated this revision to Diff 51585. etienneb added a comment. fix hasName. http://reviews.llvm.org/D18412 Files: clang-tidy/readability/RedundantStringCStrCheck.cpp test/clang-tidy/readability-redundant-string-cstr.cpp Index: test/clang-tidy/readability-redundant-string-cstr.cpp

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

etienneb updated this revision to Diff 51584. etienneb added a comment. update comment. http://reviews.llvm.org/D18457 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SuspiciousMissingCommaCheck.cpp clang-tidy/misc/SuspiciousMissingCommaCheck.h

r264323 - Change ADL to produce lookup results in a deterministic order. This fixes some

Author: rsmith Date: Thu Mar 24 14:12:22 2016 New Revision: 264323 URL: http://llvm.org/viewvc/llvm-project?rev=264323=rev Log: Change ADL to produce lookup results in a deterministic order. This fixes some rare issues with nondeterministic diagnostic order, and some very common issues with

[PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This checker is able to detect missing comma in an array of string literals. ``` const char* A[] = { "abc", "def" // missing comma (no compiler warnings) "ghi", }; ```

Re: [PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. OK, if you're not blocked on this, let's just wait then. http://reviews.llvm.org/D17981 ___ cfe-commits mailing list

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc updated this revision to Diff 51580. pcc added a comment. - Compute a correct byte offset for struct vtable bitsets http://reviews.llvm.org/D18199 Files: docs/UsersManual.rst lib/CodeGen/CGClass.cpp lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGVTables.cpp lib/CodeGen/CGVTables.h

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 24, 2016 at 11:29 AM, Aaron Ballman wrote: > On Thu, Mar 24, 2016 at 12:23 PM, David Majnemer > wrote: >> >> >> On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman >> wrote: >>> >>> On Thu, Mar 24, 2016 at 11:49

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

alexfh added inline comments. Comment at: clang-tidy/readability/RedundantStringCStrCheck.cpp:103 @@ +102,3 @@ +callee(memberExpr().bind("member")), +callee(cxxMethodDecl(matchesName(StringCStrMethod + .bind("call");

r264315 - Fix a missing comma between two string literals.

Author: etienneb Date: Thu Mar 24 13:29:24 2016 New Revision: 264315 URL: http://llvm.org/viewvc/llvm-project?rev=264315=rev Log: Fix a missing comma between two string literals. Summary: The two literals are currently appended. I'm not sure what was broken by this. Please double check

Re: [PATCH] D18454: Fix a missing comma between two string literals.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, I'd go ahead and land this. I cc'd Matt Arsenault. He works on AMD GPU stuff. http://reviews.llvm.org/D18454 ___ cfe-commits mailing list

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 24, 2016 at 12:23 PM, David Majnemer wrote: > > > On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman > wrote: >> >> On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote: >> > On Thu, Mar 3, 2016 at 10:40 AM, Aaron

[PATCH] D18454: Fix a missing comma between two string literals.

etienneb created this revision. etienneb added reviewers: alexfh, rnk. etienneb added a subscriber: cfe-commits. The two literals are currently appended. I'm not sure what was broken by this. Please double check carefully. Silly bug found by an on-going checker for clang-tidy.

Re: [PATCH] D16797: Update clang support on recent Haiku

korli added a comment. Yes, I don't have commit access. Repository: rL LLVM http://reviews.llvm.org/D16797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16797: Update clang support on recent Haiku

rsmith added a comment. Do you need someone to commit this for you? Repository: rL LLVM http://reviews.llvm.org/D16797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. The change to allow `__host__ __device__` functions to be overloaded with other combinations of target attributes appears to be separable from the `constexpr` change; please split it out and commit it first.

Re: [PATCH] D16797: Update clang support on recent Haiku

korli updated this revision to Diff 51571. korli added a comment. This updated diff fixes the x86-32 Haiku target, which needs the target define __INTEL__. This applies directly to today's trunk. Repository: rL LLVM http://reviews.llvm.org/D16797 Files: lib/Basic/Targets.cpp

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 24, 2016 at 9:23 AM, David Majnemer wrote: > > > On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman > wrote: >> >> On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote: >> > On Thu, Mar 3, 2016 at 10:40 AM, Aaron

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli added a comment. Hi Thinking more carefully, I believe you are right - no, it is not. I guess we would not call at all shouldEmitInlinedTeamsDirective for the case of paralle. Thanks! Repository: rL LLVM http://reviews.llvm.org/D18286

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

Hahnfeld added a comment. In http://reviews.llvm.org/D18286#382698, @carlo.bertolli wrote: > Hi Jonas > > Thanks for your comment. That scheme would not work for #parallel on the gpu > in case we do not want to inline the parallel region. > There are patches coming in which that is going to

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar added a comment. Richard, are you happy here? http://reviews.llvm.org/D18380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli added a comment. Hi Jonas Thanks for your comment. That scheme would not work for #parallel on the gpu in case we do not want to inline the parallel region. There are patches coming in which that is going to happen so I think that we really need to distinguish between different

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 24, 2016 at 9:09 AM, Aaron Ballman wrote: > On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote: > > On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman > > wrote: > >> > >> That was what I meant by "justification". I

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 24, 2016 at 11:49 AM, Reid Kleckner wrote: > On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman > wrote: >> >> That was what I meant by "justification". I would say it has to be >> reasonably compelling code (win32 headers, boost, some other major

Re: [PATCH] D17444: PR26672: [MSVC] Clang does not recognize "static_assert" keyword in C mode

On Thu, Mar 3, 2016 at 10:40 AM, Aaron Ballman wrote: > That was what I meant by "justification". I would say it has to be > reasonably compelling code (win32 headers, boost, some other major > library) as that's our usual bar for these sort of bug-for-bug > compatible

Re: r264205 - [CUDA] Don't define __NVCC__.

Fair enough - 'preciate your perspectives/further details. On Thu, Mar 24, 2016 at 8:44 AM, Hal Finkel wrote: > > -- > > *From: *"Reid Kleckner via cfe-commits" > *To: *"David Blaikie" > *Cc:

Re: r264205 - [CUDA] Don't define __NVCC__.

- Original Message - > From: "Reid Kleckner via cfe-commits" > To: "David Blaikie" > Cc: "cfe-commits" > Sent: Thursday, March 24, 2016 10:39:18 AM > Subject: Re: r264205 - [CUDA] Don't define __NVCC__. > On

Re: r264205 - [CUDA] Don't define __NVCC__.

On Thu, Mar 24, 2016 at 8:30 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > This seems like a different tradeoff from the one Clang made for GCC > compatibility (we define all the GCC macros, but then also define others so > people can detect Clang). If people were just

Re: [PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D18430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r264205 - [CUDA] Don't define __NVCC__.

On Wed, Mar 23, 2016 at 3:42 PM, Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jlebar > Date: Wed Mar 23 17:42:27 2016 > New Revision: 264205 > > URL: http://llvm.org/viewvc/llvm-project?rev=264205=rev > Log: > [CUDA] Don't define __NVCC__. > > Summary: > We decided

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

etienneb updated this revision to Diff 51559. etienneb added a comment. remove dead-code http://reviews.llvm.org/D18412 Files: clang-tidy/readability/RedundantStringCStrCheck.cpp test/clang-tidy/readability-redundant-string-cstr.cpp Index:

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

alexfh added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:67 @@ -66,3 +66,3 @@ auto UsedByRef = [&] { return !ast_matchers::match( decl(hasDescendant( It looks like the two-parameter ast_matchers::match function

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

etienneb updated this revision to Diff 51558. etienneb added a comment. Change name/decl matchers to 'basic_string'. http://reviews.llvm.org/D18412 Files: clang-tidy/readability/RedundantStringCStrCheck.cpp test/clang-tidy/readability-redundant-string-cstr.cpp Index:

Re: [PATCH] D17987: [clang-tidy] Extension of checker misc-misplaced-widening-cast

alexfh added inline comments. Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:116 @@ +115,3 @@ + + if (RelativeIntSizes.find(First) != RelativeIntSizes.end() && + RelativeIntSizes.find(Second) != RelativeIntSizes.end()) { This code shouldn't

Re: [PATCH] D18274: [clang-tidy] Add boost module

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. I would add the module together with the first check in it, since an empty module doesn't make sense. http://reviews.llvm.org/D18274

r264289 - Dsiable FormatStyle::GetStyleOfFile test case for mingw.

Author: ioeric Date: Thu Mar 24 09:59:39 2016 New Revision: 264289 URL: http://llvm.org/viewvc/llvm-project?rev=264289=rev Log: Dsiable FormatStyle::GetStyleOfFile test case for mingw. Modified: cfe/trunk/unittests/Format/FormatTest.cpp Modified: cfe/trunk/unittests/Format/FormatTest.cpp

Re: [PATCH] D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Thank you! Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:26 @@ +25,3 @@ + return (Name.empty() ? llvm::Twine('#') + llvm::Twine(Index + 1) +

Re: [PATCH] D18408: readability check for const params in declarations

alexfh added a comment. Looks good in general. A few nits. Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:22 @@ +21,3 @@ + +SourceRange GetTypeRange(const ParmVarDecl ) { + if (Param.getIdentifier() != nullptr) "Function names ... should be

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware updated this revision to Diff 51554. baloghadamsoftware added a comment. Merged into misc-assign-operator-signature and thus renamed to misc-assign-operator http://reviews.llvm.org/D18265 Files: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Re: [PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

etienneb added a comment. In http://reviews.llvm.org/D17981#382478, @alexfh wrote: > ... and who is unavailable for the next couple of weeks, unfortunately. To > unblock you, I'd suggest the following solution for now: > > 1. move this code to clang/lib/Tooling > 2. gate the code and its

Re: r264277 - Added support for different VFSs in format::getStyle. Disable platform-related test case for MS compilers to avoid breaking buildbot.

I am looking into it now. On Thu, Mar 24, 2016 at 2:39 PM Nico Weber wrote: > Won't this still be broken in mingw (GCC, but on Windows)? > On Mar 24, 2016 9:28 AM, "Eric Liu via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > >> Author: ioeric >> Date: Thu Mar 24

Re: r264277 - Added support for different VFSs in format::getStyle. Disable platform-related test case for MS compilers to avoid breaking buildbot.

Won't this still be broken in mingw (GCC, but on Windows)? On Mar 24, 2016 9:28 AM, "Eric Liu via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date: Thu Mar 24 08:22:42 2016 > New Revision: 264277 > > URL: http://llvm.org/viewvc/llvm-project?rev=264277=rev > Log: > Added

r264281 - Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info."

Author: aaboud Date: Thu Mar 24 08:30:41 2016 New Revision: 264281 URL: http://llvm.org/viewvc/llvm-project?rev=264281=rev Log: Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26942 (the fix is included in this commit). Differential

r264275 - Revert "removed redundant comment in format::getStyle."

Author: ioeric Date: Thu Mar 24 08:22:28 2016 New Revision: 264275 URL: http://llvm.org/viewvc/llvm-project?rev=264275=rev Log: Revert "removed redundant comment in format::getStyle." This reverts commit r264254. Modified: cfe/trunk/lib/Format/Format.cpp Modified:

r264277 - Added support for different VFSs in format::getStyle. Disable platform-related test case for MS compilers to avoid breaking buildbot.

Author: ioeric Date: Thu Mar 24 08:22:42 2016 New Revision: 264277 URL: http://llvm.org/viewvc/llvm-project?rev=264277=rev Log: Added support for different VFSs in format::getStyle. Disable platform-related test case for MS compilers to avoid breaking buildbot. Modified:

r264276 - Revert "Added support for different VFSs in format::getStyle."

Author: ioeric Date: Thu Mar 24 08:22:37 2016 New Revision: 264276 URL: http://llvm.org/viewvc/llvm-project?rev=264276=rev Log: Revert "Added support for different VFSs in format::getStyle." This reverts commit r264253. It is breaking the buildbot

Re: [PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

alexfh added a comment. In http://reviews.llvm.org/D17981#382213, @etienneb wrote: > In http://reviews.llvm.org/D17981#380350, @alexfh wrote: > > > Adding Manuel, who might have better ideas. > ... and who is unavailable for the next couple of weeks, unfortunately. To unblock you, I'd suggest

r264263 - Fix Sphinx errors with documentation build.

Author: aaronballman Date: Thu Mar 24 07:34:44 2016 New Revision: 264263 URL: http://llvm.org/viewvc/llvm-project?rev=264263=rev Log: Fix Sphinx errors with documentation build. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL:

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:3074-3078 @@ +3073,7 @@ + + if (getLangOpts().OpenMPIsDevice && ( + CGM.getTarget().getTriple().getArch() == llvm::Triple::nvptx || + CGM.getTarget().getTriple().getArch() ==

r264257 - Revert "Added support for different VFSs in format::getStyle."

Author: ioeric Date: Thu Mar 24 06:25:28 2016 New Revision: 264257 URL: http://llvm.org/viewvc/llvm-project?rev=264257=rev Log: Revert "Added support for different VFSs in format::getStyle." This reverts commit r264253. It is breaking the buildbot

r264256 - Revert "removed redundant comment in format::getStyle."

Author: ioeric Date: Thu Mar 24 06:24:49 2016 New Revision: 264256 URL: http://llvm.org/viewvc/llvm-project?rev=264256=rev Log: Revert "removed redundant comment in format::getStyle." This reverts commit r264254. Modified: cfe/trunk/lib/Format/Format.cpp Modified:

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added a comment. @Daniel, now that Manuel is on vacation. Could you have a look at the patch? Comment at: unittests/Tooling/RefactoringTest.cpp:206 @@ -169,3 +205,3 @@ TEST(ShiftedCodePositionTest, FindsNewCodePosition) { Replacements Replaces;

r264254 - removed redundant comment in format::getStyle.

Author: ioeric Date: Thu Mar 24 05:50:26 2016 New Revision: 264254 URL: http://llvm.org/viewvc/llvm-project?rev=264254=rev Log: removed redundant comment in format::getStyle. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL:

Re: [PATCH] D18399: Added support for different VFSs in format::getStyle.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264253: Added support for different VFSs in format::getStyle. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D18399?vs=51440=51534#toc Repository: rL LLVM

r264253 - Added support for different VFSs in format::getStyle.

Author: ioeric Date: Thu Mar 24 05:50:17 2016 New Revision: 264253 URL: http://llvm.org/viewvc/llvm-project?rev=264253=rev Log: Added support for different VFSs in format::getStyle. Summary: Previously, format::getStyle assumes that the given file resides in the real file system, which prevents

r264252 - Test commit access to clang repo.

Author: ioeric Date: Thu Mar 24 05:21:00 2016 New Revision: 264252 URL: http://llvm.org/viewvc/llvm-project?rev=264252=rev Log: Test commit access to clang repo. Summary: Test commit access to clang repo. Reviewers: cfe-commits Subscribers: klimek Differential Revision:

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL264251: [clang-tidy] misc-assign-operator-signature checker checks return value of… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D18264?vs=51521=51527#toc Repository: rL

[clang-tools-extra] r264251 - [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

Author: xazax Date: Thu Mar 24 05:12:08 2016 New Revision: 264251 URL: http://llvm.org/viewvc/llvm-project?rev=264251=rev Log: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators The return value of every assign operator should be Type&, not only for

Re: [PATCH] D18432: Test commit access to clang repo.

ioeric closed this revision. ioeric added a comment. I should have submitted to llvm-commits instead of cfe-commits. http://reviews.llvm.org/D18432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

alexfh accepted this revision. alexfh added a comment. LG. Tell me if you need someone to commit the patch for you. http://reviews.llvm.org/D18264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >