Author: ctopper
Date: Mon May 16 23:41:40 2016
New Revision: 269742
URL: http://llvm.org/viewvc/llvm-project?rev=269742=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512PF intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:42 2016
New Revision: 269743
URL: http://llvm.org/viewvc/llvm-project?rev=269743=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512VLBW intrinsics.
Remove leading underscores from macro argument names. Add explicit typecasts to
all macro
Author: ctopper
Date: Mon May 16 23:41:46 2016
New Revision: 269744
URL: http://llvm.org/viewvc/llvm-project?rev=269744=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512VLDQ intrinsics.
Remove leading underscores from macro argument names. Add explicit typecasts to
all macro
Author: ctopper
Date: Mon May 16 23:41:38 2016
New Revision: 269741
URL: http://llvm.org/viewvc/llvm-project?rev=269741=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512ER intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:33 2016
New Revision: 269739
URL: http://llvm.org/viewvc/llvm-project?rev=269739=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512BW intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:29 2016
New Revision: 269737
URL: http://llvm.org/viewvc/llvm-project?rev=269737=rev
Log:
[AVX512] Correct types for scalar double precision FMA intrinsics and single
precision getexp intrinsics.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Author: ctopper
Date: Mon May 16 23:41:36 2016
New Revision: 269740
URL: http://llvm.org/viewvc/llvm-project?rev=269740=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512DQ intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:32 2016
New Revision: 269738
URL: http://llvm.org/viewvc/llvm-project?rev=269738=rev
Log:
[AVX512] Fix return types in several test cases to match the intrinsic they're
testing.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified:
hintonda updated this revision to Diff 57432.
hintonda added a comment.
- Address additional comments.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
Author: ctopper
Date: Mon May 16 22:42:31 2016
New Revision: 269734
URL: http://llvm.org/viewvc/llvm-project?rev=269734=rev
Log:
[X86] Add a few missing typecasts to intrinsics. Found by playing with
-fno-lax-vector-conversions on the builtin tests.
Modified:
Author: ctopper
Date: Mon May 16 22:42:25 2016
New Revision: 269733
URL: http://llvm.org/viewvc/llvm-project?rev=269733=rev
Log:
[AVX512] _m512_setzero_qi/hi should return __m512i.
Modified:
cfe/trunk/lib/Headers/avx512bwintrin.h
cfe/trunk/test/Headers/x86intrin-2.c
Modified:
Author: ctopper
Date: Mon May 16 22:42:15 2016
New Revision: 269732
URL: http://llvm.org/viewvc/llvm-project?rev=269732=rev
Log:
[AVX512] Fix odd formatting in intrinsic header.
Modified:
cfe/trunk/lib/Headers/avx512bwintrin.h
Modified: cfe/trunk/lib/Headers/avx512bwintrin.h
URL:
Author: ctopper
Date: Mon May 16 22:42:37 2016
New Revision: 269735
URL: http://llvm.org/viewvc/llvm-project?rev=269735=rev
Log:
[X86] Fix a few intrinsic tests to use the return type that matches the
intrinsic they're testing.
Modified:
cfe/trunk/test/CodeGen/sse-builtins.c
Modified:
Author: mren
Date: Mon May 16 21:15:12 2016
New Revision: 269730
URL: http://llvm.org/viewvc/llvm-project?rev=269730=rev
Log:
Modules: set SystemHeader to true if we are building a system module.
If we are processing a #include from a module build, we should treat it
as a system header if we're
petarj created this revision.
petarj added a reviewer: atanasyan.
petarj added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Change default CPU for MIPS32 Android. Now it is mips32 (rev1).
http://reviews.llvm.org/D20313
Files:
lib/Driver/Tools.cpp
sfantao marked 2 inline comments as done.
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452
@@ +5451,3 @@
+ // in there.
+ for (const auto *C : D.getClausesOfKind()) {
+for (const auto *D : C->varlists()) {
sfantao updated this revision to Diff 57420.
sfantao added a comment.
- Move the flags adjustment for first private declarations to the mappable
expressions handler.
http://reviews.llvm.org/D20112
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_firstprivate_codegen.cpp
sfantao updated this revision to Diff 57419.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D20111
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_codegen.cpp
test/OpenMP/target_codegen_registration.cpp
test/OpenMP/target_data_codegen.cpp
On Fri, May 13, 2016 at 12:01 AM, Filipe Cabecinhas wrote:
>
> > On 13 May 2016, at 07:03, Sean Silva wrote:
> >
> >
> >
> > On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> > Author: filcab
> >
Author: rsmith
Date: Mon May 16 18:07:58 2016
New Revision: 269721
URL: http://llvm.org/viewvc/llvm-project?rev=269721=rev
Log:
Less broken fix for buildbot breakage.
Modified:
cfe/trunk/include/clang/AST/AttrIterator.h
Modified: cfe/trunk/include/clang/AST/AttrIterator.h
URL:
After this tweak, Chromium builds cleanly with the new warning enabled.
Maybe it's time to turn it on by default.
On Wed, May 11, 2016 at 1:43 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Wed May 11 12:43:13 2016
> New Revision: 269214
>
> URL:
Author: rsmith
Date: Mon May 16 18:03:40 2016
New Revision: 269720
URL: http://llvm.org/viewvc/llvm-project?rev=269720=rev
Log:
Try to make the buildbots green again: avoid the need for class Attr to be
complete for users of AttrVec.
Modified:
cfe/trunk/include/clang/AST/AttrIterator.h
Author: kromanova
Date: Mon May 16 17:54:45 2016
New Revision: 269718
URL: http://llvm.org/viewvc/llvm-project?rev=269718=rev
Log:
Doxygen comments for avxintrin.h.
Added doxygen comments to avxintrin.h's intrinsics. As of now, only around 50%
of the intrinsics in this file are documented here.
Author: rsmith
Date: Mon May 16 17:53:19 2016
New Revision: 269717
URL: http://llvm.org/viewvc/llvm-project?rev=269717=rev
Log:
Switch from SmallVector to TinyPtrVector for the list of attributes on a
declaration. This removes a memory allocation for the common case where the
declaration has
Author: rsmith
Date: Mon May 16 17:52:23 2016
New Revision: 269716
URL: http://llvm.org/viewvc/llvm-project?rev=269716=rev
Log:
Avoid O(n^2) string analysis when handling GNU __asm__ statements.
Modified:
cfe/trunk/lib/AST/Stmt.cpp
Modified: cfe/trunk/lib/AST/Stmt.cpp
URL:
rsmith added inline comments.
Comment at: include/clang/AST/DeclCXX.h:522
@@ -545,7 +521,3 @@
- typedef LazyDefinitionDataPtr
- DefinitionDataPtr;
- friend class LazyDefinitionDataPtr;
-
-
v.g.vassilev created this revision.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D20302
Files:
include/clang/AST/DeclCXX.h
lib/AST/DeclCXX.cpp
Author: probinson
Date: Mon May 16 16:25:15 2016
New Revision: 269709
URL: http://llvm.org/viewvc/llvm-project?rev=269709=rev
Log:
[PS4] Tighten up a test (noticed in passing)
Modified:
cfe/trunk/test/Driver/ps4-linker-win.c
Modified: cfe/trunk/test/Driver/ps4-linker-win.c
URL:
aaron.ballman added inline comments.
Comment at: test/clang-tidy/modernize-use-noexcept-macro.cpp:11
@@ +10,3 @@
+
+// Should not trigger a FixItHint
+class A {};
hintonda wrote:
> aaron.ballman wrote:
> > I may have missed some context in the discussion, but why
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:46
@@ +45,3 @@
+ const SmallVector ) {
+ // Find throw token -- it's a keyword, so there can't be more than one.
Also,
+ // it should be near the end of the
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21
@@ +20,3 @@
+
+static StringRef
+makeDynamicExceptionString(const SourceManager ,
hintonda wrote:
> aaron.ballman wrote:
> > Instead of a bunch of static functions,
hubert.reinterpretcast added a comment.
Ping (#2).
http://reviews.llvm.org/D19322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
Below are some buildbot numbers for the last week of 5/08/2016 - 5/14/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Author: vedantk
Date: Mon May 16 16:04:19 2016
New Revision: 269701
URL: http://llvm.org/viewvc/llvm-project?rev=269701=rev
Log:
Revert "Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage,
NFC""
This reverts commit r269695. The llvm commit does not pass the MSVC bot.
Author: vedantk
Date: Mon May 16 15:50:13 2016
New Revision: 269695
URL: http://llvm.org/viewvc/llvm-project?rev=269695=rev
Log:
Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"
Sync up with "(llvm) Use Error in InstrProf and Coverage".
Differential Revision:
Author: spyffe
Date: Mon May 16 15:48:03 2016
New Revision: 269693
URL: http://llvm.org/viewvc/llvm-project?rev=269693=rev
Log:
Added support to the ASTImporter for C++ constructor initializers.
Also added named casts and propagation of "implicit" to fix the LLDB testsuite.
This is a fixed commit
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21
@@ +20,3 @@
+
+static StringRef
+makeDynamicExceptionString(const SourceManager ,
aaron.ballman wrote:
> Instead of a bunch of static functions, would an unnamed namespace
Hello everyone,
I am cleaning zorg a little and going to remove the next builder modules
since they are not in use for a long time now:
If anyone have plans for any of them please speak up!
ChrootSetup.py
DragonEggBuilder.py
KLEEBuilder.py
ScriptedBuilder.py
gccSuiteBuilder.py
Thanks
Galina
yaxunl updated this revision to Diff 57393.
yaxunl added a comment.
Update test.
http://reviews.llvm.org/D20133
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/as_type.cl
Index: test/CodeGenOpenCL/as_type.cl
===
---
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21
@@ +20,3 @@
+
+static StringRef
+makeDynamicExceptionString(const SourceManager ,
Instead of a bunch of static functions, would an unnamed namespace make more
sense?
yaxunl updated this revision to Diff 57392.
yaxunl added a comment.
Add a test for casting char16 to i3 as Alexey suggested.
http://reviews.llvm.org/D20133
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/as_type.cl
Index: test/CodeGenOpenCL/as_type.cl
Author: majnemer
Date: Mon May 16 15:30:03 2016
New Revision: 269687
URL: http://llvm.org/viewvc/llvm-project?rev=269687=rev
Log:
[Lex] inferModuleFromLocation should do no work if there are no modules
getModuleContainingLocation ends up on the hot-path for typical C code
which can lead to calls
cdavis5x marked an inline comment as done.
Comment at: include/clang/Basic/Attr.td:2032
@@ -2031,1 +2031,3 @@
+def MSHookPrologue : InheritableAttr {
+ let Spellings = [GCC<"ms_hook_prologue">];
aaron.ballman wrote:
> Does this attribute appertain to all
cdavis5x updated this revision to Diff 57389.
cdavis5x added a comment.
- Use Sanjoy's `patchable-function` attribute.
- Add documentation for this new attribute.
http://reviews.llvm.org/D19909
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
sbenza added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:83
@@ +82,3 @@
+ if (!IsConstQualified) {
+auto Matches = utils::decl_ref_expr::allDeclRefExprs(
+*Param, *Function->getBody(), *Result.Context);
We
vmiklos created this revision.
vmiklos added reviewers: klimek, cfe-commits.
Even if this is defined in the .cpp file and only used as part of the
function (so here it's safe), usually storing StringRefs in the class is
dangerous, so don't do so.
http://reviews.llvm.org/D20296
Files:
Author: mzuckerm
Date: Mon May 16 13:57:24 2016
New Revision: 269680
URL: http://llvm.org/viewvc/llvm-project?rev=269680=rev
Log:
[Clang][AVX512] completing missing intrinsics for [vpabs] instruction set
Differential Revision: http://reviews.llvm.org/D20069
Modified:
Thanks! Committed in r269679
Steven
> On May 16, 2016, at 11:54 AM, Rafael Espíndola
> wrote:
>
> LGTM
>
> On 16 May 2016 at 14:03, Steven Wu wrote:
>>
>>> On May 16, 2016, at 6:52 AM, Rafael Espíndola
>>> wrote:
LGTM
On 16 May 2016 at 14:03, Steven Wu wrote:
>
>> On May 16, 2016, at 6:52 AM, Rafael Espíndola
>> wrote:
>>
>> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true);
>>
>> Please use an explicit type instead of auto.
>
> Sure.
>
>>
meadori added a comment.
Hmmm, it works on trunk r269671. Not sure what happened before.
http://reviews.llvm.org/D20192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
I hereby attach a patch to fix bug no. 27731:
https://llvm.org/bugs/show_bug.cgi?id=27731
Best regards,
Mads Ravn
Index: clang-tidy/modernize/PassByValueCheck.cpp
===
--- clang-tidy/modernize/PassByValueCheck.cpp (revision
thakis closed this revision.
thakis added a comment.
r269675, thanks!
http://reviews.llvm.org/D20291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Mon May 16 13:14:07 2016
New Revision: 269675
URL: http://llvm.org/viewvc/llvm-project?rev=269675=rev
Log:
[ms] Reintroduce feature guards in intrinsic headers in Microsoft mode
Visual Studio's C++ standard library headers include intrin.h, so the intrinsic
headers get
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D20291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
> On May 16, 2016, at 6:52 AM, Rafael Espíndola
> wrote:
>
> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true);
>
> Please use an explicit type instead of auto.
Sure.
>
> You deleted the assert
Are you referring to the assertion that
cameron314 updated the summary for this revision.
cameron314 updated this revision to Diff 57367.
cameron314 added a comment.
This version of the patch takes into account potential changes between
filenames and their unique IDs between parses.
http://reviews.llvm.org/D20137
Files:
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
Visual Studio's C++ standard library headers include intrin.h, so the intrinsic
headers get included a lot more often in Microsoft mode then elsewhere. The
AVX512 intrinsics are a lot of code
On Mon, May 16, 2016 at 10:03 AM, Nick Lewycky wrote:
> Hans Wennborg wrote:
>>
>> On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits
>> wrote:
>>>
>>>
>>> Author: nicholas
>>> Date: Sat May 14 12:44:14 2016
>>> New Revision: 269572
>>>
erik.pilkington added a comment.
Very weird, the test suite runs fine on my machine. Looks like the expected
line for the diagnostics on your run is always one more than the line of the
actual diagnostic. Could you please update your build to top-of-trunk, reapply
the patch, and run the suite
davidxl added a comment.
Strictly speaking, this patch requires a version bump of the indexed format.
The profile reader also needs to adjust the FunctionHash computation (either
using 0 or simple function hash) based on the version of the profile data.
Check with Justin/vsk to see if it is
danalbert accepted this revision.
danalbert added a comment.
This revision is now accepted and ready to land.
LGTM. Sorry for the delay in response.
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:17051
@@ +17050,3 @@
+#define CLK_SUCCESS 0
+#define CLK_ENQUEUE_FAILURE -101
+#define CLK_INVALID_QUEUE -102
jprice
Author: yaxunl
Date: Mon May 16 12:06:34 2016
New Revision: 269670
URL: http://llvm.org/viewvc/llvm-project?rev=269670=rev
Log:
[OpenCL] Add supported OpenCL extensions to target info.
Add supported OpenCL extensions to target info. It serves as default values to
save the users of the burden
Hans Wennborg wrote:
On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits
wrote:
Author: nicholas
Date: Sat May 14 12:44:14 2016
New Revision: 269572
URL: http://llvm.org/viewvc/llvm-project?rev=269572=rev
Log:
Warn when a reference is bound to an empty
Author: marshall
Date: Mon May 16 11:57:15 2016
New Revision: 269665
URL: http://llvm.org/viewvc/llvm-project?rev=269665=rev
Log:
Add a test for uniqueptr having either NULL and nullptr
Modified:
cameron314 added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:1402-1406
@@ +1401,7 @@
+
+vfs::Status Status;
+if (FileMgr->getNoncachedStatValue(RB.first, Status)) {
+ AnyFileChanged = true;
+ break;
+}
+
rsmith
Author: marshall
Date: Mon May 16 11:55:32 2016
New Revision: 269663
URL: http://llvm.org/viewvc/llvm-project?rev=269663=rev
Log:
Add a couple of _LIBCPP_ASSERT calls. No functional change.
Modified:
libcxx/trunk/include/future
Modified: libcxx/trunk/include/future
URL:
rmaprath added a comment.
Ping.
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thank you for the work on this! I've commit in r269662
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: aaronballman
Date: Mon May 16 11:49:01 2016
New Revision: 269662
URL: http://llvm.org/viewvc/llvm-project?rev=269662=rev
Log:
Add the hasDynamicExceptionSpec() AST matcher to match function declarations
that have a dynamic exception specification.
Patch by Don Hinton.
Modified:
On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits
wrote:
>
> Author: nicholas
> Date: Sat May 14 12:44:14 2016
> New Revision: 269572
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269572=rev
> Log:
> Warn when a reference is bound to an empty l-value
Author: bruno
Date: Mon May 16 11:46:01 2016
New Revision: 269661
URL: http://llvm.org/viewvc/llvm-project?rev=269661=rev
Log:
[Modules] Use vfs for (recursive) directory iteration
Clang performs directory walk while searching headers inside modules by
using the ::sys::fs instead of ::vfs. This
jprice added inline comments.
Comment at: lib/Headers/opencl-c.h:17051
@@ +17050,3 @@
+#define CLK_SUCCESS 0
+#define CLK_ENQUEUE_FAILURE -101
+#define CLK_INVALID_QUEUE -102
yaxunl
mclow.lists added a comment.
A couple of packaging comments. In general, this looks fine to me - still
waiting on someone from Android to chime in. -- I'll ping Dan.
Comment at: include/support/xlocale/__posix_l_fallback.h:13
@@ +12,3 @@
+// extended locale support for
hintonda added a comment.
Great, thanks again. This has been a great learning experience.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:17051
@@ +17050,3 @@
+#define CLK_SUCCESS 0
+#define CLK_ENQUEUE_FAILURE -101
+#define CLK_INVALID_QUEUE -102
ikudrin added a comment.
Does anyone known, why we need dummy coverage mapping records for unused
functions? How are they used? Isn't it better to remove these dummy records to
prevent confusion with the real ones?
http://reviews.llvm.org/D20287
meadori added a subscriber: meadori.
meadori added a comment.
I see failure when running the Clang test suite with this patch:
Command Output (stderr):
--
error: 'error' diagnostics expected but not seen:
File
ikudrin added a comment.
The motivation sample (using llvm-cov with http://reviews.llvm.org/D20286
applied):
$ cat > sample.h << EOF
inline int sample_func(int A) {
return A;
}
EOF
$ cat > dummy.cpp << EOF
#include "sample.h"
EOF
$ cat > sample.cpp << EOF
#include
hintonda updated this revision to Diff 57357.
hintonda added a comment.
- Revert back to previous version of the matcher and use Aaron's syntax with
allOf and unless to achieve the same results -- much simpler.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
hintonda updated this revision to Diff 57356.
hintonda added a comment.
Revert back to previous version.
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
hans added a comment.
I'd leave out the blank lines between DEF_TRAVERSE_STMTs, but the rest looks
good.
Comment at: include/clang/AST/RecursiveASTVisitor.h:2014
@@ -2002,2 +2013,3 @@
DEF_TRAVERSE_STMT(ObjCAutoreleasePoolStmt, {})
+
DEF_TRAVERSE_STMT(CXXForRangeStmt, {
hintonda added a comment.
Great, that's exactly what I needed. I'll revert back to the previous version.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
In http://reviews.llvm.org/D20052#430903, @hintonda wrote:
> Great, unless() was what I was missing. I'll refactor along those lines.
>
> As for what I'm trying to achieve, I want a set containing "throw()" and
> another set containing "throw(something)". If
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda added a comment.
Great, unless() was what I was missing. I'll refactor along those lines.
As for what I'm trying to achieve, I want a set containing "throw()" and
another set containing "throw(something)". If there's a cleaner way to achieve
that with an existing matcher, please let
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
I'm not keen on the new direction this patch has taken.
`hasDynamicExceptionSpec(isThrow())` is quite novel. What is the problem you
are trying to solve with this?
filcab updated this revision to Diff 57350.
filcab added a comment.
Added a version field.
http://reviews.llvm.org/D19667
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/catch-undef-behavior.c
Index: test/CodeGen/catch-undef-behavior.c
Author: etienneb
Date: Mon May 16 09:34:20 2016
New Revision: 269656
URL: http://llvm.org/viewvc/llvm-project?rev=269656=rev
Log:
[clang-tidy] Cleanups utils files
Summary:
Cleanup some code by using appropriate APIs.
Some coding style cleanups.
There is no behavior changes.
- Function
bittnerbarni updated this revision to Diff 57346.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang-tidy/performance/InefficientStringAdditionCheck.h
clang-tidy/performance/PerformanceTidyModule.cpp
+ auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true);
Please use an explicit type instead of auto.
You deleted the assert
I think this is fine otherwise.
Cheers,
Rafael
On 13 May 2016 at 20:00, Steven Wu wrote:
>
>> On May 13, 2016, at 3:56 PM, Duncan P.
a.makarov updated this revision to Diff 57344.
a.makarov added a comment.
I've updated the patch. Please take a look.
http://reviews.llvm.org/D20171
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/Driver/CC1Options.td
filcab updated this revision to Diff 57342.
filcab added a comment.
Minor update which never sets an AlignVal to 0.
http://reviews.llvm.org/D19667
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGen/catch-undef-behavior.c
Index: test/CodeGen/catch-undef-behavior.c
dim added a subscriber: cfe-commits.
dim added a comment.
Belatedly adding cfe-commits.
http://reviews.llvm.org/D20037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin added a comment.
Ping?..
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks for pointing that out. Test Added in r269651.
- Vasileios
From: Daniel Sanders
Sent: 13 May 2016 17:33
To: Vasileios Kalintiris; cfe-commits@lists.llvm.org
Subject: RE: r269411 - [mips] Consult triple's vendor field before using musl's
interpreter.
Author: vkalintiris
Date: Mon May 16 06:53:51 2016
New Revision: 269651
URL: http://llvm.org/viewvc/llvm-project?rev=269651=rev
Log:
[mips] Add test for the dynamic linker when using the mips64el-fedora-linux
triple.
We should use the musl linker only when there's no environment specified and
Any feedback?
Thanks,
--Serge
2016-05-03 22:40 GMT+06:00 Serge Pavlov :
> 2016-04-26 0:55 GMT+06:00 Richard Smith :
>
>> rsmith added inline comments.
>>
>>
>> Comment at: lib/Sema/SemaDecl.cpp:8611-8612
>> @@ -8609,3 +8610,4 @@
>>
jojo added a comment.
Dear Bradley,Renato
Sorry for late reply,I have been on leave the last three days.
Thank you very much for your review and suggestons.I will re pondering the
changes.
Repository:
rL LLVM
http://reviews.llvm.org/D20089
The reduced reproducer: https://llvm.org/bugs/show_bug.cgi?id=27754
On 14/05/16 01:23, Richard Smith wrote:
Update: Vassil and I have dug into this a bit offline. It looks like
the root cause is a likely-pre-existing bug where we somehow import a
default constructor for a class from a module
1 - 100 of 107 matches
Mail list logo