Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

pcc planned changes to this revision. pcc added a comment. One thing that I forgot to do here was to add a test covering my changes to `CGDebugInfo::EmitGlobalVariable`. I'll do that momentarily. http://reviews.llvm.org/D20415 ___ cfe-commits

[PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

pcc created this revision. pcc added reviewers: dexonsmith, dblaikie, aprantl. pcc added a subscriber: cfe-commits. http://reviews.llvm.org/D20415 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

faisalv updated this revision to Diff 57733. faisalv marked an inline comment as done. faisalv added a comment. This patch addresses all of Richard's comments - except one (on which I'm awaiting some additional clarity on, before I make any changes). http://reviews.llvm.org/D19783 Files:

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

faisalv marked 5 inline comments as done. faisalv added a comment. OK - agree (and addressed in a forthcoming patch) all your comments - except for the one I could use some clarity on - please see below Comment at: lib/Sema/SemaExprCXX.cpp:910 @@ +909,3 @@ +

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

There are tests from the test file in my patch that don't pass(*) if you just apply Oh's fix . That's not surprising since Oh's patch only meant to fix the crash, but not the 'cv' qualification issue of '*this' that we didn't have to deal with prior to by-value captures of '*this' and my initial

r270021 - Reapply^3 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"

Author: vedantk Date: Wed May 18 22:54:54 2016 New Revision: 270021 URL: http://llvm.org/viewvc/llvm-project?rev=270021=rev Log: Reapply^3 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" Sync up with "(llvm) Use Error in InstrProf and Coverage". Modified:

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

rjmccall added a comment. _Atomic is functionally a type qualifier and should be removed in Sema when computing the result type of the getter and the parameter type of the setter. That is, if the user declares a property of type _Atomic(_Bool), we should pretend that the property has type

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

On Thu, Apr 21, 2016 at 12:44 AM, Serge Pavlov wrote: > Let me demonstrate the problem using excerpt from v8 sources: > > -- lithium.h > template > struct LSubKindOperand { > static int* Create(int index) { return

r270016 - Fix PR27601 by reverting [r267453] - Refactor traversal of bases in deduction of template parameters from base

Author: faisalv Date: Wed May 18 21:28:21 2016 New Revision: 270016 URL: http://llvm.org/viewvc/llvm-project?rev=270016=rev Log: Fix PR27601 by reverting [r267453] - Refactor traversal of bases in deduction of template parameters from base This reversal is being done with r267453's author's

Re: [PATCH] D20341: [CUDA] Enable fusing FP ops for CUDA by default.

hfinkel added a comment. In http://reviews.llvm.org/D20341#432586, @jlebar wrote: > > But people also don't expect IEEE compliance on GPUs > > > Is that true? Yes. > You have a lot more experience with this than I do, but my observation of > nvidia's hardware is that it's moved to add *more*

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

I don't think we even need a helper. Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a `DiagnosticsEngine`, which has a `DiagnosticsOptions`. In other words, I think you can delete the code in Clang::ConstructJob (change it to a lookup) now that you've changed

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

silvas added a subscriber: silvas. silvas added a comment. I don't see an issue with putthing this as a helper in libBasic. We may need to add a libOption dependency to it but that sounds fine. http://reviews.llvm.org/D20404 ___ cfe-commits

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

On Wed, May 18, 2016 at 6:49 PM, Sean Silva via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Wed May 18 20:39:10 2016 >> New Revision: 270009 >> >> URL:

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

Ah, just saw 270010 On Wed, May 18, 2016 at 6:49 PM, Sean Silva wrote: > > > On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Wed May 18 20:39:10 2016 >> New Revision: 270009 >> >> URL:

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed May 18 20:39:10 2016 > New Revision: 270009 > > URL: http://llvm.org/viewvc/llvm-project?rev=270009=rev > Log: > Make Sema::getPrintingPolicy less ridiculously

r270010 - Revert accidentally-committed test for PR27558 (which currently fails...)

Author: rsmith Date: Wed May 18 20:41:52 2016 New Revision: 270010 URL: http://llvm.org/viewvc/llvm-project?rev=270010=rev Log: Revert accidentally-committed test for PR27558 (which currently fails...) Modified: cfe/trunk/test/SemaCXX/member-pointer.cpp Modified:

r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

Author: rsmith Date: Wed May 18 20:39:10 2016 New Revision: 270009 URL: http://llvm.org/viewvc/llvm-project?rev=270009=rev Log: Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform an identifier table lookup, *and* copy the LangOptions (including various std::vectors).

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Include What You Use detect duplicated include directives. I think will be good idea to use it instead of Clang-tidy for much deeper analysis. http://reviews.llvm.org/D7982

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak added a comment. Also, it seems that there are bugs in the way clang handles functions whose return types are atomic. Clang asserts when compiling the following test case: $ cat t1.c _Atomic _Bool b1; _Atomic _Bool foo1() { return b1; } $ clang -std=c11 -o - -S t1.c

Re: [PATCH] D15089: Patch to google checks in clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please update you patch to current code. Looks like addresses were fixed in files where they existed, but still need to be added to files without them. Repository: rL LLVM http://reviews.llvm.org/D15089

[PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. This patch fixes an assert that fires when there is a property that has attribute nonatomic and type _Atomic(_Bool). The assert fires when an i1 value is bitcast to i8 (which is the

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

bruno added a subscriber: bruno. bruno added a comment. Hi Manman, Comment at: lib/Serialization/ASTWriter.cpp:2191 @@ -2191,1 +2190,3 @@ +// We write out exported module macros for PCH as well. +if (true) { auto Leafs = PP.getLeafModuleMacros(Name);

Re: r269910 - Update for llvm change.

yes, thanks. Cheers, Rafael On 18 May 2016 at 19:10, Sean Silva wrote: > > > On Wed, May 18, 2016 at 4:58 AM, Rafael Espindola via cfe-commits > wrote: >> >> Author: rafael >> Date: Wed May 18 06:58:56 2016 >> New Revision: 269910 >> >> URL:

r270006 - Fix a funny Dvorak typo.

Author: rafael Date: Wed May 18 19:16:09 2016 New Revision: 270006 URL: http://llvm.org/viewvc/llvm-project?rev=270006=rev Log: Fix a funny Dvorak typo. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp URL:

Re: [PATCH] D20394: Fix cdp intrinsic

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D20394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20405: [CUDA] allow sm_50,52,53 GPUs

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. LLVM accepts them since r233575. http://reviews.llvm.org/D20405 Files: lib/Basic/Targets.cpp lib/Driver/ToolChains.cpp test/CodeGen/nvptx-cpus.c Index: test/CodeGen/nvptx-cpus.c

[PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitly passed into the driver. OTOH, it works great for cc1 mode since

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

vsk updated this revision to Diff 57711. vsk added a comment. - Add some comments to the unit test. http://reviews.llvm.org/D20401 Files: lib/Lex/TokenLexer.cpp test/CoverageMapping/Inputs/macros.h test/CoverageMapping/include-macros.c unittests/Lex/LexerTest.cpp Index:

[libcxx] r269998 - Cleanup superfluous std:: qualifiers in

Author: ericwf Date: Wed May 18 18:09:24 2016 New Revision: 269998 URL: http://llvm.org/viewvc/llvm-project?rev=269998=rev Log: Cleanup superfluous std:: qualifiers in Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL:

Re: r269910 - Update for llvm change.

On Wed, May 18, 2016 at 4:58 AM, Rafael Espindola via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rafael > Date: Wed May 18 06:58:56 2016 > New Revision: 269910 > > URL: http://llvm.org/viewvc/llvm-project?rev=269910=rev > Log: > Update for llvm change. > > Modified: >

Re: [PATCH] D20325: Add ARM cdp intrinsics

rs added a comment. > http://reviews.llvm.org/D20394 which adds a test for the intrinsic in llvm Wrong link, should be http://reviews.llvm.org/D20393 Repository: rL LLVM http://reviews.llvm.org/D20325 ___ cfe-commits mailing list

Re: [PATCH] D20325: Add ARM cdp intrinsics

rs added a comment. Hi Renato, I've created 2 new reviews for this work http://reviews.llvm.org/D20394 which adds a test for the intrinsic in llvm and http://reviews.llvm.org/D20394 which fixes the builtin signature for the cdp intrinsic. Thanks, Ranjeet Repository: rL LLVM

[PATCH] D20394: Fix cdp intrinsic

rs created this revision. rs added a reviewer: rengolin. rs added a subscriber: cfe-commits. Fixed cdp intrinsic to only accept compile time constant values, previously you could pass in a variable to the builtin which would result in illegal llvm assembly output.

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler marked 2 inline comments as done. eric_niebler added a comment. Thanks for the feedback, @curdeius. What happens now? Do I just wait until somebody accepts the llvm diff and this one? How do I increase the likelihood that that happens? http://reviews.llvm.org/D19843

[libcxx] r269991 - Optimize declval for compile times. Patch from Eric Niebler.

Author: ericwf Date: Wed May 18 17:23:46 2016 New Revision: 269991 URL: http://llvm.org/viewvc/llvm-project?rev=269991=rev Log: Optimize declval for compile times. Patch from Eric Niebler. This patch implements the C++11 version of declval without requiring a template instantiation. See PR27798

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda updated this revision to Diff 57686. hintonda added a comment. Improved matcher logic and add better range handling to try to deal with multiple asserts concerning bad ranges when running checker again real code, e.g., libcxx. Even so, still seeing some asserts in

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

wristow added a comment. In http://reviews.llvm.org/D20243#433615, @thakis wrote: > Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might > have opinions on this. Yes, these are definitely related. Fixing that other problem does //not //also fix the issue here, however

r269989 - Update for llvm change.

Author: rafael Date: Wed May 18 17:04:57 2016 New Revision: 269989 URL: http://llvm.org/viewvc/llvm-project?rev=269989=rev Log: Update for llvm change. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

thakis added a subscriber: thakis. thakis added a comment. Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might have opinions on this. http://reviews.llvm.org/D20243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

cameron314 added a subscriber: cameron314. cameron314 added a comment. I've seen rare cases where parses using the PCH files were yielding completely invalid data, almost as if they were corrupted. I wonder now if this could be the cause. (We're on Windows too.) http://reviews.llvm.org/D20243

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

probinson added a comment. This is fine as far as I'm concerned, but I think somebody more familiar with the area ought to chime in. http://reviews.llvm.org/D20243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. When we import a module that defines a builtin identifier from prefix header and precompile the prefix header, the macro information related to the identifier is lost. If

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=,*this]")

OK - thanks - will take a closer look at this hopefuly this evening or tomorrow - and respond to Richard's other comments too. Faisal Vali On Wed, May 18, 2016 at 1:46 PM, Taewook Oh wrote: > twoh added a comment. > > My patch passes check-clang and the test cases in this patch

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor added a comment. The motivation for this patch is a hashing algorithm for all AST nodes which reuses child hash values to be O(n) and therefore needs postorder support (think Java's Object.hashCode() but on AST nodes as an example). The full code that currently uses this feature can be

[PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor created this revision. teemperor added reviewers: zaks.anna, v.g.vassilev, doug.gregor, chandlerc. teemperor added a subscriber: cfe-commits. This patch adds postorder traversal support to the RecursiveASTVisitor. This feature needs to be explicitly enabled by overriding

[libcxx] r269973 - Mark LWG2583 as complete. I did this a while ago, and forgot to update the table.

Author: marshall Date: Wed May 18 14:31:01 2016 New Revision: 269973 URL: http://llvm.org/viewvc/llvm-project?rev=269973=rev Log: Mark LWG2583 as complete. I did this a while ago, and forgot to update the table. Modified: libcxx/trunk/www/cxx1z_status.html Modified:

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

curdeius added a comment. Nice job! Thanks for taking my remarks into account. Comment at: include/clang/Basic/VirtualFileSystem.h:14 Oops, my fault. http://reviews.llvm.org/D19843 ___ cfe-commits mailing list

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

twoh added a comment. My patch passes check-clang and the test cases in this patch as well. BTW, newly added test cases in the patch seem to be passed even without the patch. Isn't the bug appears when template instantiation generates nested lambdas (because template instantiation updates the

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler updated this revision to Diff 57657. eric_niebler added a comment. Factor out TrySimplifyPath from Preprocessor::HandleIncludeDirective. Other review feedback. http://reviews.llvm.org/D19843 Files: include/clang/Basic/DiagnosticGroups.td

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:97 @@ +96,3 @@ + return Status->getName(); +else + return Status.getError(); curdeius wrote: > No else needed after return. But then `Status` is not in scope.

r269970 - Revert r269967 (SSE2 builtin checks) due to failed buildbots

Author: rksimon Date: Wed May 18 13:22:20 2016 New Revision: 269970 URL: http://llvm.org/viewvc/llvm-project?rev=269970=rev Log: Revert r269967 (SSE2 builtin checks) due to failed buildbots Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/trunk/test/CodeGen/sse2-builtins.c

r269967 - [X86][SSE2] Sync with llvm/test/CodeGen/X86/sse2-intrinsics-fast-isel.ll

Author: rksimon Date: Wed May 18 13:12:34 2016 New Revision: 269967 URL: http://llvm.org/viewvc/llvm-project?rev=269967=rev Log: [X86][SSE2] Sync with llvm/test/CodeGen/X86/sse2-intrinsics-fast-isel.ll Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified:

r269968 - ObjectiveC Class Properties: warn if a class property accessor is mistakenly an

Author: mren Date: Wed May 18 13:12:34 2016 New Revision: 269968 URL: http://llvm.org/viewvc/llvm-project?rev=269968=rev Log: ObjectiveC Class Properties: warn if a class property accessor is mistakenly an instance method. When diagnosing unimplemented class property, make sure we emit a warning

[libcxx] r269965 - Change the control flow in atomic_compare_exchange_strong to avoid a potential deadlock.

Author: marshall Date: Wed May 18 12:50:13 2016 New Revision: 269965 URL: http://llvm.org/viewvc/llvm-project?rev=269965=rev Log: Change the control flow in atomic_compare_exchange_strong to avoid a potential deadlock. When you assign a shared_ptr, the deleter gets called and assigned. In this

Re: [PATCH] D20341: [CUDA] Enable fusing FP ops for CUDA by default.

tra added a comment. I don't think using FMA throws away IEEE compliance. IEEE 784-2008 says: > A language standard should also define, and require implementations to > provide, attributes that allow and > disallow value-changing optimizations, separately or collectively, for a > block.

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

rsmith added a subscriber: rsmith. rsmith added a comment. I'd also like to know whether there are cases that this patch addresses but Taewook Oh's patch does not, as the other patch involves a lot less complexity. http://reviews.llvm.org/D19783

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

I'd also like to know whether there are cases that this patch addresses but Taewook Oh's patch does not, as the other patch involves a lot less complexity. On 18 May 2016 10:15 a.m., "Richard Smith via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > rsmith added inline comments. > >

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:898 @@ +897,3 @@ + // end of the TU) we need to be able to examine its enclosing lambdas and so + // we use the DeclContext to get a hold of the ClosureClass and query it for + // capture information. The

Re: [PATCH] D20374: [Driver] Fix the case when use -fembed-bitcode and -flto= together

This revision was automatically updated to reflect the committed changes. Closed by commit rL269961: [Driver] Fix the case when use -fembed-bitcode and -flto= together (authored by steven_wu). Changed prior to commit: http://reviews.llvm.org/D20374?vs=57645=57646#toc Repository: rL LLVM

r269961 - [Driver] Fix the case when use -fembed-bitcode and -flto= together

Author: steven_wu Date: Wed May 18 12:04:52 2016 New Revision: 269961 URL: http://llvm.org/viewvc/llvm-project?rev=269961=rev Log: [Driver] Fix the case when use -fembed-bitcode and -flto= together Summary: -fembed-bitcode was only checking for old style LTO flag (-flto) but not considering the

Re: [PATCH] D20374: [Driver] Fix the case when use -fembed-bitcode and -flto= together

joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20374: [Driver] Fix the case when use -fembed-bitcode and -flto= together

steven_wu created this revision. steven_wu added a reviewer: joker.eph. steven_wu added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. -fembed-bitcode was only checking for old style LTO flag (-flto) but not considering the new -flto= style option. That makes clang output

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

hokein marked 2 inline comments as done. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:187 @@ +186,3 @@ + "}", + unresolvedLookupExpr(), true, +

r269957 - [ASTMacther] A follow-up on unresolvedLookupExpr test fixing.

Author: hokein Date: Wed May 18 11:48:44 2016 New Revision: 269957 URL: http://llvm.org/viewvc/llvm-project?rev=269957=rev Log: [ASTMacther] A follow-up on unresolvedLookupExpr test fixing. Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersNodeTest.cpp Modified:

Re: [PATCH] D20372: [include-fixer] Also look up prefixes of queries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269956: [include-fixer] Also look up prefixes of queries. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20372?vs=57635=57642#toc Repository: rL LLVM

[clang-tools-extra] r269956 - [include-fixer] Also look up prefixes of queries.

Author: d0k Date: Wed May 18 11:42:38 2016 New Revision: 269956 URL: http://llvm.org/viewvc/llvm-project?rev=269956=rev Log: [include-fixer] Also look up prefixes of queries. This is used to find nested classes. For a nested name foo::bar::qux we will first look up foo::bar::qux, then foo::bar,

Re: [PATCH] D20372: [include-fixer] Also look up prefixes of queries.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r269765 - Revert "[X86] Add immediate range checks for many of the builtins."

Indeed, my bad on two counts (I'm usually one of the people complaining about commits like this, *and* I didn't notice the other email was not sent to the list, so there was no record here). Thanks Craig, for replying. Filipe On Tue, May 17, 2016 at 11:09 PM, Sean Silva via cfe-commits

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

arsenm added a comment. Some larger and smaller structs too. I think it would be good if single element structs are replaced with the element type http://reviews.llvm.org/D20168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r269952 - clang-rename: handle non-inline ctor definitions when renaming classes

Author: vmiklos Date: Wed May 18 11:12:48 2016 New Revision: 269952 URL: http://llvm.org/viewvc/llvm-project?rev=269952=rev Log: clang-rename: handle non-inline ctor definitions when renaming classes The result of the test was C::D(), not D::D(). Reviewers: cfe-commits, klimek Differential

Re: [PATCH] D20356: clang-rename: handle non-inline ctor definitions when renaming classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL269952: clang-rename: handle non-inline ctor definitions when renaming classes (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20356?vs=57582=57641#toc Repository: rL LLVM

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

arsenm added a comment. Can you add some tests that include arrays, struct within structs and arrays of structs? http://reviews.llvm.org/D20168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20349: Fix a clang bug in lambda capture of 'this'

faisalv added a comment. That feedback would be greatly appreciated - thanks Taewook! Faisal Vali http://reviews.llvm.org/D20349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

mprobst updated this revision to Diff 57637. mprobst marked an inline comment as done. mprobst added a comment. - address review comments - - extract parseModuleReferences - more review comments http://reviews.llvm.org/D20198 Files: include/clang/Format/Format.h lib/Format/CMakeLists.txt

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

alexfh added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:187 @@ +186,3 @@ + "}", + unresolvedLookupExpr(), true, +

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

mprobst marked 4 inline comments as done. Comment at: lib/Format/SortJavaScriptImports.cpp:216-217 @@ +215,4 @@ +break; + Current = Line->First; + LineEnd = Line->Last; + skipComments(); klimek wrote: > Both of these are used only once,

Re: [PATCH] D20349: Fix a clang bug in lambda capture of 'this'

twoh added a comment. Thank you for your comments. @faisalv, it is great that you already submitted a patch. Let me see if your patch resolves the issue I have. Thanks! http://reviews.llvm.org/D20349 ___ cfe-commits mailing list

[PATCH] D20373: PR27799: [OpenCL] Clang fails to compile libclc

yaxunl created this revision. yaxunl added a reviewer: Anastasia. yaxunl added subscribers: cfe-commits, tstellarAMD. libclc fails to build due to some supported OpenCL extensions are not added to nvptx target. http://reviews.llvm.org/D20373 Files: lib/Basic/Targets.cpp Index:

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

m_zuckerman added a comment. Thanks, you are right ! Repository: rL LLVM http://reviews.llvm.org/D20321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r269941 - [PS4] Clean up some test commentary. NFC

Author: probinson Date: Wed May 18 10:35:58 2016 New Revision: 269941 URL: http://llvm.org/viewvc/llvm-project?rev=269941=rev Log: [PS4] Clean up some test commentary. NFC Modified: cfe/trunk/test/Driver/ps4-sdk-root.c Modified: cfe/trunk/test/Driver/ps4-sdk-root.c URL:

[PATCH] D20372: [include-fixer] Also look up prefixes of queries.

bkramer created this revision. bkramer added reviewers: hokein, ioeric. bkramer added a subscriber: cfe-commits. This is used to find nested classes. For a nested name foo::bar::qux we will first look up foo::bar::qux, then foo::bar, then foo unless we find a result. This is used to support

Re: [PATCH] D20366: [ASTMatcher] Make dump_ast_matchers.py executable.

hokein added a comment. In http://reviews.llvm.org/D20366#433123, @aaron.ballman wrote: > What's the harm in leaving the props at 0644? Just inconvenient . And I see the `dump_format_style.py` in the same directory is executable. http://reviews.llvm.org/D20366

r269939 - [Clang][AVX512] completing missing intrinsics [pandnd].

Author: mzuckerm Date: Wed May 18 10:25:53 2016 New Revision: 269939 URL: http://llvm.org/viewvc/llvm-project?rev=269939=rev Log: [Clang][AVX512] completing missing intrinsics [pandnd]. Differential Revision: http://reviews.llvm.org/D20101 Modified: cfe/trunk/lib/Headers/avx512fintrin.h

r269931 - [X86][SSE42] Sync with llvm/test/CodeGen/X86/sse42-intrinsics-fast-isel.ll

Author: rksimon Date: Wed May 18 09:29:55 2016 New Revision: 269931 URL: http://llvm.org/viewvc/llvm-project?rev=269931=rev Log: [X86][SSE42] Sync with llvm/test/CodeGen/X86/sse42-intrinsics-fast-isel.ll Modified: cfe/trunk/test/CodeGen/sse42-builtins.c Modified:

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269936: [ASTMatcher] Fix a ASTMatcher test failure on Windows. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20369?vs=57631=57633#toc Repository: rL LLVM

r269936 - [ASTMatcher] Fix a ASTMatcher test failure on Windows.

Author: hokein Date: Wed May 18 10:15:12 2016 New Revision: 269936 URL: http://llvm.org/viewvc/llvm-project?rev=269936=rev Log: [ASTMatcher] Fix a ASTMatcher test failure on Windows. Reviewers: alexfh, aaron.ballman Subscribers: thakis, cfe-commits, klimek Differential Revision:

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

hokein updated this revision to Diff 57631. hokein added a comment. Only use -fno-delayed-template-parsing in the testcase. http://reviews.llvm.org/D20369 Files: unittests/ASTMatchers/ASTMatchersNodeTest.cpp Index: unittests/ASTMatchers/ASTMatchersNodeTest.cpp

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

thakis added a comment. (If so, maybe add a FIXME comment to make things work without delayed template parsing. In any case, getting the bot green is the most important thing, so landing this as is is definitely fine.) http://reviews.llvm.org/D20369

r269935 - Teach Sema::MergeFunctionDecl to properly check for an out-of-line definition of a function that is declared as =default in its class definition.

Author: vvassilev Date: Wed May 18 10:14:46 2016 New Revision: 269935 URL: http://llvm.org/viewvc/llvm-project?rev=269935=rev Log: Teach Sema::MergeFunctionDecl to properly check for an out-of-line definition of a function that is declared as =default in its class definition. First part of

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

thakis added a comment. Ah, you answered my question while I was writing it. Doesn't that mean whatever feature this test is testing is broken on Windows? http://reviews.llvm.org/D20369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

thakis added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:187 @@ +186,3 @@ + "}", + unresolvedLookupExpr(), true, +

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

craig.topper added a subscriber: craig.topper. craig.topper requested changes to this revision. craig.topper added a reviewer: craig.topper. craig.topper added a comment. This revision now requires changes to proceed. Don't the type casts need to be changed too? For example permutexvar_pd has the

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

hokein added a comment. In http://reviews.llvm.org/D20369#433141, @thakis wrote: > Maybe you could change Matcher.UnresolvedLookupExpr to call bar() from a > new function foo() so that it gets instantiated? This will break the intention of the testcase. We don't want the function get

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I like this approach much better, thank you. LGTM! http://reviews.llvm.org/D20369 ___ cfe-commits mailing list

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

klimek added a comment. We're getting there. Couple of nits left. Comment at: lib/Format/SortJavaScriptImports.cpp:94-97 @@ +93,6 @@ +// Side effect imports might be ordering sensitive. Consider them equal so +// that they maintain their relative order in the stable

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

thakis added a subscriber: thakis. thakis added a comment. I agree with Aaron. Maybe you could change Matcher.UnresolvedLookupExpr to call bar() from a new function foo() so that it gets instantiated? http://reviews.llvm.org/D20369 ___ cfe-commits

r269934 - [Hexagon] Recognize "q" and "v" in inline-asm as register constraints

Author: kparzysz Date: Wed May 18 09:56:14 2016 New Revision: 269934 URL: http://llvm.org/viewvc/llvm-project?rev=269934=rev Log: [Hexagon] Recognize "q" and "v" in inline-asm as register constraints Clang follow-up to r269933. Added: cfe/trunk/test/CodeGen/hexagon-inline-asm.c Modified:

Re: [PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

aaron.ballman added a comment. Hrm, I kind of worry about this masking bugs when delayed template parsing is enabled (which it is by default on MSVC-built versions of clang). http://reviews.llvm.org/D20369 ___ cfe-commits mailing list

Re: [PATCH] D20366: [ASTMatcher] Make dump_ast_matchers.py executable.

aaron.ballman added a comment. In http://reviews.llvm.org/D20366#433103, @hokein wrote: > In http://reviews.llvm.org/D20366#433054, @aaron.ballman wrote: > > > Yeah, I'm not certain either (I've never used phab for reviewing this sort > > of thing). I would prefer this to be 0744 so that it is

[PATCH] D20369: [ASTMatcher] Fix a ASTMatcher test failure on Windows.

hokein created this revision. hokein added reviewers: alexfh, aaron.ballman. hokein added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D20369 Files: unittests/ASTMatchers/ASTMatchersTest.h Index: unittests/ASTMatchers/ASTMatchersTest.h

  1   2   >