Re: [PATCH] D20782: [AVX512] Emit generic masked store intrinsics directly from clang instead of using x86 specific intrinsics.

craig.topper added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:6304 @@ +6303,3 @@ + Indices[i] = i; +Ops[2] = CGF.Builder.CreateShuffleVector(Ops[2], Ops[2], + makeArrayRef(Indices, NumElts), delena

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

pxli168 updated this revision to Diff 58932. pxli168 added a comment. Make all tests in OpenCL 2.0. http://reviews.llvm.org/D20090 Files: lib/AST/ExprConstant.cpp lib/Sema/SemaType.cpp test/CodeGenOpenCL/vla.cl Index: test/CodeGenOpenCL/vla.cl

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 58933. EricWF added a comment. Fix some code I broke last iteration. http://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp

Re: [PATCH] D20782: [AVX512] Emit generic masked store intrinsics directly from clang instead of using x86 specific intrinsics.

delena added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:6304 @@ +6303,3 @@ + Indices[i] = i; +Ops[2] = CGF.Builder.CreateShuffleVector(Ops[2], Ops[2], + makeArrayRef(Indices, NumElts), What code do

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 58931. EricWF added a comment. Fix __tree algorithm tests. http://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp

[PATCH] D20786: Fix undefined behavior in __tree

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch attempts to fix the undefined behavior in __tree by changing the node pointer types used throughout. The pointer types are changed for raw pointers in the current ABI and for

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

pxli168 accepted this revision. pxli168 added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D20444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r271195 - Fix bug in test allocator that incorrectly computed the allocation size

Author: ericwf Date: Sun May 29 20:31:04 2016 New Revision: 271195 URL: http://llvm.org/viewvc/llvm-project?rev=271195=rev Log: Fix bug in test allocator that incorrectly computed the allocation size Modified:

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath marked an inline comment as done. rmaprath added a comment. http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath updated this revision to Diff 58929. rmaprath added a comment. Fixed a few typos. http://reviews.llvm.org/D20677 Files: CMakeLists.txt src/CMakeLists.txt src/cxa_aux_runtime.cpp src/cxa_handlers.cpp src/cxa_new_delete.cpp test/CMakeLists.txt test/backtrace_test.pass.cpp

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath added inline comments. Comment at: CMakeLists.txt:111 @@ -110,2 +110,3 @@ # Define options. +option(LIBCXXABI_ENABLE_EXCEPTIONS "Use exceptions." OFF) option(LIBCXXABI_ENABLE_ASSERTIONS "Enable assertions independent of build mode." ON) My bad, this

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath updated this revision to Diff 58927. rmaprath added a comment. OK, managed to solve this problem by removing `cxa_exception.cpp` and `cxa_personality.cpp` from the no-exceptions libcxxabi build. In order to do this, a small patch was needed for `exception.cpp` of libcxx:

[PATCH] D20784: [libcxx][libcxxabi] Decouple no-exceptions libcpp variant from cxa_exception.cpp and cxa_personality.cpp of libcxxabi

rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. This is a pre-requisite to address a review comment on D20677; The `no-exceptions` variant of libcxxabi should not be allowed to be linked against code that requires

Re: [PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

varjujan added a comment. Yes, I did. The results from running the checker on LLVM are in the attached file. Sadly, I could'nt find any real mistakes but as I wrote in the summary, false positives can still indicate bad naming convention for some variables. F1991684: result.txt

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

rivanvx updated this revision to Diff 58920. rivanvx added a comment. Updated patch. Single element structs are coerced to its element, and there are tests for structs of different sizes, structs of arrays, structs containing structs. Arrays of structs are disallowed by clang in kernels.

r271191 - clang-format: Fix segfault introduced by allowing wraps after comments.

Author: djasper Date: Sun May 29 17:07:22 2016 New Revision: 271191 URL: http://llvm.org/viewvc/llvm-project?rev=271191=rev Log: clang-format: Fix segfault introduced by allowing wraps after comments. Modified: cfe/trunk/lib/Format/ContinuationIndenter.cpp

[PATCH] D20782: [AVX512] Emit generic masked store intrinsics directly from clang instead of using x86 specific intrinsics.

craig.topper created this revision. craig.topper added reviewers: delena, RKSimon, AsafBadouh, igorb, m_zuckerman. craig.topper added a subscriber: cfe-commits. This will allow us to remove the x86 specific intrinsics from the backend. http://reviews.llvm.org/D20782 Files:

Re: r213213 - DebugInfo: Forward HandleTagDeclRequiredDefinition through MultiplexConsumer to fix debug info emission in the presence of plugins.

Thanks for the catch! Fixed in r271188 On Wed, May 25, 2016 at 10:28 AM, Nico Weber wrote: > Zombie review comment: ".test" isn't part of > test/lit.cfg::config.suffixes, so the two .test files added in this change > never run unless you explicitly run them (e.g. with

r271188 - Enable some accidentally dead tests and fix up the bitrot

Author: dblaikie Date: Sun May 29 14:50:23 2016 New Revision: 271188 URL: http://llvm.org/viewvc/llvm-project?rev=271188=rev Log: Enable some accidentally dead tests and fix up the bitrot Problem found by Nico, originally committed by me in r213213. The .test prefix wasn't actually being run.

r271187 - [X86][SSE] Make unsigned integer vector types generally available

Author: rksimon Date: Sun May 29 13:49:08 2016 New Revision: 271187 URL: http://llvm.org/viewvc/llvm-project?rev=271187=rev Log: [X86][SSE] Make unsigned integer vector types generally available As discussed on http://reviews.llvm.org/D20684, move the unsigned integer vector types used for zero

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

jvesely added inline comments. Comment at: test/Misc/r600.languageOptsOpenCL.cl:4 @@ +3,3 @@ +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown -target-cpu cypress +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown -target-cpu

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271185: clang-format: [JS] Support shebang lines on the very first line. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D20632?vs=58612=58916#toc Repository: rL LLVM

r271183 - clang-format: [JS] FormatToken.startsSequence/endsSequence.

Author: mprobst Date: Sun May 29 09:41:02 2016 New Revision: 271183 URL: http://llvm.org/viewvc/llvm-project?rev=271183=rev Log: clang-format: [JS] FormatToken.startsSequence/endsSequence. Refactors AnnotatedLine.startsWith/endsWith by extracting the core functionality into

r271185 - clang-format: [JS] Support shebang lines on the very first line.

Author: mprobst Date: Sun May 29 09:41:36 2016 New Revision: 271185 URL: http://llvm.org/viewvc/llvm-project?rev=271185=rev Log: clang-format: [JS] Support shebang lines on the very first line. Summary: Shebang lines (`#!/bin/blah`) can be used in JavaScript scripts to indicate they should be

Re: [PATCH] D20737: clang-format: [JS] fix async parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271184: clang-format: [JS] fix async parsing. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D20737?vs=58809=58915#toc Repository: rL LLVM http://reviews.llvm.org/D20737

r271184 - clang-format: [JS] fix async parsing.

Author: mprobst Date: Sun May 29 09:41:07 2016 New Revision: 271184 URL: http://llvm.org/viewvc/llvm-project?rev=271184=rev Log: clang-format: [JS] fix async parsing. Summary: Only treat the sequence `async function` as the start of a function expression, as opposed to every occurrence of the

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

djasper added inline comments. Comment at: lib/Format/Format.cpp:1411 @@ +1410,3 @@ +int getIncludePriority(const FormatStyle , + SmallVector , + StringRef IncludeName) { But you should pass it as an

Re: [PATCH] D20737: clang-format: [JS] fix async parsing.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D20737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

djasper accepted this revision. djasper added a comment. Looks good. http://reviews.llvm.org/D20632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271182 - Avoid unnecessary std::string copies. NFC.

Author: d0k Date: Sun May 29 06:04:56 2016 New Revision: 271182 URL: http://llvm.org/viewvc/llvm-project?rev=271182=rev Log: Avoid unnecessary std::string copies. NFC. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp cfe/trunk/lib/Tooling/Refactoring.cpp Modified:

Re: [PATCH] D20781: [libcxx] Add use-libunwind x86_64 builders to buildbot

rmaprath closed this revision. rmaprath added a comment. Thanks! Committed as r271179. Will be effective from the next buildmaster restart from @gkistanova. / Asiri http://reviews.llvm.org/D20781 ___ cfe-commits mailing list

Re: [PATCH] D20781: [libcxx] Add use-libunwind x86_64 builders to buildbot

gribozavr added a comment. LGTM. http://reviews.llvm.org/D20781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20781: [libcxx] Add use-libunwind x86_64 builders to buildbot

rmaprath created this revision. rmaprath added reviewers: EricWF, gribozavr, gkistanova, rengolin. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Currently, only the ARM libcxx builder seems to test libunwind (`-DLIBCXXABI_USE_LLVM_UNWINDER=ON` cmake option).

r271176 - [X86] Simplify alignr builtin support by recognizing that NumLaneElts is always 16. NFC

Author: ctopper Date: Sun May 29 02:06:02 2016 New Revision: 271176 URL: http://llvm.org/viewvc/llvm-project?rev=271176=rev Log: [X86] Simplify alignr builtin support by recognizing that NumLaneElts is always 16. NFC Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: