r271250 - [X86] Use unaligned load intrinsics to implement other intrinsics instead of manually creating the unaligned load.

Author: ctopper Date: Tue May 31 00:49:13 2016 New Revision: 271250 URL: http://llvm.org/viewvc/llvm-project?rev=271250=rev Log: [X86] Use unaligned load intrinsics to implement other intrinsics instead of manually creating the unaligned load. Modified: cfe/trunk/lib/Headers/avxintrin.h

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF marked 6 inline comments as done. EricWF added a comment. @majnemer Thanks for looking at this! Comment at: include/experimental/filesystem:610 @@ +609,3 @@ +static void __append_range(string& __dest, _Iter __b, _Iter __e) { +// TODO(EricWF) We get better

Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic

Hi Alexey, On 31 May 2016 at 12:25, Alexey Bataev wrote: > Hi Will, > Thanks for the report and sorry for a delay with answer. Generally, your > patch looks good with some small nits. I can fix some minor issues like > extra braces etc. and commit it if you don't mind. >

[libcxx] r271249 - Mark LWG issue 2520 as complete

Author: ericwf Date: Mon May 30 23:27:57 2016 New Revision: 271249 URL: http://llvm.org/viewvc/llvm-project?rev=271249=rev Log: Mark LWG issue 2520 as complete Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/pointer_deleter02.pass.cpp

Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic

Hi Will, Thanks for the report and sorry for a delay with answer. Generally, your patch looks good with some small nits. I can fix some minor issues like extra braces etc. and commit it if you don't mind. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

majnemer added a subscriber: majnemer. Comment at: include/experimental/filesystem:610 @@ +609,3 @@ +static void __append_range(string& __dest, _Iter __b, _Iter __e) { +// TODO(EricWF) We get better allocation behavior here if we don't +// provide the same

Re: [PATCH] D20709: Support ARM subtarget feature +long64

srhines added a comment. In http://reviews.llvm.org/D20709#443536, @kristof.beyls wrote: > Hi Pirama, > > My understanding is that this introduces (yet another) ARM 32 bit ABI variant > - in this case with longs being 64 bit. > My understanding is also that this is the ABI that is used in

[libcxx] r271248 - Add tests that got missed in r271247.

Author: ericwf Date: Mon May 30 20:51:34 2016 New Revision: 271248 URL: http://llvm.org/viewvc/llvm-project?rev=271248=rev Log: Add tests that got missed in r271247. Added: libcxx/trunk/test/libcxx/thread/futures/futures.promise/

[libcxx] r271247 - Mark LWG issue 2276 as complete. Add _LIBCPP_ASSERTS for it

Author: ericwf Date: Mon May 30 20:50:55 2016 New Revision: 271247 URL: http://llvm.org/viewvc/llvm-project?rev=271247=rev Log: Mark LWG issue 2276 as complete. Add _LIBCPP_ASSERTS for it Modified: libcxx/trunk/include/future libcxx/trunk/www/cxx1z_status.html Modified:

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF added a comment. Thanks. I fixed the missing include causing most of the failures. Please update me when you can with new results. http://reviews.llvm.org/D16948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a comment. In http://reviews.llvm.org/D16948#443942, @EricWF wrote: > In http://reviews.llvm.org/D16948#443941, @rmaprath wrote: > > > I'm seeing a few failures on my Fedora 20 system. Will go through these > > tomorrow. > > > If you want to just send me the raw ouput I'll go

[libcxx] r271241 - Mark LWG issue 2537 as complete

Author: ericwf Date: Mon May 30 20:11:20 2016 New Revision: 271241 URL: http://llvm.org/viewvc/llvm-project?rev=271241=rev Log: Mark LWG issue 2537 as complete Modified: libcxx/trunk/test/std/containers/container.adaptors/priority.queue/priqueue.cons.alloc/ctor_comp_cont_alloc.pass.cpp

[libcxx] r271240 - Mark LWG issue #2585 as complete

Author: ericwf Date: Mon May 30 20:03:07 2016 New Revision: 271240 URL: http://llvm.org/viewvc/llvm-project?rev=271240=rev Log: Mark LWG issue #2585 as complete Modified: libcxx/trunk/test/std/containers/sequences/forwardlist/forwardlist.modifiers/resize_size_value.pass.cpp

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF added a comment. In http://reviews.llvm.org/D16948#443941, @rmaprath wrote: > I'm seeing a few failures on my Fedora 20 system. Will go through these > tomorrow. If you want to just send me the raw ouput I'll go over them tonight. http://reviews.llvm.org/D16948

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a comment. I'm seeing a few failures on my Fedora 20 system. Will go through these tomorrow. http://reviews.llvm.org/D16948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Just for reference here is a list of symbols which have been removed: https://gist.github.com/EricWF/bf00dbc5fccc78b779f8d260727a0710 LGTM. Your free to submit it after addressing the inline

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

flx added a comment. Alex, Sam, could you take another look? It'd be great to get this change in to make the check more useful. http://reviews.llvm.org/D20277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF added a comment. Nevermind. I figured out why it wasn't working. Phab didn't know the libc++ patch was in a different repo and so it wouldn't apply the patch. http://reviews.llvm.org/D20677 ___ cfe-commits mailing list

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF added a comment. For some reason I'm having trouble applying your patch. Could you please upload it with more context? (ie git diff -U999 or similar) http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

This revision was automatically updated to reflect the committed changes. Closed by commit rL271239: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const… (authored by flx). Changed prior to commit: http://reviews.llvm.org/D20010?vs=58181=59010#toc Repository: rL LLVM

[clang-tools-extra] r271239 - [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified.

Author: flx Date: Mon May 30 19:25:57 2016 New Revision: 271239 URL: http://llvm.org/viewvc/llvm-project?rev=271239=rev Log: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified. Summary: Also trigger the check in the

[libcxx] r271238 - Mark LWG issue 2565 as complete. Update the tests to check it.

Author: ericwf Date: Mon May 30 19:23:31 2016 New Revision: 271238 URL: http://llvm.org/viewvc/llvm-project?rev=271238=rev Log: Mark LWG issue 2565 as complete. Update the tests to check it. Added:

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath marked 6 inline comments as done. rmaprath added a comment. http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath updated this revision to Diff 59009. rmaprath added a comment. Addressed review comments from @EricWF: - Addressed the nits - Disabled `backtrace_test.pass.cpp` for the moment, need to check if using `_Unwind_backtrace` with no unwinding tables (-fno-exceptions) makes sense - Enabled a

[libcxx] r271237 - Make string_view work with -fno-exceptions and get tests passing.

Author: ericwf Date: Mon May 30 18:53:19 2016 New Revision: 271237 URL: http://llvm.org/viewvc/llvm-project?rev=271237=rev Log: Make string_view work with -fno-exceptions and get tests passing. Modified: libcxx/trunk/include/experimental/string_view

Re: r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

On 30 May 2016 at 16:48, Saleem Abdulrasool wrote: > On Mon, May 30, 2016 at 12:54 PM, Rafael Espíndola > wrote: >> >> Why .rodata.cfstring? Which linker treats that specially? > > > Its mimicking the fact that the CF macros tried to place the

[libcxx] r271235 - Cleanup error handling when TLS creation fails

Author: ericwf Date: Mon May 30 18:15:19 2016 New Revision: 271235 URL: http://llvm.org/viewvc/llvm-project?rev=271235=rev Log: Cleanup error handling when TLS creation fails Modified: libcxx/trunk/include/thread Modified: libcxx/trunk/include/thread URL:

[libcxx] r271231 - Mark LWG issue #2522 as complete

Author: ericwf Date: Mon May 30 16:30:46 2016 New Revision: 271231 URL: http://llvm.org/viewvc/llvm-project?rev=271231=rev Log: Mark LWG issue #2522 as complete Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF added a comment. Looking good. I would like to see some tests for the methods we have specificly defined to have behavior in -fno-exceptions mode. Comment at: src/cxa_noexception.cpp:27 @@ +26,3 @@ + +_LIBCXXABI_FUNC_VIS void +__cxa_increment_exception_refcount(void

[PATCH] D20800: Make placeholders constexpr in C++17

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Implement LWG issue #2488 (http://cplusplus.github.io/LWG/lwg-defects.html#2488). http://reviews.llvm.org/D20800 Files: include/functional src/bind.cpp

Re: [PATCH] D20784: [libcxx][libcxxabi] Decouple no-exceptions libcpp variant from cxa_exception.cpp and cxa_personality.cpp of libcxxabi

rmaprath abandoned this revision. rmaprath added a comment. Updated http://reviews.llvm.org/D20677 with the necessary changes. This patch is no longer required. http://reviews.llvm.org/D20784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20798: clang-format: [JS] Sort imported symbols.

mprobst updated this revision to Diff 59001. mprobst added a comment. - extract method for readability http://reviews.llvm.org/D20798 Files: lib/Format/Format.cpp lib/Format/SortJavaScriptImports.cpp unittests/Format/SortImportsTestJS.cpp Index: unittests/Format/SortImportsTestJS.cpp

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath updated this revision to Diff 59000. rmaprath added a comment. Addressing review comments from @EricWF: - Rather than explicitly decoupling the no-exceptions `libc++` library from the `__cxa_*` routines (http://reviews.llvm.org/D20784), provide a placeholder implementation of those

Re: r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

On Mon, May 30, 2016 at 12:54 PM, Rafael Espíndola < rafael.espind...@gmail.com> wrote: > Why .rodata.cfstring? Which linker treats that specially? > Its mimicking the fact that the CF macros tried to place the structures in their own section. This would technically allow a linker to coalesce

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric updated this revision to Diff 58993. ioeric added a comment. - Removed inline from isHeaderInsertion. http://reviews.llvm.org/D20734 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric updated this revision to Diff 58992. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed reviewer's comments. http://reviews.llvm.org/D20734 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index:

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl updated this revision to Diff 58991. yaxunl marked 5 inline comments as done. yaxunl added a comment. Fix variable capitalization and indentation. http://reviews.llvm.org/D20133 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGenOpenCL/as_type.cl Index: test/CodeGenOpenCL/as_type.cl

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1550 @@ +1549,3 @@ + HeaderInsertionReplaces = + fixCppIncludeInsertions(Code, HeaderInsertionReplaces, Style); + NewReplaces.insert(HeaderInsertionReplaces.begin(), djasper wrote: > So, not

Re: [PATCH] D20784: [libcxx][libcxxabi] Decouple no-exceptions libcpp variant from cxa_exception.cpp and cxa_personality.cpp of libcxxabi

rmaprath added a comment. In http://reviews.llvm.org/D20784#443708, @EricWF wrote: > I don't like the direction of this patch, and it seems like the wrong > direction for what your trying to achieve as well. > If your trying to support a system with two variants of libc++abi, one that >

Re: r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

Why .rodata.cfstring? Which linker treats that specially? On 30 May 2016 at 12:23, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Mon May 30 11:23:07 2016 > New Revision: 271211 > > URL: http://llvm.org/viewvc/llvm-project?rev=271211=rev > Log: >

[PATCH] D20798: clang-format: [JS] Sort imported symbols.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. E.g. sort `import {b, a} from 'x';` into `import {a, b} from 'x';`. http://reviews.llvm.org/D20798 Files: lib/Format/Format.cpp

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

djasper added inline comments. Comment at: lib/Format/Format.cpp:1284 @@ +1283,3 @@ + // if \p CheckMainHeader is true and \p IncludeName is a main header, returns + // 0. Otherwise, returns INT_MAX if \p IncludeName does not match any category + // pattern.

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff marked 2 inline comments as done. sepavloff added a comment. In http://reviews.llvm.org/D16989#432282, @rsmith wrote: > Please also add some testcases for the corresponding case for a friend > function template: > > template void f(); > template struct A { > template void f()

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 58983. sepavloff added a comment. Updated patch http://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp Index: test/SemaCXX/friend2.cpp

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1550 @@ +1549,3 @@ +// Insert #include directives into the correct blocks. +tooling::Replacements fixHeaderInsertions(StringRef Code, + const tooling::Replacements ,

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric updated this revision to Diff 58982. ioeric marked 16 inline comments as done. ioeric added a comment. - Addressed reviewers' comments. http://reviews.llvm.org/D20734 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index:

r271221 - CodeGen: address post-commit review comments

Author: compnerd Date: Mon May 30 13:26:06 2016 New Revision: 271221 URL: http://llvm.org/viewvc/llvm-project?rev=271221=rev Log: CodeGen: address post-commit review comments David Majnemer pointed out that isOSBinFormatMachO is more compact. NFC. Modified:

r271219 - [X86][SSE] Added missing tests (merge failure)

Author: rksimon Date: Mon May 30 12:58:38 2016 New Revision: 271219 URL: http://llvm.org/viewvc/llvm-project?rev=271219=rev Log: [X86][SSE] Added missing tests (merge failure) Differential Revision: http://reviews.llvm.org/D20617 Modified: cfe/trunk/test/CodeGen/sse-builtins.c Modified:

Re: [PATCH] D20617: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL271218: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer (authored by RKSimon). Changed prior to commit: http://reviews.llvm.org/D20617?vs=58397=58979#toc Repository: rL LLVM

r271218 - [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer

Author: rksimon Date: Mon May 30 12:55:25 2016 New Revision: 271218 URL: http://llvm.org/viewvc/llvm-project?rev=271218=rev Log: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer According to the gcc headers, intel intrinsics docs and msdn codegen the _mm_store1_pd (and

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl marked 7 inline comments as done. Comment at: lib/CodeGen/CGExprScalar.cpp:3420 @@ -3407,35 +3419,3 @@ llvm::Type *SrcTy = Src->getType(); - if (isa(DstTy) && isa(SrcTy)) { -unsigned numElementsDst = cast(DstTy)->getNumElements(); -unsigned numElementsSrc =

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

djasper added inline comments. Comment at: include/clang/Format/Format.h:778 @@ -776,1 +777,3 @@ +/// replacement corresponding to the header insertion has offset UINT_MAX (i.e. +/// -1U). tooling::Replacements Why don't we just stick with UINT_MAX everywhere?

[PATCH] D20795: Added ASTStructure for analyzing the structure of Stmts.

teemperor created this revision. teemperor added reviewers: v.g.vassilev, zaks.anna. teemperor added a subscriber: cfe-commits. The ASTStructure class generates data for performant searching Stmts with similar structure. http://reviews.llvm.org/D20795 Files: include/clang/AST/ASTStructure.h

Re: [PATCH] D20791: Support SOURCE_DATE_EPOCH environment variable

emaste updated this revision to Diff 58977. emaste added a comment. Use gmtime to report in UTC when `SOURCE_DATE_EPOCH` is set. This follows GCC and makes sense given the purpose of `SOURCE_DATE_EPOCH`. For reference here is discussion on the GCC list when this was introduced there:

Re: [PATCH] D20630: [OpenCL] Allow -std={cl|CL}{|1.1|1.2|2.0} in driver

yaxunl updated this revision to Diff 58978. yaxunl added a comment. Revised as Richard suggested. http://reviews.llvm.org/D20630 Files: include/clang/Frontend/LangStandards.def lib/Frontend/CompilerInvocation.cpp test/Driver/opencl.cl test/Frontend/stdlang.c Index:

Re: [PATCH] D20784: [libcxx][libcxxabi] Decouple no-exceptions libcpp variant from cxa_exception.cpp and cxa_personality.cpp of libcxxabi

EricWF added a comment. I don't like the direction of this patch, and it seems like the wrong direction for what your trying to achieve as well. If your trying to support a system with two variants of libc++abi, one that throws and the other that does not, then you'll want libc++ to remain

Re: [PATCH] D20794: [CUDA] Fix order of vectorized ldg intrinsics' elements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271215: [CUDA] Fix order of vectorized ldg intrinsics' elements. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D20794?vs=58972=58976#toc Repository: rL LLVM

r271215 - [CUDA] Fix order of vectorized ldg intrinsics' elements.

Author: jlebar Date: Mon May 30 12:12:55 2016 New Revision: 271215 URL: http://llvm.org/viewvc/llvm-project?rev=271215=rev Log: [CUDA] Fix order of vectorized ldg intrinsics' elements. Summary: The order is [x, y, z, w], not [w, x, y, z]. Subscribers: cfe-commits, tra Differential Revision:

r271214 - [X86] Replace unaligned store builtins in SSE/AVX intrinsic files with code that will compile to a native unaligned store. Remove the builtins since they are no longer used.

Author: ctopper Date: Mon May 30 12:10:30 2016 New Revision: 271214 URL: http://llvm.org/viewvc/llvm-project?rev=271214=rev Log: [X86] Replace unaligned store builtins in SSE/AVX intrinsic files with code that will compile to a native unaligned store. Remove the builtins since they are no

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

bkramer added inline comments. Comment at: include-fixer/IncludeFixer.h:71 @@ +70,3 @@ +/// \param FirstIncludeOffset The insertion point for new include directives. +/// -1U(UINT_MAX) indicates uninitialization, which will insert the header at +/// first line. If there is no

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

bkramer added inline comments. Comment at: lib/Format/Format.cpp:1283 @@ +1282,3 @@ + // Returns the priority of the category which \p IncludeName belongs to, and + // if \p CheckMainHeader is true and \p IncldueName is a + // main header, returns 0. Otherwise, returns INT_MAX

[PATCH] D20794: [CUDA] Fix order of vectorized ldg intrinsics' elements.

jlebar created this revision. jlebar added subscribers: tra, cfe-commits. The order is [x, y, z, w], not [w, x, y, z]. http://reviews.llvm.org/D20794 Files: lib/Headers/__clang_cuda_intrinsics.h Index: lib/Headers/__clang_cuda_intrinsics.h

r271212 - test: add explicit targets for some tests

Author: compnerd Date: Mon May 30 11:36:48 2016 New Revision: 271212 URL: http://llvm.org/viewvc/llvm-project?rev=271212=rev Log: test: add explicit targets for some tests These tests currently expect MachO section names and do not provide a target. Explicitly provide one. Modified:

Re: [PATCH] D20660: Remove `auto_ptr` in C++17.

EricWF added a comment. FYI I have a LIT change out for review that adds "// REQUIRES-ANY: [...]" which would be subtle for use in this patch. http://reviews.llvm.org/D20757 http://reviews.llvm.org/D20660 ___ cfe-commits mailing list

r271211 - CodeGen: tweak CFConstantStrings for COFF and ELF

Author: compnerd Date: Mon May 30 11:23:07 2016 New Revision: 271211 URL: http://llvm.org/viewvc/llvm-project?rev=271211=rev Log: CodeGen: tweak CFConstantStrings for COFF and ELF Adjust the constant CFString emission to emit into more appropriate sections on ELF and COFF targets. It would

Re: [PATCH] D19165: [clang-tidy] Add modernize-increment-bool check.

mnbvmar updated this revision to Diff 58940. mnbvmar added a comment. Clang-formatted code. Added a simple macro test. Resolved @Prazek's issues. http://reviews.llvm.org/D19165 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/IncrementBoolCheck.cpp

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. drive-by Comment at: clang-tidy/ClangTidy.cpp:24 @@ -24,2 +23,3 @@ #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Frontend/ASTConsumers.h" +#include "clang/Basic/DiagnosticOptions.h" +#include "clang/Basic/FileManager.h"

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein added inline comments. Comment at: include-fixer/IncludeFixer.h:80 @@ +79,3 @@ +unsigned FirstIncludeOffset=-1U, +const clang::format::FormatStyle =clang::format::getLLVMStyle()); + Using a default argument in `Style` can simplify the code in some

[clang-tools-extra] r271210 - [clang-tidy] Remove redundant quote in add_new_check script

Author: etienneb Date: Mon May 30 10:42:08 2016 New Revision: 271210 URL: http://llvm.org/viewvc/llvm-project?rev=271210=rev Log: [clang-tidy] Remove redundant quote in add_new_check script Summary: Remove redundant quote. These quotes were added here: http://reviews.llvm.org/D20766 Reviewers:

Re: [PATCH] D20792: [clang-tidy] Remove redundant quote in add_new_check script

etienneb updated this revision to Diff 58969. etienneb added a comment. nits http://reviews.llvm.org/D20792 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py === --- clang-tidy/add_new_check.py +++

Re: [PATCH] D20792: [clang-tidy] Remove redundant quote in add_new_check script

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks! http://reviews.llvm.org/D20792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20792: [clang-tidy] Remove redundant quote in add_new_check script

etienneb created this revision. etienneb added a reviewer: bkramer. etienneb added a subscriber: cfe-commits. Remove redundant quote. These quotes were added here: http://reviews.llvm.org/D20766 http://reviews.llvm.org/D20792 Files: clang-tidy/add_new_check.py

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58964. hokein marked an inline comment as done. hokein added a comment. Use format::getStyle to get clang-format style. http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h

r271208 - [ASTMatchers] Add support of hasCondition for SwitchStmt.

Author: etienneb Date: Mon May 30 10:25:25 2016 New Revision: 271208 URL: http://llvm.org/viewvc/llvm-project?rev=271208=rev Log: [ASTMatchers] Add support of hasCondition for SwitchStmt. Summary: The switch statement could be added to the hasCondition matcher. Example: ``` clang-query> match

Re: [clang-tools-extra] r271207 - [clang-tidy] Fix script adding new clang-tidy check

On Mon, May 30, 2016 at 5:05 PM, Etienne Bergeron via cfe-commits wrote: > Author: etienneb > Date: Mon May 30 10:05:10 2016 > New Revision: 271207 > > URL: http://llvm.org/viewvc/llvm-project?rev=271207=rev > Log: > [clang-tidy] Fix script adding new clang-tidy check

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

Prazek updated this revision to Diff 58961. Prazek added a comment. aborting with virtual functions http://reviews.llvm.org/D18821 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp clang-tidy/bugprone/BoolToIntegerConversionCheck.h

[PATCH] D20791: Support SOURCE_DATE_EPOCH environment variable

emaste created this revision. emaste added a subscriber: cfe-commits. `SOURCE_DATE_EPOCH` specifies a UNIX timestamp (number of seconds since 01 Jan 1970 00:00:00 UTC) to be used as the timestamp input for build processes e.g. `__DATE__` and `__TIME__` See

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

doug.gregor added a comment. Yeah, this looks like the right approach. PCH follows the same rules as modules when it comes to newer information shadowing imported information. http://reviews.llvm.org/D20383 ___ cfe-commits mailing list

[clang-tools-extra] r271207 - [clang-tidy] Fix script adding new clang-tidy check

Author: etienneb Date: Mon May 30 10:05:10 2016 New Revision: 271207 URL: http://llvm.org/viewvc/llvm-project?rev=271207=rev Log: [clang-tidy] Fix script adding new clang-tidy check Summary: The `getName()` call is useless. It's better to show a better example as tutorial. Reviewers: alexfh

Re: [PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check

This revision was automatically updated to reflect the committed changes. Closed by commit rL271207: [clang-tidy] Fix script adding new clang-tidy check (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D20766?vs=58878=58958#toc Repository: rL LLVM

Re: [PATCH] D20790: [Clang][Intrinsics][avx512] Adding round cvt to clang

m_zuckerman updated this revision to Diff 58957. http://reviews.llvm.org/D20790 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c

[PATCH] D20790: [Clang][Intrinsics][avx512] Adding round cvt to clang

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20790 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

ioeric added inline comments. Comment at: include-fixer/IncludeFixer.h:80 @@ +79,3 @@ +unsigned FirstIncludeOffset=-1U, +const clang::format::FormatStyle =clang::format::getLLVMStyle()); + I don't see why we'd want Style to be optional.

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58955. hokein marked an inline comment as done. hokein added a comment. Refactor createReplacementsForHeaders. http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Anastasia, My apologies for my slow reply. My main issue was that the defaults have changed, which is somewhat annoying. However, digging deeper into this I’m noticing two serious problems: * When I do: #pragma OPENCL EXTENSION cl_khr_fp16 : disable the cl_khr_fp16 macro stays defined in

Re: [PATCH] D20618: [Clang][avx512][builtin] Adding missing intrinsics for cvt

This revision was automatically updated to reflect the committed changes. Closed by commit rL271205: [Clang][avx512][builtin] Adding missing intrinsics for cvt (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20618?vs=58405=58953#toc Repository: rL LLVM

r271205 - [Clang][avx512][builtin] Adding missing intrinsics for cvt

Author: mzuckerm Date: Mon May 30 08:22:12 2016 New Revision: 271205 URL: http://llvm.org/viewvc/llvm-project?rev=271205=rev Log: [Clang][avx512][builtin] Adding missing intrinsics for cvt Differential Revision: http://reviews.llvm.org/D20618 Modified:

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1551 @@ +1550,3 @@ +return Replaces; + tooling::Replacements HeaderInsertionReplaces; + tooling::Replacements NewReplaces; djasper wrote: > Why do you split out all the header insertion

Re: [PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric updated this revision to Diff 58952. ioeric marked 9 inline comments as done. ioeric added a comment. - Addressed reviewer's comments. http://reviews.llvm.org/D20734 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index:

r271204 - [OPENMP 4.5] Additional codegen for statically scheduled loops with

Author: abataev Date: Mon May 30 08:05:14 2016 New Revision: 271204 URL: http://llvm.org/viewvc/llvm-project?rev=271204=rev Log: [OPENMP 4.5] Additional codegen for statically scheduled loops with 'simd' modifier. Runtime library defines new schedule constant kmp_sch_static_balanced_chunked =

Re: [PATCH] D20709: Support ARM subtarget feature +long64

kristof.beyls added a comment. Hi Pirama, My understanding is that this introduces (yet another) ARM 32 bit ABI variant - in this case with longs being 64 bit. My understanding is also that this is the ABI that is used in Renderscript, and this patch helps to remove local patches that

RE: 3.8 Merge Request: r259776

Assuming I got it right... > -Original Message- > From: Alexey Bataev [mailto:a.bat...@hotmail.com] > Sent: Monday, May 30, 2016 1:31 PM > To: Hahnfeld, Jonas > Cc: cfe-commits@lists.llvm.org; Tom Stellard > Subject: Re: 3.8 Merge Request: r259776 > > I can try to rebase it to 3.8.1 but

Re: 3.8 Merge Request: r259776

I can try to rebase it to 3.8.1 but Tom wants an approve from Richard. Ping him! Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 30.05.2016 14:19, Hahnfeld, Jonas пишет: > Hi, > > last possible ping as changes are required to be merged by tomorrow... > >

RE: 3.8 Merge Request: r259776

Hi, last possible ping as changes are required to be merged by tomorrow... Cheers, Jonas > -Original Message- > From: llvm-commits [mailto:llvm-commits-boun...@lists.llvm.org] On Behalf > Of Hahnfeld, Jonas via llvm-commits > Sent: Monday, May 23, 2016 8:13 AM > To: Tom Stellard > Cc:

RE: r270373 - [driver][mips] Support new versions of MIPS CodeScape toolchains

You're welcome. I also had to challenge these issues when I introduced this "feature flag" ;-) > -Original Message- > From: Ismail Donmez [mailto:ism...@i10z.com] > Sent: Thursday, May 26, 2016 5:27 PM > To: Simon Atanasyan > Cc: Hahnfeld, Jonas; cfe-commits@lists.llvm.org > Subject: Re:

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

klimek added a subscriber: klimek. Comment at: include-fixer/IncludeFixer.cpp:397 @@ +396,3 @@ + clang::tooling::Replacements Insertions; + if (FirstIncludeOffset == -1U) { +// FIXME: skip header guards. Do we want UINT_MAX? I find the wording in the

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58942. hokein added a comment. Remove unneeded headers. http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58941. hokein marked 9 inline comments as done. hokein added a comment. Address comments. http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein added a comment. In http://reviews.llvm.org/D20621#439447, @bkramer wrote: > Can you add some lit tests for the various command line modes > clang-include-fixer has now. We can't reasonably test the vim integration but > we can tests the bits it's composed of. Done.

Re: [PATCH] D20767: [ASTMatchers] Add support of hasCondition for SwitchStmt.

klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land. LG. Thx! http://reviews.llvm.org/D20767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >