Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek updated this revision to Diff 64640. Prazek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D22208 Files: clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h clang-tidy/utils/Matchers.h

[libcxx] r276091 - Add missed test in r276090.

Author: ericwf Date: Wed Jul 20 00:22:35 2016 New Revision: 276091 URL: http://llvm.org/viewvc/llvm-project?rev=276091=rev Log: Add missed test in r276090. Added: libcxx/trunk/test/std/utilities/function.objects/func.wrap/func.wrap.func/derive_from.pass.cpp Added:

[libcxx] r276090 - Move std::function constructor SFINAE into template parameter list. Fixes PR20002.

Author: ericwf Date: Wed Jul 20 00:21:00 2016 New Revision: 276090 URL: http://llvm.org/viewvc/llvm-project?rev=276090=rev Log: Move std::function constructor SFINAE into template parameter list. Fixes PR20002. Although inheriting constructors have already been fixed in Clang 3.9 I still choose

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek marked 5 inline comments as done. Prazek added a comment. Aaron, Alex thanks for the review. After running it on llvm I also have found the private constructor bug so I also fixed it. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:21 @@ +20,3 @@

[libcxx] r276084 - Reimplement is_constructible fallback implementation. Fixes PR21574.

Author: ericwf Date: Wed Jul 20 00:01:24 2016 New Revision: 276084 URL: http://llvm.org/viewvc/llvm-project?rev=276084=rev Log: Reimplement is_constructible fallback implementation. Fixes PR21574. The previous implementation relied highly on specializations to handle special cases. This new

Re: [PATCH] D22543: [libunwind] Properly align _Unwind_Exception.

emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This revision is now accepted and ready to land. I've committed the alignment change to the copy of llvm libunwind in the FreeBSD base system now. https://reviews.llvm.org/D22543

[libcxx] r276078 - Add tests for reference binding assertions in std::tuple.

Author: ericwf Date: Tue Jul 19 21:57:39 2016 New Revision: 276078 URL: http://llvm.org/viewvc/llvm-project?rev=276078=rev Log: Add tests for reference binding assertions in std::tuple. Libc++ provides static assertions to detect reference binding issues inside tuple. This patch adds tests for

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

I'm not necessarily disagreeing, I'm saying that if I understand correctly, there are two unrelated changes (one is a build fix, and the other is a "good practice" kind of change). > On Jul 19, 2016, at 6:43 PM, Eugene Zelenko wrote: > > Eugene.Zelenko added a

[PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

EricWF created this revision. EricWF added reviewers: mclow.lists, rsmith. EricWF added subscribers: cfe-commits, rsmith. This patch uses the __attribute__((enable_if)) hack suggested by @rsmith to diagnose invalid arguments when possible. In order to diagnose an invalid argument `m` to `f(m)`

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

jlebar added a comment. FYI after talking to Chandler, I'm going to write up a separate proposal for the one-repository thing and send it to the list tomorrow. The suggestion was that this phabricator thread isn't the right place to have this discussion. https://reviews.llvm.org/D22463

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL276076: [Sema] Compute the nullability of a conditional expression based on the (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D22392?vs=64557=64628#toc Repository: rL

r276076 - [Sema] Compute the nullability of a conditional expression based on the

Author: ahatanak Date: Tue Jul 19 20:48:11 2016 New Revision: 276076 URL: http://llvm.org/viewvc/llvm-project?rev=276076=rev Log: [Sema] Compute the nullability of a conditional expression based on the nullabilities of its operands. This patch defines a function to compute the nullability of

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko added a comment. But all of them are used in code. I don't see a reason to save lines :-) Repository: rL LLVM https://reviews.llvm.org/D22555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

mehdi_amini added inline comments. Comment at: lib/Basic/FileManager.cpp:35 @@ -29,2 +34,3 @@ #include +#include That's a lot of includes though. Ok for the climits, but the other should be a separate patch I think. Repository: rL LLVM

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Tue, Jul 19, 2016 at 5:01 PM, Xinliang David Li wrote: > The new behavior works really well. There is one follow up change I would > like to discuss. > > The EQ form of the option -fprofile-generate= takes a directory name as > the argument instead of the filename.

r276074 - Revert r276069: MSVC bots not happy

Author: hubert.reinterpretcast Date: Tue Jul 19 20:05:31 2016 New Revision: 276074 URL: http://llvm.org/viewvc/llvm-project?rev=276074=rev Log: Revert r276069: MSVC bots not happy Modified: cfe/trunk/include/clang/AST/DeclTemplate.h cfe/trunk/lib/AST/ASTContext.cpp

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

alexfh added inline comments. Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:218 @@ +217,3 @@ + + StringRef TypedefToCompare = Typedef->getDecl()->getQualifiedNameAsString(); + // Check if the typedef is known and not matching the MPI datatype.

r276073 - Fix r276069: add default argument for new parameter

Author: hubert.reinterpretcast Date: Tue Jul 19 19:57:56 2016 New Revision: 276073 URL: http://llvm.org/viewvc/llvm-project?rev=276073=rev Log: Fix r276069: add default argument for new parameter Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified:

r276071 - Fix r276069: use LLVM_CONSTEXPR

Author: hubert.reinterpretcast Date: Tue Jul 19 19:41:30 2016 New Revision: 276071 URL: http://llvm.org/viewvc/llvm-project?rev=276071=rev Log: Fix r276069: use LLVM_CONSTEXPR Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL:

[PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, mehdi_amini. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Build was broken because of missing climits where PATH_MAX is defined. Repository: rL LLVM

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

jlebar added a subscriber: jlebar. jlebar added a comment. I'm sure you all have thought about this more than I have, and I apologize if this has been brought up before because I haven't been following the thread closely. But I am not convinced by this document that using subrepositories

r276069 - Concepts: Create space for requires-clause in TemplateParameterList; NFC

Author: hubert.reinterpretcast Date: Tue Jul 19 19:30:15 2016 New Revision: 276069 URL: http://llvm.org/viewvc/llvm-project?rev=276069=rev Log: Concepts: Create space for requires-clause in TemplateParameterList; NFC Summary: Space for storing the //constraint-expression// of the

Re: [PATCH] D4447: [libcxx] Fixes libc++ bug #19921 - Remove additional overloads for std::complex

EricWF abandoned this revision. EricWF added a comment. Fixed in r276067. https://reviews.llvm.org/D4447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r276067 - Add SFINAE on additional overloads of std::complex functions. Fixes PR19921.

Author: ericwf Date: Tue Jul 19 19:14:10 2016 New Revision: 276067 URL: http://llvm.org/viewvc/llvm-project?rev=276067=rev Log: Add SFINAE on additional overloads of std::complex functions. Fixes PR19921. The functions arg, conj, imag, norm, proj, and real have additional overloads for arguments

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

LokiAstari added a comment. Each new style option must :: - be used in a project of significant size (have dozens of contributors) - have a publicly accessible style guide - have a person willing to contribute and maintain patches Example: https://github.com/openframeworks/openFrameworks

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Tue, Jul 19, 2016 at 5:06 PM, Vedant Kumar wrote: > > > On Jul 19, 2016, at 5:01 PM, Xinliang David Li > wrote: > > > > The new behavior works really well. There is one follow up change I > would like to discuss. > > > > The EQ form of the option

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

> On Jul 19, 2016, at 5:01 PM, Xinliang David Li wrote: > > The new behavior works really well. There is one follow up change I would > like to discuss. > > The EQ form of the option -fprofile-generate= takes a directory name as the > argument instead of the filename.

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

The new behavior works really well. There is one follow up change I would like to discuss. The EQ form of the option -fprofile-generate= takes a directory name as the argument instead of the filename. Currently the compiler will create a default 'default.profraw' name for it, but this means,

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. removing from my dashboard, while the check is waiting for Richard's comments. https://reviews.llvm.org/D21303 ___ cfe-commits mailing

Re: [PATCH] D19577: [clang-tidy] Enhance misc-suspicious-string-compare by matching string.compare

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D19577#413888, @etienneb wrote: > In https://reviews.llvm.org/D19577#413526, @alexfh wrote: > > > I'm somewhat reluctant to add LLVM-specific checks to

Re: [PATCH] D22543: [libunwind] Properly align _Unwind_Exception.

kledzik added a comment. LGTM https://reviews.llvm.org/D22543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r276059 - Add heterogeneous comparator support for __debug_less. Fixes PR17147.

Author: ericwf Date: Tue Jul 19 18:27:18 2016 New Revision: 276059 URL: http://llvm.org/viewvc/llvm-project?rev=276059=rev Log: Add heterogeneous comparator support for __debug_less. Fixes PR17147. Added: libcxx/trunk/test/libcxx/algorithms/debug_less.pass.cpp Modified:

Re: [PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

Quuxplusone added a subscriber: Quuxplusone. Comment at: test/CodeGen/no-devirt.cpp:16 @@ +15,3 @@ + if (a > 6) return data[a] ; // Should not devirtualize + if (a > 4) return data.func1(a); // Should devirtualize + return data.func2(a);// Should

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:31 @@ +30,3 @@ + +const std::string DefaultContainersWithPushBack = +"::std::vector; ::std::list; ::std::deque"; A

Re: r275895 - [Driver] Compute effective target triples once per job (NFCI)

> On Jul 19, 2016, at 3:38 PM, Eric Christopher wrote: > > > > On Tue, Jul 19, 2016 at 3:24 PM Vedant Kumar wrote: > > > On Jul 19, 2016, at 3:02 PM, Eric Christopher wrote: > > > > ... this is pretty crazy. I think that you needed to

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D22392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r275895 - [Driver] Compute effective target triples once per job (NFCI)

> On Jul 19, 2016, at 3:02 PM, Eric Christopher wrote: > > ... this is pretty crazy. I think that you needed to plumb the effective > triple through everything means that it really needs to be owned somewhere > else and cached. > > Can you rethink this? In general it

Re: [PATCH] D22543: [libunwind] Properly align _Unwind_Exception.

compnerd added a comment. LGTM; we should make sure Nick is okay with it as well (for Darwin). This should also make its way into 3.9 I think. https://reviews.llvm.org/D22543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22543: [libunwind] Properly align _Unwind_Exception.

EricWF created this revision. EricWF added reviewers: mclow.lists, compnerd. EricWF added a subscriber: cfe-commits. _Unwind_Exception is required to be double word aligned. Currently the struct is under aligned. https://reviews.llvm.org/D22543 Files: include/unwind.h

[PATCH] D22542: [CodeGen] Fix a crash on valid when constant folding 'default:' statement in switch

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, manmanren. erik.pilkington added a subscriber: cfe-commits. The following valid code crashes Clang in CodeGen: ``` void other_test() { switch(0) { case 0: do { default:; } while(0); } } ``` The

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

mmasten updated this revision to Diff 64571. https://reviews.llvm.org/D19544 Files: include/llvm/Analysis/TargetLibraryInfo.h lib/Analysis/TargetLibraryInfo.cpp test/Transforms/LoopVectorize/X86/svml-calls.ll Index: lib/Analysis/TargetLibraryInfo.cpp

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Prazek added a subscriber: Prazek. Comment at: clang-tidy/cppcoreguidelines/RuleOfFiveAndZeroCheck.cpp:73-77 @@ +72,7 @@ + + checkRuleOfFiveViolation(Result, "dtor", "destructor"); + checkRuleOfFiveViolation(Result, "copy-ctor", "copy constructor"); +

[libcxxabi] r276022 - Attempt to bring peace to -Werror buildbots.

Author: rsmith Date: Tue Jul 19 15:35:09 2016 New Revision: 276022 URL: http://llvm.org/viewvc/llvm-project?rev=276022=rev Log: Attempt to bring peace to -Werror buildbots. Modified: libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp Modified:

Re: [PATCH] D21453: Add support for attribute "overallocated"

ahatanak added a comment. ping https://reviews.llvm.org/D21453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

ahatanak updated this revision to Diff 64557. ahatanak added a comment. Remove the check "if (LHSKind == RHSKind)" in computeConditionalNullability as it's not needed. https://reviews.llvm.org/D22392 Files: lib/Sema/SemaExpr.cpp test/Sema/nullability.c test/SemaCXX/nullability.cpp

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno closed this revision. bruno added a comment. Thanks Manman, Committed r276020 https://reviews.llvm.org/D22183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r276020 - [SemaObjC] Improve ObjCDictionaryLiteral and ObjCArryLiteral diagnostics

Author: bruno Date: Tue Jul 19 15:21:18 2016 New Revision: 276020 URL: http://llvm.org/viewvc/llvm-project?rev=276020=rev Log: [SemaObjC] Improve ObjCDictionaryLiteral and ObjCArryLiteral diagnostics Sema actions on ObjCDictionaryLiteral and ObjCArryLiteral are currently done as a side-effect of

Re: [PATCH] D22528: [libcxxabi] When catching an exception of type nullptr_t with a handler of pointer-to-member type, produce a null value of the right type

rsmith closed this revision. rsmith added a comment. Committed as r276016. Repository: rL LLVM https://reviews.llvm.org/D22528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r276016 - [libcxxabi] When catching an exception of type nullptr_t with a handler of

Author: rsmith Date: Tue Jul 19 15:19:37 2016 New Revision: 276016 URL: http://llvm.org/viewvc/llvm-project?rev=276016=rev Log: [libcxxabi] When catching an exception of type nullptr_t with a handler of pointer-to-member type, produce a null value of the right type. This fixes a bug where

Re: [PATCH] D22392: [Sema] Fix an invalid nullability warning for binary conditional operators

ahatanak updated this revision to Diff 64551. ahatanak added a comment. Address review comments. - Rename function to computeConditionalNullability. - Rewrite the function to compute the nullability of both normal and binary conditional expressions. - Add more test cases.

r276014 - Let FuncAttrs infer the 'returned' argument attribute

Author: majnemer Date: Tue Jul 19 14:59:24 2016 New Revision: 276014 URL: http://llvm.org/viewvc/llvm-project?rev=276014=rev Log: Let FuncAttrs infer the 'returned' argument attribute This reverts commit r275756. Modified: cfe/trunk/test/CodeGen/ppc64-struct-onevect.c

Re: [PATCH] D22528: [libcxxabi] When catching an exception of type nullptr_t with a handler of pointer-to-member type, produce a null value of the right type

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D22528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22528: [libcxxabi] When catching an exception of type nullptr_t with a handler of pointer-to-member type, produce a null value of the right type

rsmith added inline comments. Comment at: src/CMakeLists.txt:94 @@ -93,3 +93,3 @@ PROPERTIES -COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS}" +COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS} -fno-modules" ) Err, ignore this :) Repository: rL LLVM

[PATCH] D22528: [libcxxabi] When catching an exception of type nullptr_t with a handler of pointer-to-member type, produce a null value of the right type

rsmith created this revision. rsmith added reviewers: EricWF, mclow.lists. rsmith added a subscriber: cfe-commits. rsmith set the repository for this revision to rL LLVM. This fixes a bug where throwing an exception of type nullptr_t and catching it as a pointer-to-member would not guarantee to

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Eugene.Zelenko added a comment. Will be good idea to introduce similar check for C++98/03. Repository: rL LLVM https://reviews.llvm.org/D22513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r276010 - [OpenCL] Fixes bug of missing OCL version metadata on the AMDGCN target

Author: yaxunl Date: Tue Jul 19 14:39:45 2016 New Revision: 276010 URL: http://llvm.org/viewvc/llvm-project?rev=276010=rev Log: [OpenCL] Fixes bug of missing OCL version metadata on the AMDGCN target Added the opencl.ocl.version metadata to be emitted with amdgcn. Created a static function

Re: [PATCH] D22424: [OpenCL] Fixes bug of missing OCL related metadata on the AMDGCN target

This revision was automatically updated to reflect the committed changes. Closed by commit rL276010: [OpenCL] Fixes bug of missing OCL version metadata on the AMDGCN target (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D22424?vs=64513=64545#toc Repository: rL LLVM

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

Unit test ImportVAArgExpr fails on Windows. The source file: void declToImport(__builtin_va_list list, ...) { (void)__builtin_va_arg(list, int); } When compiled on Windows it produces AST: TranslationUnitDecl 0x638f150 <> `-FunctionDecl 0x638f780 line:1:6

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM https://reviews.llvm.org/D22523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

eli.friedman accepted this revision. eli.friedman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D22105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] r276009 - amdgpu: Use right builtn for rsq

Author: arsenm Date: Tue Jul 19 14:02:01 2016 New Revision: 276009 URL: http://llvm.org/viewvc/llvm-project?rev=276009=rev Log: amdgpu: Use right builtn for rsq The r600 path has never actually worked sinced double is not implemented there. Modified: libclc/trunk/amdgpu/lib/math/sqrt.cl

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

ashi1 updated this revision to Diff 64538. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Sam's comments. Also updated test file to changes with using triple spir-unknown-unknown. Repository: rL LLVM https://reviews.llvm.org/D22523 Files:

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

RKSimon updated this revision to Diff 64534. RKSimon added a comment. Removed sitofp conversion changes Repository: rL LLVM https://reviews.llvm.org/D22105 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avxintrin.h lib/Headers/emmintrin.h lib/Headers/xmmintrin.h

[PATCH] D22525: [Sema] Add sizeof diagnostics for bzero

bruno created this revision. bruno added a reviewer: zaks.anna. bruno added a subscriber: cfe-commits. For memset (and others) we can get diagnostics like: struct stat { int x; }; void foo(struct stat *stamps) { memset(stamps, 0, sizeof(stamps)); } t.c:7:28: warning: 'memset' call

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

RKSimon added a comment. In https://reviews.llvm.org/D22105#488566, @eli.friedman wrote: > The x86-specific operation is affected by the rounding mode... but so is a C > cast. This is specified by Annex F in the C standard. > > Of course, you're going to end up with undefined behavior if you

Re: [PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

yaxunl added inline comments. Comment at: test/CodeGenOpenCL/opencl_types.cl:1 @@ -1,1 +1,2 @@ -// RUN: %clang_cc1 %s -emit-llvm -o - -O0 | FileCheck %s +// RUN: %clang_cc1 %s -emit-llvm -o - -O0 | FileCheck %s --check-prefix=CHECK-NORMAL +// RUN: %clang_cc1 %s -triple

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl added inline comments. Comment at: lib/Sema/SemaInit.cpp:6917-6929 @@ -6915,4 +6916,15 @@ << SourceType; - } else if (Entity.getKind() != InitializedEntity::EK_Variable) { -llvm_unreachable("Invalid EntityKind!"); + break; +} else

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated this revision to Diff 64529. yaxunl marked 7 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D21567 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticGroups.td

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

arsenm added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:6856 @@ +6855,3 @@ + } + else if (StrTy->getNumElements() == 1) { +// Coerce single element structs to its element. No else after return Comment at:

[PATCH] D22523: [OpenCL] AMDGCN target will generate images in constant address space

ashi1 created this revision. ashi1 added reviewers: yaxunl, Anastasia. ashi1 added a subscriber: cfe-commits. ashi1 set the repository for this revision to rL LLVM. Allows AMDGCN target to generate images (such as %opencl.image2d_t) in constant address space. Images will still be generated in

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

spatel added a subscriber: davide. spatel added a comment. In https://reviews.llvm.org/D19544#488589, @mmasten wrote: > In the process of writing test cases, I noticed that a loop with a call to > llvm.log.f32 was not getting vectorized due to cost modeling. When forcing > vectorization on the

[libcxx] r276003 - Fix undefined behavior in __tree

Author: ericwf Date: Tue Jul 19 12:56:20 2016 New Revision: 276003 URL: http://llvm.org/viewvc/llvm-project?rev=276003=rev Log: Fix undefined behavior in __tree Summary: This patch attempts to fix the undefined behavior in __tree by changing the node pointer types used throughout. The pointer

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 64525. EricWF added a comment. Add test for PR28469 and remove __tree from the UBSAN blacklist. https://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander_Droste marked 2 inline comments as done. Alexander_Droste added a comment. Thanks for looking over this once more. I'll set up an extra MPI folder and rename the check. One comment inline. Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:218 @@ +217,3 @@ + +

Re: [PATCH] D19544: Pass for translating math intrinsics to math library calls.

mmasten added a comment. In the process of writing test cases, I noticed that a loop with a call to llvm.log.f32 was not getting vectorized due to cost modeling. When forcing vectorization on the loop and throwing -fveclib=SVML, the loop was vectorized with a widened intrinsic instead of the

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D18360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

eli.friedman added a comment. The x86-specific operation is affected by the rounding mode... but so is a C cast. This is specified by Annex F in the C standard. Of course, you're going to end up with undefined behavior if you actually modify the rounding mode because LLVM and clang don't

[libunwind] r275997 - libunwind: sync some coments with NetBSD's version

Author: emaste Date: Tue Jul 19 12:28:38 2016 New Revision: 275997 URL: http://llvm.org/viewvc/llvm-project?rev=275997=rev Log: libunwind: sync some coments with NetBSD's version NetBSD's system unwinder is a modified version of LLVM's libunwind. Slightly reduce diffs by updating comments to

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

RKSimon added a comment. In https://reviews.llvm.org/D22105#488513, @eli.friedman wrote: > I don't think we need to use x86-specific operations for sitofp-like > conversions; the C cast is equivalent given that a 32 or 64-bit integer is > always in within the range of a 32-bit float. I think

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki updated this revision to Diff 64518. apaprocki added a comment. Increased context and removed accidental inclusion of Solaris change. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

etienneb added a comment. drive-by, some comments. Thanks for the check Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:20 @@ +19,3 @@ +// Return the number of EnumConstantDecls in an EnumDecl. +static int enumLen(const EnumDecl *EnumDec) { + int Counter = 0;

[libunwind] r275996 - libunwind: Use conventional DWARF capitalization in comments and errors

Author: emaste Date: Tue Jul 19 12:15:50 2016 New Revision: 275996 URL: http://llvm.org/viewvc/llvm-project?rev=275996=rev Log: libunwind: Use conventional DWARF capitalization in comments and errors Modified: libunwind/trunk/include/libunwind.h

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

eli.friedman added a comment. I don't think we need to use x86-specific operations for sitofp-like conversions; the C cast is equivalent given that a 32 or 64-bit integer is always in within the range of a 32-bit float. Repository: rL LLVM https://reviews.llvm.org/D22105

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst. See pre-4.0 branch versions as example. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:116 @@ +115,3 @@ +} +// if there is only one not

[clang-tools-extra] r275993 - cppcoreguidelines-pro-bounds-constant-array-index: ignore implicit constructor

Author: mgehre Date: Tue Jul 19 12:02:54 2016 New Revision: 275993 URL: http://llvm.org/viewvc/llvm-project?rev=275993=rev Log: cppcoreguidelines-pro-bounds-constant-array-index: ignore implicit constructor Summary: The code struct A { int x[3]; }; gets an compiler-generated copy

Re: [PATCH] D22381: cppcoreguidelines-pro-bounds-constant-array-index: ignore implicit constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL275993: cppcoreguidelines-pro-bounds-constant-array-index: ignore implicit constructor (authored by mgehre). Changed prior to commit: https://reviews.llvm.org/D22381?vs=64035=64515#toc Repository:

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst. See pre-4.0 branch versions as example. Comment at: docs/clang-tidy/checks/cppcoreguidelines-rule-of-five-and-zero.rst:15 @@ +14,3 @@ + +Note

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D22518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22424: [OpenCL] Fixes bug of missing OCL related metadata on the AMDGCN target

ashi1 updated this revision to Diff 64513. ashi1 marked an inline comment as done. ashi1 added a comment. Revised based on Anastasia's comments. Now using new function name appendOpenCLVersionMD( Repository: rL LLVM https://reviews.llvm.org/D22424 Files: lib/CodeGen/TargetInfo.cpp

[clang-tools-extra] r275986 - clangRename: Update libdeps to add clangASTMatchers.

Author: chapuni Date: Tue Jul 19 10:53:11 2016 New Revision: 275986 URL: http://llvm.org/viewvc/llvm-project?rev=275986=rev Log: clangRename: Update libdeps to add clangASTMatchers. Note, ClangRenameTests is linking USRFindingAction.cpp directly. Modified:

[clang-tools-extra] r275985 - ClangRenameTests: Update libdeps. r275958 introduced clangASTMatchers.

Author: chapuni Date: Tue Jul 19 10:33:14 2016 New Revision: 275985 URL: http://llvm.org/viewvc/llvm-project?rev=275985=rev Log: ClangRenameTests: Update libdeps. r275958 introduced clangASTMatchers. Modified: clang-tools-extra/trunk/unittests/clang-rename/CMakeLists.txt Modified:

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

On 7/19/16 8:55 AM, Robinson, Paul wrote: I think we could emulate any pre-commit hook we like via GitHub WebHooks by having two repositories: llvm and llvm-staging (say). People push to llvm-staging, which notifies some LLVM server we own. That does basic sanity checks and pushes to llvm

Re: r275931 - Append clang system include path for offloading tool chains.

Hi Richard,   I posted https://reviews.llvm.org/D22518, is this more or less what you intended?   Thanks, Samuel   - Original message -From: Richard Smith Sent by: meta...@gmail.comTo: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits

Re: [PATCH] D22470: [libcxx] Improve shared_ptr dtor performance

bcraig updated the summary for this revision. bcraig updated this revision to Diff 64504. bcraig added a comment. Added weak_ptr benchmark, as that's where the cost shifted. https://reviews.llvm.org/D22470 Files: benchmarks/shared_ptr_create_destroy.cpp

[PATCH] D22518: Refactor how include paths are appended to the command arguments.

sfantao created this revision. sfantao added reviewers: tra, rsmith. sfantao added subscribers: cfe-commits, rsmith. This patch aims at removing redundancy in the way include paths for the regular and offloading toolchains are appended to the arguments list in the clang tool. This was suggested

Re: [PATCH] D22510: [include-fixer] A refactoring of IncludeFixerContext.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275980: [include-fixer] A refactoring of IncludeFixerContext. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D22510?vs=64481=64502#toc Repository: rL LLVM

Re: [PATCH] D22505: clang-format Access Modifier Use Normal Indent

djasper added a comment. Before we continue with the actual code review and brainstorming how we could actually call this option, can you read through http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options and provide feedback about why this option qualifies?

[clang-tools-extra] r275980 - [include-fixer] A refactoring of IncludeFixerContext.

Author: hokein Date: Tue Jul 19 09:49:04 2016 New Revision: 275980 URL: http://llvm.org/viewvc/llvm-project?rev=275980=rev Log: [include-fixer] A refactoring of IncludeFixerContext. Summary: No functional changes in this patch. It is a refactoring (pull out a structure representing the symbol

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

Anastasia added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2399 @@ +2398,3 @@ + // therefore no need to be translated. + if (getLangOpts().OpenCL && ASTTy->isSamplerT()) +return; Could we lift this check right to the beginning of the

RE: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

> > I think we could emulate any pre-commit hook we like via GitHub > > WebHooks by having two repositories: llvm and llvm-staging (say). > > > > People push to llvm-staging, which notifies some LLVM server we own. > > That does basic sanity checks and pushes to llvm proper if passed. > > I think

  1   2   >