Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

alexshap updated this revision to Diff 68128. alexshap added a comment. Address code review comment https://reviews.llvm.org/D23530 Files: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

[libcxxabi] r278773 - Default LIBCXXABI_LIBDIR_SUFFIX to LLVM_LIBDIR_SUFFIX

Author: ericwf Date: Mon Aug 15 22:44:55 2016 New Revision: 278773 URL: http://llvm.org/viewvc/llvm-project?rev=278773=rev Log: Default LIBCXXABI_LIBDIR_SUFFIX to LLVM_LIBDIR_SUFFIX Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL:

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

faisalv closed this revision. faisalv added a comment. Closed by http://llvm.org/viewvc/llvm-project?view=revision=278771 https://reviews.llvm.org/D23485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r278760 - [clang-rename] cleanup `auto` usages

On Mon, Aug 15, 2016 at 5:20 PM, Kirill Bobyrev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: omtcyfz > Date: Mon Aug 15 18:20:05 2016 > New Revision: 278760 > > URL: http://llvm.org/viewvc/llvm-project?rev=278760=rev > Log: > [clang-rename] cleanup `auto` usages > > As Alexander

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

alexshap added a comment. Yes: "Data, Length, Val" would work as well, i will update this diff https://reviews.llvm.org/D23530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF updated this revision to Diff 68121. EricWF added a comment. Do strict 'constant initializer' checking in C++11, but fall back to `isConstantInitializer()` in C++03. Add documentation about non-strict C++03 checking. This has weird results for POD types, for example: struct PODType {

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap added a comment. Thx, I don't have commit access, need smb to land this patch https://reviews.llvm.org/D23536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

arsenm accepted this revision. arsenm added a reviewer: arsenm. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap added a comment. Test plan: make -j8 check-llvm-unit F2273124: Screen Shot 2016-08-15 at 5.14.59 PM.png F2273127: Screen Shot 2016-08-15 at 5.14.29 PM.png https://reviews.llvm.org/D23536

Re: [PATCH] D20561: Warn when taking address of packed member

On Mon, Aug 15, 2016 at 6:20 PM, Matthias Braun wrote: > MatzeB added a subscriber: MatzeB. > MatzeB added a comment. > > The sanitizer code triggers this warning for code that looks conceptually > like this: > > typedef struct Bla { char bar; int foo; }

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

compnerd added a comment. The `Data` and `Length` fields are tied together. Wouldn't it be possible to reorder this as `Val`, `Length`, `Data` and have it achieve similar sizes and keep the `Data` and `Length` fields together? https://reviews.llvm.org/D23530

Re: r278763 - PR28978: If we need overload resolution for the move constructor of an

Hi Hans, Eric Fiselier requested that we fix this bug for 3.9 (it affects libc++'s std::optional implementation), so this would be a good candidate for the branch. On Mon, Aug 15, 2016 at 5:13 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Aug

[PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap created this revision. alexshap added a reviewer: tstellarAMD. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Herald added subscribers: arsenm, aemerson. The structs ImmOp and

Re: [PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

rsmith added a subscriber: rsmith. rsmith added a comment. Is this really a good idea? If I write: int *_Nullable f(); int n; int *_Nonnull g() { auto *p = f(); if (!p) p = return p; } ... it would be wrong to produce a warning that I'm converting from a nullable pointer

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10519-10520 @@ +10518,4 @@ + auto *CE = dyn_cast(Init); + bool DiagErr = (var->isInitKnownICE() || (CE && CE->getConstructor()->isConstexpr())) + ? !var->checkInitIsICE() : !checkConstInit(); +

Re: [PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

manmanren added a subscriber: manmanren. Comment at: lib/Sema/SemaDecl.cpp:9739 @@ +9738,3 @@ + DeducedType = DeducedType.setNullability( + Init->getType()->getNullability(Context), Context); + Do we propagate other attributes for deduced types?

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added a comment. Ping. https://reviews.llvm.org/D22494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r278763 - PR28978: If we need overload resolution for the move constructor of an

Author: rsmith Date: Mon Aug 15 19:13:47 2016 New Revision: 278763 URL: http://llvm.org/viewvc/llvm-project?rev=278763=rev Log: PR28978: If we need overload resolution for the move constructor of an anonymous union member of a class, we need overload resolution for the move constructor of the

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10519-10520 @@ +10518,4 @@ + auto *CE = dyn_cast(Init); + bool DiagErr = (var->isInitKnownICE() || (CE && CE->getConstructor()->isConstexpr())) + ? !var->checkInitIsICE() : !checkConstInit(); +

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth updated this revision to Diff 68114. amccarth added a comment. Added a test. https://reviews.llvm.org/D23462 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-dllimport-base-class.cpp Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth added a comment. Thank, dblaikie, for correcting my terminology. https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

manmanren added a subscriber: manmanren. manmanren added a comment. The fix looks reasonable to me. Cheers, Manman Comment at: test/CodeGenObjCXX/encode.mm:231 @@ +230,3 @@ +struct S { + typedef T Ty; + Ty *t; I wonder if we can further reduce the testing

Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

andrewmw94 added a comment. I agree that more tests would be good. Where should I put them? Should it be in a separate file or should I just have kmalloc/kfree tests next to the malloc/free ones? https://reviews.llvm.org/D23375 ___ cfe-commits

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

sfantao added a comment. Hi Art, Thanks for the patch! That looks good. https://reviews.llvm.org/D23526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Buildbot numbers for the last week of 8/07/2016 - 8/13/2016

Hello everyone, Below are some buildbot numbers for the last week of 8/07/2016 - 8/13/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 7/31/2016 - 8/06/2016

Hello everyone, Below are some buildbot numbers for the week of 7/31/2016 - 8/06/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

This revision was automatically updated to reflect the committed changes. omtcyfz marked an inline comment as done. Closed by commit rL278760: [clang-rename] cleanup `auto` usages (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23397?vs=68104=68107#toc Repository:

[clang-tools-extra] r278760 - [clang-rename] cleanup `auto` usages

Author: omtcyfz Date: Mon Aug 15 18:20:05 2016 New Revision: 278760 URL: http://llvm.org/viewvc/llvm-project?rev=278760=rev Log: [clang-rename] cleanup `auto` usages As Alexander pointed out, LLVM Coding Standards are more conservative about using auto, i.e. it should be used in the following

[PATCH] D23533: [clang-tidy] Rewrite compilation database test to not require shell

zturner created this revision. zturner added reviewers: alexfh, klimek, djasper. zturner added a subscriber: cfe-commits. This allows the test to run on windows, and also makes writing compilation database tests easier in general. See D23532 for more information.

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:858 @@ +857,3 @@ + }; + SAFE_STATIC T x = {42}; // OK. + SAFE_STATIC T y = 42; // error: variable does not have a constant initializer Sure, if that's a conscious design decision for the

[PATCH] D23532: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner created this revision. zturner added a reviewer: cfe-commits. zturner added subscribers: klimek, alexfh, djasper. Allow explicit specification of a compilation database file and source root. While trying to create a compilation database test for D23455, I ran into the problem that

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

omtcyfz marked 2 inline comments as done. Comment at: clang-rename/USRFinder.cpp:182-184 @@ -179,6 +181,5 @@ // We only want to search the decls that exist in the same file as the point. - auto Decls = Context.getTranslationUnitDecl()->decls(); - for (auto : Decls) { -

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

omtcyfz updated this revision to Diff 68104. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23397 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp clang-rename/USRLocFinder.cpp Index:

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Comment at: clang-rename/USRFinder.cpp:182 @@ -179,5 +181,3 @@ // We only want to search the decls that exist in the same file as the point. -

Re: [PATCH] D23242: [CUDA] Raise an error if a wrong-side call is codegen'ed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278759: [CUDA] Raise an error if a wrong-side call is codegen'ed. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23242?vs=67378=68103#toc Repository: rL LLVM

r278759 - [CUDA] Raise an error if a wrong-side call is codegen'ed.

Author: jlebar Date: Mon Aug 15 18:00:49 2016 New Revision: 278759 URL: http://llvm.org/viewvc/llvm-project?rev=278759=rev Log: [CUDA] Raise an error if a wrong-side call is codegen'ed. Summary: Some function calls in CUDA are allowed to appear in semantically-correct programs but are an error

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

beanz updated this revision to Diff 68102. beanz added a comment. Herald added a subscriber: mehdi_amini. Updating code comment and removing unneeded braces. I'm going to sit on this for a bit before committing in case anyone comes up with a reason this is a bad idea.

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

tra marked 2 inline comments as done. tra added a comment. https://reviews.llvm.org/D23526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

tra updated this revision to Diff 68100. tra added a comment. Addressed comments. https://reviews.llvm.org/D23526 Files: lib/Driver/Driver.cpp test/Driver/cuda-bindings.cu Index: test/Driver/cuda-bindings.cu === --- /dev/null

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

echristo added a subscriber: echristo. echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. LGTM. Might want to fix the braces while you're there. -eric https://reviews.llvm.org/D23531

[PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

beanz created this revision. beanz added reviewers: ddunbar, bob.wilson. beanz added a subscriber: cfe-commits. The eprintf library was added before the general OS X builtins library existed as a place to store one builtin function. Since we have for several years had an actual mandated builtin

Re: [PATCH] D23242: [CUDA] Raise an error if a wrong-side call is codegen'ed.

rnk accepted this revision. rnk added a comment. lgtm Comment at: clang/include/clang/Sema/Sema.h:9162 @@ -9161,1 +9161,3 @@ + /// Check whether we're allowed to call Callee from the current context. + /// FWIW I never insert doxygen annotations. I figure

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

jlebar added a comment. Wow, I have no idea if this is right. I can try to figure it out, but if sfantao can review, that's easier. Comment at: test/Driver/cuda-bindings.cu:10 @@ +9,3 @@ +// way. Instead we check whether we've generated a permanent name on +// device side

Re: [PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

jroelofs added a comment. I'm not sure that's guaranteed behavior either. That being said, I don't see a more robust way to write this test. https://reviews.llvm.org/D23524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. > This is done so containers, such as `vector` can be used > safely provided `partially_available` is safe at the point of instantiation. > I think the way to improve this is in

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv marked an inline comment as done. faisalv added a comment. https://reviews.llvm.org/D23493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv removed rL LLVM as the repository for this revision. faisalv updated this revision to Diff 68091. faisalv added a comment. Updated the patch per Richard's direction (which helped clarify my thinking about this): Check only the current call frame - if the VarDecl is contained within the

Re: [PATCH] D20561: Warn when taking address of packed member

MatzeB added a subscriber: MatzeB. MatzeB added a comment. The sanitizer code triggers this warning for code that looks conceptually like this: typedef struct Bla { char bar; int foo; } __attribute__((packed)); uintptr_t getu(struct Bla *b) { return (uintptr_t)>foo; } Resulting in:

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF marked 7 inline comments as done. Comment at: include/clang/Basic/AttrDocs.td:844 @@ +843,3 @@ +the indeterminate order of dynamic initialization. They can also be safely +used by other static constructors across translation units. + rsmith wrote: > static

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao updated this revision to Diff 68089. sfantao marked an inline comment as done. sfantao added a comment. - Remove redundant return statement. https://reviews.llvm.org/D21851 Files: test/Driver/clang-offload-bundler.c test/Driver/clang-offload-bundler.c.o

[PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

tra created this revision. tra added reviewers: jlebar, sfantao. tra added a subscriber: cfe-commits. If they are, we end up with the last intermediary output preserved in the current directory after compilation. Added a test case to verify that we're using appropriate filenames for outputs of

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao added a comment. Hi Jonas, Thanks for the review! Comment at: test/CMakeLists.txt:27-33 @@ -26,8 +26,9 @@ list(APPEND CLANG_TEST_DEPS clang clang-headers clang-format c-index-test diagtool clang-tblgen + clang-offload-bundler )

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao updated this revision to Diff 68086. sfantao marked 5 inline comments as done. sfantao added a comment. - Fix comments and diagnostics. https://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt

Re: [PATCH] D23453: Add a c2x language mode

rsmith added a comment. This seems premature; according to the charter, we are more than three years away from the C2x committee draft phase. Perhaps we should wait until we have either a new working draft or a paper approved by the WG14 for such a working draft.

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:1384 @@ +1383,3 @@ +def RequireConstantInit : InheritableAttr { + let Spellings = [GCC<"require_constant_initialization">, + CXX11<"clang", "require_constant_initialization">];

RE: r278710 - Replace an obsolete company name.

I had tried doing that in the Users.html page when I first added an entry there, and it caused problems. So, I'd rather not embed a unicode character directly into the file, and I'd rather use a semi-intelligible substitution name than some raw hex value. The intent is clearer. --paulr From:

Re: [PATCH] D23523: [ADT] Change PostOrderIterator to use NodeRef. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278746: [ADT] Change PostOrderIterator to use NodeRef. NFC. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D23523?vs=68070=68082#toc Repository: rL LLVM

r278746 - [ADT] Change PostOrderIterator to use NodeRef. NFC.

Author: timshen Date: Mon Aug 15 16:27:56 2016 New Revision: 278746 URL: http://llvm.org/viewvc/llvm-project?rev=278746=rev Log: [ADT] Change PostOrderIterator to use NodeRef. NFC. Summary: Corresponding LLVM change: D23522 Reviewers: dblaikie Subscribers: cfe-commits Differential Revision:

[libcxx] r278745 - libcxx: Fix path.compare.pass expected result

Author: azanella Date: Mon Aug 15 16:24:50 2016 New Revision: 278745 URL: http://llvm.org/viewvc/llvm-project?rev=278745=rev Log: libcxx: Fix path.compare.pass expected result The expected 'filesystem::path::compare' result states that for different path only result sign contains the information

Re: [PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

ahatanak updated this revision to Diff 68078. ahatanak added a comment. Fix Sema::getTemplateInstantiationArgs to return the template instantiation args when variable templates are being instantiated. https://reviews.llvm.org/D23096 Files: include/clang/Sema/Sema.h

[PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

EricWF created this revision. EricWF added reviewers: danalbert, jroelofs, mclow.lists. EricWF added a subscriber: cfe-commits. The modified assertion fails when the test is compiled at various optimization levels. The value of `nothrow_traced` and `throw_traced` at various optimization levels

r278742 - Objective-C diagnostics: isObjCNSObjectType should check through AttributedType.

Author: mren Date: Mon Aug 15 16:05:00 2016 New Revision: 278742 URL: http://llvm.org/viewvc/llvm-project?rev=278742=rev Log: Objective-C diagnostics: isObjCNSObjectType should check through AttributedType. For the following example: typedef __attribute__((NSObject)) CGColorRef ColorAttrRef;

[libcxx] r278736 - Fix new ASAN failures

Author: ericwf Date: Mon Aug 15 15:50:01 2016 New Revision: 278736 URL: http://llvm.org/viewvc/llvm-project?rev=278736=rev Log: Fix new ASAN failures Modified: libcxx/trunk/test/libcxx/containers/sequences/vector/asan.pass.cpp

Re: [PATCH] D23241: Add the notion of deferred diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278735: Add the notion of deferred diagnostics. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23241?vs=68063=68073#toc Repository: rL LLVM https://reviews.llvm.org/D23241

Re: [PATCH] D23341: [CUDA] Include CUDA headers before anything else.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278734: [CUDA] Include CUDA headers before anything else. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23341?vs=67439=68072#toc Repository: rL LLVM

Re: [PATCH] D23340: [CUDA] Fix CUDA install version parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278733: [CUDA] Fix CUDA install version parsing. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23340?vs=67438=68071#toc Repository: rL LLVM

r278734 - [CUDA] Include CUDA headers before anything else.

Author: jlebar Date: Mon Aug 15 15:38:52 2016 New Revision: 278734 URL: http://llvm.org/viewvc/llvm-project?rev=278734=rev Log: [CUDA] Include CUDA headers before anything else. Summary: There's no point to --cuda-path if we then go and include /usr/include first. And if you install the right

r278735 - Add the notion of deferred diagnostics.

Author: jlebar Date: Mon Aug 15 15:38:56 2016 New Revision: 278735 URL: http://llvm.org/viewvc/llvm-project?rev=278735=rev Log: Add the notion of deferred diagnostics. Summary: This patch lets you create diagnostics that are emitted if and only if a particular FunctionDecl is codegen'ed. This

r278733 - [CUDA] Fix CUDA install version parsing.

Author: jlebar Date: Mon Aug 15 15:38:48 2016 New Revision: 278733 URL: http://llvm.org/viewvc/llvm-project?rev=278733=rev Log: [CUDA] Fix CUDA install version parsing. Summary: getAsInteger returns true on error. Oops. No test because the behavior at the moment is identical with or without

[PATCH] D23523: [ADT] Change PostOrderIterator to use NodeRef. NFC.

timshen created this revision. timshen added a reviewer: dblaikie. timshen added a subscriber: cfe-commits. Corresponding LLVM change: D23522 https://reviews.llvm.org/D23523 Files: include/clang/Analysis/CFG.h include/clang/Analysis/CallGraph.h Index: include/clang/Analysis/CallGraph.h

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

compnerd closed this revision. compnerd added a comment. SVN r278730 https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r278730 - StaticAnalyzer: Report found fields order in PaddingChecker

Author: compnerd Date: Mon Aug 15 15:16:13 2016 New Revision: 278730 URL: http://llvm.org/viewvc/llvm-project?rev=278730=rev Log: StaticAnalyzer: Report found fields order in PaddingChecker Report the found fields order in PaddingChecker. Patch by Alexander Shaposhnikov! Modified:

Re: r278655 - [CodeGen] Correctly implement the AVX512 psABI rules

LGTM. But it would be great if someone with more exposure to CFE could double check. -Gerolf > On Aug 14, 2016, at 11:39 PM, David Majnemer via cfe-commits > wrote: > > Author: majnemer > Date: Mon Aug 15 01:39:18 2016 > New Revision: 278655 > > URL:

r278729 - [CMake] Apple stage1 doesn't need to set libcxx options

Author: cbieneman Date: Mon Aug 15 15:15:22 2016 New Revision: 278729 URL: http://llvm.org/viewvc/llvm-project?rev=278729=rev Log: [CMake] Apple stage1 doesn't need to set libcxx options LibCXX settings are configured in stage2 so we don't need them here. Modified:

Re: [PATCH] D23241: Add the notion of deferred diagnostics.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:4791-4802 @@ -4790,1 +4790,14 @@ +CallStackFrame *getNearestContainingCallFrame(CallStackFrame *CurFrame, + const VarDecl *VD) { + if (auto *FD = +

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

hans added a comment. Faisal: go ahead and commit directly to the branch, or let me know if you'd like me to do it. https://reviews.llvm.org/D23485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r278710 - Replace an obsolete company name.

You may also want to just try using the unicode character (not that it really matters that much though). On Mon, Aug 15, 2016 at 11:45 AM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: probinson > Date: Mon Aug 15 13:45:52 2016 > New Revision: 278710 > > URL:

Re: [PATCH] D23241: Add the notion of deferred diagnostics.

jlebar updated this revision to Diff 68063. jlebar added a comment. Move deferred diags storage into ASTContext. https://reviews.llvm.org/D23241 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/CodeGen/CodeGenModule.cpp

[libcxx] r278722 - Use -O1 when testing with ASAN and MSAN to prevent Clang OOM errors.

Author: ericwf Date: Mon Aug 15 14:37:20 2016 New Revision: 278722 URL: http://llvm.org/viewvc/llvm-project?rev=278722=rev Log: Use -O1 when testing with ASAN and MSAN to prevent Clang OOM errors. Currently certain tests get killed when compiled with ASAN at -O0 because they eat all of the

Re: [clang-tools-extra] r278295 - [Documentation] Improve consistency.

Hi, Miklos! Sorry, I was not aware about documentation source. But I think will be good idea to improve punctuation consistency in tool itself. Eugene. On Mon, Aug 15, 2016 at 12:24 PM, Miklos Vajna wrote: > Hi Eugene, > > On Wed, Aug 10, 2016 at 10:00:50PM -, Eugene

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

yaxunl added a comment. In https://reviews.llvm.org/D23086#515506, @Anastasia wrote: > > Surely vendors can re-implement all OpenCL types with an implicit typedef. > For example this would just work: > > typedef int queue_t; > void bar(queue_t q); > > > I am afraid we will

Re: [clang-tools-extra] r278295 - [Documentation] Improve consistency.

Hi Eugene, On Wed, Aug 10, 2016 at 10:00:50PM -, Eugene Zelenko via cfe-commits wrote: > Modified: clang-tools-extra/trunk/docs/clang-rename.rst > URL: >

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

EricWF closed this revision. EricWF added a comment. r278716. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r278716 - Fix PR28506. Re-enable missing math.h C++11 decls on SunOS. Patch from Michal Gorny.

Author: ericwf Date: Mon Aug 15 13:58:57 2016 New Revision: 278716 URL: http://llvm.org/viewvc/llvm-project?rev=278716=rev Log: Fix PR28506. Re-enable missing math.h C++11 decls on SunOS. Patch from Michal Gorny. Modified: libcxx/trunk/include/cmath libcxx/trunk/include/math.h

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

EricWF accepted this revision. EricWF added a comment. Also LGTM. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r278710 - Replace an obsolete company name.

Author: probinson Date: Mon Aug 15 13:45:52 2016 New Revision: 278710 URL: http://llvm.org/viewvc/llvm-project?rev=278710=rev Log: Replace an obsolete company name. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

rnk added a comment. In https://reviews.llvm.org/D23455#515486, @brad.king wrote: > > the feasibility of emitting 'arguments' instead of 'command' into the JSON > > compilation database. > > > CMake constructs the command lines internally using string replacement on > templates. We never

Re: [PATCH] D23492: Make function local tags visible.

rsmith added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1546-1548 @@ -1545,5 +1549,5 @@ // definition of it, because parameters aren't "within" the definition. if ((D->isTemplateParameter() || isa(D)) ? isVisible(SemaRef, cast(DC)) :

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added a comment. i don't have commit access, if you could land this patch i would be grateful https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added a comment. In https://reviews.llvm.org/D23086#515468, @yaxunl wrote: > In https://reviews.llvm.org/D23086#515443, @Anastasia wrote: > > > In https://reviews.llvm.org/D23086#514279, @yaxunl wrote: > > > > > How about we decide if a type is ndrange_t type based on their canonical

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

bcraig added a comment. LGTM Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217 @@ +216,3 @@ +// then large field indices to small field indices +return std::make_tuple(Align, -Size, + Field ?

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

brad.king added a comment. > the feasibility of emitting 'arguments' instead of 'command' into the JSON > compilation database. CMake constructs the command lines internally using string replacement on templates. We never actually know the exact arguments. Therefore providing arguments

[clang-tools-extra] r278686 - [Documentation] Improve checks groups descriptions in clang-tidy/index.rst

Author: eugenezelenko Date: Mon Aug 15 12:44:29 2016 New Revision: 278686 URL: http://llvm.org/viewvc/llvm-project?rev=278686=rev Log: [Documentation] Improve checks groups descriptions in clang-tidy/index.rst Use table to avoid tautology. List all existing checks groups. Use alphabetical

Re: [PATCH] D23471: [Documentation] Improve checks groups descriptions in clang-tidy/index.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL278686: [Documentation] Improve checks groups descriptions in clang-tidy/index.rst (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23471?vs=67926=68050#toc Repository:

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

yaxunl added a comment. In https://reviews.llvm.org/D23086#515443, @Anastasia wrote: > In https://reviews.llvm.org/D23086#514279, @yaxunl wrote: > > > How about we decide if a type is ndrange_t type based on their canonical > > types. If the canonical type of type X is the same as the canonical

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap marked 2 inline comments as done. alexshap added a comment. ping https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23293: Some place that could using TargetParser in clang

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. More trivial changes. LGTM. Thanks! https://reviews.llvm.org/D23293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added a comment. In https://reviews.llvm.org/D23086#514279, @yaxunl wrote: > How about we decide if a type is ndrange_t type based on their canonical > types. If the canonical type of type X is the same as the canonical type of > ndrange_t type, then type X is treated as ndrange_t

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. Ping. https://reviews.llvm.org/D23420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >