Re: [PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags

mgorny added a comment. In https://reviews.llvm.org/D24809#553415, @EricWF wrote: > > Stop stripping -m32 from the user-supplied flags. There is no valid reason > > to do that, stripping it silently is thoroughly confusing and makes it > > impossible to do distribution multi-ABI builds without

Re: [PATCH] D24601: XFAIL Driver/darwin-stdlib.cpp if CLANG_DEFAULT_CXX_STDLIB is set

vsk added a subscriber: vsk. vsk added a comment. It should be fine to XFAIL this test temporarily. Is there a PR for this? https://reviews.llvm.org/D24601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka added a comment. My assumption is that "start" makes access valid, and "end" makes access invalid, up to the next "start". I see no problems problems with loops and multiple regions, as soon as access is happening between start and end. Loops always call "start" for nested alloca on

Re: [PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

mclow.lists accepted this revision. mclow.lists added a comment. I guess this is OK. I'd rather not have naked `_WIN32` references outside of <__config>, but this is not the first one. https://reviews.llvm.org/D14259 ___ cfe-commits mailing list

Re: [PATCH] D24945: [libc++abi] Default to DLL annotations on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL282470: [libc++abi] Default to DLL annotations on Windows (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24945?vs=72598=72599#toc Repository: rL LLVM

[libcxxabi] r282470 - [libc++abi] Default to DLL annotations on Windows

Author: smeenai Date: Mon Sep 26 22:44:09 2016 New Revision: 282470 URL: http://llvm.org/viewvc/llvm-project?rev=282470=rev Log: [libc++abi] Default to DLL annotations on Windows `__declspec(dllexport)` and `__declspec(dllimport)` should only be used when building libc++abi as a DLL, but that's

Re: [PATCH] D24945: [libc++abi] Default to DLL annotations on Windows

smeenai updated this revision to Diff 72598. smeenai added a comment. Addressing @EricWF's comment https://reviews.llvm.org/D24945 Files: CMakeLists.txt include/__cxxabi_config.h Index: include/__cxxabi_config.h === ---

Re: [PATCH] D24945: [libc++abi] Default to DLL annotations on Windows

smeenai marked an inline comment as done. smeenai added a comment. https://reviews.llvm.org/D24945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

dcoughlin accepted this revision. dcoughlin added a comment. LGTM. https://reviews.llvm.org/D23236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r282468 - Fix possible division by zero

Author: ericwf Date: Mon Sep 26 21:13:27 2016 New Revision: 282468 URL: http://llvm.org/viewvc/llvm-project?rev=282468=rev Log: Fix possible division by zero Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp

Re: [PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. https://reviews.llvm.org/D24119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags

EricWF added a comment. > Stop stripping -m32 from the user-supplied flags. There is no valid reason to > do that, stripping it silently is thoroughly confusing and makes it > impossible to do distribution multi-ABI builds without resorting to ugly > hacks. The reason for stripping it is

Re: [PATCH] D13280: [OpenCL] Adding reserved operator logical xor for OpenCL

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL259651. https://reviews.llvm.org/D13280 ___ cfe-commits mailing list

Re: [PATCH] D13349: [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL249301. https://reviews.llvm.org/D13349 ___ cfe-commits mailing list

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

rsmith added a comment. Before we start with heroics here, we should consider whether the LLVM intrinsics are actually specified the right way. The current specification does the wrong thing for even trivial cases, such as a variable declared within a loop, so there's some impedance mismatch

Re: [PATCH] D24945: [libc++abi] Default to DLL annotations on Windows

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing inline comments. Unfortunately libc++abi doesn't have a way to make `_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT` persistent, but this solution works for now.

Re: [PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D13419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r282466 - Remove out of date items in TODO.txt

Author: ericwf Date: Mon Sep 26 20:28:47 2016 New Revision: 282466 URL: http://llvm.org/viewvc/llvm-project?rev=282466=rev Log: Remove out of date items in TODO.txt Modified: libcxx/trunk/TODO.TXT Modified: libcxx/trunk/TODO.TXT URL:

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

ahatanak added a comment. This looks fine to me. https://reviews.llvm.org/D23236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r282453 - P0145R3 (C++17 evaluation order tweaks): consistently emit the LHS of array

On Mon, Sep 26, 2016 at 5:57 PM, Kostya Serebryany via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Looks like yours: > > FAILED: tools/clang/lib/CodeGen/CMakeFiles/clangCodeGen.dir/CGExpr.cpp.obj > C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~1\cl.exe /nologo /TP > -DCLANG_ENABLE_ARCMT

r282464 - Remove default argument from lambda to appease old MSVC.

Author: rsmith Date: Mon Sep 26 19:53:24 2016 New Revision: 282464 URL: http://llvm.org/viewvc/llvm-project?rev=282464=rev Log: Remove default argument from lambda to appease old MSVC. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp URL:

r282463 - Defend test against differences between 32-bit and 64-bit MSABI manglings.

Author: rsmith Date: Mon Sep 26 19:52:29 2016 New Revision: 282463 URL: http://llvm.org/viewvc/llvm-project?rev=282463=rev Log: Defend test against differences between 32-bit and 64-bit MSABI manglings. Modified: cfe/trunk/test/CodeGenCXX/cxx1z-eval-order.cpp Modified:

Re: r282453 - P0145R3 (C++17 evaluation order tweaks): consistently emit the LHS of array

Looks like yours: FAILED: tools/clang/lib/CodeGen/CMakeFiles/clangCodeGen.dir/CGExpr.cpp.obj C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~1\cl.exe /nologo /TP -DCLANG_ENABLE_ARCMT -DCLANG_ENABLE_OBJC_REWRITER -DCLANG_ENABLE_STATIC_ANALYZER -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE

Re: [PATCH] D24820: Add -stats-stats option

aprantl added a comment. Awesome. Sorry! Repository: rL LLVM https://reviews.llvm.org/D24820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13813: Teach MyriadToolchain how to find its C++ header paths.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL250536. https://reviews.llvm.org/D13813 ___ cfe-commits mailing list

Re: [PATCH] D13891: Apply modernize-use-default to llvm.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D13891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r282457 - P0145R3 (C++17 evaluation order tweaks): evaluate the base expression before

Author: rsmith Date: Mon Sep 26 18:56:57 2016 New Revision: 282457 URL: http://llvm.org/viewvc/llvm-project?rev=282457=rev Log: P0145R3 (C++17 evaluation order tweaks): evaluate the base expression before the pointer-to-member expression in calls through .* and ->* expressions. Modified:

[PATCH] D24946: [CUDA] Added support for CUDA-8

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. Herald added a subscriber: jlebar. https://reviews.llvm.org/D24946 Files: lib/Driver/ToolChains.cpp lib/Headers/__clang_cuda_runtime_wrapper.h

r282453 - P0145R3 (C++17 evaluation order tweaks): consistently emit the LHS of array

Author: rsmith Date: Mon Sep 26 18:49:47 2016 New Revision: 282453 URL: http://llvm.org/viewvc/llvm-project?rev=282453=rev Log: P0145R3 (C++17 evaluation order tweaks): consistently emit the LHS of array subscripting before the RHS, regardless of which is the base and which is the index. Added:

[PATCH] D24945: [libc++abi] Default to DLL annotations on Windows

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. `__declspec(dllexport)` and `__declspec(dllimport)` should only be used when building libc++abi as a DLL, but that's the more

Re: [PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D14259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14353: Allow use of private headers in different sub-modules.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL252170. https://reviews.llvm.org/D14353 ___ cfe-commits mailing list

[PATCH] D24944: [CUDA] Added __nvvm_atom_{sys|cta}_* builtins for sm_60 GPUs.

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. Herald added subscribers: jlebar, jholewinski. https://reviews.llvm.org/D24944 Files: include/clang/Basic/BuiltinsNVPTX.def lib/Basic/Targets.cpp lib/CodeGen/CGBuiltin.cpp

[libcxx] r282446 - [libc++] Fix typos causing compilation errors when _LIBCPP_DEBUG_LEVEL >= 2

Author: oleg Date: Mon Sep 26 16:39:38 2016 New Revision: 282446 URL: http://llvm.org/viewvc/llvm-project?rev=282446=rev Log: [libc++] Fix typos causing compilation errors when _LIBCPP_DEBUG_LEVEL >= 2 Summary: This patch fixes a couple of typos that cause compilation errors when application

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

EricWF added a comment. LGTM other than the inline comments. I'll give it a final once over tonight or tomorrow. Comment at: include/__cxxabi_config.h:36 @@ -35,1 +35,3 @@ #endif + #if defined(_MSC_VER) && !defined(__clang__) + // Using Microsoft Visual C++ compiler

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

loladiro updated this revision to Diff 72581. loladiro added a comment. back to _VSTD::forward, address review comments, add tests for non-empty deleter and unique_ptrs of arrays. Repository: rL LLVM https://reviews.llvm.org/D24372 Files: include/memory

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/RenamingAction.cpp:73 @@ -73,1 +72,3 @@ llvm::Error Err = FileToReplaces[Replace.getFilePath()].add(Replace); + // FIXME: As for clang-rename,

Re: [PATCH] D24877: [libc++] Default to DLL semantics on Windows

smeenai abandoned this revision. smeenai added a comment. Your patch looks good to me and is a nicer way of accomplishing this. Thanks for taking care of it! https://reviews.llvm.org/D24877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

compnerd closed this revision. compnerd added a comment. r282447 https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24877: [libc++] Default to DLL semantics on Windows

EricWF resigned from this revision. EricWF removed a reviewer: EricWF. EricWF added a comment. I fixed this with a slightly different patch in r282449. I hope you don't mind that I didn't use this patch, I just wanted to add support for generating custom __config headers for static builds on

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

djasper closed this revision. djasper added a comment. Committed as r282448. https://reviews.llvm.org/D15643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r282449 - Expect DLL builds on Windows by default and require a custom __config for static

Author: ericwf Date: Mon Sep 26 17:19:41 2016 New Revision: 282449 URL: http://llvm.org/viewvc/llvm-project?rev=282449=rev Log: Expect DLL builds on Windows by default and require a custom __config for static builds. On Windows the __declspec(dllimport) and __declspec(dllexport) attributes

r282448 - [clang-format] Don't allow newline after uppercase Obj-C block return types

Author: djasper Date: Mon Sep 26 17:19:08 2016 New Revision: 282448 URL: http://llvm.org/viewvc/llvm-project?rev=282448=rev Log: [clang-format] Don't allow newline after uppercase Obj-C block return types Fixes the following: BOOL (^aaa)(void) = ^BOOL { }; The first BOOL's token was getting

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

ksuther updated this revision to Diff 72578. ksuther added a comment. Added a unit test. https://reviews.llvm.org/D15643 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

r282447 - headers: add missing Windows ARM Interlocked intrinsics

Author: compnerd Date: Mon Sep 26 17:12:43 2016 New Revision: 282447 URL: http://llvm.org/viewvc/llvm-project?rev=282447=rev Log: headers: add missing Windows ARM Interlocked intrinsics On ARM, there are multiple versions of each of the intrinsics, with acquire/relaxed/release barrier semantics.

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

djasper added a comment. Ah, sorry for dropping this on the floor :(. May I nonetheless ask you to add a test (unittests/Format/FormatTest.cpp)? https://reviews.llvm.org/D15643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D15643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15691: [OpenCL] Improving OpenCL function pointer error checking to catch lone function designator

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL256838. https://reviews.llvm.org/D15691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15994: Allow for unfinished #if blocks in preambles.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D15994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r282443 - [Modules TS] Diagnose 'export' declaration within 'export' declaration.

Author: rsmith Date: Mon Sep 26 16:27:23 2016 New Revision: 282443 URL: http://llvm.org/viewvc/llvm-project?rev=282443=rev Log: [Modules TS] Diagnose 'export' declaration within 'export' declaration. Modified: cfe/trunk/include/clang/AST/DeclBase.h

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

andriigrynenko updated this revision to Diff 72571. andriigrynenko added a comment. Do CHECKs for all iterations of the loop. https://reviews.llvm.org/D24628 Files: include/sanitizer/common_interface_defs.h lib/asan/asan_thread.cc lib/asan/asan_thread.h

Re: [PATCH] D16262: [libc++] Treat trailing backslashes in a regex pattern as invalid.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r258107. https://reviews.llvm.org/D16262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Was committed in r260265, but reverted in r260536. https://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16951: [MS ABI] dllimport'd class cannot have constexpr ctors

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D16951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Eugene.Zelenko added a comment. It's fine. I just walk through all accepted revisions to find forgotten ones. https://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r282439 - [libc++] Extension: Make `move` and `forward` constexpr in C++11.

Author: ericwf Date: Mon Sep 26 15:55:02 2016 New Revision: 282439 URL: http://llvm.org/viewvc/llvm-project?rev=282439=rev Log: [libc++] Extension: Make `move` and `forward` constexpr in C++11. Summary: `std::move` and `std::forward` were not marked constexpr in C++11. This can be very

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

EricWF added a comment. FYI `std::move` and `std::forward` are now constexpr in C++11. There is no need to use `__forward`. Repository: rL LLVM https://reviews.llvm.org/D24372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing the inline comments. Comment at: src/fallback_malloc.cpp:58 @@ +57,3 @@ + +#define HEAP_SIZE 512 +char heap [ HEAP_SIZE ]; A static

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Correct. I haven't had a chance to get back to this. I'm aiming to pick it up again in the next week or two, but if this is specifically blocking you, feel free to rebase and commit on my behalf. > On 2016-Sep-26, at 13:39, Eugene Zelenko wrote: > > Eugene.Zelenko

r282438 - Fix test on windows

Author: matze Date: Mon Sep 26 15:48:34 2016 New Revision: 282438 URL: http://llvm.org/viewvc/llvm-project?rev=282438=rev Log: Fix test on windows Modified: cfe/trunk/test/Driver/save-stats.c Modified: cfe/trunk/test/Driver/save-stats.c URL:

Re: [PATCH] D24820: Add -stats-stats option

MatzeB added inline comments. Comment at: test/Driver/save-stats.c:12 @@ +11,3 @@ +// RUN: %clang -target x86_64-apple-darwin -save-stats=obj -c -o obj/dir/save-stats.o %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OBJ +// CHECK-OBJ:

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 72554. rSerge added a comment. Implemented a workaround for XFAIL not differentiating between `x86` and `x86_64` because it searches for a substring in the triple string, thus `x86` matches both `x86-X-Y-Z` and `x86_64-X-Y-Z`.

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

andriigrynenko added inline comments. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199 @@ -164,7 +175,26 @@ ret += Run(argc - 1, 0, stack); +// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]] +// CHECK: Main context from: [[CHILD_STACK]] 524288

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

This revision was automatically updated to reflect the committed changes. Closed by commit rL282435: [include] Declare __STDC_*_MACROS for C++11 compat in old libc (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D24903?vs=72492=72552#toc Repository: rL LLVM

[libcxx] r282435 - [include] Declare __STDC_*_MACROS for C++11 compat in old libc

Author: mgorny Date: Mon Sep 26 15:20:00 2016 New Revision: 282435 URL: http://llvm.org/viewvc/llvm-project?rev=282435=rev Log: [include] Declare __STDC_*_MACROS for C++11 compat in old libc Declare __STDC_FORMAT_MACROS, __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS before including real

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

mgorny added a comment. Ok. Thanks for the review. https://reviews.llvm.org/D24903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D17840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D17890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17979: [OPENMP] Add regression test for codegen of distribute pragma for NVPTX

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D17979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Please remove the `LIBCXX` macros before committing. Comment at: include/stdint.h:118 @@ +117,3 @@ +# define __STDC_CONSTANT_MACROS +# define

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

aaron.ballman added a comment. In https://reviews.llvm.org/D24886#552859, @rsmith wrote: > Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This > attribute is specified by the C++ core guidelines, not by clang, and > presumably we want code using this attribute to be portable

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

rsmith added a comment. Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This attribute is specified by the C++ core guidelines, not by clang, and presumably we want code using this attribute to be portable across implementations of the C++ code guidelines. I'd suggest asking

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added a comment. Ping, can someone commit this one now? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24932: Fix PR 30440

DmitryPolukhin added a comment. LGTM, added Richard in case he has something to add. Repository: rL LLVM https://reviews.llvm.org/D24932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24933: Enable configuration files in clang

ddunbar added a comment. I am too out of the loop on Clang development to be able to comment on the specific direction, but I will just say that I am highly in favor of adding new features in this direction. Thank you! https://reviews.llvm.org/D24933

Re: r282426 - CC1: Add -save-stats option

Nice! -Hal - Original Message - > From: "Matthias Braun via cfe-commits" > To: cfe-commits@lists.llvm.org > Sent: Monday, September 26, 2016 1:53:34 PM > Subject: r282426 - CC1: Add -save-stats option > > Author: matze > Date: Mon Sep 26 13:53:34 2016 > New

Re: [PATCH] D24820: Add -stats-stats option

This revision was automatically updated to reflect the committed changes. Closed by commit rL282426: CC1: Add -save-stats option (authored by matze). Changed prior to commit: https://reviews.llvm.org/D24820?vs=72376=72532#toc Repository: rL LLVM https://reviews.llvm.org/D24820 Files:

r282426 - CC1: Add -save-stats option

Author: matze Date: Mon Sep 26 13:53:34 2016 New Revision: 282426 URL: http://llvm.org/viewvc/llvm-project?rev=282426=rev Log: CC1: Add -save-stats option This option behaves in a similar spirit as -save-temps and writes internal llvm statistics in json format to a file. Differential Revision:

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

v.g.vassilev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:102 @@ -95,5 +101,3 @@ // as a note. -DiagEngine.Report(Group.Sequences.front().getStartLoc(), WarnID); -for (unsigned i = 1; i < Group.Sequences.size(); ++i) { -

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

compnerd added inline comments. Comment at: src/config.h:41 @@ +40,3 @@ +defined(__CloudABI__) || \ +defined(__sun__) +# define _LIBCXXABI_HAS_THREAD_API_PTHREAD Can you change this to `defined(__sun__) && defined(_POSIX_THREADS)` at the very least?

Re: [PATCH] D24862: Workaround ASTMatcher crashes. Added some more test cases.

hokein accepted this revision. hokein added a comment. LGTM. https://reviews.llvm.org/D24862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24933: Enable configuration files in clang

sepavloff created this revision. sepavloff added reviewers: rnk, ddunbar. sepavloff added a subscriber: cfe-commits. The implementation follows the discussion in mail list (http://lists.llvm.org/pipermail/cfe-dev/2016-September/050776.html). Main part of the config file support is implemented in

[PATCH] D24932: Fix PR 30440

arphaman created this revision. arphaman added a reviewer: DmitryPolukhin. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth in the two constructors added in r274222

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

NoQ updated this revision to Diff 72521. NoQ added a comment. Addressed inline comments on the original review https://reviews.llvm.org/D24278. Rebased on top of the updated https://reviews.llvm.org/D24278. Changed warning messages completely according to Anna's comments in

Re: [PATCH] D24813: Driver: Add a test for triple with opencl environment

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D24813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24915: [analyzer] Extend bug reports with extra notes - ObjCDeallocChecker

NoQ updated this revision to Diff 72520. NoQ added a comment. Addressed two inline comments by Devin in the original review https://reviews.llvm.org/D24278. Rebased on top of the updated https://reviews.llvm.org/D24278. https://reviews.llvm.org/D24915 Files:

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

NoQ updated this revision to Diff 72519. NoQ marked 10 inline comments as done. NoQ added a comment. Addressed inline comments. Renamed extra notes to notes. https://reviews.llvm.org/D24278 Files: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h

Re: [PATCH] D24874: Fully implement the matcher for CXXCtorInitializer

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! Commit in r282417 https://reviews.llvm.org/D24874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r282417 - Complete support for the cxxCtorInitializer() AST matcher so that it can be used as a top-level matcher.

Author: aaronballman Date: Mon Sep 26 12:04:27 2016 New Revision: 282417 URL: http://llvm.org/viewvc/llvm-project?rev=282417=rev Log: Complete support for the cxxCtorInitializer() AST matcher so that it can be used as a top-level matcher. Modified:

Re: [PATCH] D24928: [ASTMatcher] Clarify isStaticStorageClass and hasStaticStorageDuration documents.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the clarifications! Comment at: include/clang/ASTMatchers/ASTMatchers.h:3395 @@ -3392,1 +3394,3 @@ +/// \brief Matches variable/function

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticGroups.td:522 @@ -521,2 +521,3 @@ def GNUZeroVariadicMacroArguments : DiagGroup<"gnu-zero-variadic-macro-arguments">; +def GNUVecElemSize : DiagGroup<"gnu-vec-elem-size">; def Fallback

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

omtcyfz added a comment. @arphaman, thank you for the comments! Improved the wording. https://reviews.llvm.org/D24914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

omtcyfz updated this revision to Diff 72511. omtcyfz marked 2 inline comments as done. omtcyfz added a comment. Address two comments. https://reviews.llvm.org/D24914 Files: clang-rename/RenamingAction.cpp Index: clang-rename/RenamingAction.cpp

[PATCH] D24928: [ASTMatcher] Clarify isStaticStorageClass and hasStaticStorageDuration documents.

hokein created this revision. hokein added a reviewer: aaron.ballman. hokein added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D24928 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D24821: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

hokein added inline comments. Comment at: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h:3391 @@ +3390,3 @@ +/// \brief Matches variable/function declarations that have static storage class +/// (with "static" key word) written in the source. +///

Re: [PATCH] D24820: Add -stats-stats option

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks Matthias LGTM! Repository: rL LLVM https://reviews.llvm.org/D24820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24821: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

aaron.ballman added a subscriber: aaron.ballman. Comment at: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h:3391 @@ +3390,3 @@ +/// \brief Matches variable/function declarations that have static storage class +/// (with "static" key word) written in the source. +///

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

arphaman added a subscriber: arphaman. Comment at: clang-rename/RenamingAction.cpp:75 @@ +74,3 @@ + // has been matched multiple times (which shouldn't happen in reality, + // need to fix that) or when it's a specific header. For now, just ingore + // there error

r282415 - [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

Author: hokein Date: Mon Sep 26 11:01:52 2016 New Revision: 282415 URL: http://llvm.org/viewvc/llvm-project?rev=282415=rev Log: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl. Reviewers: klimek Subscribers: cfe-commits, klimek Differential Revision:

  1   2   >