Author: ericwf
Date: Wed Oct 12 01:48:31 2016
New Revision: 283978
URL: http://llvm.org/viewvc/llvm-project?rev=283978&view=rev
Log:
Revert Add . Will recommit with better commit message
Removed:
libcxx/trunk/include/optional
libcxx/trunk/test/libcxx/utilities/optional/
libcxx/trunk/t
ahatanak marked an inline comment as done.
ahatanak added a comment.
(I'm replying to the comment near TreeTransform.h:11967 because phab doesn't
let me hit save)
It looks like RebuildCXXPseudoDestructorExpr isn't even called because a
MemberExpr is created instead of a CXXPseudoDestructorExpr.
ahatanak updated this revision to Diff 74324.
ahatanak added a comment.
Added a call to operator C1* in test case.
https://reviews.llvm.org/D24969
Files:
lib/Sema/SemaTemplateInstantiateDecl.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/destructor.cpp
Index: test/SemaCXX/destructor.cpp
Author: ericwf
Date: Tue Oct 11 23:56:23 2016
New Revision: 283976
URL: http://llvm.org/viewvc/llvm-project?rev=283976&view=rev
Log:
Fix two more tests that hang when testing against libstdc++
Modified:
libcxx/trunk/test/std/utilities/intseq/intseq.make/make_integer_seq.fail.cpp
libcxx/t
EricWF added inline comments.
Comment at: CMakeLists.txt:327
# Required flags ==
set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build
dialect")
add_compile_flags_if_supported(-std=${LIBCXX_ST
Author: ericwf
Date: Tue Oct 11 23:29:50 2016
New Revision: 283975
URL: http://llvm.org/viewvc/llvm-project?rev=283975&view=rev
Log:
Prevent the test suite from hanging when run against libstdc++
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/std/thread/thread.mutex/
phosek added inline comments.
Comment at: CMakeLists.txt:327
# Required flags ==
set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build
dialect")
add_compile_flags_if_supported(-std=${LIBCXX_ST
Yes, I have yet to figure out when that REQUIRES comment is, erm,
required. Sorry. :-/
I believe Art checked in a fix.
On Oct 11, 2016 7:22 PM, "Chandler Carruth" wrote:
> On Tue, Oct 11, 2016 at 6:39 PM Justin Lebar via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: jlebar
>
On Tue, Oct 11, 2016 at 6:39 PM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jlebar
>
> Date: Tue Oct 11 20:30:08 2016
>
> New Revision: 283963
>
>
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283963&view=rev
>
> Log:
>
> [CUDA] Make touching a kernel from a __ho
EricWF added a comment.
> musl's pthread implementations use volatile types in their structs which is
> not being constexpr in C++11 but is in C++14.
This means that libc++'s std::mutex is unsafe to use during dynamic
initialization in C++11 with MUSL, which would really suck except that Clang
Author: tra
Date: Tue Oct 11 21:08:08 2016
New Revision: 283964
URL: http://llvm.org/viewvc/llvm-project?rev=283964&view=rev
Log:
Added REQUIRED triples to the test that fails on some ARM buildbots.
Modified:
cfe/trunk/test/SemaCUDA/function-overload-hd.cu
Modified: cfe/trunk/test/SemaCUDA/f
Author: jlebar
Date: Tue Oct 11 20:30:08 2016
New Revision: 283963
URL: http://llvm.org/viewvc/llvm-project?rev=283963&view=rev
Log:
[CUDA] Make touching a kernel from a __host__ __device__ function a deferred
error.
Previously, this was an immediate, don't pass go, don't collect $200
error. Bu
agutowski added inline comments.
Comment at: test/Sema/builtins-x86_64.c:17
+ v8ll vec8longlongs;
+ (void)__builtin_ia32_readeflags_u64(); //
expected-error{{use of unknown builtin}} expected-note 0+ {{}}
+ (void)__builtin_ia32_writeeflags_u64(4);
agutowski created this revision.
agutowski added reviewers: rnk, hans, thakis.
agutowski added a subscriber: cfe-commits.
Follow-up to https://reviews.llvm.org/D24598 (separating builtins for x84-64
and i386).
https://reviews.llvm.org/D25494
Files:
include/clang/Basic/BuiltinsX86.def
inclu
Author: ericwf
Date: Tue Oct 11 20:19:16 2016
New Revision: 283962
URL: http://llvm.org/viewvc/llvm-project?rev=283962&view=rev
Log:
Fix libc++abi test config after recent libc++ changes
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
Modified: libcxxabi/trunk/test/libcxxabi/test/con
Author: ericwf
Date: Tue Oct 11 19:28:14 2016
New Revision: 283960
URL: http://llvm.org/viewvc/llvm-project?rev=283960&view=rev
Log:
Add mork workarounds for running the test suite against libstdc++
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/lit.cfg
libcxx/tru
tavianator added a comment.
In https://reviews.llvm.org/D21803#556857, @EricWF wrote:
> @rmaprath I'll merge this if needed. Feel free to commit your patch first.
Yeah, @rmaprath I'm happy to rebase this over your patch.
> @tavianator Do you need somebody to merge this for you?
I assume so, y
Author: ericwf
Date: Tue Oct 11 19:00:37 2016
New Revision: 283958
URL: http://llvm.org/viewvc/llvm-project?rev=283958&view=rev
Log:
Make it easier to run the libc++ test suite against libstdc++
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
libcxx/trunk/test/libcxx/test/config.py
libc
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
BillyONeal added a subscriber: cfe-commits.
https://reviews.llvm.org/D25492
Files:
test/std/strings/basic.string/string.modifiers/string_append/T_size_size.pass.cpp
test/std/strings/basic.string/string.modifi
jbangert marked an inline comment as done.
jbangert added a comment.
Thanks for the review!
https://reviews.llvm.org/D24997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbangert updated this revision to Diff 74311.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/NamespaceAliaser.cpp
clang-tidy/utils/NamespaceAliaser.h
clang-tidy/utils/UsingInserter.cpp
clang-tidy/utils/UsingInserter.h
erichkeane updated the summary for this revision.
erichkeane removed a reviewer: gbenyei.
erichkeane removed rL LLVM as the repository for this revision.
erichkeane updated this revision to Diff 74310.
erichkeane added a comment.
Emailed with Alexey who identified the problem in the OpenMP impleme
agutowski added a comment.
In https://reviews.llvm.org/D25458#567697, @rnk wrote:
> Can you provide a more complete motivating example where our diagnostics were
> bad? I'm having a hard time figuring it out from the test
Sure, compiling the following program in C++ for i386 emits warnings abo
phosek added a comment.
libc++ was already building with musl after https://reviews.llvm.org/D21637 was
commited, but this broke recently as a consequence of r282640 which introduced
the use of `_LIBCPP_SAFE_STATIC` for libc++ internal globals. I'm not sure if
this is the best solution, but it'
phosek created this revision.
phosek added reviewers: EricWF, mclow.lists.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
Herald added subscribers: mgorny, beanz.
musl's pthread implementations use volatile types in their structs which is not
being
rnk added a comment.
Can you provide a more complete motivating example where our diagnostics were
bad? I'm having a hard time figuring it out from the test
https://reviews.llvm.org/D25458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: ericwf
Date: Tue Oct 11 17:18:09 2016
New Revision: 283951
URL: http://llvm.org/viewvc/llvm-project?rev=283951&view=rev
Log:
Fix LWG2683 - filesystem::copy() should always clear the user-provided
error_code
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
libcxx
rnk added a comment.
We shouldn't thread this kind of boolean all the way through name lookup. This
is the kind of thing that callers should configure on the LookupResult object
that they pass in.
https://reviews.llvm.org/D25458
___
cfe-commits ma
Author: sqlbyme
Date: Tue Oct 11 17:09:13 2016
New Revision: 283950
URL: http://llvm.org/viewvc/llvm-project?rev=283950&view=rev
Log:
Revert - When optimizing for size, enable loop rerolling by default
This reverts r283685 as it is causing test failures on Green Dragon.
Modified:
cfe/trunk/l
rmaprath added a comment.
Added some comments to @EricWF's feedback. Will check back tomorrow (falling
asleep...)
/ Asiri
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC
Author: vedantk
Date: Tue Oct 11 16:56:05 2016
New Revision: 283949
URL: http://llvm.org/viewvc/llvm-project?rev=283949&view=rev
Log:
[Profile] Update testcase for r283948 (NFC)
Old: "__DATA,__llvm_prf_data"
New: "__DATA,__llvm_prf_data,regular,live_support"
This should fix the following bot fai
rsmith added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:11356-11357
+ // Compute the EffectiveAlignment as the alignment of the whole chain.
+ CharUnits EffectiveAlignment = Context.getTypeAlignInChars(
+ ReverseMemberChain.back()->getParent()->getTypeForDecl()
Yup, GCC is "fast enough" again. Thanks :)
On Tue, Oct 11, 2016 at 9:13 PM, Mehdi Amini wrote:
> Reverted in r283920, can you check if it is enough to “fix” the GCC issue?
>
>> On Oct 11, 2016, at 12:04 PM, Benjamin Kramer wrote:
>>
>> Committing this patch before the constexpr change seems back
rsmith added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:4849
+ DeclarationName Name = D->getDeclName();
+ if (auto *DD = dyn_cast(D))
+Name =
ahatanak wrote:
> rsmith wrote:
> > Do we need to do this for conversion fun
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
aaron
EricWF added inline comments.
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC_VER < 500)
If `_LIBCPP_HAS_THREAD_API_EXTERNAL` is defined can't we just assum
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1213
+ bool isThisDeclarationADemotedDefinition() const {
+return NonParmVarDeclBits.IsThisDeclarationADemotedDefinition;
+ }
This is the bug. You can't read this bit here without first chec
Author: marshall
Date: Tue Oct 11 16:24:06 2016
New Revision: 283945
URL: http://llvm.org/viewvc/llvm-project?rev=283945&view=rev
Log:
Remove extraneous 'const' in the implementation of is_move_assignable. Howard
pleads temporary insanity about this. Discussed at
http://stackoverflow.com/questi
We noticed that this change also caused VS2015 to take a lot longer when
building Targets.cpp. The revert in r283920 seems to have fixed it. The
upstream PS4 Windows bot went from a build time of 17:53
(http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/127
Author: ericwf
Date: Tue Oct 11 16:22:21 2016
New Revision: 283944
URL: http://llvm.org/viewvc/llvm-project?rev=283944&view=rev
Log:
Fix std::pair on FreeBSD
Summary:
FreeBSD ships an old ABI for std::pair which requires that it have non-trivial
copy/move constructors. Currently the non-trivial
Author: mren
Date: Tue Oct 11 16:18:20 2016
New Revision: 283943
URL: http://llvm.org/viewvc/llvm-project?rev=283943&view=rev
Log:
Module: for ObjectiveC, be consistent when checking hidden decls.
In MatchAllMethodDeclarations, when checking a hidden decl, be sure
to allow hidden when searching f
Author: ericwf
Date: Tue Oct 11 16:13:44 2016
New Revision: 283941
URL: http://llvm.org/viewvc/llvm-project?rev=283941&view=rev
Log:
Fix incorrect exception handling behavior in the uninitialized algorithms
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/memory/spec
Author: arnolds
Date: Tue Oct 11 15:34:03 2016
New Revision: 283932
URL: http://llvm.org/viewvc/llvm-project?rev=283932&view=rev
Log:
Pass the end of a component to SwiftAggLowering's enumerateComponents callback
This is usefull for determining whether components overlap.
Modified:
cfe/trunk
Author: arnolds
Date: Tue Oct 11 15:34:06 2016
New Revision: 283933
URL: http://llvm.org/viewvc/llvm-project?rev=283933&view=rev
Log:
Swift Calling Convention: Parameters are allowed after the
swift_error/swift_context parameter
We need to be able to decelare witness functions which append the se
vbyakovlcl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
bruno wrote:
> vbyakovlcl wrote:
> > bruno wrote:
> > > v
Hi Chris,
Thanks! Can you (or someone else) revert this. I won't be able to look at it
until tonight.
-Hal
- Original Message -
> From: "Chris Matthews"
> To: "Hal Finkel" , cfe-commits@lists.llvm.org
> Sent: Tuesday, October 11, 2016 2:32:33 PM
> Subject: Re: r283685 - When optimi
I noticed since this commit there is a test-suite failure:
http://lab.llvm.org:8080/green/job/perf_darwin_x86_Osflto/64/
SingleSource.Benchmarks.Adobe-C++.loop_unroll appears to be failing.
Tailing the output of the program gets:
…
test 236 failed
test 236 failed
test 236 failed
test 2
Hal,
I noticed since this commit there is a test-suite failure:
http://lab.llvm.org:8080/green/job/perf_darwin_x86_Osflto/64/
SingleSource.Benchmarks.Adobe-C++.loop_unroll appears to be failing.
Tailing the output of the program gets:
…
test 236 failed
test 236 failed
test 236 failed
test 236
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D25480#567552, @ahatanak wrote:
> __builtin_fpclassify takes five int arguments followed by one last argument
> that is of floating point type. Do you know if there is a way to specify the
> last one argument is a floating poin
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Finde
Reverted in r283920, can you check if it is enough to “fix” the GCC issue?
> On Oct 11, 2016, at 12:04 PM, Benjamin Kramer wrote:
>
> Committing this patch before the constexpr change seems backwards
> then? The static initializers are already breaking stuff because it
> takes GCC with optimizat
Author: mehdi_amini
Date: Tue Oct 11 14:04:24 2016
New Revision: 283920
URL: http://llvm.org/viewvc/llvm-project?rev=283920&view=rev
Log:
Revert "Change Builtins name to be stored as StringRef instead of raw pointers
(NFC)"
This reverts commit r283802. It introduces temporarily static
initialize
Yes, do you have a specific concern for this table size in particular?
> On Oct 11, 2016, at 12:07 PM, Craig Topper wrote:
>
> But this also increases the size of the builtin table too right? Since
> StringRef is twice the size of a pointer.
>
> ~Craig
>
> On Tue, Oct 11, 2016 at 11:40 AM, Me
> On Oct 11, 2016, at 12:04 PM, Benjamin Kramer wrote:
>
> Committing this patch before the constexpr change seems backwards
> then?
Well not really because I need to make StringRef(const char *) explicit, so all
the others have to go first.
> The static initializers are already breaking stuf
But this also increases the size of the builtin table too right? Since
StringRef is twice the size of a pointer.
~Craig
On Tue, Oct 11, 2016 at 11:40 AM, Mehdi Amini via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This is temporary: the last patch of my series of patches adds the
> conste
Committing this patch before the constexpr change seems backwards
then? The static initializers are already breaking stuff because it
takes GCC with optimization and debug info takes 10+ minutes to
generate megabytes of static initializer code in Targets.cpp. Can you
please revert this until the co
ahatanak added a comment.
__builtin_fpclassify takes five int arguments followed by one last argument
that is of floating point type. Do you know if there is a way to specify the
last one argument is a floating point rather than using '.'?
https://reviews.llvm.org/D25480
___
malcolm.parsons added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Fin
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
The recently-added limited_allocator is much more conformant than the evil old
stack_allocator. However, limited_allocator encodes non-Standard assumptions
about how many allo
Author: bruno
Date: Tue Oct 11 13:38:33 2016
New Revision: 283917
URL: http://llvm.org/viewvc/llvm-project?rev=283917&view=rev
Log:
[Driver] Use -fsyntax-only in test/Driver/show-option-names.c
Make the test less expensive, follow up from r283915.
Modified:
cfe/trunk/test/Driver/show-option-
This is temporary: the last patch of my series of patches adds the constexpr
ctor and remove all these static initializers.
> On Oct 11, 2016, at 11:26 AM, Benjamin Kramer wrote:
>
> I don't think this change is worth it. We create huge static arrays
> with Builtin::Info in Builtins.cpp and Tar
Author: bruno
Date: Tue Oct 11 13:31:45 2016
New Revision: 283915
URL: http://llvm.org/viewvc/llvm-project?rev=283915&view=rev
Log:
[Driver] Fix test from r283913 to unbreak bots
Followup from r283913 & r283827
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55135
Modified:
cfe/tr
Let's see how it goes: Committed r283913
On Tue, Oct 11, 2016 at 11:13 AM, Bruno Cardoso Lopes
wrote:
> On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin
> wrote:
>> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
>> wrote:
>>> Thanks Renato!
>>
>> So, Daniel Jasper did a trick on r283853 (clang
Author: bruno
Date: Tue Oct 11 13:21:26 2016
New Revision: 283913
URL: http://llvm.org/viewvc/llvm-project?rev=283913&view=rev
Log:
Reapply [Driver][Diagnostics] Make 'show option names' default for driver
warnings
Reapply r283827 by fixing the tests to not be target specific
Currently, driver
I don't think this change is worth it. We create huge static arrays
with Builtin::Info in Builtins.cpp and Targets.cpp, StringRef(const
char*) is not constexpr (because of strlen). This means you'll get a
huge generated initialization function for it. We want to reduce the
number of global initiali
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:387
+ Token Tok;
+ while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {
+ }
hokein wrote:
> Maybe we can use `findLocationAfterToken` here?
This doesn't seem
On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin wrote:
> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
> wrote:
>> Thanks Renato!
>
> So, Daniel Jasper did a trick on r283853 (clang || true) to make it
> not fail when it returns on error. However, I wasn't able to make it
> return anything but
hubert.reinterpretcast added a comment.
A test should probably be added as well.
https://reviews.llvm.org/D25480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Tue Oct 11 12:36:03 2016
New Revision: 283907
URL: http://llvm.org/viewvc/llvm-project?rev=283907&view=rev
Log:
[CUDA] Re-land support for (r283683 and r283680).
These were reverted in r283753 and r283747.
The first patch added a header to the root 'Headers' install directo
idlecode marked an inline comment as done.
idlecode added a comment.
Sure, I will upload diff as soon as I test it
https://reviews.llvm.org/D25439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > vbyakovlcl wrote:
> > > b
taniabarg created this revision.
taniabarg added reviewers: davidsh, hubert.reinterpretcast.
taniabarg added a subscriber: cfe-commits.
BIF fpclassify has the wrong number of integer parameters specified in
Builtins.def. There should be 5 int parameters (each representing the values
FP_NAN, FP_I
Author: rnk
Date: Tue Oct 11 12:24:09 2016
New Revision: 283906
URL: http://llvm.org/viewvc/llvm-project?rev=283906&view=rev
Log:
Fix the build with MSVC 2013 after r283856
Modified:
cfe/trunk/lib/Frontend/CacheTokens.cpp
Modified: cfe/trunk/lib/Frontend/CacheTokens.cpp
URL:
http://llvm.org
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
+
Finde
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1469
+ let Spellings = [CXX11<"clang", "suppress">, CXX11<"gsl", "suppress">];
+ let Args = [VariadicStringArgument<"Rules">];
+ let Documentation = [SuppressDocs];
Perhaps we should
On 11 October 2016 at 16:34, Bruno Cardoso Lopes
wrote:
> Thanks Renato!
So, Daniel Jasper did a trick on r283853 (clang || true) to make it
not fail when it returns on error. However, I wasn't able to make it
return anything but 0, so I'm at odds why this fails on the bot.
I was expecting it to
This breaks MSVC 2013 builds:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/30238/steps/run%20tests/logs/stdio
FAILED:
tools/clang/lib/Frontend/CMakeFiles/clangFrontend.dir/CacheTokens.cpp.obj
...
C:\b\slave\sanitizer-windows\llvm\tools\clang\lib\Frontend\CacheTokens.cpp(63)
: error C
alexfh added inline comments.
Comment at: clang-tidy/google/NonConstReferences.cpp:73
+ [&](llvm::StringRef WhiteListType) {
+ return ReferencedType.getCanonicalType().getAsString(
+Result.Context->getPrintingP
vbyakovlcl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
bruno wrote:
> vbyakovlcl wrote:
> > bruno wrote:
> > > B
vbyakovlcl updated this revision to Diff 74269.
https://reviews.llvm.org/D24669
Files:
llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/CodeGen/vecshift.c
llvm/tools/clang/test/Sema/vecshift.c
Index: llvm/tools/clang
On Tue, Oct 11, 2016 at 9:34 AM, Justin Lebar wrote:
> > Can we figure out why having an incremental stage1 is problematic? I
> want to keep it that way to speed up the bot.
>
> The problem is that the cmake install rule that we use does not remove
> extra files that happen to be present in the i
> Can we figure out why having an incremental stage1 is problematic? I want to
> keep it that way to speed up the bot.
The problem is that the cmake install rule that we use does not remove
extra files that happen to be present in the install directory. So if
you put something bad in there, as I
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D25436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Can we figure out why having an incremental stage1 is problematic? I want
to keep it that way to speed up the bot.
It sounds like the problem is that we do not delete the stage1 install
directory before installing to it, or our install step uses a glob that may
include stale files from previous bu
Author: zturner
Date: Tue Oct 11 11:06:32 2016
New Revision: 283895
URL: http://llvm.org/viewvc/llvm-project?rev=283895&view=rev
Log:
Fix clang-offload-bundler test.
A recent change to llvm::cl slightly changed the format of
the help output, and it broke this test. NFC
Modified:
cfe/trunk/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283891: [OpenCL] Allow partial initializer for array and
struct (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25335?vs=73818&id=74266#toc
Repository:
rL LLVM
https://revie
Author: yaxunl
Date: Tue Oct 11 10:53:28 2016
New Revision: 283891
URL: http://llvm.org/viewvc/llvm-project?rev=283891&view=rev
Log:
[OpenCL] Allow partial initializer for array and struct
Currently Clang allows partial initializer for C99 but not for OpenCL, e.g.
float a[16][16] = {1.0f, 2.0f};
Author: vvassilev
Date: Tue Oct 11 10:51:06 2016
New Revision: 283890
URL: http://llvm.org/viewvc/llvm-project?rev=283890&view=rev
Log:
Revert r283887 and r283882, until the issue is understood and fixed.
Removed:
cfe/trunk/test/Modules/Inputs/PR28752/
cfe/trunk/test/Modules/pr28752.cpp
M
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: rengolin, jmolloy.
SjoerdMeijer added a subscriber: cfe-commits.
Guard the -fdenormal-fp-math with -fno-fast-math. This allows disabling the FP
options with just one flag: –fno-fast-math.
https://reviews.llvm.org/D25479
Files:
elsteveogrande updated this revision to Diff 74265.
elsteveogrande added a comment.
Thanks very much @vsk for the feedback! Updated per your recommendations;
`CHECK` looks much better
https://reviews.llvm.org/D25153
Files:
include/clang/Driver/Options.td
include/clang/Frontend/Preprocesso
tstellarAMD added a comment.
In https://reviews.llvm.org/D25343#565288, @Anastasia wrote:
> Do you have any code example where Clang/LLVM performs wrong optimizations
> with respect to the control flow of SPMD execution?
>
> My understanding from the earlier discussion we have had:
> https://ww
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/partial_initializer.cl:5
+
+// CHECK: @GA = addrspace(1) global [6 x [6 x float]] {{[[][[]}}6 x float]
[float 1.00e+00, float 2.00e+00, float 0.00e+00, float
0.00e+00, float 0.00e+00, float 0.0
Thanks Renato!
On Tue, Oct 11, 2016 at 3:36 AM, Renato Golin wrote:
> On 11 October 2016 at 10:14, Renato Golin wrote:
>> clang-4.0: warning: no such sysroot directory: '/FOO' [-Wmissing-sysroot]
>> error: unable to create target: 'No available targets are compatible
>> with this triple.'
>> 1 e
Author: mehdi_amini
Date: Tue Oct 11 10:15:32 2016
New Revision: 283888
URL: http://llvm.org/viewvc/llvm-project?rev=283888&view=rev
Log:
Use StringRef instead of raw pointer in SourceManagerInternals LineTableInfo
API (NFC)
Modified:
cfe/trunk/include/clang/Basic/SourceManagerInternals.h
M
Author: vvassilev
Date: Tue Oct 11 10:09:26 2016
New Revision: 283887
URL: http://llvm.org/viewvc/llvm-project?rev=283887&view=rev
Log:
r283882 followup. Don't demote ParmVarDecls. This should fix our module builds.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaD
kromanenkov created this revision.
kromanenkov added reviewers: zaks.anna, NoQ, dcoughlin.
kromanenkov added subscribers: a.sidorin, cfe-commits.
Add a new type of NonLoc SVal for pointer-to-member operations. This SVal
supports both pointers to member functions and pointers to member data.
htt
Author: malcolm.parsons
Date: Tue Oct 11 09:49:24 2016
New Revision: 283886
URL: http://llvm.org/viewvc/llvm-project?rev=283886&view=rev
Log:
[clang-tidy] Ignore empty members and bases in
cppcoreguidelines-pro-type-member-init
Summary: Empty/incomplete variables/members/bases don't need to be i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283886: [clang-tidy] Ignore empty members and bases in
cppcoreguidelines-pro-type… (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25238?vs=74125&id=74256#toc
Reposito
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283879: [clang-tidy] Fix template agrument false positives
in unused-using-decls. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25437?vs=74239&id=74254#toc
Repository:
rL L
javed.absar created this revision.
javed.absar added reviewers: jmolloy, rengolin.
javed.absar added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This patch fixes an incomplete test, wherein the target-cpu name (cortex-r52)
was missing.
https://reviews.llvm.org/D25474
Files:
1 - 100 of 138 matches
Mail list logo
