[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka marked an inline comment as done. vitalybuka added a comment. Please take a look. Meanwhile, I will investigate performance footprint. In https://reviews.llvm.org/D24693#559781, @rsmith wrote: > Is there some reasonable base set of functionality between this and > JumpDiagnostics

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka updated this revision to Diff 74814. vitalybuka added a comment. - fixed comment - added test for indirect jumps https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h

[clang-tools-extra] r284360 - ClangMoveTests.cpp: Appease msc18.

Author: chapuni Date: Mon Oct 17 00:09:58 2016 New Revision: 284360 URL: http://llvm.org/viewvc/llvm-project?rev=284360=rev Log: ClangMoveTests.cpp: Appease msc18. clang-tools-extra\unittests\clang-move\ClangMoveTests.cpp(216) : error C2593: 'operator =' is ambiguous

[clang-tools-extra] r284359 - Reformat.

Author: chapuni Date: Mon Oct 17 00:08:49 2016 New Revision: 284359 URL: http://llvm.org/viewvc/llvm-project?rev=284359=rev Log: Reformat. Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp URL:

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka updated this revision to Diff 74813. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. Herald added a subscriber: modocache. - updated comments - indirect jumps - optimized Detect() https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp

r284355 - [CUDA] Fix false-positive in known-emitted handling.

Author: jlebar Date: Sun Oct 16 21:25:55 2016 New Revision: 284355 URL: http://llvm.org/viewvc/llvm-project?rev=284355=rev Log: [CUDA] Fix false-positive in known-emitted handling. Previously: When compiling for host, our constructed call graph went *through* kernel calls. This meant that if we

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva wrote: > Nice to see this land! > > One nit: > Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a user > uses the "gold syntax" then LLD will silently ignore it, which isn't good. > At the very least, can we

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

Nice to see this land! One nit: Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a user uses the "gold syntax" then LLD will silently ignore it, which isn't good. At the very least, can we issue an error if we see `-plugin-opt jobs=N` and suggest the LLD spelling? Or maybe

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

See the Mac bot here: https://codereview.chromium.org/2416293003/ -> https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/105/steps/package%20clang/logs/stdio I think that bot uses Xcode 8's compiler. I haven't tried again since 2 days ago. On Sat, Oct 15, 2016 at

r284352 - clang/test/CXX/conv/conv.fctptr/p1.cpp: Appease for targeting i686-win32.

Author: chapuni Date: Sun Oct 16 18:00:18 2016 New Revision: 284352 URL: http://llvm.org/viewvc/llvm-project?rev=284352=rev Log: clang/test/CXX/conv/conv.fctptr/p1.cpp: Appease for targeting i686-win32. error: 'error' diagnostics seen but not expected: File

r284351 - Revert "Revert "[analyzer] Make MallocChecker more robust against custom redeclarations""

Author: dcoughlin Date: Sun Oct 16 17:19:03 2016 New Revision: 284351 URL: http://llvm.org/viewvc/llvm-project?rev=284351=rev Log: Revert "Revert "[analyzer] Make MallocChecker more robust against custom redeclarations"" This reverts commit r284340 to reapply r284335. The bot breakage was due

r284341 - AST: Improve a couple of comments and cast unused values to void

Author: bogner Date: Sun Oct 16 15:12:42 2016 New Revision: 284341 URL: http://llvm.org/viewvc/llvm-project?rev=284341=rev Log: AST: Improve a couple of comments and cast unused values to void Make these comments a bit more explicit that they're initializing the RawText member, and explicitly

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

> On Oct 16, 2016, at 12:53 PM, Renato Golin wrote: > > On 16 October 2016 at 20:36, Devin Coughlin wrote: >> Reverted in r284340. > > Hi Devin, > > Sometimes Clang patches break on stage 2 or test-suite, but this is > not the case. I dug deeper

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

On 16 October 2016 at 20:36, Devin Coughlin wrote: > Reverted in r284340. Hi Devin, Sometimes Clang patches break on stage 2 or test-suite, but this is not the case. I dug deeper and found that there was another commit, not showing on that range (it should have, but that's

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

> On Oct 16, 2016, at 12:12 PM, Devin Coughlin via cfe-commits > wrote: > >> >> On Oct 16, 2016, at 12:04 PM, Renato Golin wrote: >> >> On 16 October 2016 at 18:26, Devin Coughlin via cfe-commits >> wrote: >>>

r284340 - Revert "[analyzer] Make MallocChecker more robust against custom redeclarations"

Author: dcoughlin Date: Sun Oct 16 14:26:07 2016 New Revision: 284340 URL: http://llvm.org/viewvc/llvm-project?rev=284340=rev Log: Revert "[analyzer] Make MallocChecker more robust against custom redeclarations" This reverts commit r284335. It appears to be causing test-suite compile-time and

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

> On Oct 16, 2016, at 12:04 PM, Renato Golin wrote: > > On 16 October 2016 at 18:26, Devin Coughlin via cfe-commits > wrote: >> Author: dcoughlin >> Date: Sun Oct 16 12:26:06 2016 >> New Revision: 284335 >> >> URL:

Re: r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

On 16 October 2016 at 18:26, Devin Coughlin via cfe-commits wrote: > Author: dcoughlin > Date: Sun Oct 16 12:26:06 2016 > New Revision: 284335 > > URL: http://llvm.org/viewvc/llvm-project?rev=284335=rev > Log: > [analyzer] Make MallocChecker more robust against custom

r284337 - P0012R1: Make exception specifications be part of the type system. This

Author: rsmith Date: Sun Oct 16 12:54:23 2016 New Revision: 284337 URL: http://llvm.org/viewvc/llvm-project?rev=284337=rev Log: P0012R1: Make exception specifications be part of the type system. This implements the bulk of the change (modifying the type system to include exception

r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

Author: dcoughlin Date: Sun Oct 16 12:26:06 2016 New Revision: 284335 URL: http://llvm.org/viewvc/llvm-project?rev=284335=rev Log: [analyzer] Make MallocChecker more robust against custom redeclarations Add additional checking to MallocChecker to avoid crashing when memory routines have

[PATCH] D25654: [Sema] Don't perform aggregate initialization for types with explicit constructors

rsmith added a comment. Please also add a test to test/CXX/drs/dr15xx.cpp for core issue 1518, which this paper was resolving. Comment at: lib/AST/DeclCXX.cpp:564 +// C++1z [dcl.init.aggr]p1: +// - no user-provided, explicit, or inherited constructors, +if

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

mgorny created this revision. mgorny added reviewers: rafael, chandlerc, bruno, bkramer. mgorny added a subscriber: cfe-commits. Support using gcc-config to determine the correct GCC toolchain location on Gentoo. In order to do that, attempt to read gcc-config configuration form

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, klimek, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. It is easy to configure clang-tidy with both aliased and original checks enabled. This causes the check to

[libcxx] r284333 - Make any_cast<void()>(nullptr) compile

Author: ericwf Date: Sun Oct 16 06:56:38 2016 New Revision: 284333 URL: http://llvm.org/viewvc/llvm-project?rev=284333=rev Log: Make any_cast(nullptr) compile Modified: libcxx/trunk/include/any libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/any_cast_pointer.pass.cpp

[PATCH] D25642: [clang-tidy] Use ignoreImplicit in cert-err58-cpp check

This revision was automatically updated to reflect the committed changes. Closed by commit rL284332: [clang-tidy] Use ignoreImplicit in cert-err58-cpp check (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D25642?vs=74770=74787#toc Repository: rL LLVM

[clang-tools-extra] r284332 - [clang-tidy] Use ignoreImplicit in cert-err58-cpp check

Author: malcolm.parsons Date: Sun Oct 16 04:47:10 2016 New Revision: 284332 URL: http://llvm.org/viewvc/llvm-project?rev=284332=rev Log: [clang-tidy] Use ignoreImplicit in cert-err58-cpp check Summary: Fix a false negative in cert-err58-cpp check when calling a constructor creates objects that