[PATCH] D25675: clang-format: [JS] Fix template string ASI.

This revision was automatically updated to reflect the committed changes. mprobst marked an inline comment as done. Closed by commit rL284807: clang-format: [JS] Fix template string ASI. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D25675?vs=74837=75390#toc

[PATCH] D25675: clang-format: [JS] Fix template string ASI.

mprobst marked an inline comment as done. mprobst added inline comments. Comment at: unittests/Format/FormatTestJS.cpp:1280 +TEST_F(FormatTestJS, TemplateStringASI) { + verifyFormat("var x = `hello${world}`;", "var x = `hello${\n" + "

r284807 - clang-format: [JS] Fix template string ASI.

Author: mprobst Date: Fri Oct 21 00:11:38 2016 New Revision: 284807 URL: http://llvm.org/viewvc/llvm-project?rev=284807=rev Log: clang-format: [JS] Fix template string ASI. Summary: Previously, automatic semicolon insertion would add an unwrapped line when a template string contained a line

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5080 +def note_explicit_ownership_qualification : Note< + "explicitly specify ownership qualification">; + How about: warning: block captures an autoreleasing

[PATCH] D25675: clang-format: [JS] Fix template string ASI.

djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTestJS.cpp:1280 +TEST_F(FormatTestJS, TemplateStringASI) { + verifyFormat("var x = `hello${world}`;", "var x = `hello${\n" +

[PATCH] D23765: Fix for clang PR 29087

twoh added a comment. ping https://reviews.llvm.org/D23765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284802 - Don't try to use !Previous.empty() as a proxy for "Is this a redeclaration?" --

Author: rsmith Date: Thu Oct 20 22:15:03 2016 New Revision: 284802 URL: http://llvm.org/viewvc/llvm-project?rev=284802=rev Log: Don't try to use !Previous.empty() as a proxy for "Is this a redeclaration?" -- we don't collapse that down to a single entry if it's not a redeclaration. Instead, set

[libcxx] r284801 - [ModuleMap] Add more module entries to cover some non modular headers

Author: bruno Date: Thu Oct 20 22:14:27 2016 New Revision: 284801 URL: http://llvm.org/viewvc/llvm-project?rev=284801=rev Log: [ModuleMap] Add more module entries to cover some non modular headers These modules are necessary on Darwin to allow modules with 'no_undeclared_includes' (introduced in

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

rsmith added a comment. This generally makes sense to me. `_Nonnull` in this position seems very similar to `static` (which typically also implies non-nullness). Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499 case Type::Adjusted: - case Type::Decayed: + case

r284800 - DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.

Author: rsmith Date: Thu Oct 20 21:36:37 2016 New Revision: 284800 URL: http://llvm.org/viewvc/llvm-project?rev=284800=rev Log: DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules. This has two significant effects: 1) Direct relational comparisons between null pointer

r284798 - [Driver][Darwin] Pass -no_deduplicate to ld64

Author: bruno Date: Thu Oct 20 20:49:14 2016 New Revision: 284798 URL: http://llvm.org/viewvc/llvm-project?rev=284798=rev Log: [Driver][Darwin] Pass -no_deduplicate to ld64 Recent versions of ld64 run a deduplicate pass, which is on by default. Disable the pass by using -no_deduplicate in

r284797 - [Modules] Add 'no_undeclared_includes' module map attribute

Author: bruno Date: Thu Oct 20 20:41:56 2016 New Revision: 284797 URL: http://llvm.org/viewvc/llvm-project?rev=284797=rev Log: [Modules] Add 'no_undeclared_includes' module map attribute The 'no_undeclared_includes' attribute should be used in a module to tell that only non-modular headers and

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

inglorion updated this revision to Diff 75381. inglorion added a comment. Use insert's return value to save a set lookup, and use CanonicalDeclPtr https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index:

[PATCH] D25857: [tsan] Introduce a function attribute to disable TSan checking at run time

zaks.anna created this revision. zaks.anna added reviewers: kcc, kubabrecka, dvyukov. zaks.anna added a subscriber: cfe-commits. This introduces a function annotation that disables TSan checking for the function at run time. The benefit over __attribute__((no_sanitize("thread"))) is that the

[PATCH] D25853: [libcxx] [test] Fix non-Standard make_from_tuple() tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. The Standard doesn't depict make_from_tuple() as conditionally noexcept. Mark these tests as libcxx-specific. https://reviews.llvm.org/D25853 Files:

[PATCH] D25852: [libcxx] [test] Fix shadow warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix shadow warnings. This variable was scoped incorrectly, found by MSVC. https://reviews.llvm.org/D25852 Files:

[PATCH] D25851: [libcxx] [test] Fix unreferenced formal parameter warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix unreferenced formal parameter warnings. Found by MSVC as usual. https://reviews.llvm.org/D25851 Files:

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

jordan_rose created this revision. jordan_rose added reviewers: aprantl, doug.gregor. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. Last year Apple added new qualifiers to pointer types: `_Nullable`, `_Nonnull`, and `_Null_unspecified`.

Buildbot numbers for the week of 10/9/2016 - 10/15/2016

Hello everyone, Below are some buildbot numbers for the last week of 10/9/2016 - 10/15/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Buildbot numbers for the week of 10/2/2016 - 10/8/2016

Hello everyone, Below are some buildbot numbers for the week of 10/2/2016 - 10/8/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

inglorion updated this revision to Diff 75367. inglorion added a comment. Updated to track the latest state of https://reviews.llvm.org/D25578 https://reviews.llvm.org/D25579 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-ms-vbase.cpp Index:

[PATCH] D25842: [clang] Limit clang test to ARM and AArch64 only

mgrang retitled this revision from "[clang] Limit clang test to ARM only" to "[clang] Limit clang test to ARM and AArch64 only". mgrang updated the summary for this revision. mgrang updated this revision to Diff 75368. mgrang added a comment. Test limited only to ARM and AArch64.

Re: r284793 - Remove 24 instances of 'REQUIRES: shell'

On Thu, Oct 20, 2016 at 4:38 PM, Robinson, Paul wrote: > Is there any expectation that they _should_ (eventually) work on Windows? > Yes, LLVM is a cross-platform project, and there is an expectation that developers will attempt to write portable code. It seems like

r284794 - Revert 9 changes from r284793, they still fail on some bots

Author: rnk Date: Thu Oct 20 18:30:39 2016 New Revision: 284794 URL: http://llvm.org/viewvc/llvm-project?rev=284794=rev Log: Revert 9 changes from r284793, they still fail on some bots Modified: cfe/trunk/test/Driver/rewrite-map-in-diagnostics.c

RE: r284793 - Remove 24 instances of 'REQUIRES: shell'

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Reid Kleckner via cfe-commits > Sent: Thursday, October 20, 2016 4:12 PM > To: cfe-commits@lists.llvm.org > Subject: r284793 - Remove 24 instances of 'REQUIRES: shell' > > Author: rnk >

RE: r284777 - Fix off-by-one error in PPCaching.cpp token annotation assertion

Hi Reid, Just a heads up that the test you added fails if the compiler defaults to a different C++ standard. Our internal version defaults to c++11, and the test fails because the error "expected ';' after top level declarator" is not emitted. Douglas Yung > -Original Message- >

r284793 - Remove 24 instances of 'REQUIRES: shell'

Author: rnk Date: Thu Oct 20 18:11:45 2016 New Revision: 284793 URL: http://llvm.org/viewvc/llvm-project?rev=284793=rev Log: Remove 24 instances of 'REQUIRES: shell' Tests fall into one of the following categories: - The requirement was unnecessary - Additional quoting was required for

Re: r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

> On Oct 19, 2016, at 4:19 AM, Vassil Vassilev via cfe-commits > wrote: > > Author: vvassilev > Date: Wed Oct 19 06:19:30 2016 > New Revision: 284577 > > URL: http://llvm.org/viewvc/llvm-project?rev=284577=rev > Log: > [modules] Do not report missing definitions of

r284785 - Re-commit r284753, reverted in r284778, with a fix for PR30749.

Author: rsmith Date: Thu Oct 20 16:53:09 2016 New Revision: 284785 URL: http://llvm.org/viewvc/llvm-project?rev=284785=rev Log: Re-commit r284753, reverted in r284778, with a fix for PR30749. Original commit message: [c++1z] Teach composite pointer type computation how to compute the composite

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

mgorny marked 3 inline comments as done. mgorny added a comment. I think I've addressed all your concerns now. https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:111 + QualType ObjT = (IsCpp || IsObjC) + ? Obj->getType().getCanonicalType().getUnqualifiedType() + : Obj->getType();

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

mgorny retitled this revision from "[ToolChains] Disable OpenSUSE rules for SLES10" to "[Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older". mgorny updated the summary for this revision. mgorny updated this revision to Diff 75357. https://reviews.llvm.org/D24954 Files:

[PATCH] D22712: Remove FileEntry copy-constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL284782: [clang] Remove FileEntry copy-constructor (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D22712?vs=65187=75356#toc Repository: rL LLVM

r284782 - [clang] Remove FileEntry copy-constructor

Author: alexshap Date: Thu Oct 20 16:20:35 2016 New Revision: 284782 URL: http://llvm.org/viewvc/llvm-project?rev=284782=rev Log: [clang] Remove FileEntry copy-constructor Code cleanup: address FIXME in the file include/clang/Basic/FileManager.h and remove copy-constructor of the class

r284781 - Revert "Disable swiftcall test on windows: More brutal way to appease windows bots"

Author: rnk Date: Thu Oct 20 16:17:28 2016 New Revision: 284781 URL: http://llvm.org/viewvc/llvm-project?rev=284781=rev Log: Revert "Disable swiftcall test on windows: More brutal way to appease windows bots" This reverts commit r284174. The tests pass for me locally. It must have been a 2015

Re: r284753 - [c++1z] Teach composite pointer type computation how to compute the composite

On Thu, Oct 20, 2016 at 10:57 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Oct 20 12:57:33 2016 > New Revision: 284753 > > URL: http://llvm.org/viewvc/llvm-project?rev=284753=rev > Log: > [c++1z] Teach composite pointer type computation how to

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande updated this revision to Diff 75351. elsteveogrande added a comment. Fixed an error. A newline is sometimes not appended prior to this `#include`. When returning from an included file which doesn't have a trailing newline, the #include is stuck at the end of some other line,

r284778 - Revert r284753 "[c++1z] Teach composite pointer type computation how to compute the composite"

Author: hans Date: Thu Oct 20 15:54:32 2016 New Revision: 284778 URL: http://llvm.org/viewvc/llvm-project?rev=284778=rev Log: Revert r284753 "[c++1z] Teach composite pointer type computation how to compute the composite" It caused PR30749. Removed: cfe/trunk/test/CXX/expr/p13.cpp Modified:

r284777 - Fix off-by-one error in PPCaching.cpp token annotation assertion

Author: rnk Date: Thu Oct 20 15:53:20 2016 New Revision: 284777 URL: http://llvm.org/viewvc/llvm-project?rev=284777=rev Log: Fix off-by-one error in PPCaching.cpp token annotation assertion This assert is intended to defend against backtracking into the middle of a sequence of tokens that is

[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.

GorNishanov abandoned this revision. GorNishanov added a comment. I'll simplify and split it into super tiny microscopic patches to have a better chance of being reviewed. https://reviews.llvm.org/D25258 ___ cfe-commits mailing list

[PATCH] D25819: [Driver] Refactor DetectDistro() parameters to take VFS ref only. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL284774: [Driver] Refactor DetectDistro() parameters to take VFS ref only. NFC (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25819?vs=75283=75350#toc Repository: rL LLVM

r284774 - [Driver] Refactor DetectDistro() parameters to take VFS ref only. NFC

Author: mgorny Date: Thu Oct 20 15:45:40 2016 New Revision: 284774 URL: http://llvm.org/viewvc/llvm-project?rev=284774=rev Log: [Driver] Refactor DetectDistro() parameters to take VFS ref only. NFC Refactor the DetectDistro() function to take a single vfs::FileSystem reference only, instead of

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. ARC implicitly marks indirect parameters passed to a function as autoreleasing and passing a block that captures those parameters to another function sometimes causes problems that are

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra created this revision. tra added reviewers: jlebar, rsmith. tra added a subscriber: cfe-commits. Some functions and templates are treated as `__host__` `__device__` even when they don't have explicitly specified target attributes. What's worse, this treatment may change depending on command

[PATCH] D25842: [clang] Limit clang test to ARM only

rengolin added inline comments. Comment at: test/Frontend/gnu-mcount.c:1 +// REQUIRES: arm-registered-target + If you have ARM but not AArch64, this test will also fail. Can you use AND on REQUIRES? https://reviews.llvm.org/D25842

[PATCH] D25696: [Driver] Parse Debian version as integer when possible. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL284770: [Driver] Parse Debian version as integer when possible. NFC (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25696?vs=75269=75345#toc Repository: rL LLVM

[PATCH] D25819: [Driver] Refactor DetectDistro() parameters to take VFS ref only. NFC

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Very nice! LGTM https://reviews.llvm.org/D25819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284770 - [Driver] Parse Debian version as integer when possible. NFC

Author: mgorny Date: Thu Oct 20 15:13:35 2016 New Revision: 284770 URL: http://llvm.org/viewvc/llvm-project?rev=284770=rev Log: [Driver] Parse Debian version as integer when possible. NFC Replace the string matching for /etc/debian_version with split integer/string matching algorithm. When the

[PATCH] D25696: [Driver] Parse Debian version as integer when possible. NFC

mgorny added a comment. Thanks for the review. I'll now look into updating the code for other distros to follow suit. https://reviews.llvm.org/D25696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25842: [clang] Limit clang test to ARM only

mgrang created this revision. mgrang added reviewers: abdulras, honggyu.kim. mgrang added a subscriber: cfe-commits. mgrang added a project: clang-c. Herald added subscribers: rengolin, aemerson. Limit clang/test/Frontend/gnu-mcount.c to ARM only. https://reviews.llvm.org/D25842 Files:

[PATCH] D25696: [Driver] Parse Debian version as integer when possible. NFC

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D25696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25839: Removed unused function argument. NFC.

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. https://reviews.llvm.org/D25839 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp Index: lib/Sema/SemaDecl.cpp

[PATCH] D25838: [Fuchsia] Support for additional architectures

phosek created this revision. phosek added a reviewer: rsmith. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. Herald added a subscriber: aemerson. Fuchsia also experimentally supports ARM32 architecture, add it to the list of supported targets.

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

sebpop added a comment. In https://reviews.llvm.org/D24991#571056, @hiraditya wrote: > Marshall suggests using macro as we discussed offline. For some reason the > reply does not appear here: > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161010/173780.html Ping. Repository:

[PATCH] D25813: [CodeGen] Devirtualize calls to methods marked final in a derived class

This revision was automatically updated to reflect the committed changes. Closed by commit rL284766: [CodeGen] Devirtualize calls to methods marked final in a derived class (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25813?vs=75266=75331#toc Repository: rL LLVM

r284766 - [CodeGen] Devirtualize calls to methods marked final in a derived class

Author: vedantk Date: Thu Oct 20 13:44:14 2016 New Revision: 284766 URL: http://llvm.org/viewvc/llvm-project?rev=284766=rev Log: [CodeGen] Devirtualize calls to methods marked final in a derived class If we see a virtual method call to Base::foo() but can infer that the object is an instance of

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

alexshap added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:149 BugReporter ) const { MatchFinder F; Callback CB(this, BR, AM.getAnalysisDeclContext(D));

r284761 - [c++1z] Fix assertion failure when using the wrong number of bindings for a

Author: rsmith Date: Thu Oct 20 13:29:25 2016 New Revision: 284761 URL: http://llvm.org/viewvc/llvm-project?rev=284761=rev Log: [c++1z] Fix assertion failure when using the wrong number of bindings for a struct with unnamed bitfields. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

[PATCH] D25806: Module: correctly set the module file kind when emitting diagnostics for file_modified

manmanren updated this revision to Diff 75326. manmanren added a comment. Thanks Richard for the testing case. It is also obvious from the testing case that we can have another diagnostic in flight when emitting err_fe_pch_file_modified. https://reviews.llvm.org/D25806 Files:

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

NoQ added a comment. Ouch, i think i forgot about `OSNumber`, including tests. Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:111 + QualType ObjT = (IsCpp || IsObjC) + ? Obj->getType().getCanonicalType().getUnqualifiedType() +

r284754 - Add more doxygen comments to emmintrin.h's intrinsics.

Author: kromanova Date: Thu Oct 20 12:59:15 2016 New Revision: 284754 URL: http://llvm.org/viewvc/llvm-project?rev=284754=rev Log: Add more doxygen comments to emmintrin.h's intrinsics. With this patch, 75% of the intrinsics in this file will be documented now. The patches for the rest of the

[PATCH] D25813: [CodeGen] Devirtualize calls to methods marked final in a derived class

rjmccall added a comment. Looks great to me, thanks. https://reviews.llvm.org/D25813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284753 - [c++1z] Teach composite pointer type computation how to compute the composite

Author: rsmith Date: Thu Oct 20 12:57:33 2016 New Revision: 284753 URL: http://llvm.org/viewvc/llvm-project?rev=284753=rev Log: [c++1z] Teach composite pointer type computation how to compute the composite pointer type of two function pointers with different noexcept specifications. While I'm

[PATCH] D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D25012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

NoQ added a reviewer: zaks.anna. NoQ added a comment. Ping!~ Did my idea sound completely wrong to you? :) Does https://reviews.llvm.org/D25660 depend on this patch? And/or did you find another workaround? https://reviews.llvm.org/D22374 ___

[PATCH] D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast

mgehre added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25 - Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this); + std::vector Rules{"type", "type.1", "cppcoreguidelines-pro-type-reinterpret-cast"}; +

[PATCH] D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.

rnk added inline comments. Comment at: test/CodeGen/avx512-kconstraints-att_inline_asm.c:6 +void mask_Yk_i8(char msk){ +//CHECK: #APP +//CHECK: vpaddb %xmm1, %xmm0, %xmm1 {%k1} The LLVM IR won't have #APP markers in it. Does this test really pass?

[PATCH] D20811: [analyzer] Model some library functions

dcoughlin added a comment. In https://reviews.llvm.org/D20811#575521, @NoQ wrote: > I thought to give it a pause to take a fresh look at how to arrange the > macro-hints in the summaries. > > Maybe something like that: > > CASE > ARGUMENT_CONDITION(ARG_NO(0), OutOfRange) >

r284749 - [clang-cl] Fix test that shouldn't be running on non-x86

Author: rengolin Date: Thu Oct 20 12:41:08 2016 New Revision: 284749 URL: http://llvm.org/viewvc/llvm-project?rev=284749=rev Log: [clang-cl] Fix test that shouldn't be running on non-x86 The clang-cl test required x86-registered-target but it defaulted to the host's triple and AArch64 still

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

rjmccall added a comment. The fact that this bug only arises when performing a *second* instantiation suggests that there's a deeper bug here, because template instantiation is not supposed to modify the pattern AST. In this case, the basic problem is that, when the parser processes a

RE: [PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

+ Tom Matt Thanks Ettore. I think OpenCL is subject to the same issue, and noduplicate does not help either. Basically if a function A directly or indirectly calls a convergent function e.g. barrier, function A itself must also be marked as convergent, otherwise optimization passes may

[PATCH] D20811: [analyzer] Model some library functions

NoQ marked 9 inline comments as done. NoQ added a comment. I thought to give it a pause to take a fresh look at how to arrange the macro-hints in the summaries. Maybe something like that: CASE ARGUMENT_CONDITION(ARG_NO(0), OutOfRange) RANGE('0', '9') RANGE('A', 'Z')

[PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

This revision was automatically updated to reflect the committed changes. Closed by commit rL284742: [clang-tidy] Add check 'readability-redundant-member-init' (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D24339?vs=74769=75311#toc Repository: rL LLVM

[clang-tools-extra] r284742 - [clang-tidy] Add check 'readability-redundant-member-init'

Author: malcolm.parsons Date: Thu Oct 20 11:08:03 2016 New Revision: 284742 URL: http://llvm.org/viewvc/llvm-project?rev=284742=rev Log: [clang-tidy] Add check 'readability-redundant-member-init' Summary: The check emits a warning if a member-initializer calls the member's default constructor

[clang-tools-extra] r284737 - Use auto in for loop

Author: malcolm.parsons Date: Thu Oct 20 10:40:34 2016 New Revision: 284737 URL: http://llvm.org/viewvc/llvm-project?rev=284737=rev Log: Use auto in for loop Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultCheck.cpp Modified:

Re: [PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

Hello guys, >> Should we deprecate noduplicate then as convergent should cover both use >> cases for OpenCL I believe? As far as I understand noduplicate was added >> specifically for SPMD use cases... > > noduplicate has different semantics than convergent. Although it is proposed > for SPMD

[PATCH] D25769: [clang-tidy] Simplify modernize-use-default

This revision was automatically updated to reflect the committed changes. Closed by commit rL284735: [clang-tidy] Simplify modernize-use-default (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D25769?vs=75140=75307#toc Repository: rL LLVM

[PATCH] D25828: Implement part of P0031; adding `constexpr` to `move_iterator`

mclow.lists added inline comments. Comment at: include/iterator:1559 struct __libcpp_is_trivial_iterator - : public _LIBCPP_BOOL_CONSTANT(is_pointer<_Iter>::value) {}; - +: public _LIBCPP_BOOL_CONSTANT(is_pointer<_Iter>::value) {}; + These

[PATCH] D25828: Implement part of P0031; adding `constexpr` to `move_iterator`

mclow.lists created this revision. mclow.lists added reviewers: EricWF, lefticus, AntonBikineev. mclow.lists added a subscriber: cfe-commits. This just does the `move_iterator` bits of http://wg21.link/P0031 - not any of the other parts. This duplicates some (but not all) of the work that was

[PATCH] D22712: Remove FileEntry copy-constructor

bkramer accepted this revision. bkramer added a comment. GCC 4.7 is dead. Go ahead if it compiles. https://reviews.llvm.org/D22712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

On Thu, Oct 20, 2016 at 11:02 AM, David Blaikie wrote: > If we issue a fixit we should recover as-if the code was written with the > fixit in. Does this code do that? That's a good point; I don't think this patch does the fix. > (can we test it? I know we test some > fixits

r284732 - [Format] Cleanup after replacing constructor body with = default

Author: malcolm.parsons Date: Thu Oct 20 09:58:45 2016 New Revision: 284732 URL: http://llvm.org/viewvc/llvm-project?rev=284732=rev Log: [Format] Cleanup after replacing constructor body with = default Summary: Remove colon and commas after replacing constructor body with = default. Fix

[PATCH] D25768: [Format] Cleanup after replacing constructor body with = default

This revision was automatically updated to reflect the committed changes. Closed by commit rL284732: [Format] Cleanup after replacing constructor body with = default (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D25768?vs=75138=75299#toc Repository: rL

[libcxx] r284731 - Adding a missing constexpr test for reverse_iterator operator[].

Author: marshall Date: Thu Oct 20 09:57:34 2016 New Revision: 284731 URL: http://llvm.org/viewvc/llvm-project?rev=284731=rev Log: Adding a missing constexpr test for reverse_iterator operator[]. Modified:

[PATCH] D22712: Remove FileEntry copy-constructor

alexshap added a comment. i see, thanks. So do i understand correctly that we can proceed with this patch ? https://reviews.llvm.org/D22712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22712: Remove FileEntry copy-constructor

vsk added a comment. I believe gcc 4.7 and msvc 2013 are now unsupported (see e.g r284729). https://reviews.llvm.org/D22712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

If we issue a fixit we should recover as-if the code was written with the fixit in. Does this code do that? (can we test it? I know we test some fixits - not sure it's necessary/worthwhile to test them all, but maybe we have a good idiom for testing that the recovery is correct) On Thu, Oct 20,

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

aaron.ballman added inline comments. Comment at: test/SemaObjC/format-strings-objc.m:299 + NSLog([self str: @"%@ %@"], @"name"); // expected-warning {{more '%' conversions than data arguments}} +} + Can you add an example showing a positive use case as well?

r284730 - Retire llvm::alignOf in favor of C++11 alignof.

Author: d0k Date: Thu Oct 20 09:27:22 2016 New Revision: 284730 URL: http://llvm.org/viewvc/llvm-project?rev=284730=rev Log: Retire llvm::alignOf in favor of C++11 alignof. No functionality change intended. Modified: cfe/trunk/include/clang/AST/ASTContext.h

[PATCH] D22712: Remove FileEntry copy-constructor

alexshap added a comment. @bkramer ? https://reviews.llvm.org/D22712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284729 - Clean up alignment hacks now that MSVC 2013 and GCC 4.7 are gone.

Author: d0k Date: Thu Oct 20 08:52:26 2016 New Revision: 284729 URL: http://llvm.org/viewvc/llvm-project?rev=284729=rev Log: Clean up alignment hacks now that MSVC 2013 and GCC 4.7 are gone. Modified: cfe/trunk/include/clang/AST/Stmt.h cfe/trunk/include/clang/AST/TemplateBase.h

[PATCH] D25769: [clang-tidy] Simplify modernize-use-default

ioeric accepted this revision. ioeric added inline comments. Comment at: test/clang-tidy/modernize-use-default-copy.cpp:85 + // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: use '= default' + // CHECK-FIXES: /* don't delete */ = default; int Field;

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

kparzysz updated this revision to Diff 75292. kparzysz added a comment. Unxfail these tests on Linux. Repository: rL LLVM https://reviews.llvm.org/D25811 Files: test/std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp

[PATCH] D25769: [clang-tidy] Simplify modernize-use-default

djasper accepted this revision. djasper added a reviewer: djasper. djasper added a comment. I don't know whether it is an intentional choice to remove this comment. I'd be fine either way (I think there are arguments for and against it). So, this looks good to me. But maybe Eric has something

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

kparzysz added a comment. In https://reviews.llvm.org/D25811#575105, @EricWF wrote: > Seems like we should figure out why these pass on ToT OS X. All of them have // XFAIL: with_system_cxx_lib=x86_64-apple-darwin11 // XFAIL: with_system_cxx_lib=x86_64-apple-darwin12 Maybe that's it. I don't

[PATCH] D25363: [Sema] Store a SourceRange for multi-token builtin types

aaron.ballman added inline comments. Comment at: include/clang/AST/TypeLoc.h:533 +} else { + BuiltinRange.setBegin(std::min(Range.getBegin(), BuiltinRange.getBegin())); + BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd()));

[PATCH] D25769: [clang-tidy] Simplify modernize-use-default

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small nit, but you may want to wait for @djasper to weigh in on the removed comment question. Comment at:

[PATCH] D25816: Use descriptive message if list initializer is incorrectly parenthesized.

arphaman added a comment. Thanks for working on this! I have a couple of comments: Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1762 def err_init_incomplete_type : Error<"initialization of incomplete type %0">; +def err_list_init_in_parens : Error<"list-initializer

[PATCH] D25363: [Sema] Store a SourceRange for multi-token builtin types

malcolm.parsons added inline comments. Comment at: include/clang/AST/TypeLoc.h:533 +} else { + BuiltinRange.setBegin(std::min(Range.getBegin(), BuiltinRange.getBegin())); + BuiltinRange.setEnd(std::max(Range.getEnd(), BuiltinRange.getEnd())); I

[PATCH] D25747: [clang-tidy] Fix an assertion failure in cppcoreguidelines-pro-type-member-init.

hokein added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30 +AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) { + return Node.hasDefaultConstructor(); aaron.ballman wrote: > I think this should be a public AST matcher

  1   2   >