r284956 - [AVX-512] Replace 64-bit element and 512-bit vector pmin/pmax builtins with native IR like we do for 128/256-bit, but with the addition of masking.

Author: ctopper Date: Sun Oct 23 23:04:24 2016 New Revision: 284956 URL: http://llvm.org/viewvc/llvm-project?rev=284956=rev Log: [AVX-512] Replace 64-bit element and 512-bit vector pmin/pmax builtins with native IR like we do for 128/256-bit, but with the addition of masking. Modified:

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar added a comment. Friendly ping? https://reviews.llvm.org/D25403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284954 - [AVX-512] Replace masked 128/256-bit byte, word, and dword min/max builtins with selects and the older unmasked builtins.

Author: ctopper Date: Sun Oct 23 18:57:30 2016 New Revision: 284954 URL: http://llvm.org/viewvc/llvm-project?rev=284954=rev Log: [AVX-512] Replace masked 128/256-bit byte, word, and dword min/max builtins with selects and the older unmasked builtins. Modified:

[libcxx] r284952 - Backout enabling -Wshadow until I have time to fix the breakage

Author: ericwf Date: Sun Oct 23 17:24:11 2016 New Revision: 284952 URL: http://llvm.org/viewvc/llvm-project?rev=284952=rev Log: Backout enabling -Wshadow until I have time to fix the breakage Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py

[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

mgehre added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2509 +to suppress specific clang-tidy warnings. They can be attached to a scope, +statement or type. The ``[[gsl::suppress]]`` is an alias of ``[[clang::suppress]]`` +which is intended to be used for

[libunwind] r284951 - [libunwind] Add support for Fuchsia

Author: phosek Date: Sun Oct 23 16:48:47 2016 New Revision: 284951 URL: http://llvm.org/viewvc/llvm-project?rev=284951=rev Log: [libunwind] Add support for Fuchsia Fuchsia is a new operating system which uses libunwind as unwinder. Differential Revision: https://reviews.llvm.org/D25899

[libcxx] r284950 - [libcxx] Use C++14 when building libc++ with musl

Author: phosek Date: Sun Oct 23 16:48:27 2016 New Revision: 284950 URL: http://llvm.org/viewvc/llvm-project?rev=284950=rev Log: [libcxx] Use C++14 when building libc++ with musl musl's pthread implementations use volatile types in their structs which is not being constexpr in C++11 but is in

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

This revision was automatically updated to reflect the committed changes. Closed by commit rL284950: [libcxx] Use C++14 when building libc++ with musl (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25491?vs=75553=75554#toc Repository: rL LLVM

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

phosek updated this revision to Diff 75553. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -325,6 +325,11 @@ # Required flags

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:422 // Set up the per-function pass manager. + FPM.add(new TargetLibraryInfoWrapperPass(*TLII)); if (CodeGenOpts.VerifyModule) This seems unnecessary? Repository: rL LLVM

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

mehdi_amini updated this revision to Diff 75552. mehdi_amini added a comment. Use a separate enum to described OSLogBufferLayout header flags https://reviews.llvm.org/D25888 Files: clang/include/clang/Analysis/Analyses/FormatString.h clang/include/clang/Analysis/Analyses/OSLog.h

r284947 - Remove LLVM_CONSTEXPR.

Author: jlebar Date: Sun Oct 23 14:39:16 2016 New Revision: 284947 URL: http://llvm.org/viewvc/llvm-project?rev=284947=rev Log: Remove LLVM_CONSTEXPR. Summary: With MSVC 2013 and GCC < 4.8 gone, we can use the "constexpr" keyword. Reviewers: bkramer, mehdi_amini Subscribers: llvm-commits

[libcxx] r284946 - Fix breakage introduced by adding -Wshadow.

Author: ericwf Date: Sun Oct 23 14:26:39 2016 New Revision: 284946 URL: http://llvm.org/viewvc/llvm-project?rev=284946=rev Log: Fix breakage introduced by adding -Wshadow. Modified: libcxx/trunk/include/list Modified: libcxx/trunk/include/list URL:

[libcxx] r284945 - Fix libc++ specific assertion in permissions(...) tests

Author: ericwf Date: Sun Oct 23 14:14:58 2016 New Revision: 284945 URL: http://llvm.org/viewvc/llvm-project?rev=284945=rev Log: Fix libc++ specific assertion in permissions(...) tests Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.permissions/permissions.pass.cpp

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

koriakin updated this revision to Diff 75550. koriakin added a comment. Added a comment explaining the reason. Repository: rL LLVM https://reviews.llvm.org/D21737 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

djasper added a comment. Generally, always upload diffs with the full file as context to phabricator. That way, it is easier to see how the diff fits into the rest of the file. Thanks for fixing this!! Comment at: lib/Format/FormatTokenLexer.cpp:528 FormatTok->TokenText

[libcxx] r284944 - Turn on -Wshadow so I find occurances before STL does

Author: ericwf Date: Sun Oct 23 14:01:10 2016 New Revision: 284944 URL: http://llvm.org/viewvc/llvm-project?rev=284944=rev Log: Turn on -Wshadow so I find occurances before STL does Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL:

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

koriakin added a comment. In https://reviews.llvm.org/D21737#468861, @mehdi_amini wrote: > Missing test. This is tested by https://reviews.llvm.org/D21741 (along with https://reviews.llvm.org/D21736). Repository: rL LLVM https://reviews.llvm.org/D21737

[PATCH] D25853: [libcxx] [test] Fix non-Standard make_from_tuple() tests.

EricWF closed this revision. EricWF added a comment. r284943. https://reviews.llvm.org/D25853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r284943 - Make make_from_tuple tests more portable. Patch from s...@microsoft.com

Author: ericwf Date: Sun Oct 23 13:55:51 2016 New Revision: 284943 URL: http://llvm.org/viewvc/llvm-project?rev=284943=rev Log: Make make_from_tuple tests more portable. Patch from s...@microsoft.com Modified:

[PATCH] D25853: [libcxx] [test] Fix non-Standard make_from_tuple() tests.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Only scrubs don't have commit access (and don't get no love). https://reviews.llvm.org/D25853 ___ cfe-commits mailing list

[PATCH] D25851: [libcxx] [test] Fix unreferenced formal parameter warnings.

EricWF closed this revision. EricWF added a comment. r284942. https://reviews.llvm.org/D25851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r284942 - Fix unreferenced parameters. Patch from s...@microsoft.com

Author: ericwf Date: Sun Oct 23 13:52:58 2016 New Revision: 284942 URL: http://llvm.org/viewvc/llvm-project?rev=284942=rev Log: Fix unreferenced parameters. Patch from s...@microsoft.com Modified:

[PATCH] D25851: [libcxx] [test] Fix unreferenced formal parameter warnings.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Get commit access! https://reviews.llvm.org/D25851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25852: [libcxx] [test] Fix shadow warnings.

EricWF closed this revision. EricWF added a comment. r284941. https://reviews.llvm.org/D25852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r284941 - Fix shadowing warning. Patch from s...@microsoft.com

Author: ericwf Date: Sun Oct 23 13:47:58 2016 New Revision: 284941 URL: http://llvm.org/viewvc/llvm-project?rev=284941=rev Log: Fix shadowing warning. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.assign/emplace.pass.cpp

[PATCH] D25852: [libcxx] [test] Fix shadow warnings.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Y'all need to get commit access :-P https://reviews.llvm.org/D25852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25898: [clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()

Prazek added inline comments. Comment at: test/clang-tidy/modernize-make-shared.cpp:122 + Pderived = std::shared_ptr(new Derived()); + // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: use std::make_shared instead + // CHECK-FIXES: Pderived = std::make_shared();

[PATCH] D25898: [clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()

malcolm.parsons added inline comments. Comment at: test/clang-tidy/modernize-make-shared.cpp:122 + Pderived = std::shared_ptr(new Derived()); + // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: use std::make_shared instead + // CHECK-FIXES: Pderived = std::make_shared();

[PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

Prazek added a comment. Richard? https://reviews.llvm.org/D21502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

Prazek added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-transparent-functors.rst:12 + .. code-block:: c++ + +// Non-transparent functor Say somewhere that you also handle cases like std::less(arg1, arg2) because from this

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

Prazek added inline comments. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:70 +static const StringRef Message = +"prefer transparent functors (aka diamond operators)"; + The message would be much better if you would put the name of this

[PATCH] D25898: [clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()

Prazek added a comment. Besides this looks good Comment at: test/clang-tidy/modernize-make-shared.cpp:122 + Pderived = std::shared_ptr(new Derived()); + // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: use std::make_shared instead + // CHECK-FIXES: Pderived =

r284936 - [AVX-512] Replace 512-bit pmovzx/sx builtins with native IR.

Author: ctopper Date: Sun Oct 23 02:35:47 2016 New Revision: 284936 URL: http://llvm.org/viewvc/llvm-project?rev=284936=rev Log: [AVX-512] Replace 512-bit pmovzx/sx builtins with native IR. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/lib/Headers/avx512bwintrin.h

r284935 - [AVX-512] Remove masked 128/256-bit packss/packus builtins and replace with selects and the older unmasked builtins.

Author: ctopper Date: Sun Oct 23 02:35:39 2016 New Revision: 284935 URL: http://llvm.org/viewvc/llvm-project?rev=284935=rev Log: [AVX-512] Remove masked 128/256-bit packss/packus builtins and replace with selects and the older unmasked builtins. Modified:

[PATCH] D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.

mharoush added inline comments. Comment at: test/CodeGen/avx512-kconstraints-att_inline_asm.c:6 +void mask_Yk_i8(char msk){ +//CHECK: #APP +//CHECK: vpaddb %xmm1, %xmm0, %xmm1 {%k1} rnk wrote: > The LLVM IR won't have #APP markers in it. Does this test really

r284934 - Add more doxygen comments to emmintrin.h's intrinsics.

Author: kromanova Date: Sun Oct 23 02:30:50 2016 New Revision: 284934 URL: http://llvm.org/viewvc/llvm-project?rev=284934=rev Log: Add more doxygen comments to emmintrin.h's intrinsics. With this patch, all intrinsics in this file (with an exception of a handful of a recently added ones) will

[PATCH] D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.

mharoush set the repository for this revision to rL LLVM. mharoush updated this revision to Diff 75542. mharoush added a comment. Only test affected(correct version this time: checking LLVM IR instead of x86 asm), This test depends on D25012 being applied.

[PATCH] D25898: [clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()

malcolm.parsons updated this revision to Diff 75541. malcolm.parsons added a comment. Correct operator signature. Remove unused parameter. Rename method. Reformat. https://reviews.llvm.org/D25898 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h