Hahnfeld added a comment.
any progress?
https://reviews.llvm.org/D22452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
gentle ping
https://reviews.llvm.org/D25669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285176: [CodeGen] Don't emit lifetime intrinsics for some
local variables (authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D24693?vs=74814&id=75832#toc
Repository:
rL LLVM
Author: vitalybuka
Date: Wed Oct 26 00:42:30 2016
New Revision: 285176
URL: http://llvm.org/viewvc/llvm-project?rev=285176&view=rev
Log:
[CodeGen] Don't emit lifetime intrinsics for some local variables
Summary:
Current generation of lifetime intrinsics does not handle cases like:
```
{
ch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285175: [AVX-512] Fix the operand order for all calls to
__builtin_ia32_vfmaddss3_mask. (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D25902?vs=75557&id=75830#toc
Repository:
Author: ctopper
Date: Wed Oct 26 00:35:38 2016
New Revision: 285175
URL: http://llvm.org/viewvc/llvm-project?rev=285175&view=rev
Log:
[AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.
Summary: The preserved input should be the first argument and the vector inputs
sh
jlebar added a comment.
Doesn't look like we changed any testcases when we changed this behavior? The
change in behavior may be unobservable, but even still it seems worthwhile to
have tests that check that we're not doing any of the alternatives we
considered.
Comment at:
jlebar added a comment.
Is it possible to write a testcase for the using-declaration change?
https://reviews.llvm.org/D25809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ruiu
Date: Tue Oct 25 22:38:48 2016
New Revision: 285162
URL: http://llvm.org/viewvc/llvm-project?rev=285162&view=rev
Log:
Use printf instead of "echo -ne".
Not all echo commands support "-e".
Modified:
cfe/trunk/test/Driver/response-file-extra-whitespace.c
Modified: cfe/trunk/test/
mlemay-intel abandoned this revision.
mlemay-intel added a comment.
I was able to setup a temporary thread control block early enough in musl libc
initialization to obviate the need for an attribute like runtime_init.
https://reviews.llvm.org/D19853
__
Author: rsmith
Date: Tue Oct 25 21:31:56 2016
New Revision: 285160
URL: http://llvm.org/viewvc/llvm-project?rev=285160&view=rev
Log:
[modules] Fix assert if multiple update records provide a definition for a
class template specialization and that specialization has attributes.
Modified:
cfe/t
Author: inglorion
Date: Tue Oct 25 17:19:32 2016
New Revision: 285132
URL: http://llvm.org/viewvc/llvm-project?rev=285132&view=rev
Log:
[codeview] emit debug info for indirect virtual base classes
Summary:
Fixes PR28281.
MSVC lists indirect virtual base classes in the field list of a class.
This
itessier created this revision.
itessier added a subscriber: cfe-commits.
https://reviews.llvm.org/D16552 implemented the likely resolution of core issue
253, but didn't include support for class based array fields. E.g.:
struct A {
}
struct B {
A a[2];
}
const B b; // Fails, but should p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285132: [codeview] emit debug info for indirect virtual base
classes (authored by inglorion).
Changed prior to commit:
https://reviews.llvm.org/D25579?vs=75381&id=75804#toc
Repository:
rL LLVM
https
jlebar added a comment.
In https://reviews.llvm.org/D25640#579238, @tra wrote:
> I'm OK with the change, but the comments suggest that things may be more
> complicated.
> How about disabling assert for CUDA only?
I don't think that is the right approach. This function has nothing to do with
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285158: [CodeGen] Move shouldEmitLifetimeMarkers into more
convenient place (authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D24695?vs=72908&id=75827#toc
Repository:
rL LLV
Author: vitalybuka
Date: Tue Oct 25 21:00:00 2016
New Revision: 285159
URL: http://llvm.org/viewvc/llvm-project?rev=285159&view=rev
Log:
[Sema] Handle CaseStmt and DefaultStmt as SwitchCase
Summary: rsmith
Differential Revision: https://reviews.llvm.org/D25665
Modified:
cfe/trunk/lib/Sema/J
Author: vitalybuka
Date: Tue Oct 25 20:59:57 2016
New Revision: 285158
URL: http://llvm.org/viewvc/llvm-project?rev=285158&view=rev
Log:
[CodeGen] Move shouldEmitLifetimeMarkers into more convenient place
Summary: D24693 will need access to it from other places
Reviewers: eugenis
Subscribers: c
Author: rsmith
Date: Tue Oct 25 20:37:36 2016
New Revision: 285154
URL: http://llvm.org/viewvc/llvm-project?rev=285154&view=rev
Log:
[cxx_status] update comment
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk
Committed as r285152.
On Tue, Oct 25, 2016 at 3:09 PM, Richard Smith
wrote:
> Missed one change from the test suite:
>
> Index: test/Modules/cstd.m
> ===
> --- test/Modules/cstd.m (revision 285117)
> +++ test/Modules/cstd.m (working
Author: rsmith
Date: Tue Oct 25 20:08:55 2016
New Revision: 285152
URL: http://llvm.org/viewvc/llvm-project?rev=285152&view=rev
Log:
Treat module headers wrapped by our builtin headers as implicitly being textual
headers. We previously got this check backwards and treated the wrapper header
as bei
mclow.lists added a comment.
Looks better than before.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Oct 25 20:05:54 2016
New Revision: 285150
URL: http://llvm.org/viewvc/llvm-project?rev=285150&view=rev
Log:
Implement name mangling proposal for exception specifications from cxx-abi-dev
2016-10-11.
This has the following ABI impact:
1) Functions whose parameter or ret
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
jordan_rose marked an inline comment as done.
jordan_rose added a comment.
Oops. Ignore the API notes file, which is only in Swift's branch of Clang right
now.
Repository:
rL LLVM
https://reviews.llvm.org/D25850
___
cfe-commits mailing list
cfe-
Author: dougk
Date: Tue Oct 25 18:59:11 2016
New Revision: 285144
URL: http://llvm.org/viewvc/llvm-project?rev=285144&view=rev
Log:
[Myriad] add empty file to simulated bin dir
Added:
cfe/trunk/test/Driver/Inputs/basic_myriad_tree/bin/
cfe/trunk/test/Driver/Inputs/basic_myriad_tree/bin/.k
jordan_rose retitled this revision from "[WIP] Accept nullability annotations
(_Nullable) on array parameters" to "Accept nullability annotations (_Nullable)
on array parameters".
jordan_rose updated the summary for this revision.
jordan_rose updated this revision to Diff 75820.
jordan_rose added
ahatanak updated this revision to Diff 75819.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Skip the step to correct typo if ParseInitializer returns ExprError(). Add a
test case that exercises the change.
https://reviews.llvm.org/D25206
Files:
lib/Parse/ParseExprCXX.c
tra added a comment.
I'm OK with the change, but the comments suggest that things may be more
complicated.
How about disabling assert for CUDA only?
https://reviews.llvm.org/D25640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
dcoughlin added a comment.
Are the parameter types actually needed? I think in general the rest of the
analyzer uses arity alone.
Is the idea to allow for overloads in C++? If so, then I think this
equivalent-up-to-size-and-sign approach will disallow those overloads.
Commen
tra updated this revision to Diff 75816.
tra added a comment.
- handle using declarations found in the overload set we check.
https://reviews.llvm.org/D25809
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaDecl.cpp
lib/Sem
tra updated this revision to Diff 75812.
tra added a comment.
- Instead of relying on the first attribute we find, check all matching ones.
- Specializations inherit their target attributes from their base template
only. Their effective target always matches that of the template and is no
longer
On 10/18/16 22:13, Brad Smith via cfe-commits wrote:
On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote:
On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote:
Author: emaste
Date: Fri Oct 14 12:59:53 2016
New Revision: 284256
URL: http://llvm.org/vie
ping
On Mon, Oct 17, 2016 at 5:57 PM, Kostya Serebryany wrote:
> Did you code-review this?
> (sorry if I missed it)
>
> On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: dougk
>> Date: Fri Oct 14 14:55:09 2016
>> New Revision: 2
Author: dougk
Date: Tue Oct 25 18:02:30 2016
New Revision: 285140
URL: http://llvm.org/viewvc/llvm-project?rev=285140&view=rev
Log:
[Myriad] Find libc++ adjacent to libstdc++
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/myriad-tool
jordan_rose added a comment.
> `_Nonnull` in this position seems very similar to `static` (which typically
> also implies non-nullness).
I wasn't actually sure if it was okay to assume this, but the standard does
seem pretty clear:
> If the keyword `static` also appears within the `[` and `]`
zaks.anna added inline comments.
Comment at: test/Analysis/CFNumber.c:39
+ unsigned char scalar = 0;
+ CFNumberGetValue(x, kCFNumberSInt16Type, &scalar); // expected-warning{{A
CFNumber object that represents a 16-bit integer is used to initialize an 8-bit
integer; 8 bits of
mehdi_amini added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
rsmith wrote:
> ahatanak wrote:
> > mehdi_amini wrote:
> > > What happens when t
rsmith added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
ahatanak wrote:
> mehdi_amini wrote:
> > What happens when there is no typo correctio
ahatanak added reviewers: bruno, erik.pilkington, majnemer.
ahatanak added a comment.
Add more reviewers.
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Hello,
> As far as I understand the whole problem is that the optimized functions are
> marked by __attribute__((pure)). If the attribute is removed from your
> example, we get LLVM dump preserving correctness:
>
> define i32 @bar(i32 %x) local_unnamed_addr #0 {
> entry:
> %call = tail call i3
Missed one change from the test suite:
Index: test/Modules/cstd.m
===
--- test/Modules/cstd.m (revision 285117)
+++ test/Modules/cstd.m (working copy)
@@ -1,5 +1,5 @@
// RUN: rm -rf %t
-// RUN: %clang_cc1 -fsyntax-only -isystem %S/In
This was a thinko on my part: clang's builtin headers include_next the
system headers, not the other way around, so the system headers should be
implicitly textual, not clang's headers. This patch fixes the problem for
me with glibc. Does this help for Darwin too?
On Tue, Oct 25, 2016 at 2:01 PM,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285127: Use linker flag --fix-cortex-a53-843419 on Android
ARM64 compilation. (authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D25761?vs=75174&id=75801#toc
Repository:
rL LLVM
Author: srhines
Date: Tue Oct 25 16:44:35 2016
New Revision: 285127
URL: http://llvm.org/viewvc/llvm-project?rev=285127&view=rev
Log:
Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.
Summary:
This is only forced on if there is no non-Cortex-A53 CPU specified as
well. Android'
Author: compnerd
Date: Tue Oct 25 16:43:28 2016
New Revision: 285126
URL: http://llvm.org/viewvc/llvm-project?rev=285126&view=rev
Log:
CodeGen: be more conservative about setting section
The section names currently are MachO specific. Only set the section on the
variables if the file format is M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285125: [OpenCL] Add missing atom_xor for 64 bit to
opencl-c.h (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25954?vs=75740&id=75797#toc
Repository:
rL LLVM
https://review
Author: yaxunl
Date: Tue Oct 25 16:37:05 2016
New Revision: 285125
URL: http://llvm.org/viewvc/llvm-project?rev=285125&view=rev
Log:
[OpenCL] Add missing atom_xor for 64 bit to opencl-c.h
Differential Revision: https://reviews.llvm.org/D25954
Modified:
cfe/trunk/lib/Headers/opencl-c.h
Modif
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:94
+ else if (isa(RS)) {
+// FIXME: Presence of an IVar region has priority over this branch, because
+// ObjC objects are on the heap even if the core doesn't realize this.
---
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: akirtzidis
Date: Tue Oct 25 16:11:22 2016
New Revision: 285120
URL: http://llvm.org/viewvc/llvm-project?rev=285120&view=rev
Log:
[index] Fixes for locations and relations in Objective C categories and
getters/setters
- Add entries for protocols on categories
- Add relation between catego
On Mon, Oct 24, 2016 at 4:58 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith
> wrote:
> > On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes
> > wrote:
> >>
> >> > Sure, go ahead.
> >>
> >> I committed in r284797 and
Author: ericwf
Date: Tue Oct 25 15:45:17 2016
New Revision: 285117
URL: http://llvm.org/viewvc/llvm-project?rev=285117&view=rev
Log:
Fix nullptr tests
Modified:
libcxx/trunk/include/__nullptr
libcxx/trunk/test/std/language.support/support.types/nullptr_t.pass.cpp
Modified: libcxx/trunk/i
mgorny added a reviewer: beanz.
mgorny added a subscriber: beanz.
mgorny added a comment.
@beanz, could you also look at this one? I'd like to replace
CLANG_LIBDIR_SUFFIX with the runtimes suffix, and for this I'd have to get rid
of this CLANG_LIBDIR_SUFFIX occurrence as well. However, I don't t
Author: ericwf
Date: Tue Oct 25 15:07:49 2016
New Revision: 285107
URL: http://llvm.org/viewvc/llvm-project?rev=285107&view=rev
Log:
Get libc++abi building with LLVM_ENABLE_MODULES
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/src/CMakeLists.txt
URL:
http://llvm.org
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499
case Type::Adjusted:
- case Type::Decayed:
+ case Type::Decayed: {
// Decayed and adjusted types use the adjusted type in LLVM and DWARF.
-return CreateType(
-cast(cast(Ty)->get
Author: ericwf
Date: Tue Oct 25 14:44:38 2016
New Revision: 285102
URL: http://llvm.org/viewvc/llvm-project?rev=285102&view=rev
Log:
Update revision number in CHANGELOG.TXT
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT
URL:
http://llvm.org/viewvc/
Author: ericwf
Date: Tue Oct 25 14:43:44 2016
New Revision: 285101
URL: http://llvm.org/viewvc/llvm-project?rev=285101&view=rev
Log:
[libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions
from the dylib
Summary:
This patch turns on `-fvisibility-inlines-hidden` when buil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285101: [libcxx] Build with -fvisibility-inlines-hidden --
Remove 20 inline definitions… (authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D25593?vs=75770&id=75772#toc
Repository:
EricWF updated this revision to Diff 75770.
EricWF added a comment.
- Address review comments by adding better documentation in the CHANGELOG.TXT.
https://reviews.llvm.org/D25593
Files:
CMakeLists.txt
lib/abi/CHANGELOG.TXT
lib/abi/x86_64-linux-gnu.abilist
Index: lib/abi/x86_64-linux-gnu.
Author: ericwf
Date: Tue Oct 25 14:33:14 2016
New Revision: 285100
URL: http://llvm.org/viewvc/llvm-project?rev=285100&view=rev
Log:
[libc++] Fix modules build - Rework __refstring definition
Summary:
`__libcpp_refstring` currently has two different definitions. First there is
the complete defi
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
Fairly straightforward: simply removes the parameter names from the unused
parameters.
https://reviews.llvm.org/D25958
Files:
test/support/archetypes.hpp
Index:
Author: epilk
Date: Tue Oct 25 14:05:50 2016
New Revision: 285098
URL: http://llvm.org/viewvc/llvm-project?rev=285098&view=rev
Log:
Reapply r284265: "[Sema] Refactor context checking for availability diagnostics"
The problem with the original commit was that some of Apple's headers depended
on an
NoQ added inline comments.
Comment at: test/Analysis/CFNumber.c:39
+ unsigned char scalar = 0;
+ CFNumberGetValue(x, kCFNumberSInt16Type, &scalar); // expected-warning{{A
CFNumber object that represents a 16-bit integer is used to initialize an 8-bit
integer; 8 bits of the C
jordan_rose added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499
case Type::Adjusted:
- case Type::Decayed:
+ case Type::Decayed: {
// Decayed and adjusted types use the adjusted type in LLVM and DWARF.
-return CreateType(
-cast(cast(Ty)-
sfantao updated this revision to Diff 75741.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix typos and use StringRef() instead of const char * to follow what the
Driver does today when it comes to specify the bound architectures.
https://reviews.llvm.org/D21853
Files:
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, b-sumner.
https://reviews.llvm.org/D25954
Files:
lib/Headers/opencl-c.h
Index: lib/Headers/opencl-c.h
===
--- lib/Headers/op
NoQ updated this revision to Diff 75739.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Consider a lot more dispatch_once_t regions: improve diagnostics for local
structs containing predicates, find ivar structs with predicates.
Address a couple of review comments, discuss the rest.
NoQ added inline comments.
Comment at: test/Analysis/dispatch-once.m:13
+
+void test_stack() {
+ dispatch_once_t once;
dcoughlin wrote:
> Should the tests for dispatch_once in unix-fns.c be moved here?
In fact we need to de-duplicate code with unix.API's pthread
sfantao marked 7 inline comments as done.
sfantao added a comment.
Hi Hal,
Thanks for the review! Comments inlined.
Comment at: include/clang/Driver/Action.h:504
+ /// unbundling action.
+ struct DependingActionInfoTy final {
+/// \brief The tool chain of the depending a
sfantao added a comment.
Hi Hal,
Thanks for the review!
Comment at: lib/Driver/ToolChains.cpp:2854
+ case options::OPT_shared:
+ case options::OPT_static:
+ case options::OPT_fPIC:
hfinkel wrote:
> And also?
>
> case options::OPT_dynamic:
Oh,
sfantao updated this revision to Diff 75732.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix typos and check -dynamic when it comes to translating arguments for
offloading gcc toolchains.
https://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
inc
beanz added a comment.
I think doing just the suffix is the right starting point.
https://reviews.llvm.org/D23752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi Hal,
Thanks for the review! Comments inlined.
Comment at: lib/Driver/Tools.cpp:334
+ LksStream << " OpenMP Offload Linker Script.\n";
+ LksStream << "*/\n";
+ LksStream << "TARGET(binary)\n";
hfinkel wrote:
> We should also say
sfantao updated this revision to Diff 75730.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Address Hal Finkel comments - fix comments/fix linker script comment.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/T
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
AlexeySotkin wrote:
> bader wr
mgorny created this revision.
mgorny added reviewers: bruno, bkramer.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: modocache, beanz.
Refactor the Distro enum along with helper functions into a full-fledged
Distro class, inspired by llvm::Triple, and make it a public API.
The n
labath created this revision.
labath added reviewers: benlangmuir, zturner.
labath added a subscriber: cfe-commits.
NFCI
https://reviews.llvm.org/D25948
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/FileSystemStatCache.cpp
lib/Basic/VirtualFileSystem.cpp
lib/Frontend/ASTUnit.
sfantao updated this revision to Diff 75722.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Fix typos and add test tht checks phases when OpenMP and CUDA are used
simultaneously.
https://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
sfantao added a comment.
Hi Hal,
Thanks for the review! Fixed the typos in the new diff.
Comment at: lib/Driver/Driver.cpp:1949
+SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs));
+
//
hfinkel wrote:
> Since we can have both Open
rjmccall requested changes to this revision.
rjmccall added a comment.
This revision now requires changes to proceed.
There's no reason for this to only consider constant-sized arrays, and you
should use getBaseElementTypeUnsafe() so you look through nested array types.
That method is a no-op o
bruno added a comment.
Hi,
Nice, thanks for working on this!
Comment at: lib/Sema/SemaExpr.cpp:8051
+ if (!LHSVecType) {
+assert(RHSVecType && "RHSVecType is not a vector!");
if (!tryVectorConvertAndSplat(*this, (IsCompAssign ? nullptr : &LHS),
`tryV
mgorny added inline comments.
Comment at: unittests/Driver/ToolChainsTest.cpp:154
+
"BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";));
+ ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem));
+}
bruno wrote:
>
arphaman updated this revision to Diff 75712.
arphaman added a comment.
The updated patch addresses Richard's comment by making sure the fixit isn't
emitted when the destructor call is invalid.
Repository:
rL LLVM
https://reviews.llvm.org/D25817
Files:
lib/Sema/SemaExprCXX.cpp
test/CXX/
Author: mgorny
Date: Tue Oct 25 10:33:32 2016
New Revision: 285076
URL: http://llvm.org/viewvc/llvm-project?rev=285076&view=rev
Log:
[Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older
Disable the OpenSUSE rules for OpenSUSE versions older than 11 as they
are incompatible with the old
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285076: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10
and older (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24954?vs=75704&id=75713#toc
Repository:
rL LLVM
https:
Author: mgorny
Date: Tue Oct 25 10:07:41 2016
New Revision: 285074
URL: http://llvm.org/viewvc/llvm-project?rev=285074&view=rev
Log:
[Driver] Support obtaining active toolchain from gcc-config on Gentoo
Support using gcc-config to determine the correct GCC toolchain location
on Gentoo. In order t
> On 2016-Oct-24, at 21:43, Mehdi AMINI wrote:
>
> mehdi_amini created this revision.
> mehdi_amini added a reviewer: dexonsmith.
> mehdi_amini added a subscriber: cfe-commits.
>
> We're only doing it with -flto currently, however it never "hurt"
> to pass it, and users that are linking without
bruno added a comment.
This is great!
Comment at: unittests/Driver/ToolChainsTest.cpp:154
+
"BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";));
+ ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem));
+}
Can
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
ship it.
https://reviews.llvm.org/D25661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
sdardis updated this revision to Diff 75708.
sdardis marked an inline comment as done.
sdardis added a comment.
Extra testing for cases where the operand on the left of an operation is a
vector.
Removed two spurious checks for vector types.
https://reviews.llvm.org/D25866
Files:
lib/Sema/Sem
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285074: [Driver] Support obtaining active toolchain from
gcc-config on Gentoo (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25661?vs=75707&id=75710#toc
Repository:
rL LLVM
mgorny updated this revision to Diff 75707.
mgorny marked 3 inline comments as done.
mgorny added a comment.
Thanks for the review. Implemented all three suggestions.
https://reviews.llvm.org/D25661
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/gentoo_linux_gcc_multi_version_tree/etc
sfantao added a comment.
Hi Hal,
Thanks for the review!
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:163
+def err_drv_expecting_fopenmp_with_fopenmp_targets : Error<
+ "The option -fopenmp-targets must be used in conjunction with a -fopenmp
option compatible with
Author: compnerd
Date: Tue Oct 25 09:50:44 2016
New Revision: 285073
URL: http://llvm.org/viewvc/llvm-project?rev=285073&view=rev
Log:
CodeGen: mark protocols as common data
This allows for the coalescing of the protocol declarations. When the protocols
are declared in headers, multiple definiti
mgorny planned changes to this revision.
mgorny added inline comments.
Comment at: unittests/Driver/ToolChainsTest.cpp:15
+// FIXME: I presume this is not the correct way of doing this
+#include "../lib/Driver/ToolChains.h"
+#include "clang/Basic/VirtualFileSystem.h"
sfantao updated this revision to Diff 75705.
sfantao marked an inline comment as done.
sfantao added a comment.
- Address Hal Finkel comments - make diagnostic message more informative.
https://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/
mgorny updated this revision to Diff 75704.
mgorny added a comment.
Updated to perform `.startswith()` check before splitting.
https://reviews.llvm.org/D24954
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
==
1 - 100 of 136 matches
Mail list logo