smeenai updated this revision to Diff 78324.
smeenai added a comment.
Moving explanation to comment instead of referencing Phabricator
https://reviews.llvm.org/D26657
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/windows-itanium-dllexport.cpp
Index: test
majnemer added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7683-7685
+// or implicit instantiation. MinGW doesn't allow this. In the implicit
+// instantiation case, we limit clang to only adding dllexport; see the
+// discussion in https://revi
smeenai updated this revision to Diff 78322.
smeenai added a comment.
Limiting to dllexport after discussion with @hans
https://reviews.llvm.org/D26657
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/windows-itanium-dllexport.cpp
Index: test/CodeGenCXX/win
smeenai added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+ Old_TSK == TSK_ImplicitInstantiation) &&
(TSK == TSK_ExplicitInstantiationDefinition ||
DLLImportExplicitInstan
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thank you for the cleanup!!! For bonus points, please add comments to the class
APIs:)
https://reviews.llvm.org/D26773
___
cfe-commits mai
mclow.lists added a comment.
Do these tests pass with the current `` implementation, or will they have
to wait?
Comment at: test/std/utilities/utility/utility.inplace/inplace.pass.cpp:40
-template
-struct CheckRet : std::false_type {};
-template
-struct CheckRet : std::tru
CaseyCarter updated this revision to Diff 78311.
CaseyCarter added a comment.
Remove unused reference variable in any_cast_reference.pass.cpp.
https://reviews.llvm.org/D26782
Files:
test/std/utilities/any/any.class/any.cons/in_place_type.pass.cpp
test/std/utilities/any/any.class/any.cons/va
On 16 November 2016 at 18:38, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I'm a bit surprised that this landed, given that gcc bug. I can see the
> motivation for the gcc bug: If you say your enum is going to need
> underlying 8 bits, then warning that your bitfield where you
I'm a bit surprised that this landed, given that gcc bug. I can see the
motivation for the gcc bug: If you say your enum is going to need
underlying 8 bits, then warning that your bitfield where you store it is
smaller _is_ surprising.
I'm not sure if landing this while gcc still behaves the way i
CaseyCarter created this revision.
CaseyCarter added reviewers: mclow.lists, EricWF.
CaseyCarter added a subscriber: cfe-commits.
Note that this does not implement the product code changes to and
, this is only the necessary changes to accompanying test code.
https://reviews.llvm.org/D26782
F
Author: rsmith
Date: Wed Nov 16 20:16:09 2016
New Revision: 287193
URL: http://llvm.org/viewvc/llvm-project?rev=287193&view=rev
Log:
Remove -Wsigned-enum-bitfield from -Wmost. On a wide set of ABIs, this warning
is completely irrelevant, producing (effectively) false positives, and -Wmost
is used
mehdi_amini added a comment.
What is the correct solution for MSVC in C? (If any)
Repository:
rL LLVM
https://reviews.llvm.org/D24289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rsmith added a comment.
This is causing warnings to fire for headers shared between C and C++, where
the "give the enum an unsigned underlying type" advice doesn't work, and where
the code in question will never be built for the MS ABI. It seems really hard
to justify this being on by default.
ahatanak updated this revision to Diff 78300.
ahatanak added a comment.
Rebase and ping.
https://reviews.llvm.org/D21099
Files:
lib/Sema/SemaChecking.cpp
test/Sema/warn-cast-align.c
Index: test/Sema/warn-cast-align.c
===
---
Author: gbiv
Date: Wed Nov 16 19:33:54 2016
New Revision: 287187
URL: http://llvm.org/viewvc/llvm-project?rev=287187&view=rev
Log:
[Sema] Fix a bug in enable_if condition instantiation.
During template instantiation, we currently fall back to just calling
Sema::SubstExpr for enable_if attributes
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D26780
Files:
clang/lib/Headers/__clang_cuda_cmath.h
clang/lib/Headers/__clang_cuda_runtime_wrapper.h
Index: clang/lib/Headers/__clang_cuda_runtime_wrapper.h
Author: krasin
Date: Wed Nov 16 19:09:04 2016
New Revision: 287185
URL: http://llvm.org/viewvc/llvm-project?rev=287185&view=rev
Log:
Explicitly specify that ubsan-vtable-checks is x86-64.
This should fix a failure on PowerPC introduced by r287181.
Modified:
cfe/trunk/test/CodeGenCXX/ubsan-vt
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D26777
Files:
clang/lib/CodeGen/CGCUDANV.cpp
Index: clang/lib/CodeGen/CGCUDANV.cpp
===
--- clang/lib/Cod
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
This used to work because system headers are found in a (somewhat)
predictable set of locations on Linux. But this is not the case on
MacOS; without this change, we don't look in the right places f
Author: krasin
Date: Wed Nov 16 18:39:48 2016
New Revision: 287181
URL: http://llvm.org/viewvc/llvm-project?rev=287181&view=rev
Log:
Insert a type check before reading vtable.
Summary:
this is to prevent a situation when a pointer is invalid or null,
but we get to reading from vtable before we ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287181: Insert a type check before reading vtable. (authored
by krasin).
Changed prior to commit:
https://reviews.llvm.org/D26559?vs=78279&id=78288#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
rnk added a comment.
If I understand correctly, this patch takes template function patterns, copies
them into instantiated context, parses them in that context, and then
instantiates them in that context. The key difference is that today's
fdelayed-template-parsing doesn't parse the body of the
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
https://reviews.llvm.org/D26773
Files:
lib/StaticAnalyzer/Core/ProgramState.cpp
Index: lib/StaticAnalyzer/Core/ProgramState.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287179: [CMake] Support lld with LTO bootstrap (authored by
phosek).
Changed prior to commit:
https://reviews.llvm.org/D26649?vs=78096&id=78283#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2664
Author: phosek
Date: Wed Nov 16 17:59:06 2016
New Revision: 287179
URL: http://llvm.org/viewvc/llvm-project?rev=287179&view=rev
Log:
[CMake] Support lld with LTO bootstrap
lld has LTO support, if requested we should add a dependency on lld
rather than LLVMgold when doing LTO bootstrap build.
Dif
rnk added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+ Old_TSK == TSK_ImplicitInstantiation) &&
(TSK == TSK_ExplicitInstantiationDefinition ||
DLLImportExplicitInstantiat
beanz added a comment.
Yep, LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287177: Add warning when assigning enums to bitfields
without an explicit unsigned… (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D24289?vs=70760&id=78281#toc
Repository:
rL LL
Author: rnk
Date: Wed Nov 16 17:40:00 2016
New Revision: 287177
URL: http://llvm.org/viewvc/llvm-project?rev=287177&view=rev
Log:
Add warning when assigning enums to bitfields without an explicit unsigned
underlying type
Summary:
Add a warning when assigning enums to bitfields without an explici
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGExprCXX.cpp:1768
QualType ElementType) {
+ CGF.EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+DE-
krasin updated this revision to Diff 78279.
krasin added a comment.
inline
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
==
dcoughlin added a comment.
Thanks for the patch!
How does this differ from `getCXXThisVal()` on `CXXInstanceCall` and its
subclasses in CallEvent.h? Can that be used instead? Or are there places where
you need access to this without a CallEvent?
Also: it seems like there are a lot of places in
krasin updated this revision to Diff 78277.
krasin added a comment.
Address minor comment.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
==
krasin marked an inline comment as done.
krasin added inline comments.
Comment at: test/CodeGenCXX/ubsan-vtable-checks.cpp:23
+ // CHECK-NULL: [[UBSAN_CMP_RES:%[0-9]+]] = icmp ne %struct.T*
%{{[_a-z0-9]+}}, null
+ // CHECK-NULL-NEXT: br i1 [[UBSAN_CMP_RES]], label %cont, label
krasin updated this revision to Diff 78276.
krasin added a comment.
Fix the test under -Asserts build.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287175: [analyzer] Remove unused
check::RegionChanges::wantsRegionChangeUpdate callback (authored by zaks).
Changed prior to commit:
https://reviews.llvm.org/D26759?vs=78249&id=78271#toc
Repository:
Author: zaks
Date: Wed Nov 16 16:59:01 2016
New Revision: 287175
URL: http://llvm.org/viewvc/llvm-project?rev=287175&view=rev
Log:
[analyzer] Remove unused check::RegionChanges::wantsRegionChangeUpdate callback
Remove the check::RegionChanges::wantsRegionChangeUpdate callback as it is no
longer u
rsmith added inline comments.
Comment at: docs/UsersManual.rst:655-656
+
+Command line option `--config` can be used to specify configuration file in
+a clang invocation. For instance:
+
Rather than inventing a new mechanism, could we extend our existing `@file`
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added subscribers: cfe-commits, alexfh.
The VirtualCallChecker is in alpha because its interprocedural diagnostics
represent the call path textually in the diagnostic message rather than with a
path sensitive d
Author: smeenai
Date: Wed Nov 16 16:18:10 2016
New Revision: 287164
URL: http://llvm.org/viewvc/llvm-project?rev=287164&view=rev
Log:
[libc++] Introduce `_LIBCPP_OVERRIDABLE_FUNC_VIS`
This is a generalization of `_LIBCPP_NEW_DELETE_VIS`; the new macro name
captures the semantics better, and also
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287164: [libc++] Introduce `_LIBCPP_OVERRIDABLE_FUNC_VIS`
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26702?vs=78079&id=78264#toc
Repository:
rL LLVM
https://reviews.ll
rsmith added inline comments.
Comment at: include/clang/AST/Expr.h:440
+ ///
+ /// Likewise bitfields, we model gl-values referring to packed-fields as
+ /// an aspect of the value-kind type system.
aaron.ballman wrote:
> Like bitfields
> glvalues
"Likewise bi
hans added a comment.
In https://reviews.llvm.org/D26657#597859, @smeenai wrote:
> In https://reviews.llvm.org/D26657#597523, @hans wrote:
>
> > In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
> >
> > > In https://reviews.llvm.org/D26657#596759, @hans wrote:
> > >
> > > > > On MSVC, if
Author: gbiv
Date: Wed Nov 16 15:31:25 2016
New Revision: 287154
URL: http://llvm.org/viewvc/llvm-project?rev=287154&view=rev
Log:
Use the member function location in enable_if diagnostics.
Before:
:3:3: error: no matching member function for call to 'bar'
Foo().bar();
^
After:
:3:9: error:
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1769
+ SourceLocation CallLoc;
+ if (DE)
+CallLoc = DE->getExprLoc();
DE will always be non-null at this point.
Comment at: test/CodeGenCXX/ubsan-vtable-checks.cpp:23
+ //
rsmith added a comment.
Please don't ban things just because you can. If there's some reason why this
doesn't make sense in OpenCL, this may be fine, but generally you shouldn't be
making this language mode deviate from clang's normal behaviour regarding
extensions.
(It would be great if we ha
Author: ericwf
Date: Wed Nov 16 15:15:58 2016
New Revision: 287153
URL: http://llvm.org/viewvc/llvm-project?rev=287153&view=rev
Log:
[clang-tidy] Fix identifier naming for initializer list member initializers.
Summary:
This patch adds handling for member initializers in a constructors initializer
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/clang-tidy/readability-identifier-naming.cpp:155
// CHECK-FIXES: {{^}}class CMyClass {{{$}}
+public:
my_class();
E
EricWF updated this revision to Diff 78252.
EricWF added a comment.
Fix `auto` usage.
https://reviews.llvm.org/D26744
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-naming.cpp
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: test/clang-tidy/readability-identifier-naming.cpp:155
// CHECK-FIXES: {{^}}class CMyClass {{{$}}
+public:
my_class();
aaron.ballman wrote:
> Why set the access specifier here
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:681
+
+for (auto Init : Decl->inits()) {
+ if (!Init->isWritten() || Init->isInClassMemberInitializer())
Please use `const auto *` instead of just `auto`.
smeenai added a comment.
In https://reviews.llvm.org/D26657#597523, @hans wrote:
> In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
>
> > In https://reviews.llvm.org/D26657#596759, @hans wrote:
> >
> > > > On MSVC, if an implicit instantiation already exists and an explicit
> > > > ins
k-wisniewski updated this revision to Diff 78249.
k-wisniewski added a comment.
Removed a line that leaked from another diff - thanks Anna!
https://reviews.llvm.org/D26759
Files:
include/clang/StaticAnalyzer/Core/Checker.h
include/clang/StaticAnalyzer/Core/CheckerManager.h
include/clang/S
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D26741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
mgorny created this revision.
mgorny added reviewers: samsonov, etienneb, beanz.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, kubabrecka.
Remove the explicit i686 target that is completely duplicate to
the i386 target, with the latter being used more commonly.
1. The
NoQ added a comment.
I'm ok with constructing `SymbolRegionValue` for `ArgLoc` manually and adding a
comment like `FIXME: leaking implementation details of RegionStoreManager`.
https://reviews.llvm.org/D26760
___
cfe-commits mailing list
cfe-commit
NoQ added a comment.
I think this method, unlike https://reviews.llvm.org/D26760, doesn't have the
problem with overwriting the location in the top frame, because the location of
C++ "this" cannot really be assigned to.
https://reviews.llvm.org/D26762
___
mgorny created this revision.
mgorny added a reviewer: kcc.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, kubabrecka.
Use the __SSE2__ to determine whether SSE2 is enabled in the ASAN tests
rather than relying on either of the __i686__ and __x86_64__. The former
is onl
smeenai added a comment.
In https://reviews.llvm.org/D26702#597377, @EricWF wrote:
> What happens on windows when `operator new` isn't overridden and has to be
> imported from the DLL? Does that work?
Yup. If you have a function that isn't marked `dllimport` and it's not found
locally, the li
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:535
+ ExplicitRegions, Regions,
+ Call, LCtx);
}
Looks like the other patch leaked i
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks great!
https://reviews.llvm.org/D26759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
k-wisniewski created this revision.
k-wisniewski added reviewers: a.sidorin, zaks.anna, NoQ, dcoughlin.
k-wisniewski added subscribers: cfe-commits, NoQ.
Artem Dergachev (@NoQ ) helped me correctly handle C++ method calls in my
RecursionChecker (that finds infnite recursion) and this is the metho
k-wisniewski created this revision.
k-wisniewski added reviewers: NoQ, dcoughlin, zaks.anna, a.sidorin.
k-wisniewski added a subscriber: cfe-commits.
Hi!
I've noticed that check::RegionChanges::wantsRegionChangeUpdate is no longer
used - as far as the discussion went it has been unused at least
k-wisniewski created this revision.
k-wisniewski added reviewers: a.sidorin, NoQ, dcoughlin, zaks.anna.
k-wisniewski added a subscriber: cfe-commits.
This patch adds getArgsSVal method to ProgramState that allows the user to
obtain SVals of argumetns used in a call that created the given StackFra
krasin updated this revision to Diff 78240.
krasin marked an inline comment as done.
krasin added a comment.
Sync to Clang ToT.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
==
hans added a subscriber: srhines.
hans added a comment.
I'm still skeptical, but I think this is an improvement over the previous patch.
I think your best bet to get this landed is to find someone from the cfe-dev
thread who is in favour of config files and have them review it.
I'm also cc'ing
Author: adrian
Date: Wed Nov 16 13:31:44 2016
New Revision: 287141
URL: http://llvm.org/viewvc/llvm-project?rev=287141&view=rev
Log:
Relax testcase.
This removes checks that are irrelevant for what is being tested.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp
Modified: cfe/
Author: adrian
Date: Wed Nov 16 13:26:11 2016
New Revision: 287139
URL: http://llvm.org/viewvc/llvm-project?rev=287139&view=rev
Log:
Add the missing FileCheck invocation to this testcase.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug
Author: yrnkrn
Date: Wed Nov 16 13:24:10 2016
New Revision: 287138
URL: http://llvm.org/viewvc/llvm-project?rev=287138&view=rev
Log:
Rangify for loops, NFC.
Modified:
cfe/trunk/lib/Frontend/DependencyFile.cpp
Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp
URL:
http://llvm.org/viewvc/l
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
This looks amazing. I have a few minor quibbles and a testing concern, but
overall this looks like a great step forward! Thank you!
Comment at: lib/AST/ASTImport
teemperor added a reviewer: rsmith.
teemperor added a comment.
Looks good to me. I'll add Richard because he also merged/approved the original
post-order patch.
https://reviews.llvm.org/D26742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: adrian
Date: Wed Nov 16 12:49:47 2016
New Revision: 287134
URL: http://llvm.org/viewvc/llvm-project?rev=287134&view=rev
Log:
Fix PR31029 by attaching an artificial debug location to msabi thunks.
This was a latent bug that was recently uncovered by r286400.
Added:
cfe/trunk/test/CodeG
mclow.lists added a comment.
More info - The following code:
#include
int main () {}
fails to compile on either gcc 6.2 (locally), gcc 7 head (online compiler) or
MSVC (online compiler).
https://reviews.llvm.org/D26376
___
cfe-commits mailin
khazem added a comment.
Thanks very much for this patch! It certainly fixes the infinite recursion
issue on our codebase. It LGTM, but I'd like to add a test case before landing
it.
https://reviews.llvm.org/D26753
___
cfe-commits mailing list
cfe-
arphaman added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:5405
+ // Objective-C++: Detect C++ keywords and try to prevent further errors
by
+ // treating these keyword as valid member names.
+ if (getLangOpts().ObjC1 && getLangOpts().CPlusPlus &&
---
arphaman updated this revision to Diff 78218.
arphaman marked 4 inline comments as done.
arphaman added a comment.
Addressed review comments by renaming the diagnostic and simplifying the name
and the use of the `expectIdentifier ` method.
Repository:
rL LLVM
https://reviews.llvm.org/D26503
rSerge updated this revision to Diff 78216.
rSerge added a comment.
Rebased to the latest version of LLVM sources.
https://reviews.llvm.org/D26415
Files:
lib/Driver/Tools.cpp
test/Driver/XRay/xray-instrument-cpu.c
test/Driver/XRay/xray-instrument-os.c
Index: test/Driver/XRay/xray-instru
spyffe closed this revision.
spyffe added a comment.
Committed r287129
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: spyffe
Date: Wed Nov 16 12:21:00 2016
New Revision: 287129
URL: http://llvm.org/viewvc/llvm-project?rev=287129&view=rev
Log:
Fixed layout of test/ASTMerge.
As outlined in a previous RFC, the test/ASTMerge/Inputs folder is getting full
and the tests are starting to become interdependent.
Author: d0k
Date: Wed Nov 16 12:15:26 2016
New Revision: 287128
URL: http://llvm.org/viewvc/llvm-project?rev=287128&view=rev
Log:
[Frontend] Allow attaching an external sema source to compiler instance and
extra diags to TypoCorrections
This can be used to append alternative typo corrections to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287128: [Frontend] Allow attaching an external sema source
to compiler instance and… (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D26745?vs=78179&id=78213#toc
Repository:
rL L
a.sidorin created this revision.
a.sidorin added reviewers: spyffe, khazem.
a.sidorin added a subscriber: cfe-commits.
- Support template partial specialization
- Avoid infinite recursion in IsStructurallyEquivalent for TemplateArgument
with implementing IsStructurallyEquivalent for TemplateName
bruno added a comment.
Ping!
https://reviews.llvm.org/D26267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer created this revision.
bkramer added reviewers: klimek, hokein, ioeric.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
- Refactor the external sema source into a visible class
- Add support for emitting FixIts
- Wrap up include fixer as a plugin as I did with c
rogfer01 updated this revision to Diff 78209.
rogfer01 added a comment.
Changes:
- Rebase patch to trunk
- Fixes as pointed out by reviewers
TODO:
- Diagnose and drop the packed attribute of a class with a nontrivially
constructed data member.
https://reviews.llvm.org/D23325
Files:
includ
rogfer01 marked 15 inline comments as done.
rogfer01 added a comment.
I am retaking this, will upload an updated patch soon.
Comment at: lib/AST/Decl.cpp:3523
+ return !isBitField() &&
+ (this->hasAttr() || getParent()->hasAttr()) &&
+ Context.getDeclAlign(this
Anastasia added a comment.
Earlier related discussion: https://reviews.llvm.org/D17821
Repository:
rL LLVM
https://reviews.llvm.org/D26746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
On 16 Nov 2016 10:04 am, "Marshall Clow" wrote:
mclow.lists added a comment.
Ok - looking just at `kill_dependency`, this was added to the C standard in
C11. It's required to be a macro.
`atomic_is_lock_free` appears to be a function, as does `atomic_load`.
Haven't checked the rest.
That's a b
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-default-member-init.rst:7
+This check converts a default constructor's member initializers into default
+member initializers. Other member initializers that match the default
+member initializ
mclow.lists added a comment.
Ok - looking just at `kill_dependency`, this was added to the C standard in
C11. It's required to be a macro.
`atomic_is_lock_free` appears to be a function, as does `atomic_load`. Haven't
checked the rest.
I see that Bionic (sometimes) defines `atomic_is_lock_free`
Anastasia added a comment.
It seems that this bit is accepted under -std=c99 and the warning is given with
the -pedantic flag. I am not sure whether it adds much deviating the
implementation from C here. The OpenCL spec doesn't seem to contain anything on
this matter? But if we decide to be mor
hans added a comment.
In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
> In https://reviews.llvm.org/D26657#596759, @hans wrote:
>
> > > On MSVC, if an implicit instantiation already exists and an explicit
> > > instantiation definition with a DLL attribute is created, the DLL
> > > a
mclow.lists added a comment.
I'll do some research.
https://reviews.llvm.org/D26376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Hmm, this won't help when building libc++ as a module, and we don't have a
wrapper header to hold these undefs since is not part of c++.
So either that combination of includes gives a broken or a broken
, or we do something nonstandard like reimplementing the latter in
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Template instantiations were causing misplaced fixits.
https://reviews.llvm.org/D26751
Files:
clang-tidy/modernize/UseEqualsDeleteCheck.cpp
test/cl
Author: pjaaskel
Date: Wed Nov 16 10:21:59 2016
New Revision: 287115
URL: http://llvm.org/viewvc/llvm-project?rev=287115&view=rev
Log:
target-data test update for TCE and TCELE
Modified:
cfe/trunk/test/CodeGen/target-data.c
Modified: cfe/trunk/test/CodeGen/target-data.c
URL:
http://llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287118: [change-namespace] handle constructor initializer:
Derived : Base::Base() {}… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26637?vs=78190&id=78201#toc
Repository:
Author: ioeric
Date: Wed Nov 16 10:54:53 2016
New Revision: 287118
URL: http://llvm.org/viewvc/llvm-project?rev=287118&view=rev
Log:
[change-namespace] handle constructor initializer: Derived : Base::Base() {}
and added conflict detections
Summary:
namespace nx { namespace ny { class Base { publ
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, Eugene.Zelenko, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Herald added subscribers: modocache, mgorny.
Fixes PR18858
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
Author: rksimon
Date: Wed Nov 16 10:11:08 2016
New Revision: 287114
URL: http://llvm.org/viewvc/llvm-project?rev=287114&view=rev
Log:
Remove duplicate condition (PR30648). NFCI.
We only need to check that the bitstream entry is a Record.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
M
1 - 100 of 144 matches
Mail list logo
