[PATCH] D26415: [XRay] Support AArch64 in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL287518: [XRay] Support AArch64 in Clang (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D26415?vs=78216=78685#toc Repository: rL LLVM https://reviews.llvm.org/D26415

[PATCH] D26903: [libcxx] Add tests (but not implementation)

CaseyCarter added a comment. I'll take a look at these tomorrow; I don't have easy access to my implementation with the changes from P0510 and P0504 from home (it's waiting on a compiler bugfix to checkin). Comment at:

[PATCH] D26587: [X86][AVX512][InlineASM][MS][clang] (I|G)CC Memory adjustments compatibility

coby updated this revision to Diff 78681. Repository: rL LLVM https://reviews.llvm.org/D26587 Files: test/CodeGen/ms-inline-asm-avx512-memory-adjustments.c Index: test/CodeGen/ms-inline-asm-avx512-memory-adjustments.c === ---

[libcxx] r287513 - Mark variadic lock guard tests as XFAIL with modules, since they have to define macros to expose the new ABI

Author: ericwf Date: Sun Nov 20 19:10:52 2016 New Revision: 287513 URL: http://llvm.org/viewvc/llvm-project?rev=287513=rev Log: Mark variadic lock guard tests as XFAIL with modules, since they have to define macros to expose the new ABI Modified:

[PATCH] D26882: Refactor how FunctionDecl handles constexpr:

hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/Decl.h:1915 +IsConstexprSpecified = IC; +IsConstexpr = IC; + } How is the `inline` property transmitted here? Why does the `setImplicitlyConstexpr` function need to call

[libcxx] r287512 - Adjust uses_alloc_types helpers for later changes

Author: ericwf Date: Sun Nov 20 18:41:32 2016 New Revision: 287512 URL: http://llvm.org/viewvc/llvm-project?rev=287512=rev Log: Adjust uses_alloc_types helpers for later changes Modified: libcxx/trunk/test/support/uses_alloc_types.hpp Modified: libcxx/trunk/test/support/uses_alloc_types.hpp

Re: [PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

Thanks for the great explanation, I agree with this advice. I'm going to investigate writing a new patch to do this. On Fri, Nov 18, 2016 at 1:59 PM, Arthur O'Dwyer wrote: > On Thu, Nov 17, 2016 at 2:14 PM, Sasha Bermeister > wrote: > >> Although

[PATCH] D26885: [libcxx] Fix max_size() across all containers

mclow.lists added inline comments. Comment at: test/std/containers/associative/map/map.access/max_size.pass.cpp:24 + +template size_t alloc_max_size(Alloc const ) { + typedef std::allocator_traits AT; How about a newline here? (after the `template<>`) And why

[PATCH] D26900: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config

mgorny created this revision. mgorny added reviewers: beanz, rnk, chapuni, chandlerc. mgorny added a subscriber: cfe-commits. Use the new --cmakedir option to obtain LLVM_CMAKE_PATH straight from llvm-config instead of reconstructing it locally. https://reviews.llvm.org/D26900 Files:

[libcxx] r287507 - Merge r286774 - Fixes PR30979

Author: ericwf Date: Sun Nov 20 15:33:12 2016 New Revision: 287507 URL: http://llvm.org/viewvc/llvm-project?rev=287507=rev Log: Merge r286774 - Fixes PR30979 Modified: libcxx/branches/release_39/include/tuple

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

malcolm.parsons updated this revision to Diff 78663. malcolm.parsons added a comment. Use llvm_unreachable. Ignore template instantiations. https://reviews.llvm.org/D26750 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D26258: [AVX512][clang] Amending vpmultishiftqb

coby abandoned this revision. coby added a comment. deprecated. Repository: rL LLVM https://reviews.llvm.org/D26258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24933: Enable configuration files in clang

mgorny added a comment. In https://reviews.llvm.org/D24933#600884, @sepavloff wrote: > > Whoever makes the `blah-clang` symlink should get to control what the > > default configuration for `blah-clang` is, I think. > > The patch is changed so that config file for `blah-clang` is searched for >

[PATCH] D24933: Enable configuration files in clang

sepavloff marked 5 inline comments as done. sepavloff added a comment. > Rather than inventing a new mechanism, could we extend our existing `@file` > facility to support comments and nested inclusion of further `@file`s? Reusing `@file` is an attractive idea, but it cannot be implemented due

[PATCH] D26350: Keep invalid Switch in the AST

ogoffart added a comment. ping? https://reviews.llvm.org/D26350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26465: [Diag] Optimize DiagnosticIDs::getDiagnosticSeverity

ogoffart added a comment. ping? https://reviews.llvm.org/D26465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78654. AntonBikineev added a comment. Richard, thanks, I addressed your comments. https://reviews.llvm.org/D26829 Files: include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Sema/SemaDeclCXX.cpp

[PATCH] D24933: Enable configuration files in clang

hfinkel added a comment. What happens with unused arguments in the configuration files? This feature looks potentially useful for me, but only if it suppresses unused-argument warnings. For example, if I put -L/usr/local/lib -stdlib=libc++ into a configuration file, I can't have these:

r287483 - Add doxygen comments to immintrin.h's intrinsics.

Author: kromanova Date: Sun Nov 20 02:35:05 2016 New Revision: 287483 URL: http://llvm.org/viewvc/llvm-project?rev=287483=rev Log: Add doxygen comments to immintrin.h's intrinsics. The doxygen comments are automatically generated based on Sony's intrinsics docu ment. I got an OK from Eric

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 78652. sepavloff added a comment. Herald added a subscriber: aemerson. Updated patch. - Restrict the search for config files specified by mangled clang name to binary directory only, - Allow the search for config files specified by `--config` in binary