[libcxx] r289029 - Fix PR30323: numeric_limits::max_digits10 when using 16 bit ints.

2016-12-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Dec 8 01:30:01 2016 New Revision: 289029 URL: http://llvm.org/viewvc/llvm-project?rev=289029=rev Log: Fix PR30323: numeric_limits::max_digits10 when using 16 bit ints. Summary: Also see https://llvm.org/bugs/show_bug.cgi?id=30323 Reviewers: mclow.lists Subscribers:

[PATCH] D27566: Fix PR30323: numeric_limits::max_digits10 when using 16 bit ints.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289029: Fix PR30323: numeric_limits::max_digits10 when using 16 bit ints. (authored by EricWF). Changed prior to commit: https://reviews.llvm.org/D27566?vs=80716=80722#toc Repository: rL LLVM

[PATCH] D27555: [libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Are you planning on fixing this in your compiler? https://reviews.llvm.org/D27555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27541: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Waiting for a response on https://reviews.llvm.org/D27540 before reviewing this. https://reviews.llvm.org/D27541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/std/re/re.traits/value.pass.cpp:119 } for (int c = 'g'; c < 0x; ++c) { Can't we just make `c` a

[PATCH] D27123: Add AVR target and toolchain to Clang

2016-12-07 Thread Senthil Kumar Selvaraj via Phabricator via cfe-commits
saaadhu updated this revision to Diff 80721. saaadhu added a comment. Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead of short. {U,}INT16_TYPE still gets defined as short though - lib/Frontend/InitPreprocessor.cpp::DefineExactWidthIntType does not use

[PATCH] D27543: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 6/7.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. LGTM. https://reviews.llvm.org/D27543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27542: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 5/7.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D27542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27540: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. > MSVC seriously emits a warning for void foo(short); foo(0); because the > literal 0 is an int? Oh my goodness it does... Your compiler is bad and it should feel bad. It's not like you can write `foo(0s)`. https://reviews.llvm.org/D27540

[PATCH] D27540: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. MSVC seriously emits a warning for `void foo(short); foo(0);` because the literal `0` is an int? If so you really should fix that in MSVC; That's a bogus warning. Does it emit a warning for `short x = 3;`? https://reviews.llvm.org/D27540

[libcxx] r289028 - Fix _LIBCPP_VERSION tests with modules on Darwin

2016-12-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Dec 8 00:37:41 2016 New Revision: 289028 URL: http://llvm.org/viewvc/llvm-project?rev=289028=rev Log: Fix _LIBCPP_VERSION tests with modules on Darwin Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL:

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. I'm not sure `CLOCK_UPTIME_RAW` meets the requirements of `steady_clock`. The manpage for `clock_gettime` on OS X specifies `CLOCK_UPTIME_RAW` as: > CLOCK_UPTIME_RAW clock that increments monotonically, in the same manner as > CLOCK_MONOTONIC_RAW, but that does not

[PATCH] D27564: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times

2016-12-07 Thread Keno Fischer via Phabricator via cfe-commits
loladiro added a comment. I take it this supersedes https://reviews.llvm.org/D24372? I apologize for not getting around to commiting that yet, but if it does supersede that revision, we should probably keep the tests that we have there. https://reviews.llvm.org/D27564

[PATCH] D27566: Fix PR30323: numeric_limits::max_digits10 when using 16 bit ints.

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Also see https://llvm.org/bugs/show_bug.cgi?id=30323 https://reviews.llvm.org/D27566 Files: include/limits Index: include/limits

[PATCH] D27565: [libcxx] Alternative fix for compressed pair

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Grr... OK so this is currently ABI breaking because it re-arranges the layout of `__compressed_pair` when `T2` is empty but `T1` is not. I might be able to work around this with some metaprogramming. https://reviews.llvm.org/D27565

[PATCH] D24431: CodeGen: Start using inrange annotations on vtable getelementptr.

2016-12-07 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I'm not sure I like this IR design, but this use of it seems fine. LGTM. https://reviews.llvm.org/D24431 ___ cfe-commits mailing list

[PATCH] D22296: CodeGen: New vtable group representation: struct of vtable arrays.

2016-12-07 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. This seems reasonable to me. Just a few representational / API requests. Comment at: clang/include/clang/AST/VTableBuilder.h:222 + typedef llvm::DenseMap> + AddressPointsMapTy;

[PATCH] D27565: [libcxx] Alternative fix for compressed pair

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 80715. EricWF added a comment. Remove ever more dead code. https://reviews.llvm.org/D27565 Files: include/__hash_table include/memory include/string test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default01.fail.cpp

[PATCH] D27565: [libcxx] Alternative fix for compressed pair

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. I would rather have this fix than https://reviews.llvm.org/D27564, but I'm not yet sure it isn't ABI breaking. https://reviews.llvm.org/D27565 Files: include/__hash_table

r289022 - [DOXYGEN] Improved doxygen comments for avxintrin.h intrinsics.

2016-12-07 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Wed Dec 7 22:09:17 2016 New Revision: 289022 URL: http://llvm.org/viewvc/llvm-project?rev=289022=rev Log: [DOXYGEN] Improved doxygen comments for avxintrin.h intrinsics. Tagged parameter names with \a doxygen command to display them in italics. Formatted comments to fit

[PATCH] D27564: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Ideally I would like to re-write `__compressed_pair` so that it doesn't need 4 complete specializations but I'm not sure the change would be non-ABI breaking. https://reviews.llvm.org/D27564 ___ cfe-commits mailing list

r288892 - Compilation database test: don't try to output to CWD

2016-12-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Dec 7 03:19:07 2016 New Revision: 288892 URL: http://llvm.org/viewvc/llvm-project?rev=288892=rev Log: Compilation database test: don't try to output to CWD Summary: Write output from compilation database test to %T rather than the working dir. Sometimes CWD isn't

[PATCH] D27564: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added subscribers: cfe-commits, loladiro. __compressed_pair takes and passes it's constructor arguments by value. This causes arguments to be moved 3 times instead of once. This patch addresses that issue and fixes

[PATCH] D13134: [analyzer] Add keyboard shortcuts to report.html

2016-12-07 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin commandeered this revision. dcoughlin edited reviewers, added: skomski; removed: dcoughlin. dcoughlin added a comment. Commandeering and closing this revision as it has been more than a year. Repository: rL LLVM https://reviews.llvm.org/D13134

[PATCH] D25417: [libcxxabi] Fix alignment of allocated exceptions in 32 bit builds

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. I ran into some test failures on OS X while attempting to commit this. The `unwind.h` header provided on OS X hasn't upstreamed the libunwind fix from r276215 , meaning `__cxa_exception` is still under-aligned and therefore so is the

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

2016-12-07 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. This looks great to me other than the idiom I mentioned inline (which is common, as I have found to my chagrin). Comment at: lib/StaticAnalyzer/Checkers/ObjCPropertyChecker.cpp:12 +// Currently finds only one kind of issue: +// - Find

r289021 - [c++1z] P0490R0, NB comment GB 20: if std::tuple_size is complete, use the

2016-12-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Dec 7 21:24:55 2016 New Revision: 289021 URL: http://llvm.org/viewvc/llvm-project?rev=289021=rev Log: [c++1z] P0490R0, NB comment GB 20: if std::tuple_size is complete, use the tuple-like interpretation of decomposition declaration even if there is no ::value member. We

r289019 - [c++1z] P0003R5: Removing dynamic exception specifications.

2016-12-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Dec 7 20:49:07 2016 New Revision: 289019 URL: http://llvm.org/viewvc/llvm-project?rev=289019=rev Log: [c++1z] P0003R5: Removing dynamic exception specifications. We continue to support dynamic exception specifications in C++1z as an extension, but produce an

[PATCH] D24431: CodeGen: Start using inrange annotations on vtable getelementptr.

2016-12-07 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a reviewer: rjmccall. pcc added a comment. John, may I ask you to take a look? https://reviews.llvm.org/D24431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22296: CodeGen: New vtable group representation: struct of vtable arrays.

2016-12-07 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a reviewer: rjmccall. pcc added a comment. John, may I ask you to take a look? https://reviews.llvm.org/D22296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22296: CodeGen: New vtable group representation: struct of vtable arrays.

2016-12-07 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc updated this revision to Diff 80709. pcc added a comment. Refresh https://reviews.llvm.org/D22296 Files: clang/include/clang/AST/VTableBuilder.h clang/lib/AST/VTableBuilder.cpp clang/lib/CodeGen/CGCXX.cpp clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp

r289018 - [Headers] Enable #include_next on Darwin

2016-12-07 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Wed Dec 7 20:13:56 2016 New Revision: 289018 URL: http://llvm.org/viewvc/llvm-project?rev=289018=rev Log: [Headers] Enable #include_next on Darwin Allows darwin targets to provide additional definitions and implementation specifc values for float.h rdar://problem/21961491

[PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

2016-12-07 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:110-112 +// FIXME: shouldIgnoreMacro() in ASTWriter also stops at macros from the +// predefines buffer in module builds. Do we need to splice to those here +// too? If I remember

[PATCH] D27557: Update the default of the Mozilla coding style

2016-12-07 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: klimek. sylvestre.ledru added a subscriber: cfe-commits. I also proposed the change in Firefox .clang-format file: https://bugzilla.mozilla.org/show_bug.cgi?id=1322321 https://reviews.llvm.org/D27557 Files:

[PATCH] D27555: [libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory". /analyze sees array::size() being called on arrays with garbage-inited doubles, and complains. It doesn't

r289011 - Loosen checks for _MSC_FULL_VER under -fms-extensions.

2016-12-07 Thread David L. Jones via cfe-commits
Author: dlj Date: Wed Dec 7 19:11:41 2016 New Revision: 289011 URL: http://llvm.org/viewvc/llvm-project?rev=289011=rev Log: Loosen checks for _MSC_FULL_VER under -fms-extensions. Summary: On actual Windows hosts :-) , this could report something other than the fallback, with a non-zero

[PATCH] D27409: [analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol.

2016-12-07 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Ship it! :-) https://reviews.llvm.org/D27409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Buildbot numbers for the week of 11/27/2016 - 12/03/2016

2016-12-07 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 11/27/2016 - 12/03/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Buildbot numbers for the week of 11/20/2016 - 11/26/2016

2016-12-07 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 11/20/2016 - 11/26/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-07 Thread Paul Robinson via Phabricator via cfe-commits
probinson accepted this revision. probinson added a reviewer: probinson. probinson added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/CodeGen/CGDebugInfo.cpp:3765 +InitExpr = +

[PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

2016-12-07 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks! Comment at: test/PCH/builtin-macro.c:29 + +const char s[] = __DATE__ " " __TIME__ " " __TIMESTAMP__; + rnk wrote: > This test doesn't seem to fail if `__DATE__` expands to something. I removed > `-D__DATE__=` from the command

[PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

2016-12-07 Thread Nico Weber via Phabricator via cfe-commits
thakis updated this revision to Diff 80687. thakis marked 2 inline comments as done. thakis added a comment. comments https://reviews.llvm.org/D27545 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPMacroExpansion.cpp lib/Serialization/ASTReader.cpp test/PCH/builtin-macro.c Index:

[PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

2016-12-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Fix seems reasonable. Comment at: lib/Lex/PPMacroExpansion.cpp:115 + "only built-ins should have an entry here"); +assert(!OldMD->getPrevious() && "builtin should only have a singe entry"); +ED->setPrevious(OldMD);

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

2016-12-07 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:99 + if (!D->hasAttrs()) +return false; + for (Attr *Attribute : D->getAttrs()) { jlebar wrote: > Is this early return necessary? Yes. Otherwise D->getAttrs() will trigger assert(hasAttrs) if we

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

2016-12-07 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 80677. tra marked 4 inline comments as done. tra added a comment. Addressed Justin's comments. https://reviews.llvm.org/D25845 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-07 Thread David Gross via Phabricator via cfe-commits
dgross added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3765 +InitExpr = + DBuilder.createConstantValueExpression(Init.getFloat().bitcastToAPInt().getZExtValue()); GV.reset(DBuilder.createGlobalVariable( probinson wrote: > This line

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-07 Thread David Gross via Phabricator via cfe-commits
dgross updated this revision to Diff 80683. dgross added a comment. Incorporate code review feedback. - Reformat source. - Make test pattern more general. https://reviews.llvm.org/D27549 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-static-const-fp.c Index:

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

2016-12-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 80682. rnk marked an inline comment as done. rnk added a comment. - Allow more decls in prototypes, dump fd decls https://reviews.llvm.org/D27279 Files: include/clang/AST/Decl.h include/clang/Sema/DeclSpec.h include/clang/Sema/Sema.h

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

2016-12-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk marked an inline comment as done. rnk added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1240 +/// in the prototype. These are generally tag types or enumerators. +unsigned NumDeclsInPrototype : 8; + rsmith wrote: > It seems plausible

r288998 - Refactor how the MSVC toolchain searches for a compatibility version.

2016-12-07 Thread David L. Jones via cfe-commits
Author: dlj Date: Wed Dec 7 17:41:58 2016 New Revision: 288998 URL: http://llvm.org/viewvc/llvm-project?rev=288998=rev Log: Refactor how the MSVC toolchain searches for a compatibility version. Summary: The MSVC toolchain and Clang driver combination currently uses a fairly complex sequence of

r288997 - Add more tests for MSVC version handling.

2016-12-07 Thread David L. Jones via cfe-commits
Author: dlj Date: Wed Dec 7 17:39:44 2016 New Revision: 288997 URL: http://llvm.org/viewvc/llvm-project?rev=288997=rev Log: Add more tests for MSVC version handling. Summary: This change adds more test cases for the default MSVC compatibility version: 1. When -fms-extensions is supplied, but

r288994 - [Driver] Add tests for default stack protector values on Darwin

2016-12-07 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Wed Dec 7 17:20:30 2016 New Revision: 288994 URL: http://llvm.org/viewvc/llvm-project?rev=288994=rev Log: [Driver] Add tests for default stack protector values on Darwin Modified: cfe/trunk/test/Driver/stack-protector.c Modified: cfe/trunk/test/Driver/stack-protector.c

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-07 Thread Paul Robinson via Phabricator via cfe-commits
probinson added subscribers: cfe-commits, probinson. probinson added a comment. Hi David! As this is a Clang patch, you should subscribe cfe-commits rather than llvm-commits. I've done that for you. See also inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3765 +

[PATCH] D27486: Correct class-template deprecation behavior

2016-12-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Thanks David! To all - I'm actually doing my best to rewrite this based on Richard's suggestions, so look for a 'in progress' update to this review as soon as I get something that is reasonably presentable. https://reviews.llvm.org/D27486

[PATCH] D27486: Correct class-template deprecation behavior

2016-12-07 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:2355 Converted, nullptr); + if (auto *attr = ClassTemplate->getTemplatedDecl() + ->getAttr()) Please

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

2016-12-07 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1240 +/// in the prototype. These are generally tag types or enumerators. +unsigned NumDeclsInPrototype : 8; + It seems plausible that generated code could have more than 256 such

[PATCH] D27546: [ASTReader] Sort RawComments before merging

2016-12-07 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno created this revision. bruno added reviewers: manmanren, akyrtzi, rsmith. bruno added a subscriber: cfe-commits. `RawComments` are sorted by comparing underlying `SourceLocation`'s. This is done by comparing `FileID` and `Offset`; when the `FileID` is the same it means the locations are

[PATCH] D25417: [libcxxabi] Fix alignment of allocated exceptions in 32 bit builds

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 80658. EricWF added a comment. - Use `_aligned_malloc` on windows. - Ensure `posix_memalign` isn't called with a size of `0`. I'm 99% sure that's currently impossible but we might as well handle it. I'll commit after testing on OS X.

[PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

2016-12-07 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: rnk. thakis added subscribers: cfe-commits, rsmith. PCH files store the macro history for a given macro, and the whole history list for one identifier is given to the Preprocessor at once via Preprocessor::setLoadedMacroDirective(). This

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

[PATCH] D27543: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 6/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 6/7.

[PATCH] D27542: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 5/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 5/7. Instead of storing double in double and then truncating to int, store

[PATCH] D27541: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7. Change char to long and remove some char casts. This preserves test

[PATCH] D27540: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7. Add static_cast when constructing pair from (Something,

[PATCH] D27539: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 2/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 2/7. These tests for some guy's transparent operator functors were needlessly

[PATCH] D27538: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 1/7.

2016-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 1/7. Given `std::basic_streambuf::int_type __c`, `std::basic_string str_`,

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. If this caused by a bug it should be marked `XFAIL` and have a comment explaining why it fails and links to the relevant PR's. Feel free to commit after making those changes.

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

2016-12-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 80650. rnk added a comment. - Remove an assert and test that edge case https://reviews.llvm.org/D27279 Files: include/clang/AST/Decl.h include/clang/Sema/DeclSpec.h include/clang/Sema/Sema.h lib/AST/ASTDumper.cpp lib/AST/Decl.cpp

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + amaiorano wrote: > hans wrote: > > I think File would be better than Document when referring to source code. > > >

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

2016-12-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added a subscriber: cfe-commits. Herald added a subscriber: mgorny. When an ObjC property is declared as `(copy)`, and the type of the property is mutable (eg. `NSMutableSomething`), the autosynthesized code for the

[PATCH] D27039: [CodeCompletion] Autocomplete NS_DESIGNATED_INITIALIZER in initializers with arguments

2016-12-07 Thread Manman Ren via Phabricator via cfe-commits
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM Manman Repository: rL LLVM https://reviews.llvm.org/D27039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27520: [clang-tidy] Add check for redundant function pointer dereferences

2016-12-07 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons updated this revision to Diff 80642. malcolm.parsons added a comment. Add to release notes. Remove youtube link. https://reviews.llvm.org/D27520 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked 9 inline comments as done. erichkeane added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3871 +for (auto : FI.arguments()) { + if (Count < 6) +I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall);

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 80641. erichkeane added a comment. Fixing issues brought up by David. https://reviews.llvm.org/D27529 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/TargetInfo.cpp test/CodeGen/vectorcall.c test/CodeGenCXX/homogeneous-aggregates.cpp

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3871 +for (auto : FI.arguments()) { + if (Count < 6) +I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall); majnemer wrote: > erichkeane wrote: > > majnemer

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3871 +for (auto : FI.arguments()) { + if (Count < 6) +I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall); erichkeane wrote: > majnemer wrote: > >

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); majnemer wrote: > erichkeane wrote: > > majnemer wrote: > > >

r288976 - [RecursiveASTVisitor] Improve post-order traversal unit test

2016-12-07 Thread Malcolm Parsons via cfe-commits
Author: malcolm.parsons Date: Wed Dec 7 14:38:20 2016 New Revision: 288976 URL: http://llvm.org/viewvc/llvm-project?rev=288976=rev Log: [RecursiveASTVisitor] Improve post-order traversal unit test Modified: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Modified:

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); erichkeane wrote: > majnemer wrote: > > Formatting. > I don't see

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); majnemer wrote: >

[clang-tools-extra] r288969 - [change-namespace] always add a '::' prefix when a symbol reference needs to be fully-qualified.

2016-12-07 Thread Eric Liu via cfe-commits
Author: ioeric Date: Wed Dec 7 14:08:02 2016 New Revision: 288969 URL: http://llvm.org/viewvc/llvm-project?rev=288969=rev Log: [change-namespace] always add a '::' prefix when a symbol reference needs to be fully-qualified. Modified:

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

2016-12-07 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1688 +for (auto : FI.arguments()) { + if(Count < 6) +I.info = reclassifyHvaArgType(I.type, State, I.info); Formatting. Comment at:

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

2016-12-07 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. This LGTM but Aaron should give the go ahead. Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

2016-12-07 Thread Richard Smith via cfe-commits
On 7 December 2016 at 10:11, Malcolm Parsons wrote: > On 7 December 2016 at 17:56, Richard Smith wrote: > > On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" > > wrote: > > > > Author: malcolm.parsons > >

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

2016-12-07 Thread Artem Belevich via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL288962: [CUDA] Improve target attribute checking for function templates. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D25809?vs=80522=80635#toc Repository: rL LLVM

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-07 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + hans wrote: > I think File would be better than Document when referring to source code. > > But it seems a

r288962 - [CUDA] Improve target attribute checking for function templates.

2016-12-07 Thread Artem Belevich via cfe-commits
Author: tra Date: Wed Dec 7 13:27:16 2016 New Revision: 288962 URL: http://llvm.org/viewvc/llvm-project?rev=288962=rev Log: [CUDA] Improve target attribute checking for function templates. * __host__ __device__ functions are no longer considered to be redeclarations of __host__ or __device__

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + I think File would be better than Document when referring to source code. But it seems a little annoying to need

[PATCH] D27513: Refactor clang's ParseHelper into Support (clang part)

2016-12-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a subscriber: cfe-commits. hans added a comment. I've commented on the llvm side. Adding cfe-commits as well since it affects clang. Repository: rL LLVM https://reviews.llvm.org/D27513 ___ cfe-commits mailing list

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

2016-12-07 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. > I've reverted to 75652 Did you forget to arc diff? Anyway if it's just that if statement, lgtm. https://reviews.llvm.org/D25809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

2016-12-07 Thread Malcolm Parsons via cfe-commits
On 7 December 2016 at 17:56, Richard Smith wrote: > On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" > wrote: > > Author: malcolm.parsons > Date: Wed Dec 7 11:39:04 2016 > New Revision: 288923 > > URL:

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

2016-12-07 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In https://reviews.llvm.org/D25809#615485, @jlebar wrote: > If you would like me to have another look at this, is it possible to make an > interdiff of your changes between this and the last version I reviewed? > phab's interdiff is useless because it straddles a rebase.

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-07 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons updated this revision to Diff 80623. malcolm.parsons added a comment. Remove hasReplacementType matcher. https://reviews.llvm.org/D27166 Files: clang-tidy/modernize/UseAutoCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/modernize-use-auto.rst

[PATCH] D27520: [clang-tidy] Add check for redundant function pointer dereferences

2016-12-07 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/readability-redundant-function-ptr-dereference.rst:7 +Finds redundant dereferences of a function pointer. +See

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

2016-12-07 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1532 + return llvm::ConstantInt::get(ConvertType(DestTy), + CGF.getContext().getTargetNullPtrValue(E->getType())); assert(!DestTy->isBooleanType() && "bool should use PointerToBool");

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

2016-12-07 Thread Richard Smith via cfe-commits
On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: malcolm.parsons Date: Wed Dec 7 11:39:04 2016 New Revision: 288923 URL: http://llvm.org/viewvc/llvm-project?rev=288923=rev Log: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

[PATCH] D26742: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

2016-12-07 Thread Malcolm Parsons via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL288923: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26742?vs=78165=80621#toc Repository: rL LLVM

r288922 - [analyzer] Fix typo in nullability checker diagnostic

2016-12-07 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Wed Dec 7 11:36:27 2016 New Revision: 288922 URL: http://llvm.org/viewvc/llvm-project?rev=288922=rev Log: [analyzer] Fix typo in nullability checker diagnostic 'infered' --> 'inferred' Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp Modified:

[PATCH] D27053: [CodeCompletion] Provide Objective-C class property completion results

2016-12-07 Thread Manman Ren via Phabricator via cfe-commits
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM . Manman Comment at: lib/Sema/SemaCodeComplete.cpp:3763 +if (!M->getSelector().isUnarySelector() || +M->getReturnType()->isVoidType() ||

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-07 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added a comment. ping. https://reviews.llvm.org/D27166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >