r290661 - [CodeGen] Unique constant CompoundLiterals.

Author: gbiv Date: Wed Dec 28 01:27:40 2016 New Revision: 290661 URL: http://llvm.org/viewvc/llvm-project?rev=290661=rev Log: [CodeGen] Unique constant CompoundLiterals. Our newly aggressive constant folding logic makes it possible for CGExprConstant to see the same CompoundLiteralExpr more than

[PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

EricWF abandoned this revision. EricWF added a comment. Another version of this has already been committed. https://reviews.llvm.org/D24599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23495: Remove std::tuple's reduced-arity-extension on implicit constructors.

EricWF abandoned this revision. EricWF added a comment. Another version of this has already been committed. https://reviews.llvm.org/D23495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20800: Make placeholders constexpr in C++17

EricWF abandoned this revision. EricWF added a comment. Already committed. https://reviews.llvm.org/D20800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

EricWF abandoned this revision. EricWF added a comment. This is long dead. https://reviews.llvm.org/D13796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13332: [libcxx] Remove uses of std::unique_ptr<T[N]> from test to prevent warning.

EricWF abandoned this revision. EricWF added a comment. This was already committed. https://reviews.llvm.org/D13332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r290660 - Mark 'auto' as dependent when instantiating the type of a non-type template

Author: rsmith Date: Wed Dec 28 00:27:18 2016 New Revision: 290660 URL: http://llvm.org/viewvc/llvm-project?rev=290660=rev Log: Mark 'auto' as dependent when instantiating the type of a non-type template parameter. Fixes failed deduction for 'auto' non-type template parameters nested within

[libcxx] r290659 - Remove dead debug_mode doc link

Author: ericwf Date: Wed Dec 28 00:21:09 2016 New Revision: 290659 URL: http://llvm.org/viewvc/llvm-project?rev=290659=rev Log: Remove dead debug_mode doc link Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL:

[libcxx] r290658 - Ensure <__debug> gets the nullptr definition in C++03

Author: ericwf Date: Wed Dec 28 00:15:01 2016 New Revision: 290658 URL: http://llvm.org/viewvc/llvm-project?rev=290658=rev Log: Ensure <__debug> gets the nullptr definition in C++03 Modified: libcxx/trunk/include/__debug Modified: libcxx/trunk/include/__debug URL:

[libcxx] r290657 - Fix debug mode for vector/list and cleanup tests

Author: ericwf Date: Wed Dec 28 00:06:09 2016 New Revision: 290657 URL: http://llvm.org/viewvc/llvm-project?rev=290657=rev Log: Fix debug mode for vector/list and cleanup tests Added: libcxx/trunk/test/libcxx/debug/containers/db_associative_container_tests.pass.cpp

[libcxx] r290656 - Fix stupid build error caused by a stupid person

Author: ericwf Date: Tue Dec 27 23:56:16 2016 New Revision: 290656 URL: http://llvm.org/viewvc/llvm-project?rev=290656=rev Log: Fix stupid build error caused by a stupid person Modified: libcxx/trunk/include/__debug Modified: libcxx/trunk/include/__debug URL:

[libcxx] r290655 - Add tests for unordered container tests and std::string

Author: ericwf Date: Tue Dec 27 23:53:01 2016 New Revision: 290655 URL: http://llvm.org/viewvc/llvm-project?rev=290655=rev Log: Add tests for unordered container tests and std::string Added: libcxx/trunk/test/libcxx/debug/containers/

[libcxx] r290654 - Fix __wrap_iter in debug mode and apply _NOEXCEPT_DEBUG to it

Author: ericwf Date: Tue Dec 27 23:35:32 2016 New Revision: 290654 URL: http://llvm.org/viewvc/llvm-project?rev=290654=rev Log: Fix __wrap_iter in debug mode and apply _NOEXCEPT_DEBUG to it Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/iterator Modified:

[libcxx] r290653 - Fix build errors in C++03 caused by recent debug changes

Author: ericwf Date: Tue Dec 27 23:26:56 2016 New Revision: 290653 URL: http://llvm.org/viewvc/llvm-project?rev=290653=rev Log: Fix build errors in C++03 caused by recent debug changes Modified: libcxx/trunk/include/__debug libcxx/trunk/test/libcxx/debug/debug_throw.pass.cpp Modified:

[libcxx] r290652 - Fix debug mode build w/o exceptions

Author: ericwf Date: Tue Dec 27 23:20:27 2016 New Revision: 290652 URL: http://llvm.org/viewvc/llvm-project?rev=290652=rev Log: Fix debug mode build w/o exceptions Modified: libcxx/trunk/include/__debug libcxx/trunk/lib/abi/CHANGELOG.TXT libcxx/trunk/src/debug.cpp Modified:

[libcxx] r290651 - Implement a throwing version of _LIBCPP_ASSERT.

Author: ericwf Date: Tue Dec 27 22:58:52 2016 New Revision: 290651 URL: http://llvm.org/viewvc/llvm-project?rev=290651=rev Log: Implement a throwing version of _LIBCPP_ASSERT. This patch implements changes to allow _LIBCPP_ASSERT to throw on failure instead of aborting. The main changes needed

[libcxxabi] r290650 - add cxa_demangle_fuzzer

Author: kcc Date: Tue Dec 27 21:28:29 2016 New Revision: 290650 URL: http://llvm.org/viewvc/llvm-project?rev=290650=rev Log: add cxa_demangle_fuzzer Summary: All easy-to-find bugs in cxa_demangle where fixed now (https://bugs.chromium.org/p/chromium/issues/detail?id=606626) except for one

[PATCH] D28133: add cxa_demangle_fuzzer

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. (I can't test because LLVM_USE_SANITIZE_COVERAGE seems broken on Darwin) https://reviews.llvm.org/D28133 ___ cfe-commits

[PATCH] D28133: add cxa_demangle_fuzzer

kcc updated this revision to Diff 82571. kcc added a comment. remove unneeded set(LLVM_LINK_COMPONENTS support) https://reviews.llvm.org/D28133 Files: CMakeLists.txt fuzz/ fuzz/CMakeLists.txt fuzz/cxa_demangle_fuzzer.cpp Index: fuzz/cxa_demangle_fuzzer.cpp

[PATCH] D28133: add cxa_demangle_fuzzer

kcc marked an inline comment as done. kcc added a comment. yes, removed. https://reviews.llvm.org/D28133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r290647 - DR1315: a non-type template argument in a partial specialization is permitted

Author: rsmith Date: Tue Dec 27 20:37:25 2016 New Revision: 290647 URL: http://llvm.org/viewvc/llvm-project?rev=290647=rev Log: DR1315: a non-type template argument in a partial specialization is permitted to make reference to template parameters. This is only a partial implementation; we retain

[PATCH] D28133: add cxa_demangle_fuzzer

mehdi_amini added inline comments. Comment at: fuzz/CMakeLists.txt:3 +if( LLVM_USE_SANITIZE_COVERAGE ) + set(LLVM_LINK_COMPONENTS support) + This is a dependency on libLLVMSupport right? Why is this needed? https://reviews.llvm.org/D28133

[PATCH] D28133: add cxa_demangle_fuzzer

kcc created this revision. kcc added reviewers: compnerd, mehdi_amini, mclow.lists. kcc added a subscriber: cfe-commits. Herald added a subscriber: mgorny. All easy-to-find bugs in cxa_demangle where fixed now (https://bugs.chromium.org/p/chromium/issues/detail?id=606626) except for one

r290642 - Update test that relies on the optimizer to match new output.

Author: mkuper Date: Tue Dec 27 18:30:43 2016 New Revision: 290642 URL: http://llvm.org/viewvc/llvm-project?rev=290642=rev Log: Update test that relies on the optimizer to match new output. Modified: cfe/trunk/test/CodeGen/avx-shuffle-builtins.c Modified:

Re: r290533 - Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows

On Tue, Dec 27, 2016 at 12:41:08PM -0800, Saleem Abdulrasool wrote: > Id really rather not change the behavior. We would generate ELF style PIC, > which obviously doesn't work. That's not what I mean. I simply say that we should ignore -fPIC/-fpic/-fPIE/-fpie on Windows, silently. The relality

[PATCH] D28131: [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.

EricWF created this revision. EricWF added reviewers: mclow.lists, vsk. EricWF added a subscriber: cfe-commits. This patch fixes llvm.org/PR31402 by replacing `map::__find_equal_key` with `__tree::__find_equal`, which has already addressed the same undefined behavior. Unfortunately I haven't

[clang-tools-extra] r290633 - [clang-tidy] Make 2 checks register matchers for C++ only.

Author: malcolm.parsons Date: Tue Dec 27 16:14:40 2016 New Revision: 290633 URL: http://llvm.org/viewvc/llvm-project?rev=290633=rev Log: [clang-tidy] Make 2 checks register matchers for C++ only. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseEqualsDeleteCheck.cpp

r290631 - DebugInfo: Don't include size/alignment on class declarations

Author: dblaikie Date: Tue Dec 27 16:05:35 2016 New Revision: 290631 URL: http://llvm.org/viewvc/llvm-project?rev=290631=rev Log: DebugInfo: Don't include size/alignment on class declarations This seems like it must've been a leftover by accident - no tests were backing it up & it doesn't make

[clang-tools-extra] r290630 - [clang-tidy] Replace dead link in modernize-pass-by-value doc

Author: malcolm.parsons Date: Tue Dec 27 16:01:37 2016 New Revision: 290630 URL: http://llvm.org/viewvc/llvm-project?rev=290630=rev Log: [clang-tidy] Replace dead link in modernize-pass-by-value doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-pass-by-value.rst

[libcxx] r290627 - Implement P0435R1 - Resolving LWG issues for common_type

Author: ericwf Date: Tue Dec 27 15:16:48 2016 New Revision: 290627 URL: http://llvm.org/viewvc/llvm-project?rev=290627=rev Log: Implement P0435R1 - Resolving LWG issues for common_type Modified: libcxx/trunk/include/type_traits

Re: r290533 - Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows

Id really rather not change the behavior. We would generate ELF style PIC, which obviously doesn't work. On Tue, Dec 27, 2016 at 10:09 AM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Dec 26, 2016 at 03:35:25AM -, Saleem Abdulrasool via > cfe-commits

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

amaiorano added a comment. Thank you, @ioeric for your feedback! Comment at: include/clang/Format/Format.h:862 /// /// \returns FormatStyle as specified by ``StyleName``. If no style could be /// determined, the default is LLVM Style (see ``getLLVMStyle()``).

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

malcolm.parsons accepted this revision. malcolm.parsons added a comment. LGTM! https://reviews.llvm.org/D27210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r290593 - DR1495: A partial specialization is ill-formed if it is not (strictly) more

On 27 December 2016 at 10:41, Richard Smith wrote: > On 27 Dec 2016 1:42 am, "Chandler Carruth via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > I suspect that this commit is responsible for a regression parsing widely > used open source packages like Eigen. > >

r290625 - Add warning flag for "partial specialization is not more specialized than primary template" error (since Eigen hits it), and while I'm here also add a warning flag for "partial specializatio

Author: rsmith Date: Tue Dec 27 14:03:09 2016 New Revision: 290625 URL: http://llvm.org/viewvc/llvm-project?rev=290625=rev Log: Add warning flag for "partial specialization is not more specialized than primary template" error (since Eigen hits it), and while I'm here also add a warning flag for

Re: r290593 - DR1495: A partial specialization is ill-formed if it is not (strictly) more

Hi Eigen folks, Clang (and GCC) recently implemented C++ DR 1495 (wg21.link/cwg1495), which says that a class template partial specialization is ill-formed if it is not more specialized than the primary template. (If we imagine the primary template had a corresponding partial specialization, we

[libcxx] r290624 - Fix PR31481 - 3+ parameter common_type isn't SFINAE friendly

Author: ericwf Date: Tue Dec 27 13:59:50 2016 New Revision: 290624 URL: http://llvm.org/viewvc/llvm-project?rev=290624=rev Log: Fix PR31481 - 3+ parameter common_type isn't SFINAE friendly Modified: libcxx/trunk/include/type_traits

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

ioeric added inline comments. Comment at: include/clang/Format/Format.h:862 /// /// \returns FormatStyle as specified by ``StyleName``. If no style could be /// determined, the default is LLVM Style (see ``getLLVMStyle()``). Is this still true?

[PATCH] D27850: [libcxx] add missing constexpr to optional::value_or

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The changes to `` LGTM but not the ones to `` Unfortunately libc++'s `` doesn't yet implement LFTS v2 so all of the other non-const observers are also not constexpr in our implementation. I

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

Both work: #define DECLARE_ASM_REP_MOVS(Type, Movs) \ template <> void asm_rep_movs(Type * dst, Type * src, size_t size) { \ __asm__("rep " Movs " \n\t" \ : "+D"(dst), "+S"(src), "+c"(size) \ : \ : "memory"); \

[PATCH] D27850: [libcxx] add missing constexpr to optional::value_or

cpplearner updated this revision to Diff 82551. https://reviews.llvm.org/D27850 Files: include/experimental/optional include/optional test/std/experimental/optional/optional.object/optional.object.observe/value_or.pass.cpp

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

rnk added a comment. I think you uploaded the wrong patch on the last upload, the code looks like it's related to __attribute__((deprecated)) now? https://reviews.llvm.org/D27529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r290619 - [DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics.

Author: kromanova Date: Tue Dec 27 12:53:29 2016 New Revision: 290619 URL: http://llvm.org/viewvc/llvm-project?rev=290619=rev Log: [DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics. Added \n commands to insert a line breaks where necessary, since one long line of documentation is

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. I guess it doesn't build because output constraints need "=" (e.g., "=D")? Also, I think all registers ("D", "S", and "c") should be in both the output and input operands list. You can probably declare new variables and use them in the output operands (e.g.,

[PATCH] D27850: [libcxx] add missing constexpr to optional::value_or

cpplearner updated this revision to Diff 82549. cpplearner added a comment. test updated https://reviews.llvm.org/D27850 Files: test/std/utilities/optional/optional.object/optional.object.observe/value_or.pass.cpp Index:

Re: r290593 - DR1495: A partial specialization is ill-formed if it is not (strictly) more

On 27 Dec 2016 1:42 am, "Chandler Carruth via cfe-commits" < cfe-commits@lists.llvm.org> wrote: I suspect that this commit is responsible for a regression parsing widely used open source packages like Eigen. See the code in Eigen here:

[PATCH] D28125: [OpenMP] Update target codegen for NVPTX device.

arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, kkwli0, caomhin. arpith-jacob added a subscriber: cfe-commits. Herald added subscribers: aprantl, jholewinski. This patch includes updates for codegen of the target region for the NVPTX device. It

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

myatsina added a comment. In https://reviews.llvm.org/D15075#631316, @ahatanak wrote: > In https://reviews.llvm.org/D15075#631237, @myatsina wrote: > > > In https://reviews.llvm.org/D15075#631207, @vitalybuka wrote: > > > > > These patches break asan tests: > > >

Re: r290533 - Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows

On Mon, Dec 26, 2016 at 03:35:25AM -, Saleem Abdulrasool via cfe-commits wrote: > Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows Can we please invert this behavior? Complain if the effective PIC mode is not level 2 and silently ignore it otherwise? I find the MinGW warnings to be highly

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. In https://reviews.llvm.org/D15075#631237, @myatsina wrote: > In https://reviews.llvm.org/D15075#631207, @vitalybuka wrote: > > > These patches break asan tests: > >

[PATCH] D28124: [OpenMP] Code cleanup for NVPTX OpenMP codegen

arpith-jacob created this revision. arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, kkwli0, caomhin. arpith-jacob added a subscriber: cfe-commits. Herald added a subscriber: jholewinski. This patch cleans up private methods for NVPTX OpenMP codegen. It converts private members

[clang-tools-extra] r290605 - Attempt to fix non-determinism in tests.

Author: xazax Date: Tue Dec 27 05:56:54 2016 New Revision: 290605 URL: http://llvm.org/viewvc/llvm-project?rev=290605=rev Log: Attempt to fix non-determinism in tests. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-suspicious-enum-usage-strict.cpp Modified:

[PATCH] D26167: [Clang-tidy] check for malloc, realloc and free calls

kimgr added a comment. Minor spelling nits inline Comment at: clang-tidy/cppcoreguidelines/NoMallocCheck.cpp:30 + callExpr(callee(functionDecl(hasAnyName("::malloc", "::calloc" + .bind("aquisition"), + this); Spelling nit: acquisition

[clang-tools-extra] r290600 - [clang-tidy] Add enum misuse check.

Author: xazax Date: Tue Dec 27 04:07:39 2016 New Revision: 290600 URL: http://llvm.org/viewvc/llvm-project?rev=290600=rev Log: [clang-tidy] Add enum misuse check. The checker detects various cases when an enum is probably misused (as a bitmask). Patch by: Peter Szecsi! Differential Revision:

[PATCH] D22507: Clang-tidy - Enum misuse check

This revision was automatically updated to reflect the committed changes. Closed by commit rL290600: [clang-tidy] Add enum misuse check. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D22507?vs=82488=82533#toc Repository: rL LLVM https://reviews.llvm.org/D22507

Re: r290593 - DR1495: A partial specialization is ill-formed if it is not (strictly) more

I suspect that this commit is responsible for a regression parsing widely used open source packages like Eigen. See the code in Eigen here:

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

myatsina added a comment. In https://reviews.llvm.org/D15075#631207, @vitalybuka wrote: > These patches break asan tests: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/528/steps/check-asan%20in%20gcc%20build/logs/stdio Vitaly , This patch is a gcc compatibility issue and

Re: r290577 - Add a test for `const` folding introduced by r290297. NFC.

Great, thanks! On 26 December 2016 at 21:44, George Burgess IV wrote: > r290584 :) > > On Mon, Dec 26, 2016 at 8:30 PM, George Burgess IV < > george.burgess...@gmail.com> wrote: > >> SG; working on a follow-up now. Thanks! >> >> On Mon, Dec 26, 2016 at 8:26 PM,

r290593 - DR1495: A partial specialization is ill-formed if it is not (strictly) more

Author: rsmith Date: Tue Dec 27 01:56:27 2016 New Revision: 290593 URL: http://llvm.org/viewvc/llvm-project?rev=290593=rev Log: DR1495: A partial specialization is ill-formed if it is not (strictly) more specialized than the primary template. (Put another way, if we imagine there were a partial