[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode added a comment. Yes, please. Thanks for you time :) https://reviews.llvm.org/D29724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. LGTM, do you need someone to commit for you? https://reviews.llvm.org/D29724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

LLVM buildmaster will be updated and restarted tonight

2017-02-11 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 8 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r294879 - [Driver] Use stem() and not filename().

2017-02-11 Thread Davide Italiano via cfe-commits
On Sat, Feb 11, 2017 at 4:19 PM, Rui Ueyama wrote: > On Sat, Feb 11, 2017 at 3:44 PM, Davide Italiano via cfe-commits > wrote: >> >> Author: davide >> Date: Sat Feb 11 17:44:37 2017 >> New Revision: 294879 >> >> URL:

Re: r294879 - [Driver] Use stem() and not filename().

2017-02-11 Thread Rui Ueyama via cfe-commits
On Sat, Feb 11, 2017 at 3:44 PM, Davide Italiano via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: davide > Date: Sat Feb 11 17:44:37 2017 > New Revision: 294879 > > URL: http://llvm.org/viewvc/llvm-project?rev=294879=rev > Log: > [Driver] Use stem() and not filename(). > > On

r294879 - [Driver] Use stem() and not filename().

2017-02-11 Thread Davide Italiano via cfe-commits
Author: davide Date: Sat Feb 11 17:44:37 2017 New Revision: 294879 URL: http://llvm.org/viewvc/llvm-project?rev=294879=rev Log: [Driver] Use stem() and not filename(). On Windows the filename might have an extension, namely `.exe`, so the search will fail. Sorry, I don't have a good way to test

[PATCH] D29868: Recover more gracefully when __declspec is not supported as a keyword

2017-02-11 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: lib/Parse/ParseDecl.cpp:2973 + // recognize that scenario and recover gracefully. + if (!getLangOpts().MicrosoftExt && Tok.is(tok::identifier) && + Tok.getIdentifierInfo()->getName().equals("__declspec")) {

r294877 - CodeGen: use # as the comment leader for ARC marker

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 17:03:13 2017 New Revision: 294877 URL: http://llvm.org/viewvc/llvm-project?rev=294877=rev Log: CodeGen: use # as the comment leader for ARC marker Use # as the comment leader for AArch64 auto-release elision marker. This is to keep it in sync with the value

r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 15:34:18 2017 New Revision: 294872 URL: http://llvm.org/viewvc/llvm-project?rev=294872=rev Log: CodeGen: annotate ObjC ARC functions with ABI constraints Certain ARC runtime functions have an ABI contract of being forwarding. Annotate the functions with the

r294871 - test: ignore some warnings in test code (NFC)

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 15:34:15 2017 New Revision: 294871 URL: http://llvm.org/viewvc/llvm-project?rev=294871=rev Log: test: ignore some warnings in test code (NFC) Silence some diagnostics which clang now generates. This makes it easier to see the failures in lit output. NFC.

[PATCH] D29868: Recover more gracefully when __declspec is not supported as a keyword

2017-02-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. In r238238, we removed __declspec as a universally-accepted keyword -- instead, it is only enabled as a supported keyword when -fms-extensions or -fdeclspec is passed to the driver. However, this had an unfortunate side-effect in that it made for bad

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

2017-02-11 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg requested changes to this revision. joerg added inline comments. This revision now requires changes to proceed. Comment at: lib/CodeGen/CodeGenModule.cpp:2402 + return GetOrCreateLLVMGlobal(Name, llvm::PointerType::getUnqual(Ty), nullptr, +

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

2017-02-11 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay added a comment. Done, thanks for the patch @Lekensteyn! If you plan on submitting more patches, feel free to ask for commit access . Repository: rL LLVM https://reviews.llvm.org/D29817

r294869 - [AVR] Fix __AVR_xxx macro definitions; authored by Peter Wu

2017-02-11 Thread Dylan McKay via cfe-commits
Author: dylanmckay Date: Sat Feb 11 15:06:07 2017 New Revision: 294869 URL: http://llvm.org/viewvc/llvm-project?rev=294869=rev Log: [AVR] Fix __AVR_xxx macro definitions; authored by Peter Wu Summary: The -mmcu option for GCC sets macros like __AVR_ATmega328P__ (with the trailing underscores),

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

2017-02-11 Thread Dylan McKay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294869: [AVR] Fix __AVR_xxx macro definitions; authored by Peter Wu (authored by dylanmckay). Changed prior to commit: https://reviews.llvm.org/D29817?vs=88025=88104#toc Repository: rL LLVM

[PATCH] D29692: [clang-tidy] add check modernize-use-const-instead-of-define

2017-02-11 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin updated this revision to Diff 88103. AlexanderLanin marked 2 inline comments as done. AlexanderLanin added a comment. Fixes as reported in review https://reviews.llvm.org/D29692 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D29692: [clang-tidy] add check modernize-use-const-instead-of-define

2017-02-11 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin marked 9 inline comments as done. AlexanderLanin added a comment. Not sure about CppCoreGuidelines as several guidelines have the same rule and I only used CppCoreGuidelines as it's convenient to link a specific rule. But I can move it if you like?! Comment

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode updated this revision to Diff 88101. idlecode added a comment. Addressed Richard's inline comment. https://reviews.llvm.org/D29724 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Frontend/LangStandard.h include/clang/Frontend/LangStandards.def

Re: r294855 - docs: update docs for objc_storeStrong behaviour

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Hi Hans, Would you mind grabbing this for the 4.0 release as well? It's merely correcting the documentation, so should have no impact on the toolchain itself. On Sat, Feb 11, 2017 at 9:24 AM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Sat

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Frontend/CompilerInvocation.cpp:1753-1754 + KindValue != LangStandard::lang_unspecified; + ++KindValue) + { +const

Re: r293199 - Turn on -Wblock-capture-autoreleasing by default.

2017-02-11 Thread Nico Weber via cfe-commits
Hi Akira, this fires in internal chrome/ios code like so: somefile.m: error: block captures an autoreleasing out-parameter, which may result in use-after-free bugs [-Werror,-Wblock-capture-autoreleasing] if (error) { ^ somefile.m: note: declare the parameter

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-11 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode updated this revision to Diff 88100. idlecode added a comment. Displayed standards will now match processed file kind https://reviews.llvm.org/D29724 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Frontend/LangStandard.h

r294862 - Hopefully fixes a compile error introduced by r294861.

2017-02-11 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Feb 11 12:00:32 2017 New Revision: 294862 URL: http://llvm.org/viewvc/llvm-project?rev=294862=rev Log: Hopefully fixes a compile error introduced by r294861. Modified: cfe/trunk/include/clang/AST/TypeLoc.h Modified: cfe/trunk/include/clang/AST/TypeLoc.h URL:

r294861 - Attributes on K C functions should not cause incompatible function type with a redeclaration having the same attribute. Fixing this introduced a secondary problem where we were assuming th

2017-02-11 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Feb 11 11:49:53 2017 New Revision: 294861 URL: http://llvm.org/viewvc/llvm-project?rev=294861=rev Log: Attributes on K C functions should not cause incompatible function type with a redeclaration having the same attribute. Fixing this introduced a secondary

[PATCH] D28166: Properly merge K functions that have attributes

2017-02-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r294861. https://reviews.llvm.org/D28166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r294854 - CodeGen: rename variables to adhere to naming convention

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:07 2017 New Revision: 294854 URL: http://llvm.org/viewvc/llvm-project?rev=294854=rev Log: CodeGen: rename variables to adhere to naming convention Adjust style before making more intrusive changes. NFC. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp

r294853 - Sema: simplify conditional execution (NFC)

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:04 2017 New Revision: 294853 URL: http://llvm.org/viewvc/llvm-project?rev=294853=rev Log: Sema: simplify conditional execution (NFC) The conditional cast is unnecessary since we know that it will always succeed. NFC. Modified:

r294855 - docs: update docs for objc_storeStrong behaviour

2017-02-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Feb 11 11:24:09 2017 New Revision: 294855 URL: http://llvm.org/viewvc/llvm-project?rev=294855=rev Log: docs: update docs for objc_storeStrong behaviour objc_storeStrong does not return a value. Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

2017-02-11 Thread Peter Wu via Phabricator via cfe-commits
Lekensteyn added a comment. In https://reviews.llvm.org/D29817#674306, @dylanmckay wrote: > Do you have commit access @Lekensteyn? No I do not, please push it for me :-) https://reviews.llvm.org/D29817 ___ cfe-commits mailing list

r294838 - Make helpers static. NFC.

2017-02-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Feb 11 06:21:17 2017 New Revision: 294838 URL: http://llvm.org/viewvc/llvm-project?rev=294838=rev Log: Make helpers static. NFC. Modified: cfe/trunk/lib/Analysis/OSLog.cpp cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Analysis/OSLog.cpp URL:

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

2017-02-11 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D29839#674315, @xazax.hun wrote: > In https://reviews.llvm.org/D29839#674307, @Prazek wrote: > > > In https://reviews.llvm.org/D29839#674301, @xazax.hun wrote: > > > > > Shouldn't this be a path sensitive check within the clang static analyzer

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

2017-02-11 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In https://reviews.llvm.org/D29839#674307, @Prazek wrote: > In https://reviews.llvm.org/D29839#674301, @xazax.hun wrote: > > > Shouldn't this be a path sensitive check within the clang static analyzer > > instead? So branches are properly handled and interprocedural

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

2017-02-11 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88088. EricWF added a comment. - Fix the initializer list constructors. - Add tests for almost every constructor. The following two examples still do not work: std::basic_string s1("hello world", 2); // deduces Allocator = int std::basic_string s2("hello

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

2017-02-11 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/string:782 _LIBCPP_INLINE_VISIBILITY basic_string(const value_type* __s, size_type __n); _LIBCPP_INLINE_VISIBILITY rsmith wrote: > Did you skip this one intentionally? Yes. `size_type` is a

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

2017-02-11 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D29839#674301, @xazax.hun wrote: > Shouldn't this be a path sensitive check within the clang static analyzer > instead? So branches are properly handled and interprocedural analysis is > done. Do you have some examples? I would argue, that

[PATCH] D29817: [AVR] Fix __AVR_xxx macro definitions

2017-02-11 Thread Dylan McKay via Phabricator via cfe-commits
dylanmckay added a comment. Do you have commit access @Lekensteyn? https://reviews.llvm.org/D29817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29839: [clang-tidy] New misc-istream-overflow check

2017-02-11 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Shouldn't this be a path sensitive check within the clang static analyzer instead? So branches are properly handled and interprocedural analysis is done. https://reviews.llvm.org/D29839 ___ cfe-commits mailing list

[PATCH] D15227: [analyzer] Valist checkers.

2017-02-11 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In https://reviews.llvm.org/D15227#674278, @zaks.anna wrote: > @xazax.hun, > > Can we move this out of alpha? > > Have this checkers been tested on a large codebase? What are false positive > rates? I have tested it on a few ~200k LOC C codebase and I did not see

[libcxx] r294833 - Remove a now unneeded __CloudABI__ check.

2017-02-11 Thread Ed Schouten via cfe-commits
Author: ed Date: Sat Feb 11 02:33:16 2017 New Revision: 294833 URL: http://llvm.org/viewvc/llvm-project?rev=294833=rev Log: Remove a now unneeded __CloudABI__ check. CloudABI has gained the setlocale() function in the meantime, meaning there is no longer a need to conditionalize this.

[libcxx] r294832 - Fix the build of thread.cpp on CloudABI.

2017-02-11 Thread Ed Schouten via cfe-commits
Author: ed Date: Sat Feb 11 02:30:18 2017 New Revision: 294832 URL: http://llvm.org/viewvc/llvm-project?rev=294832=rev Log: Fix the build of thread.cpp on CloudABI. CloudABI does provide unistd.h, but doesn't define __unix__. We need to include this header file to make hardware_concurrency work.

[PATCH] D29739: Make Lit tests C++11 compatible - Objective-C++

2017-02-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D29739#674288, @probinson wrote: > In https://reviews.llvm.org/D29739#673971, @rjmccall wrote: > > > In https://reviews.llvm.org/D29739#673933, @tigerleapgorge wrote: > > > > > Hi John, > > > > > > Here is the most recent discussion I can