[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// mgorny wrote: > Hahnfeld wrote: > > pirama wrote: > > > pirama wrote: > > > > I feel this test is

[libcxx] r295428 - Use inline namespaces with GCC instead of __attribute__((__strong__)).

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 17 01:31:38 2017 New Revision: 295428 URL: http://llvm.org/viewvc/llvm-project?rev=295428&view=rev Log: Use inline namespaces with GCC instead of __attribute__((__strong__)). GCC 7.0.1 started warning that __attribute__((__strong__)) is depricated. This patch switches

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Thanks. The -L tests look good, -rpath is not perfect but I don't think you can improve it without additional changes to the Driver. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES

r295427 - Revert r295421, new ODR checker for modules, to fix build bot.

2017-02-16 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Feb 17 01:19:24 2017 New Revision: 295427 URL: http://llvm.org/viewvc/llvm-project?rev=295427&view=rev Log: Revert r295421, new ODR checker for modules, to fix build bot. Removed: cfe/trunk/include/clang/AST/ODRHash.h cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/te

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Please adapt the title and summary for the more general changes this has evolved to. Comment at: lib/Driver/Tools.cpp:284 +// If we are not cross-compling, add '-rpath' with architecture-specific +// library path so libraries lined from this p

[libcxx] r295423 - Remove dead code in test

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 17 01:00:04 2017 New Revision: 295423 URL: http://llvm.org/viewvc/llvm-project?rev=295423&view=rev Log: Remove dead code in test Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/implicit_deduction_guides.pass.cpp Modified: libcxx/trunk/test/

[libcxx] r295422 - add implicit deduction guide tests for string_view

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 17 00:59:11 2017 New Revision: 295422 URL: http://llvm.org/viewvc/llvm-project?rev=295422&view=rev Log: add implicit deduction guide tests for string_view Added: libcxx/trunk/test/std/strings/string.view/string.view.cons/implicit_deduction_guides.pass.cpp Added:

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88861. EricWF marked an inline comment as done. EricWF added a comment. Address @majnemer's comments. https://reviews.llvm.org/D30082 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-template-deduction-guide.cpp Index: test/CodeGenCXX/debu

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF marked an inline comment as done. EricWF added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2479 +case Type::DeducedTemplateSpecialization: { + QualType DT = dyn_cast(T)->getDeducedType(); + assert(!DT.isNull() && "Undeduced types shouldn't reach

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

2017-02-16 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2479 +case Type::DeducedTemplateSpecialization: { + QualType DT = dyn_cast(T)->getDeducedType(); + assert(!DT.isNull() && "Undeduced types shouldn't reach here."); You are uncon

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88859. EricWF added a comment. Remove unintentional changes. https://reviews.llvm.org/D30082 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-template-deduction-guide.cpp Index: test/CodeGenCXX/debug-info-template-deduction-guide.cpp =

Re: r295379 - Properly set up the DeclContext for parameters of implicit deduction guides;

2017-02-16 Thread Eric Fiselier via cfe-commits
I put my attempt to fix this up for review: https://reviews.llvm.org/D30082 On Thu, Feb 16, 2017 at 10:17 PM, Eric Fiselier wrote: > Hi Richard, > > One more issue. When compiling with `-g` the following code hits a > `llvm_unreachable` in CGDebugInfo::CreateTypeNode. > > template struct S { S

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. Herald added a subscriber: aprantl. Currently the following code hits an `llvm_unreachable` in `CGDebugInfo::CreateTypeNode` because `DeducedTemplateSpecialization` isn't handled. // clang++ -std=c++1z -g test.cpp template struct S { S(T) {} }; S s(42); Th

r295421 - Add better ODR checking for modules.

2017-02-16 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Feb 16 23:54:30 2017 New Revision: 295421 URL: http://llvm.org/viewvc/llvm-project?rev=295421&view=rev Log: Add better ODR checking for modules. A slightly weaker form of ODR checking than previous attempts, but hopefully won't break the modules build bot. Future work wi

Re: r295379 - Properly set up the DeclContext for parameters of implicit deduction guides;

2017-02-16 Thread Eric Fiselier via cfe-commits
Hi Richard, One more issue. When compiling with `-g` the following code hits a `llvm_unreachable` in CGDebugInfo::CreateTypeNode. template struct S { S(T) {} }; S s(42); /Eric On Thu, Feb 16, 2017 at 2:29 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith

[libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 23:04:09 2017 New Revision: 295417 URL: http://llvm.org/viewvc/llvm-project?rev=295417&view=rev Log: Work around Clang assertion when testing C++17 deduction guides with '-g'. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

2017-02-16 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 88854. smeenai added a comment. Rebase https://reviews.llvm.org/D29157 Files: include/__config include/locale include/string Index: include/string === --- include/string +++ include/str

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

2017-02-16 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Will do the rebase. Comment at: include/locale:626 template +_LIBCPP_HIDDEN iter_type __do_get_floating_point EricWF wrote: > After applying the changes to `__config` but not this header > `check-cxx-abilist` didn't repo

r295416 - [index] Improvde how we handle synthesized ObjC properties and the associated ivars.

2017-02-16 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Thu Feb 16 22:49:41 2017 New Revision: 295416 URL: http://llvm.org/viewvc/llvm-project?rev=295416&view=rev Log: [index] Improvde how we handle synthesized ObjC properties and the associated ivars. Related synthesized properties with the ivar they use with the 'accessor'

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88852. EricWF added a comment. - Update so that it merges with https://reviews.llvm.org/D26057 https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp lib/Sema/SemaExprMember.cpp test/CodeGenCorout

[libcxxabi] r295411 - Fix test_exception_storage.pass.cpp in C++17 my re-enabling the unexpected handlers

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 22:26:22 2017 New Revision: 295411 URL: http://llvm.org/viewvc/llvm-project?rev=295411&view=rev Log: Fix test_exception_storage.pass.cpp in C++17 my re-enabling the unexpected handlers Modified: libcxxabi/trunk/test/test_exception_storage.pass.cpp Modified: l

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

2017-02-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. LGTM. https://reviews.llvm.org/D29986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24812: Lit C++11 Compatibility Patch #11

2017-02-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D24812#678931, @tigerleapgorge wrote: > @rjmccall > > Hi John, I've made the changes to volatile.cpp. > I take it this patch is good for commit? Yes, I think I have the information I wanted from Reid. LGTM. https://reviews.llvm.org/D2481

[PATCH] D24812: Lit C++11 Compatibility Patch #11

2017-02-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: test/CodeGenCXX/static-init.cpp:14 +// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8 +// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global

[PATCH] D29806: [clang-tidy] Add -path option to clang-tidy-diff.py

2017-02-16 Thread Ehsan Akhgari via Phabricator via cfe-commits
ehsan added a comment. Gentle ping. :-) https://reviews.llvm.org/D29806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30045: Remove `std::random_shuffle` in C++17

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. @mclow.lists A couple of additional things: - Add `_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE` to the `_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES` list in `__config`. - Add a test for that in `test/libcxx/depr/enable_removed_cpp17_features.pass.cpp` Comme

[libcxx] r295407 - Add doc for _LIBCPP_ENABLE_CXX17_DISABLED_AUTO_PTR and make it work under _LIBCPP_ENABLE_CXX17_REMOVED_FEATURES

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 21:30:25 2017 New Revision: 295407 URL: http://llvm.org/viewvc/llvm-project?rev=295407&view=rev Log: Add doc for _LIBCPP_ENABLE_CXX17_DISABLED_AUTO_PTR and make it work under _LIBCPP_ENABLE_CXX17_REMOVED_FEATURES Modified: libcxx/trunk/docs/UsingLibcxx.rst

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-16 Thread David Herzka via Phabricator via cfe-commits
herzka added a comment. Currently, `A.customGetterProperty` would be turned into `[A customGetterProperty]`, which would fail to compile because that selector isn't declared anywhere. With my fix, it does compile because it (correctly) resolves to `[A customGet]`, which does exist. Similarly, `

[libcxx] r295406 - [libcxx] Remove unexpected handlers in C++17

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 21:25:08 2017 New Revision: 295406 URL: http://llvm.org/viewvc/llvm-project?rev=295406&view=rev Log: [libcxx] Remove unexpected handlers in C++17 Summary: This patch implements [P0003R5](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0003r5.html) which

[PATCH] D28172: [libcxx] Remove unexpected handlers in C++17

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88843. EricWF added a comment. - Update so that it merges with master. - add `_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES` macro for re-enabling all removed C++17 features. https://reviews.llvm.org/D28172 Files: docs/UsingLibcxx.rst include/__config includ

[PATCH] D30045: Remove `std::random_shuffle` in C++17

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after fixing inline comments. Comment at: include/algorithm:3029 +#if _LIBCPP_STD_VER <= 14 || defined(_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE) class _LIBCPP_TYP

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/locale:626 template +_LIBCPP_HIDDEN iter_type __do_get_floating_point After applying the changes to `__config` but not this header `check-cxx-abilist` didn't report any changes to these symbols. Wh

r295404 - Added doxygen comments to smmintrin.h's intrinsics.

2017-02-16 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Thu Feb 16 20:49:50 2017 New Revision: 295404 URL: http://llvm.org/viewvc/llvm-project?rev=295404&view=rev Log: Added doxygen comments to smmintrin.h's intrinsics. Note: The doxygen comments are automatically generated based on Sony's intrinsic s document. I got an OK fro

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. I applied `inline` to most of the functions changed in `basic_string`, and updated the ABI lists accordingly. Please update this patch so it merges with trunk. Note you can add `_LIBCPP_HIDDEN` to the functions in `basic_string` as well if you want, however the `inline`

[libcxx] r295403 - Mark a couple for basic_string member templates as inline. no ABI change this time.

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 20:31:56 2017 New Revision: 295403 URL: http://llvm.org/viewvc/llvm-project?rev=295403&view=rev Log: Mark a couple for basic_string member templates as inline. no ABI change this time. Modified: libcxx/trunk/include/string Modified: libcxx/trunk/include/strin

[PATCH] D29967: Get class property selectors from property decl if it exists

2017-02-16 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. I think Im misunderstanding something. How does the test actually test what you are changing? https://reviews.llvm.org/D29967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

r295401 - Retry: [ubsan] Reduce null checking of C++ object pointers (PR27581)

2017-02-16 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Thu Feb 16 20:03:51 2017 New Revision: 295401 URL: http://llvm.org/viewvc/llvm-project?rev=295401&view=rev Log: Retry: [ubsan] Reduce null checking of C++ object pointers (PR27581) This patch teaches ubsan to insert exactly one null check for the 'this' pointer per method/la

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAttr or

[libcxx] r295399 - update revision in CHANGELOG.TXT and fix python error

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 19:56:57 2017 New Revision: 295399 URL: http://llvm.org/viewvc/llvm-project?rev=295399&view=rev Log: update revision in CHANGELOG.TXT and fix python error Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT libcxx/trunk/utils/libcxx/sym_check/extract.py Modified:

Re: [libcxx] r294116 - Remove CMake hack

2017-02-16 Thread Eric Fiselier via cfe-commits
Sorry about the breakage. I'm not sure what else to do. The hack had been sitting there for more than a month IIRC. Any advice for next time? /Eric On Thu, Feb 16, 2017 at 7:00 PM, Justin Bogner wrote: > Eric Fiselier via cfe-commits writes: > > Author: ericwf > > Date: Sat Feb 4 19:19:02 2

Re: [libcxx] r294116 - Remove CMake hack

2017-02-16 Thread Justin Bogner via cfe-commits
Eric Fiselier via cfe-commits writes: > Author: ericwf > Date: Sat Feb 4 19:19:02 2017 > New Revision: 294116 > > URL: http://llvm.org/viewvc/llvm-project?rev=294116&view=rev > Log: > Remove CMake hack FWIW, I just spent half an hour trying to figure out why a tree I hadn't built in a bit wouldn

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/string:1100 template +inline _LIBCPP_INLINE_VISIBILITY typename enable_if Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDDEN` everywhere else? https://reviews.llvm.org/D29157

r295396 - Revert "[ubsan] Reduce null checking of C++ object pointers (PR27581)"

2017-02-16 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Thu Feb 16 19:42:36 2017 New Revision: 295396 URL: http://llvm.org/viewvc/llvm-project?rev=295396&view=rev Log: Revert "[ubsan] Reduce null checking of C++ object pointers (PR27581)" This reverts commit r295391. It breaks this bot: http://lab.llvm.org:8011/builders/clang-wi

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I really don't like this change (and https://reviews.llvm.org/D29757) because they start to include a ton of extra headers, and because they lift complex configuration logic into wha

[PATCH] D29757: [libcxx] Threading support: Externalize hardware_concurrency()

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Same comment as https://reviews.llvm.org/D29818 I really don't like this change (and https://reviews.llvm.org/D29818) because they start to include a ton of extra headers, and becaus

[PATCH] D30035: Add const to function parameters

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. This change is ABI breaking because these functions are exported using explicit template instantiations, and because changing their signature changes the mangling. Can you explain w

[libcxx] r295393 - [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 19:17:10 2017 New Revision: 295393 URL: http://llvm.org/viewvc/llvm-project?rev=295393&view=rev Log: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types. Summary: This patch fixes http://llvm.org/PR31938. The description below

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88812. EricWF added a comment. - Clarify comments about conforming constructors that still don't support guides. https://reviews.llvm.org/D29863 Files: include/string test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp test/su

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp:57 + { // Testing (2) +// FIXME: (2) doesn't work with implicit deduction. +// const test_allocator alloc{}; rsmith wrote: > I think t

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

2017-02-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295391: [ubsan] Reduce null checking of C++ object pointers (PR27581) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29530?vs=88259&id=88808#toc Repository: rL LLVM https:

r295391 - [ubsan] Reduce null checking of C++ object pointers (PR27581)

2017-02-16 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Thu Feb 16 19:05:42 2017 New Revision: 295391 URL: http://llvm.org/viewvc/llvm-project?rev=295391&view=rev Log: [ubsan] Reduce null checking of C++ object pointers (PR27581) This patch teaches ubsan to insert exactly one null check for the 'this' pointer per method/lambda.

[libcxx] r295390 - add tests for ENAMETOOLONG

2017-02-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 16 19:00:37 2017 New Revision: 295390 URL: http://llvm.org/viewvc/llvm-project?rev=295390&view=rev Log: add tests for ENAMETOOLONG Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.exists/exists.pass.cpp libcxx/trunk/test/std/experime

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

2017-02-16 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. Other than (5), all the failing cases look like they should fail per the current `basic_string` spec. Comment at: test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp:57 + { // Testing (2) +// FIXME: (2) doesn't work with i

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88803. EricWF added a comment. - Enumerate and test each constructor. https://reviews.llvm.org/D29863 Files: include/string test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp utils/libcxx/test/config.py Index: utils/libcxx/te

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// pirama wrote: > I feel this test is fragile. Any idea how to further restrict and require > that t

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama updated this revision to Diff 88799. pirama added a comment. Stricter tests. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/aarch64/.keep test/Drive

r295381 - Use correct fix-it location for -Wblock-capture-autoreleasing

2017-02-16 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Feb 16 17:15:36 2017 New Revision: 295381 URL: http://llvm.org/viewvc/llvm-project?rev=295381&view=rev Log: Use correct fix-it location for -Wblock-capture-autoreleasing The '__autoreleasing' keyword should be inserted after the Objective-C pointer type. rdar://3012354

[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88795. EricWF added a comment. Remove test code that snuck in. https://reviews.llvm.org/D29930 Files: docs/LanguageExtensions.rst include/clang/Basic/TokenKinds.def include/clang/Basic/TypeTraits.h lib/Parse/ParseDeclCXX.cpp lib/Parse/ParseExpr.cpp

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAt

[PATCH] D29930: Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

2017-02-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 88794. EricWF retitled this revision from "Add `__is_direct_constructible` trait for checking safe reference initialization." to "Add `__reference_binds_to_temporary` trait for checking safe reference initialization.". EricWF edited the summary of this revisi

[PATCH] D29901: Modular Codegen: Add/use a bit in serialized function definitions to track whether they are the subject of modular codegen

2017-02-16 Thread David Blaikie via Phabricator via cfe-commits
dblaikie updated this revision to Diff 88792. dblaikie added a comment. - Simplify ModuleFile lookup https://reviews.llvm.org/D29901 Files: include/clang/AST/ExternalASTSource.h include/clang/Sema/MultiplexExternalSemaSource.h include/clang/Serialization/ASTReader.h lib/AST/ASTContext.c

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Michał Górny via Phabricator via cfe-commits
mgorny added inline comments. Comment at: test/Driver/arch-specific-libdir.c:6 +// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \ +// RUN: | FileCheck --check-prefix=CHECK-ARCHDIR %s +// Please be more specific in the tests, i.e. check if the

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

2017-02-16 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. It seems to me that the problem here is that `DeclMustBeEmitted` is not safe to call in the middle of deserialization if anything partially-deserialized might be reachable from the declaration we're querying, and yet we're currently calling it in that case. I don't see h

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAttr or

Re: [PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

2017-02-16 Thread Hans Wennborg via cfe-commits
Richard, can you take a look when you have a moment? The PR is marked as a release blocker. On Thu, Feb 9, 2017 at 1:54 PM, Duncan P. N. Exon Smith via Phabricator via cfe-commits wrote: > dexonsmith added a comment. > > I'm not comfortable signing off on this, but it seems like this should be se

r295379 - Properly set up the DeclContext for parameters of implicit deduction guides;

2017-02-16 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Feb 16 15:29:21 2017 New Revision: 295379 URL: http://llvm.org/viewvc/llvm-project?rev=295379&view=rev Log: Properly set up the DeclContext for parameters of implicit deduction guides; this is needed for deferred instantiation of default arguments. Modified: cfe/trunk

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

2017-02-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Well hmm... changing this from MSVC to always caused a ton of regressions. I no longer think that this is a proper patch as it sits. Additionally, it doesn't fix the A::TYPE *var3 condition. https://reviews.llvm.org/D29401 __

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: docs/LanguageExtensions.rst:2349 +attribute is supported by the pragma by referring to the +:doc:`individual documentation for that attribute `. arphaman wrote: > efriedma wrote: > > arphaman wrote: > > > arphaman wrote: > >

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: docs/LanguageExtensions.rst:2418 +In general, the attributes are applied to a declaration only when there would +have been no error or warning for that attribute if it was specified explicitly. +An attribute is applied to each rel

Re: r295224 - PR24440: Do not silently discard a fold-expression appearing as the operand of a cast-expression.

2017-02-16 Thread Hans Wennborg via cfe-commits
Merged in r295375. Thanks, Hans On Wed, Feb 15, 2017 at 12:14 PM, Richard Smith wrote: > Hans, this would be a good candidate for Clang 4. The bug in question is not > a regression, but it is an accepts-invalid / wrong-code bug. > > On 15 February 2017 at 11:57, Richard Smith via cfe-commits >

[PATCH] D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D28670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: docs/LanguageExtensions.rst:2349 +attribute is supported by the pragma by referring to the +:doc:`individual documentation for that attribute `. efriedma wrote: > arphaman wrote: > > arphaman wrote: > > > efriedma wrote

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: docs/LanguageExtensions.rst:2349 +attribute is supported by the pragma by referring to the +:doc:`individual documentation for that attribute `. arphaman wrote: > arphaman wrote: > > efriedma wrote: > > > I'm wondering

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// I feel this test is fragile. Any idea how to further restrict and require that the default target

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

2017-02-16 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 88770. Repository: rL LLVM https://reviews.llvm.org/D26654 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- /dev/null +++ cmake

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

2017-02-16 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama updated this revision to Diff 88768. pirama added a comment. - Arch-subdir is now always added to -L - It is added to -rpath during native compilation. - Tests have been updated https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Dri

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: docs/LanguageExtensions.rst:2349 +attribute is supported by the pragma by referring to the +:doc:`individual documentation for that attribute `. arphaman wrote: > efriedma wrote: > > I'm wondering if we can tweak the ap

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 88764. arphaman marked an inline comment as done. arphaman added a comment. The updated patch switches over to the opt-out approach, allows the C++11 style syntax and improves documentation. Repository: rL LLVM https://reviews.llvm.org/D30009 Files:

Re: [libcxx] r295330 - math: correct the MSVCRT condition

2017-02-16 Thread Andrey Khalyavin via cfe-commits
What is _VC_CRT_NAJOR_VERSION? Is it misprint or a hack? Google gives zero results. -- Andrey Khalyavin On Thu, Feb 16, 2017 at 6:47 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Thu Feb 16 09:47:50 2017 > New Revision: 295330 > > URL: htt

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

2017-02-16 Thread Taewook Oh via Phabricator via cfe-commits
twoh added inline comments. Comment at: test/Lexer/case-insensitive-include-pr31836.sh:6 +// RUN: touch %T/case-insensitive-include-pr31836.h +// RUN: echo "#include \"%T/Case-Insensitive-Include-Pr31836.h\"" | %clang_cc1 -E - 2>&1 | FileCheck %s + karies wrote:

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

2017-02-16 Thread Axel Naumann via Phabricator via cfe-commits
karies added inline comments. Comment at: test/Lexer/case-insensitive-include-pr31836.sh:6 +// RUN: touch %T/case-insensitive-include-pr31836.h +// RUN: echo "#include \"%T/Case-Insensitive-Include-Pr31836.h\"" | %clang_cc1 -E - 2>&1 | FileCheck %s + @twoh Does

[PATCH] D24812: Lit C++11 Compatibility Patch #11

2017-02-16 Thread Charles Li via Phabricator via cfe-commits
tigerleapgorge added a comment. @rjmccall Hi John, I've made the changes to volatile.cpp. I take it this patch is good for commit? https://reviews.llvm.org/D24812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

2017-02-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/Parse/ParseStmt.cpp:186 // found. -if (Next.isNot(tok::coloncolon)) { +if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat || +Next.isNot(tok::less))) { efriedma wrote: > erichkeane

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

2017-02-16 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: lib/Parse/ParseStmt.cpp:186 // found. -if (Next.isNot(tok::coloncolon)) { +if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat || +Next.isNot(tok::less))) { erichkeane wrote: > efriedma wr

[libcxx] r295355 - Update a couple of issue statuses

2017-02-16 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Feb 16 12:50:30 2017 New Revision: 295355 URL: http://llvm.org/viewvc/llvm-project?rev=295355&view=rev Log: Update a couple of issue statuses Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llvm

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

2017-02-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/Parse/ParseStmt.cpp:186 // found. -if (Next.isNot(tok::coloncolon)) { +if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat || +Next.isNot(tok::less))) { efriedma wrote: > erichkeane

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

2017-02-16 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: lib/Parse/ParseStmt.cpp:186 // found. -if (Next.isNot(tok::coloncolon)) { +if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat || +Next.isNot(tok::less))) { erichkeane wrote: > Clang-tidy

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D30009#678890, @arphaman wrote: > In https://reviews.llvm.org/D30009#678091, @hfinkel wrote: > > > I don't understand why it only supports some attributes. Is there some > > handling that needs to take place (I don't see anything obvious in th

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D30009#678091, @hfinkel wrote: > I don't understand why it only supports some attributes. Is there some > handling that needs to take place (I don't see anything obvious in this > patch)? If most attributes will "just work", I'd much rather

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

2017-02-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

2017-02-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Thoughts? https://reviews.llvm.org/D29401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28266: Transparent_union attribute should be possible in front of union (rework)

2017-02-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Hi guys- Since this is a rework of Vlad's changes, I'm not sure you noticed that this was a different review! Anyone have opinions? Additionally, I had 1 question in SemaDecl.cpp that I think was right, otherwise I hope this is a pretty light review. https://revi

[PATCH] D27486: Correct class-template deprecation behavior

2017-02-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. @rsmith did you ever get a chance to re-review this? Is this what you were wanting for this? https://reviews.llvm.org/D27486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

2017-02-16 Thread Hans Wennborg via cfe-commits
I've merged it in r295340. Cheers, Hans On Thu, Feb 16, 2017 at 6:26 AM, Anastasia Stulova wrote: > Hans, could we merge this documentation only change (r295313) in release40 > branch. I can commit myself if needed. :) > > Thanks in advance, > Anastasia > > -Original Message- > From: An

[PATCH] D29879: [OpenMP] Teams reduction on the NVPTX device.

2017-02-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295335: [OpenMP] Teams reduction on the NVPTX device. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D29879?vs=88715&id=88746#toc Repository: rL LLVM https://reviews.llvm.or

r295335 - [OpenMP] Teams reduction on the NVPTX device.

2017-02-16 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Thu Feb 16 10:48:49 2017 New Revision: 295335 URL: http://llvm.org/viewvc/llvm-project?rev=295335&view=rev Log: [OpenMP] Teams reduction on the NVPTX device. This patch implements codegen for the reduction clause on any teams construct for elementary data types. It builds on

r295333 - [OpenMP] Parallel reduction on the NVPTX device.

2017-02-16 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Thu Feb 16 10:20:16 2017 New Revision: 295333 URL: http://llvm.org/viewvc/llvm-project?rev=295333&view=rev Log: [OpenMP] Parallel reduction on the NVPTX device. This patch implements codegen for the reduction clause on any parallel construct for elementary data types. An eff

[libcxx] r295329 - threading_support: make __thread_sleep_for be alertable

2017-02-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 16 09:47:45 2017 New Revision: 295329 URL: http://llvm.org/viewvc/llvm-project?rev=295329&view=rev Log: threading_support: make __thread_sleep_for be alertable On Windows, we were using `Sleep` which is not alertable. This means that if the thread was used for a us

[libcxx] r295330 - math: correct the MSVCRT condition

2017-02-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 16 09:47:50 2017 New Revision: 295330 URL: http://llvm.org/viewvc/llvm-project?rev=295330&view=rev Log: math: correct the MSVCRT condition Fixes a number of tests in the testsuite on Windows. Modified: libcxx/trunk/include/cmath libcxx/trunk/include/math.h

Re: r291905 - [Sema] Add warning for unused lambda captures

2017-02-16 Thread Aaron Ballman via cfe-commits
On Wed, Feb 15, 2017 at 7:42 PM, Richard Smith via cfe-commits wrote: > https://bugs.llvm.org/show_bug.cgi?id=31977 makes the good point that this > is warning on a certain idiomatic use of capture-by-value to extend the > lifetime of an RAII object; consider: > > shared_ptr p = /*...*/; > int

  1   2   >