Author: echristo
Date: Sat Mar 25 00:40:13 2017
New Revision: 298769
URL: http://llvm.org/viewvc/llvm-project?rev=298769=rev
Log:
Define __HAVE_BSWAP__ on ppc to match gcc since we support both builtins as
well.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
On Fri, Mar 24, 2017 at 8:58 PM Yaxun Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yaxunl
> Date: Fri Mar 24 22:46:25 2017
> New Revision: 298767
>
> URL: http://llvm.org/viewvc/llvm-project?rev=298767=rev
> Log:
> [AMDGPU] Switch address space mapping by triple environment
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298767: [AMDGPU] Switch address space mapping by triple
environment amdgiz (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D31210?vs=92997=93031#toc
Repository:
rL LLVM
Author: yaxunl
Date: Fri Mar 24 22:46:25 2017
New Revision: 298767
URL: http://llvm.org/viewvc/llvm-project?rev=298767=rev
Log:
[AMDGPU] Switch address space mapping by triple environment amdgiz
For target environment amdgiz and amdgizcl (giz means Generic Is Zero), AMDGPU
will use new address
Author: smeenai
Date: Fri Mar 24 22:42:20 2017
New Revision: 298766
URL: http://llvm.org/viewvc/llvm-project?rev=298766=rev
Log:
[libc++] Fix some comment typos
Remove a stray letter, add a missing letter. No functional change.
Modified:
libcxx/trunk/CMakeLists.txt
Modified:
Author: echristo
Date: Fri Mar 24 22:33:59 2017
New Revision: 298765
URL: http://llvm.org/viewvc/llvm-project?rev=298765=rev
Log:
Add the _CALL_LINUX preprocessor define for ppc linux platforms.
This typically is only for a new enough linker (bfd >= 2.16.2 or gold), but
our ppc suppport
Author: smeenai
Date: Fri Mar 24 22:29:51 2017
New Revision: 298764
URL: http://llvm.org/viewvc/llvm-project?rev=298764=rev
Log:
[libc++] Fix word transposition in comment
"to due" -> "due to". No functional change.
Modified:
libcxx/trunk/CMakeLists.txt
Modified:
Author: smeenai
Date: Fri Mar 24 22:22:35 2017
New Revision: 298763
URL: http://llvm.org/viewvc/llvm-project?rev=298763=rev
Log:
[libc++] Fix capitalization in comment
Fix a stray capital letter in the middle of a sentence. No functional
change.
Modified:
libcxx/trunk/CMakeLists.txt
Author: smeenai
Date: Fri Mar 24 22:12:37 2017
New Revision: 298762
URL: http://llvm.org/viewvc/llvm-project?rev=298762=rev
Log:
[libc++] Update package version
Make it consistent with the rest of LLVM.
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
Author: echristo
Date: Fri Mar 24 21:55:21 2017
New Revision: 298761
URL: http://llvm.org/viewvc/llvm-project?rev=298761=rev
Log:
__BIGGEST_ALIGNMENT__ has always been 16 on all power platforms rather
than the default of 8 in clang, fix and update tests accordingly.
Modified:
Author: echristo
Date: Fri Mar 24 21:29:18 2017
New Revision: 298759
URL: http://llvm.org/viewvc/llvm-project?rev=298759=rev
Log:
Add preprocessor defines for a bare powerpc64le triple/cpu.
The le triple didn't exist until power8, so use that as a default (this
also matches what gcc does).
smeenai created this revision.
Herald added a subscriber: mgorny.
Globbing for source files is problematic because if a source file is
added or removed, the configuration won't be run again, and so the build
won't pick up on the added or removed file until the next configuration.
cmake's help
yaxunl added inline comments.
Comment at: lib/Basic/Targets.cpp:2015
-static const unsigned AMDGPUAddrSpaceMap[] = {
- 1,// opencl_global
- 3,// opencl_local
- 2,// opencl_constant
- 4,// opencl_generic
- 1,// cuda_device
- 2,// cuda_constant
- 3
Author: rtrieu
Date: Fri Mar 24 19:48:52 2017
New Revision: 298754
URL: http://llvm.org/viewvc/llvm-project?rev=298754=rev
Log:
[ODRHash] Add support for array and decayed types.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
Not sure, that's why I asked. Is it useful? Is it one of those things we
want to remove since it'll be common among all of the TUs that want the
text?
On Fri, Mar 24, 2017 at 3:43 PM Zhizhou Yang via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Sure I can add some more tests here.
>
> For
bkelley added a comment.
Sorry for missing the unnecessary LangOpts checks here. Thanks again for the
feedback!
https://reviews.llvm.org/D31005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bkelley updated this revision to Diff 93023.
bkelley marked 4 inline comments as done.
bkelley added a comment.
Updated with feedback from @rjmccall
https://reviews.llvm.org/D31005
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
Just a couple of suggestions, otherwise:
LGTM
Comment at: lib/Basic/Targets.cpp:2015
-static const unsigned AMDGPUAddrSpaceMap[] = {
- 1,// opencl_global
- 3,//
Sure I can add some more tests here.
For -grecord-gcc-switches itself, I think maybe we could keep it in
recording, since it is also one of the options from command line?
On Fri, Mar 24, 2017 at 2:54 PM, Eric Christopher via Phabricator <
revi...@reviews.llvm.org> wrote:
> echristo added inline
rjmccall added a comment.
Just a couple of minor requests.
Comment at: lib/Sema/SemaExpr.cpp:708
+ if (getLangOpts().ObjCWeak &&
E->getType().getObjCLifetime() == Qualifiers::OCL_Weak)
Cleanup.setExprNeedsCleanups(true);
Much like the other
george.burgess.iv added inline comments.
Comment at: test/Driver/debug-options.c:201
//
+// GRECORD: "-dwarf-debug-flags"
+// GRECORD: -### -c -grecord-gcc-switches
echristo wrote:
> This seems a little light on the testing, would you mind adding some more
>
echristo added inline comments.
Comment at: test/Driver/debug-options.c:201-202
//
+// GRECORD: "-dwarf-debug-flags"
+// GRECORD: -### -c -grecord-gcc-switches
+//
This seems a little light on the testing, would you mind adding some more
interesting lines
hfinkel added a comment.
In https://reviews.llvm.org/D30920#710329, @mehdi_amini wrote:
> In https://reviews.llvm.org/D30920#710209, @hfinkel wrote:
>
> > Yes, we should do this. I don't understand why this is tricky. Actually, I
> > think having these kinds of decisions explicit in the code of
Author: rtrieu
Date: Fri Mar 24 16:17:48 2017
New Revision: 298742
URL: http://llvm.org/viewvc/llvm-project?rev=298742=rev
Log:
[ODRHash] Add error messages for mismatched parameters in methods.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
zhizhouy updated this revision to Diff 93011.
zhizhouy added a comment.
Added tests into test/Driver/debug-options.c. Thanks.
https://reviews.llvm.org/D30760
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/debug-options.c
Index: test/Driver/debug-options.c
mehdi_amini added a subscriber: joerg.
mehdi_amini added a comment.
In https://reviews.llvm.org/D30920#710209, @hfinkel wrote:
> Yes, we should do this. I don't understand why this is tricky. Actually, I
> think having these kinds of decisions explicit in the code of the
> transformations
As Adrian mentioned, this can probably be covered/added to an existing test
case in clang/test/Driver
On Fri, Mar 24, 2017 at 1:57 PM Zhizhou Yang via Phabricator <
revi...@reviews.llvm.org> wrote:
> zhizhouy updated this revision to Diff 93003.
> zhizhouy marked 3 inline comments as done.
>
zhizhouy updated this revision to Diff 93003.
zhizhouy marked 3 inline comments as done.
zhizhouy added a comment.
Checked both grecord-gcc-swtiches and gno-record-gcc-switches.
Modified testcases for it.
https://reviews.llvm.org/D30760
Files:
lib/Driver/ToolChains/Clang.cpp
yaxunl updated this revision to Diff 92997.
yaxunl retitled this revision from "[AMDGPU] Add new address space mapping" to
"[AMDGPU] Switch address space mapping by triple environment".
yaxunl added a comment.
Use triple environment name.
https://reviews.llvm.org/D31210
Files:
bkelley added a comment.
Thanks again for the feedback. Is there anything further I should update in
this diff or is it looking good?
Thanks!
Brian
https://reviews.llvm.org/D31005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lebedev.ri added inline comments.
Comment at: test/clang-tidy/misc-assert-side-effect.cpp:67
+
+ assert(freeFunction());
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect
Is it intentional that the check also warns on free functions
Author: pcc
Date: Fri Mar 24 14:32:20 2017
New Revision: 298728
URL: http://llvm.org/viewvc/llvm-project?rev=298728=rev
Log:
Fix a test so that it actually checks the output.
Modified:
cfe/trunk/test/Modules/module-impl-with-link.c
Modified: cfe/trunk/test/Modules/module-impl-with-link.c
hfinkel added a comment.
In https://reviews.llvm.org/D30920#703305, @mehdi_amini wrote:
> The fundamental difference, is that Os/Oz especially are treated as
> `optimizations directive` that are independent of the pass pipeline:
> instructing that "loop unroll should not increase size" is
Anastasia added a comment.
In https://reviews.llvm.org/D31183#709566, @echuraev wrote:
> In https://reviews.llvm.org/D31183#708833, @yaxunl wrote:
>
> > I think this is a good feature for the convenience of user. I've seen usage
> > like this.
>
>
> I agree. I don't see any reasons why this
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D31324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D31007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gnzlbg added a comment.
Thanks for working on this!
> I'm not sure if it would be helpful to have this check in both ways. I did a
> code search for "not_eq", "bitand" and "and_eq" on github, and their usage
> seems to be a clear minority.
I actually was requesting the opposite version of
yaxunl added a comment.
Hi Tony,
I have already updated with a full diff. Please take a look. Thanks.
https://reviews.llvm.org/D31210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tejohnson added a comment.
Ping - I think this just needs a test in addition to undoing the AsmHelper
definition move. I have some follow on changes I want to send that set up the
rest of the lto::Config fields (e.g. the RelocModel etc).
https://reviews.llvm.org/D31114
mfherbst updated this revision to Diff 92986.
mfherbst added a comment.
Fixed typos (MainFile => MainSourceFile)
https://reviews.llvm.org/D31326
Files:
run-clang-tidy.py
Index: run-clang-tidy.py
===
--- run-clang-tidy.py
+++
arsenm updated this revision to Diff 92981.
arsenm added a comment.
Use existing type member variable
https://reviews.llvm.org/D31043
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/cleanup-destslot-simple.c
test/CodeGen/lifetime-asan.c
test/CodeGen/lifetime2.c
t-tye requested changes to this revision.
t-tye added a comment.
This revision now requires changes to proceed.
Also please upload as full diff.
Comment at: lib/Basic/Targets.cpp:2026-2069
+ struct AddrSpace {
+unsigned Generic, Global, Local, Constant, Private;
+bool
yaxunl updated this revision to Diff 92977.
yaxunl added a comment.
Revised by Tony's suggestions.
https://reviews.llvm.org/D31210
Files:
lib/Basic/Targets.cpp
test/CodeGenOpenCL/amdgpu-env-amdgiz.cl
Index: test/CodeGenOpenCL/amdgpu-env-amdgiz.cl
jaykang10 added a comment.
> I believe the argument lacks numbers (or at least you have them but didn't
> mention). I didn't hear about performance results, or validation that this
> was actually tested for correctness. Small test cases prove a point, but
> can't be considered general.
>
>
Author: rksimon
Date: Fri Mar 24 11:59:14 2017
New Revision: 298712
URL: http://llvm.org/viewvc/llvm-project?rev=298712=rev
Log:
Fix MSVC 'not all control paths return a value' warning.
Modified:
cfe/trunk/lib/Index/IndexingContext.cpp
Modified: cfe/trunk/lib/Index/IndexingContext.cpp
URL:
Author: stulova
Date: Fri Mar 24 11:43:51 2017
New Revision: 298709
URL: http://llvm.org/viewvc/llvm-project?rev=298709=rev
Log:
[OpenCL][Bug 10573] Don't set CXXOperatorNames flag
The flag CXXOperatorNames was overwritten unconditionally
after being set for OpenCL.
There seems to be no
bkelley added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6681
// full-expression's cleanups.
- if ((S.getLangOpts().ObjCAutoRefCount &&
- MTE->getType()->isObjCLifetimeType()) ||
+ if (MTE->getType()->isNonTrivialObjCLifetimeType() ||
bkelley updated this revision to Diff 92966.
bkelley marked an inline comment as done.
bkelley added a comment.
Updated with latest feedback from @rjmccall
https://reviews.llvm.org/D31007
Files:
lib/Sema/SemaCast.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclCXX.cpp
lib/Sema/SemaInit.cpp
Author: marshall
Date: Fri Mar 24 11:17:20 2017
New Revision: 298706
URL: http://llvm.org/viewvc/llvm-project?rev=298706=rev
Log:
XFAIL the std::byte tests on a bunch of old clang versions, because they don't
like 'std::byte b1{1}'
Modified:
aprantl added inline comments.
Comment at: test/CodeGen/debug-info-grecord-gcc-switches.c:1
+// RUN: %clang -g -grecord-gcc-switches -S -emit-llvm -o - %s | FileCheck %s
+int main (void) {
Shouldn't this test be in the Driver/ directory? There is already a big
erichkeane added a comment.
FWIW, the LLVM changes for this have been committed.
https://reviews.llvm.org/D29599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6681
// full-expression's cleanups.
- if ((S.getLangOpts().ObjCAutoRefCount &&
- MTE->getType()->isObjCLifetimeType()) ||
+ if (MTE->getType()->isNonTrivialObjCLifetimeType() ||
ioeric added inline comments.
Comment at: clang-rename/USRLocFinder.cpp:195
+// Find all locations identified by the given USRs. Traverse the AST and find
+// every AST node whose USR is in the given USRs' set.
+class RenameLocFinder
hokein wrote:
> ioeric
hokein added inline comments.
Comment at: clang-rename/USRLocFinder.cpp:195
+// Find all locations identified by the given USRs. Traverse the AST and find
+// every AST node whose USR is in the given USRs' set.
+class RenameLocFinder
ioeric wrote:
> I think this
hokein updated this revision to Diff 92954.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments and polish tests.
https://reviews.llvm.org/D31176
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/USRFinder.cpp
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
https://reviews.llvm.org/D31004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasimir updated this revision to Diff 92948.
krasimir added a comment.
- Make Items ownership more explicit
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
malaperle-ericsson added a comment.
Urg, I was working on this too :) I'll compare implementations and provide
comments if I find anything good to suggest.
https://reviews.llvm.org/D31328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasimir updated this revision to Diff 92940.
krasimir marked 7 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
NoQ added a comment.
Thanks again for the awesome stuff! It took years for me to even come up with
the idea.
Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:494
+ SymbolManager = C.getSymbolManager();
+ return SM.getDerivedSymbol(Sym, LCV.getRegion());
}
krasimir updated this revision to Diff 92939.
krasimir added a comment.
- Add '.' and '>' as completion trigger characters
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
bkramer added inline comments.
Comment at: clangd/ASTManager.cpp:264
+assert(CCS->getTypedText());
+Item.label = llvm::yaml::escape(CCS->getTypedText());
+if (CCS->getBriefComment())
CompletionItem::unparse should do the escaping. It's
krasimir updated this revision to Diff 92931.
krasimir added a comment.
- Clean-up leftovers
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
krasimir created this revision.
Adds code completion support to clangd.
https://reviews.llvm.org/D31328
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
clangd/ProtocolHandlers.h
mgehre updated this revision to Diff 92923.
mgehre added a comment.
Thank you for the comments; all of them have been addressed.
https://reviews.llvm.org/D24886
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaStmtAttr.cpp
alexfh added a comment.
FWIW, I'm pretty sure this can and should be done on the lexer level - it will
be faster and more universal.
Repository:
rL LLVM
https://reviews.llvm.org/D31308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh added a comment.
> So I would propose to keep the features as-is for now,
> change the name to readability-operators-representation, and then later
> (someone else?) might also add an option
> for making this work the other way around. Would that be ok for you?
Fine by me.
alexfh added a comment.
In https://reviews.llvm.org/D31308#709709, @mgehre wrote:
> Thanks for your feedback, Eugene!
>
> I'm not sure if it would be helpful to have this check in both ways. I did a
> code search for "not_eq", "bitand" and "and_eq"
> on github, and their usage seems to be a
mgehre added a comment.
Thanks for your feedback, Eugene!
I'm not sure if it would be helpful to have this check in both ways. I did a
code search for "not_eq", "bitand" and "and_eq"
on github, and their usage seems to be a clear minority.
So I would propose to keep the features as-is for now,
alexfh added a comment.
In https://reviews.llvm.org/D29262#709351, @krystyna wrote:
> I have plan to finish this patch next week, when I finish academic year at my
> school. If I will have any issues with submitting, Prazek offered to help me.
Sure, no stress. Good luck with your studies!
mgehre added a comment.
Friendly ping
https://reviews.llvm.org/D22476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echuraev created this revision.
Herald added a subscriber: yaxunl.
Enable cl_mad_enamle and cl_no_signed_zeros options when user turns on
cl_unsafe_math_optimizations or cl_fast_relaxed_math options.
https://reviews.llvm.org/D31324
Files:
lib/Frontend/CompilerInvocation.cpp
Author: dergachev
Date: Fri Mar 24 05:16:08 2017
New Revision: 298699
URL: http://llvm.org/viewvc/llvm-project?rev=298699=rev
Log:
[analyzer] MisusedMovedObject: Remove deprecated callback. NFC
wantsRegionChangeUpdate() checker callback is no longer used since recently.
Fixes a buildbot
Author: dergachev
Date: Fri Mar 24 04:52:30 2017
New Revision: 298698
URL: http://llvm.org/viewvc/llvm-project?rev=298698=rev
Log:
[analyzer] Add MisusedMovedObjectChecker for detecting use-after-move errors.
The checker currently warns on copying, moving, or calling methods on an object
that
echuraev created this revision.
Herald added a subscriber: yaxunl.
"kernel_arg_type_qual" metadata should contain const/volatile/restrict
tags only for pointer types to match the corresponding requirement of
the OpenCL specification.
OpenCL 2.0 spec 5.9.3 Kernel Object Queries:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298697: [libclang] Bury dead TemporaryFiles (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31288?vs=92804=92908#toc
Repository:
rL LLVM
https://reviews.llvm.org/D31288
Author: krasimir
Date: Fri Mar 24 04:49:54 2017
New Revision: 298697
URL: http://llvm.org/viewvc/llvm-project?rev=298697=rev
Log:
[libclang] Bury dead TemporaryFiles
Summary:
AllocatedCXCodeCompleteResults::TemporaryFiles have turned into zombies.
Seven years ago they used to do their job during
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298696: [clangd] Add support for vscode extension
configuration (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D31121?vs=92367=92907#toc
Repository:
rL LLVM
Author: krasimir
Date: Fri Mar 24 04:29:00 2017
New Revision: 298696
URL: http://llvm.org/viewvc/llvm-project?rev=298696=rev
Log:
[clangd] Add support for vscode extension configuration
Summary: Adds vscode workspace level configuration options for path to clangd
binary and its arguments.
Author: chandlerc
Date: Fri Mar 24 04:11:57 2017
New Revision: 298695
URL: http://llvm.org/viewvc/llvm-project?rev=298695=rev
Log:
Revert r298491 and r298494 which changed Clang's handling of 'nonnull'
attributes.
These patches don't work because we can't currently access the parameter
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 298597
https://reviews.llvm.org/D30045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists closed this revision.
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
Committed as revision 298681.
https://reviews.llvm.org/D31163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
82 matches
Mail list logo
