r299806 - [cfi] Emit __cfi_check stub in the frontend.

Author: eugenis Date: Fri Apr 7 18:00:38 2017 New Revision: 299806 URL: http://llvm.org/viewvc/llvm-project?rev=299806&view=rev Log: [cfi] Emit __cfi_check stub in the frontend. Previously __cfi_check was created in LTO optimization pipeline, which means LLD has no way of knowing about the exist

r299800 - Toolchains: remove crtbegin on xwindows

Author: compnerd Date: Fri Apr 7 15:47:06 2017 New Revision: 299800 URL: http://llvm.org/viewvc/llvm-project?rev=299800&view=rev Log: Toolchains: remove crtbegin on xwindows crtbegin is not really a proper windows support thing. This was duplicated when the toolchain was initially built. If th

Re: r299774 - Sema: prevent __declspec(naked) use on x64

Yeah, I shouldn't write commit messages late at night (I didn't commit until the morning to keep an eye on the bots). I opted to follow cl in terms of erroring. I can make it a warning if you feel strongly about that. I think for naked functions being stricter is better. The user can just as ea

Re: r299774 - Sema: prevent __declspec(naked) use on x64

On 7 April 2017 at 12:06, Aaron Ballman wrote: > On Fri, Apr 7, 2017 at 2:53 PM, Richard Smith > wrote: > > On 7 Apr 2017 11:49 am, "David Majnemer via cfe-commits" > > wrote: > > > > > > > > On Fri, Apr 7, 2017 at 8:30 AM, Aaron Ballman via cfe-commits > > wrote: > >> > >> On Fri, Apr 7, 2017

[libunwind] r299798 - Revert "[CMake][libunwind] Use -nodefaultlibs for CMake checks"

Author: phosek Date: Fri Apr 7 15:24:22 2017 New Revision: 299798 URL: http://llvm.org/viewvc/llvm-project?rev=299798&view=rev Log: Revert "[CMake][libunwind] Use -nodefaultlibs for CMake checks" This reverts commit r299796. Modified: libunwind/trunk/cmake/config-ix.cmake Modified: libunwi

[libcxxabi] r299797 - [CMake][libcxxabi] Use -nodefaultlibs for CMake checks

Author: phosek Date: Fri Apr 7 15:10:41 2017 New Revision: 299797 URL: http://llvm.org/viewvc/llvm-project?rev=299797&view=rev Log: [CMake][libcxxabi] Use -nodefaultlibs for CMake checks Since libc++abi is built with -nodefaultlibs, we should be using this option even for CMake checks to avoid a

[libunwind] r299796 - [CMake][libunwind] Use -nodefaultlibs for CMake checks

Author: phosek Date: Fri Apr 7 15:10:29 2017 New Revision: 299796 URL: http://llvm.org/viewvc/llvm-project?rev=299796&view=rev Log: [CMake][libunwind] Use -nodefaultlibs for CMake checks Since libunwind is built with -nodefaultlibs, we should be using this option even for CMake checks to avoid a

Re: r299774 - Sema: prevent __declspec(naked) use on x64

On Fri, Apr 7, 2017 at 2:53 PM, Richard Smith wrote: > On 7 Apr 2017 11:49 am, "David Majnemer via cfe-commits" > wrote: > > > > On Fri, Apr 7, 2017 at 8:30 AM, Aaron Ballman via cfe-commits > wrote: >> >> On Fri, Apr 7, 2017 at 11:13 AM, Saleem Abdulrasool via cfe-commits >> wrote: >> > Author

Re: r299774 - Sema: prevent __declspec(naked) use on x64

On 7 Apr 2017 11:49 am, "David Majnemer via cfe-commits" < cfe-commits@lists.llvm.org> wrote: On Fri, Apr 7, 2017 at 8:30 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Apr 7, 2017 at 11:13 AM, Saleem Abdulrasool via cfe-commits > wrote: > > Author: compnerd >

Re: r299774 - Sema: prevent __declspec(naked) use on x64

On Fri, Apr 7, 2017 at 8:30 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Apr 7, 2017 at 11:13 AM, Saleem Abdulrasool via cfe-commits > wrote: > > Author: compnerd > > Date: Fri Apr 7 10:13:47 2017 > > New Revision: 299774 > > > > URL: http://llvm.org/viewvc/ll

r299785 - Attempt to fix ms-intrinsics.c test

Author: hans Date: Fri Apr 7 12:01:56 2017 New Revision: 299785 URL: http://llvm.org/viewvc/llvm-project?rev=299785&view=rev Log: Attempt to fix ms-intrinsics.c test Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c URL: http://llvm.org/viewv

r299782 - Implement _interlockedbittestandset as a builtin

Author: hans Date: Fri Apr 7 11:41:47 2017 New Revision: 299782 URL: http://llvm.org/viewvc/llvm-project?rev=299782&view=rev Log: Implement _interlockedbittestandset as a builtin It's used by MS headers in VS 2017 without including intrin.h, so we can't implement it in the header anymore. Diffe

Re: r299774 - Sema: prevent __declspec(naked) use on x64

On Fri, Apr 7, 2017 at 11:13 AM, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Fri Apr 7 10:13:47 2017 > New Revision: 299774 > > URL: http://llvm.org/viewvc/llvm-project?rev=299774&view=rev > Log: > Sema: prevent __declspec(naked) use on x64 > > MSDN (https://msdn.microsof

r299774 - Sema: prevent __declspec(naked) use on x64

Author: compnerd Date: Fri Apr 7 10:13:47 2017 New Revision: 299774 URL: http://llvm.org/viewvc/llvm-project?rev=299774&view=rev Log: Sema: prevent __declspec(naked) use on x64 MSDN (https://msdn.microsoft.com/en-us/library/h5w10wxs.aspx) indicates that `__declspec(naked)` is only permitted on x

[clang-tools-extra] r299764 - Fix compiler warnings: "ISO c99 requires rest arguments to be used" on

Author: hokein Date: Fri Apr 7 07:37:32 2017 New Revision: 299764 URL: http://llvm.org/viewvc/llvm-project?rev=299764&view=rev Log: Fix compiler warnings: "ISO c99 requires rest arguments to be used" on the test file. Modified: clang-tools-extra/trunk/unittests/clang-rename/RenameClassTest.c

r299760 - CloneDetection.h: Fix warnings. [-Wdocumentation]

Author: chapuni Date: Fri Apr 7 06:06:31 2017 New Revision: 299760 URL: http://llvm.org/viewvc/llvm-project?rev=299760&view=rev Log: CloneDetection.h: Fix warnings. [-Wdocumentation] Modified: cfe/trunk/include/clang/Analysis/CloneDetection.h Modified: cfe/trunk/include/clang/Analysis/Clone

r299759 - [scan-build-py] merge runner module to analyzer

Author: rizsotto Date: Fri Apr 7 06:04:49 2017 New Revision: 299759 URL: http://llvm.org/viewvc/llvm-project?rev=299759&view=rev Log: [scan-build-py] merge runner module to analyzer Differential Revision: https://reviews.llvm.org/D31237 Removed: cfe/trunk/tools/scan-build-py/libscanbuild/ru

[PATCH] D31401: [clangd] Extract FsPath from file:// uri

This revision was automatically updated to reflect the committed changes. Closed by commit rL299758: [clangd] Extract FsPath from file:// uri (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D31401?vs=94271&id=94507#toc Repository: rL LLVM https://reviews.llvm.org/D

[clang-tools-extra] r299758 - [clangd] Extract FsPath from file:// uri

Author: krasimir Date: Fri Apr 7 06:03:26 2017 New Revision: 299758 URL: http://llvm.org/viewvc/llvm-project?rev=299758&view=rev Log: [clangd] Extract FsPath from file:// uri Patch contributed by stanionascu! rfc8089#appendix-E.2 specifies that paths can begin with a drive letter e.g. as file:

[PATCH] D31765: Skip Unicode character expansion in assembly files

This revision was automatically updated to reflect the committed changes. Closed by commit rL299754: Skip Unicode character expansion in assembly files (authored by sanwou01). Changed prior to commit: https://reviews.llvm.org/D31765?vs=94501&id=94505#toc Repository: rL LLVM https://reviews.

r299754 - Skip Unicode character expansion in assembly files

Author: sanwou01 Date: Fri Apr 7 05:13:00 2017 New Revision: 299754 URL: http://llvm.org/viewvc/llvm-project?rev=299754&view=rev Log: Skip Unicode character expansion in assembly files Summary: When using the C preprocessor with assembly files, either with a capital `S` file extension, or with `

[PATCH] D31805: [clang-tidy] Mention "add the check to release note" in add_new_check.py.

hokein created this revision. https://reviews.llvm.org/D31805 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py === --- clang-tidy/add_new_check.py +++ clang-tidy/add_new_check.py @@ -304,6 +304,8 @@ write_

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

echuraev updated this revision to Diff 94503. echuraev marked an inline comment as done. https://reviews.llvm.org/D26794 Files: lib/Sema/SemaExpr.cpp test/SemaOpenCL/blocks_with_array.cl Index: test/SemaOpenCL/blocks_with_array.cl

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

echuraev added a comment. Yes, I have an access to the new revision and I have read it. https://reviews.llvm.org/D26794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31765: Skip Unicode character expansion in assembly files

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D31765: Skip Unicode character expansion in assembly files

salari01 updated this revision to Diff 94501. salari01 added a comment. Updated test to check preprocessed output instead of the assembled file. Cannot use `-verify` with the driver, but with `-E` and `-o -`, there is no longer a need to have the dummy warning to avoid the FileCheck error. htt

[clang-tools-extra] r299752 - [clang-tidy] A couple of minor fixes in modernize-use-using tests

Author: alexfh Date: Fri Apr 7 04:41:27 2017 New Revision: 299752 URL: http://llvm.org/viewvc/llvm-project?rev=299752&view=rev Log: [clang-tidy] A couple of minor fixes in modernize-use-using tests Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-using-macros.cpp clang-too

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein added a comment. In https://reviews.llvm.org/D31757#720351, @Eugene.Zelenko wrote: > Isn't such analysis is path-sensitive and should be implemented in Static > Analyzer? This check is more like a flow-sensitive analysis IMO, which can be supported by clang-tidy. > Please mention this

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein updated this revision to Diff 94498. hokein marked an inline comment as done. hokein added a comment. Mention the check in Release note. https://reviews.llvm.org/D31757 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientVectorOperationCheck.cpp clang-tid

[PATCH] D31765: Skip Unicode character expansion in assembly files

olista01 added a comment. The change itself looks fine, but I have a few comments on the test. Tests of clang shouldn't actually run the assembler, as I think this one will fail if clang is built without the ARM backend. A better way to write the test would be to just run the preprocessor, and

[PATCH] D30777: Added `applyAtomicChanges` function.

ioeric reopened this revision. ioeric added a comment. This revision is now accepted and ready to land. This (https://reviews.llvm.org/rL298913) was reverted upstream due to cyclic dependency on GreenDragon bot. Investigating... Repository: rL LLVM https://reviews.llvm.org/D30777

[PATCH] D30777: Added `applyAtomicChanges` function.

ioeric updated this revision to Diff 94497. ioeric added a comment. Herald added a subscriber: mgorny. - Try to unbreak buildbots after r298913. - Add clangFormat to dependency - Update cmake https://reviews.llvm.org/D30777 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling

[PATCH] D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd.

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. Regarding the testing. It looks like we have two ways of testing this: 1. Add clangd-specific protocol handlers that output useful stats(i.e. currently opened documents), use those in tests. 2. Add unit tests that emu

[PATCH] D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd.

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Addressed the locking comments. Locking inside the request handlers looks much nicer indeed. Comment at: clangd/ASTManager.cpp:203 + // TODO(ibiryukov): at this point DocDatasLock can be unlocked i

[PATCH] D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd.

ilya-biryukov updated this revision to Diff 94494. ilya-biryukov added a comment. Moved locking of ClangObjectLock into request handlers. https://reviews.llvm.org/D31746 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/ClangDMain.cpp clangd/Protocol.cpp clangd/Protocol.h clan

[PATCH] D31746: Remove ASTUnits for closed documents and cache CompilationDatabase per directory in clangd.

ilya-biryukov updated this revision to Diff 94492. ilya-biryukov added a comment. Minor fixes. Fixed variable name issues and comment spelling errors. https://reviews.llvm.org/D31746 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/ClangDMain.cpp clangd/Protocol.cpp clangd/Prot

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Alexey, thank you for reviewing this. If you don't mind, I will wait applying the changes you requested, Unfortunately I am not ready yet to send out an update as I am still working on the vector ABI. I will ping you when ready. Francesco https://reviews.llvm.org

[PATCH] D31760: [lsan] Enable LSan on arm Linux, clang part

m.ostapenko updated this revision to Diff 94489. m.ostapenko added a comment. Also check for thumb. Repository: rL LLVM https://reviews.llvm.org/D31760 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c