[libcxx] r302213 - Document XFAIL's with the relevent bug number

Author: ericwf Date: Fri May 5 00:19:21 2017 New Revision: 302213 URL: http://llvm.org/viewvc/llvm-project?rev=302213=rev Log: Document XFAIL's with the relevent bug number Modified: libcxx/trunk/test/std/numerics/rand/rand.device/ctor.pass.cpp

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

bcraig added a comment. I'm still working on this. Things I've learned: A clang install is bundled with re-implementations of several of these headers. The default #include_next behavior ends up pulling in lots of those. I have been able to get things working with a VC include path and a

[PATCH] D32891: [Sema][ObjC++] Objective-C++ support for __is_base_of(B, D)

erik.pilkington created this revision. This patch adds Objective-C interfaces support for the type trait `is_base_of`, so that `__is_base_of(NSString, NSMutableString)` is true. rdar://24308607 Thanks for taking a look! Erik https://reviews.llvm.org/D32891 Files: lib/Sema/SemaExprCXX.cpp

[PATCH] D32886: [asan] A clang flag to enable ELF globals-gc

eugenis added inline comments. Comment at: include/clang/Driver/Options.td:830 HelpText<"Disable use-after-scope detection in AddressSanitizer">; +def fsanitize_address_globals_live_support : Flag<["-"],

[PATCH] D32886: [asan] A clang flag to enable ELF globals-gc

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Generally makes sense. A question about the name. Feel free to land with a name that you and other sanitizer folks are happy with. Comment at:

[PATCH] D32886: [asan] A clang flag to enable ELF globals-gc

eugenis updated this revision to Diff 97901. Repository: rL LLVM https://reviews.llvm.org/D32886 Files: include/clang/Driver/Options.td include/clang/Driver/SanitizerArgs.h include/clang/Frontend/CodeGenOptions.def lib/CodeGen/BackendUtil.cpp lib/Driver/SanitizerArgs.cpp

[PATCH] D32886: [asan] A clang flag to enable ELF globals-gc

eugenis created this revision. This feature is subtly broken when the linker is gold 2.26 or earlier. See the following bug for details: https://sourceware.org/bugzilla/show_bug.cgi?id=19002 Since the decision needs to be made at compilation time, we can not test the linker version. The flag

r302207 - Document that Multilib flags must be actual flags

Author: jroelofs Date: Thu May 4 19:18:27 2017 New Revision: 302207 URL: http://llvm.org/viewvc/llvm-project?rev=302207=rev Log: Document that Multilib flags must be actual flags This is because -print-multi-lib depends on them being flags for correctness. Fixes a case of this in the

Re: [PATCH] D32879: Warn that the [] spelling of uuid(...) is deprecated.

On May 4, 2017 4:55 PM, "Nico Weber via Phabricator" < revi...@reviews.llvm.org> wrote: thakis created this revision. Herald added a subscriber: javed.absar. https://reviews.llvm.org/D32879 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Parse/ParseDeclCXX.cpp

[PATCH] D30427: Fix whitespace before token-paste of an argument.

This revision was automatically updated to reflect the committed changes. Closed by commit rL302195: Fix whitespace before token-paste of an argument. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D30427?vs=89918=97881#toc Repository: rL LLVM

r302195 - Fix whitespace before token-paste of an argument.

Author: jyknight Date: Thu May 4 16:31:17 2017 New Revision: 302195 URL: http://llvm.org/viewvc/llvm-project?rev=302195=rev Log: Fix whitespace before token-paste of an argument. The whitespace should come from the argument name in the macro expansion, rather than from the token passed to the

[PATCH] D32879: Warn that the [] spelling of uuid(...) is deprecated.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D32879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32879: Warn that the [] spelling of uuid(...) is deprecated.

thakis created this revision. Herald added a subscriber: javed.absar. https://reviews.llvm.org/D32879 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaDeclAttr.cpp test/Parser/MicrosoftExtensions.cpp test/Parser/ms-square-bracket-attributes.mm

[clang-tools-extra] r302191 - [clangd] Add documentation page

Author: malaperle Date: Thu May 4 14:57:53 2017 New Revision: 302191 URL: http://llvm.org/viewvc/llvm-project?rev=302191=rev Log: [clangd] Add documentation page Summary: Add a simple documentation page for Clangd. This will be useful for interested users and contributors to get basic

r302190 - Turn on -Wmicrosoft-enum-forward-reference by default.

Author: nico Date: Thu May 4 14:54:50 2017 New Revision: 302190 URL: http://llvm.org/viewvc/llvm-project?rev=302190=rev Log: Turn on -Wmicrosoft-enum-forward-reference by default. clang-cl already errs or warns on everything that cl warns on in /permissive- mode, except for enum foward

[PATCH] D32761: Fix bugs checking va_start in lambdas and erroneous contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rL302188: Fix bugs checking va_start in lambdas and erroneous contexts (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D32761?vs=97503=97868#toc Repository: rL LLVM

r302188 - Fix bugs checking va_start in lambdas and erroneous contexts

Author: rnk Date: Thu May 4 14:51:05 2017 New Revision: 302188 URL: http://llvm.org/viewvc/llvm-project?rev=302188=rev Log: Fix bugs checking va_start in lambdas and erroneous contexts Summary: First, getCurFunction looks through blocks and lambdas, which is wrong. Inside a lambda, va_start

r302187 - Turn -Wmicrosoft-enum-value off by default.

Author: nico Date: Thu May 4 14:36:26 2017 New Revision: 302187 URL: http://llvm.org/viewvc/llvm-project?rev=302187=rev Log: Turn -Wmicrosoft-enum-value off by default. The warning is currently way too noisy to be useful. The plan is to make it warn when an MS enum that's negative is compared

[PATCH] D32543: [X86] Clang option -fuse-init-array has no effect when generating for MCU target

AndreiGrischenko updated this revision to Diff 97866. AndreiGrischenko added a comment. Thanks Craig for the good advice. You are right I can check llc with MCU triple using option -use-ctors. Please see updated patch. https://reviews.llvm.org/D32543 Files:

r302184 - Driver: only inject libstdc++ paths when needed on CrossWindows

Author: compnerd Date: Thu May 4 14:18:21 2017 New Revision: 302184 URL: http://llvm.org/viewvc/llvm-project?rev=302184=rev Log: Driver: only inject libstdc++ paths when needed on CrossWindows When building with libc++ don't bother with injecting the libstdc++ search paths into the linker

[libcxx] r302182 - Fix test failure with GCC 4.9

Author: ericwf Date: Thu May 4 14:13:28 2017 New Revision: 302182 URL: http://llvm.org/viewvc/llvm-project?rev=302182=rev Log: Fix test failure with GCC 4.9 Modified: libcxx/trunk/test/support/test.workarounds/c1xx_broken_is_trivially_copyable.pass.cpp Modified:

[libcxx] r302181 - Change Appveyor to download Clang from llvm.org instead of my private server

Author: ericwf Date: Thu May 4 14:04:50 2017 New Revision: 302181 URL: http://llvm.org/viewvc/llvm-project?rev=302181=rev Log: Change Appveyor to download Clang from llvm.org instead of my private server Modified: libcxx/trunk/appveyor.yml libcxx/trunk/install-appveyor-reqs.cmd

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

JonasToth added a comment. this check is somewhat duplicated to a check currently in review, which seemed to be abondened? https://reviews.llvm.org/D19201 I will read that one first and try to coordinate with the author. Repository: rL LLVM https://reviews.llvm.org/D31370

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski updated this revision to Diff 97859. sbarzowski added a comment. Herald added a subscriber: xazax.hun. Fixed false positive issues https://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

r302179 - [ms-inline-asm] Use the frontend size only for ambiguous instructions

Author: rnk Date: Thu May 4 13:19:52 2017 New Revision: 302179 URL: http://llvm.org/viewvc/llvm-project?rev=302179=rev Log: [ms-inline-asm] Use the frontend size only for ambiguous instructions This avoids problems on code like this: char buf[16]; __asm { movups xmm0, [buf] mov

r302176 - Re-apply r302108, "IR: Use pointers instead of GUIDs to represent edges in the module summary. NFCI."

Author: pcc Date: Thu May 4 13:03:25 2017 New Revision: 302176 URL: http://llvm.org/viewvc/llvm-project?rev=302176=rev Log: Re-apply r302108, "IR: Use pointers instead of GUIDs to represent edges in the module summary. NFCI." with a fix for the clang backend. Modified:

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

Hahnfeld added a comment. One minor drive-by comment. I think there is still one outstanding from Justin... Comment at: lib/Driver/ToolChains/Cuda.cpp:368 + assert(!GpuArch.empty() && "Must have an explicit GPU arch."); + std::string LibDeviceFile; You

[libcxx] r302168 - Use lgamma_r instead of lgamma in binomial_distribution, because freakin' POSIX took a perfectly fine call and made it not thread safe.

Author: marshall Date: Thu May 4 11:36:39 2017 New Revision: 302168 URL: http://llvm.org/viewvc/llvm-project?rev=302168=rev Log: Use lgamma_r instead of lgamma in binomial_distribution, because freakin' POSIX took a perfectly fine call and made it not thread safe. Modified:

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

EricWF added a comment. > libc++ committed to ABI stability for optional, a new feature of C++17, > before the standard shipped? Libc++ doesn't commit to anything, the vendors such as Apple and FreeBSD do. I don't think either of them have shipped a release with std::optional yet, but I need

[PATCH] D32424: Add a fix-it for -Wunguarded-availability

erik.pilkington added a comment. Hi Alex, thanks for working on this! This looks right, but I have a couple of comments. Thanks, Erik Comment at: lib/Sema/SemaDeclAttr.cpp:7151 +Visitor.Scope = Scope; +Visitor.TraverseStmt(const_cast(Scope)); +return

[clang-tools-extra] r302164 - [clang-tidy] fix readability-implicit-bool-cast false positive with xor

Author: alexfh Date: Thu May 4 11:06:08 2017 New Revision: 302164 URL: http://llvm.org/viewvc/llvm-project?rev=302164=rev Log: [clang-tidy] fix readability-implicit-bool-cast false positive with xor Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp

[PATCH] D32510: [libcxx] Fix C1XX implementation of DoNotOptimize

This revision was automatically updated to reflect the committed changes. Closed by commit rL302162: [test] Name the local variable in the C1XX implementation of DoNotOptmize (authored by CaseyCarter). Changed prior to commit: https://reviews.llvm.org/D32510?vs=96648=97837#toc Repository:

[libcxx] r302162 - [test] Name the local variable in the C1XX implementation of DoNotOptmize

Author: caseycarter Date: Thu May 4 10:54:09 2017 New Revision: 302162 URL: http://llvm.org/viewvc/llvm-project?rev=302162=rev Log: [test] Name the local variable in the C1XX implementation of DoNotOptmize Differential Revision: https://reviews.llvm.org/D32510 Modified:

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

CaseyCarter added a comment. In https://reviews.llvm.org/D32385#745771, @EricWF wrote: > So Itanium ABI has this quirk where trivial types are passed using different > conventions than non-trivial types. This means changing the triviality of > `std::optional` for any instantiation is

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

CaseyCarter updated this revision to Diff 97834. CaseyCarter added a comment. The constexpr variant tests were enabled separate commit (https://reviews.llvm.org/rL302158). This differential now contains only the fine-grained SMF triviality extension test. https://reviews.llvm.org/D32671

[clang-tools-extra] r302161 - [clang-tidy] fix readability-implicit-bool-cast false alarm on |=, &=

Author: alexfh Date: Thu May 4 10:34:31 2017 New Revision: 302161 URL: http://llvm.org/viewvc/llvm-project?rev=302161=rev Log: [clang-tidy] fix readability-implicit-bool-cast false alarm on |=, &= Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp

[clang-tools-extra] r302160 - [clang-tidy] Code cleanup, (almost) NFC (*).

Author: alexfh Date: Thu May 4 10:34:23 2017 New Revision: 302160 URL: http://llvm.org/viewvc/llvm-project?rev=302160=rev Log: [clang-tidy] Code cleanup, (almost) NFC (*). (*) Printed types of member pointers don't use elaborated type specifiers (`int struct S::*` -> `int S::*`). Modified:

r302159 - [Tooling] add a createReplacement overload for StringRef

Author: alexfh Date: Thu May 4 10:34:06 2017 New Revision: 302159 URL: http://llvm.org/viewvc/llvm-project?rev=302159=rev Log: [Tooling] add a createReplacement overload for StringRef Modified: cfe/trunk/include/clang/Tooling/FixIt.h Modified: cfe/trunk/include/clang/Tooling/FixIt.h URL:

[PATCH] D32543: [X86] Clang option -fuse-init-array has no effect when generating for MCU target

craig.topper added a comment. It looksl ike UseInitArray is connected to -use-ctors command line option to llc so we should be able to test this without a frontend test. https://reviews.llvm.org/D32543 ___ cfe-commits mailing list

[PATCH] D32543: [X86] Clang option -fuse-init-array has no effect when generating for MCU target

craig.topper added a comment. Should we add a test to test/CodeGen/X86/constructor.ll that test appears to have been modified when NAcl was added to the line you changed. https://reviews.llvm.org/D32543 ___ cfe-commits mailing list

r302156 - clang-format: [JS] exponentiation operator

Author: mprobst Date: Thu May 4 10:04:04 2017 New Revision: 302156 URL: http://llvm.org/viewvc/llvm-project?rev=302156=rev Log: clang-format: [JS] exponentiation operator Summary: While its precedence should be higher than multiplicative, LLVM does not have a level for that, so for the time

[PATCH] D32864: clang-format: [JS] exponentiation operator

This revision was automatically updated to reflect the committed changes. Closed by commit rL302156: clang-format: [JS] exponentiation operator (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D32864?vs=97829=97830#toc Repository: rL LLVM

[PATCH] D32864: clang-format: [JS] exponentiation operator

djasper accepted this revision. djasper added a comment. Thanks https://reviews.llvm.org/D32864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32864: clang-format: [JS] exponentiation operator

mprobst updated this revision to Diff 97829. mprobst added a comment. - support **= https://reviews.llvm.org/D32864 Files: lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

[PATCH] D32856: [OpenCL] Check that global samplers are const

yaxunl added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8301 +def err_opencl_sampler_qualifier : Error< + "global sampler requires a const qualifier">; def err_opencl_cast_non_zero_to_event_t : Error< global sampler requires a

[PATCH] D32864: clang-format: [JS] exponentiation operator

djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTestJS.cpp:1791 +TEST_F(FormatTestJS, Exponentiation) { + verifyFormat("squared = x ** 2;"); +} Also make this

[PATCH] D32864: clang-format: [JS] exponentiation operator

mprobst created this revision. Herald added a subscriber: klimek. While its precedence should be higher than multiplicative, LLVM does not have a level for that, so for the time being just treat it as multiplicative. https://reviews.llvm.org/D32864 Files: lib/Format/FormatToken.h

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

On 4 May 2017 at 12:52, Alex L wrote: > > > On 4 May 2017 at 12:43, Alex L wrote: > >> >> >> On 3 May 2017 at 22:23, Richard Smith wrote: >> >>> On 3 May 2017 at 07:29, Alex L wrote: >>> Hi Richard,

r302151 - DiagnosticsEngine should clear DelayedDiagID before reporting the

Author: arphaman Date: Thu May 4 08:56:51 2017 New Revision: 302151 URL: http://llvm.org/viewvc/llvm-project?rev=302151=rev Log: DiagnosticsEngine should clear DelayedDiagID before reporting the delayed diagnostic This fix avoids an infinite recursion that was uncovered in one of our internal

[PATCH] D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons

baloghadamsoftware created this revision. Extension of the mismatched iterator checker for constructors taking range of first..last (first and last must be iterators of the same container) and also for comparisons of iterators of different containers (one does not compare iterators of

r302143 - Add support of the next Ubuntu (Ubuntu 17.10 - Artful Aardvark)

Author: sylvestre Date: Thu May 4 07:46:38 2017 New Revision: 302143 URL: http://llvm.org/viewvc/llvm-project?rev=302143=rev Log: Add support of the next Ubuntu (Ubuntu 17.10 - Artful Aardvark) Modified: cfe/trunk/include/clang/Driver/Distro.h cfe/trunk/lib/Driver/Distro.cpp Modified:

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware created this revision. If a container is moved by its move assignment operator, according to the standard all their iterators except the past-end iterators remain valid but refer to the new container. This patch introduces support for this case in the iterator checkers.

r302141 - Revert "IR: Use pointers instead of GUIDs to represent edges in the module summary. NFCI."

Author: ioeric Date: Thu May 4 07:05:40 2017 New Revision: 302141 URL: http://llvm.org/viewvc/llvm-project?rev=302141=rev Log: Revert "IR: Use pointers instead of GUIDs to represent edges in the module summary. NFCI." This reverts commit r302108. Modified:

[PATCH] D32592: [Analyzer] Iterator Checker - Part1: Minimal Checker for a Simple Test Case

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:478-479 +auto = C.getSymbolManager(); +EndSym = SymMgr.conjureSymbol(CE, C.getLocationContext(), + C.getASTContext().LongTy, C.blockCount()); +

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

On 4 May 2017 at 12:43, Alex L wrote: > > > On 3 May 2017 at 22:23, Richard Smith wrote: > >> On 3 May 2017 at 07:29, Alex L wrote: >> >>> Hi Richard, >>> >>> This commit has caused an infinite loop in one of our internal libclang

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

On 3 May 2017 at 22:23, Richard Smith wrote: > On 3 May 2017 at 07:29, Alex L wrote: > >> Hi Richard, >> >> This commit has caused an infinite loop in one of our internal libclang >> based tooling tests. It keeps repeating the following frames: >> >>

[PATCH] D32592: [Analyzer] Iterator Checker - Part1: Minimal Checker for a Simple Test Case

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:211-214 +std::pair +createDifference(SymbolManager , SymbolRef Sym1, SymbolRef Sym2); +const llvm::APSInt *getDifference(ProgramStateRef State,

r302136 - [Index] The relation between the declarations in template

Author: arphaman Date: Thu May 4 05:42:06 2017 New Revision: 302136 URL: http://llvm.org/viewvc/llvm-project?rev=302136=rev Log: [Index] The relation between the declarations in template specializations that 'override' declarations in the base template should use the 'specializationOf' relation

[PATCH] D32856: [OpenCL] Check that global samplers are const

svenvh created this revision. Patch by Simon Perretta. https://reviews.llvm.org/D32856 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/sampler_t.cl Index: test/SemaOpenCL/sampler_t.cl

[PATCH] D32592: [Analyzer] Iterator Checker - Part1: Minimal Checker for a Simple Test Case

NoQ added a comment. I see the checker going towards what we call "metadata symbols", which seems logical. I still feel the checker deserves a lot more comments around the code. In particular, i'd definitely love to see a human-readable explanation of what kinds of iterators are supported

[PATCH] D32574: [libcxx] [test] Fixed possible loss of data warnings in tests on amd64

EricWF added inline comments. Comment at: test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:39 assert(pos <= sv.size()); -unsigned rlen = std::min(sv.size() - pos, n); +unsigned rlen = std::min(static_cast(sv.size()) - pos, n);

[PATCH] D32574: [libcxx] [test] Fixed possible loss of data warnings in tests on amd64

BillyONeal added inline comments. Comment at: test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:39 assert(pos <= sv.size()); -unsigned rlen = std::min(sv.size() - pos, n); +unsigned rlen = std::min(static_cast(sv.size()) - pos, n);

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

BillyONeal added inline comments. Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:146 +auto res = std::gcd(static_cast(1234), INT32_MIN); +static_assert(std::is_same>::value, "");

r302131 - [ARM] ACLE Chapter 9 intrinsics

Author: sam_parker Date: Thu May 4 03:37:59 2017 New Revision: 302131 URL: http://llvm.org/viewvc/llvm-project?rev=302131=rev Log: [ARM] ACLE Chapter 9 intrinsics Implemented the remaining integer data processing intrinsics from the ARM ACLE v2.1 spec, such as parallel arithemtic and DSP style

[PATCH] D32743: [clang-tidy] Add new cert-dcl21-cpp check.

xazax.hun updated this revision to Diff 97790. xazax.hun added a comment. - Fixed include order. https://reviews.llvm.org/D32743 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/PostfixOperatorCheck.cpp clang-tidy/cert/PostfixOperatorCheck.h

[PATCH] D32743: [clang-tidy] Add new cert-dcl21-cpp check.

xazax.hun updated this revision to Diff 97789. xazax.hun marked 21 inline comments as done. xazax.hun added a comment. - Fixes according to the review comments. https://reviews.llvm.org/D32743 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

EricWF added a comment. So Itanium ABI has this quirk where trivial types are passed using different conventions than non-trivial types. This means changing the triviality of `std::optional` for any instantiation is potentially ABI breaking. I'll need to do more investigation to find out how

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

EricWF added inline comments. Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:146 +auto res = std::gcd(static_cast(1234), INT32_MIN); +static_assert(std::is_same>::value, "");

[PATCH] D32386: [libcxx] [test] Avoid P0138R2, direct-list-init of fixed enums from integers.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Could you add a separate test that performs direct-list-init of fixed enums from integers, and XFAIL it accordingly? Testing it found a bug, so I don't want to complete eliminate that test

[PATCH] D32510: [libcxx] Fix C1XX implementation of DoNotOptimize

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Oops. Thanks for the fix. https://reviews.llvm.org/D32510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

EricWF added a comment. Could you commit all the changes *except* the trivial extensions tests, and then update this to contain only that? https://reviews.llvm.org/D32671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32574: [libcxx] [test] Fixed possible loss of data warnings in tests on amd64

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing inline comments. Comment at: test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:39 assert(pos <= sv.size()); -unsigned

[PATCH] D32727: [libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance shouldn't be mandated".

EricWF added a comment. LGTM minus inline comments. https://reviews.llvm.org/D32727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32727: [libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance shouldn't be mandated".

EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: test/std/iterators/stream.iterators/istream.iterator/types.pass.cpp:42 #include int main() Needs `#include "test_macros.h"`

[libcxx] r302129 - Fix incorrect usage of __libcpp_mutex_trylock. Patch from Andrey Khalyavin

Author: ericwf Date: Thu May 4 02:45:09 2017 New Revision: 302129 URL: http://llvm.org/viewvc/llvm-project?rev=302129=rev Log: Fix incorrect usage of __libcpp_mutex_trylock. Patch from Andrey Khalyavin Modified: libcxx/trunk/src/memory.cpp Modified: libcxx/trunk/src/memory.cpp URL:

[libcxx] r302128 - Update Appveyor bot link to point to new llvm-mirror Appveyor account

Author: ericwf Date: Thu May 4 02:40:23 2017 New Revision: 302128 URL: http://llvm.org/viewvc/llvm-project?rev=302128=rev Log: Update Appveyor bot link to point to new llvm-mirror Appveyor account Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL:

[PATCH] D30805: [OpenCL] Add intel_reqd_sub_group_size attribute support

This revision was automatically updated to reflect the committed changes. Closed by commit rL302125: [OpenCL] Add intel_reqd_sub_group_size attribute support (authored by pxl). Changed prior to commit: https://reviews.llvm.org/D30805?vs=97772=97786#toc Repository: rL LLVM

r302125 - [OpenCL] Add intel_reqd_sub_group_size attribute support

Author: pxl Date: Thu May 4 02:31:20 2017 New Revision: 302125 URL: http://llvm.org/viewvc/llvm-project?rev=302125=rev Log: [OpenCL] Add intel_reqd_sub_group_size attribute support Summary: Add intel_reqd_sub_group_size attribute support as intel extension cl_intel_required_subgroup_size from

[libcxx] r302122 - test commit

Author: ericwf Date: Thu May 4 01:28:34 2017 New Revision: 302122 URL: http://llvm.org/viewvc/llvm-project?rev=302122=rev Log: test commit Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

[libcxx] r302120 - test commit

Author: ericwf Date: Thu May 4 01:27:06 2017 New Revision: 302120 URL: http://llvm.org/viewvc/llvm-project?rev=302120=rev Log: test commit Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

[PATCH] D32735: [libcxxabi][CMake] Set library dir when built under runtimes/

This revision was automatically updated to reflect the committed changes. Closed by commit rL302118: [libcxxabi][CMake] Set library dir when built under runtimes/ (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D32735?vs=97402=9#toc Repository: rL LLVM

[libcxxabi] r302118 - [libcxxabi][CMake] Set library dir when built under runtimes/

Author: hahnfeld Date: Thu May 4 01:04:49 2017 New Revision: 302118 URL: http://llvm.org/viewvc/llvm-project?rev=302118=rev Log: [libcxxabi][CMake] Set library dir when built under runtimes/ This will put libraries into the build root's lib/ directory by default. Differential Revision:

[PATCH] D32736: [libcxx][CMake] Set library dir when built under runtimes/

This revision was automatically updated to reflect the committed changes. Closed by commit rL302117: [libcxx][CMake] Set library dir when built under runtimes/ (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D32736?vs=97403=97776#toc Repository: rL LLVM

[libcxx] r302117 - [libcxx][CMake] Set library dir when built under runtimes/

Author: hahnfeld Date: Thu May 4 01:02:50 2017 New Revision: 302117 URL: http://llvm.org/viewvc/llvm-project?rev=302117=rev Log: [libcxx][CMake] Set library dir when built under runtimes/ This will put libraries into the build root's lib/ directory by default. Differential Revision:

[libcxx] r302116 - update buildbot doc to link to the new Appveyor builders

Author: ericwf Date: Thu May 4 00:58:59 2017 New Revision: 302116 URL: http://llvm.org/viewvc/llvm-project?rev=302116=rev Log: update buildbot doc to link to the new Appveyor builders Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL: