[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

echuraev updated this revision to Diff 100210. https://reviews.llvm.org/D31745 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/clang-builtin-version.cl test/SemaOpenCL/to_addr_builtin.cl Index: test/SemaOpenCL/to_addr_builtin.cl ===

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

baloghadamsoftware added a comment. Any comments regarding the last changes? https://reviews.llvm.org/D32592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33538: [coroutines] Support "coroutines" feature to module map "requires"

EricWF updated this revision to Diff 100207. EricWF added a comment. - Alphabetize newly added switch case. https://reviews.llvm.org/D33538 Files: docs/Modules.rst lib/Basic/Module.cpp test/Modules/Inputs/DependsOnModule.framework/Headers/coroutines.h test/Modules/Inputs/DependsOnModule

[PATCH] D32350: [Analyzer] Exception checker for misuse: uncaught/noncompliant throws

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Superseded by https://reviews.llvm.org/D33537 https://reviews.llvm.org/D32350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D33538: [coroutines] Support "coroutines" feature to module map "requires"

EricWF created this revision. In order for libc++ to add `` to its module map, there has to be a feature that can be used to detect if coroutines support is enabled in Clang. https://reviews.llvm.org/D33538 Files: docs/Modules.rst lib/Basic/Module.cpp test/Modules/Inputs/DependsOnModule

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware added a comment. Supersedes https://reviews.llvm.org/D32350 https://reviews.llvm.org/D33537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33537: [clang-tidy] Exception Escape Checker

baloghadamsoftware created this revision. Herald added a subscriber: mgorny. Finds functions which should not throw exceptions: Destructors, move constructors, move assignment operators, the main() function, swap() functions, functions marked with throw() or noexcept and functions given as optio

[libcxx] r303838 - Remove from the module map for now. It doesn't work unless modules are enabled

Author: ericwf Date: Thu May 25 00:30:05 2017 New Revision: 303838 URL: http://llvm.org/viewvc/llvm-project?rev=303838&view=rev Log: Remove from the module map for now. It doesn't work unless modules are enabled Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include

[PATCH] D33536: [coroutines] Bump __cpp_coroutines version

EricWF created this revision. This patch is needed so that Libc++ can actually tess if Clang supports coroutines, instead of just paying lip service with a partial implementation. Otherwise the libc++ test suite will fail against older versions of Clang https://reviews.llvm.org/D33536 Files:

[libcxx] r303837 - Disable the coroutines tests until Clang bumps __cpp_coroutines to reflect recent changes

Author: ericwf Date: Thu May 25 00:11:40 2017 New Revision: 303837 URL: http://llvm.org/viewvc/llvm-project?rev=303837&view=rev Log: Disable the coroutines tests until Clang bumps __cpp_coroutines to reflect recent changes Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/

[libcxx] r303836 - Add

Author: ericwf Date: Wed May 24 23:36:24 2017 New Revision: 303836 URL: http://llvm.org/viewvc/llvm-project?rev=303836&view=rev Log: Add This patch adds the library portions of the coroutines PDTS, which should now be supported by Clang. Added: libcxx/trunk/include/experimental/coroutine

[libcxx] r303835 - Fix broken links on C++1z status page

Author: ericwf Date: Wed May 24 23:09:07 2017 New Revision: 303835 URL: http://llvm.org/viewvc/llvm-project?rev=303835&view=rev Log: Fix broken links on C++1z status page Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/ll

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv updated this revision to Diff 100201. george.burgess.iv added a comment. Herald added a subscriber: jfb. Fix the aforementioned issue; PTAL. Note that this fix is slightly backwards incompatible. It disallows code like: void foo(int); void foo(int) __attribute__((overloadab

[PATCH] D33534: [coroutines] Diagnose when promise types fail to declare either return_void or return_value.

EricWF created this revision. According to the PDTS it's perfectly legal to have a promise type that defines neither `return_value` nor `return_void`. However a coroutine that uses such a promise type will almost always have UB, because it can never `co_return`. This patch changes Clang to diag

[libcxx] r303833 - Add non-parallel version of for_each_n (+tests) from the Parallelism TS

Author: marshall Date: Wed May 24 21:29:54 2017 New Revision: 303833 URL: http://llvm.org/viewvc/llvm-project?rev=303833&view=rev Log: Add non-parallel version of for_each_n (+tests) from the Parallelism TS Added: libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.foreach/for_each_n.pass.

r303831 - [coroutines] Fix fallthrough diagnostics for coroutines

Author: ericwf Date: Wed May 24 21:16:53 2017 New Revision: 303831 URL: http://llvm.org/viewvc/llvm-project?rev=303831&view=rev Log: [coroutines] Fix fallthrough diagnostics for coroutines Summary: This patch fixes a number of issues with the analysis warnings emitted when a coroutine may reach

[PATCH] D33532: [coroutines] Fix fallthrough diagnostics for coroutines

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D33532: [coroutines] Fix fallthrough diagnostics for coroutines

EricWF added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:378 const Stmt *S = CS.getStmt(); -if ((isa(S) && !IsCoroutine) || isa(S)) { +if (isa(S) || isa(S)) { HasLiveReturn = true; GorNishanov wrote: > Is this check no long

[PATCH] D33532: [coroutines] Fix fallthrough diagnostics for coroutines

GorNishanov added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:378 const Stmt *S = CS.getStmt(); -if ((isa(S) && !IsCoroutine) || isa(S)) { +if (isa(S) || isa(S)) { HasLiveReturn = true; Is this check no longer needed becaus

[PATCH] D33532: [coroutines] Fix fallthrough diagnostics for coroutines

EricWF created this revision. This patch fixes a number of issues with the analysis warnings emitted when a coroutine may reach the end of the function w/o returning. - Fix bug where coroutines with `return_value` are incorrectly diagnosed as missing `co_return`'s. - Rework diagnostic message t

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 24 May 2017 at 15:32, Marshall Clow via Phabricator wrote: > More. Trying the above code on godbolt.org, gcc 6.1/6.2/6.3/7.1 all reject it > (with `-std=c++14` and `-std=c++1z`) with the error message: This was a pretty explicit intent in Richard's proposal: treat incoming code as charitably

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 24 May 2017 3:19 pm, "Tim Northover" wrote: On 24 May 2017 at 15:06, Richard Smith wrote: > I think this is expected. Clang has an extension where it treats 1.0if as a > _Complex float if no operator""if is available; Since it's breaking some bots, I've reverted my commit while we hash this

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:423 + +class AARGetter { + FunctionAnalysisManager &AM; mehdi_amini wrote: > Can't you do it with a lambda? I can, except that AAR needs to be allocated outside of the la

[libcxx] r303824 - Add some constexpr tests for optional's move/copy ctor

Author: marshall Date: Wed May 24 19:22:33 2017 New Revision: 303824 URL: http://llvm.org/viewvc/llvm-project?rev=303824&view=rev Log: Add some constexpr tests for optional's move/copy ctor Modified: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/copy.pass.cpp

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

mehdi_amini added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:423 + +class AARGetter { + FunctionAnalysisManager &AM; Can't you do it with a lambda? https://reviews.llvm.org/D33525 __

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen created this revision. Herald added subscribers: eraman, inglorion, Prazek, mehdi_amini. Also see https://reviews.llvm.org/D33429 for other ThinLTO + New PM related changes. https://reviews.llvm.org/D33525 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thin_link_bitcod

[PATCH] D33328: [CodeGen] Pessimize aliasing for union members (and may-alias) objects

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, that looks great. Repository: rL LLVM https://reviews.llvm.org/D33328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Makes sense. LGTM! Repository: rL LLVM https://reviews.llvm.org/D33357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

jroelofs updated this revision to Diff 100177. jroelofs marked an inline comment as done. jroelofs added a comment. Fix a cmake warning: Platform/baremetal to use this system, please send your config file to cm...@www.cmake.org so it can be added to cmake Your CMakeCache.txt file was copied

[PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

mclow.lists added a comment. More. Trying the above code on godbolt.org, gcc 6.1/6.2/6.3/7.1 all reject it (with `-std=c++14` and `-std=c++1z`) with the error message: > : In function 'int main()': > :4:30: error: unable to find numeric literal operator 'operator""if' > > { std::complex foo

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 24 May 2017 at 15:06, Richard Smith wrote: > I think this is expected. Clang has an extension where it treats 1.0if as a > _Complex float if no operator""if is available; Since it's breaking some bots, I've reverted my commit while we hash this out. r303813. > libc++ has an extension > where

r303813 - Revert "Sema: allow imaginary constants via GNU extension if UDL overloads not present."

Author: tnorthover Date: Wed May 24 17:18:35 2017 New Revision: 303813 URL: http://llvm.org/viewvc/llvm-project?rev=303813&view=rev Log: Revert "Sema: allow imaginary constants via GNU extension if UDL overloads not present." This reverts commit r303697. It broke libc++ tests that were specifica

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 24 May 2017 at 14:35, Marshall Clow via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > mclow.lists added a comment. > > This broke a libc++ test. The following is expected to fail to compile: > > #include > #include > > int main() > { > std::complex foo = 1

[PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

mclow.lists added a comment. This broke a libc++ test. The following is expected to fail to compile: #include #include int main() { std::complex foo = 1.0if; // should fail w/conversion operator not found } when build as C++1z https://reviews.llvm.org/D33424 ___

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

kcc added a comment. Done (see https://github.com/google/oss-fuzz/blob/master/projects/llvm_libcxxabi/project.yaml) Repository: rL LLVM https://reviews.llvm.org/D33368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

erik.pilkington added a comment. > Also, are you now maintaining this code? > I am trying to find someone who wants to be CC-ed to other demangler bugs > automatically reported by oss-fuzz. I don’t think I’ll accept the title of maintainer, (I only have one commit in this file!) but I have som

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

brycel updated this revision to Diff 100161. brycel added a comment. Double backticks, not single. https://reviews.llvm.org/D33497 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/LambdaFunctionNameCheck.cpp clang-tidy/misc/LambdaFunctionNameCheck.h clang-tidy/misc/MiscTidyModule.c

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

brycel marked an inline comment as done. brycel added inline comments. Comment at: docs/ReleaseNotes.rst:83 + + Finds uses of __func__ or __FUNCTION__ inside lambdas. + Eugene.Zelenko wrote: > Eugene.Zelenko wrote: > > Please highlight __func__ and __FUNCTI

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:83 + + Finds uses of __func__ or __FUNCTION__ inside lambdas. + Eugene.Zelenko wrote: > Please highlight __func__ and __FUNCTION__ with ``. I meant double ``, not single `. https://re

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

kcc added a comment. Also, are you now maintaining this code? I am trying to find someone who wants to be CC-ed to other demangler bugs automatically reported by oss-fuzz. Repository: rL LLVM https://reviews.llvm.org/D33368 ___ cfe-commits mail

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

kcc added a comment. I also encourage you to run the fuzzer on every change in this code. Repository: rL LLVM https://reviews.llvm.org/D33368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

erik.pilkington added a comment. r303806 removes the assertion (instead just returning first). I though this should never happen, I'm looking into this testcase to see if there is another bug here. Thanks, Erik Repository: rL LLVM https://reviews.llvm.org/D33368 _

[libcxxabi] r303806 - [Demangler] Remove a failing assert introduced in r303718

Author: epilk Date: Wed May 24 15:53:13 2017 New Revision: 303806 URL: http://llvm.org/viewvc/llvm-project?rev=303806&view=rev Log: [Demangler] Remove a failing assert introduced in r303718 Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL: ht

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

brycel updated this revision to Diff 100159. brycel marked an inline comment as done. brycel added a comment. Fixed ReleaseNotes.rst https://reviews.llvm.org/D33497 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/LambdaFunctionNameCheck.cpp clang-tidy/misc/LambdaFunctionNameCheck.h

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

kcc added a comment. oss-fuzz finds the assertion failure in this new code: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1834 Repository: rL LLVM https://reviews.llvm.org/D33368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

craig.topper added a comment. Is there enough functional here that there should be tests for? i.e. make sure march/mcpu switches are recognized, that the target is recognized, etc. https://reviews.llvm.org/D33356 ___ cfe-commits mailing list cfe-co

r303804 - Basic: fix whitespace in file header (NFC)

Author: compnerd Date: Wed May 24 15:27:09 2017 New Revision: 303804 URL: http://llvm.org/viewvc/llvm-project?rev=303804&view=rev Log: Basic: fix whitespace in file header (NFC) Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL: http://llvm.org/viewvc/l

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:83 + + Finds uses of __func__ or __FUNCTION__ inside lambdas. + Please highlight __func__ and __FUNCTION__ with ``. https://reviews.llvm.org/D33497

[PATCH] D33507: [coroutines] Add support for coroutines with non-scalar parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL303803: [coroutines] Add support for coroutines with non-scalar parameters (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D33507?vs=100132&id=100152#toc Repository: rL L

[PATCH] D33507: [coroutines] Add support for coroutines with non-scalar parameters

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r303803 - [coroutines] Add support for coroutines with non-scalar parameters

Author: gornishanov Date: Wed May 24 15:09:14 2017 New Revision: 303803 URL: http://llvm.org/viewvc/llvm-project?rev=303803&view=rev Log: [coroutines] Add support for coroutines with non-scalar parameters Summary: Simple types like int are handled by LLVM Coroutines just fine. But for non-scalar

RE: r303798 - For Microsoft compatibility, set fno_operator_names

Thanks for the feedback, working on it… From: Keane, Erich Sent: Wednesday, May 24, 2017 3:47 PM To: Nico Weber ; Blower, Melanie Cc: cfe-commits ; rnk Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names Adding Melanie, the author of the patch. From: tha...@google.com

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

brycel updated this revision to Diff 100149. brycel added a comment. Herald added a subscriber: xazax.hun. Addressed the following review comments: - Added a test to make sure we don't warn on __PRETTY_FUNCTION__ - Suppressed warnings when in a macro that also uses __FILE__ and __LINE__ - Updated

RE: r303798 - For Microsoft compatibility, set fno_operator_names

Adding Melanie, the author of the patch. From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber Sent: Wednesday, May 24, 2017 12:43 PM To: Keane, Erich Cc: cfe-commits ; rnk Subject: Re: r303798 - For Microsoft compatibility, set fno_operator_names Reviewed here: https://rev

Re: r303798 - For Microsoft compatibility, set fno_operator_names

Reviewed here: https://reviews.llvm.org/D33505 Still, please make this warn. On Wed, May 24, 2017 at 3:42 PM, Nico Weber wrote: > Was this reviewed somewhere? > > Please make it so that this emits a warning. We want clang-cl to warn on > invalid code (and in system headers warnings are suppress

Re: r303798 - For Microsoft compatibility, set fno_operator_names

Was this reviewed somewhere? Please make it so that this emits a warning. We want clang-cl to warn on invalid code (and in system headers warnings are suppressed). On Wed, May 24, 2017 at 3:31 PM, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Wed M

r303798 - For Microsoft compatibility, set fno_operator_names

Author: erichkeane Date: Wed May 24 14:31:19 2017 New Revision: 303798 URL: http://llvm.org/viewvc/llvm-project?rev=303798&view=rev Log: For Microsoft compatibility, set fno_operator_names There's a Microsoft header in the Windows SDK which won't compile with clang because it uses an operator na

[PATCH] D33489: [OpenCL] Added regression test on invalid vector initialization.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D33483: [OpenCL] reserve_id_t cannot be used as argument to kernel function

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Btw the same applies to the program scope declaration (s6.9.p), but could be done as a separate change. https://reviews.llvm.org/D33483

[PATCH] D33353: [OpenCL] An error shall occur if any scalar operand has greater rank than the type of the vector element

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8307 "variable length arrays are not supported in OpenCL">; +def err_scalar_type_rank_greater_than_vector_type : Error< +"scalar operand type has greater rank than the type of the vecto

[PATCH] D33328: [CodeGen] Pessimize aliasing for union members (and may-alias) objects

kparzysz updated this revision to Diff 100142. kparzysz added a comment. Pass char TBAA directly to DecorateInstructionWithTBAA and pass true for ConvertTypeToTag in such cases. Repository: rL LLVM https://reviews.llvm.org/D33328 Files: lib/CodeGen/CGExpr.cpp test/CodeGen/union-tbaa1.c

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12449 // function declaration is going to be treated as an error. - if (Diags.getDiagnosticLevel(diag_id, Loc) >= DiagnosticsEngine::Error) { + if (!getLangOpts().OpenCL && + Diags.getDiagnosticLevel(dia

[PATCH] D33304: [WIP][clang-tidy] Add a new module Android and a new check for file descriptors.

Eugene.Zelenko added a comment. It's also necessary to mention new checks group in docs/clang-tidy/index.rst. Repository: rL LLVM https://reviews.llvm.org/D33304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r303789 - Address follow-up feedback for r303712

Author: akirtzidis Date: Wed May 24 13:35:01 2017 New Revision: 303789 URL: http://llvm.org/viewvc/llvm-project?rev=303789&view=rev Log: Address follow-up feedback for r303712 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/

[PATCH] D33328: [CodeGen] Pessimize aliasing for union members (and may-alias) objects

rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1436 +if (BaseInfo.getMayAlias()) + TBAAInfo = CGM.getTBAAInfo(getContext().CharTy); llvm::MDNode *TBAAPath = CGM.getTBAAStructTagInfo(TBAABaseType, TBAAInfo, kparzysz wrote: > rjmcc

r303786 - Fix one test case faiulre in commit 303766.

Author: jtony Date: Wed May 24 13:12:11 2017 New Revision: 303786 URL: http://llvm.org/viewvc/llvm-project?rev=303786&view=rev Log: Fix one test case faiulre in commit 303766. It is clean when I build boostrap and run make checkall on my machine, I guess it could be I only build bootstrap with as

Re: r303630 - Allow to use vfs::FileSystem for file accesses inside ASTUnit.

On Wed, May 24, 2017 at 12:18 AM, Ilya Biryukov wrote: > We test it in clangd (https://reviews.llvm.org/D33416). > Logically, it's a single change, split into two part: for cfe and > clang-tools-extra. I see, thanks! > > On Wed, May 24, 2017 at 1:48 AM, Bruno Cardoso Lopes > wrote: >> >> Any s

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

On Wed, May 24, 2017 at 1:37 PM, Argyrios Kyrtzidis wrote: > > On May 24, 2017, at 10:12 AM, Aaron Ballman wrote: > > On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis > wrote: > > > On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: > > On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via

[PATCH] D33507: [coroutines] Add support for coroutines with non-scalar parameters

GorNishanov created this revision. Simple types like int are handled by LLVM Coroutines just fine. But for non-scalar parameters we need to create copies of those parameters in the coroutine frame and make all uses of those parameters to refer to parameter copies. https://reviews.llvm.org/D335

[PATCH] D33448: [CodeGen] Add thumb-mode to function target-features for arm/thumb triples.

echristo added a comment. In https://reviews.llvm.org/D33448#763411, @fhahn wrote: > In https://reviews.llvm.org/D33448#762410, @echristo wrote: > > > I probably would have added this as a feature in ARMTargetInfo similar to > > CRC/soft-float/etc. > > > > Thoughts? > > > Do you mean ARMTargetMa

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

jroelofs marked 2 inline comments as done. jroelofs added inline comments. Comment at: lib/Driver/ToolChains/BareMetal.cpp:110 + SmallString<128> Dir(SysRoot); + llvm::sys::path::append(Dir, "include", "c++", "v1"); + return Dir.str(); compnerd wrote: > Is thi

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

mpark added a comment. Yes, you're right that fine-grained SMF triviality is implemented but LWG 2904 is not yet. I would love it if you can integrate the currently `libcxx` tests into `std` tests! Thank you :) https://reviews.llvm.org/D32671 ___

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

jroelofs updated this revision to Diff 100131. jroelofs added a comment. implement feedback https://reviews.llvm.org/D33259 Files: cmake/caches/BaremetalARM.cmake lib/Driver/CMakeLists.txt lib/Driver/Driver.cpp lib/Driver/ToolChains/BareMetal.cpp lib/Driver/ToolChains/BareMetal.h li

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

> On May 24, 2017, at 10:12 AM, Aaron Ballman wrote: > > On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis > wrote: >> >>> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: >>> >>> On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits >>> wrote: >>>

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

aaron.ballman added inline comments. Comment at: clang-tidy/misc/DefaultNumericsCheck.cpp:37 +void DefaultNumericsCheck::check(const MatchFinder::MatchResult &Result) { + + const auto *MatchedDecl = Result.Nodes.getNodeAs("call"); Can remove the spurious newline

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). https://reviews.llvm.org/D33497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis wrote: > >> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: >> >> On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits >> wrote: >>> Author: akirtzidis >>> Date: Tue May 23 19:46:27 2017 >>> New Revision: 303712 >>> >>> URL: ht

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: > > On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits > wrote: >> Author: akirtzidis >> Date: Tue May 23 19:46:27 2017 >> New Revision: 303712 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=303712&view=rev >> Log: >> Enh

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

spatel added subscribers: scanon, andrew.w.kaylor. spatel added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7932 break; case X86::BI__builtin_ia32_cmppd256: ID = Intrinsic::x86_avx_cmp_pd_256; dtemirbulatov wrote: > spatel wrote: > >

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim updated this revision to Diff 100111. belickim added a comment. I implemented changes suggested by Joerg. In previous version there was also an additional macro with CPU name that I removed. It was not documented anywhere and is not even used by GCC. So there seems to be no prior usage

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

CaseyCarter added a comment. In https://reviews.llvm.org/D32671#762840, @mpark wrote: > @CaseyCarter: Do these changes pass with the current version? > Also, have you seen the tests in > `test/libcxx/utilities/variant/variant.variant`? > If yes, do those tests and the ones in this diff overlap

r303768 - [OPENMP] Allow value of thread local variables in target regions.

Author: abataev Date: Wed May 24 11:00:02 2017 New Revision: 303768 URL: http://llvm.org/viewvc/llvm-project?rev=303768&view=rev Log: [OPENMP] Allow value of thread local variables in target regions. If the variable is marked as TLS variable and target device does not support TLS, the error is em

[PATCH] D33448: [CodeGen] Add thumb-mode to function target-features for arm/thumb triples.

fhahn added a comment. In https://reviews.llvm.org/D33448#762410, @echristo wrote: > I probably would have added this as a feature in ARMTargetInfo similar to > CRC/soft-float/etc. > > Thoughts? Do you mean ARMTargetMachine::getSubtargetImpl (https://github.com/llvm-mirror/llvm/blob/master/li

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits wrote: > Author: akirtzidis > Date: Tue May 23 19:46:27 2017 > New Revision: 303712 > > URL: http://llvm.org/viewvc/llvm-project?rev=303712&view=rev > Log: > Enhance the 'diagnose_if' attribute so that we can apply it for ObjC met

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

lebedev.ri added a comment. In https://reviews.llvm.org/D33497#763376, @brycel wrote: > In https://reviews.llvm.org/D33497#763307, @lebedev.ri wrote: > > > 1. What about `__PRETTY_FUNCTION__` ? > > > I think `__PRETTY_FUNCTION__` inside a lambda is useful enough not to warn > about. Then that

r303766 - [PowerPC] Implement vec_xxsldwi builtin.

Author: jtony Date: Wed May 24 10:54:13 2017 New Revision: 303766 URL: http://llvm.org/viewvc/llvm-project?rev=303766&view=rev Log: [PowerPC] Implement vec_xxsldwi builtin. The vec_xxsldwi builtin is missing from altivec.h. This has been requested by developers working on libvpx for VP9 support f

[PATCH] D33499: [PPC] First approximation of PPC32/Darwin ABI info

kparzysz updated this revision to Diff 100105. kparzysz added a comment. Add implementation of EmitVAArg and explicitly call emitVoidPtrVAArg in it. Repository: rL LLVM https://reviews.llvm.org/D33499 Files: lib/CodeGen/TargetInfo.cpp Index: lib/CodeGen/TargetInfo.cpp ===

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

brycel added a comment. In https://reviews.llvm.org/D33497#763307, @lebedev.ri wrote: > 1. What about `__PRETTY_FUNCTION__` ? `__PRETTY_FUNCTION__` is a little more useful, it at least tells you which function the lambda is defined in: #include int main() { auto f = [] { pri

[PATCH] D33498: [coroutines] Make generic lambda coroutines work

This revision was automatically updated to reflect the committed changes. Closed by commit rL303764: [coroutines] Make generic lambda coroutines work (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D33498?vs=100097&id=100102#toc Repository: rL LLVM https://revie

r303764 - [coroutines] Make generic lambda coroutines work

Author: gornishanov Date: Wed May 24 10:44:57 2017 New Revision: 303764 URL: http://llvm.org/viewvc/llvm-project?rev=303764&view=rev Log: [coroutines] Make generic lambda coroutines work Summary: 1. Coroutine cannot be constexpr (added a check in SemaLambda.cpp not to mark coroutine as constexpr

[PATCH] D33499: [PPC] First approximation of PPC32/Darwin ABI info

kparzysz created this revision. Use the default implementation of EmitVAArg instead of the SVR4 one. This is meant to address PR33108. This is really just a scaffold. I don't know what exactly needs to be implemented for Darwin. The motivating testcase: void foo() { __builtin_va_list

[PATCH] D33498: [coroutines] Make generic lambda coroutines work

GorNishanov created this revision. Herald added a subscriber: EricWF. 1. Coroutine cannot be constexpr (added a check in SemaLambda.cpp not to mark coroutine as constexpr) 2. TransformCoroutineBodyStmt should transform ResultDecl and ReturnStmt https://reviews.llvm.org/D33498 Files: lib/Sema

[PATCH] D33498: [coroutines] Make generic lambda coroutines work

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz updated this revision to Diff 100095. Typz added a comment. add new value to AlignOperands to support this mode. fix some corner cases. https://reviews.llvm.org/D32478 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/For

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

lebedev.ri added a comment. 1. What about `__PRETTY_FUNCTION__` ? 2. Consider following generic error handling macro: (ThrowException is some template function) #undef STR #define STR(a) XSTR(a) #define ThrowExceptionHelper(CLASS, fmt, ...) ThrowException(__FILE__ ":" STR(__LINE__) ":

[PATCH] D33450: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL303761: Warn about uses of `@available` that can't suppress the (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D33450?vs=99948&id=100094#toc Repository: rL LLVM https://re

r303761 - Warn about uses of `@available` that can't suppress the

Author: arphaman Date: Wed May 24 10:15:29 2017 New Revision: 303761 URL: http://llvm.org/viewvc/llvm-project?rev=303761&view=rev Log: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings rdar://32306520 Differential Revision: https://reviews.llvm.org/D33450

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

This revision was automatically updated to reflect the committed changes. jtony marked 2 inline comments as done. Closed by commit rL303760: [PowerPC] Implement vec_xxpermdi builtin. (authored by jtony). Changed prior to commit: https://reviews.llvm.org/D33053?vs=99966&id=100093#toc Repository

r303760 - [PowerPC] Implement vec_xxpermdi builtin.

Author: jtony Date: Wed May 24 10:13:32 2017 New Revision: 303760 URL: http://llvm.org/viewvc/llvm-project?rev=303760&view=rev Log: [PowerPC] Implement vec_xxpermdi builtin. The vec_xxpermdi builtin is missing from altivec.h. This has been requested by developers working on libvpx for VP9 support

  1   2   >