[libcxx] r303966 - Workaround debug info bug in Clangs coroutine implementation

Author: ericwf Date: Thu May 25 23:09:38 2017 New Revision: 303966 URL: http://llvm.org/viewvc/llvm-project?rev=303966=rev Log: Workaround debug info bug in Clangs coroutine implementation Modified:

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF updated this revision to Diff 100361. EricWF added a comment. - Fix whitespace in `__config`. @compnerd Any final thoughts? https://reviews.llvm.org/D33080 Files: include/__bit_reference include/__config include/__hash_table include/__mutex_base include/__split_buffer

[PATCH] D33082: Fix Libc++ build with MinGW64

EricWF updated this revision to Diff 100358. EricWF added a comment. - remove `asprintf` declaration and definition entirely. It's not used anywhere within libc++. https://reviews.llvm.org/D33082 Files: include/__config include/__locale include/locale include/stdio.h

[PATCH] D33082: Fix Libc++ build with MinGW64

EricWF added a comment. In https://reviews.llvm.org/D33082#765282, @bcraig wrote: > I think that we generally shouldn't be giving functions names that are > already claimed elsewhere (like mbsnrtowcs and wcsnrtombs). It is my opinion > that these should always be qualified as __libcpp_*

[libcxx] r303963 - Get working in C++03.

Author: ericwf Date: Thu May 25 22:02:54 2017 New Revision: 303963 URL: http://llvm.org/viewvc/llvm-project?rev=303963=rev Log: Get working in C++03. Clang supports coroutines in all dialects; Therefore libc++ should too, otherwise the Clang extension is unusable. I'm not convinced extending

r303962 - [docs] Point coroutine link to an actual document

Author: gbiv Date: Thu May 25 21:56:51 2017 New Revision: 303962 URL: http://llvm.org/viewvc/llvm-project?rev=303962=rev Log: [docs] Point coroutine link to an actual document Unsure if there's a better document, but what we had before led to a 404. :) Modified:

[PATCH] D33568: Fix crash when evaluating constant expressions involving nullptr

t.p.northover closed this revision. t.p.northover added a comment. Thanks Richard. I've committed this as r303957. https://reviews.llvm.org/D33568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r303957 - Create valid LValue to represent null pointers in constant exprs

Author: tnorthover Date: Thu May 25 21:16:00 2017 New Revision: 303957 URL: http://llvm.org/viewvc/llvm-project?rev=303957=rev Log: Create valid LValue to represent null pointers in constant exprs We were leaving the SubobjectDesignator in a surprising situation, where it was allegedly valid but

[libcxx] r303956 - Guard against older Clang versions.

Author: ericwf Date: Thu May 25 20:52:59 2017 New Revision: 303956 URL: http://llvm.org/viewvc/llvm-project?rev=303956=rev Log: Guard against older Clang versions. Clang started providing -fcoroutines and defining __cpp_coroutines way before it implemented the __builtin_coro_foo functions. This

[PATCH] D32520: Support __fp16 vectors

ahatanak updated this revision to Diff 100354. ahatanak added a comment. Rebase. https://reviews.llvm.org/D32520 Files: include/clang/Sema/Sema.h lib/CodeGen/CGExprScalar.cpp lib/Sema/SemaExpr.cpp test/CodeGen/fp16vec-ops.c test/Sema/fp16vec-sema.c Index: test/Sema/fp16vec-sema.c

[PATCH] D33082: Fix Libc++ build with MinGW64

bcraig added a comment. > Are you suggesting that libc++ should stop declaring/defining these > functions, at least publically? I think that we generally shouldn't be giving functions names that are already claimed elsewhere (like mbsnrtowcs and wcsnrtombs). It is my opinion that these

[libcxx] r303953 - Remove incorrect #ifdef guards around variant tests.

Author: ericwf Date: Thu May 25 20:27:08 2017 New Revision: 303953 URL: http://llvm.org/viewvc/llvm-project?rev=303953=rev Log: Remove incorrect #ifdef guards around variant tests. The tests were previously guarded by #if defined(_LIBCPP_VER) || defined(_MSVC_STL_VER), which is both incorrect

[PATCH] D33178: Remove requirement for libunwind sources.

Shiz added a comment. @EricWF: Thanks for reviewing! Is there anything else I need to do at this point or will it be committed automatically? Repository: rL LLVM https://reviews.llvm.org/D33178 ___ cfe-commits mailing list

[libcxx] r303951 - [test] Fix breakage from r303947 =(

Author: caseycarter Date: Thu May 25 20:00:56 2017 New Revision: 303951 URL: http://llvm.org/viewvc/llvm-project?rev=303951=rev Log: [test] Fix breakage from r303947 =( Modified:

[PATCH] D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. One minor nit and LGTM. Thanks! -eric Comment at: lib/Basic/Targets.cpp:5353 +// enable or disable thumb-mode per function +if (isThumb())

[libcxx] r303947 - [test] make_shared<T()>(...) is, uh, libc++-specific

Author: caseycarter Date: Thu May 25 19:37:33 2017 New Revision: 303947 URL: http://llvm.org/viewvc/llvm-project?rev=303947=rev Log: [test] make_shared(...) is, uh, libc++-specific Modified:

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

EricWF added a comment. In https://reviews.llvm.org/D33538#765225, @rsmith wrote: > In https://reviews.llvm.org/D33538#765146, @EricWF wrote: > > > In https://reviews.llvm.org/D33538#765045, @rsmith wrote: > > > > > Do we need to conditionalize this part of libc++? Nothing in the > > > header

Re: [clang-tools-extra] r303884 - [Documentation] Mention hicpp check group in Clang-tidy main document.

Hi, Alexander! On Thu, May 25, 2017 at 5:16 PM, Alexander Kornienko wrote: > > > On 25 May 2017 19:22, "Eugene Zelenko via cfe-commits" > wrote: > > Author: eugenezelenko > Date: Thu May 25 12:22:29 2017 > New Revision: 303884 > > URL:

Re: [clang-tools-extra] r303884 - [Documentation] Mention hicpp check group in Clang-tidy main document.

On 25 May 2017 19:22, "Eugene Zelenko via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: eugenezelenko Date: Thu May 25 12:22:29 2017 New Revision: 303884 URL: http://llvm.org/viewvc/llvm-project?rev=303884=rev Log: [Documentation] Mention hicpp check group in Clang-tidy main

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

rsmith added a comment. In https://reviews.llvm.org/D33538#765146, @EricWF wrote: > In https://reviews.llvm.org/D33538#765045, @rsmith wrote: > > > Do we need to conditionalize this part of libc++? Nothing in the > > header appears to need compiler support. > > > That's correct. I was mistaken

r303945 - Factor resolving of header directives -> files out of module map parser.

Author: rsmith Date: Thu May 25 19:01:53 2017 New Revision: 303945 URL: http://llvm.org/viewvc/llvm-project?rev=303945=rev Log: Factor resolving of header directives -> files out of module map parser. Modified: cfe/trunk/include/clang/Lex/ModuleMap.h cfe/trunk/lib/Lex/ModuleMap.cpp

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

EricWF added a comment. Also see r303936, which re-adds to the module map and fixes the bug. https://reviews.llvm.org/D33538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33082: Fix Libc++ build with MinGW64

martell added a comment. > ! In https://reviews.llvm.org/D33082#764617, @EricWF wrote: > Defining `_GNU_SOURCE` during the library build isn't enough, it's also has > to be defined when people are using the headers, > and in that case we must depend on the compiler to pre-define it. Is it >

[libcxx] r303936 - Re-add to the module map.

Author: ericwf Date: Thu May 25 18:39:29 2017 New Revision: 303936 URL: http://llvm.org/viewvc/llvm-project?rev=303936=rev Log: Re-add to the module map. The original issues were caused because didn't correctly #ifdef out enough of the header, which caused incomplete types to be used. This

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Actually, looking through the comments, it appears that everyone (eventually) agreed with the approach in the patch. I agree too. LGTM. Mehdi, are you able to rebase and commit, or

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

EricWF added a comment. In https://reviews.llvm.org/D33538#765045, @rsmith wrote: > Do we need to conditionalize this part of libc++? Nothing in the > header appears to need compiler support. That's correct. I was mistaken as to why this was needed. I mistook a bug in libc++ for the reason

r303934 - "*" => "+" to avoid matching on empty string.

Author: rtrieu Date: Thu May 25 18:25:36 2017 New Revision: 303934 URL: http://llvm.org/viewvc/llvm-project?rev=303934=rev Log: "*" => "+" to avoid matching on empty string. Modified: cfe/trunk/test/Driver/baremetal.cpp Modified: cfe/trunk/test/Driver/baremetal.cpp URL:

[PATCH] D33568: Fix crash when evaluating constant expressions involving nullptr

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D33568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D33538#765062, @rsmith wrote: > In https://reviews.llvm.org/D33538#765045, @rsmith wrote: > > > Do we need to conditionalize this part of libc++? Nothing in the >

[PATCH] D33568: Fix crash when evaluating constant expressions involving nullptr

t.p.northover updated this revision to Diff 100321. t.p.northover added a comment. Sounds very reasonable to me. I've uploaded a new diff. https://reviews.llvm.org/D33568 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/null-cast.cpp Index: clang/test/SemaCXX/null-cast.cpp

r303932 - Make test/Driver/baremetal.cpp work when output directory isn't named 'bin'.

Author: rtrieu Date: Thu May 25 18:03:08 2017 New Revision: 303932 URL: http://llvm.org/viewvc/llvm-project?rev=303932=rev Log: Make test/Driver/baremetal.cpp work when output directory isn't named 'bin'. Modified: cfe/trunk/test/Driver/baremetal.cpp Modified:

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

rsmith added a comment. In https://reviews.llvm.org/D33538#765045, @rsmith wrote: > Do we need to conditionalize this part of libc++? Nothing in the > header appears to need compiler support. Oh wait, I see what's going on. You're not testing for whether coroutines is enabled, you're

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

george.karpenkov added a comment. @vsk Looks reasonable to me, although I would say such a change should probably require more tests. However, I am not a C++ expert, and I am still not overly familiar with a codebase, so I'm not sure whether I should be a single reviewer.

[PATCH] D33538: [coroutines] Support "coroutines" feature in module map requires clause

rsmith added a comment. Do we need to conditionalize this part of libc++? Nothing in the header appears to need compiler support. https://reviews.llvm.org/D33538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r303930 - Switch from using a DiagnosticTrap and a note for "while defining a special

Author: rsmith Date: Thu May 25 17:47:05 2017 New Revision: 303930 URL: http://llvm.org/viewvc/llvm-project?rev=303930=rev Log: Switch from using a DiagnosticTrap and a note for "while defining a special member function" context notes to registering an entry on the context stack. Also reorder

[libcxx] r303929 - Correct typo: LIBCXXABI_BUILTINS_LIBRARY -> LIBCXX_BUILTINS_LIBRARY

Author: ericwf Date: Thu May 25 17:43:42 2017 New Revision: 303929 URL: http://llvm.org/viewvc/llvm-project?rev=303929=rev Log: Correct typo: LIBCXXABI_BUILTINS_LIBRARY -> LIBCXX_BUILTINS_LIBRARY Modified: libcxx/trunk/cmake/config-ix.cmake Modified: libcxx/trunk/cmake/config-ix.cmake URL:

[libcxx] r303928 - libcxx: fix bootstrapping for mingw-w64

Author: martell Date: Thu May 25 17:37:15 2017 New Revision: 303928 URL: http://llvm.org/viewvc/llvm-project?rev=303928=rev Log: libcxx: fix bootstrapping for mingw-w64 Differential Revision: https://reviews.llvm.org/D33388 Modified: libcxx/trunk/cmake/config-ix.cmake

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli added a comment. @jroelofs we are not building builtins currently but we are planning to do so. I just added some basic configurations for builtins. https://reviews.llvm.org/D33561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli updated this revision to Diff 100308. aoli added a comment. Add builtin configurations. https://reviews.llvm.org/D33561 Files: cmake/caches/Android-stage2.cmake cmake/caches/Android.cmake Index: cmake/caches/Android.cmake

Re: r303873 - Don't defer to the GCC driver for linking arm-baremetal

On 5/25/17 2:41 PM, Hans Wennborg wrote: The test was failing on Windows; r303910 for that. Oh yuk.. thanks for fixing that. Jon On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits wrote: On 5/25/17 11:39 AM, Galina Kistanova wrote: Hello

[PATCH] D33568: Fix crash when evaluating constant expressions involving nullptr

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5498-5500 Result.set((Expr*)nullptr, 0, false, true, Offset); +Result.getLValueDesignator() = +SubobjectDesignator(E->getType()->getPointeeType()); This is the only caller

[PATCH] D33568: Fix crash when evaluating constant expressions involving nullptr

t.p.northover created this revision. Herald added a subscriber: mcrosier. For the simple casts in the test, we were crashing because the ZeroInitialization function created an LValue with an unexpected SubobjectDesignator: it was valid but didn't actually refer to a valid MostDerivedType.

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

MatzeB added a comment. FWIW, I think this makes sense. Moving O0 and optnone get closer seems sensible. Even though -O3 with an optnone function indeed gives you different results today. We are basically maintaining two things for the same "do not optimize" goal. This obviously won't make O0

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

alexshap added inline comments. Comment at: clang-tidy/misc/DefaultNumericsCheck.h:20 +/// This check flags usages of ``std::numeric_limits::{min,max}()`` for +/// unspecialized types. It is dangerous because it returns T(), which might is +/// rarely minimum or maximum for this

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

aaron.ballman added a comment. Once you fix the typo in the check, can you run it over some large C++ code bases to see if it finds any results? Comment at: clang-tidy/misc/DefaultNumericsCheck.cpp:30 + ofClass(classTemplateSpecializationDecl( +

[PATCH] D33537: [clang-tidy] Exception Escape Checker

Prazek added a comment. How is that compared to https://reviews.llvm.org/D19201 and the clang patch mentioned in this patch? Repository: rL LLVM https://reviews.llvm.org/D33537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r303873 - Don't defer to the GCC driver for linking arm-baremetal

The test was failing on Windows; r303910 for that. On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits wrote: > > > On 5/25/17 11:39 AM, Galina Kistanova wrote: > > Hello Jonathan, > > This commit broke one of our builders: > >

r303910 - Make test/Driver/baremetal.cpp pass on Windows

Author: hans Date: Thu May 25 15:39:52 2017 New Revision: 303910 URL: http://llvm.org/viewvc/llvm-project?rev=303910=rev Log: Make test/Driver/baremetal.cpp pass on Windows Modified: cfe/trunk/test/Driver/baremetal.cpp Modified: cfe/trunk/test/Driver/baremetal.cpp URL:

[clang-tools-extra] r303909 - Earlier revert introduced an extra space, remove it.

Author: erichkeane Date: Thu May 25 15:29:17 2017 New Revision: 303909 URL: http://llvm.org/viewvc/llvm-project?rev=303909=rev Log: Earlier revert introduced an extra space, remove it. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp Modified:

r303908 - Revert "[AMDGPU] add __builtin_amdgcn_s_getpc"

Author: rnk Date: Thu May 25 15:28:26 2017 New Revision: 303908 URL: http://llvm.org/viewvc/llvm-project?rev=303908=rev Log: Revert "[AMDGPU] add __builtin_amdgcn_s_getpc" This reverts commit r303861, the LLVM intrinsic was reverted. Modified:

[PATCH] D33563: Track whether a unary operation can overflow

aaron.ballman created this revision. We do not explicitly model integer promotions on unary operators even though those promotions happen in practice. This patch tracks the most important piece of information about the promotion on the AST node: whether the operator can overflow or not. It

Re: r303798 - For Microsoft compatibility, set fno_operator_names

I agree with Nico in retrospect. Setting -fno-operator-names is too big a hammer. Instead we should add some MSVCCompat hacks to pretend we saw an identifier token instead of a keyword token when these keywords are used as declarators. On Thu, May 25, 2017 at 10:14 AM, Nico Weber

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

pcc added inline comments. Comment at: clang/test/CodeGen/thin_link_bitcode.c:5 +// RUN: %clang_cc1 -o %t -flto=thin -fexperimental-new-pass-manager -fthin-link-bitcode=%t.newpm -triple x86_64-unknown-linux-gnu -emit-llvm-bc %s +// RUN: llvm-bcanalyzer -dump %t.newpm |

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

jroelofs added a comment. what about the builtins? https://reviews.llvm.org/D33561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli updated this revision to Diff 100282. aoli added a comment. Fix wrong flags. https://reviews.llvm.org/D33561 Files: cmake/caches/Android-stage2.cmake cmake/caches/Android.cmake Index: cmake/caches/Android.cmake === ---

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli created this revision. Herald added a subscriber: mgorny. Thoes files are used to build Android toolchain. https://reviews.llvm.org/D32816 makes it possible to build runtimes for targets. https://reviews.llvm.org/D33561 Files: cmake/caches/Android-stage2.cmake

[PATCH] D33525: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen added a comment. In https://reviews.llvm.org/D33525#764251, @chandlerc wrote: > (focusing on the LLVM side of this review for now) > > Can you add an LLVM-based test? Can you add this to > `lib/Passes/PassRegistry.def`? I see that not all passes are registered (BitcodeWriterPass). Is

[libcxx] r303900 - Update more coroutine_handle signatures to reflect N4663.

Author: ericwf Date: Thu May 25 14:04:55 2017 New Revision: 303900 URL: http://llvm.org/viewvc/llvm-project?rev=303900=rev Log: Update more coroutine_handle signatures to reflect N4663. Thanks to Casey Carter for pointing out the out-of-date tests and implementation. Modified:

[PATCH] D33340: [libcxx] [test] Add string nullptr asserts to erase functions.

BillyONeal closed this revision. BillyONeal added a comment. In https://reviews.llvm.org/D33340#764206, @EricWF wrote: > Sorry for the delay reviewing such a simple change. No problem! Their simplicity also means no likely merge conflicts :) In https://reviews.llvm.org/D33340#764213, @EricWF

[libcxx] r303899 - Add asserts that the nullptr is maintained in string erase operations.

Author: bion Date: Thu May 25 14:01:14 2017 New Revision: 303899 URL: http://llvm.org/viewvc/llvm-project?rev=303899=rev Log: Add asserts that the nullptr is maintained in string erase operations. Modified:

Re: r303873 - Don't defer to the GCC driver for linking arm-baremetal

On 5/25/17 11:39 AM, Galina Kistanova wrote: Hello Jonathan, This commit broke one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2608/steps/build-unified-tree/logs/stdio Please have a look at this? r303898 should take care of that. Jon

r303898 - Appease more buildbots about r303873

Author: jroelofs Date: Thu May 25 13:55:22 2017 New Revision: 303898 URL: http://llvm.org/viewvc/llvm-project?rev=303898=rev Log: Appease more buildbots about r303873 Modified: cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp Modified: cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp URL:

[libcxx] r303895 - Update coroutine_handle::promise to reflect N4663.

Author: ericwf Date: Thu May 25 13:52:34 2017 New Revision: 303895 URL: http://llvm.org/viewvc/llvm-project?rev=303895=rev Log: Update coroutine_handle::promise to reflect N4663. This patch updates the promise() member to match the current spec. Specifically it removes the non-const overload and

[PATCH] D33550: Make __wrap_iter constexpr

EricWF added a comment. @mclow.lists Could you update this diff with more context? https://reviews.llvm.org/D33550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF updated this revision to Diff 100269. EricWF added a comment. - Remove the external include guards for `__undef_macros` as requested by @compnerd. I couldn't come up with a easy test case that showed any notable difference having the external guards. https://reviews.llvm.org/D33080

[PATCH] D33290: [libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug

This revision was automatically updated to reflect the committed changes. CaseyCarter marked an inline comment as done. Closed by commit rL303889: [test] Remove workaround for C1XX conversion-to-nullptr bug (authored by CaseyCarter). Changed prior to commit:

[PATCH] D33214: [libcxx] [test] Workaround C1XX bug in uses_allocator_types.hpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL303888: [test] Workaround C1XX bug in uses_allocator_types.hpp (authored by CaseyCarter). Changed prior to commit: https://reviews.llvm.org/D33214?vs=99086=100264#toc Repository: rL LLVM

[libcxx] r303889 - [test] Remove workaround for C1XX conversion-to-nullptr bug

Author: caseycarter Date: Thu May 25 12:42:21 2017 New Revision: 303889 URL: http://llvm.org/viewvc/llvm-project?rev=303889=rev Log: [test] Remove workaround for C1XX conversion-to-nullptr bug VSO#391542 "Types can't be convertible to nullptr_t" Also put internal bug numbers on the workarounds

[libcxx] r303888 - [test] Workaround C1XX bug in uses_allocator_types.hpp

Author: caseycarter Date: Thu May 25 12:42:17 2017 New Revision: 303888 URL: http://llvm.org/viewvc/llvm-project?rev=303888=rev Log: [test] Workaround C1XX bug in uses_allocator_types.hpp VSO#109062 "Explicit template argument specification with empty template parameter pack expansion does not

Re: r303873 - Don't defer to the GCC driver for linking arm-baremetal

Hello Jonathan, This commit broke one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2608/steps/build-unified-tree/logs/stdio Please have a look at this? Thanks Galina On Thu, May 25, 2017 at 8:42 AM, Jonathan Roelofs via cfe-commits <

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF added a comment. In https://reviews.llvm.org/D33080#754442, @compnerd wrote: > I think that we should sink the `min`/`max` checks into `__undef_macros`. I > don't like the idea of littering that check everywhere. I would much rather litter at the cost of the implementation than

[PATCH] D33082: Fix Libc++ build with MinGW64

EricWF updated this revision to Diff 100263. EricWF added a comment. Add `_LIBCPP_MSVCRT_LIKE` and use it to replace `_LIBCPP_WIN32API` where appropriate. https://reviews.llvm.org/D33082 Files: include/__config include/__locale include/locale include/stdio.h

[clang-tools-extra] r303884 - [Documentation] Mention hicpp check group in Clang-tidy main document.

Author: eugenezelenko Date: Thu May 25 12:22:29 2017 New Revision: 303884 URL: http://llvm.org/viewvc/llvm-project?rev=303884=rev Log: [Documentation] Mention hicpp check group in Clang-tidy main document. Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified:

[PATCH] D33082: Fix Libc++ build with MinGW64

EricWF marked 3 inline comments as done. EricWF added a comment. In https://reviews.llvm.org/D33082#760516, @martell wrote: > I want to give some context here to dispel the confusion of what is and isn't > win32 api specific. > > First lets take `vasprintf` and `asprintf ` which are not

[PATCH] D33537: [clang-tidy] Exception Escape Checker

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/misc-exception-escape.rst:7 +Finds functions which should not throw exceptions: ++ Destructors ++ Copy constructors I

Re: r303798 - For Microsoft compatibility, set fno_operator_names

Among the goals of the clang-cl project are a) being able to parse MS system headers b) helper users to write standards-compliant C++ (in particular, if your code builds with clang-cl without warnings, it'd be good if it also built with regular clang then). The regular change plus header change

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

ilya-biryukov updated this revision to Diff 100262. ilya-biryukov added a comment. - Fixed file comment of ClangdTests.cpp https://reviews.llvm.org/D33416 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h

[PATCH] D33082: Fix Libc++ build with MinGW64

EricWF marked 6 inline comments as done. EricWF added inline comments. Comment at: include/__locale:370 static const mask blank = _ISblank; -#elif defined(_LIBCPP_MSVCRT) +#elif defined(_LIBCPP_WIN32API) typedef unsigned short mask; compnerd wrote: >

RE: r303798 - For Microsoft compatibility, set fno_operator_names

No problem, I definitely think it was the right choice. A change that contains all of what Melanie’s original patch did, plus the Header changes (plus the clang-tidy fixes that came out of this) would be acceptable? Also, I believe she’s working on the warning as well. We were discussing it,

RE: r303798 - For Microsoft compatibility, set fno_operator_names

Sometimes it’s possible to reason with the open source community, then they change their code and make modifications which accommodate the various compilers. E.g. we could ask chromium team if they could use the operator symbol instead of ‘and’. From: Nico Weber [mailto:tha...@google.com]

Re: r303798 - For Microsoft compatibility, set fno_operator_names

On Thu, May 25, 2017 at 12:18 PM, Keane, Erich wrote: > How does chromium compiler in CL? It seems that it would have a similar > problem here… > That's a good question! It looks like iso646.h is included, and in MSVC that contains something like `#define and &&`. But

RE: r303798 - For Microsoft compatibility, set fno_operator_names

Patch and Buildbot fixes all reverted as of –r303882. Sorry for the thrash. From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber Sent: Thursday, May 25, 2017 9:16 AM To: Blower, Melanie Cc: rnk ; Keane, Erich

r303882 - Revert MSVC CXXOperatorNames patch due to issues with Chromium

Author: erichkeane Date: Thu May 25 11:24:49 2017 New Revision: 303882 URL: http://llvm.org/viewvc/llvm-project?rev=303882=rev Log: Revert MSVC CXXOperatorNames patch due to issues with Chromium Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp

[clang-tools-extra] r303881 - Revert 303872/303877 since the patch that caused these issues

Author: erichkeane Date: Thu May 25 11:23:00 2017 New Revision: 303881 URL: http://llvm.org/viewvc/llvm-project?rev=303881=rev Log: Revert 303872/303877 since the patch that caused these issues is also being reverted. Modified:

r303880 - Relax testcase to appease buildbots

Author: jroelofs Date: Thu May 25 11:20:51 2017 New Revision: 303880 URL: http://llvm.org/viewvc/llvm-project?rev=303880=rev Log: Relax testcase to appease buildbots When lld isn't built, the tests as they were previously, were too picky about the path to the linker. Modified:

RE: r303798 - For Microsoft compatibility, set fno_operator_names

How does chromium compiler in CL? It seems that it would have a similar problem here… From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber Sent: Thursday, May 25, 2017 9:16 AM To: Blower, Melanie Cc: rnk ; Keane, Erich

RE: r303798 - For Microsoft compatibility, set fno_operator_names

In addition to this making clang-cl silently accept invalid code, it also breaks existing valid code, building chromium now fails. Let's revert and come up with something better asynchronously. FAILED: obj/third_party/WebKit/Source/core/dom/dom/CustomElementRegistry.obj

[libcxx] r303878 - Fix a test that was failing in C++11 mode introduced in r303874

Author: epilk Date: Thu May 25 11:16:17 2017 New Revision: 303878 URL: http://llvm.org/viewvc/llvm-project?rev=303878=rev Log: Fix a test that was failing in C++11 mode introduced in r303874 Modified:

[clang-tools-extra] r303877 - Clang-tidy doesn't understand -fno-ms-compatibility, so just removing 'not'

Author: erichkeane Date: Thu May 25 11:07:19 2017 New Revision: 303877 URL: http://llvm.org/viewvc/llvm-project?rev=303877=rev Log: Clang-tidy doesn't understand -fno-ms-compatibility, so just removing 'not' Modified:

[libcxx] r303876 - Mark LWG#2900 as complete - we already do this, and I checked the tests in a couple days ago (r303268 & r303824)

Author: marshall Date: Thu May 25 11:05:54 2017 New Revision: 303876 URL: http://llvm.org/viewvc/llvm-project?rev=303876=rev Log: Mark LWG#2900 as complete - we already do this, and I checked the tests in a couple days ago (r303268 & r303824) Modified: libcxx/trunk/www/cxx1z_status.html

[PATCH] D30837: [libcxx] Support for shared_ptr<T()>

This revision was automatically updated to reflect the committed changes. Closed by commit rL303874: Add support for shared_ptr (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D30837?vs=97313=100251#toc Repository: rL LLVM https://reviews.llvm.org/D30837 Files:

[libcxx] r303874 - Add support for shared_ptr

Author: epilk Date: Thu May 25 10:43:31 2017 New Revision: 303874 URL: http://llvm.org/viewvc/llvm-project?rev=303874=rev Log: Add support for shared_ptr Fixes PR27566. Differential revision: https://reviews.llvm.org/D30837 Added:

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

jroelofs closed this revision. jroelofs added a comment. r303873 https://reviews.llvm.org/D33259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r303873 - Don't defer to the GCC driver for linking arm-baremetal

Author: jroelofs Date: Thu May 25 10:42:13 2017 New Revision: 303873 URL: http://llvm.org/viewvc/llvm-project?rev=303873=rev Log: Don't defer to the GCC driver for linking arm-baremetal Also comes with a cmake cache for building the runtime bits: $ cmake \

[clang-tools-extra] r303872 - Disable MSVC-Compat mode for two tests that use C++Operator Names

Author: erichkeane Date: Thu May 25 10:39:24 2017 New Revision: 303872 URL: http://llvm.org/viewvc/llvm-project?rev=303872=rev Log: Disable MSVC-Compat mode for two tests that use C++Operator Names MSVC doesn't support C++ operator names (using 'or' instead of ||, 'not' instead of '!', etc), so

r303871 - Make git-clang-format python 3 compatible

Author: ericwf Date: Thu May 25 10:24:04 2017 New Revision: 303871 URL: http://llvm.org/viewvc/llvm-project?rev=303871=rev Log: Make git-clang-format python 3 compatible Summary: This patch attempts to make `git-clang-format` both python2 and python3 compatible. Currently it only works in

r303868 - [coroutines] Diagnose when promise types fail to declare either return_void or return_value.

Author: ericwf Date: Thu May 25 09:59:39 2017 New Revision: 303868 URL: http://llvm.org/viewvc/llvm-project?rev=303868=rev Log: [coroutines] Diagnose when promise types fail to declare either return_void or return_value. Summary: According to the PDTS it's perfectly legal to have a promise type

r303867 - [coroutines] Bump __cpp_coroutines version

Author: ericwf Date: Thu May 25 09:58:46 2017 New Revision: 303867 URL: http://llvm.org/viewvc/llvm-project?rev=303867=rev Log: [coroutines] Bump __cpp_coroutines version Summary: This patch is needed so that Libc++ can actually tess if Clang supports coroutines, instead of just paying lip

[PATCH] D33550: Make __wrap_iter constexpr

mclow.lists added inline comments. Comment at: include/iterator:1409 -private: +// private: #if _LIBCPP_DEBUG_LEVEL >= 2 This is testing debris - making the constructors public for testing. https://reviews.llvm.org/D33550

[PATCH] D33550: Make __wrap_iter constexpr

mclow.lists created this revision. `__wrap_iter` is an internal libc++ class that is used as an iterator type when (for some reason) we don't want to use raw pointers as an iterator. It is the iterator type for `vector` and `string` (but not `array` - not sure why). If we used pointers, all

  1   2   >