[PATCH] D33852: Enable __declspec(selectany) on linux

2017-06-03 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. > ! In https://reviews.llvm.org/D33852#772290, @davide wrote: > This assumption is not quite right. Also GCC, when targeting Linux, provides > a `-fms-extensions` flag. > There's a bunch of software out there that unfortunately has to target ELF > and build with

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-06-03 Thread Davide Italiano via Phabricator via cfe-commits
davide added a comment. In https://reviews.llvm.org/D33852#772230, @martell wrote: > @Prazek it was not disabled by mistake. > This was a MS extension and it appeared as though the test case should have > been for windows. > I updated it and made the extension available to windows only.

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-06-03 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. @Prazek it wasn't disabled by mistake. This was a MS extension and it appeared as though the test case should have been for windows. I updated it and made the extension available to windows only. (MSVC, Cygwin, Mingw etc) It didn't expect anyone would want a MS

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-06-03 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. It seems that this is separate issue - we don't generate comdat for MachO. Indeed we should warn on not supported declspec for macho. https://reviews.llvm.org/D33852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r304663 - Fixed warning: enum constant in boolean context.

2017-06-03 Thread Richard Smith via cfe-commits
Can we get a testcase for this bug? Seems like we can't have any coverage for the case where IsArmArch is supposed to be false. On 3 Jun 2017 9:47 am, "Galina Kistanova via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: gkistanova Date: Sat Jun 3 11:47:06 2017 New Revision: 304663

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

2017-06-03 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. This causes a test failure with non-standard CLANG_RESOURCE_DIR: Command Output (stderr): -- /var/tmp/portage/sys-devel/clang-/work/x/y/clang-/test/Driver/baremetal.cpp:8:22: error: expected string not found in input // CHECK-V6M-C-SAME: "-resource-dir"

[libcxxabi] r304664 - [libcxxabi] HandleLLVMOptions in out of tree build

2017-06-03 Thread Martell Malone via cfe-commits
Author: martell Date: Sat Jun 3 12:23:19 2017 New Revision: 304664 URL: http://llvm.org/viewvc/llvm-project?rev=304664=rev Log: [libcxxabi] HandleLLVMOptions in out of tree build Differential revision: https://reviews.llvm.org/D33753 Modified:

r304663 - Fixed warning: enum constant in boolean context.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 11:47:06 2017 New Revision: 304663 URL: http://llvm.org/viewvc/llvm-project?rev=304663=rev Log: Fixed warning: enum constant in boolean context. Modified: cfe/trunk/lib/Driver/ToolChains/Linux.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Linux.cpp URL:

r304662 - tests: silence -Wobjc-root-class warnings

2017-06-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 3 11:18:13 2017 New Revision: 304662 URL: http://llvm.org/viewvc/llvm-project?rev=304662=rev Log: tests: silence -Wobjc-root-class warnings Silence warnings about no ObjC class root for the types defined for the tests. Modified:

r304661 - CodeGen: fix section names for different file formats

2017-06-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 3 11:18:09 2017 New Revision: 304661 URL: http://llvm.org/viewvc/llvm-project?rev=304661=rev Log: CodeGen: fix section names for different file formats This changes the codegen to match the section names according to the ObjC rewriter as well as the runtime. The

[clang-tools-extra] r304657 - [clang-tidy] Make misc-static-assert accept assert(!"msg")

2017-06-03 Thread Florian Gross via cfe-commits
Author: fgross Date: Sat Jun 3 05:13:55 2017 New Revision: 304657 URL: http://llvm.org/viewvc/llvm-project?rev=304657=rev Log: [clang-tidy] Make misc-static-assert accept assert(!"msg") Added negated string literals to the set of IsAlwaysFalse expressions to avoid flagging of assert(!"msg").

[PATCH] D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg")

2017-06-03 Thread Florian Gross via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304657: [clang-tidy] Make misc-static-assert accept assert(!"msg") (authored by fgross). Changed prior to commit: https://reviews.llvm.org/D33827?vs=101197=101311#toc Repository: rL LLVM

r304653 - Added missing break.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:40:10 2017 New Revision: 304653 URL: http://llvm.org/viewvc/llvm-project?rev=304653=rev Log: Added missing break. Modified: cfe/trunk/lib/Basic/IdentifierTable.cpp Modified: cfe/trunk/lib/Basic/IdentifierTable.cpp URL:

r304652 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:38:22 2017 New Revision: 304652 URL: http://llvm.org/viewvc/llvm-project?rev=304652=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Basic/TargetInfo.cpp Modified:

r304651 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:35:06 2017 New Revision: 304651 URL: http://llvm.org/viewvc/llvm-project?rev=304651=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp

r304650 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:31:42 2017 New Revision: 304650 URL: http://llvm.org/viewvc/llvm-project?rev=304650=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp

r304649 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:30:46 2017 New Revision: 304649 URL: http://llvm.org/viewvc/llvm-project?rev=304649=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r304648 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:30:08 2017 New Revision: 304648 URL: http://llvm.org/viewvc/llvm-project?rev=304648=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Edit/RewriteObjCFoundationAPI.cpp Modified:

r304647 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:29:40 2017 New Revision: 304647 URL: http://llvm.org/viewvc/llvm-project?rev=304647=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp Modified:

r304646 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:29:16 2017 New Revision: 304646 URL: http://llvm.org/viewvc/llvm-project?rev=304646=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/Parser.cpp Modified:

r304645 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:27:16 2017 New Revision: 304645 URL: http://llvm.org/viewvc/llvm-project?rev=304645=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp

r304644 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:26:27 2017 New Revision: 304644 URL: http://llvm.org/viewvc/llvm-project?rev=304644=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

r304643 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:25:47 2017 New Revision: 304643 URL: http://llvm.org/viewvc/llvm-project?rev=304643=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Lex/Lexer.cpp Modified: cfe/trunk/lib/Lex/Lexer.cpp

r304642 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through + formatted. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:25:29 2017 New Revision: 304642 URL: http://llvm.org/viewvc/llvm-project?rev=304642=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through + formatted. NFC. Modified: cfe/trunk/lib/Lex/LiteralSupport.cpp Modified:

r304641 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:23:51 2017 New Revision: 304641 URL: http://llvm.org/viewvc/llvm-project?rev=304641=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Analysis/PrintfFormatString.cpp

r304640 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-03 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Sat Jun 3 01:23:19 2017 New Revision: 304640 URL: http://llvm.org/viewvc/llvm-project?rev=304640=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp