[PATCH] D30375: Function with unparsed body is a definition

sepavloff updated this revision to Diff 101993. sepavloff added a comment. Changed implementation https://reviews.llvm.org/D30375 Files: include/clang/AST/Decl.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D30375: Function with unparsed body is a definition

sepavloff added a comment. Thank you for explanation. Probably making new semantic action is an overkill. The intent was to postpone setting flag `WillHaveBody` as late as possible, to the moment when it becomes clear that the function indeed will have a body. Otherwise parsing of deleted

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

mclow.lists updated this revision to Diff 101989. mclow.lists added a comment. Turn the for loops into do-while loops, saving a comparison. https://reviews.llvm.org/D34038 Files: include/numeric test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_iter_iter_iter.pass.cpp

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

mclow.lists updated this revision to Diff 101988. mclow.lists added a comment. Added a `_VSTD::`, made some assertions `static_assert`, and addressed Bryce's concerns about doing an init when the input range is empty. https://reviews.llvm.org/D34038 Files: include/numeric

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

mclow.lists added a comment. > Should the non-parallel implementation of reduce static_assert or SFINAE away > when these requirements are not met? That may be desirable, but that's not what the standard says. There's nothing there about "shall not participate in overload resolution".

[clang-tools-extra] r305046 - [clangd] Update for ASTUnit API change.

Author: akirtzidis Date: Thu Jun 8 21:04:19 2017 New Revision: 305046 URL: http://llvm.org/viewvc/llvm-project?rev=305046=rev Log: [clangd] Update for ASTUnit API change. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL:

r305045 - Remove 'Filename' parameter from BeginSourceFileAction.

Author: rsmith Date: Thu Jun 8 20:36:10 2017 New Revision: 305045 URL: http://llvm.org/viewvc/llvm-project?rev=305045=rev Log: Remove 'Filename' parameter from BeginSourceFileAction. No-one was using this, and it's not meaningful in general -- FrontendActions can be run on inputs that don't

[PATCH] D34021: [coroutines] Fix co_await for range statement

EricWF added inline comments. Comment at: test/SemaCXX/coawait_range_for.cpp:133 + +struct ForLoopAwaiterCoawaitLookup { + struct promise_type { This test is incorrect WRT ADL lookup. https://reviews.llvm.org/D34021

r305044 - [libclang] Introduce a new parsing option 'CXTranslationUnit_SingleFileParse' that puts preprocessor in a mode for parsing a single file only.

Author: akirtzidis Date: Thu Jun 8 20:20:48 2017 New Revision: 305044 URL: http://llvm.org/viewvc/llvm-project?rev=305044=rev Log: [libclang] Introduce a new parsing option 'CXTranslationUnit_SingleFileParse' that puts preprocessor in a mode for parsing a single file only. This is useful for

r305039 - Represent debug information compression type fully

Author: compnerd Date: Thu Jun 8 19:40:30 2017 New Revision: 305039 URL: http://llvm.org/viewvc/llvm-project?rev=305039=rev Log: Represent debug information compression type fully This is tied with the LLVM side of the change to expose the debug information compression types to clang. We now

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

wash added a comment. This implementation works, but performs unnecessary operations. https://gist.github.com/brycelelbach/907ac3b8a74603cc189897ab789a65a9 The "next" result is calculated in each iteration; this means one unnecessary application of the binary op (the "next" result on the final

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

chh added a comment. Android source is suppressing misc-noexcept-move-constructor warnings because -fno-exceptions is used and Android does not like to add more exception specific code. It's not a big deal for Android to suppress this check one way or the other. I don't mind reverting it, just

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

wash added a comment. https://gist.github.com/brycelelbach/137f1e45b737d615134e228ec0c84f3a <- some crude tests I wrote based on slides/notes of mine. https://reviews.llvm.org/D34038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

rjmccall accepted this revision. rjmccall added inline comments. Comment at: include/clang/AST/Decl.h:901 +/// member functions. +unsigned ImplicitParamKind : 3; }; aaron.ballman wrote: > rjmccall wrote: > > ABataev wrote: > > > aaron.ballman wrote: >

Re: r305022 - [ASTMatchers] Add clang-query support for equals matcher

Yes, mea culpa :( I forgot to rebuild after doing the final revision of the patch (in which two new tests were added). The failing tests are temporary disabled in r305025 until a proper fix is developed. Kind regards, Peter On Thu, Jun 08, 2017 at 03:58:01PM -0700, Kostya Serebryany wrote: >

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

wash added inline comments. Comment at: include/numeric:182 +{ + _Tp __saved = __init; + for (; __first != __last; ++__first, (void) ++__result) { If `__first == __last`, this initialization is unnecessary; I'd refactor this so that we check for

r305026 - [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. Reapplying revisions 304630, 304631, 304632, 304673, see

Author: kcc Date: Thu Jun 8 17:58:19 2017 New Revision: 305026 URL: http://llvm.org/viewvc/llvm-project?rev=305026=rev Log: [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. Reapplying revisions 304630, 304631,

r305025 - [ASTMatchers] temporary disable tests with floating suffix

Author: lekensteyn Date: Thu Jun 8 17:58:12 2017 New Revision: 305025 URL: http://llvm.org/viewvc/llvm-project?rev=305025=rev Log: [ASTMatchers] temporary disable tests with floating suffix r305022 assumed that floatLiteral(equals(1.2)) would also match 1.2f and 1.2l, but apparently that is not

Re: r305022 - [ASTMatchers] Add clang-query support for equals matcher

The test seems to be failing: llvm/tools/clang/unittests/ASTMatchers/Dynamic/RegistryTest.cpp:533: Failure Value of: matches("double x = 1.2f;", DoubleStmt) Actual: false (Could not find match in "double x = 1.2f;") Expected: true On Thu, Jun 8, 2017 at 3:00 PM, Peter Wu via cfe-commits <

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. I think we need a test case like this for all of the `transform_*`s struct A {}; struct B {}; struct C {}; B unary_op(C); B unary_op(A) { assert(false); /* unary op applied to init value! */ } A binary_op(A, A); A binary_op(A, B); A binary_op(B, A); A

[PATCH] D34007: Implement inclusive_scan and transform_inclusive_scan

wash added a comment. Here's `partial_sum`: template inline _LIBCPP_INLINE_VISIBILITY _OutputIterator partial_sum(_InputIterator __first, _InputIterator __last, _OutputIterator __result, _BinaryOperation __binary_op) { if (__first != __last) {

[PATCH] D34007: Implement inclusive_scan and transform_inclusive_scan

wash added a comment. So, `inclusive_scan` should be equivalent to `partial_sum` for the non-parallel version. https://reviews.llvm.org/D34007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33976: [clang] Fix format specifiers fixits

mehdi_amini added a comment. In https://reviews.llvm.org/D33976#775918, @alexshap wrote: > @mehdi_amini , thanks, i see, regarding the "opposite issue" - probably an > example / test case would be helpful, that looks like a separate issue. > Thanks for adding @ahatanak and @arphaman, that

[PATCH] D34007: Implement inclusive_scan and transform_inclusive_scan

wash added a comment. Minor note: there's a mix of tabs and spaces in this diff. https://reviews.llvm.org/D34007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

I managed to link a hello world application, however the NetBSD-specific nits stand for production programs. RPATH is the first difference that matters. Unfortunately I'm swamped by other LLVM projects to join LLD.. research other differences and prepare patches myself. On 09.06.2017 00:11, Rui

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added inline comments. Comment at: test/clang-tidy/misc-noexcept-move-constructor.cpp:2 +// RUN: clang-tidy %s -checks="-*,misc-noexcept-move-constructor" -- -std=c++11 \ +// RUN: | FileCheck %s -check-prefix=CHECK-EXCEPTIONS \ +// RUN:

Re: [PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

On Thu, Jun 8, 2017 at 6:24 PM, Alexander Kornienko via Phabricator wrote: > alexfh added a comment. > > In https://reviews.llvm.org/D34002#776193, @chh wrote: > >> In https://reviews.llvm.org/D34002#775830, @alexfh wrote: >> >> > IIUC, when `vector` (for a class `T`

[clang-tools-extra] r305024 - [clang-tidy] Use -fexceptions explicitly in the tests that need exceptions.

Author: alexfh Date: Thu Jun 8 17:25:23 2017 New Revision: 305024 URL: http://llvm.org/viewvc/llvm-project?rev=305024=rev Log: [clang-tidy] Use -fexceptions explicitly in the tests that need exceptions. This should fix relevant buildbot breakages. Modified:

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added a comment. In https://reviews.llvm.org/D34002#776193, @chh wrote: > In https://reviews.llvm.org/D34002#775830, @alexfh wrote: > > > IIUC, when `vector` (for a class `T` that has both move and copy > > constructors) resizes, it will prefer move constructors, but only if > > they're

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

I don't remember the details, but I believe LLD-generated executables are fine with either Linux or on NetBSD On Thu, Jun 8, 2017 at 3:08 PM, Kamil Rytarowski wrote: > On 08.06.2017 22:39, Rui Ueyama wrote: > > On Wed, Jun 7, 2017 at 6:55 AM, Joerg Sonnenberger via Phabricator > >

Re: [clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

It looks like the buildbots have exceptions turned off by default, so the tests need to use `-fexceptions` explicitly. Testing a fix... On Thu, Jun 8, 2017 at 11:26 PM, Galina Kistanova wrote: > Hello Alexander, > > Couple of our builders do not like this commit: > >

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. For all the `transform_` variants, the spec allows the "inner" operation (the transformation)'s return type is not constrained. We should have a test for this. For example, consider the binary-unary `transform_reduce` implementation: template inline

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

On 08.06.2017 22:39, Rui Ueyama wrote: > On Wed, Jun 7, 2017 at 6:55 AM, Joerg Sonnenberger via Phabricator > > wrote: > > joerg added a comment. > > In https://reviews.llvm.org/D33726#774105 >

r305022 - [ASTMatchers] Add clang-query support for equals matcher

Author: lekensteyn Date: Thu Jun 8 17:00:58 2017 New Revision: 305022 URL: http://llvm.org/viewvc/llvm-project?rev=305022=rev Log: [ASTMatchers] Add clang-query support for equals matcher Summary: This allows the clang-query tool to use matchers like "integerLiteral(equals(32))". For this to

r305021 - [ASTMatchers] Add support for floatLiterals

Author: lekensteyn Date: Thu Jun 8 17:00:50 2017 New Revision: 305021 URL: http://llvm.org/viewvc/llvm-project?rev=305021=rev Log: [ASTMatchers] Add support for floatLiterals Summary: Needed to support something like "floatLiteral(equals(1.0))". The parser for floating point numbers is kept

r305020 - [ASTMatchers] Add support for boolean literals

Author: lekensteyn Date: Thu Jun 8 17:00:38 2017 New Revision: 305020 URL: http://llvm.org/viewvc/llvm-project?rev=305020=rev Log: [ASTMatchers] Add support for boolean literals Summary: Recognize boolean literals for future extensions ("equals(true)"). Note that a specific VariantValue

[PATCH] D33094: [ASTMatchers] Add clang-query support for equals matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL305022: [ASTMatchers] Add clang-query support for equals matcher (authored by Lekensteyn). Changed prior to commit: https://reviews.llvm.org/D33094?vs=101817=101967#toc Repository: rL LLVM

[PATCH] D33093: [ASTMatchers] Add support for boolean literals

This revision was automatically updated to reflect the committed changes. Closed by commit rL305020: [ASTMatchers] Add support for boolean literals (authored by Lekensteyn). Changed prior to commit: https://reviews.llvm.org/D33093?vs=98781=101966#toc Repository: rL LLVM

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

This revision was automatically updated to reflect the committed changes. Closed by commit rL305021: [ASTMatchers] Add support for floatLiterals (authored by Lekensteyn). Changed prior to commit: https://reviews.llvm.org/D33135?vs=101816=101968#toc Repository: rL LLVM

[PATCH] D33976: [clang] Fix format specifiers fixits

This revision was automatically updated to reflect the committed changes. Closed by commit rL305018: [clang] Fix format specifiers fixits (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D33976?vs=101962=101964#toc Repository: rL LLVM

r305018 - [clang] Fix format specifiers fixits

Author: alexshap Date: Thu Jun 8 16:44:45 2017 New Revision: 305018 URL: http://llvm.org/viewvc/llvm-project?rev=305018=rev Log: [clang] Fix format specifiers fixits This diff fixes printf "fixits" in the case when there is a wrapping macro and the format string needs multiple replacements.

[PATCH] D33976: [clang] Fix format specifiers fixits

alexshap updated this revision to Diff 101962. alexshap added a comment. Address comments Repository: rL LLVM https://reviews.llvm.org/D33976 Files: include/clang/Edit/EditedSource.h lib/Edit/EditedSource.cpp test/FixIt/fixit-format-darwin.m Index: test/FixIt/fixit-format-darwin.m

Re: [clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

Hello Alexander, Couple of our builders do not like this commit: Failing Tests: Clang Tools :: clang-tidy/modernize-use-noexcept-opt.cpp Clang Tools :: clang-tidy/modernize-use-noexcept.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/12431

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

rsmith added inline comments. Comment at: include/numeric:145 +{ +return reduce(__first, __last, __init, _VSTD::plus<>()); +} Missing _VSTD:: Comment at: include/numeric:153 +{ +return reduce(__first, __last, + typename

[PATCH] D34022: Repair 2010-05-31-palignr.c test

echristo added a comment. Thanks! https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34022: Repair 2010-05-31-palignr.c test

v.g.vassilev added a comment. Raphael and I work together I can take care of it... https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r304949 - [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

Hello Yan, This commit broke few of our builders: Failing Tests (1): Clang Tools :: clang-tidy/misc-noexcept-move-constructor.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/12411

[PATCH] D33094: [ASTMatchers] Add clang-query support for equals matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:335 unsigned Unsigned; +double Double; bool Boolean;

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from one minor nit, LGTM! Comment at: include/clang/AST/Decl.h:901 +/// member functions. +unsigned ImplicitParamKind : 3; };

r305013 - [Sema] Refactor OverloadCandidate::BuiltinTypes. NFC.

Author: gbiv Date: Thu Jun 8 15:55:21 2017 New Revision: 305013 URL: http://llvm.org/viewvc/llvm-project?rev=305013=rev Log: [Sema] Refactor OverloadCandidate::BuiltinTypes. NFC. As promised in r304996. Modified: cfe/trunk/include/clang/Sema/Overload.h

Re: [PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

On Wed, Jun 7, 2017 at 6:55 AM, Joerg Sonnenberger via Phabricator < revi...@reviews.llvm.org> wrote: > joerg added a comment. > > In https://reviews.llvm.org/D33726#774105, @ruiu wrote: > > > I'm totally against adding per-OS path knowledge to our linker. > Compilers already know include paths

[PATCH] D34022: Repair 2010-05-31-palignr.c test

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Thanks for the fix! Do you need someone to commit it? https://reviews.llvm.org/D34022 ___ cfe-commits mailing list

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 101955. yaxunl retitled this revision from "Support synchronisation scope in Clang atomic builtin functions" to "Add OpenCL 2.0 atomic builtin functions as Clang builtin". yaxunl edited the summary of this revision. yaxunl added a comment. Add

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. I think the test `reduce_iter_iter_T.pass.cpp` can be improved a little bit. Right now, it: - Tests that the three argument overload (iterators + init) work correctly when the iterator value type is the same as the init type. - Tests that the return type of the three

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

wash added a comment. Suppose you have: struct A {}; struct B {}; A operator+(A, B); std::vector v; std::reduce(v.begin(), v.end(), A{}); The implementation in this patch works fine for the above case - as would `accumulate`, which it is equivalent to. However, `reduce`

[PATCH] D33910: [ubsan] Detect invalid unsigned pointer index expression (clang)

vsk added a comment. I've encountered some new diagnostics when running tests on a stage2 instrumented clang, and will need more time to investigate them. Sorry for the delayed communication, I am a bit swamped this week owing to wwdc and being a build cop. https://reviews.llvm.org/D33910

RE: r284060 - Implement MS _BitScan intrinsics

It’s probably also better to not try to infer our weird desired behavior. It should probably be controlled by a specific driver directive, like “-fms-extensions-lp64-intrinsics” or something like that. Using a new directive means that nobody can accidentally get this behavior if they for some

r305002 - Revert "Frontend support for Nios2 target"

Author: n.bozhenov Date: Thu Jun 8 13:36:35 2017 New Revision: 305002 URL: http://llvm.org/viewvc/llvm-project?rev=305002=rev Log: Revert "Frontend support for Nios2 target" As it breaks many buildbots. Removed: cfe/trunk/include/clang/Basic/BuiltinsNios2.def

[libcxx] r305000 - [libcxx] [test] Update locale names for Windows.

Author: stl_msft Date: Thu Jun 8 13:22:03 2017 New Revision: 305000 URL: http://llvm.org/viewvc/llvm-project?rev=305000=rev Log: [libcxx] [test] Update locale names for Windows. locale.codecvt.byname/ctor_char.pass.cpp: This test used to use "en_US" as a plain string instead of using

[libcxx] r304999 - [libcxx] [test] Remove a Clang/C2 workaround.

Author: stl_msft Date: Thu Jun 8 13:21:59 2017 New Revision: 304999 URL: http://llvm.org/viewvc/llvm-project?rev=304999=rev Log: [libcxx] [test] Remove a Clang/C2 workaround. Clang/LLVM doesn't need this workaround. Fixes D33955. Modified:

r304997 - Added llvm_unreachable to make sure the switch is always exhaustive.

Author: gkistanova Date: Thu Jun 8 13:20:32 2017 New Revision: 304997 URL: http://llvm.org/viewvc/llvm-project?rev=304997=rev Log: Added llvm_unreachable to make sure the switch is always exhaustive. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified:

r304996 - [Sema] Remove unused field from OverloadCandidate.

Author: gbiv Date: Thu Jun 8 13:19:25 2017 New Revision: 304996 URL: http://llvm.org/viewvc/llvm-project?rev=304996=rev Log: [Sema] Remove unused field from OverloadCandidate. The only use in-tree I can find for BuiltinTypes.ResultTy is a single store to it. We otherwise just recompute what it

[PATCH] D33976: [clang] Fix format specifiers fixits

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM with a couple of fixes: Comment at: test/FixIt/fixit-format-darwin.m:3 +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -fsyntax-only

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r304697 - Revert "[sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)"

Ah, I see https://bugs.llvm.org/show_bug.cgi?id=33308, moving the discussion there. On Thu, Jun 8, 2017 at 10:05 AM, Kostya Serebryany wrote: > How did it break it? > Any logs? > > On Mon, Jun 5, 2017 at 12:35 AM, Renato Golin via cfe-commits < > cfe-commits@lists.llvm.org>

r304994 - Frontend support for Nios2 target.

Author: n.bozhenov Date: Thu Jun 8 12:40:30 2017 New Revision: 304994 URL: http://llvm.org/viewvc/llvm-project?rev=304994=rev Log: Frontend support for Nios2 target. Summary: - Implements TargetInfo class for Nios2 target. - Enables handling of -march and -mcpu options for Nios2 target. -

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

This revision was automatically updated to reflect the committed changes. Closed by commit rL304994: Frontend support for Nios2 target. (authored by n.bozhenov). Changed prior to commit: https://reviews.llvm.org/D33356?vs=100674=101941#toc Repository: rL LLVM

RE: r284060 - Implement MS _BitScan intrinsics

Yes, we definitely do not want to introduce pointer-type incompatibility warnings. Predicating the behavior change on LP64 vs LLP64 seems better. What’s the best way to do that? Brian and I can hack on clang a bit, but we’re certainly not experts. Schwieb From: Saleem Abdulrasool

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

arphaman added inline comments. Comment at: test/Index/availability.c:20 // CHECK-2: (macos, introduced=10.4, deprecated=10.5, obsoleted=10.7) // CHECK-2: EnumConstantDecl=old_enum:6:3 (Definition) (deprecated) rdwampler wrote: > Can we run `FileCheck` once

Re: r304697 - Revert "[sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)"

How did it break it? Any logs? On Mon, Jun 5, 2017 at 12:35 AM, Renato Golin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rengolin > Date: Mon Jun 5 02:35:45 2017 > New Revision: 304697 > > URL: http://llvm.org/viewvc/llvm-project?rev=304697=rev > Log: > Revert

[PATCH] D33493: Speed up preamble loading

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one inline request below. I also have a question: what kind of performance benefits do you get for the preamble load times? Comment at:

[clang-tools-extra] r304988 - Wdocumentation fix.

Author: rksimon Date: Thu Jun 8 12:01:01 2017 New Revision: 304988 URL: http://llvm.org/viewvc/llvm-project?rev=304988=rev Log: Wdocumentation fix. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNoexceptCheck.h Modified:

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

chh added a comment. In https://reviews.llvm.org/D34002#775830, @alexfh wrote: > IIUC, when `vector` (for a class `T` that has both move and copy > constructors) resizes, it will prefer move constructors, but only if they're > declared `noexcept`. This is true even if `-fno-exceptions` is on.

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof added a comment. @rnk can you let me know if you are happy with the changes? @rovka I assume the rebase did not change your mind about the patch. But please let me know if you have new reservations. Thanks Comment at: lib/Frontend/DiagnosticRenderer.cpp:512 //

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof updated this revision to Diff 101933. christof marked 6 inline comments as done. christof added a comment. Rebased onto current HEAD and addressed the comments from Reid. https://reviews.llvm.org/D31709 Files: include/clang/Basic/SourceLocation.h

r304984 - [sanitizer-coverage] Allow using KASAN instrumentation with sancov

Author: glider Date: Thu Jun 8 11:24:21 2017 New Revision: 304984 URL: http://llvm.org/viewvc/llvm-project?rev=304984=rev Log: [sanitizer-coverage] Allow using KASAN instrumentation with sancov Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

mclow.lists created this revision. These are part of C++17. Later, we'll get the parallel versions. https://reviews.llvm.org/D34038 Files: include/numeric test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_iter_iter_iter.pass.cpp

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

christof commandeered this revision. christof added a reviewer: sanwou01. christof added a comment. This refactoring was ready to land some time ago, except for a few small details. It's a shame if we don't commit this refactoring, so with @sanwou01 his agreement, I'm taking over this patch.

[clang-tools-extra] r304983 - [clangd] extend completion test

Author: krasimir Date: Thu Jun 8 11:02:27 2017 New Revision: 304983 URL: http://llvm.org/viewvc/llvm-project?rev=304983=rev Log: [clangd] extend completion test Modified: clang-tools-extra/trunk/test/clangd/completion.test Modified: clang-tools-extra/trunk/test/clangd/completion.test URL:

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi updated this revision to Diff 101929. MontyKutyi added a comment. Just added the whole file instead of a small surrounding to be able to check the `DEF_TRAVERSE_DECL` macro too. https://reviews.llvm.org/D34030 Files: include/clang/AST/RecursiveASTVisitor.h Index:

[clang-tools-extra] r304981 - [clangd] Separate authority less uris from completion tests

Author: krasimir Date: Thu Jun 8 10:21:55 2017 New Revision: 304981 URL: http://llvm.org/viewvc/llvm-project?rev=304981=rev Log: [clangd] Separate authority less uris from completion tests Added: clang-tools-extra/trunk/test/clangd/authority-less-uri.test - copied, changed from

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

This revision was automatically updated to reflect the committed changes. Closed by commit rL304980: [clangd] Add parameter and return type information to completion results (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D34033?vs=101921=101925#toc Repository: rL

[clang-tools-extra] r304980 - [clangd] Add parameter and return type information to completion results

Author: krasimir Date: Thu Jun 8 10:11:51 2017 New Revision: 304980 URL: http://llvm.org/viewvc/llvm-project?rev=304980=rev Log: [clangd] Add parameter and return type information to completion results Summary: This patch adds information about the parameters and return types of completion

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: test/clangd/completion.test:32 # CHECK: {"jsonrpc":"2.0","id":1,"result":[ -# CHECK-DAG: {"label":"a","kind":5} -# CHECK-DAG:

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

krasimir updated this revision to Diff 101921. krasimir marked an inline comment as done. krasimir added a comment. - Add sortText and filterText https://reviews.llvm.org/D34033 Files: clangd/ClangdUnit.cpp test/clangd/completion.test Index: test/clangd/completion.test

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clangd/ClangdUnit.cpp:153 Item.kind = getKind(Result.CursorKind); +Item.insertText = CCS->getTypedText(); if (CCS->getBriefComment()) ilya-biryukov

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

krasimir updated this revision to Diff 101919. krasimir added a comment. - Remove optional chunks. They might contain control characters https://reviews.llvm.org/D34033 Files: clangd/ClangdUnit.cpp test/clangd/completion.test Index: test/clangd/completion.test

[PATCH] D34033: [clangd] Add parameter and return type information to completion results

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:153 Item.kind = getKind(Result.CursorKind); +Item.insertText = CCS->getTypedText(); if (CCS->getBriefComment()) Should we also update sortText and filterText, which

[PATCH] D33598: [libclang] [OpenCL] Expose CIndex functions for typedef and address space

This revision was automatically updated to reflect the committed changes. Closed by commit rL304978: [libclang] Expose typedef and address space functions (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D33598?vs=100404=101918#toc Repository: rL LLVM

r304978 - [libclang] Expose typedef and address space functions

Author: svenvh Date: Thu Jun 8 09:22:04 2017 New Revision: 304978 URL: http://llvm.org/viewvc/llvm-project?rev=304978=rev Log: [libclang] Expose typedef and address space functions Expose the following functions: - clang_getTypedefName - clang_getAddressSpace Patch by Simon Perretta.

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rL304977: [clang-tidy] New checker to replace dynamic exception specifications (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D20693?vs=101860=101910#toc Repository: rL LLVM

[clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

Author: alexfh Date: Thu Jun 8 09:04:16 2017 New Revision: 304977 URL: http://llvm.org/viewvc/llvm-project?rev=304977=rev Log: [clang-tidy] New checker to replace dynamic exception specifications Summary: New checker to replace dynamic exception specifications This is an alternative to D18575

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev updated this revision to Diff 101908. ABataev added a comment. Removed FIXMEs and corrected comment https://reviews.llvm.org/D33735 Files: include/clang/AST/Decl.h lib/AST/ASTImporter.cpp lib/AST/Decl.cpp lib/AST/DeclObjC.cpp lib/CodeGen/CGBlocks.cpp

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh added a comment. In https://reviews.llvm.org/D20693#776030, @hintonda wrote: > Great, thanks for you help. > > Could you commit this for me? Sure, running tests... https://reviews.llvm.org/D20693 ___ cfe-commits mailing list

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Great, thanks for you help. Could you commit this for me? https://reviews.llvm.org/D20693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

joerg added a comment. Soft-float on the runtime environment part. I.e. non-trivial operations are lowered to library calls. Repository: rL LLVM https://reviews.llvm.org/D34018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34031: [OpenCL] Diagnose some reserved types

svenvh created this revision. Catch uses of the 'long long', 'unsigned long long', and 'long double' reserved types. Remove use of 'long long' in test/Misc/languageOptsOpenCL.cl; it shouldn't have been added there in the first place as the OpenCL specification explicitly forbids it in s6.1.4.

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

FlameTop added inline comments. Comment at: test/clang-tidy/misc-noexcept-move-constructor.cpp:2 +// RUN: clang-tidy %s -checks="-*,misc-noexcept-move-constructor" -- -std=c++11 \ +// RUN: | FileCheck %s -check-prefix=CHECK-EXCEPTIONS \ +// RUN:

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

krytarowski added a comment. Softfloat on the NetBSD of Clang/LLVM part? Repository: rL LLVM https://reviews.llvm.org/D34018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >