pcc added a comment.
Before looking at this patch in detail, can you please explain the need for
this feature? How difficult would it be to change your code to avoid relying on
invalid casts?
https://reviews.llvm.org/D34233
___
cfe-commits mailing
egoktas updated this revision to Diff 102641.
egoktas added a comment.
Remove the edits to CGExpr.cpp which accidentally got included in the diff.
https://reviews.llvm.org/D34233
Files:
include/clang/Basic/SanitizerBlacklist.h
lib/Basic/SanitizerBlacklist.cpp
lib/CodeGen/CGVTables.cpp
l
egoktas created this revision.
egoktas created this object with visibility "All Users".
User can explicitly specify classlinks in a sanitizer blacklist file. During
compilation with Control-Flow Integrity (CFI), the specified classes will be
linked so that (vtables of) the class type Y can be us
Author: marshall
Date: Thu Jun 15 00:44:49 2017
New Revision: 305453
URL: http://llvm.org/viewvc/llvm-project?rev=305453&view=rev
Log:
Renamed some of the newly added tests. No functional change
Added:
libcxx/trunk/test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp
-
dberris added a comment.
@dblaikie it turns out that this is a much simpler change now. PTAL?
https://reviews.llvm.org/D34052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jun 14 22:50:02 2017
New Revision: 305451
URL: http://llvm.org/viewvc/llvm-project?rev=305451&view=rev
Log:
attempt to fix GCC ToT build failures
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-project
Author: ericwf
Date: Wed Jun 14 22:38:08 2017
New Revision: 305450
URL: http://llvm.org/viewvc/llvm-project?rev=305450&view=rev
Log:
Correct documentation about the AfterClass clang-format option
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
Modified: cfe/trunk/docs/ClangFormatStyleOp
puneetha updated this revision to Diff 102635.
puneetha added a comment.
Added testcase.
https://reviews.llvm.org/D34198
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/type-traits.cpp
Index: test/SemaCXX/type-traits.cpp
===
---
Author: ericwf
Date: Wed Jun 14 22:03:45 2017
New Revision: 305448
URL: http://llvm.org/viewvc/llvm-project?rev=305448&view=rev
Log:
Fix another test with modules enabled
Modified:
libcxx/trunk/test/libcxx/depr/depr.function.objects/depr.adaptors.cxx1z.pass.cpp
Modified:
libcxx/trunk/test/
Author: ericwf
Date: Wed Jun 14 22:02:43 2017
New Revision: 305447
URL: http://llvm.org/viewvc/llvm-project?rev=305447&view=rev
Log:
remove incorrectly committed assertion
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://llvm.
xiangzhai added a comment.
Kindly ping Artem and Anna :)
Repository:
rL LLVM
https://reviews.llvm.org/D31868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jun 14 21:54:15 2017
New Revision: 305446
URL: http://llvm.org/viewvc/llvm-project?rev=305446&view=rev
Log:
Add hack to get --param=enable_modules=true working with a __config_site header
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils
Author: ericwf
Date: Wed Jun 14 21:54:12 2017
New Revision: 305445
URL: http://llvm.org/viewvc/llvm-project?rev=305445&view=rev
Log:
Fix test when modules are enabled
Modified:
libcxx/trunk/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.cxx1z.pass.cpp
Modi
xiangzhai added a comment.
Dear Anna,
Long time no see, miss you :)
> Should this revision be "abandoned" or is the plan to iterate on it?
I wanna the plan to iterate on it, Artem reviewed the patch, and I fixed the
issue as he suggested, ran `make check-clang-analysis` also used it for
check
Author: ericwf
Date: Wed Jun 14 20:53:12 2017
New Revision: 305442
URL: http://llvm.org/viewvc/llvm-project?rev=305442&view=rev
Log:
Move external instantiation for __vector_base_common to vector.cpp
Previously the explicit instantiation for this was in locale.cpp,
but that didn't make much sense
Author: ctopper
Date: Wed Jun 14 20:27:58 2017
New Revision: 305439
URL: http://llvm.org/viewvc/llvm-project?rev=305439&view=rev
Log:
[Basic] Use a static_assert instead of using the old array of size -1 trick.
Modified:
cfe/trunk/include/clang/Basic/AllDiagnostics.h
Modified: cfe/trunk/incl
Author: rtrieu
Date: Wed Jun 14 20:35:06 2017
New Revision: 305440
URL: http://llvm.org/viewvc/llvm-project?rev=305440&view=rev
Log:
[ODRHash] Hash TemplateArgument::Pack and TemplateTypeParmType
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/tr
Author: ericwf
Date: Wed Jun 14 19:54:08 2017
New Revision: 305437
URL: http://llvm.org/viewvc/llvm-project?rev=305437&view=rev
Log:
[clang-format] Allow git-clang-format to handle empty extensions.
Most of libc++'s header files don't use extension. This prevents
using git-clang-format on them, w
Author: erichkeane
Date: Wed Jun 14 19:28:13 2017
New Revision: 305435
URL: http://llvm.org/viewvc/llvm-project?rev=305435&view=rev
Log:
Fix LexerTest signed/unsigned comparison.
Werror was catching a signed/unsigned compare in
an assert, correct the signed 'expected' value to be
unsigned.
Modi
Author: erichkeane
Date: Wed Jun 14 19:27:23 2017
New Revision: 305434
URL: http://llvm.org/viewvc/llvm-project?rev=305434&view=rev
Log:
Update Append Argument to more efficiently traverse tokens
This function was previously making (correct) assumptions
without complete knowledge of MacroArgs gua
hintonda added a comment.
I have, but just haven't heard back yet... Thanks again...
https://reviews.llvm.org/D34179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r305432. You should consider reaching out to Chris Lattner for svn
access!
https://reviews.llvm.org/D34179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: aaronballman
Date: Wed Jun 14 19:00:08 2017
New Revision: 305432
URL: http://llvm.org/viewvc/llvm-project?rev=305432&view=rev
Log:
Handle -ast-dump-all when passed as the only option.
Patch by Don Hinton
Modified:
cfe/trunk/lib/Frontend/ASTConsumers.cpp
cfe/trunk/test/Coverage/as
hintonda added a comment.
Great, thanks Aaron.
Could you commit it for me when you get a chance?
https://reviews.llvm.org/D34179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF created this revision.
Herald added a subscriber: klimek.
This patch (1) enable parsing for coroutines by default and (2) teaches
clang-format how to properly handle them.
https://reviews.llvm.org/D34225
Files:
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
lib/Format/Unwrapp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D34179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
aaron.ballman added a comment.
In https://reviews.llvm.org/D33904#778165, @george.burgess.iv wrote:
> > Why not just use __has_feature(overloadable_unmarked) or similar?
>
> My impression was that `__has_feature` was was for larger features than
> tweaks to attributes. If this would be an approp
aaron.ballman added inline comments.
Comment at: include/clang-c/Index.h:185
+ */
+ CXCursor_ExceptionSpecificationKind_None, ///< no exception specification
+
You can drop the trailing comment.
Comment at: include/clang-c/Index.h:208
+ /**
hiraditya created this revision.
https://reviews.llvm.org/D34224
Files:
include/memory
Index: include/memory
===
--- include/memory
+++ include/memory
@@ -724,7 +724,7 @@
struct __has_element_type : false_type {};
template
-s
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:41
+ forEachConstructorInitializer(
+ cxxCtorInitializer(
mehdi_amini added a comment.
OK! Thanks both :)
https://reviews.llvm.org/D34156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305427: [locale] Avoid copy of __atoms when char_type is
char (authored by hiraditya).
Changed prior to commit:
https://reviews.llvm.org/D30268?vs=102566&id=102621#toc
Repository:
rL LLVM
https://re
Author: hiraditya
Date: Wed Jun 14 18:17:45 2017
New Revision: 305427
URL: http://llvm.org/viewvc/llvm-project?rev=305427&view=rev
Log:
[locale] Avoid copy of __atoms when char_type is char
The function num_get<_CharT>::stage2_int_prep makes unnecessary copy of src
into atoms when char_type is ch
Author: erichkeane
Date: Wed Jun 14 18:15:51 2017
New Revision: 305426
URL: http://llvm.org/viewvc/llvm-project?rev=305426&view=rev
Log:
Update callbacks tracker to match change in 305425
Modified:
clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp
Modified: clang-tools-extra/trunk/pp-t
This revision was automatically updated to reflect the committed changes.
erichkeane marked 3 inline comments as done.
Closed by commit rL305425: [Preprocessor]Correct Macro-Arg allocation of
StringifiedArguments, (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D320
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:356
QualType ResultTy) {
- if (!State->isTainted(RHS) && !State->isTainted(LHS))
-return UnknownVal();
I am concerned that removing the g
Author: erichkeane
Date: Wed Jun 14 18:09:01 2017
New Revision: 305425
URL: http://llvm.org/viewvc/llvm-project?rev=305425&view=rev
Log:
[Preprocessor]Correct Macro-Arg allocation of StringifiedArguments,
correct getNumArguments
StringifiedArguments is allocated (resized) based on the size the
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/RedundantKeywordCheck.cpp:22
+template
+static bool startsWith(const T &Node, StringRef Value) {
+ Token Result;
Why do you need to do a textual search that the first token in the declarati
zaks.anna added a comment.
Should this revision be "abandoned" or is the plan to iterate on it?
Repository:
rL LLVM
https://reviews.llvm.org/D31320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks good with a nit!
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:325
+ Loc makeNull() { return loc::ConcreteInt(BasicVals.getZeroWith
zaks.anna added a comment.
Great cleanup! Some comments below.
Comment at: www/analyzer/alpha_checks.html:91
+(C, C++)
+Check for logical errors for function calls and Objective-C message
+expressions (e.g., uninitialized arguments, null function pointers,
fo
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added a comment.
In https://reviews.llvm.org/D34156#780714, @mehdi_amini wrote:
> In https://reviews.llvm.org/D34156#780570, @tobiasvk wrote:
>
> > - Change patch to always emit a module summary for regular LTO
> >
> > I don't see any real downside of having a summary given the marginal tim
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#780714, @mehdi_amini wrote:
> In https://reviews.llvm.org/D34156#780570, @tobiasvk wrote:
>
> > - Change patch to always emit a module summary for regular LTO
> >
> > I don't see any real downside of having a summary given the margina
arphaman updated this revision to Diff 102607.
arphaman added a comment.
Remove redundant driver version correctness checks.
Repository:
rL LLVM
https://reviews.llvm.org/D34175
Files:
lib/Driver/ToolChains/Darwin.cpp
test/Driver/darwin-sdkroot.c
Index: test/Driver/darwin-sdkroot.c
mehdi_amini added a comment.
In https://reviews.llvm.org/D34156#780570, @tobiasvk wrote:
> - Change patch to always emit a module summary for regular LTO
>
> I don't see any real downside of having a summary given the marginal time
> and space overhead it takes to construct and save it.
I th
Author: dexonsmith
Date: Wed Jun 14 16:26:31 2017
New Revision: 305418
URL: http://llvm.org/viewvc/llvm-project?rev=305418&view=rev
Log:
AST: Add missing break at end of switch
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
Modified: cfe/trunk/lib/AST/ASTContext.cpp
URL:
http://llvm.org/viewvc/
Author: marshall
Date: Wed Jun 14 16:23:57 2017
New Revision: 305417
URL: http://llvm.org/viewvc/llvm-project?rev=305417&view=rev
Log:
Rework some metaprogramming to use the detection idiom; no functional change
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
mibintc updated this revision to Diff 102605.
mibintc added a comment.
Thanks for your review, Fedor. I moved AddGnuIncludeArgs out of
GCCInstallation, like you suggested, and put it along where the library
includes are added. I also pulled out the change for MipsLinux since I don't
have a wa
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM! Please fix the code style issues that I pointed out before committing.
Comment at: unittests/Lex/LexerTest.cpp:24
#include "clang/Lex/PreprocessorOptions.h"
+#incl
vsk updated this revision to Diff 102603.
vsk marked an inline comment as done.
vsk added a comment.
Address Adrian's comment about using an enum to simplify some calls.
https://reviews.llvm.org/D34121
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeGen/CodeGenFunction.
arphaman added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1133
+ HadExtra) ||
+ HadExtra || Major != 10 || Minor >= 100 || Micro >= 100)
+return MacOSSDKVersion;
inouehrs wrote:
> What these magic number
arphaman added a comment.
In https://reviews.llvm.org/D34185#780494, @ahatanak wrote:
> This patch fixes the crash and that is fine, but the users might find the
> last error ("expected '}'" at the end of the file) confusing. This seems to
> happen because Parser::ParseLexedObjCMethodDefs consu
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me.
Sorry of the delay here -- and thanks for your patience. I will review the
other patches this weekend.
https://reviews.llvm.org/D33308
___
mclow.lists added a comment.
As of r305410, libc++ passes all the tests w/ -Wcast-qual enabled.
Repository:
rL LLVM
https://reviews.llvm.org/D33102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: marshall
Date: Wed Jun 14 15:00:36 2017
New Revision: 305410
URL: http://llvm.org/viewvc/llvm-project?rev=305410&view=rev
Log:
Add some const_casts in places where we were implicitly casting away constness.
No functional change, but now they're explicit
Modified:
libcxx/trunk/include
On Wed, Jun 14, 2017, 8:17 AM Serge Pavlov wrote:
> 2017-06-14 4:24 GMT+07:00 David Blaikie :
>
>> Ah, I find that the test passes if I remove the compile_commands.json
>> file from my build directory (I have Ninja configured to generate a
>> compile_commands.json file).
>>
>> Looks like what hap
tobiasvk updated this revision to Diff 102585.
tobiasvk added a comment.
- Change patch to always emit a module summary for regular LTO
I don't see any real downside of having a summary given the marginal time and
space overhead it takes to construct and save it.
https://reviews.llvm.org/D34156
fjricci abandoned this revision.
fjricci added a comment.
Weak hooks do provide a good solution, abandoning for now (although it may need
to be reconsidered if we get a windows LSan port up and running).
https://reviews.llvm.org/D34210
___
cfe-comm
ruiu added a comment.
Overall looking good. Good work! A few minor comments.
Comment at: clang/include/clang/Driver/Options.td:2198
def stdlib_EQ : Joined<["-", "--"], "stdlib=">, Flags<[CC1Option]>,
- HelpText<"C++ standard library to use">;
+ HelpText<"C++ standard library
zaks.anna added a comment.
This generally sounds good. Definitely do submit these changes in small pieces!
See http://llvm.org/docs/DeveloperPolicy.html#incremental-development for
rationale.
https://reviews.llvm.org/D27753
___
cfe-commits mailing
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:454
+def UnixAPIPortabilityChecker : Checker<"API">,
+ HelpText<"Finds implementation-defined behavior in UNIX/Posix functions">,
+ DescFile<"UnixAPIChecker.cpp">;
No
m.ostapenko added a comment.
In https://reviews.llvm.org/D34210#780520, @fjricci wrote:
> Currently, the way that we tell users to gate on sanitizer-specific behavior
> is with `__has_feature(foo_sanitizer)`, as far as I know, it's the only way
> to do so. LSan provides several API functions fo
fjricci added a comment.
Currently, the way that we tell users to gate on sanitizer-specific behavior is
with `__has_feature(foo_sanitizer)`, as far as I know, it's the only way to do
so. LSan provides several API functions for users, ie `__lsan_ignore_object`.
If a user program wants to use th
ahatanak added a comment.
This patch fixes the crash and that is fine, but the users might find the last
error ("expected '}'" at the end of the file) confusing. This seems to happen
because Parser::ParseLexedObjCMethodDefs consumes all tokens in the file until
it sees the EOF after consuming a
yawanng updated this revision to Diff 102577.
yawanng marked 7 inline comments as done.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/FileOpenFlagCheck.cpp
clang-tidy/android
yawanng added inline comments.
Comment at: clang-tidy/android/FileOpenFlagCheck.cpp:61
+ SourceLocation EndLoc =
+ Lexer::getLocForEndOfToken(FlagArg->getLocEnd(), 0, SM, getLangOpts());
+
hokein wrote:
> Instead of using getLangOpts(), you should use `Resu
kcc added a comment.
I'm not sure about this one.
standalone lsan is a link-time feature only, it doesn't change the compilation,
so the argument of consistency doesn't apply.
https://reviews.llvm.org/D34210
___
cfe-commits mailing list
cfe-commit
tstellar created this revision.
Reported in PR33161.
https://reviews.llvm.org/D34212
Files:
docs/BinaryCompatibilityWithOtherCompilers.rst
Index: docs/BinaryCompatibilityWithOtherCompilers.rst
===
--- /dev/null
+++ docs/BinaryC
Author: jtony
Date: Wed Jun 14 12:23:43 2017
New Revision: 305401
URL: http://llvm.org/viewvc/llvm-project?rev=305401&view=rev
Log:
[PPC] Enhance altivec conversion function macros implementation.
Add checking for the second parameter of altivec conversion builtin to make sure
it is compile-time
Eugene.Zelenko added a comment.
It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
llvm::make_unique.
https://reviews.llvm.org/D34206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
yvvan added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:2453
std::string PlaceholderStr = FormatFunctionParameter(Policy, Param);
+if (Param->hasDefaultArg() && PlaceholderStr.find("=") ==
std::string::npos) {
+std::string DefaultValue =
-
hiraditya updated this revision to Diff 102566.
hiraditya added a comment.
Addressed comments from Eric.
https://reviews.llvm.org/D30268
Files:
libcxx/benchmarks/stringstream.bench.cpp
libcxx/include/__config
libcxx/include/locale
Index: libcxx/include/locale
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305399: Define _GNU_SOURCE for rtems c++ (authored by
jyknight).
Changed prior to commit:
https://reviews.llvm.org/D34105?vs=102188&id=102565#toc
Repository:
rL LLVM
https://reviews.llvm.org/D34105
Author: jyknight
Date: Wed Jun 14 12:01:18 2017
New Revision: 305399
URL: http://llvm.org/viewvc/llvm-project?rev=305399&view=rev
Log:
Define _GNU_SOURCE for rtems c++
This is required by the libc++ locale support.
Patch by Walter Lee.
Differential Revision: https://reviews.llvm.org/D34105
Mod
Author: marshall
Date: Wed Jun 14 11:54:43 2017
New Revision: 305397
URL: http://llvm.org/viewvc/llvm-project?rev=305397&view=rev
Log:
In several places in std::allocator (and one in shared_ptr, we were
casting a 'const T*' to a 'void *' - implicitly casting away the const. Add
const_cast to mak
Author: jyknight
Date: Wed Jun 14 11:40:03 2017
New Revision: 305394
URL: http://llvm.org/viewvc/llvm-project?rev=305394&view=rev
Log:
PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+
Newlib 2.5 added the locale management functions, so it should not
include __nop_local_mgmt.h. This chang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305394: PR32476: __nop_locale_mgmt.h not needed with newlib
2.5+ (authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D32146?vs=102265&id=102562#toc
Repository:
rL LLVM
https://
malcolm.parsons added a comment.
LGTM!
Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:58
+// is already nested NestingThreshold levels deep, record the start
location
+// of this new compound statement
+if (CurrentNestingLevel == Info.NestingThreshold)
--
lebedev.ri added a comment.
In https://reviews.llvm.org/D34202#780424, @malcolm.parsons wrote:
> My coding standards require the `{}`, so while I may not agree with your
> definition of nesting, it doesn't matter.
Well, seeing `readability-deep-nesting.cpp` in the issue, i suppose the
definit
malcolm.parsons added a comment.
My coding standards require the `{}`, so while I may not agree with your
definition of nesting, it doesn't matter.
Repository:
rL LLVM
https://reviews.llvm.org/D34202
___
cfe-commits mailing list
cfe-commits@list
lebedev.ri added a comment.
In https://reviews.llvm.org/D34202#780394, @malcolm.parsons wrote:
> What do you expect for this?
>
> if (true)
> if (true)
> if (true) {
> int j;
> }
>
that it is equivalent to
if (true && true && true) { // 1
int j;
mclow.lists created this revision.
This is the last of three patches - https://reviews.llvm.org/D33997 and
https://reviews.llvm.org/D34038 were the first two.
When this lands, we'll have all of the new (non-parallel) algorithms that were
added in C++17.
https://reviews.llvm.org/D34211
Files:
rjmccall added a comment.
Test cases?
https://reviews.llvm.org/D34198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons added a comment.
What do you expect for this?
if (true)
if (true)
if (true) {
int j;
}
Repository:
rL LLVM
https://reviews.llvm.org/D34202
___
cfe-commits mailing list
cfe-commits@lists.l
fjricci created this revision.
Stand-alone leak sanitizer builds are supported with -fsanitize=leak,
adds an attribute for consistency with the rest of the sanitizer attributes.
https://reviews.llvm.org/D34210
Files:
lib/Lex/PPMacroExpansion.cpp
test/Lexer/has_feature_leak_sanitizer.cpp
I
klimek added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:2453
std::string PlaceholderStr = FormatFunctionParameter(Policy, Param);
+if (Param->hasDefaultArg() && PlaceholderStr.find("=") ==
std::string::npos) {
+std::string DefaultValue =
a.sidorin accepted this revision.
a.sidorin added a comment.
Hello Daniel & Gabor,
Thank you very much for your work. This patch looks good to me but I think such
a change should also be approved by maintainers.
https://reviews.llvm.org/D30691
___
dkrupp added a comment.
Thanks for the reviews so far.
I think we have addressed all major concerns regarding this patch:
-(Anna) Scan-build-py integration of the functionality is nearly finished (see
https://github.com/rizsotto/scan-build/issues/83) (--ctu switch performs both
analysis phases
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305392: Be more strict when checking the -flto option value
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34055?vs=102551&id=102555#toc
Repository:
rL LLVM
https://revi
Author: yamaguchi
Date: Wed Jun 14 10:37:11 2017
New Revision: 305392
URL: http://llvm.org/viewvc/llvm-project?rev=305392&view=rev
Log:
Be more strict when checking the -flto option value
Summary:
It seems -flto must be either "thin" or "full". I think the use of
containValue is just a typo.
Rev
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:3010
+return CGF.EmitCheckedInBoundsGEP(ptr, indices, signedIndices,
+ /*IsSubtraction=*/false, loc, name);
} else {
Might want to define an
`enum { Not
hokein created this revision.
Herald added a subscriber: xazax.hun.
https://reviews.llvm.org/D34206
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
docs/clang-tidy/checks/modernize-make-shared.rst
docs/clang-tidy/checks/modernize-make-unique.rst
hokein added inline comments.
Comment at: clang-tidy/android/FileOpenFlagCheck.cpp:28
+ hasParameter(1, hasType(isInteger())),
+ hasAnyName("open", "open64"))
+ .bind("funcDecl")))
--
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
https://reviews.llvm.org/D34055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
waltl added a comment.
In https://reviews.llvm.org/D32146#780231, @bcraig wrote:
> LGTM.
> @waltl : Do you need me to submit the changes, or will you handle that?
Thanks -- I think jyknight will handle it.
https://reviews.llvm.org/D32146
___
cfe
2017-06-14 4:24 GMT+07:00 David Blaikie :
> Ah, I find that the test passes if I remove the compile_commands.json file
> from my build directory (I have Ninja configured to generate a
> compile_commands.json file).
>
> Looks like what happens is it finds the compilation database and fails
> hard w
yamaguchi updated this revision to Diff 102551.
yamaguchi added a comment.
Herald added a subscriber: eraman.
Update patch. Add testcase and check if argument is valid or not.
https://reviews.llvm.org/D34055
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clang/test/CodeGen/thinlto-backend
lebedev.ri updated this revision to Diff 102548.
lebedev.ri added a comment.
Simplify it even further by moving the logic into it's proper place -
`TraverseCompoundStmt()`
Repository:
rL LLVM
https://reviews.llvm.org/D34202
Files:
clang-tidy/readability/FunctionSizeCheck.cpp
test/clang-
yvvan added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:2411-2417
+ const SourceLocation StartLoc = SrcRange.getBegin();
+ const SourceLocation EndLoc = SrcRange.getEnd();
+ if (StartLoc != SM.getExpansionLoc(StartLoc) || EndLoc !=
SM.getExpansionLoc(EndLoc))
+
1 - 100 of 149 matches
Mail list logo
