[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

2017-06-16 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich added a comment. Please commit on my behalf. https://reviews.llvm.org/D30406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

2017-06-16 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thank you! (Not sure if @NoQ wants to do a final review.) Do you have commit access or should we commit on your behalf? https://reviews.llvm.org/D30406

[PATCH] D34102: [analyzer] Add portability package for the checkers.

2017-06-16 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. > eg. checkers for portability across linux/bsd should be off on windows by > default, checkers for non-portable C++ APIs should be off in plain C code, etc Is the checker you are moving to portability off and not useful on Windows? https://reviews.llvm.org/D34102

[PATCH] D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11

2017-06-16 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D34266 ___ cfe-commits mailing list

LLVM buildmaster will be updated and restarted tonight

2017-06-16 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

2017-06-16 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. It looks Comment at: lib/Sema/SemaExpr.cpp:14715 +if (Method->isVirtual() && !(Method->hasAttr() || + Method->getParent()->hasAttr())) OdrUse = false; Do you think it makes sense to eliminate all

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

2017-06-16 Thread Eric Christopher via Phabricator via cfe-commits
echristo edited reviewers, added: bkramer; removed: echristo. echristo added a comment. Going to let Ben review this. I'd rather not pass the bool down and he might know a way to avoid that here by knowing the code more :) https://reviews.llvm.org/D34304

r305619 - Call setMustBuildLookupTable on TagDecls in ExternalASTMerger

2017-06-16 Thread Lang Hames via cfe-commits
Author: lhames Date: Fri Jun 16 19:12:38 2017 New Revision: 305619 URL: http://llvm.org/viewvc/llvm-project?rev=305619=rev Log: Call setMustBuildLookupTable on TagDecls in ExternalASTMerger Summary: setMustBuildLookupTable should be called on imported TagDecls otherwise we may fail to import

Buildbot numbers for the week of 06/04/2017 - 06/10/2017

2017-06-16 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 06/04/2017 - 06/10/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Buildbot numbers for the week of 05/28/2017 - 06/03/2017

2017-06-16 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 05/28/2017 - 06/03/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Duncan P. N. Exon Smith via cfe-commits
> On Jun 16, 2017, at 11:02, Reid Kleckner wrote: > > We should fix it. Agreed. > We just need a new character code in the builtin function prototype encoding. > Currently there is no encoding for a portable int32_t that magically becomes > "long" on 32-bit Windows. The

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

2017-06-16 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ +

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

2017-06-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 102902. arphaman marked an inline comment as done. arphaman added a comment. Swap the checking operators and bring back the accidentally deleted code. Repository: rL LLVM https://reviews.llvm.org/D34264 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

2017-06-16 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. Herald added a subscriber: Prazek. The test case I added used to fail because of a linker error. Linkage failed because Sema::MarkDeclRefReferenced would prevent the virtual method definition from being emitted by setting OdrUse=false and then code-gen would

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

2017-06-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:6944 -diag = !ObjCPropertyAccess ? diag::err_unavailable - : diag::err_property_method_unavailable; -diag_message = diag::err_unavailable_message;

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

2017-06-16 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:6944 -diag = !ObjCPropertyAccess ? diag::err_unavailable - : diag::err_property_method_unavailable; -diag_message = diag::err_unavailable_message;

[PATCH] D34294: Rework libcxx strerror_r handling.

2017-06-16 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In https://reviews.llvm.org/D34294#782856, @jyknight wrote: > In https://reviews.llvm.org/D34294#782806, @krytarowski wrote: > > > New one is harder to comprehend and less portable (usage of `__atribute__`). > > > I can't disagree more strongly. This is

[PATCH] D34212: docs: Document binary compatibility issue due to bug in gcc

2017-06-16 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. Could you add links to this document in index.rst and UsersManual.rst? Comment at: docs/BinaryCompatibilityWithOtherCompilers.rst:39 + +https://llvm.org/PR33161 This link is still showing up as 'insecure'. Mind using this?:

Re: r305600 - [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes

2017-06-16 Thread Joerg Sonnenberger via cfe-commits
On Fri, Jun 16, 2017 at 10:40:18PM -, Petr Hosek via cfe-commits wrote: > @@ -53,8 +53,15 @@ using namespace clang::driver; > using namespace llvm::opt; > > std::string GetExecutablePath(const char *Argv0, bool CanonicalPrefixes) { > - if (!CanonicalPrefixes) > -return Argv0; > + if

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

2017-06-16 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305600: [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D34290?vs=102881=102894#toc Repository: rL LLVM

r305600 - [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes

2017-06-16 Thread Petr Hosek via cfe-commits
Author: phosek Date: Fri Jun 16 17:40:18 2017 New Revision: 305600 URL: http://llvm.org/viewvc/llvm-project?rev=305600=rev Log: [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes When -no-canonical-prefixes option is used and argv0 contains only a program name, we need to do a

[PATCH] D34294: Rework libcxx strerror_r handling.

2017-06-16 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. In https://reviews.llvm.org/D34294#782806, @krytarowski wrote: > New one is harder to comprehend and less portable (usage of `__atribute__`). I can't disagree more strongly. This is fundamentally portable C++ code -- __attribute__((unused)) is simply warning

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

2017-06-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 102891. arphaman marked 2 inline comments as done. arphaman added a comment. Remove the assert and support the other partial availability warnings. Repository: rL LLVM https://reviews.llvm.org/D34264 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

2017-06-16 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. This patch makes ubsan's nonnull return value diagnostics more precise, which makes the diagnostics more useful when there are multiple return statements in a function. Example: 1 |__attribute__((returns_nonnull)) char *foo() { 2 | if (...) { 3 |return

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-16 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi updated this revision to Diff 102885. akyrtzi added a comment. Improving doc comment. https://reviews.llvm.org/D34263 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorOptions.h lib/Lex/PPDirectives.cpp lib/Lex/PPExpressions.cpp

[PATCH] D34294: Rework libcxx strerror_r handling.

2017-06-16 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Or better: #elif __GLIBC__ || (__ANDROID_API__ - 0) >= 23 If I understand correctly, Android adopted GNU version. https://reviews.llvm.org/D34294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34294: Rework libcxx strerror_r handling.

2017-06-16 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. New one is harder to comprehend and less portable (usage of `__atribute__`). Can we just replace #elif defined(__linux__) && !defined(_LIBCPP_HAS_MUSL_LIBC) && \ (!defined(__ANDROID__) || __ANDROID_API__ >= 23) with `#elif __GLIBC__`?

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-16 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added a comment. Thanks, this looks good to me. I'd appreciate if @klimek could take a quick look though. Comment at: include/clang/Lex/PreprocessorOptions.h:102 + /// in preprocessor directive conditions it causes all blocks to be parsed so + /// that the

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

2017-06-16 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D34290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

2017-06-16 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 102881. phosek marked an inline comment as done. phosek edited the summary of this revision. Repository: rL LLVM https://reviews.llvm.org/D34290 Files: tools/driver/driver.cpp Index: tools/driver/driver.cpp

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

2017-06-16 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: tools/driver/driver.cpp:58 +SmallString<128> ExecutablePath(Argv0); +// Do a PATH lookup, if there are no directory components. +if (llvm::sys::path::filename(ExecutablePath) == ExecutablePath) hans wrote: >

[PATCH] D34267: do more processing in clang-fuzzer (use EmitAssemblyAction)

2017-06-16 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc added a comment. ignore this for now. I've found how to make it even more interesting (by using llvm::InitializeAllTargets, etc), will send an update later. https://reviews.llvm.org/D34267 ___ cfe-commits mailing list

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 102877. jyu2 added a comment. update patch https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.cpp test/SemaCXX/warn-throw-out-noexcept-func.cpp Index:

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:27 +} + +struct N : A { aaron.ballman wrote: > jyu2 wrote: > > aaron.ballman wrote: > > > Can you add a test case like: > > > ``` > > > struct Throws { > > > ~Throws()

[PATCH] D34294: Rework libcxx strerror_r handling.

2017-06-16 Thread James Y Knight via Phabricator via cfe-commits
jyknight created this revision. Herald added subscribers: krytarowski, srhines. The set of #ifdefs used to handle the two incompatible variants of strerror_r were not complete (they didn't handle newlib appropriately). Rather than attempting to make the ifdefs more complex, make them unnecessary

[PATCH] D33852: Enable __declspec(selectany) on linux

2017-06-16 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: include/clang/Basic/Attr.td:2421 -def SelectAny : InheritableAttr, TargetSpecificAttr { +def SelectAny : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"selectany">, GCC<"selectany">]; Prazek wrote: >

[PATCH] D34286: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

2017-06-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 102871. hokein added a comment. Update https://reviews.llvm.org/D34286 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/modernize-make-unique.cpp

[PATCH] D34114: [clang] A better format for unnecessary packed warning.

2017-06-16 Thread Yan Wang via Phabricator via cfe-commits
yawanng added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D34114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33253: [index] Fix typo: inferface -> interface

2017-06-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Btw, you can usually commit typo fixes and other similar changes without pre-commit reviews Repository: rL LLVM https://reviews.llvm.org/D33253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r305588 - [index] Fix typo: inferface -> interface

2017-06-16 Thread Marc-Andre Laperle via cfe-commits
Author: malaperle Date: Fri Jun 16 15:58:26 2017 New Revision: 305588 URL: http://llvm.org/viewvc/llvm-project?rev=305588=rev Log: [index] Fix typo: inferface -> interface Reviewers: arphaman Reviewed By: arphaman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D33253

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:27 +} + +struct N : A { jyu2 wrote: > aaron.ballman wrote: > > Can you add a test case like: > > ``` > > struct Throws { > > ~Throws() noexcept(false); > > }; > > >

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 102868. jyu2 added a comment. Update patch https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.cpp test/SemaCXX/warn-throw-out-noexcept-func.cpp Index:

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only -Wexceptions -verify -std=c++11 +struct A { aaron.ballman wrote: >

r305586 - Killing a tab and some other spurious whitespace; NFC.

2017-06-16 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Jun 16 15:52:59 2017 New Revision: 305586 URL: http://llvm.org/viewvc/llvm-project?rev=305586=rev Log: Killing a tab and some other spurious whitespace; NFC. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp Modified:

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

2017-06-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I find the change to the diagnostic for enum constants a bit off putting, since the warning can refer to the enum itself when an enum constant is used. I'd rather we say something like `'EnumConstant' is deprecated` and keep the note that this patch uses (`'Enum' has

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

2017-06-16 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Thanks! Please add to the description that this is for PR9576. Comment at: tools/driver/driver.cpp:58 +SmallString<128> ExecutablePath(Argv0); +// Do a PATH lookup, if there are no directory components. +if

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only -Wexceptions -verify -std=c++11 +struct A { rnk wrote: >

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only -Wexceptions -verify -std=c++11 +struct A { aaron.ballman wrote: > I believe

[PATCH] D34277: [analyzer] Bump default performance thresholds?

2017-06-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. This was an mixture of internal apple projects (user apps, drivers, deamons, whatever) with a relatively balanced selection of languages and levels of analyzer adoption. They amounted to ~16 hours of analysis CPU time (i.e. 4 hours on a quad-core machine per run). I've

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

2017-06-16 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305576: [PR33394] Avoid lexing editor placeholders when Clang is used only (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34256?vs=102764=102862#toc Repository: rL LLVM

r305576 - [PR33394] Avoid lexing editor placeholders when Clang is used only

2017-06-16 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Jun 16 15:13:39 2017 New Revision: 305576 URL: http://llvm.org/viewvc/llvm-project?rev=305576=rev Log: [PR33394] Avoid lexing editor placeholders when Clang is used only for preprocessing r300667 added support for editor placeholder to Clang. That commit didn’t take

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

2017-06-16 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. When -no-canonical-prefixes option is used and argv0 contains only a program name, we need to do a PATH lookup to get an executable path, otherwise the return value won't be a valid path and any subsequent uses of it (e.g. invoking -cc1) will fail with an error.

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. A few more nits, but this feels like it's getting close to ready (at least, to me). Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only

r305574 - Ignore return value in test.

2017-06-16 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Jun 16 14:29:20 2017 New Revision: 305574 URL: http://llvm.org/viewvc/llvm-project?rev=305574=rev Log: Ignore return value in test. Modified: cfe/trunk/test/Driver/m_and_mm.c Modified: cfe/trunk/test/Driver/m_and_mm.c URL:

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-16 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi updated this revision to Diff 102859. akyrtzi added a comment. Enhanced doc-comment for the preprocessor option, and fixed indentation on a couple of calls. https://reviews.llvm.org/D34263 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorOptions.h

[PATCH] D34277: [analyzer] Bump default performance thresholds?

2017-06-16 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Once Artem gives more details about the codebase he tested on, I think it would be fine to commit this. We can revert/address concerns later if @a.sidorin or anyone else raises concerns

[PATCH] D34277: [analyzer] Bump default performance thresholds?

2017-06-16 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. > Maybe we should introduce another UMK_* for deeper analysis instead? The difference here is not substantial enough to warrant a new level. The general motivation for bumping these numbers is that we've set the timeouts many years ago and the hardware improved quite

r305568 - [ubsan] docs: Add a note about pointers to volatile

2017-06-16 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Fri Jun 16 13:38:43 2017 New Revision: 305568 URL: http://llvm.org/viewvc/llvm-project?rev=305568=rev Log: [ubsan] docs: Add a note about pointers to volatile Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified:

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

2017-06-16 Thread Dan Ciliske via Phabricator via cfe-commits
dciliske added a comment. So... how should I get something added? That patch has been sitting for a couple weeks. Should I work on that patch? If so, how do I work on it? This is the first time I'm working on a large OSS project. https://reviews.llvm.org/D34252

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-16 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added inline comments. Comment at: lib/Lex/PPDirectives.cpp:2774 +// the directive blocks. +CurPPLexer->pushConditionalLevel(CI.IfLoc, /*wasskip*/false, + /*foundnonskip*/true, /*foundelse*/true); akyrtzi

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-16 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi added inline comments. Comment at: lib/Lex/PPDirectives.cpp:2774 +// the directive blocks. +CurPPLexer->pushConditionalLevel(CI.IfLoc, /*wasskip*/false, + /*foundnonskip*/true, /*foundelse*/true); benlangmuir

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

2017-06-16 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D34287 Files: include/clang/Frontend/ASTUnit.h include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp lib/Frontend/CMakeLists.txt lib/Frontend/PrecompiledPreamble.cpp Index:

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

2017-06-16 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added a comment. Thank you Sean, I'll try. https://reviews.llvm.org/D6550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34286: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

2017-06-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. Herald added a subscriber: xazax.hun. If the class being created in unique_ptr is in anonymous nampespace, the anonymous namespace will be included in the apply-fixes. This patch fix this. namespace { class Foo {}; } std::unique_ptr f; f.reset(new Foo());

[PATCH] D32332: Add support for transparent overloadable functions in clang

2017-06-16 Thread George Burgess IV via Phabricator via cfe-commits
george.burgess.iv updated this revision to Diff 102850. george.burgess.iv marked 3 inline comments as done. george.burgess.iv added a comment. Addressed all feedback https://reviews.llvm.org/D32332 Files: include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

2017-06-16 Thread Sean Callanan via Phabricator via cfe-commits
spyffe added a comment. Hmm, the transforming in place of `SelLocs` reads a little weirdly to me, but other than that the code seems fine. Is your concern that you don't know how to write an Objective-C test that would cover this? It looks to me like an Objective-C interface with a method:

RE: [llvm-dev] Llvm lab resent network issues are resolved

2017-06-16 Thread Quentin Neill via cfe-commits
> Hello everyone, > There were network issues with our provider and LLVM buildmaster was > unavailable recently. > Sorry for inconvenience. > Thanks > Galina Hi Galina, Thanks for the note. Still no connectivity from the outside (using several down time checkers (upstrends.com,

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

2017-06-16 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added a comment. Will anybody object if I commit this change without a test? This bug seems to be pretty obvious but, unfortunately, I'm not familiar with Objective C. https://reviews.llvm.org/D6550 ___ cfe-commits mailing list

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Reid Kleckner via cfe-commits
We should fix it. We just need a new character code in the builtin function prototype encoding. Currently there is no encoding for a portable int32_t that magically becomes "long" on 32-bit Windows. The closest thing we have is 'W', which is used by Neon intrinsics to select between "long" and

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

2017-06-16 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added inline comments. Comment at: www/analyzer/alpha_checks.html:91 +(C, C++) +Check for logical errors for function calls and Objective-C message +expressions (e.g., uninitialized arguments, null function pointers, szdominik wrote: > zaks.anna

[PATCH] D34277: [analyzer] Bump default performance thresholds?

2017-06-16 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added a comment. Hi Artem, Could you tell what code bases did you use to collect your statistics? I'll try to check the patch on our code bases. I think we should be careful about default settings. Maybe we should introduce another UMK_* for deeper analysis instead?

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

2017-06-16 Thread Benjamin Buch via Phabricator via cfe-commits
bebuch reopened this revision. bebuch added a comment. This revision is now accepted and ready to land. I believe this patch is incomplete, I get a very odd warning: struct A{ int x; }; template < typename > struct B{ A data_[1]; void f(){ for(auto [x]:

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-16 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added a comment. It would be nice if the doc comment for the single file parse mode flag was updated to include this new functionality. Comment at: lib/Lex/PPDirectives.cpp:2709 +CurPPLexer->pushConditionalLevel(IfToken.getLocation(), /*wasskip*/true, +

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
We (Office developers for Apple platforms at Microsoft) would prefer to have the intrinsics work properly for LP64, as that will generate the most optimal and efficient code. That said, we understand that this may be odd to implement from the compiler's perspective and can work around it if the

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

2017-06-16 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In https://reviews.llvm.org/D34158#782467, @fedor.sergeev wrote: > LGTM wrt your update to sources. > And sorry, I'm not that qualified to answer your question on failing tests. > > Probing existence of this header would make a sense, yet you are including it > w/o a

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

2017-06-16 Thread Fedor Sergeev via Phabricator via cfe-commits
fedor.sergeev added a comment. LGTM wrt your update to sources. And sorry, I'm not that qualified to answer your question on failing tests. Probing existence of this header would make a sense, yet you are including it w/o a full path, so how are you going to find it for this probe?

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

2017-06-16 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. I also did not have any local patches applied - just checked out release_40 branch for llvm and clang. I believe I also don't have warnings as errors enabled. At least I've checked for the extra flags and did not find such. I'll search once again if I have /WX somewhere

Llvm lab resent network issues are resolved

2017-06-16 Thread Galina Kistanova via cfe-commits
Hello everyone, There were network issues with our provider and LLVM buildmaster was unavailable recently. Sorry for inconvenience. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

2017-06-16 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM https://reviews.llvm.org/D34256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

2017-06-16 Thread Leslie Zhai via Phabricator via cfe-commits
xiangzhai updated this revision to Diff 102840. xiangzhai added a comment. Dear Raphael, I updated my patch as you suggested, may I commit it? thanks! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31320 Files: include/clang/Analysis/CloneDetection.h

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

2017-06-16 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich updated this revision to Diff 102838. vlad.tsyrklevich marked an inline comment as done. vlad.tsyrklevich added a comment. After reviewing this patch again last night I: 1. Updated some "%clang_cc1 -analyze" calls with "%clang_analyze_cc1" due to

[PATCH] D33383: [GSoC] Flag value completion for clang

2017-06-16 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/include/clang/Driver/Options.td:2198 def stdlib_EQ : Joined<["-", "--"], "stdlib=">, Flags<[CC1Option]>, - HelpText<"C++ standard library to use">; + HelpText<"C++ standard library to use">,

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

2017-06-16 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi closed this revision. yamaguchi added a comment. Landed in r305561. https://reviews.llvm.org/D32341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r305561 - Fix a bug that warnings generated with -M or -MM flags

2017-06-16 Thread Yuka Takahashi via cfe-commits
Author: yamaguchi Date: Fri Jun 16 11:01:13 2017 New Revision: 305561 URL: http://llvm.org/viewvc/llvm-project?rev=305561=rev Log: Fix a bug that warnings generated with -M or -MM flags This is a patch for bug: https://bugs.llvm.org/show_bug.cgi?id=6817 Warnings should not be emitted with -M

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

2017-06-16 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a subscriber: tstellar. hans added a comment. That's strange. I build the llvm 4.0 branch (and trunk too, which has the same code) with Visual Studio 2015 without problems. (I don't build with warnings as errors though, so if this is a warning maybe I missed it.) Do you have any

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

2017-06-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 102833. hokein added a comment. More improvements. https://reviews.llvm.org/D34206 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h docs/clang-tidy/checks/modernize-make-shared.rst

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
Adding Brian and Tomasz. I'm pretty sure we have the Windows SDK intrinsics headers. I'm not sure which method we'd prefer, so I'll walk down the hall and ask them. Tomasz is our header maestro (because we play crazy #include_next games so we can use both Windows and macOS SDKs!) We'll get

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

2017-06-16 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi added a comment. Hey Vladimir, what you are proposing is orthogonal to this patch. You are proposing for "the client to provide the value for an undefined identifier", and the patch is about the client not knowing what the value should be so it fallbacks to parsing all tokens to get

[PATCH] D34102: [analyzer] Add portability package for the checkers.

2017-06-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 102829. NoQ added a comment. Whoops, forgot to actually attach the patch. Here. https://reviews.llvm.org/D34102 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp test/Analysis/malloc-overflow2.c

[PATCH] D34102: [analyzer] Add portability package for the checkers.

2017-06-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Here's a version of the patch without `.unix`. I'd still hate it to re-add the subpackages if we decide to turn some portability checkers on and off depending on language/platform (eg. checkers for portability across linux/bsd should be off on windows by default, checkers

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 102828. jyu2 added a comment. Thanks Aaron!!! I just upload new patch to address your comments. I now understand your point on when I can use auto. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

2017-06-16 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. error list https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

2017-06-16 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan created this revision. I currently have narrowing conversion error without that fix. I try building with 64 and 32 bit compilers - both reproduce that error. https://reviews.llvm.org/D34279 Files: include/llvm/Target/TargetOpcodes.h Index: include/llvm/Target/TargetOpcodes.h

[PATCH] D32332: Add support for transparent overloadable functions in clang

2017-06-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This is generally looking good to me, with a few small nits. @rsmith, do you have thought on this? Comment at: lib/Sema/SemaDecl.cpp:2875-2876 /// Returns true if there was an error, false otherwise. -bool Sema::MergeFunctionDecl(FunctionDecl

[PATCH] D34277: [analyzer] Bump default performance thresholds?

2017-06-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. Because we now have faster CPUs and more RAM and stuff, should we now skew the balance to finding more bugs? We could probably make a few rounds of such changes, observing any delayed feedback from users who use default settings and aren't watching phabricator, and

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

2017-06-16 Thread wangxin via Phabricator via cfe-commits
wangxindsb created this revision. This implement a path-sensitive checker that warns if virtual calls are made from constructors and destructors. The checker use the GDM (generic data map) to store three integers in the program state for constructors, destructors and objects. Once enter one of

[PATCH] D33563: Track whether a unary operation can overflow

2017-06-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Ping https://reviews.llvm.org/D33563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

2017-06-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:304 + ->getUnqualifiedDesugaredType(); + if (CaughtType == nullptr || CaughtType == ThrowType) +return true; aaron.ballman wrote: > The check for a null

[PATCH] D34202: [clang-tidy] readability-function-size: fix nesting level calculation

2017-06-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305554: [clang-tidy] readability-function-size: fix nesting level calculation (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D34202?vs=102548=102813#toc Repository: rL

[clang-tools-extra] r305554 - [clang-tidy] readability-function-size: fix nesting level calculation

2017-06-16 Thread Roman Lebedev via cfe-commits
Author: lebedevri Date: Fri Jun 16 08:07:47 2017 New Revision: 305554 URL: http://llvm.org/viewvc/llvm-project?rev=305554=rev Log: [clang-tidy] readability-function-size: fix nesting level calculation Summary: A followup for D32942. Malcolm Parsons has provided a valid testcase that the initial

  1   2   >