[PATCH] D34444: Teach codegen to work in incremental processing mode.

rjmccall added a comment. Okay. In that case, I see two problems, one major and one potentially major. The major problem is that, as Richard alludes to, you need to make sure you emit any on-demand definitions that Sema registered with CodeGen during the initial CGM's lifetime but used in

r306497 - Remove a redundant call to ArgList::hasFlag. NFC.

Author: vedantk Date: Tue Jun 27 18:56:07 2017 New Revision: 306497 URL: http://llvm.org/viewvc/llvm-project?rev=306497=rev Log: Remove a redundant call to ArgList::hasFlag. NFC. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL:

[PATCH] D34714: [MS] Don't statically initialize dllimport member function pointers

majnemer added a comment. In https://reviews.llvm.org/D34714#793205, @rnk wrote: > Did you locally add a test case for the dllimport member function pointer > template argument? Arg, yes. Forgot to add the file... Comment at: lib/Sema/SemaTemplate.cpp:5704 + else +NPV

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added inline comments. Comment at: llvm/test/Other/new-pm-thinlto-defaults.ll:157 ; CHECK-PRELINK-O-NEXT: Running pass: GlobalOptPass -; CHECK-PRELINK-O-NEXT: Running pass: NameAnonGlobalPass ; CHECK-POSTLINK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

tejohnson added inline comments. Comment at: llvm/test/Other/new-pm-thinlto-defaults.ll:157 ; CHECK-PRELINK-O-NEXT: Running pass: GlobalOptPass -; CHECK-PRELINK-O-NEXT: Running pass: NameAnonGlobalPass ; CHECK-POSTLINK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>

[PATCH] D34714: [MS] Don't statically initialize dllimport member function pointers

rnk added a comment. Did you locally add a test case for the dllimport member function pointer template argument? Comment at: lib/Sema/SemaTemplate.cpp:5704 + else +NPV = isNullPointerValueTemplateArgument(S, Param, ParamType, ResultArg); + Think we

[PATCH] D34665: [CodeGen] Fix assertion failure in EmitCallArg

This revision was automatically updated to reflect the committed changes. Closed by commit rL306494: [CodeGen] Fix assertion failure in EmitCallArg. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D34665?vs=104086=104327#toc Repository: rL LLVM

r306494 - [CodeGen] Fix assertion failure in EmitCallArg.

Author: ahatanak Date: Tue Jun 27 17:42:48 2017 New Revision: 306494 URL: http://llvm.org/viewvc/llvm-project?rev=306494=rev Log: [CodeGen] Fix assertion failure in EmitCallArg. The assertion was failing when a method of a parameterized class was called and the types of the argument and

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:804-807 + case 0: +return PassBuilder::O0; + case 1: Why is this change needed? Comment at: clang/lib/CodeGen/BackendUtil.cpp:885-886 if

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen added a comment. A question I have is that I don't know how to test this. Ideally we want -debug-pass-manager from opt, but that flag is not part of the LLVM libraries. https://reviews.llvm.org/D34728 ___ cfe-commits mailing list

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen created this revision. Herald added subscribers: hiraditya, eraman, inglorion, mehdi_amini, sanjoy. Previously it doesn't actually invoke the designated new PM builder functions. https://reviews.llvm.org/D34728 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

This revision was automatically updated to reflect the committed changes. Closed by commit rL306489: [COFF, ARM64] Add support for Windows ARM64 COFF format (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D34706?vs=104308=104317#toc Repository: rL LLVM

r306489 - [COFF, ARM64] Add support for Windows ARM64 COFF format

Author: mgrang Date: Tue Jun 27 16:56:34 2017 New Revision: 306489 URL: http://llvm.org/viewvc/llvm-project?rev=306489=rev Log: [COFF, ARM64] Add support for Windows ARM64 COFF format Summary: This is the clang part of the initial implementation to support Windows ARM64 COFF format. Reviewers:

[PATCH] D34725: Add sample PGO integration test to cover profile annotation and inlining.

danielcdh created this revision. Herald added a subscriber: sanjoy. The patch makes the integration test cover major sample PGO components. https://reviews.llvm.org/D34725 Files: test/CodeGen/Inputs/pgo-sample.prof test/CodeGen/pgo-sample.c Index: test/CodeGen/pgo-sample.c

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

ruiu accepted this revision. ruiu added a comment. LGTM. I don't think I have enough knowledge to sign off, but as Saleem has already LGTM'ed, I guess it should be okay. https://reviews.llvm.org/D34706 ___ cfe-commits mailing list

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang updated this revision to Diff 104308. mgrang added a comment. Comments addressed. https://reviews.llvm.org/D34706 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-macros.c Index: test/Preprocessor/predefined-macros.c

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei created this revision. Herald added subscribers: xazax.hun, mgorny. This patch adds a new Static Analyzer checker for the correct use of handle in Magenta kernel. The concept of handle is very similar to file descriptor in Unix. This checker checks leaks, use after release and double

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine updated this revision to Diff 104307. saugustine added a comment. Rework this patch to use argument adjusters. It turns out that the call to newInvocation from ClangFuzzer has a very limited set of hard-coded arguments, so I don't think it is necessary to do the hand-adjusting there.

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

danielcdh added inline comments. Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:4 +// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO +//

[PATCH] D34091: Support for querying the exception specification type through libclang

This revision was automatically updated to reflect the committed changes. Closed by commit rL306483: [libclang] Support for querying the exception specification type through… (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D34091?vs=102934=104301#toc Repository: rL

r306483 - [libclang] Support for querying the exception specification type through libclang

Author: jbcoe Date: Tue Jun 27 15:54:56 2017 New Revision: 306483 URL: http://llvm.org/viewvc/llvm-project?rev=306483=rev Log: [libclang] Support for querying the exception specification type through libclang Summary: This patch exposes the exception specification type (noexcept, etc.) of a C++

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 104297. Prazek added a comment. fixed broken test https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefaultNumericsCheck.cpp clang-tidy/misc/DefaultNumericsCheck.h clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

danielcdh created this revision. Herald added subscribers: eraman, mehdi_amini, sanjoy. This implements the clang bits of https://reviews.llvm.org/D34720, and add corresponding test to verify if it worked. https://reviews.llvm.org/D34721 Files: lib/CodeGen/BackendUtil.cpp

[PATCH] D34714: [MS] Don't statically initialize dllimport member function pointers

majnemer created this revision. r306137 made dllimport pointers to member functions non-constant. This is correct because a load must be executed to resolve any dllimported data. However, r306137 did not account for the use of dllimport member function pointers used as template arguments. This

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 104288. Prazek added a comment. Small fix https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefaultNumericsCheck.cpp clang-tidy/misc/DefaultNumericsCheck.h clang-tidy/misc/MiscTidyModule.cpp

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc added inline comments. Comment at: include/clang/Format/Format.h:993 + /// inside ``IncludeCategories``. + bool IncludeRegexCaseInsensitive; + djasper wrote: > Do we really need a flag here? Shouldn't we just always do this? I have no opinion one way

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 104281. Prazek marked 2 inline comments as done. Prazek added a comment. Herald added a subscriber: JDevlieghere. - fixed docs - fixes - Last fixes? https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek added a comment. In https://reviews.llvm.org/D33470#790484, @aaron.ballman wrote: > In https://reviews.llvm.org/D33470#789791, @Prazek wrote: > > > In https://reviews.llvm.org/D33470#764846, @aaron.ballman wrote: > > > > > Once you fix the typo in the check, can you run it over some large

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. > can you recommend someone to review the extra test changes? I'm rather new to the project and thus rather bad at finding reviewers. Also generally I do not consider myself qualified enough to be the only reviewer, though in this particular case I believe I spent

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

coby added inline comments. Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1310 } - -bool X86AsmParser::ParseIntelExpression(IntelExprStateMachine , SMLoc ) { +bool X86AsmParser::ParseIntelExpression(IntelExprStateMachine , SMLoc , +

[PATCH] D32332: Add support for transparent overloadable functions in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL306467: [Sema] Allow unmarked overloadable functions. (authored by gbiv). Changed prior to commit: https://reviews.llvm.org/D32332?vs=103448=104277#toc Repository: rL LLVM

r306467 - [Sema] Allow unmarked overloadable functions.

Author: gbiv Date: Tue Jun 27 14:31:31 2017 New Revision: 306467 URL: http://llvm.org/viewvc/llvm-project?rev=306467=rev Log: [Sema] Allow unmarked overloadable functions. This patch extends the `overloadable` attribute to allow for one function with a given name to not be marked with the

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv added a comment. Woohoo! Thanks again to both of you. https://reviews.llvm.org/D32332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34091: Support for querying the exception specification type through libclang

ajbennieston added a comment. Jon, by all means go ahead! https://reviews.llvm.org/D34091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

rsmith added a comment. In https://reviews.llvm.org/D30946#754103, @schroedersi wrote: > As an alternative to the current solution, the above-mentioned member > functions could each be extended by a "PrintingContext" argument, which then > contains the variable states. I'd be interested to

RE: r306149 - Emit warning when throw exception in destruct or dealloc functions which has a

Hi Richard: I’m not sure if you noticed this, but my coworker did submit a review here: https://reviews.llvm.org/D34671 with the changes you suggested. Thanks, Erich From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith Sent: Monday, June 26, 2017 2:25 PM To: Keane,

[PATCH] D32332: Add support for transparent overloadable functions in clang

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D32332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

ruiu added inline comments. Comment at: lib/Basic/Targets.cpp:6553 +class MicrosoftARM64leTargetInfo +: public WindowsTargetInfo { I cannot imagine there will be MicrosoftARM64beTargetInfo, so I wonder if we should name this MicrosoftARM64TargetInfo.

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang added a comment. Here is the llvm part of this patch: https://reviews.llvm.org/D34705 https://reviews.llvm.org/D34706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang created this revision. Herald added subscribers: kristof.beyls, aemerson. This is the clang part of the initial implementation to support Windows ARM64 COFF format. https://reviews.llvm.org/D34706 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-macros.c Index:

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104249. johannes added a comment. - pass Options as a const reference instead of a pointer - rename TreeComparator -> ASTDiff::Impl, rename Comparator -> DiffImpl - move declaration of ASTDiff::Impl from the header to the source file so that Options does

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. We use them as separate translation units due to the fact that we need to survive multiple calls to `HandleEndOfTranslationUnit`. This 'finalizes' the module, and we cannot write to it anymore. Even though we could write to it (this was the case when we were using

[PATCH] D34444: Teach codegen to work in incremental processing mode.

rjmccall added a comment. What's the relationship between these llvm::Modules that you want to generate? Are you imagining them as separate translation units, or are the subsequent modules more like addenda to the original? Repository: rL LLVM https://reviews.llvm.org/D3

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

rsmith accepted this revision. rsmith added a comment. LGTM, thanks. Do you need someone to commit for you? https://reviews.llvm.org/D34198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34449: [clang-tidy] Enable constexpr definitions in headers.

hokein added a comment. BTW, could you please also update the `docs/clang-tidy/checks/misc-definitions-in-headers.rst`? Comment at: test/clang-tidy/misc-definitions-in-headers-1z.hpp:5 +class CE { + constexpr static int i = 5; +}; Could you follow the way of

r306447 - test: fix test for release builds

Author: compnerd Date: Tue Jun 27 11:57:50 2017 New Revision: 306447 URL: http://llvm.org/viewvc/llvm-project?rev=306447=rev Log: test: fix test for release builds Use a regex capture to avoid hardcoding the name. This should repair the failing buildbot. Modified:

[PATCH] D34665: [CodeGen] Fix assertion failure in EmitCallArg

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This seems fine, thanks. https://reviews.llvm.org/D34665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

compnerd closed this revision. compnerd added a comment. SVN r306444 https://reviews.llvm.org/D34580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306444 - CodeGen: load indirect ObjC ARC arguments in prologue

Author: compnerd Date: Tue Jun 27 11:37:51 2017 New Revision: 306444 URL: http://llvm.org/viewvc/llvm-project?rev=306444=rev Log: CodeGen: load indirect ObjC ARC arguments in prologue When generating a prologue, add loads for ARC arguments passed indirectly. Patch by Dave Lee! Added:

[libunwind] r306442 - [libunwind] Add _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS

Author: nico Date: Tue Jun 27 11:37:06 2017 New Revision: 306442 URL: http://llvm.org/viewvc/llvm-project?rev=306442=rev Log: [libunwind] Add _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS It's useful to be able to disable visibility annotations entirely; for example, if we're building libunwind

r306434 - Update the test comment to clarify the intention of the test.

Author: dehao Date: Tue Jun 27 10:45:40 2017 New Revision: 306434 URL: http://llvm.org/viewvc/llvm-project?rev=306434=rev Log: Update the test comment to clarify the intention of the test. Modified: cfe/trunk/test/CodeGen/pgo-sample-thinlto-summary.c Modified:

r306433 - [x86] weaken test checks that shouldn't be here in the first place

Author: spatel Date: Tue Jun 27 10:39:46 2017 New Revision: 306433 URL: http://llvm.org/viewvc/llvm-project?rev=306433=rev Log: [x86] weaken test checks that shouldn't be here in the first place This test would fail after the proposed change in: https://reviews.llvm.org/D34242 Modified:

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 104201. wangxindsb marked an inline comment as done. wangxindsb added a comment. -Fix the bug of the virtual call during a function call of the object. -Add flag for the PUREONLY. https://reviews.llvm.org/D34275 Files:

r306430 - Update test for enabling ICP for AutoFDO.

Author: dehao Date: Tue Jun 27 10:23:42 2017 New Revision: 306430 URL: http://llvm.org/viewvc/llvm-project?rev=306430=rev Log: Update test for enabling ICP for AutoFDO. Summary: This is the test update patch for https://reviews.llvm.org/D34662 Reviewers: davidxl Reviewed By: davidxl

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D34663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

danielcdh added inline comments. Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:39 +// O2: if.true.direct_targ // ThinLTO-NOT: if.true.direct_targ void icp(void (*p)()) { davidxl wrote: > Is the thinLTO behavior here expected? Yes, it's expected, icp is

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

davidxl added inline comments. Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:39 +// O2: if.true.direct_targ // ThinLTO-NOT: if.true.direct_targ void icp(void (*p)()) { Is the thinLTO behavior here expected? https://reviews.llvm.org/D34663

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

bader added a comment. Note: `get_sampler_initializer` from my test case returns integer, not a sampler, but having function is not relevant to the problem. Here is a bit simplified test case without function calls that still reproduces the problem: kernel void foo(int sampler_init_value) {

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

smeenai resigned from this revision. smeenai added a comment. Sorry, I've been meaning to respond for a while. This is kinda ugly, but I can't think of a better way to do it. I'm fine with this, but given that it's a pretty invasive change, I'm not comfortable accepting. You may wanna ping

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

danielcdh updated this revision to Diff 104199. danielcdh added a comment. update comments https://reviews.llvm.org/D34663 Files: test/CodeGen/pgo-sample-thinlto-summary.c Index: test/CodeGen/pgo-sample-thinlto-summary.c ===

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

akyrtzi added a comment. I'd prefer to avoid including whitespace-only changes (there are a couple of lines in the diff with only whitespace change), otherwise LGTM! https://reviews.llvm.org/D34506 ___ cfe-commits mailing list

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

yaxunl added a comment. In https://reviews.llvm.org/D34342#786941, @bader wrote: > Added test case reproducing the issue described in the description. > Removed test cases from test/SemaOpenCL/sampler_t.cl covered by > test/CodeGenOpenCL/sampler.cl. > > While I was moving one test case from

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

fhahn added a comment. In https://reviews.llvm.org/D24644#792262, @mehdi_amini wrote: > In https://reviews.llvm.org/D24644#792168, @fhahn wrote: > > > I'd like to fix PR22999 and was wondering if you think adding a > > function-section attribute to the IR would be a viable solution? > > > >

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

hokein added a comment. In https://reviews.llvm.org/D34206#790406, @alexfh wrote: > Ping me once you're done fixing the bugs. The bugs are fixed. The patch is ready for review ;) https://reviews.llvm.org/D34206 ___ cfe-commits mailing list

[clang-tools-extra] r306421 - [clang-tidy] Handle new array expressions in modernize-make-unique check.

Author: hokein Date: Tue Jun 27 09:25:05 2017 New Revision: 306421 URL: http://llvm.org/viewvc/llvm-project?rev=306421=rev Log: [clang-tidy] Handle new array expressions in modernize-make-unique check. Reviewers: alexfh Reviewed By: alexfh Subscribers: JDevlieghere, xazax.hun, cfe-commits

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306421: [clang-tidy] Handle new array expressions in modernize-make-unique check. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D34674 Files:

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. @fedor.sergeev do you have time to review my (hopefully) final revision? Also can you recommend someone to review the extra test changes? Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

arphaman created this revision. Herald added a subscriber: mgorny. The core engine of clang-rename will be used for local and global renames in the new refactoring engine (http://lists.llvm.org/pipermail/cfe-dev/2017-June/054286.html). I haven't renamed the files/cleaned up the code in this

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

hokein updated this revision to Diff 104190. hokein added a comment. Remove a redundant empty line. https://reviews.llvm.org/D34674 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h test/clang-tidy/modernize-make-unique.cpp Index:

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

mehdi_amini added a comment. In https://reviews.llvm.org/D24644#792168, @fhahn wrote: > I'd like to fix PR22999 and was wondering if you think adding a > function-section attribute to the IR would be a viable solution? > > When doing LTO, we could add the same function-section to each function

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer added a comment. I have create a separate patch for the _Float16 preprocessor macro definitions in https://reviews.llvm.org/D34695. https://reviews.llvm.org/D33719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r306419 - [OPENMP] Use MapVector instead of DenseMap for stable codegen, NFC.

Author: abataev Date: Tue Jun 27 08:46:42 2017 New Revision: 306419 URL: http://llvm.org/viewvc/llvm-project?rev=306419=rev Log: [OPENMP] Use MapVector instead of DenseMap for stable codegen, NFC. Modified: cfe/trunk/include/clang/AST/OpenMPClause.h

Re: [Diffusion] rL306364: [CodeGen][ObjC] Fix GNU's encoding of bit-field ivars.

Thanks for the fix! The change looks reasonable to me. On Tue, Jun 27, 2017 at 12:46 AM, NAKAMURA Takumi via Phabricator < revi...@reviews.llvm.org> wrote: > chapuni added subscribers: cfe-commits, chapuni. > chapuni added a comment. > > Could you confirm if my change were reasonable? Or

[PATCH] D34695: _Float16 preprocessor macro definitions

SjoerdMeijer created this revision. Herald added subscribers: aheejin, dschuff, jfb. This adds the _Float16 preprocessor macro definitions. https://reviews.llvm.org/D34695 Files: lib/Frontend/InitPreprocessor.cpp lib/Headers/float.h test/Preprocessor/init.c Index:

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

fhahn added a comment. I'd like to fix PR22999 and was wondering if you think adding a function-section attribute to the IR would be a viable solution? When doing LTO, we could add the same function-section to each function in a module in the IRLinker. @mehdi_amini did you think something like

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

xazax.hun added a comment. I created a new public API that is using a piece of code that was factored out from `isBeforeInTranslationUnit`. Using this new function it is possible to implement proper comparison of source locations within the Static Analyzer. What do you think?

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

xazax.hun updated this revision to Diff 104167. xazax.hun retitled this revision from "Relax an assert in the comparison of source locations" to "Factor out a functionality from `isBeforeInTranslationUnit`". xazax.hun edited the summary of this revision. xazax.hun added a comment. - New

[PATCH] D34687: [Tooling] CompilationDatabase should be able to strip position arguments when `-fsyntax-only` is used

arphaman created this revision. Right now, Clang fails to create a fixed compilation database when the compilation arguments use `-fsyntax-only` instead of `-c`. The reported error is: "warning: no compile jobs found". This happens because we don't look at the compilation job when stripping

[PATCH] D34686: [AArch64] Add hasFP16VectorArithmetic helper function. NFCI

SjoerdMeijer created this revision. Herald added subscribers: kristof.beyls, aemerson. This is a clean-up for different ARMV8-A architecture kinds. Helper function hasFP16VectorArithmetic makes things a bit more “scalable” if we want to add ARMv8.3 at some point.

r306409 - [clang-format] Fix a clang-tidy warning, NFC

Author: krasimir Date: Tue Jun 27 07:07:45 2017 New Revision: 306409 URL: http://llvm.org/viewvc/llvm-project?rev=306409=rev Log: [clang-format] Fix a clang-tidy warning, NFC Modified: cfe/trunk/lib/Format/NamespaceEndCommentsFixer.cpp Modified:

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D34674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r306408 - [clang-format] Fix a buildbot failure after r306406

Author: krasimir Date: Tue Jun 27 06:58:41 2017 New Revision: 306408 URL: http://llvm.org/viewvc/llvm-project?rev=306408=rev Log: [clang-format] Fix a buildbot failure after r306406 Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp

[PATCH] D34621: [clang-format] Support <>-style proto message fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL306406: [clang-format] Support <>-style proto message fields (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D34621 Files: cfe/trunk/lib/Format/ContinuationIndenter.cpp

r306406 - [clang-format] Support <>-style proto message fields

Author: krasimir Date: Tue Jun 27 06:43:07 2017 New Revision: 306406 URL: http://llvm.org/viewvc/llvm-project?rev=306406=rev Log: [clang-format] Support <>-style proto message fields Summary: This patch adds support for <>-style proto message fields inside proto options. Previously these were

[PATCH] D34621: [clang-format] Support <>-style proto message fields

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D34621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34621: [clang-format] Support <>-style proto message fields

krasimir updated this revision to Diff 104148. krasimir added a comment. - Remove todo test case https://reviews.llvm.org/D34621 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp

[PATCH] D34621: [clang-format] Support <>-style proto message fields

krasimir updated this revision to Diff 104146. krasimir added a comment. - Rebase with master - Updated implementation with the new tests https://reviews.llvm.org/D34621 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:57 + SyntaxTree(T *Node, const ASTContext ) + : TreeImpl(llvm::make_unique(this, Node, AST)) {} + If you want to use two different names then something like

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bcraig added a comment. _LIBCPP_MS_CRT seems fine too. https://reviews.llvm.org/D34588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added a comment. Ignore the "Just to clarify: I'm fine with adding the" comment, it was from last week that was saved in my session and that I didn't delete. https://reviews.llvm.org/D34329 ___ cfe-commits mailing list

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added a comment. Just to clarify: I'm fine with adding the Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:32 +public: + ASTDiff(SyntaxTree , SyntaxTree , ComparisonOptions *Options); + Can you pass-in the options by value instead of a pointer?

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

yvvan added a comment. F3487082: llvm.profdata Profdata which causes crash https://reviews.llvm.org/D34680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34680: Fix clang-cl build -fprofile-instr-use flag

yvvan created this revision. Reproduced while building llvm with clang-cl. I have trained profdata file. When I tried to use it I got crash complaining of nullptr casted inside visitor. https://reviews.llvm.org/D34680 Files: lib/CodeGen/CodeGenPGO.cpp Index: lib/CodeGen/CodeGenPGO.cpp

[PATCH] D34102: [analyzer] Add portability package for the checkers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306396: [analyzer] Move zero-size allocation checks to optin.portability. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D34102?vs=102829=104133#toc Repository: rL LLVM

r306396 - [analyzer] Move zero-size allocation checks to optin.portability.

Author: dergachev Date: Tue Jun 27 04:14:39 2017 New Revision: 306396 URL: http://llvm.org/viewvc/llvm-project?rev=306396=rev Log: [analyzer] Move zero-size allocation checks to optin.portability. This is a new checker package. It contains checkers that highlight well-documented

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan abandoned this revision. yvvan added a comment. Can't reproduce an error anymore https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Recheck please the latest diff https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Could anybody take a look at on this please? Thanks, Peter https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

chapuni added a comment. @Serge_Preis @arphaman Thanks! https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >