mstorsjo created this revision.
This fixes a dependency inconsistency, where addMinGWDefines in Targets.cpp
(used from other architectures than X86) called the addCygMingDefines function
in X86.h.
This was inconsistently split in SVN r308791 (https://reviews.llvm.org/D35701).
https://reviews.
rsmith accepted this revision.
rsmith added inline comments.
Comment at: test/CodeGenCoroutines/coro-ret-void.cpp:30
+coro1 f2() {
+ co_return(void) A{};
+}
This seems like an extremely confusing way to format this statement. Maybe move
the space left a bit?
yvvan added a comment.
Ok, i will make safer solution...
https://reviews.llvm.org/D34873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes updated this revision to Diff 108863.
jtbandes added a comment.
- Undo change in argument list
https://reviews.llvm.org/D36019
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
jtbandes updated this revision to Diff 108860.
jtbandes added a comment.
Okay, I think this approach is better:
- Rename the version of `appendNewlineText` used for escaped newlines to
`appendEscapedNewlineText` to reduce confusability.
- If `ENAS_DontAlign`, skip all of the offset calculation l
jtbandes added a comment.
I can add some clarity but I can't claim to fully understand the whole program
flow here yet, so my explanation is probably insufficient.
The overflow (underflow? but I think that means something specific to FP) is on
line formerly-650: `EscapedNewlineColumn - Offset -
djasper added a comment.
Could you explain this in more detail? Which subtraction is underflowing? Why
can't we just add a ternary expression there to handle the case?
https://reviews.llvm.org/D36019
___
cfe-commits mailing list
cfe-commits@lists.l
raj.khem added a comment.
@EricWF you are right. I have made the changes accordingly. This patch can be
ignored.
https://reviews.llvm.org/D18174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
smeenai added inline comments.
Comment at: include/__mutex_base:51
#ifndef _LIBCPP_CXX03_LANG
-constexpr mutex() = default;
+#ifdef __GLIBC__
+constexpr
EricWF wrote:
> Limiting `constexpr` to GLIBC implementations only is incorrect; you want to
> exclu
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
This patch is not OK, since it affects way more that just MUSL libc.
Also can you please provide a reduced reproducer as two why `pthread_mutex_t
mut = PTHREAD_MUTEX_INITIALIZER` is
EricWF created this revision.
Previously Clang incorrectly ignored the expression of a void `co_return`. This
patch addresses that bug.
I'm not quite sure if I got the code-gen right, but this patch is at least a
start.
https://reviews.llvm.org/D36070
Files:
lib/CodeGen/CGCoroutine.cpp
t
raj.khem updated this revision to Diff 108853.
raj.khem edited the summary of this revision.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D18174
Files:
include/__mutex_base
Index: include/__mutex_base
===
--- include
This particular issue isn't clang-specific; it affects MSVC as well, and I
believe clang's -fdelayed-template-parsing attempts to model MSVC's behavior.
See https://godbolt.org/g/xrbpgX (code in https://reviews.llvm.org/P8012).
On 7/6/17, 10:13 PM, "cfe-commits on behalf of Duncan P. N. Exon Smith
EricWF added a comment.
@rsmith Should this be considered for the `5.0` release?
https://reviews.llvm.org/D35297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Sun Jul 30 17:24:28 2017
New Revision: 309530
URL: http://llvm.org/viewvc/llvm-project?rev=309530&view=rev
Log:
[Sema] Fix operator lookup to consider local extern declarations.
Summary:
Previously Clang was not considering operator declarations that occur at
function scope.
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D35297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
EricWF updated this revision to Diff 108845.
EricWF added a comment.
- Address issues in inline comments. The patch should be ready to go now :-)
https://reviews.llvm.org/D35297
Files:
lib/Sema/SemaLookup.cpp
test/SemaCXX/overloaded-operator.cpp
Index: test/SemaCXX/overloaded-operator.cpp
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:229
assert(!Redeclaration && "cannot do redeclaration operator lookup");
-IDNS = Decl::IDNS_NonMemberOperator;
+IDNS = Decl::IDNS_NonMemberOperator | Decl::IDNS_LocalExtern;
break;
---
Author: ericwf
Date: Sun Jul 30 15:28:08 2017
New Revision: 309528
URL: http://llvm.org/viewvc/llvm-project?rev=309528&view=rev
Log:
Mark LWG 2942 as complete
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.weak/util.smartptr.weak.obs/owner_before_shared_ptr.pass
EricWF added a comment.
@rsmith Ping. This should be super simple to review.
https://reviews.llvm.org/D35297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Sun Jul 30 15:16:30 2017
New Revision: 309527
URL: http://llvm.org/viewvc/llvm-project?rev=309527&view=rev
Log:
Mark LWG 2961 as complete
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
URL:
http://llvm.org/viewvc/llvm-project/l
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D35986
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: brad
Date: Sun Jul 30 14:13:59 2017
New Revision: 309523
URL: http://llvm.org/viewvc/llvm-project?rev=309523&view=rev
Log:
Also pass -pie back to the linker when linking on OpenBSD.
Modified:
cfe/trunk/lib/Driver/ToolChains/OpenBSD.cpp
cfe/trunk/test/Driver/openbsd.c
Modified: cf
Author: brad
Date: Sun Jul 30 13:33:06 2017
New Revision: 309522
URL: http://llvm.org/viewvc/llvm-project?rev=309522&view=rev
Log:
Fix a typo.
Modified:
cfe/trunk/test/Preprocessor/init.c
Modified: cfe/trunk/test/Preprocessor/init.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Pr
Author: epilk
Date: Sun Jul 30 13:09:55 2017
New Revision: 309520
URL: http://llvm.org/viewvc/llvm-project?rev=309520&view=rev
Log:
[demangler] Fix some bugs in r309340 found by oss-fuzz
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
libcxxabi/trunk/test/test_demangle.pass.cpp
Modified:
teemperor updated this revision to Diff 108839.
teemperor added a comment.
(Fixed diff)
https://reviews.llvm.org/D34182
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
lib/StaticAnalyzer/Checkers/CloneChecker.cpp
Index: lib/StaticAnalyzer/Checkers/CloneChec
teemperor updated this revision to Diff 108837.
teemperor added a comment.
Herald added a subscriber: klimek.
- Updated according to Artem's comments.
https://reviews.llvm.org/D34182
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
lib/Format/UnwrappedLinePar
Eugene.Zelenko added a comment.
I think will be good idea to do this in -list-checks too.
https://reviews.llvm.org/D36051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru added a comment.
Good ideas guys. I will try to update list.rst to a table with the extra
information.
https://reviews.llvm.org/D36051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: lll
Date: Sat Jul 29 13:42:58 2017
New Revision: 309496
URL: http://llvm.org/viewvc/llvm-project?rev=309496&view=rev
Log:
Improve readability of CXX method overrides list
Summary:
Separate CXX method overrides list entries with commas.
Reviewers: lhames
Reviewed By: lhames
Subscribers:
Author: coby
Date: Sun Jul 30 03:19:10 2017
New Revision: 309508
URL: http://llvm.org/viewvc/llvm-project?rev=309508&view=rev
Log:
[x86][inline-asm]Allow a pack of Control Regs to be properly picked
Allows the incorporation of legit (x86) Control Regs within inline asm
stataements
Differential
Author: coby
Date: Sun Jul 30 04:13:46 2017
New Revision: 309510
URL: http://llvm.org/viewvc/llvm-project?rev=309510&view=rev
Log:
[x86][inline-asm][ms-compat] legalize the use of "jc/jz short "
MS ignores the keyword "short" when used after a jc/jz instruction, LLVM ought
to do the same.
llvm:
xazax.hun added a comment.
Maybe instead of a separate list, having this information like yes/no column in
a table in the original is more user-friendly.
https://reviews.llvm.org/D36051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309508: [x86][inline-asm]Allow a pack of Control Regs to be
properly picked (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D35903?vs=108317&id=108825#toc
Repository:
rL LLVM
h
sepavloff created this revision.
Herald added subscribers: srhines, klimek.
Information about clang executable name component, such as target and
driver mode, was passes in std::pair. With this change it is passed in
special structure. It improves readability and makes access to this
information m
JonasToth added a comment.
would be a classification of checks in general interesting?
i could think of "quality", some checks might be heuristic, some might be new
and have some bugs, and some might catch everything correct and handle it
perfectly.
So checks could have 2 categories:
-> autof
37 matches
Mail list logo
