[PATCH] D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.

[Raphael Isemann via Phabricator via cfe-commits]

teemperor added a comment.

In https://reviews.llvm.org/D36067#825867, @xazax.hun wrote:

> I like the directions of this patch.
>  In general, I am in favor of explicitly registering the options from user 
> defined checkers. 
>  But changing a config option will now break the command line compatibility, 
> so I wonder how do we want to handle this:
>
> - Have a list of no-op configs that we accept but warn that it has been 
> replaced/removed?
> - Just do not care and break compatibility?
> - Something else?


Don't have a preference here, but adding a forwarding config that also emits a 
warning should be easy to do.

> I have a wishlist for this feature but I am perfectly fine to only address 
> those in follow-up patches:
> 
> - Ability to set descriptions and maybe default values in the Checkers.td
> - Command line argument to dump the list of options with descriptions (and 
> defaults)

Yes, I would prefer having this in follow up patches. I tried to keep this as a 
minimal starting example because this currently blocks @yamaguchi 's GSoC 
project for bash completion. There we want to complete the values for 
`-analyzer-config` and we currently don't have a good way to get a complete 
list of available configs from the driver :).


https://reviews.llvm.org/D36067



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D36111#826878, @mgrang wrote:

> @mstorsjo I see that spec2000/eon calls __getReg, _ReadStatusReg and 
> _WriteStatusReg intrinsics for ARM64. I think I would need to implement them 
> in llvm. Do you know where can I find a doc explaining their behavior?


Sorry - I have no previous knowledge on them. Googling for `_ReadStatusReg` 
gets me to https://msdn.microsoft.com/en-us/library/hh875058.aspx at least 
(which is for ARM and not ARM64), which indicates that it'd map to the MRS 
instruction. And `__getReg`: 
https://msdn.microsoft.com/en-us/library/kcb3wece(v=vs.120).aspx

Since the ARM64 specifics of them aren't publicly known I guess you'd have to 
test MSVC to see what they expect in practice. For `__getReg` it seems to refer 
to `intrin.h` for register name constants - I guess `arm64intr.h` should define 
the constants for register numbers as well, or are they just called like 
`__getReg(30)` (to get the value of x30)?


https://reviews.llvm.org/D36111



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35955: clang-format: Add preprocessor directive indentation

[Daniel Jasper via Phabricator via cfe-commits]

djasper added inline comments.



Comment at: docs/ClangFormatStyleOptions.rst:1182
 
+**IndentPPDirectives** (``bool``)
+  Indent preprocessor directives on conditionals.

I think we can foresee that a bool is not going to be enough here. Make this an 
enum, which for no can contain the values "no" and "afterhash" and in the long 
run can get a "beforehash" value.



Comment at: lib/Format/ContinuationIndenter.cpp:379
 
+  // indent preprocessor directives after the hash if required.
+  if ((State.Line->Type == LT_PreprocessorDirective ||

Start comments upper case.



Comment at: lib/Format/ContinuationIndenter.cpp:383
+  Current.Previous->is(tok::hash) && State.FirstIndent > 0) {
+// subtract 1 so indent lines up with non-preprocessor code
+Spaces += State.FirstIndent;

Same here and use full sentences.

Also, this does not seem to be what the example in the style option suggests 
and I'd rather not do it (subtracting 1).



Comment at: lib/Format/UnwrappedLineFormatter.cpp:1021
 
+  // Preprocessor directives get indented after the hash.
+  if (Line.Type == LT_PreprocessorDirective ||

... or not at all. :)



Comment at: lib/Format/UnwrappedLineParser.cpp:667
   parsePPUnknown();
+  if (IfNDef) {
+PPMaybeIncludeGuard = IfCondition;

LLVM style does not use braces for single statement ifs.



Comment at: lib/Format/UnwrappedLineParser.cpp:699
   }
+  if (PPMaybeIncludeGuard != nullptr &&
+  PPMaybeIncludeGuard->TokenText == FormatTok->TokenText &&

In LLVM's codebase, we mostly just leave out the "!= nullptr" and rely on the 
implicit conversion to bool.



Comment at: lib/Format/UnwrappedLineParser.cpp:701
+  PPMaybeIncludeGuard->TokenText == FormatTok->TokenText &&
+  PPIndentLevel > 0) {
+--PPIndentLevel;

I think you'll need substantially more tests here:
- An include guard must not have a #else 
- An include guard must span the entire file



Comment at: lib/Format/UnwrappedLineParser.h:238
 
+  unsigned PPIndentLevel;
+  FormatToken *PPMaybeIncludeGuard;

I think this should almost always be PPBranchLevel. Probably the different case 
is the #else itself, but I think we can handle that easily.


https://reviews.llvm.org/D35955



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

[Daniel Jasper via Phabricator via cfe-commits]

djasper added a comment.

Please add all the tests into unittests/Format/FormatTest.cpp instead. We use 
FileCheck-based tests only to verify the behavior of the clang-format binary 
itself.


https://reviews.llvm.org/D35743



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

[Hal Finkel via Phabricator via cfe-commits]

hfinkel added inline comments.



Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3068
+def err_impcast_complex_scalar : Error<
+  "implicit conversion discards imaginary component: %0 to %1">;
 def warn_impcast_float_precision : Warning<

I think that, as an error, we should word this differently. How about:
  implicit conversion from %0 to %1 is not permitted in C++



https://reviews.llvm.org/D35817



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36118: Fix creating bitcasts with wrong address space

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.


https://reviews.llvm.org/D36118



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxxabi] r309349 - [demangler] Fix some overzealous -Wreturn-type errors

[Erik Pilkington via cfe-commits]

On 7/31/17 11:44 AM, David Blaikie wrote:



On Thu, Jul 27, 2017 at 6:35 PM Erik Pilkington via cfe-commits 
mailto:cfe-commits@lists.llvm.org>> wrote:


Author: epilk
Date: Thu Jul 27 18:35:14 2017
New Revision: 309349

URL: http://llvm.org/viewvc/llvm-project?rev=309349&view=rev
Log:
[demangler] Fix some overzealous -Wreturn-type errors


I'm guessing this is GCC's -Wreturn-type after a 
fully-covered-all-returning switch?

Yep, thats exactly the problem.
That's usually addressed by using llvm_unreachable after the switch, 
rather than a dead return. (not sure if you've something like 
llvm_unreachable in libcxxabi to use?)
Turns out there is a macro for this in libcxxabi. r309649 updates this 
to use that macro.


Thanks!
Erik



Modified:
libcxxabi/trunk/src/cxa_demangle.cpp

Modified: libcxxabi/trunk/src/cxa_demangle.cpp
URL:

http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=309349&r1=309348&r2=309349&view=diff

==
--- libcxxabi/trunk/src/cxa_demangle.cpp (original)
+++ libcxxabi/trunk/src/cxa_demangle.cpp Thu Jul 27 18:35:14 2017
@@ -896,6 +896,7 @@ public:
 case SpecialSubKind::iostream:
   return StringView("basic_iostream");
 }
+return StringView();
   }

   void printLeft(OutputStream &S) const override {
@@ -944,6 +945,7 @@ public:
 case SpecialSubKind::iostream:
   return StringView("iostream");
 }
+return StringView();
   }

   void printLeft(OutputStream &S) const override {


___
cfe-commits mailing list
cfe-commits@lists.llvm.org 
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r309650 - [demangler] Fix another bug found by oss-fuzz in r309340

[Erik Pilkington via cfe-commits]

Author: epilk
Date: Mon Jul 31 19:38:41 2017
New Revision: 309650

URL: http://llvm.org/viewvc/llvm-project?rev=309650&view=rev
Log:
[demangler] Fix another bug found by oss-fuzz in r309340

Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
libcxxabi/trunk/test/test_demangle.pass.cpp

Modified: libcxxabi/trunk/src/cxa_demangle.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=309650&r1=309649&r2=309650&view=diff
==
--- libcxxabi/trunk/src/cxa_demangle.cpp (original)
+++ libcxxabi/trunk/src/cxa_demangle.cpp Mon Jul 31 19:38:41 2017
@@ -5867,6 +5867,8 @@ parse_encoding(const char* first, const
 if (t != last && *t == 'v')
 {
 ++t;
+if (db.names.empty())
+return first;
 Node* name = db.names.back();
 db.names.pop_back();
 result = db.make(

Modified: libcxxabi/trunk/test/test_demangle.pass.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/test_demangle.pass.cpp?rev=309650&r1=309649&r2=309650&view=diff
==
--- libcxxabi/trunk/test/test_demangle.pass.cpp (original)
+++ libcxxabi/trunk/test/test_demangle.pass.cpp Mon Jul 31 19:38:41 2017
@@ -29676,6 +29676,7 @@ const char* invalid_cases[] =
 "AT__ZSiIJEEAnwscT_T__",
 "FSiIJEENT_IoE ",
 "ZTVSiIZTVSiIZTVSiIZTVSiINIJEET_T_T_T_T_ ",
+
"_ZSiIJEttvvET_v",
 };
 
 const unsigned NI = sizeof(invalid_cases) / sizeof(invalid_cases[0]);


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r309649 - [demangler] Use _LIBCPP_UNREACHABLE()

[Erik Pilkington via cfe-commits]

Author: epilk
Date: Mon Jul 31 19:38:40 2017
New Revision: 309649

URL: http://llvm.org/viewvc/llvm-project?rev=309649&view=rev
Log:
[demangler] Use _LIBCPP_UNREACHABLE()

Modified:
libcxxabi/trunk/src/cxa_demangle.cpp

Modified: libcxxabi/trunk/src/cxa_demangle.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=309649&r1=309648&r2=309649&view=diff
==
--- libcxxabi/trunk/src/cxa_demangle.cpp (original)
+++ libcxxabi/trunk/src/cxa_demangle.cpp Mon Jul 31 19:38:40 2017
@@ -896,7 +896,7 @@ public:
 case SpecialSubKind::iostream:
   return StringView("basic_iostream");
 }
-return StringView();
+_LIBCPP_UNREACHABLE();
   }
 
   void printLeft(OutputStream &S) const override {
@@ -945,7 +945,7 @@ public:
 case SpecialSubKind::iostream:
   return StringView("iostream");
 }
-return StringView();
+_LIBCPP_UNREACHABLE();
   }
 
   void printLeft(OutputStream &S) const override {


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang added a comment.

@mstorsjo I see that spec2000/eon calls __getReg, _ReadStatusReg and 
_WriteStatusReg intrinsics for ARM64. I think I would need to implement them in 
llvm. Do you know where can I find a doc explaining their behavior?


https://reviews.llvm.org/D36111



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36122: Thread Safety Analysis: fix assert_capability.

[Josh Gao via Phabricator via cfe-commits]

jmgao created this revision.

Previously, the assert_capability attribute was completely ignored by
thread safety analysis.


https://reviews.llvm.org/D36122

Files:
  include/clang/Basic/Attr.td
  lib/Analysis/ThreadSafety.cpp
  lib/Sema/SemaDeclAttr.cpp
  test/SemaCXX/warn-thread-safety-analysis.cpp


Index: test/SemaCXX/warn-thread-safety-analysis.cpp
===
--- test/SemaCXX/warn-thread-safety-analysis.cpp
+++ test/SemaCXX/warn-thread-safety-analysis.cpp
@@ -1,4 +1,5 @@
-// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -Wthread-safety 
-Wthread-safety-beta -Wno-thread-safety-negative -fcxx-exceptions %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -Wthread-safety 
-Wthread-safety-beta -Wno-thread-safety-negative -fcxx-exceptions 
-DUSE_ASSERT_CAPABILITY=0 %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -Wthread-safety 
-Wthread-safety-beta -Wno-thread-safety-negative -fcxx-exceptions 
-DUSE_ASSERT_CAPABILITY=1 %s
 
 // FIXME: should also run  %clang_cc1 -fsyntax-only -verify -Wthread-safety 
-std=c++11 -Wc++98-compat %s
 // FIXME: should also run  %clang_cc1 -fsyntax-only -verify -Wthread-safety %s
@@ -13,8 +14,15 @@
 #define ACQUIRED_BEFORE(...) __attribute__((acquired_before(__VA_ARGS__)))
 #define EXCLUSIVE_LOCK_FUNCTION(...)
__attribute__((exclusive_lock_function(__VA_ARGS__)))
 #define SHARED_LOCK_FUNCTION(...)   
__attribute__((shared_lock_function(__VA_ARGS__)))
+
+#if USE_ASSERT_CAPABILITY
+#define ASSERT_EXCLUSIVE_LOCK(...)  
__attribute__((assert_capability(__VA_ARGS__)))
+#define ASSERT_SHARED_LOCK(...) 
__attribute__((assert_shared_capability(__VA_ARGS__)))
+#else
 #define ASSERT_EXCLUSIVE_LOCK(...)  
__attribute__((assert_exclusive_lock(__VA_ARGS__)))
 #define ASSERT_SHARED_LOCK(...) 
__attribute__((assert_shared_lock(__VA_ARGS__)))
+#endif
+
 #define EXCLUSIVE_TRYLOCK_FUNCTION(...) 
__attribute__((exclusive_trylock_function(__VA_ARGS__)))
 #define SHARED_TRYLOCK_FUNCTION(...)
__attribute__((shared_trylock_function(__VA_ARGS__)))
 #define UNLOCK_FUNCTION(...)
__attribute__((unlock_function(__VA_ARGS__)))
Index: lib/Sema/SemaDeclAttr.cpp
===
--- lib/Sema/SemaDeclAttr.cpp
+++ lib/Sema/SemaDeclAttr.cpp
@@ -5686,8 +5686,12 @@
 
 static void handleAssertCapabilityAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
+  SmallVector Args;
+  if (!checkLockFunAttrCommon(S, D, Attr, Args))
+return;
+
   D->addAttr(::new (S.Context) AssertCapabilityAttr(Attr.getRange(), S.Context,
-Attr.getArgAsExpr(0),
+Args.data(), Args.size(),
 Attr.getAttributeSpellingListIndex()));
 }
 
Index: lib/Analysis/ThreadSafety.cpp
===
--- lib/Analysis/ThreadSafety.cpp
+++ lib/Analysis/ThreadSafety.cpp
@@ -1735,8 +1735,23 @@
 CapExprSet AssertLocks;
 Analyzer->getMutexIDs(AssertLocks, A, Exp, D, VD);
 for (const auto &AssertLock : AssertLocks)
-  Analyzer->addLock(FSet, llvm::make_unique(
-  AssertLock, LK_Shared, Loc, false, true),
+  Analyzer->addLock(FSet,
+llvm::make_unique(
+AssertLock, LK_Shared, Loc, false, true),
+ClassifyDiagnostic(A));
+break;
+  }
+
+  case attr::AssertCapability: {
+AssertCapabilityAttr *A = cast(At);
+CapExprSet AssertLocks;
+Analyzer->getMutexIDs(AssertLocks, A, Exp, D, VD);
+for (const auto &AssertLock : AssertLocks)
+  Analyzer->addLock(FSet,
+llvm::make_unique(
+AssertLock,
+A->isShared() ? LK_Shared : LK_Exclusive, Loc,
+false, true),
 ClassifyDiagnostic(A));
 break;
   }
Index: include/clang/Basic/Attr.td
===
--- include/clang/Basic/Attr.td
+++ include/clang/Basic/Attr.td
@@ -2138,7 +2138,7 @@
   let TemplateDependent = 1;
   let ParseArgumentsAsUnevaluated = 1;
   let DuplicatesAllowedWhileMerging = 1;
-  let Args = [ExprArgument<"Expr">];
+  let Args = [VariadicExprArgument<"Args">];
   let Accessors = [Accessor<"isShared",
 [GNU<"assert_shared_capability">,
  CXX11<"clang", "assert_shared_capability">]>];


Index: test/SemaCXX/warn-thread-safety-analysis.cpp
===
--- test/SemaCXX/warn-thread-safety-analysis.cpp
+++ test/SemaCXX/warn-thread-safety-analysis.cpp
@@ -1,4 +1,5 @@
-// RUN: %clang_cc1 -fsyntax-only 

r309640 - Use -target instead of -arch in test case.

[Akira Hatanaka via cfe-commits]

Author: ahatanak
Date: Mon Jul 31 16:08:52 2017
New Revision: 309640

URL: http://llvm.org/viewvc/llvm-project?rev=309640&view=rev
Log:
Use -target instead of -arch in test case.

Modified:
cfe/trunk/test/Driver/darwin-version.c

Modified: cfe/trunk/test/Driver/darwin-version.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/darwin-version.c?rev=309640&r1=309639&r2=309640&view=diff
==
--- cfe/trunk/test/Driver/darwin-version.c (original)
+++ cfe/trunk/test/Driver/darwin-version.c Mon Jul 31 16:08:52 2017
@@ -26,7 +26,7 @@
 
 // RUN: %clang -target armv7-apple-ios11.1 -c -### %s 2>&1 | \
 // RUN: FileCheck --check-prefix=CHECK-VERSION-IOS7 %s
-// RUN: %clang -arch armv7 -Wno-missing-sysroot -isysroot 
SDKs/iPhoneOS11.0.sdk -c -### %s 2>&1 | \
+// RUN: %clang -target armv7-apple-ios9 -Wno-missing-sysroot -isysroot 
SDKs/iPhoneOS11.0.sdk -c -### %s 2>&1 | \
 // RUN: FileCheck --check-prefix=CHECK-VERSION-IOS7 %s
 // CHECK-VERSION-IOS7: thumbv7-apple-ios10.99.99
 


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309636 - Silence warning -Wmissing-sysroot.

[Akira Hatanaka via cfe-commits]

Author: ahatanak
Date: Mon Jul 31 15:46:00 2017
New Revision: 309636

URL: http://llvm.org/viewvc/llvm-project?rev=309636&view=rev
Log:
Silence warning -Wmissing-sysroot.

Modified:
cfe/trunk/test/Driver/darwin-version.c

Modified: cfe/trunk/test/Driver/darwin-version.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/darwin-version.c?rev=309636&r1=309635&r2=309636&view=diff
==
--- cfe/trunk/test/Driver/darwin-version.c (original)
+++ cfe/trunk/test/Driver/darwin-version.c Mon Jul 31 15:46:00 2017
@@ -26,7 +26,7 @@
 
 // RUN: %clang -target armv7-apple-ios11.1 -c -### %s 2>&1 | \
 // RUN: FileCheck --check-prefix=CHECK-VERSION-IOS7 %s
-// RUN: %clang -arch armv7 -isysroot SDKs/iPhoneOS11.0.sdk -c -### %s 2>&1 | \
+// RUN: %clang -arch armv7 -Wno-missing-sysroot -isysroot 
SDKs/iPhoneOS11.0.sdk -c -### %s 2>&1 | \
 // RUN: FileCheck --check-prefix=CHECK-VERSION-IOS7 %s
 // CHECK-VERSION-IOS7: thumbv7-apple-ios10.99.99
 


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35914: [mips] Add support -m(no-)embedded-data option

[Simon Atanasyan via Phabricator via cfe-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM


https://reviews.llvm.org/D35914



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309635 - Re-apply r309622 with a fix for MSVC.

[Peter Collingbourne via cfe-commits]

Author: pcc
Date: Mon Jul 31 15:35:33 2017
New Revision: 309635

URL: http://llvm.org/viewvc/llvm-project?rev=309635&view=rev
Log:
Re-apply r309622 with a fix for MSVC.

Patch by Vlad Tsyrklevich!

Added:
cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
Modified:
cfe/trunk/lib/CodeGen/CGClass.cpp

Modified: cfe/trunk/lib/CodeGen/CGClass.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGClass.cpp?rev=309635&r1=309634&r2=309635&view=diff
==
--- cfe/trunk/lib/CodeGen/CGClass.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGClass.cpp Mon Jul 31 15:35:33 2017
@@ -2523,8 +2523,10 @@ LeastDerivedClassWithSameLayout(const CX
 void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD,
llvm::Value *VTable,
SourceLocation Loc) {
-  if (CGM.getCodeGenOpts().WholeProgramVTables &&
-  CGM.HasHiddenLTOVisibility(RD)) {
+  if (SanOpts.has(SanitizerKind::CFIVCall))
+EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
+  else if (CGM.getCodeGenOpts().WholeProgramVTables &&
+   CGM.HasHiddenLTOVisibility(RD)) {
 llvm::Metadata *MD =
 CGM.CreateMetadataIdentifierForType(QualType(RD->getTypeForDecl(), 0));
 llvm::Value *TypeId =
@@ -2536,9 +2538,6 @@ void CodeGenFunction::EmitTypeMetadataCo
{CastedVTable, TypeId});
 Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::assume), TypeTest);
   }
-
-  if (SanOpts.has(SanitizerKind::CFIVCall))
-EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
 }
 
 void CodeGenFunction::EmitVTablePtrCheckForCall(const CXXRecordDecl *RD,

Added: cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp?rev=309635&view=auto
==
--- cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp Mon Jul 31 15:35:33 2017
@@ -0,0 +1,15 @@
+// Only output llvm.assume(llvm.type.test()) if cfi-vcall is disabled and 
whole-program-vtables is enabled
+// RUN: %clang_cc1 -flto -fvisibility hidden -fsanitize=cfi-vcall 
-fwhole-program-vtables -emit-llvm -o - %s | FileCheck --check-prefix=CHECK 
--check-prefix=CFI %s
+// RUN: %clang_cc1 -flto -fvisibility hidden -fwhole-program-vtables 
-emit-llvm -o - %s | FileCheck --check-prefix=CHECK --check-prefix=NOCFI %s
+
+struct S1 {
+  virtual void f();
+};
+
+// CHECK: define{{.*}}s1f
+// CHECK: llvm.type.test
+// CFI-NOT: llvm.assume
+// NOCFI: llvm.assume
+void s1f(S1 *s1) {
+  s1->f();
+}


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

[Yan Wang via Phabricator via cfe-commits]

yawanng added a comment.

Ping.


https://reviews.llvm.org/D35743



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

[Yan Wang via Phabricator via cfe-commits]

yawanng added a comment.

Ping.


https://reviews.llvm.org/D35372



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

[Sterling Augustine via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL309634: Add powerpc64 to compiler-rt build infrastructure. 
(authored by saugustine).

Changed prior to commit:
  https://reviews.llvm.org/D36108?vs=109015&id=109017#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D36108

Files:
  compiler-rt/trunk/cmake/Modules/CompilerRTUtils.cmake
  compiler-rt/trunk/cmake/builtin-config-ix.cmake
  compiler-rt/trunk/lib/builtins/CMakeLists.txt
  compiler-rt/trunk/lib/builtins/clear_cache.c


Index: compiler-rt/trunk/lib/builtins/CMakeLists.txt
===
--- compiler-rt/trunk/lib/builtins/CMakeLists.txt
+++ compiler-rt/trunk/lib/builtins/CMakeLists.txt
@@ -458,6 +458,20 @@
 set(mips64el_SOURCES ${GENERIC_TF_SOURCES}
  ${mips_SOURCES})
 
+set(powerpc64_SOURCES
+  ppc/divtc3.c
+  ppc/fixtfdi.c
+  ppc/fixunstfdi.c
+  ppc/floatditf.c
+  ppc/floatunditf.c
+  ppc/gcc_qadd.c
+  ppc/gcc_qdiv.c
+  ppc/gcc_qmul.c
+  ppc/gcc_qsub.c
+  ppc/multc3.c
+  ${GENERIC_SOURCES})
+set(powerpc64le_SOURCES ${powerpc64_SOURCES})
+
 set(wasm32_SOURCES ${GENERIC_SOURCES})
 set(wasm64_SOURCES ${GENERIC_SOURCES})
 
Index: compiler-rt/trunk/lib/builtins/clear_cache.c
===
--- compiler-rt/trunk/lib/builtins/clear_cache.c
+++ compiler-rt/trunk/lib/builtins/clear_cache.c
@@ -165,7 +165,7 @@
   for (addr = xstart; addr < xend; addr += icache_line_size)
 __asm __volatile("ic ivau, %0" :: "r"(addr));
   __asm __volatile("isb sy");
-#elif defined (__powerpc64__) && defined(__LITTLE_ENDIAN__)
+#elif defined (__powerpc64__)
   const size_t line_size = 32;
   const size_t len = (uintptr_t)end - (uintptr_t)start;
 
Index: compiler-rt/trunk/cmake/Modules/CompilerRTUtils.cmake
===
--- compiler-rt/trunk/cmake/Modules/CompilerRTUtils.cmake
+++ compiler-rt/trunk/cmake/Modules/CompilerRTUtils.cmake
@@ -167,6 +167,8 @@
   check_symbol_exists(__i386__ "" __I386)
   check_symbol_exists(__mips__ "" __MIPS)
   check_symbol_exists(__mips64__ "" __MIPS64)
+  check_symbol_exists(__powerpc64__ "" __PPC64)
+  check_symbol_exists(__powerpc64le__ "" __PPC64LE)
   check_symbol_exists(__s390x__ "" __S390X)
   check_symbol_exists(__wasm32__ "" __WEBASSEMBLY32)
   check_symbol_exists(__wasm64__ "" __WEBASSEMBLY64)
@@ -184,6 +186,10 @@
 add_default_target_arch(mips64)
   elseif(__MIPS)
 add_default_target_arch(mips)
+  elseif(__PPC64)
+add_default_target_arch(powerpc64)
+  elseif(__PPC64LE)
+add_default_target_arch(powerpc64le)
   elseif(__S390X)
 add_default_target_arch(s390x)
   elseif(__WEBASSEMBLY32)
Index: compiler-rt/trunk/cmake/builtin-config-ix.cmake
===
--- compiler-rt/trunk/cmake/builtin-config-ix.cmake
+++ compiler-rt/trunk/cmake/builtin-config-ix.cmake
@@ -40,7 +40,7 @@
 endif()
 
 set(ALL_BUILTIN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
-${MIPS32} ${MIPS64} ${WASM32} ${WASM64})
+${MIPS32} ${MIPS64} ${PPC64} ${WASM32} ${WASM64})
 
 include(CompilerRTUtils)
 include(CompilerRTDarwinUtils)


Index: compiler-rt/trunk/lib/builtins/CMakeLists.txt
===
--- compiler-rt/trunk/lib/builtins/CMakeLists.txt
+++ compiler-rt/trunk/lib/builtins/CMakeLists.txt
@@ -458,6 +458,20 @@
 set(mips64el_SOURCES ${GENERIC_TF_SOURCES}
  ${mips_SOURCES})
 
+set(powerpc64_SOURCES
+  ppc/divtc3.c
+  ppc/fixtfdi.c
+  ppc/fixunstfdi.c
+  ppc/floatditf.c
+  ppc/floatunditf.c
+  ppc/gcc_qadd.c
+  ppc/gcc_qdiv.c
+  ppc/gcc_qmul.c
+  ppc/gcc_qsub.c
+  ppc/multc3.c
+  ${GENERIC_SOURCES})
+set(powerpc64le_SOURCES ${powerpc64_SOURCES})
+
 set(wasm32_SOURCES ${GENERIC_SOURCES})
 set(wasm64_SOURCES ${GENERIC_SOURCES})
 
Index: compiler-rt/trunk/lib/builtins/clear_cache.c
===
--- compiler-rt/trunk/lib/builtins/clear_cache.c
+++ compiler-rt/trunk/lib/builtins/clear_cache.c
@@ -165,7 +165,7 @@
   for (addr = xstart; addr < xend; addr += icache_line_size)
 __asm __volatile("ic ivau, %0" :: "r"(addr));
   __asm __volatile("isb sy");
-#elif defined (__powerpc64__) && defined(__LITTLE_ENDIAN__)
+#elif defined (__powerpc64__)
   const size_t line_size = 32;
   const size_t len = (uintptr_t)end - (uintptr_t)start;
 
Index: compiler-rt/trunk/cmake/Modules/CompilerRTUtils.cmake
===
--- compiler-rt/trunk/cmake/Modules/CompilerRTUtils.cmake
+++ compiler-rt/trunk/cmake/Modules/CompilerRTUtils.cmake
@@ -167,6 +167,8 @@
   check_symbol_exists(__i386__ "" __I386)
   check_symbol_exists(__mips__ "" __MIPS)
   check_symbol_exists(__mips64__ "" __MIPS64)
+  check_symbol_exists(__powerpc64__ "" __PPC64)
+  check_symbol_exists(__powerpc64le__ "" __PPC64LE)
   check_symbol

[PATCH] D36118: Fix creating bitcasts with wrong address space

[Matt Arsenault via Phabricator via cfe-commits]

arsenm created this revision.
Herald added subscribers: Anastasia, tpr, wdng.

In a future commit AMDGPU will start passing
aggregates directly to more functions, triggering
asserts in test/CodeGenOpenCL/addr-space-struct-arg.cl


https://reviews.llvm.org/D36118

Files:
  lib/CodeGen/CGCall.cpp


Index: lib/CodeGen/CGCall.cpp
===
--- lib/CodeGen/CGCall.cpp
+++ lib/CodeGen/CGCall.cpp
@@ -1223,7 +1223,8 @@
 //
 // FIXME: Assert that we aren't truncating non-padding bits when have 
access
 // to that information.
-Src = CGF.Builder.CreateBitCast(Src, llvm::PointerType::getUnqual(Ty));
+Src = CGF.Builder.CreateBitCast(Src,
+Ty->getPointerTo(Src.getAddressSpace()));
 return CGF.Builder.CreateLoad(Src);
   }
 
@@ -3946,7 +3947,8 @@
   Builder.CreateMemCpy(TempAlloca, Src, SrcSize);
   Src = TempAlloca;
 } else {
-  Src = Builder.CreateBitCast(Src, llvm::PointerType::getUnqual(STy));
+  Src = Builder.CreateBitCast(Src,
+  
STy->getPointerTo(Src.getAddressSpace()));
 }
 
 auto SrcLayout = CGM.getDataLayout().getStructLayout(STy);


Index: lib/CodeGen/CGCall.cpp
===
--- lib/CodeGen/CGCall.cpp
+++ lib/CodeGen/CGCall.cpp
@@ -1223,7 +1223,8 @@
 //
 // FIXME: Assert that we aren't truncating non-padding bits when have access
 // to that information.
-Src = CGF.Builder.CreateBitCast(Src, llvm::PointerType::getUnqual(Ty));
+Src = CGF.Builder.CreateBitCast(Src,
+Ty->getPointerTo(Src.getAddressSpace()));
 return CGF.Builder.CreateLoad(Src);
   }
 
@@ -3946,7 +3947,8 @@
   Builder.CreateMemCpy(TempAlloca, Src, SrcSize);
   Src = TempAlloca;
 } else {
-  Src = Builder.CreateBitCast(Src, llvm::PointerType::getUnqual(STy));
+  Src = Builder.CreateBitCast(Src,
+  STy->getPointerTo(Src.getAddressSpace()));
 }
 
 auto SrcLayout = CGM.getDataLayout().getStructLayout(STy);
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

[Sterling Augustine via Phabricator via cfe-commits]

saugustine added a comment.

In https://reviews.llvm.org/D36108#826673, @timshen wrote:

> Offline discussion discovered that __clear_cache() is not implemented for 
> powerpc64 (the big-endian target). I think it's correct to use the same 
> implementation of __clear_cache() for both endianness. With that change 
> (possibly in the same patch), this patch looks good.


Done. Thanks.


https://reviews.llvm.org/D36108



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309633 - [Driver] Make sure the deployment target is earlier than iOS 11 when

[Akira Hatanaka via cfe-commits]

Author: ahatanak
Date: Mon Jul 31 15:19:34 2017
New Revision: 309633

URL: http://llvm.org/viewvc/llvm-project?rev=309633&view=rev
Log:
[Driver] Make sure the deployment target is earlier than iOS 11 when
it is inferred from -isysroot.

This fixes a change that was inadvertently introduced in r309607.

rdar://problem/32230613

Modified:
cfe/trunk/lib/Driver/ToolChains/Darwin.cpp
cfe/trunk/test/Driver/darwin-version.c

Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Darwin.cpp?rev=309633&r1=309632&r2=309633&view=diff
==
--- cfe/trunk/lib/Driver/ToolChains/Darwin.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains/Darwin.cpp Mon Jul 31 15:19:34 2017
@@ -1174,13 +1174,12 @@ void Darwin::AddDeploymentTarget(Derived
   unsigned Major, Minor, Micro;
   bool HadExtra;
 
-  // iOS 10 is the maximum deployment target for 32-bit targets.
-  if (iOSVersion && getTriple().isArch32Bit() &&
-  Driver::GetReleaseVersion(iOSVersion->getValue(), Major, Minor, Micro,
-HadExtra) &&
-  Major > 10)
-getDriver().Diag(diag::warn_invalid_ios_deployment_target)
-<< iOSVersion->getAsString(Args);
+  // The iOS deployment target that is explicitly specified via a command line
+  // option or an environment variable.
+  std::string ExplicitIOSDeploymentTargetStr;
+
+  if (iOSVersion)
+ExplicitIOSDeploymentTargetStr = iOSVersion->getAsString(Args);
 
   // Add a macro to differentiate between m(iphone|tv|watch)os-version-min=X.Y 
and
   // -m(iphone|tv|watch)simulator-version-min=X.Y.
@@ -1223,13 +1222,9 @@ void Darwin::AddDeploymentTarget(Derived
 if (char *env = ::getenv("WATCHOS_DEPLOYMENT_TARGET"))
   WatchOSTarget = env;
 
-// iOS 10 is the maximum deployment target for 32-bit targets.
-if (!iOSTarget.empty() && getTriple().isArch32Bit() &&
-Driver::GetReleaseVersion(iOSTarget.c_str(), Major, Minor, Micro,
-  HadExtra) &&
-Major > 10)
-  getDriver().Diag(diag::warn_invalid_ios_deployment_target)
-  << std::string("IPHONEOS_DEPLOYMENT_TARGET=") + iOSTarget;
+if (!iOSTarget.empty())
+  ExplicitIOSDeploymentTargetStr =
+  std::string("IPHONEOS_DEPLOYMENT_TARGET=") + iOSTarget;
 
 // If there is no command-line argument to specify the Target version and
 // no environment variable defined, see if we can set the default based
@@ -1298,15 +1293,6 @@ void Darwin::AddDeploymentTarget(Derived
   break;
 case llvm::Triple::IOS:
   getTriple().getiOSVersion(Major, Minor, Micro);
-
-  // iOS 10 is the maximum deployment target for 32-bit targets. If the
-  // inferred deployment target is iOS 11 or later, set it to 10.99.
-  if (getTriple().isArch32Bit() && Major >= 11) {
-Major = 10;
-Minor = 99;
-Micro = 99;
-  }
-
   OSTarget = &iOSTarget;
   break;
 case llvm::Triple::TvOS:
@@ -1402,6 +1388,20 @@ void Darwin::AddDeploymentTarget(Derived
 HadExtra || Major >= 100 || Minor >= 100 || Micro >= 100)
   getDriver().Diag(diag::err_drv_invalid_version_number)
   << iOSVersion->getAsString(Args);
+// For 32-bit targets, the deployment target for iOS has to be earlier than
+// iOS 11.
+if (getTriple().isArch32Bit() && Major >= 11) {
+  // If the deployment target is explicitly specified, print a diagnostic.
+  if (!ExplicitIOSDeploymentTargetStr.empty()) {
+getDriver().Diag(diag::warn_invalid_ios_deployment_target)
+<< ExplicitIOSDeploymentTargetStr;
+  // Otherwise, set it to 10.99.99.
+  } else {
+Major = 10;
+Minor = 99;
+Micro = 99;
+  }
+}
   } else if (Platform == TvOS) {
 if (!Driver::GetReleaseVersion(TvOSVersion->getValue(), Major, Minor,
Micro, HadExtra) || HadExtra ||

Modified: cfe/trunk/test/Driver/darwin-version.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/darwin-version.c?rev=309633&r1=309632&r2=309633&view=diff
==
--- cfe/trunk/test/Driver/darwin-version.c (original)
+++ cfe/trunk/test/Driver/darwin-version.c Mon Jul 31 15:19:34 2017
@@ -26,6 +26,8 @@
 
 // RUN: %clang -target armv7-apple-ios11.1 -c -### %s 2>&1 | \
 // RUN: FileCheck --check-prefix=CHECK-VERSION-IOS7 %s
+// RUN: %clang -arch armv7 -isysroot SDKs/iPhoneOS11.0.sdk -c -### %s 2>&1 | \
+// RUN: FileCheck --check-prefix=CHECK-VERSION-IOS7 %s
 // CHECK-VERSION-IOS7: thumbv7-apple-ios10.99.99
 
 // RUN: env IPHONEOS_DEPLOYMENT_TARGET=11.0 \


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

[Sterling Augustine via Phabricator via cfe-commits]

saugustine updated this revision to Diff 109015.
saugustine added a comment.

- The current powerpc implementation of clear cache works for big endian.


https://reviews.llvm.org/D36108

Files:
  compiler-rt/cmake/Modules/CompilerRTUtils.cmake
  compiler-rt/cmake/builtin-config-ix.cmake
  compiler-rt/lib/builtins/CMakeLists.txt
  compiler-rt/lib/builtins/clear_cache.c


Index: compiler-rt/lib/builtins/clear_cache.c
===
--- compiler-rt/lib/builtins/clear_cache.c
+++ compiler-rt/lib/builtins/clear_cache.c
@@ -165,7 +165,7 @@
   for (addr = xstart; addr < xend; addr += icache_line_size)
 __asm __volatile("ic ivau, %0" :: "r"(addr));
   __asm __volatile("isb sy");
-#elif defined (__powerpc64__) && defined(__LITTLE_ENDIAN__)
+#elif defined (__powerpc64__)
   const size_t line_size = 32;
   const size_t len = (uintptr_t)end - (uintptr_t)start;
 
Index: compiler-rt/lib/builtins/CMakeLists.txt
===
--- compiler-rt/lib/builtins/CMakeLists.txt
+++ compiler-rt/lib/builtins/CMakeLists.txt
@@ -458,6 +458,20 @@
 set(mips64el_SOURCES ${GENERIC_TF_SOURCES}
  ${mips_SOURCES})
 
+set(powerpc64_SOURCES
+  ppc/divtc3.c
+  ppc/fixtfdi.c
+  ppc/fixunstfdi.c
+  ppc/floatditf.c
+  ppc/floatunditf.c
+  ppc/gcc_qadd.c
+  ppc/gcc_qdiv.c
+  ppc/gcc_qmul.c
+  ppc/gcc_qsub.c
+  ppc/multc3.c
+  ${GENERIC_SOURCES})
+set(powerpc64le_SOURCES ${powerpc64_SOURCES})
+
 set(wasm32_SOURCES ${GENERIC_SOURCES})
 set(wasm64_SOURCES ${GENERIC_SOURCES})
 
Index: compiler-rt/cmake/builtin-config-ix.cmake
===
--- compiler-rt/cmake/builtin-config-ix.cmake
+++ compiler-rt/cmake/builtin-config-ix.cmake
@@ -40,7 +40,7 @@
 endif()
 
 set(ALL_BUILTIN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
-${MIPS32} ${MIPS64} ${WASM32} ${WASM64})
+${MIPS32} ${MIPS64} ${PPC64} ${WASM32} ${WASM64})
 
 include(CompilerRTUtils)
 include(CompilerRTDarwinUtils)
Index: compiler-rt/cmake/Modules/CompilerRTUtils.cmake
===
--- compiler-rt/cmake/Modules/CompilerRTUtils.cmake
+++ compiler-rt/cmake/Modules/CompilerRTUtils.cmake
@@ -167,6 +167,8 @@
   check_symbol_exists(__i386__ "" __I386)
   check_symbol_exists(__mips__ "" __MIPS)
   check_symbol_exists(__mips64__ "" __MIPS64)
+  check_symbol_exists(__powerpc64__ "" __PPC64)
+  check_symbol_exists(__powerpc64le__ "" __PPC64LE)
   check_symbol_exists(__s390x__ "" __S390X)
   check_symbol_exists(__wasm32__ "" __WEBASSEMBLY32)
   check_symbol_exists(__wasm64__ "" __WEBASSEMBLY64)
@@ -184,6 +186,10 @@
 add_default_target_arch(mips64)
   elseif(__MIPS)
 add_default_target_arch(mips)
+  elseif(__PPC64)
+add_default_target_arch(powerpc64)
+  elseif(__PPC64LE)
+add_default_target_arch(powerpc64le)
   elseif(__S390X)
 add_default_target_arch(s390x)
   elseif(__WEBASSEMBLY32)


Index: compiler-rt/lib/builtins/clear_cache.c
===
--- compiler-rt/lib/builtins/clear_cache.c
+++ compiler-rt/lib/builtins/clear_cache.c
@@ -165,7 +165,7 @@
   for (addr = xstart; addr < xend; addr += icache_line_size)
 __asm __volatile("ic ivau, %0" :: "r"(addr));
   __asm __volatile("isb sy");
-#elif defined (__powerpc64__) && defined(__LITTLE_ENDIAN__)
+#elif defined (__powerpc64__)
   const size_t line_size = 32;
   const size_t len = (uintptr_t)end - (uintptr_t)start;
 
Index: compiler-rt/lib/builtins/CMakeLists.txt
===
--- compiler-rt/lib/builtins/CMakeLists.txt
+++ compiler-rt/lib/builtins/CMakeLists.txt
@@ -458,6 +458,20 @@
 set(mips64el_SOURCES ${GENERIC_TF_SOURCES}
  ${mips_SOURCES})
 
+set(powerpc64_SOURCES
+  ppc/divtc3.c
+  ppc/fixtfdi.c
+  ppc/fixunstfdi.c
+  ppc/floatditf.c
+  ppc/floatunditf.c
+  ppc/gcc_qadd.c
+  ppc/gcc_qdiv.c
+  ppc/gcc_qmul.c
+  ppc/gcc_qsub.c
+  ppc/multc3.c
+  ${GENERIC_SOURCES})
+set(powerpc64le_SOURCES ${powerpc64_SOURCES})
+
 set(wasm32_SOURCES ${GENERIC_SOURCES})
 set(wasm64_SOURCES ${GENERIC_SOURCES})
 
Index: compiler-rt/cmake/builtin-config-ix.cmake
===
--- compiler-rt/cmake/builtin-config-ix.cmake
+++ compiler-rt/cmake/builtin-config-ix.cmake
@@ -40,7 +40,7 @@
 endif()
 
 set(ALL_BUILTIN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
-${MIPS32} ${MIPS64} ${WASM32} ${WASM64})
+${MIPS32} ${MIPS64} ${PPC64} ${WASM32} ${WASM64})
 
 include(CompilerRTUtils)
 include(CompilerRTDarwinUtils)
Index: compiler-rt/cmake/Modules/CompilerRTUtils.cmake
===
--- compiler-rt/cmake/Modules/CompilerRTUtils.cmake
+++ compiler-rt/cmake/Modules/CompilerRTUtils.cmake
@@ -167,6 +167,8 @@
   check_symbol_exists(__i386__ "" __I386)
   check_symbol_exists(_

[PATCH] D34158: For standards compatibility, preinclude if the file is available

[Melanie Blower via Phabricator via cfe-commits]

mibintc updated this revision to Diff 108999.
mibintc added a comment.

This patch responds to @fedor.sergeev 's feedback from earlier today. This is a 
change to the test case test/Driver/stdc-predef.c in the situation that the 
system does not supply a version of stdc-predef.h. Fedor had suggested an 
option like -H which traces the include files, but the file stdc-predef.h does 
not appear in the -H standard include tracing even if it is available on the 
host system. Instead for this case I preprocess the simple test file, with 
sysroot pointing to a filesystem missing the file stdc-predef.h, and verify 
with FileCheck that the string stdc-predef.h doesn't appear in the preprocessed 
output.


Repository:
  rL LLVM

https://reviews.llvm.org/D34158

Files:
  include/clang/Driver/CC1Options.td
  include/clang/Lex/PreprocessorOptions.h
  lib/Driver/ToolChains/Clang.cpp
  lib/Frontend/CompilerInvocation.cpp
  lib/Frontend/InitPreprocessor.cpp
  test/Driver/Inputs/stdc-predef/usr/include/stdc-predef.h
  test/Driver/clang_cpp.c
  test/Driver/crash-report-header.h
  test/Driver/crash-report-spaces.c
  test/Driver/crash-report.c
  test/Driver/rewrite-legacy-objc.m
  test/Driver/rewrite-map-in-diagnostics.c
  test/Driver/rewrite-objc.m
  test/Driver/stdc-predef-not.c
  test/Driver/stdc-predef.c
  test/Index/IBOutletCollection.m
  test/Index/annotate-macro-args.m
  test/Index/annotate-tokens-pp.c
  test/Index/annotate-tokens.c
  test/Index/c-index-getCursor-test.m
  test/Index/get-cursor-macro-args.m
  test/Index/get-cursor.cpp
  test/Preprocessor/ignore-pragmas.c
  unittests/Tooling/TestVisitor.h

Index: lib/Driver/ToolChains/Clang.cpp
===
--- lib/Driver/ToolChains/Clang.cpp
+++ lib/Driver/ToolChains/Clang.cpp
@@ -3243,6 +3243,11 @@
   KernelOrKext) {
 CmdArgs.push_back("-ffreestanding");
 IsHosted = false;
+  } else {
+// For standards compliance, clang will preinclude 
+// -ffreestanding suppresses this behavior.
+CmdArgs.push_back("-fsystem-include-if-exists");
+CmdArgs.push_back("stdc-predef.h");
   }
 
   // Forward -f (flag) options which we can pass directly.
Index: lib/Frontend/CompilerInvocation.cpp
===
--- lib/Frontend/CompilerInvocation.cpp
+++ lib/Frontend/CompilerInvocation.cpp
@@ -2503,6 +2503,10 @@
   for (const Arg *A : Args.filtered(OPT_chain_include))
 Opts.ChainedIncludes.emplace_back(A->getValue());
 
+  // Add the ordered list of -fsystem-include-if-exists.
+  for (const Arg *A : Args.filtered(OPT_fsystem_include_if_exists))
+Opts.FSystemIncludeIfExists.emplace_back(A->getValue());
+
   for (const Arg *A : Args.filtered(OPT_remap_file)) {
 std::pair Split = StringRef(A->getValue()).split(';');
 
Index: lib/Frontend/InitPreprocessor.cpp
===
--- lib/Frontend/InitPreprocessor.cpp
+++ lib/Frontend/InitPreprocessor.cpp
@@ -69,6 +69,15 @@
   Builder.append(Twine("#include \"") + File + "\"");
 }
 
+/// AddImplicitSystemIncludeIfExists - Add an implicit system \#include of the 
+/// specified file to the predefines buffer: precheck with __has_include.
+static void AddImplicitSystemIncludeIfExists(MacroBuilder &Builder, 
+ StringRef File) {
+  Builder.append(Twine("#if __has_include( <") + File + ">)");
+  Builder.append(Twine("#include <") + File + ">");
+  Builder.append(Twine("#endif"));
+}
+
 static void AddImplicitIncludeMacros(MacroBuilder &Builder, StringRef File) {
   Builder.append(Twine("#__include_macros \"") + File + "\"");
   // Marker token to stop the __include_macros fetch loop.
@@ -1091,6 +1100,13 @@
   // Exit the command line and go back to  (2 is LC_LEAVE).
   if (!PP.getLangOpts().AsmPreprocessor)
 Builder.append("# 1 \"\" 2");
+  
+  // Process -fsystem-include-if-exists directives.
+  for (unsigned i = 0, 
+   e = InitOpts.FSystemIncludeIfExists.size(); i != e; ++i) {
+const std::string &Path = InitOpts.FSystemIncludeIfExists[i];
+AddImplicitSystemIncludeIfExists(Builder, Path);
+  }
 
   // If -imacros are specified, include them now.  These are processed before
   // any -include directives.
Index: unittests/Tooling/TestVisitor.h
===
--- unittests/Tooling/TestVisitor.h
+++ unittests/Tooling/TestVisitor.h
@@ -52,6 +52,7 @@
   /// \brief Runs the current AST visitor over the given code.
   bool runOver(StringRef Code, Language L = Lang_CXX) {
 std::vector Args;
+Args.push_back("-ffreestanding");
 switch (L) {
   case Lang_C:
 Args.push_back("-x");
Index: include/clang/Driver/CC1Options.td
===
--- include/clang/Driver/CC1Options.td
+++ include/clang/Driver/CC1Options.td
@@ -738,6 +738,8 @@
   HelpText<"Use specified token cache file">;
 def 

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

[Tim Shen via Phabricator via cfe-commits]

timshen accepted this revision.
timshen added a comment.
This revision is now accepted and ready to land.

Offline discussion discovered that __clear_cache() is not implemented for 
powerpc64 (the big-endian target). I think it's correct to use the same 
implementation of __clear_cache() for both endianness. With that change 
(possibly in the same patch), this patch looks good.


https://reviews.llvm.org/D36108



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D34158: For standards compatibility, preinclude if the file is available

[Blower, Melanie via cfe-commits]

 
fedor.sergeev added inline comments.



Comment at: test/Driver/stdc-predef.c:15
+  /* In this test, the file stdc-predef.h is missing from the 
+installation */ #if _STDC_PREDEF_H
+  #error "stdc-predef.h should not be included"

I would rather see a real check on include file inclusion (say, checking -H 
output) than a check for a macro.
Exact macro guard name is not a public interface at all. You might be lucky 
with current stdc-predef.h on Linux, but on other platforms it could be named 
differently.
> Thanks Fedor.  I am uploading a new patch with an updated version of this 
> test case. Please see comments in the new patch.

Repository:
  rL LLVM

https://reviews.llvm.org/D34158



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang added inline comments.



Comment at: include/clang/Basic/BuiltinsAArch64.def:49
 // Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")

mstorsjo wrote:
> mgrang wrote:
> > mstorsjo wrote:
> > > Shouldn't these be limited to MSVC mode only? Have a look at 
> > > `BuiltinsARM.def`, where there's cases like `LANGBUILTIN(__dmb, "vUi", 
> > > "nc", ALL_MS_LANGUAGES)` instead.
> > I do see LANGBUILTIN in BuiltinsARM.def however it is defined as follows:
> > 
> > ```
> > #   define LANGBUILTIN(ID, TYPE, ATTRS, BUILTIN_LANG) BUILTIN(ID, TYPE, 
> > ATTRS)
> > ```
> > 
> > So it seems the BUILTIN_LANG is never really used. Moreover, using 
> > LANGBUILTIN in BuiltinsAArch64.def I run into compilation error like this:
> > ```
> > BuiltinsAArch64.def:65:12: error: expected '= constant-expression' or end 
> > of enumerator definition
> > LANGBUILTIN(__dmb, "vUi", "nc", ALL_MS_LANGUAGES)
> > ```
> That's only the fallback definition of `LANGBUILTIN`. The `.def` file is 
> included multiple times in different contexts. Have a look at e.g. 
> `lib/Basic/Targets/ARM.cpp` and look for `BuiltinsARM.def` there, and you'll 
> find a different implementation of `LANGBUILTIN`.
Got it! Thanks Martin. I will push an update.


https://reviews.llvm.org/D36111



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D35783: Ignore shadowing for declarations coming from within macros.

[Roman Lebedev via cfe-commits]

On Mon, Jul 31, 2017 at 9:57 PM, David Blaikie  wrote:
>
>
> On Tue, Jul 25, 2017 at 1:19 AM Roman Lebedev via Phabricator via
> cfe-commits  wrote:
>>
>> lebedev.ri added a comment.
>>
>> How does this relate to the gcc behavior?
>> I suspect not everyone would want to have this relaxed `-Wshadow` mode.
>
>
> Generally I think the goal hasn't been to allow a clang user to keep their
> code GCC warning clean - if a warning has too many false positives, it
> can/will be changed in clang, even if it means it misses cases GCC will
> flag. (for example -Wreturn-type, which pops up a lot in the LLVM codebase
> when it fires on code that's probably unreachable that Clang is nice enough
> to assume won't be reached (code after a fully covered switch over enum,
> where each case returns))
>
> Though it's not unheard of to bisect the diagnostic space to provide these
> variations if suitable - but I wouldn't suggest doing so 'just' for
> compatibility with GCC.
Makes sense.

>>
>> Perhaps it could be hidden under some new flag, which is not going to be
>> automatically enabled by `-Weverything`.
>
>
> Nothing is ever not going to be automatically enabled by -Weverything (the
> intent is that it's really, always, everything). Or perhaps you meant -Wall?
No, i understand that, and i quite like that, but i meant -Weverything, do
read the second part: -Weverything would enable a NOP flag, but when
the flag is explicitly disabled like -Wno-.., THEN this exception is enabled.
I'm not sure if it is doable in llvm.
>...

>> Like, `-Wshadow-in-macros` which does nothing compared to `-Wshadow`, and
>> then `-Wno-shadow-in-macros` which enables this relaxed mode?

>>
>> https://reviews.llvm.org/D35783
Roman.

>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309626 - Move RTEMS to OSTargets.h

[Walter Lee via cfe-commits]

Author: waltl
Date: Mon Jul 31 14:00:16 2017
New Revision: 309626

URL: http://llvm.org/viewvc/llvm-project?rev=309626&view=rev
Log:
Move RTEMS to OSTargets.h

Differential Revision: https://reviews.llvm.org/D36106

Modified:
cfe/trunk/lib/Basic/Targets/OSTargets.h
cfe/trunk/lib/Basic/Targets/X86.h

Modified: cfe/trunk/lib/Basic/Targets/OSTargets.h
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets/OSTargets.h?rev=309626&r1=309625&r2=309626&view=diff
==
--- cfe/trunk/lib/Basic/Targets/OSTargets.h (original)
+++ cfe/trunk/lib/Basic/Targets/OSTargets.h Mon Jul 31 14:00:16 2017
@@ -495,6 +495,40 @@ public:
   }
 };
 
+// RTEMS Target
+template 
+class LLVM_LIBRARY_VISIBILITY RTEMSTargetInfo : public OSTargetInfo {
+protected:
+  void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple,
+MacroBuilder &Builder) const override {
+// RTEMS defines; list based off of gcc output
+
+Builder.defineMacro("__rtems__");
+Builder.defineMacro("__ELF__");
+  }
+
+public:
+  RTEMSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
+  : OSTargetInfo(Triple, Opts) {
+switch (Triple.getArch()) {
+default:
+case llvm::Triple::x86:
+  // this->MCountName = ".mcount";
+  break;
+case llvm::Triple::mips:
+case llvm::Triple::mipsel:
+case llvm::Triple::ppc:
+case llvm::Triple::ppc64:
+case llvm::Triple::ppc64le:
+  // this->MCountName = "_mcount";
+  break;
+case llvm::Triple::arm:
+  // this->MCountName = "__mcount";
+  break;
+}
+  }
+};
+
 // Solaris target
 template 
 class LLVM_LIBRARY_VISIBILITY SolarisTargetInfo : public OSTargetInfo {

Modified: cfe/trunk/lib/Basic/Targets/X86.h
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets/X86.h?rev=309626&r1=309625&r2=309626&view=diff
==
--- cfe/trunk/lib/Basic/Targets/X86.h (original)
+++ cfe/trunk/lib/Basic/Targets/X86.h Mon Jul 31 14:00:16 2017
@@ -773,40 +773,6 @@ public:
   bool allowsLargerPreferedTypeAlignment() const override { return false; }
 };
 
-// RTEMS Target
-template 
-class LLVM_LIBRARY_VISIBILITY RTEMSTargetInfo : public OSTargetInfo {
-protected:
-  void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple,
-MacroBuilder &Builder) const override {
-// RTEMS defines; list based off of gcc output
-
-Builder.defineMacro("__rtems__");
-Builder.defineMacro("__ELF__");
-  }
-
-public:
-  RTEMSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
-  : OSTargetInfo(Triple, Opts) {
-switch (Triple.getArch()) {
-default:
-case llvm::Triple::x86:
-  // this->MCountName = ".mcount";
-  break;
-case llvm::Triple::mips:
-case llvm::Triple::mipsel:
-case llvm::Triple::ppc:
-case llvm::Triple::ppc64:
-case llvm::Triple::ppc64le:
-  // this->MCountName = "_mcount";
-  break;
-case llvm::Triple::arm:
-  // this->MCountName = "__mcount";
-  break;
-}
-  }
-};
-
 // x86-32 RTEMS target
 class LLVM_LIBRARY_VISIBILITY RTEMSX86_32TargetInfo : public X86_32TargetInfo {
 public:


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.



Comment at: include/clang/Basic/BuiltinsAArch64.def:49
 // Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")

mgrang wrote:
> mstorsjo wrote:
> > Shouldn't these be limited to MSVC mode only? Have a look at 
> > `BuiltinsARM.def`, where there's cases like `LANGBUILTIN(__dmb, "vUi", 
> > "nc", ALL_MS_LANGUAGES)` instead.
> I do see LANGBUILTIN in BuiltinsARM.def however it is defined as follows:
> 
> ```
> #   define LANGBUILTIN(ID, TYPE, ATTRS, BUILTIN_LANG) BUILTIN(ID, TYPE, ATTRS)
> ```
> 
> So it seems the BUILTIN_LANG is never really used. Moreover, using 
> LANGBUILTIN in BuiltinsAArch64.def I run into compilation error like this:
> ```
> BuiltinsAArch64.def:65:12: error: expected '= constant-expression' or end of 
> enumerator definition
> LANGBUILTIN(__dmb, "vUi", "nc", ALL_MS_LANGUAGES)
> ```
That's only the fallback definition of `LANGBUILTIN`. The `.def` file is 
included multiple times in different contexts. Have a look at e.g. 
`lib/Basic/Targets/ARM.cpp` and look for `BuiltinsARM.def` there, and you'll 
find a different implementation of `LANGBUILTIN`.


https://reviews.llvm.org/D36111



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35894: [clangd] Code hover for Clangd

[William Enright via Phabricator via cfe-commits]

Nebiroth updated this revision to Diff 108997.
Nebiroth added a comment.

Implemention of Code Hover as described in LSP definition.
Removed unintentional changes to formatting.
Removed file id field in Location struct.


https://reviews.llvm.org/D35894

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/ClangdUnit.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  clangd/ProtocolHandlers.cpp
  clangd/ProtocolHandlers.h
  clangd/clients/clangd-vscode/src/extension.ts
  test/clangd/hover.test

Index: test/clangd/hover.test
===
--- /dev/null
+++ test/clangd/hover.test
@@ -0,0 +1,26 @@
+# RUN: clangd -run-synchronously < %s | FileCheck %s
+# It is absolutely vital that this file has CRLF line endings.
+#
+Content-Length: 125
+
+{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
+
+Content-Length: 172
+
+{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///main.cpp","languageId":"cpp","version":1,"text":"int main() {\nint a;\na;\n}\n"}}}
+
+Content-Length: 143
+
+{"jsonrpc":"2.0","id":1,"method":"textDocument/hover","params":{"textDocument":{"uri":"file:///main.cpp"},"position":{"line":0,"character":5}}}
+# Go to local variable
+# CHECK: {"jsonrpc":"2.0","id":1,"result":{"contents": {"language": "C++", "value": "int main() {\nint a;\na;\n}"}, "range": {"start": {"line": 0, "character": 0}, "end": {"line": 3, "character": 1
+
+Content-Length: 143
+
+{"jsonrpc":"2.0","id":1,"method":"textDocument/hover","params":{"textDocument":{"uri":"file:///main.cpp"},"position":{"line":1,"character":5}}}
+# Go to local variable
+# CHECK: {"jsonrpc":"2.0","id":1,"result":{"contents": {"language": "C++", "value": "int a"}, "range": {"start": {"line": 1, "character": 0}, "end": {"line": 1, "character": 5
+
+Content-Length: 44
+
+{"jsonrpc":"2.0","id":3,"method":"shutdown"}
Index: clangd/clients/clangd-vscode/src/extension.ts
===
--- clangd/clients/clangd-vscode/src/extension.ts
+++ clangd/clients/clangd-vscode/src/extension.ts
@@ -1,5 +1,6 @@
 import * as vscode from 'vscode';
 import * as vscodelc from 'vscode-languageclient';
+import * as vscodejsonrpc from 'vscode-jsonrpc';
 
 /**
  * Method to get workspace configuration option
Index: clangd/ProtocolHandlers.h
===
--- clangd/ProtocolHandlers.h
+++ clangd/ProtocolHandlers.h
@@ -48,6 +48,8 @@
 JSONOutput &Out) = 0;
   virtual void onGoToDefinition(TextDocumentPositionParams Params, StringRef ID,
 JSONOutput &Out) = 0;
+  virtual void onCodeHover(TextDocumentPositionParams Params, StringRef ID,
+JSONOutput &Out) = 0;
 };
 
 void regiterCallbackHandlers(JSONRPCDispatcher &Dispatcher, JSONOutput &Out,
Index: clangd/ProtocolHandlers.cpp
===
--- clangd/ProtocolHandlers.cpp
+++ clangd/ProtocolHandlers.cpp
@@ -204,6 +204,24 @@
   ProtocolCallbacks &Callbacks;
 };
 
+struct CodeHoverHandler : Handler {
+  CodeHoverHandler(JSONOutput &Output, ProtocolCallbacks &Callbacks)
+  : Handler(Output), Callbacks(Callbacks) {}
+
+  void handleMethod(llvm::yaml::MappingNode *Params, StringRef ID) override {
+auto TDPP = TextDocumentPositionParams::parse(Params);
+if (!TDPP) {
+  Output.log("Failed to decode TextDocumentPositionParams!\n");
+  return;
+}
+
+Callbacks.onCodeHover(*TDPP, ID, Output);
+  }
+
+private:
+  ProtocolCallbacks &Callbacks;
+};
+
 } // namespace
 
 void clangd::regiterCallbackHandlers(JSONRPCDispatcher &Dispatcher,
@@ -239,4 +257,7 @@
   llvm::make_unique(Out, Callbacks));
   Dispatcher.registerHandler("textDocument/definition",
   llvm::make_unique(Out, Callbacks));
+  Dispatcher.registerHandler(
+  "textDocument/hover",
+  llvm::make_unique(Out, Callbacks));
 }
Index: clangd/Protocol.h
===
--- clangd/Protocol.h
+++ clangd/Protocol.h
@@ -23,6 +23,7 @@
 
 #include "llvm/ADT/Optional.h"
 #include "llvm/Support/YAMLParser.h"
+#include "clang/Basic/SourceLocation.h"
 #include 
 #include 
 
@@ -304,7 +305,59 @@
   parse(llvm::yaml::MappingNode *Params);
 };
 
-/// The kind of a completion entry.
+struct MarkedString {
+  /**
+ * MarkedString can be used to render human readable text. It is either a
+ * markdown string
+ * or a code-block that provides a language and a code snippet. The language
+ * identifier
+ * is sematically equal to the optional language identifier in fenced code
+ * blocks in GitHub
+ * issues. See
+ * https://help.github.com/articles/creating-and-highlighting-code-blocks/#syntax-highlighting
+ *
+ * The pair of a language and a value is an equivalent to markd

[PATCH] D35894: [clangd] Code hover for Clangd

[William Enright via Phabricator via cfe-commits]

Nebiroth added a comment.

I had missed a typo in the code, should be fixed and compiling properly now.


https://reviews.llvm.org/D35894



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309624 - Revert r309622, "Fix logic for generating llvm.type.test()s"

[Peter Collingbourne via cfe-commits]

Author: pcc
Date: Mon Jul 31 13:53:16 2017
New Revision: 309624

URL: http://llvm.org/viewvc/llvm-project?rev=309624&view=rev
Log:
Revert r309622, "Fix logic for generating llvm.type.test()s"

Caused a bot test failure:
http://bb.pgr.jp/builders/test-clang-msc-x64-on-i686-linux-RA/builds/5325

Removed:
cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
Modified:
cfe/trunk/lib/CodeGen/CGClass.cpp

Modified: cfe/trunk/lib/CodeGen/CGClass.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGClass.cpp?rev=309624&r1=309623&r2=309624&view=diff
==
--- cfe/trunk/lib/CodeGen/CGClass.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGClass.cpp Mon Jul 31 13:53:16 2017
@@ -2523,10 +2523,8 @@ LeastDerivedClassWithSameLayout(const CX
 void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD,
llvm::Value *VTable,
SourceLocation Loc) {
-  if (SanOpts.has(SanitizerKind::CFIVCall))
-EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
-  else if (CGM.getCodeGenOpts().WholeProgramVTables &&
-   CGM.HasHiddenLTOVisibility(RD)) {
+  if (CGM.getCodeGenOpts().WholeProgramVTables &&
+  CGM.HasHiddenLTOVisibility(RD)) {
 llvm::Metadata *MD =
 CGM.CreateMetadataIdentifierForType(QualType(RD->getTypeForDecl(), 0));
 llvm::Value *TypeId =
@@ -2538,6 +2536,9 @@ void CodeGenFunction::EmitTypeMetadataCo
{CastedVTable, TypeId});
 Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::assume), TypeTest);
   }
+
+  if (SanOpts.has(SanitizerKind::CFIVCall))
+EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
 }
 
 void CodeGenFunction::EmitVTablePtrCheckForCall(const CXXRecordDecl *RD,

Removed: cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp?rev=309623&view=auto
==
--- cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp (removed)
@@ -1,15 +0,0 @@
-// Only output llvm.assume(llvm.type.test()) if cfi-vcall is disabled and 
whole-program-vtables is enabled
-// RUN: %clang_cc1 -fvisibility hidden -fsanitize=cfi-vcall 
-fwhole-program-vtables -emit-llvm -o - %s | FileCheck --check-prefix=CHECK 
--check-prefix=CFI %s
-// RUN: %clang_cc1 -fvisibility hidden -fwhole-program-vtables -emit-llvm -o - 
%s | FileCheck --check-prefix=CHECK --check-prefix=NOCFI %s
-
-struct S1 {
-  virtual void f();
-};
-
-// CHECK: define{{.*}}s1f
-// CHECK: llvm.type.test
-// CFI-NOT: llvm.assume
-// NOCFI: llvm.assume
-void s1f(S1 *s1) {
-  s1->f();
-}


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang added inline comments.



Comment at: include/clang/Basic/BuiltinsAArch64.def:49
 // Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")

mstorsjo wrote:
> Shouldn't these be limited to MSVC mode only? Have a look at 
> `BuiltinsARM.def`, where there's cases like `LANGBUILTIN(__dmb, "vUi", "nc", 
> ALL_MS_LANGUAGES)` instead.
I do see LANGBUILTIN in BuiltinsARM.def however it is defined as follows:

```
#   define LANGBUILTIN(ID, TYPE, ATTRS, BUILTIN_LANG) BUILTIN(ID, TYPE, ATTRS)
```

So it seems the BUILTIN_LANG is never really used. Moreover, using LANGBUILTIN 
in BuiltinsAArch64.def I run into compilation error like this:
```
BuiltinsAArch64.def:65:12: error: expected '= constant-expression' or end of 
enumerator definition
LANGBUILTIN(__dmb, "vUi", "nc", ALL_MS_LANGUAGES)
```


https://reviews.llvm.org/D36111



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36013: Fix logic for generating llvm.type.test()s

[Peter Collingbourne via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL309622: Fix logic for generating llvm.type.test()s (authored 
by pcc).

Changed prior to commit:
  https://reviews.llvm.org/D36013?vs=108702&id=108994#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D36013

Files:
  cfe/trunk/lib/CodeGen/CGClass.cpp
  cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp


Index: cfe/trunk/lib/CodeGen/CGClass.cpp
===
--- cfe/trunk/lib/CodeGen/CGClass.cpp
+++ cfe/trunk/lib/CodeGen/CGClass.cpp
@@ -2523,8 +2523,10 @@
 void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD,
llvm::Value *VTable,
SourceLocation Loc) {
-  if (CGM.getCodeGenOpts().WholeProgramVTables &&
-  CGM.HasHiddenLTOVisibility(RD)) {
+  if (SanOpts.has(SanitizerKind::CFIVCall))
+EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
+  else if (CGM.getCodeGenOpts().WholeProgramVTables &&
+   CGM.HasHiddenLTOVisibility(RD)) {
 llvm::Metadata *MD =
 CGM.CreateMetadataIdentifierForType(QualType(RD->getTypeForDecl(), 0));
 llvm::Value *TypeId =
@@ -2536,9 +2538,6 @@
{CastedVTable, TypeId});
 Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::assume), TypeTest);
   }
-
-  if (SanOpts.has(SanitizerKind::CFIVCall))
-EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
 }
 
 void CodeGenFunction::EmitVTablePtrCheckForCall(const CXXRecordDecl *RD,
Index: cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
===
--- cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
+++ cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
@@ -0,0 +1,15 @@
+// Only output llvm.assume(llvm.type.test()) if cfi-vcall is disabled and 
whole-program-vtables is enabled
+// RUN: %clang_cc1 -fvisibility hidden -fsanitize=cfi-vcall 
-fwhole-program-vtables -emit-llvm -o - %s | FileCheck --check-prefix=CHECK 
--check-prefix=CFI %s
+// RUN: %clang_cc1 -fvisibility hidden -fwhole-program-vtables -emit-llvm -o - 
%s | FileCheck --check-prefix=CHECK --check-prefix=NOCFI %s
+
+struct S1 {
+  virtual void f();
+};
+
+// CHECK: define{{.*}}s1f
+// CHECK: llvm.type.test
+// CFI-NOT: llvm.assume
+// NOCFI: llvm.assume
+void s1f(S1 *s1) {
+  s1->f();
+}


Index: cfe/trunk/lib/CodeGen/CGClass.cpp
===
--- cfe/trunk/lib/CodeGen/CGClass.cpp
+++ cfe/trunk/lib/CodeGen/CGClass.cpp
@@ -2523,8 +2523,10 @@
 void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD,
llvm::Value *VTable,
SourceLocation Loc) {
-  if (CGM.getCodeGenOpts().WholeProgramVTables &&
-  CGM.HasHiddenLTOVisibility(RD)) {
+  if (SanOpts.has(SanitizerKind::CFIVCall))
+EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
+  else if (CGM.getCodeGenOpts().WholeProgramVTables &&
+   CGM.HasHiddenLTOVisibility(RD)) {
 llvm::Metadata *MD =
 CGM.CreateMetadataIdentifierForType(QualType(RD->getTypeForDecl(), 0));
 llvm::Value *TypeId =
@@ -2536,9 +2538,6 @@
{CastedVTable, TypeId});
 Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::assume), TypeTest);
   }
-
-  if (SanOpts.has(SanitizerKind::CFIVCall))
-EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
 }
 
 void CodeGenFunction::EmitVTablePtrCheckForCall(const CXXRecordDecl *RD,
Index: cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
===
--- cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
+++ cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
@@ -0,0 +1,15 @@
+// Only output llvm.assume(llvm.type.test()) if cfi-vcall is disabled and whole-program-vtables is enabled
+// RUN: %clang_cc1 -fvisibility hidden -fsanitize=cfi-vcall -fwhole-program-vtables -emit-llvm -o - %s | FileCheck --check-prefix=CHECK --check-prefix=CFI %s
+// RUN: %clang_cc1 -fvisibility hidden -fwhole-program-vtables -emit-llvm -o - %s | FileCheck --check-prefix=CHECK --check-prefix=NOCFI %s
+
+struct S1 {
+  virtual void f();
+};
+
+// CHECK: define{{.*}}s1f
+// CHECK: llvm.type.test
+// CFI-NOT: llvm.assume
+// NOCFI: llvm.assume
+void s1f(S1 *s1) {
+  s1->f();
+}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309622 - Fix logic for generating llvm.type.test()s

[Peter Collingbourne via cfe-commits]

Author: pcc
Date: Mon Jul 31 13:45:14 2017
New Revision: 309622

URL: http://llvm.org/viewvc/llvm-project?rev=309622&view=rev
Log:
Fix logic for generating llvm.type.test()s

CodeGenFunction::EmitTypeMetadataCodeForVCall() could output an
llvm.assume(llvm.type.test())when CFI was enabled, optimizing out the
vcall check. This case was only reached when: 1) CFI-vcall was enabled,
2) -fwhole-program-tables was specified, and 3)
-fno-sanitize-trap=cfi-vcall was specified.

Patch by Vlad Tsyrklevich!

Differential Revision: https://reviews.llvm.org/D36013

Added:
cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
Modified:
cfe/trunk/lib/CodeGen/CGClass.cpp

Modified: cfe/trunk/lib/CodeGen/CGClass.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGClass.cpp?rev=309622&r1=309621&r2=309622&view=diff
==
--- cfe/trunk/lib/CodeGen/CGClass.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGClass.cpp Mon Jul 31 13:45:14 2017
@@ -2523,8 +2523,10 @@ LeastDerivedClassWithSameLayout(const CX
 void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD,
llvm::Value *VTable,
SourceLocation Loc) {
-  if (CGM.getCodeGenOpts().WholeProgramVTables &&
-  CGM.HasHiddenLTOVisibility(RD)) {
+  if (SanOpts.has(SanitizerKind::CFIVCall))
+EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
+  else if (CGM.getCodeGenOpts().WholeProgramVTables &&
+   CGM.HasHiddenLTOVisibility(RD)) {
 llvm::Metadata *MD =
 CGM.CreateMetadataIdentifierForType(QualType(RD->getTypeForDecl(), 0));
 llvm::Value *TypeId =
@@ -2536,9 +2538,6 @@ void CodeGenFunction::EmitTypeMetadataCo
{CastedVTable, TypeId});
 Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::assume), TypeTest);
   }
-
-  if (SanOpts.has(SanitizerKind::CFIVCall))
-EmitVTablePtrCheckForCall(RD, VTable, CodeGenFunction::CFITCK_VCall, Loc);
 }
 
 void CodeGenFunction::EmitVTablePtrCheckForCall(const CXXRecordDecl *RD,

Added: cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp?rev=309622&view=auto
==
--- cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp Mon Jul 31 13:45:14 2017
@@ -0,0 +1,15 @@
+// Only output llvm.assume(llvm.type.test()) if cfi-vcall is disabled and 
whole-program-vtables is enabled
+// RUN: %clang_cc1 -fvisibility hidden -fsanitize=cfi-vcall 
-fwhole-program-vtables -emit-llvm -o - %s | FileCheck --check-prefix=CHECK 
--check-prefix=CFI %s
+// RUN: %clang_cc1 -fvisibility hidden -fwhole-program-vtables -emit-llvm -o - 
%s | FileCheck --check-prefix=CHECK --check-prefix=NOCFI %s
+
+struct S1 {
+  virtual void f();
+};
+
+// CHECK: define{{.*}}s1f
+// CHECK: llvm.type.test
+// CFI-NOT: llvm.assume
+// NOCFI: llvm.assume
+void s1f(S1 *s1) {
+  s1->f();
+}


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36096: [ubsan] Make the 'vptr check disabled' warning more helpful

[Vedant Kumar via Phabricator via cfe-commits]

vsk abandoned this revision.
vsk added a comment.

Abandoned in favor of https://reviews.llvm.org/D36112, since it turns out 
-fsanitize=null,vptr doesn't work for some use cases.


https://reviews.llvm.org/D36096



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

[Vedant Kumar via Phabricator via cfe-commits]

vsk created this revision.

In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I 
did not see the need for the two checks to have separate null checking logic 
for the same pointer. I expected the two checks to either always be enabled 
together, or to be mutually compatible.

In the mailing list discussion re: r309007 it became clear that that isn't the 
case. If a codebase is -fsanitize=vptr clean but not -fsanitize=null clean, 
it's useful to have -fsanitize=vptr emit its own null check. That's what this 
patch does: with it, -fsanitize=vptr can be used without -fsanitize=null.


https://reviews.llvm.org/D36112

Files:
  docs/ReleaseNotes.rst
  docs/UndefinedBehaviorSanitizer.rst
  include/clang/Basic/DiagnosticDriverKinds.td
  lib/CodeGen/CGExpr.cpp
  lib/Driver/SanitizerArgs.cpp
  test/CodeGenCXX/catch-undef-behavior.cpp
  test/CodeGenCXX/ubsan-type-checks.cpp
  test/Driver/fsanitize.c
  test/Driver/rtti-options.cpp

Index: test/Driver/rtti-options.cpp
===
--- test/Driver/rtti-options.cpp
+++ test/Driver/rtti-options.cpp
@@ -16,14 +16,14 @@
 // Make sure we only error/warn once, when trying to enable vptr and
 // undefined and have -fno-rtti
 // RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=undefined -fsanitize=vptr -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-SAN-ERROR -check-prefix=CHECK-OK %s
-// RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=null,vptr %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
-// RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=null,vptr -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
-// RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=null,vptr -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-SAN-ERROR %s
+// RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=vptr %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
+// RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=vptr -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
+// RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=vptr -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-SAN-ERROR %s
 // RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=undefined %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
 // RUN: %clang -### -c -target x86_64-unknown-linux -fsanitize=undefined -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
-// RUN: %clang -### -c -target x86_64-scei-ps4 -fsanitize=null,vptr %s 2>&1 | FileCheck -check-prefix=CHECK-SAN-WARN %s
-// RUN: %clang -### -c -target x86_64-scei-ps4 -fsanitize=null,vptr -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
-// RUN: %clang -### -c -target x86_64-scei-ps4 -fsanitize=null,vptr -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-SAN-ERROR %s
+// RUN: %clang -### -c -target x86_64-scei-ps4 -fsanitize=vptr %s 2>&1 | FileCheck -check-prefix=CHECK-SAN-WARN %s
+// RUN: %clang -### -c -target x86_64-scei-ps4 -fsanitize=vptr -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
+// RUN: %clang -### -c -target x86_64-scei-ps4 -fsanitize=vptr -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-SAN-ERROR %s
 // RUN: %clang -### -c -target x86_64-scei-ps4 -fsanitize=undefined -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-OK %s
 
 // Exceptions + no/default rtti
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -58,10 +58,6 @@
 // RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -fno-rtti %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-UNDEFINED-NO-RTTI
 // CHECK-UNDEFINED-NO-RTTI-NOT: vptr
 
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -fno-sanitize=null %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-NO-NULL
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=vptr %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-NO-NULL
-// CHECK-VPTR-NO-NULL: warning: implicitly disabling vptr sanitizer because null checking wasn't enabled
-
 // RUN: %clang -target x86_64-linux-gnu -fsanitize=address,thread -fno-rtti %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANA-SANT
 // CHECK-SANA-SANT: '-fsanitize=address' not allowed with '-fsanitize=thread'
 
@@ -366,8 +362,8 @@
 // RUN: %clang -target x86_64-apple-darwin10 -mmacosx-version-min=10.8 -fsanitize=vptr %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-DARWIN-OLD
 // CHECK-VPTR-DARWIN-OLD: unsupported option '-fsanitize=vptr' for target 'x86_64-apple-darwin10'
 
-// RUN: %clang -target x86_64-apple-darwin10 -mmacosx-version-min=10.9 -fsanitize=alignment,null,vptr %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-DARWIN-NEW
-// CHECK-VPTR-DARWIN-NEW: -fsanitize=alignment,null,vptr
+// RUN: %clang -target x86_64-apple-darwin10 -mmacosx-version-min=10.9 -fsanitize=alignment,vptr %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-DARWIN-NEW
+// CHECK-VPTR-DARWIN-NEW: -fsanitize=alignment,vptr
 
 // RUN: %clang -ta

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

[Martin Storsjö via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL309620: [Attr] Make TargetWindows and TargetMicrosoftCXXABI 
match on aarch64 as well (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D36100?vs=108971&id=108992#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D36100

Files:
  cfe/trunk/include/clang/Basic/Attr.td
  cfe/trunk/test/Sema/dllimport.c


Index: cfe/trunk/include/clang/Basic/Attr.td
===
--- cfe/trunk/include/clang/Basic/Attr.td
+++ cfe/trunk/include/clang/Basic/Attr.td
@@ -268,10 +268,10 @@
 def TargetMSP430 : TargetArch<["msp430"]>;
 def TargetX86 : TargetArch<["x86"]>;
 def TargetAnyX86 : TargetArch<["x86", "x86_64"]>;
-def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
   let OSes = ["Win32"];
 }
-def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb", 
"aarch64"]> {
   let CXXABIs = ["Microsoft"];
 }
 
Index: cfe/trunk/test/Sema/dllimport.c
===
--- cfe/trunk/test/Sema/dllimport.c
+++ cfe/trunk/test/Sema/dllimport.c
@@ -2,6 +2,7 @@
 // RUN: %clang_cc1 -triple x86_64-win32   -fsyntax-only -fms-extensions 
-verify -std=c11 -DMS %s
 // RUN: %clang_cc1 -triple i686-mingw32   -fsyntax-only -fms-extensions 
-verify -std=c11 -DGNU %s
 // RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions 
-verify -std=c99 -DGNU %s
+// RUN: %clang_cc1 -triple aarch64-win32  -fsyntax-only -fms-extensions 
-verify -std=c99 -DMS %s
 
 // Invalid usage.
 __declspec(dllimport) typedef int typedef1;


Index: cfe/trunk/include/clang/Basic/Attr.td
===
--- cfe/trunk/include/clang/Basic/Attr.td
+++ cfe/trunk/include/clang/Basic/Attr.td
@@ -268,10 +268,10 @@
 def TargetMSP430 : TargetArch<["msp430"]>;
 def TargetX86 : TargetArch<["x86"]>;
 def TargetAnyX86 : TargetArch<["x86", "x86_64"]>;
-def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
   let OSes = ["Win32"];
 }
-def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
   let CXXABIs = ["Microsoft"];
 }
 
Index: cfe/trunk/test/Sema/dllimport.c
===
--- cfe/trunk/test/Sema/dllimport.c
+++ cfe/trunk/test/Sema/dllimport.c
@@ -2,6 +2,7 @@
 // RUN: %clang_cc1 -triple x86_64-win32   -fsyntax-only -fms-extensions -verify -std=c11 -DMS %s
 // RUN: %clang_cc1 -triple i686-mingw32   -fsyntax-only -fms-extensions -verify -std=c11 -DGNU %s
 // RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions -verify -std=c99 -DGNU %s
+// RUN: %clang_cc1 -triple aarch64-win32  -fsyntax-only -fms-extensions -verify -std=c99 -DMS %s
 
 // Invalid usage.
 __declspec(dllimport) typedef int typedef1;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

[Martin Storsjö via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL309619: [AArch64] Don't define __LP64__ when targeting 
Windows (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D36098?vs=108968&id=108991#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D36098

Files:
  cfe/trunk/lib/Basic/Targets/AArch64.cpp
  cfe/trunk/test/Preprocessor/init.c

Index: cfe/trunk/test/Preprocessor/init.c
===
--- cfe/trunk/test/Preprocessor/init.c
+++ cfe/trunk/test/Preprocessor/init.c
@@ -1424,6 +1424,167 @@
 // AARCH64-DARWIN: #define __WINT_WIDTH__ 32
 // AARCH64-DARWIN: #define __aarch64__ 1
 
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-windows-msvc < /dev/null | FileCheck -match-full-lines -check-prefix AARCH64-MSVC %s
+//
+// AARCH64-MSVC: #define _INTEGRAL_MAX_BITS 64
+// AARCH64-MSVC-NOT: #define _LP64 1
+// AARCH64-MSVC: #define _M_ARM64 1
+// AARCH64-MSVC: #define _WIN32 1
+// AARCH64-MSVC: #define _WIN64 1
+// AARCH64-MSVC: #define __AARCH64EL__ 1
+// AARCH64-MSVC: #define __ARM_64BIT_STATE 1
+// AARCH64-MSVC: #define __ARM_ACLE 200
+// AARCH64-MSVC: #define __ARM_ALIGN_MAX_STACK_PWR 4
+// AARCH64-MSVC: #define __ARM_ARCH 8
+// AARCH64-MSVC: #define __ARM_ARCH_ISA_A64 1
+// AARCH64-MSVC: #define __ARM_ARCH_PROFILE 'A'
+// AARCH64-MSVC: #define __ARM_FEATURE_CLZ 1
+// AARCH64-MSVC: #define __ARM_FEATURE_DIRECTED_ROUNDING 1
+// AARCH64-MSVC: #define __ARM_FEATURE_DIV 1
+// AARCH64-MSVC: #define __ARM_FEATURE_FMA 1
+// AARCH64-MSVC: #define __ARM_FEATURE_IDIV 1
+// AARCH64-MSVC: #define __ARM_FEATURE_LDREX 0xF
+// AARCH64-MSVC: #define __ARM_FEATURE_NUMERIC_MAXMIN 1
+// AARCH64-MSVC: #define __ARM_FEATURE_UNALIGNED 1
+// AARCH64-MSVC: #define __ARM_FP 0xE
+// AARCH64-MSVC: #define __ARM_FP16_ARGS 1
+// AARCH64-MSVC: #define __ARM_FP16_FORMAT_IEEE 1
+// AARCH64-MSVC: #define __ARM_PCS_AAPCS64 1
+// AARCH64-MSVC: #define __ARM_SIZEOF_MINIMAL_ENUM 4
+// AARCH64-MSVC: #define __ARM_SIZEOF_WCHAR_T 4
+// AARCH64-MSVC: #define __BIGGEST_ALIGNMENT__ 16
+// AARCH64-MSVC: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
+// AARCH64-MSVC: #define __CHAR16_TYPE__ unsigned short
+// AARCH64-MSVC: #define __CHAR32_TYPE__ unsigned int
+// AARCH64-MSVC: #define __CHAR_BIT__ 8
+// AARCH64-MSVC: #define __CONSTANT_CFSTRINGS__ 1
+// AARCH64-MSVC: #define __DBL_DECIMAL_DIG__ 17
+// AARCH64-MSVC: #define __DBL_DENORM_MIN__ 4.9406564584124654e-324
+// AARCH64-MSVC: #define __DBL_DIG__ 15
+// AARCH64-MSVC: #define __DBL_EPSILON__ 2.2204460492503131e-16
+// AARCH64-MSVC: #define __DBL_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __DBL_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __DBL_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __DBL_MANT_DIG__ 53
+// AARCH64-MSVC: #define __DBL_MAX_10_EXP__ 308
+// AARCH64-MSVC: #define __DBL_MAX_EXP__ 1024
+// AARCH64-MSVC: #define __DBL_MAX__ 1.7976931348623157e+308
+// AARCH64-MSVC: #define __DBL_MIN_10_EXP__ (-307)
+// AARCH64-MSVC: #define __DBL_MIN_EXP__ (-1021)
+// AARCH64-MSVC: #define __DBL_MIN__ 2.2250738585072014e-308
+// AARCH64-MSVC: #define __DECIMAL_DIG__ __LDBL_DECIMAL_DIG__
+// AARCH64-MSVC: #define __FINITE_MATH_ONLY__ 0
+// AARCH64-MSVC: #define __FLT_DECIMAL_DIG__ 9
+// AARCH64-MSVC: #define __FLT_DENORM_MIN__ 1.40129846e-45F
+// AARCH64-MSVC: #define __FLT_DIG__ 6
+// AARCH64-MSVC: #define __FLT_EPSILON__ 1.19209290e-7F
+// AARCH64-MSVC: #define __FLT_EVAL_METHOD__ 0
+// AARCH64-MSVC: #define __FLT_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __FLT_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __FLT_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __FLT_MANT_DIG__ 24
+// AARCH64-MSVC: #define __FLT_MAX_10_EXP__ 38
+// AARCH64-MSVC: #define __FLT_MAX_EXP__ 128
+// AARCH64-MSVC: #define __FLT_MAX__ 3.40282347e+38F
+// AARCH64-MSVC: #define __FLT_MIN_10_EXP__ (-37)
+// AARCH64-MSVC: #define __FLT_MIN_EXP__ (-125)
+// AARCH64-MSVC: #define __FLT_MIN__ 1.17549435e-38F
+// AARCH64-MSVC: #define __FLT_RADIX__ 2
+// AARCH64-MSVC: #define __INT_MAX__ 2147483647
+// AARCH64-MSVC: #define __LDBL_DECIMAL_DIG__ 17
+// AARCH64-MSVC: #define __LDBL_DENORM_MIN__ 4.9406564584124654e-324L
+// AARCH64-MSVC: #define __LDBL_DIG__ 15
+// AARCH64-MSVC: #define __LDBL_EPSILON__ 2.2204460492503131e-16L
+// AARCH64-MSVC: #define __LDBL_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __LDBL_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __LDBL_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __LDBL_MANT_DIG__ 53
+// AARCH64-MSVC: #define __LDBL_MAX_10_EXP__ 308
+// AARCH64-MSVC: #define __LDBL_MAX_EXP__ 1024
+// AARCH64-MSVC: #define __LDBL_MAX__ 1.7976931348623157e+308L
+// AARCH64-MSVC: #define __LDBL_MIN_10_EXP__ (-307)
+// AARCH64-MSVC: #define __LDBL_MIN_EXP__ (-1021)
+// AARCH64-MSVC: #define __LDBL_MIN__ 2.2250738585072014e-308L
+// AARCH64-MSVC: #define __LITTLE_ENDIAN__ 1
+// AARCH64-MSVC: #define __LONG_LONG_MAX__ 9223372036854775807LL
+// AARCH64-MSVC: #define __LONG_MAX__ 2147483647L
+// AARCH64-MSV

r309620 - [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

[Martin Storsjo via cfe-commits]

Author: mstorsjo
Date: Mon Jul 31 13:40:59 2017
New Revision: 309620

URL: http://llvm.org/viewvc/llvm-project?rev=309620&view=rev
Log:
[Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

Differential Revision: https://reviews.llvm.org/D36100

Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/test/Sema/dllimport.c

Modified: cfe/trunk/include/clang/Basic/Attr.td
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Attr.td?rev=309620&r1=309619&r2=309620&view=diff
==
--- cfe/trunk/include/clang/Basic/Attr.td (original)
+++ cfe/trunk/include/clang/Basic/Attr.td Mon Jul 31 13:40:59 2017
@@ -268,10 +268,10 @@ def TargetMips : TargetArch<["mips", "mi
 def TargetMSP430 : TargetArch<["msp430"]>;
 def TargetX86 : TargetArch<["x86"]>;
 def TargetAnyX86 : TargetArch<["x86", "x86_64"]>;
-def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
   let OSes = ["Win32"];
 }
-def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb", 
"aarch64"]> {
   let CXXABIs = ["Microsoft"];
 }
 

Modified: cfe/trunk/test/Sema/dllimport.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/dllimport.c?rev=309620&r1=309619&r2=309620&view=diff
==
--- cfe/trunk/test/Sema/dllimport.c (original)
+++ cfe/trunk/test/Sema/dllimport.c Mon Jul 31 13:40:59 2017
@@ -2,6 +2,7 @@
 // RUN: %clang_cc1 -triple x86_64-win32   -fsyntax-only -fms-extensions 
-verify -std=c11 -DMS %s
 // RUN: %clang_cc1 -triple i686-mingw32   -fsyntax-only -fms-extensions 
-verify -std=c11 -DGNU %s
 // RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions 
-verify -std=c99 -DGNU %s
+// RUN: %clang_cc1 -triple aarch64-win32  -fsyntax-only -fms-extensions 
-verify -std=c99 -DMS %s
 
 // Invalid usage.
 __declspec(dllimport) typedef int typedef1;


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

[Martin Storsjö via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL309618: [test] Fix mistagged CHECK-NOT-lines for 
AARCH64-DARWIN in Preprocessor/init.c (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D36099?vs=108969&id=108990#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D36099

Files:
  cfe/trunk/test/Preprocessor/init.c


Index: cfe/trunk/test/Preprocessor/init.c
===
--- cfe/trunk/test/Preprocessor/init.c
+++ cfe/trunk/test/Preprocessor/init.c
@@ -1236,13 +1236,13 @@
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-apple-ios7.0 < 
/dev/null | FileCheck -match-full-lines -check-prefix AARCH64-DARWIN %s
 //
 // AARCH64-DARWIN: #define _LP64 1
-// AARCH64-NOT: #define __AARCH64EB__ 1
+// AARCH64-DARWIN-NOT: #define __AARCH64EB__ 1
 // AARCH64-DARWIN: #define __AARCH64EL__ 1
-// AARCH64-NOT: #define __AARCH_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __AARCH_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __ARM_64BIT_STATE 1
 // AARCH64-DARWIN: #define __ARM_ARCH 8
 // AARCH64-DARWIN: #define __ARM_ARCH_ISA_A64 1
-// AARCH64-NOT: #define __ARM_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __ARM_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __BIGGEST_ALIGNMENT__ 8
 // AARCH64-DARWIN: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
 // AARCH64-DARWIN: #define __CHAR16_TYPE__ unsigned short


Index: cfe/trunk/test/Preprocessor/init.c
===
--- cfe/trunk/test/Preprocessor/init.c
+++ cfe/trunk/test/Preprocessor/init.c
@@ -1236,13 +1236,13 @@
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-apple-ios7.0 < /dev/null | FileCheck -match-full-lines -check-prefix AARCH64-DARWIN %s
 //
 // AARCH64-DARWIN: #define _LP64 1
-// AARCH64-NOT: #define __AARCH64EB__ 1
+// AARCH64-DARWIN-NOT: #define __AARCH64EB__ 1
 // AARCH64-DARWIN: #define __AARCH64EL__ 1
-// AARCH64-NOT: #define __AARCH_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __AARCH_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __ARM_64BIT_STATE 1
 // AARCH64-DARWIN: #define __ARM_ARCH 8
 // AARCH64-DARWIN: #define __ARM_ARCH_ISA_A64 1
-// AARCH64-NOT: #define __ARM_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __ARM_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __BIGGEST_ALIGNMENT__ 8
 // AARCH64-DARWIN: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
 // AARCH64-DARWIN: #define __CHAR16_TYPE__ unsigned short
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309618 - [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

[Martin Storsjo via cfe-commits]

Author: mstorsjo
Date: Mon Jul 31 13:40:48 2017
New Revision: 309618

URL: http://llvm.org/viewvc/llvm-project?rev=309618&view=rev
Log:
[test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

Differential Revision: https://reviews.llvm.org/D36099

Modified:
cfe/trunk/test/Preprocessor/init.c

Modified: cfe/trunk/test/Preprocessor/init.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/init.c?rev=309618&r1=309617&r2=309618&view=diff
==
--- cfe/trunk/test/Preprocessor/init.c (original)
+++ cfe/trunk/test/Preprocessor/init.c Mon Jul 31 13:40:48 2017
@@ -1236,13 +1236,13 @@
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-apple-ios7.0 < 
/dev/null | FileCheck -match-full-lines -check-prefix AARCH64-DARWIN %s
 //
 // AARCH64-DARWIN: #define _LP64 1
-// AARCH64-NOT: #define __AARCH64EB__ 1
+// AARCH64-DARWIN-NOT: #define __AARCH64EB__ 1
 // AARCH64-DARWIN: #define __AARCH64EL__ 1
-// AARCH64-NOT: #define __AARCH_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __AARCH_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __ARM_64BIT_STATE 1
 // AARCH64-DARWIN: #define __ARM_ARCH 8
 // AARCH64-DARWIN: #define __ARM_ARCH_ISA_A64 1
-// AARCH64-NOT: #define __ARM_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __ARM_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __BIGGEST_ALIGNMENT__ 8
 // AARCH64-DARWIN: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
 // AARCH64-DARWIN: #define __CHAR16_TYPE__ unsigned short


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309619 - [AArch64] Don't define __LP64__ when targeting Windows

[Martin Storsjo via cfe-commits]

Author: mstorsjo
Date: Mon Jul 31 13:40:53 2017
New Revision: 309619

URL: http://llvm.org/viewvc/llvm-project?rev=309619&view=rev
Log:
[AArch64] Don't define __LP64__ when targeting Windows

Windows/ARM64 is a LLP64 environment, so don't set this default
define.

Differential Revision: https://reviews.llvm.org/D36098

Modified:
cfe/trunk/lib/Basic/Targets/AArch64.cpp
cfe/trunk/test/Preprocessor/init.c

Modified: cfe/trunk/lib/Basic/Targets/AArch64.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets/AArch64.cpp?rev=309619&r1=309618&r2=309619&view=diff
==
--- cfe/trunk/lib/Basic/Targets/AArch64.cpp (original)
+++ cfe/trunk/lib/Basic/Targets/AArch64.cpp Mon Jul 31 13:40:53 2017
@@ -119,8 +119,10 @@ void AArch64TargetInfo::getTargetDefines
 Builder.defineMacro("__ELF__");
 
   // Target properties.
-  Builder.defineMacro("_LP64");
-  Builder.defineMacro("__LP64__");
+  if (!getTriple().isOSWindows()) {
+Builder.defineMacro("_LP64");
+Builder.defineMacro("__LP64__");
+  }
 
   // ACLE predefines. Many can only have one possible value on v8 AArch64.
   Builder.defineMacro("__ARM_ACLE", "200");

Modified: cfe/trunk/test/Preprocessor/init.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/init.c?rev=309619&r1=309618&r2=309619&view=diff
==
--- cfe/trunk/test/Preprocessor/init.c (original)
+++ cfe/trunk/test/Preprocessor/init.c Mon Jul 31 13:40:53 2017
@@ -1424,6 +1424,167 @@
 // AARCH64-DARWIN: #define __WINT_WIDTH__ 32
 // AARCH64-DARWIN: #define __aarch64__ 1
 
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-windows-msvc < 
/dev/null | FileCheck -match-full-lines -check-prefix AARCH64-MSVC %s
+//
+// AARCH64-MSVC: #define _INTEGRAL_MAX_BITS 64
+// AARCH64-MSVC-NOT: #define _LP64 1
+// AARCH64-MSVC: #define _M_ARM64 1
+// AARCH64-MSVC: #define _WIN32 1
+// AARCH64-MSVC: #define _WIN64 1
+// AARCH64-MSVC: #define __AARCH64EL__ 1
+// AARCH64-MSVC: #define __ARM_64BIT_STATE 1
+// AARCH64-MSVC: #define __ARM_ACLE 200
+// AARCH64-MSVC: #define __ARM_ALIGN_MAX_STACK_PWR 4
+// AARCH64-MSVC: #define __ARM_ARCH 8
+// AARCH64-MSVC: #define __ARM_ARCH_ISA_A64 1
+// AARCH64-MSVC: #define __ARM_ARCH_PROFILE 'A'
+// AARCH64-MSVC: #define __ARM_FEATURE_CLZ 1
+// AARCH64-MSVC: #define __ARM_FEATURE_DIRECTED_ROUNDING 1
+// AARCH64-MSVC: #define __ARM_FEATURE_DIV 1
+// AARCH64-MSVC: #define __ARM_FEATURE_FMA 1
+// AARCH64-MSVC: #define __ARM_FEATURE_IDIV 1
+// AARCH64-MSVC: #define __ARM_FEATURE_LDREX 0xF
+// AARCH64-MSVC: #define __ARM_FEATURE_NUMERIC_MAXMIN 1
+// AARCH64-MSVC: #define __ARM_FEATURE_UNALIGNED 1
+// AARCH64-MSVC: #define __ARM_FP 0xE
+// AARCH64-MSVC: #define __ARM_FP16_ARGS 1
+// AARCH64-MSVC: #define __ARM_FP16_FORMAT_IEEE 1
+// AARCH64-MSVC: #define __ARM_PCS_AAPCS64 1
+// AARCH64-MSVC: #define __ARM_SIZEOF_MINIMAL_ENUM 4
+// AARCH64-MSVC: #define __ARM_SIZEOF_WCHAR_T 4
+// AARCH64-MSVC: #define __BIGGEST_ALIGNMENT__ 16
+// AARCH64-MSVC: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
+// AARCH64-MSVC: #define __CHAR16_TYPE__ unsigned short
+// AARCH64-MSVC: #define __CHAR32_TYPE__ unsigned int
+// AARCH64-MSVC: #define __CHAR_BIT__ 8
+// AARCH64-MSVC: #define __CONSTANT_CFSTRINGS__ 1
+// AARCH64-MSVC: #define __DBL_DECIMAL_DIG__ 17
+// AARCH64-MSVC: #define __DBL_DENORM_MIN__ 4.9406564584124654e-324
+// AARCH64-MSVC: #define __DBL_DIG__ 15
+// AARCH64-MSVC: #define __DBL_EPSILON__ 2.2204460492503131e-16
+// AARCH64-MSVC: #define __DBL_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __DBL_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __DBL_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __DBL_MANT_DIG__ 53
+// AARCH64-MSVC: #define __DBL_MAX_10_EXP__ 308
+// AARCH64-MSVC: #define __DBL_MAX_EXP__ 1024
+// AARCH64-MSVC: #define __DBL_MAX__ 1.7976931348623157e+308
+// AARCH64-MSVC: #define __DBL_MIN_10_EXP__ (-307)
+// AARCH64-MSVC: #define __DBL_MIN_EXP__ (-1021)
+// AARCH64-MSVC: #define __DBL_MIN__ 2.2250738585072014e-308
+// AARCH64-MSVC: #define __DECIMAL_DIG__ __LDBL_DECIMAL_DIG__
+// AARCH64-MSVC: #define __FINITE_MATH_ONLY__ 0
+// AARCH64-MSVC: #define __FLT_DECIMAL_DIG__ 9
+// AARCH64-MSVC: #define __FLT_DENORM_MIN__ 1.40129846e-45F
+// AARCH64-MSVC: #define __FLT_DIG__ 6
+// AARCH64-MSVC: #define __FLT_EPSILON__ 1.19209290e-7F
+// AARCH64-MSVC: #define __FLT_EVAL_METHOD__ 0
+// AARCH64-MSVC: #define __FLT_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __FLT_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __FLT_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __FLT_MANT_DIG__ 24
+// AARCH64-MSVC: #define __FLT_MAX_10_EXP__ 38
+// AARCH64-MSVC: #define __FLT_MAX_EXP__ 128
+// AARCH64-MSVC: #define __FLT_MAX__ 3.40282347e+38F
+// AARCH64-MSVC: #define __FLT_MIN_10_EXP__ (-37)
+// AARCH64-MSVC: #define __FLT_MIN_EXP__ (-125)
+// AARCH64-MSVC: #define __FLT_MIN__ 1.17549435e-38F
+// AARCH64-MSVC: #define __FLT_RADIX__ 

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.



Comment at: include/clang/Basic/BuiltinsAArch64.def:49
 // Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")

Shouldn't these be limited to MSVC mode only? Have a look at `BuiltinsARM.def`, 
where there's cases like `LANGBUILTIN(__dmb, "vUi", "nc", ALL_MS_LANGUAGES)` 
instead.


https://reviews.llvm.org/D36111



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang added a comment.

Related llvm patch: https://reviews.llvm.org/D36110


https://reviews.llvm.org/D36111



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.

https://reviews.llvm.org/D36111

Files:
  include/clang/Basic/BuiltinsAArch64.def
  test/CodeGen/builtins-arm64.c


Index: test/CodeGen/builtins-arm64.c
===
--- test/CodeGen/builtins-arm64.c
+++ test/CodeGen/builtins-arm64.c
@@ -30,6 +30,9 @@
 }
 
 void barriers() {
+  __dmb(1);  //CHECK: call {{.*}} @llvm.aarch64.dmb(i32 1)
+  __dsb(2);  //CHECK: call {{.*}} @llvm.aarch64.dsb(i32 2)
+  __isb(3);  //CHECK: call {{.*}} @llvm.aarch64.isb(i32 3)
   __builtin_arm_dmb(1);  //CHECK: call {{.*}} @llvm.aarch64.dmb(i32 1)
   __builtin_arm_dsb(2);  //CHECK: call {{.*}} @llvm.aarch64.dsb(i32 2)
   __builtin_arm_isb(3);  //CHECK: call {{.*}} @llvm.aarch64.isb(i32 3)
Index: include/clang/Basic/BuiltinsAArch64.def
===
--- include/clang/Basic/BuiltinsAArch64.def
+++ include/clang/Basic/BuiltinsAArch64.def
@@ -46,6 +46,9 @@
 BUILTIN(__builtin_arm_crc32cd, "UiUiLUi", "nc")
 
 // Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")
+BUILTIN(__isb, "vUi", "nc")
 BUILTIN(__builtin_arm_dmb, "vUi", "nc")
 BUILTIN(__builtin_arm_dsb, "vUi", "nc")
 BUILTIN(__builtin_arm_isb, "vUi", "nc")


Index: test/CodeGen/builtins-arm64.c
===
--- test/CodeGen/builtins-arm64.c
+++ test/CodeGen/builtins-arm64.c
@@ -30,6 +30,9 @@
 }
 
 void barriers() {
+  __dmb(1);  //CHECK: call {{.*}} @llvm.aarch64.dmb(i32 1)
+  __dsb(2);  //CHECK: call {{.*}} @llvm.aarch64.dsb(i32 2)
+  __isb(3);  //CHECK: call {{.*}} @llvm.aarch64.isb(i32 3)
   __builtin_arm_dmb(1);  //CHECK: call {{.*}} @llvm.aarch64.dmb(i32 1)
   __builtin_arm_dsb(2);  //CHECK: call {{.*}} @llvm.aarch64.dsb(i32 2)
   __builtin_arm_isb(3);  //CHECK: call {{.*}} @llvm.aarch64.isb(i32 3)
Index: include/clang/Basic/BuiltinsAArch64.def
===
--- include/clang/Basic/BuiltinsAArch64.def
+++ include/clang/Basic/BuiltinsAArch64.def
@@ -46,6 +46,9 @@
 BUILTIN(__builtin_arm_crc32cd, "UiUiLUi", "nc")
 
 // Memory barrier
+BUILTIN(__dmb, "vUi", "nc")
+BUILTIN(__dsb, "vUi", "nc")
+BUILTIN(__isb, "vUi", "nc")
 BUILTIN(__builtin_arm_dmb, "vUi", "nc")
 BUILTIN(__builtin_arm_dsb, "vUi", "nc")
 BUILTIN(__builtin_arm_isb, "vUi", "nc")
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309616 - [X86] Remove -O3 from tbm-builtins.c test file.

[Craig Topper via cfe-commits]

Author: ctopper
Date: Mon Jul 31 13:21:53 2017
New Revision: 309616

URL: http://llvm.org/viewvc/llvm-project?rev=309616&view=rev
Log:
[X86] Remove -O3 from tbm-builtins.c test file.

A change to InstCombine broke this test, but we generally frown on running 
optimizations clang tests anyway. So I've updated the checks to not depend on 
optimizations anymore.

Modified:
cfe/trunk/test/CodeGen/tbm-builtins.c

Modified: cfe/trunk/test/CodeGen/tbm-builtins.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbm-builtins.c?rev=309616&r1=309615&r2=309616&view=diff
==
--- cfe/trunk/test/CodeGen/tbm-builtins.c (original)
+++ cfe/trunk/test/CodeGen/tbm-builtins.c Mon Jul 31 13:21:53 2017
@@ -1,8 +1,4 @@
-// RUN: %clang_cc1 -ffreestanding %s -O3 -triple=x86_64-unknown-unknown 
-target-feature +tbm -emit-llvm -o - | FileCheck %s
-// FIXME: The code generation checks for add/sub and/or are depending on the 
optimizer.
-// The REQUIRES keyword will be removed when the FIXME is complete.
-// REQUIRES: x86-registered-target
-
+// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-unknown-unknown 
-target-feature +tbm -emit-llvm -o - | FileCheck %s
 
 #include 
 
@@ -28,134 +24,136 @@ unsigned long long test__bextri_u64_bigi
 
 unsigned int test__blcfill_u32(unsigned int a) {
   // CHECK-LABEL: test__blcfill_u32
-  // CHECK: [[TMP:%.*]] = add i32 [[SRC:%.*]], 1
-  // CHECK-NEXT: %{{.*}} = and i32 [[TMP]], [[SRC]]
+  // CHECK: [[TMP:%.*]] = add i32 %{{.*}}, 1
+  // CHECK: %{{.*}} = and i32 %{{.*}}, [[TMP]]
   return __blcfill_u32(a);
 }
 
 unsigned long long test__blcfill_u64(unsigned long long a) {
   // CHECK-LABEL: test__blcfill_u64
-  // CHECK: [[TMPT:%.*]] = add i64 [[SRC:%.*]], 1
-  // CHECK-NEXT: %{{.*}} = and i64 [[TMP]], [[SRC]]
+  // CHECK: [[TMP:%.*]] = add i64 %{{.*}}, 1
+  // CHECK: %{{.*}} = and i64 %{{.*}}, [[TMP]]
   return __blcfill_u64(a);
 }
 
 unsigned int test__blci_u32(unsigned int a) {
   // CHECK-LABEL: test__blci_u32
-  // CHECK: [[TMP:%.*]] = sub i32 -2, [[SRC:%.*]]
-  // CHECK-NEXT: %{{.*}} = or i32 [[TMP]], [[SRC]]
+  // CHECK: [[TMP1:%.*]] = add i32 %{{.*}}, 1
+  // CHECK: [[TMP2:%.*]] = xor i32 [[TMP1]], -1
+  // CHECK: %{{.*}} = or i32 %{{.*}}, [[TMP2]]
   return __blci_u32(a);
 }
 
 unsigned long long test__blci_u64(unsigned long long a) {
   // CHECK-LABEL: test__blci_u64
-  // CHECK: [[TMP:%.*]] = sub i64 -2, [[SRC:%.*]]
-  // CHECK-NEXT: %{{.*}} = or i64 [[TMP]], [[SRC]]
+  // CHECK: [[TMP1:%.*]] = add i64 %{{.*}}, 1
+  // CHECK: [[TMP2:%.*]] = xor i64 [[TMP1]], -1
+  // CHECK: %{{.*}} = or i64 %{{.*}}, [[TMP2]]
   return __blci_u64(a);
 }
 
 unsigned int test__blcic_u32(unsigned int a) {
   // CHECK-LABEL: test__blcic_u32
-  // CHECK: [[TMP1:%.*]] = xor i32 [[SRC:%.*]], -1
-  // CHECK-NEXT: [[TMP2:%.*]] = add i32 [[SRC]], 1
-  // CHECK-NEXT: {{.*}} = and i32 [[TMP2]], [[TMP1]]
+  // CHECK: [[TMP1:%.*]] = xor i32 %{{.*}}, -1
+  // CHECK: [[TMP2:%.*]] = add i32 %{{.*}}, 1
+  // CHECK-NEXT: {{.*}} = and i32 [[TMP1]], [[TMP2]]
   return __blcic_u32(a);
 }
 
 unsigned long long test__blcic_u64(unsigned long long a) {
   // CHECK-LABEL: test__blcic_u64
-  // CHECK: [[TMP1:%.*]] = xor i64 [[SRC:%.*]], -1
-  // CHECK-NEXT: [[TMP2:%.*]] = add i64 [[SRC]], 1
-  // CHECK-NEXT: {{.*}} = and i64 [[TMP2]], [[TMP1]]
+  // CHECK: [[TMP1:%.*]] = xor i64 %{{.*}}, -1
+  // CHECK: [[TMP2:%.*]] = add i64 %{{.*}}, 1
+  // CHECK-NEXT: {{.*}} = and i64 [[TMP1]], [[TMP2]]
   return __blcic_u64(a);
 }
 
 unsigned int test__blcmsk_u32(unsigned int a) {
   // CHECK-LABEL: test__blcmsk_u32
-  // CHECK: [[TMP:%.*]] = add i32 [[SRC:%.*]], 1
-  // CHECK-NEXT: {{.*}} = xor i32 [[TMP]], [[SRC]]
+  // CHECK: [[TMP:%.*]] = add i32 %{{.*}}, 1
+  // CHECK-NEXT: {{.*}} = xor i32 %{{.*}}, [[TMP]]
   return __blcmsk_u32(a);
 }
 
 unsigned long long test__blcmsk_u64(unsigned long long a) {
   // CHECK-LABEL: test__blcmsk_u64
-  // CHECK: [[TMP:%.*]] = add i64 [[SRC:%.*]], 1
-  // CHECK-NEXT: {{.*}} = xor i64 [[TMP]], [[SRC]]
+  // CHECK: [[TMP:%.*]] = add i64 %{{.*}}, 1
+  // CHECK-NEXT: {{.*}} = xor i64 %{{.*}}, [[TMP]]
   return __blcmsk_u64(a);
 }
 
 unsigned int test__blcs_u32(unsigned int a) {
   // CHECK-LABEL: test__blcs_u32
-  // CHECK: [[TMP:%.*]] = add i32 [[SRC:%.*]], 1
-  // CHECK-NEXT: {{.*}} = or i32 [[TMP]], [[SRC]]
+  // CHECK: [[TMP:%.*]] = add i32 %{{.*}}, 1
+  // CHECK-NEXT: {{.*}} = or i32 %{{.*}}, [[TMP]]
   return __blcs_u32(a);
 }
 
 unsigned long long test__blcs_u64(unsigned long long a) {
   // CHECK-LABEL: test__blcs_u64
-  // CHECK: [[TMP:%.*]] = add i64 [[SRC:%.*]], 1
-  // CHECK-NEXT: {{.*}} = or i64 [[TMP]], [[SRC]]
+  // CHECK: [[TMP:%.*]] = add i64 %{{.*}}, 1
+  // CHECK-NEXT: {{.*}} = or i64 %{{.*}}, [[TMP]]
   return __blcs_u64(a);
 }
 
 unsigned int test__blsfill_u32(unsigned int a) {
   // CHECK-LABEL: test__blsfill_u32
-  // CHECK: [[TMP:%.*]] = add i32 [[SRC:%.*]], -1
-  // CHECK-NEXT: {{.*}} = or i

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

[Sterling Augustine via Phabricator via cfe-commits]

saugustine created this revision.
Herald added subscribers: aheejin, mgorny, dberris, nemanjai.

Add powerpc64 to compiler-rt build infrastructure.


https://reviews.llvm.org/D36108

Files:
  compiler-rt/cmake/Modules/CompilerRTUtils.cmake
  compiler-rt/cmake/builtin-config-ix.cmake
  compiler-rt/lib/builtins/CMakeLists.txt


Index: compiler-rt/lib/builtins/CMakeLists.txt
===
--- compiler-rt/lib/builtins/CMakeLists.txt
+++ compiler-rt/lib/builtins/CMakeLists.txt
@@ -458,6 +458,20 @@
 set(mips64el_SOURCES ${GENERIC_TF_SOURCES}
  ${mips_SOURCES})
 
+set(powerpc64_SOURCES
+  ppc/divtc3.c
+  ppc/fixtfdi.c
+  ppc/fixunstfdi.c
+  ppc/floatditf.c
+  ppc/floatunditf.c
+  ppc/gcc_qadd.c
+  ppc/gcc_qdiv.c
+  ppc/gcc_qmul.c
+  ppc/gcc_qsub.c
+  ppc/multc3.c
+  ${GENERIC_SOURCES})
+set(powerpc64le_SOURCES ${powerpc64_SOURCES})
+
 set(wasm32_SOURCES ${GENERIC_SOURCES})
 set(wasm64_SOURCES ${GENERIC_SOURCES})
 
Index: compiler-rt/cmake/builtin-config-ix.cmake
===
--- compiler-rt/cmake/builtin-config-ix.cmake
+++ compiler-rt/cmake/builtin-config-ix.cmake
@@ -40,7 +40,7 @@
 endif()
 
 set(ALL_BUILTIN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
-${MIPS32} ${MIPS64} ${WASM32} ${WASM64})
+${MIPS32} ${MIPS64} ${PPC64} ${WASM32} ${WASM64})
 
 include(CompilerRTUtils)
 include(CompilerRTDarwinUtils)
Index: compiler-rt/cmake/Modules/CompilerRTUtils.cmake
===
--- compiler-rt/cmake/Modules/CompilerRTUtils.cmake
+++ compiler-rt/cmake/Modules/CompilerRTUtils.cmake
@@ -167,6 +167,8 @@
   check_symbol_exists(__i386__ "" __I386)
   check_symbol_exists(__mips__ "" __MIPS)
   check_symbol_exists(__mips64__ "" __MIPS64)
+  check_symbol_exists(__powerpc64__ "" __PPC64)
+  check_symbol_exists(__powerpc64le__ "" __PPC64LE)
   check_symbol_exists(__s390x__ "" __S390X)
   check_symbol_exists(__wasm32__ "" __WEBASSEMBLY32)
   check_symbol_exists(__wasm64__ "" __WEBASSEMBLY64)
@@ -184,6 +186,10 @@
 add_default_target_arch(mips64)
   elseif(__MIPS)
 add_default_target_arch(mips)
+  elseif(__PPC64)
+add_default_target_arch(powerpc64)
+  elseif(__PPC64LE)
+add_default_target_arch(powerpc64le)
   elseif(__S390X)
 add_default_target_arch(s390x)
   elseif(__WEBASSEMBLY32)


Index: compiler-rt/lib/builtins/CMakeLists.txt
===
--- compiler-rt/lib/builtins/CMakeLists.txt
+++ compiler-rt/lib/builtins/CMakeLists.txt
@@ -458,6 +458,20 @@
 set(mips64el_SOURCES ${GENERIC_TF_SOURCES}
  ${mips_SOURCES})
 
+set(powerpc64_SOURCES
+  ppc/divtc3.c
+  ppc/fixtfdi.c
+  ppc/fixunstfdi.c
+  ppc/floatditf.c
+  ppc/floatunditf.c
+  ppc/gcc_qadd.c
+  ppc/gcc_qdiv.c
+  ppc/gcc_qmul.c
+  ppc/gcc_qsub.c
+  ppc/multc3.c
+  ${GENERIC_SOURCES})
+set(powerpc64le_SOURCES ${powerpc64_SOURCES})
+
 set(wasm32_SOURCES ${GENERIC_SOURCES})
 set(wasm64_SOURCES ${GENERIC_SOURCES})
 
Index: compiler-rt/cmake/builtin-config-ix.cmake
===
--- compiler-rt/cmake/builtin-config-ix.cmake
+++ compiler-rt/cmake/builtin-config-ix.cmake
@@ -40,7 +40,7 @@
 endif()
 
 set(ALL_BUILTIN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
-${MIPS32} ${MIPS64} ${WASM32} ${WASM64})
+${MIPS32} ${MIPS64} ${PPC64} ${WASM32} ${WASM64})
 
 include(CompilerRTUtils)
 include(CompilerRTDarwinUtils)
Index: compiler-rt/cmake/Modules/CompilerRTUtils.cmake
===
--- compiler-rt/cmake/Modules/CompilerRTUtils.cmake
+++ compiler-rt/cmake/Modules/CompilerRTUtils.cmake
@@ -167,6 +167,8 @@
   check_symbol_exists(__i386__ "" __I386)
   check_symbol_exists(__mips__ "" __MIPS)
   check_symbol_exists(__mips64__ "" __MIPS64)
+  check_symbol_exists(__powerpc64__ "" __PPC64)
+  check_symbol_exists(__powerpc64le__ "" __PPC64LE)
   check_symbol_exists(__s390x__ "" __S390X)
   check_symbol_exists(__wasm32__ "" __WEBASSEMBLY32)
   check_symbol_exists(__wasm64__ "" __WEBASSEMBLY64)
@@ -184,6 +186,10 @@
 add_default_target_arch(mips64)
   elseif(__MIPS)
 add_default_target_arch(mips)
+  elseif(__PPC64)
+add_default_target_arch(powerpc64)
+  elseif(__PPC64LE)
+add_default_target_arch(powerpc64le)
   elseif(__S390X)
 add_default_target_arch(s390x)
   elseif(__WEBASSEMBLY32)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

[Vedant Kumar via Phabricator via cfe-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

This lgtm, we shouldn't defer this until https://reviews.llvm.org/D32842 is 
done, as that may take a while.


https://reviews.llvm.org/D35849



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

[Vedant Kumar via Phabricator via cfe-commits]

vsk added a comment.

In https://reviews.llvm.org/D32842#826383, @shenhan wrote:

> Ping? Can we make a decision on this? 
>  I've this simple one D35849: [UBSan] Provide default blacklist filename for 
> UBSan  which, depending on this, shall be 
> discarded or move forward.
>  If this CL stalls, I'll seek to proceed with 
> https://reviews.llvm.org/D35849. Any how, https://reviews.llvm.org/D35849 
> gets wiped out whence this CL (https://reviews.llvm.org/D32842) is submitted.


Please go ahead with https://reviews.llvm.org/D35849, I believe @pcc sgtm'd an 
identical patch of mine a while back, and it lgtm as well. Once I have time to 
revisit this I'll make sure to consider ubsan_blacklist.txt.


https://reviews.llvm.org/D32842



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35894: [clangd] Code hover for Clangd

[William Enright via Phabricator via cfe-commits]

Nebiroth updated this revision to Diff 108979.
Nebiroth marked 19 inline comments as done.
Nebiroth added a comment.

Implemention of Code Hover as described in LSP definition.
Removed unintentional changes to formatting.
Removed file id field in Location struct.


https://reviews.llvm.org/D35894

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h
  clangd/ClangdUnit.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  clangd/ProtocolHandlers.cpp
  clangd/ProtocolHandlers.h
  clangd/clients/clangd-vscode/src/extension.ts
  test/clangd/hover.test

Index: test/clangd/hover.test
===
--- /dev/null
+++ test/clangd/hover.test
@@ -0,0 +1,26 @@
+# RUN: clangd -run-synchronously < %s | FileCheck %s
+# It is absolutely vital that this file has CRLF line endings.
+#
+Content-Length: 125
+
+{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
+
+Content-Length: 172
+
+{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///main.cpp","languageId":"cpp","version":1,"text":"int main() {\nint a;\na;\n}\n"}}}
+
+Content-Length: 143
+
+{"jsonrpc":"2.0","id":1,"method":"textDocument/hover","params":{"textDocument":{"uri":"file:///main.cpp"},"position":{"line":0,"character":5}}}
+# Go to local variable
+# CHECK: {"jsonrpc":"2.0","id":1,"result":{"contents": {"language": "C++", "value": "int main() {\nint a;\na;\n}"}, "range": {"start": {"line": 0, "character": 0}, "end": {"line": 3, "character": 1
+
+Content-Length: 143
+
+{"jsonrpc":"2.0","id":1,"method":"textDocument/hover","params":{"textDocument":{"uri":"file:///main.cpp"},"position":{"line":1,"character":5}}}
+# Go to local variable
+# CHECK: {"jsonrpc":"2.0","id":1,"result":{"contents": {"language": "C++", "value": "int a"}, "range": {"start": {"line": 1, "character": 0}, "end": {"line": 1, "character": 5
+
+Content-Length: 44
+
+{"jsonrpc":"2.0","id":3,"method":"shutdown"}
Index: clangd/clients/clangd-vscode/src/extension.ts
===
--- clangd/clients/clangd-vscode/src/extension.ts
+++ clangd/clients/clangd-vscode/src/extension.ts
@@ -1,5 +1,6 @@
 import * as vscode from 'vscode';
 import * as vscodelc from 'vscode-languageclient';
+import * as vscodejsonrpc from 'vscode-jsonrpc';
 
 /**
  * Method to get workspace configuration option
Index: clangd/ProtocolHandlers.h
===
--- clangd/ProtocolHandlers.h
+++ clangd/ProtocolHandlers.h
@@ -48,6 +48,8 @@
 JSONOutput &Out) = 0;
   virtual void onGoToDefinition(TextDocumentPositionParams Params, StringRef ID,
 JSONOutput &Out) = 0;
+  virtual void onCodeHover(TextDocumentPositionParams Params, StringRef ID,
+JSONOutput &Out) = 0;
 };
 
 void regiterCallbackHandlers(JSONRPCDispatcher &Dispatcher, JSONOutput &Out,
Index: clangd/ProtocolHandlers.cpp
===
--- clangd/ProtocolHandlers.cpp
+++ clangd/ProtocolHandlers.cpp
@@ -204,6 +204,24 @@
   ProtocolCallbacks &Callbacks;
 };
 
+struct CodeHoverHandler : Handler {
+  CodeHoverHandler(JSONOutput &Output, ProtocolCallbacks &Callbacks)
+  : Handler(Output), Callbacks(Callbacks) {}
+
+  void handleMethod(llvm::yaml::MappingNode *Params, StringRef ID) override {
+auto TDPP = TextDocumentPositionParams::parse(Params);
+if (!TDPP) {
+  Output.log("Failed to decode TextDocumentPositionParams!\n");
+  return;
+}
+
+Callbacks.onCodeHover(*TDPP, ID, Output);
+  }
+
+private:
+  ProtocolCallbacks &Callbacks;
+};
+
 } // namespace
 
 void clangd::regiterCallbackHandlers(JSONRPCDispatcher &Dispatcher,
@@ -239,4 +257,7 @@
   llvm::make_unique(Out, Callbacks));
   Dispatcher.registerHandler("textDocument/definition",
   llvm::make_unique(Out, Callbacks));
+  Dispatcher.registerHandler(
+  "textDocument/hover",
+  llvm::make_unique(Out, Callbacks));
 }
Index: clangd/Protocol.h
===
--- clangd/Protocol.h
+++ clangd/Protocol.h
@@ -23,6 +23,7 @@
 
 #include "llvm/ADT/Optional.h"
 #include "llvm/Support/YAMLParser.h"
+#include "clang/Basic/SourceLocation.h"
 #include 
 #include 
 
@@ -304,7 +305,59 @@
   parse(llvm::yaml::MappingNode *Params);
 };
 
-/// The kind of a completion entry.
+struct MarkedString {
+  /**
+ * MarkedString can be used to render human readable text. It is either a
+ * markdown string
+ * or a code-block that provides a language and a code snippet. The language
+ * identifier
+ * is sematically equal to the optional language identifier in fenced code
+ * blocks in GitHub
+ * issues. See
+ * https://help.github.com/articles/creating-and-highlighting-code-blocks/#syntax-highlighting
+ *
+ * The pair of a la

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

[Vedant Kumar via cfe-commits]

> On Jul 31, 2017, at 12:30 PM, Nico Weber  wrote:
> 
> On Mon, Jul 31, 2017 at 1:18 PM, Vedant Kumar  > wrote:
> The bot should start working again with -fsanitize=vptr,null.
> 
> The warning can be improved. If we find -fno-sanitize=null in the argument 
> list, we might say:
> implicitly disabling vptr sanitizer because "-fno-sanitize=null" was specified
> 
> Otherwise we might say:
> implicitly disabling vptr sanitizer because null checking wasn't enabled, try 
> specifying -fsanitize=null or -fsanitize=undefined
> 
> Hm, I still don't understand. I enable vptr ubsan checking, and I don't want 
> null checking (because chromium happens to be vptr clean and we want to keep 
> it that way, but we're not nullptr clean due to for example v8's SMIs). How 
> do I get yesterday's behavior back?

We can teach the -fsanitize=vptr to emit its own null check when 
-fsanitize=null isn't available (I'll send a patch out for this). I opted not 
to do this initially to because I expected the two checks to either always be 
enabled together, or to be mutually compatible.

vedant

>  
> 
> I'll send out a patch for review.
> 
> vedant
> 
> > On Jul 31, 2017, at 9:37 AM, Hans Wennborg  > > wrote:
> >
> > /sub
> >
> > I believe Vedant asked for this to be merged to 5.0, so I'd like to
> > merge the resolution too.
> >
> > On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits
> > mailto:cfe-commits@lists.llvm.org>> wrote:
> >> Hi Vedant,
> >>
> >> after this change our ubsanvptr bot fails like so:
> >>
> >> clang-6.0: error: implicitly disabling vptr sanitizer because null checking
> >> wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer]
> >>
> >> The bot uses -fsanitize=vptr. I have no idea what this warning is supposed
> >> to tell me. Maybe it could be reworded, or maybe it shouldn't be emitted?
> >>
> >> Thanks,
> >> Nico
> >>
> >> On Tue, Jul 25, 2017 at 3:34 PM, Vedant Kumar via cfe-commits
> >> mailto:cfe-commits@lists.llvm.org>> wrote:
> >>>
> >>> Author: vedantk
> >>> Date: Tue Jul 25 12:34:23 2017
> >>> New Revision: 309007
> >>>
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=309007&view=rev 
> >>> 
> >>> Log:
> >>> [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)
> >>>
> >>> The instrumentation generated by -fsanitize=vptr does not null check a
> >>> user pointer before loading from it. This causes crashes in the face of
> >>> UB member calls (this=nullptr), i.e it's causing user programs to crash
> >>> only after UBSan is turned on.
> >>>
> >>> The fix is to make run-time null checking a prerequisite for enabling
> >>> -fsanitize=vptr, and to then teach UBSan to reuse these run-time null
> >>> checks to make -fsanitize=vptr safe.
> >>>
> >>> Testing: check-clang, check-ubsan, a stage2 ubsan-enabled build
> >>>
> >>> Differential Revision: https://reviews.llvm.org/D35735 
> >>> 
> >>>
> >>> https://bugs.llvm.org/show_bug.cgi?id=33881 
> >>> 
> >>>
> >>> Modified:
> >>>cfe/trunk/docs/ReleaseNotes.rst
> >>>cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
> >>>cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
> >>>cfe/trunk/include/clang/Basic/DiagnosticGroups.td
> >>>cfe/trunk/lib/CodeGen/CGExpr.cpp
> >>>cfe/trunk/lib/Driver/SanitizerArgs.cpp
> >>>cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp
> >>>cfe/trunk/test/CodeGenCXX/ubsan-devirtualized-calls.cpp
> >>>cfe/trunk/test/CodeGenCXX/ubsan-type-checks.cpp
> >>>cfe/trunk/test/CodeGenCXX/ubsan-vtable-checks.cpp
> >>>cfe/trunk/test/Driver/fsanitize.c
> >>>cfe/trunk/test/Driver/rtti-options.cpp
> >>>
> >>> Modified: cfe/trunk/docs/ReleaseNotes.rst
> >>> URL:
> >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNotes.rst?rev=309007&r1=309006&r2=309007&view=diff
> >>>  
> >>> 
> >>>
> >>> ==
> >>> --- cfe/trunk/docs/ReleaseNotes.rst (original)
> >>> +++ cfe/trunk/docs/ReleaseNotes.rst Tue Jul 25 12:34:23 2017
> >>> @@ -155,7 +155,9 @@ Static Analyzer
> >>> Undefined Behavior Sanitizer (UBSan)
> >>> 
> >>>
> >>> -...
> >>> +The C++ dynamic type check now requires run-time null checking (i.e,
> >>> +`-fsanitize=vptr` cannot be used without `-fsanitize=null`). This change
> >>> does
> >>> +not impact users who rely on UBSan check groups (e.g
> >>> `-fsanitize=undefined`).
> >>>
> >>> Core Analysis Improvements
> >>> ==
> >>>
> >>> Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
> >>> URL:
> >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UndefinedBehaviorSanitizer.rst?rev=309007&r1=309006&r2=309007&view=diff
> >>>  
> >>> 

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.



Comment at: lib/Basic/Targets/AArch64.cpp:466-467
+  case CC_X86ThisCall:
+  case CC_X86FastCall:
+  case CC_X86VectorCall:
+return CCCR_Ignore;

rnk wrote:
> Do they really ignore __fastcall and __vectorcall on arm64?
> 
> I assume __thiscall and __stdcall are all over various Win SDK headers, so 
> they need to be ignored for compatibility, but I've never seen public 
> documented APIs using __vectorcall. The STL ifdefs out those overloads, right?
I don't have MSVC for arm64 to test with (but @mgrang does so he can check), 
but I included them for consistency and completeness.


https://reviews.llvm.org/D36105



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


https://reviews.llvm.org/D36099



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.



Comment at: lib/Basic/Targets/AArch64.cpp:466-467
+  case CC_X86ThisCall:
+  case CC_X86FastCall:
+  case CC_X86VectorCall:
+return CCCR_Ignore;

Do they really ignore __fastcall and __vectorcall on arm64?

I assume __thiscall and __stdcall are all over various Win SDK headers, so they 
need to be ignored for compatibility, but I've never seen public documented 
APIs using __vectorcall. The STL ifdefs out those overloads, right?


https://reviews.llvm.org/D36105



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.

lgtm


https://reviews.llvm.org/D36098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


https://reviews.llvm.org/D36100



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.

This is similar to what's done on arm and x86_64, where these calling 
conventions are silently ignored, as in SVN r245076 
(https://reviews.llvm.org/D12034).


https://reviews.llvm.org/D36105

Files:
  lib/Basic/Targets/AArch64.cpp
  lib/Basic/Targets/AArch64.h
  test/Parser/arm-windows-calling-convention-handling.c


Index: test/Parser/arm-windows-calling-convention-handling.c
===
--- test/Parser/arm-windows-calling-convention-handling.c
+++ test/Parser/arm-windows-calling-convention-handling.c
@@ -1,4 +1,5 @@
 // RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only 
-verify %s
+// RUN: %clang_cc1 -triple aarch64-windows -fms-compatibility -fsyntax-only 
-verify %s
 
 int __cdecl cdecl(int a, int b, int c, int d) { // expected-no-diagnostics
   return a + b + c + d;
Index: lib/Basic/Targets/AArch64.h
===
--- lib/Basic/Targets/AArch64.h
+++ lib/Basic/Targets/AArch64.h
@@ -105,6 +105,8 @@
 MacroBuilder &Builder) const override;
 
   BuiltinVaListKind getBuiltinVaListKind() const override;
+
+  CallingConvCheckResult checkCallingConvention(CallingConv CC) const override;
 };
 
 class LLVM_LIBRARY_VISIBILITY AArch64beTargetInfo : public AArch64TargetInfo {
Index: lib/Basic/Targets/AArch64.cpp
===
--- lib/Basic/Targets/AArch64.cpp
+++ lib/Basic/Targets/AArch64.cpp
@@ -458,6 +458,23 @@
   return TargetInfo::CharPtrBuiltinVaList;
 }
 
+TargetInfo::CallingConvCheckResult
+MicrosoftARM64TargetInfo::checkCallingConvention(CallingConv CC) const {
+  switch (CC) {
+  case CC_X86StdCall:
+  case CC_X86ThisCall:
+  case CC_X86FastCall:
+  case CC_X86VectorCall:
+return CCCR_Ignore;
+  case CC_C:
+  case CC_OpenCLKernel:
+  case CC_Win64:
+return CCCR_OK;
+  default:
+return CCCR_Warning;
+  }
+}
+
 DarwinAArch64TargetInfo::DarwinAArch64TargetInfo(const llvm::Triple &Triple,
  const TargetOptions &Opts)
 : DarwinTargetInfo(Triple, Opts) {


Index: test/Parser/arm-windows-calling-convention-handling.c
===
--- test/Parser/arm-windows-calling-convention-handling.c
+++ test/Parser/arm-windows-calling-convention-handling.c
@@ -1,4 +1,5 @@
 // RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple aarch64-windows -fms-compatibility -fsyntax-only -verify %s
 
 int __cdecl cdecl(int a, int b, int c, int d) { // expected-no-diagnostics
   return a + b + c + d;
Index: lib/Basic/Targets/AArch64.h
===
--- lib/Basic/Targets/AArch64.h
+++ lib/Basic/Targets/AArch64.h
@@ -105,6 +105,8 @@
 MacroBuilder &Builder) const override;
 
   BuiltinVaListKind getBuiltinVaListKind() const override;
+
+  CallingConvCheckResult checkCallingConvention(CallingConv CC) const override;
 };
 
 class LLVM_LIBRARY_VISIBILITY AArch64beTargetInfo : public AArch64TargetInfo {
Index: lib/Basic/Targets/AArch64.cpp
===
--- lib/Basic/Targets/AArch64.cpp
+++ lib/Basic/Targets/AArch64.cpp
@@ -458,6 +458,23 @@
   return TargetInfo::CharPtrBuiltinVaList;
 }
 
+TargetInfo::CallingConvCheckResult
+MicrosoftARM64TargetInfo::checkCallingConvention(CallingConv CC) const {
+  switch (CC) {
+  case CC_X86StdCall:
+  case CC_X86ThisCall:
+  case CC_X86FastCall:
+  case CC_X86VectorCall:
+return CCCR_Ignore;
+  case CC_C:
+  case CC_OpenCLKernel:
+  case CC_Win64:
+return CCCR_OK;
+  default:
+return CCCR_Warning;
+  }
+}
+
 DarwinAArch64TargetInfo::DarwinAArch64TargetInfo(const llvm::Triple &Triple,
  const TargetOptions &Opts)
 : DarwinTargetInfo(Triple, Opts) {
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

[Nico Weber via cfe-commits]

On Mon, Jul 31, 2017 at 1:18 PM, Vedant Kumar  wrote:

> The bot should start working again with -fsanitize=vptr,null.
>
> The warning can be improved. If we find -fno-sanitize=null in the argument
> list, we might say:
> implicitly disabling vptr sanitizer because "-fno-sanitize=null" was
> specified
>
> Otherwise we might say:
> implicitly disabling vptr sanitizer because null checking wasn't enabled,
> try specifying -fsanitize=null or -fsanitize=undefined
>

Hm, I still don't understand. I enable vptr ubsan checking, and I don't
want null checking (because chromium happens to be vptr clean and we want
to keep it that way, but we're not nullptr clean due to for example v8's
SMIs). How do I get yesterday's behavior back?


>
> I'll send out a patch for review.
>
> vedant
>
> > On Jul 31, 2017, at 9:37 AM, Hans Wennborg  wrote:
> >
> > /sub
> >
> > I believe Vedant asked for this to be merged to 5.0, so I'd like to
> > merge the resolution too.
> >
> > On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits
> >  wrote:
> >> Hi Vedant,
> >>
> >> after this change our ubsanvptr bot fails like so:
> >>
> >> clang-6.0: error: implicitly disabling vptr sanitizer because null
> checking
> >> wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer]
> >>
> >> The bot uses -fsanitize=vptr. I have no idea what this warning is
> supposed
> >> to tell me. Maybe it could be reworded, or maybe it shouldn't be
> emitted?
> >>
> >> Thanks,
> >> Nico
> >>
> >> On Tue, Jul 25, 2017 at 3:34 PM, Vedant Kumar via cfe-commits
> >>  wrote:
> >>>
> >>> Author: vedantk
> >>> Date: Tue Jul 25 12:34:23 2017
> >>> New Revision: 309007
> >>>
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=309007&view=rev
> >>> Log:
> >>> [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)
> >>>
> >>> The instrumentation generated by -fsanitize=vptr does not null check a
> >>> user pointer before loading from it. This causes crashes in the face of
> >>> UB member calls (this=nullptr), i.e it's causing user programs to crash
> >>> only after UBSan is turned on.
> >>>
> >>> The fix is to make run-time null checking a prerequisite for enabling
> >>> -fsanitize=vptr, and to then teach UBSan to reuse these run-time null
> >>> checks to make -fsanitize=vptr safe.
> >>>
> >>> Testing: check-clang, check-ubsan, a stage2 ubsan-enabled build
> >>>
> >>> Differential Revision: https://reviews.llvm.org/D35735
> >>>
> >>> https://bugs.llvm.org/show_bug.cgi?id=33881
> >>>
> >>> Modified:
> >>>cfe/trunk/docs/ReleaseNotes.rst
> >>>cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
> >>>cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
> >>>cfe/trunk/include/clang/Basic/DiagnosticGroups.td
> >>>cfe/trunk/lib/CodeGen/CGExpr.cpp
> >>>cfe/trunk/lib/Driver/SanitizerArgs.cpp
> >>>cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp
> >>>cfe/trunk/test/CodeGenCXX/ubsan-devirtualized-calls.cpp
> >>>cfe/trunk/test/CodeGenCXX/ubsan-type-checks.cpp
> >>>cfe/trunk/test/CodeGenCXX/ubsan-vtable-checks.cpp
> >>>cfe/trunk/test/Driver/fsanitize.c
> >>>cfe/trunk/test/Driver/rtti-options.cpp
> >>>
> >>> Modified: cfe/trunk/docs/ReleaseNotes.rst
> >>> URL:
> >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/
> ReleaseNotes.rst?rev=309007&r1=309006&r2=309007&view=diff
> >>>
> >>> 
> ==
> >>> --- cfe/trunk/docs/ReleaseNotes.rst (original)
> >>> +++ cfe/trunk/docs/ReleaseNotes.rst Tue Jul 25 12:34:23 2017
> >>> @@ -155,7 +155,9 @@ Static Analyzer
> >>> Undefined Behavior Sanitizer (UBSan)
> >>> 
> >>>
> >>> -...
> >>> +The C++ dynamic type check now requires run-time null checking (i.e,
> >>> +`-fsanitize=vptr` cannot be used without `-fsanitize=null`). This
> change
> >>> does
> >>> +not impact users who rely on UBSan check groups (e.g
> >>> `-fsanitize=undefined`).
> >>>
> >>> Core Analysis Improvements
> >>> ==
> >>>
> >>> Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
> >>> URL:
> >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/
> UndefinedBehaviorSanitizer.rst?rev=309007&r1=309006&r2=309007&view=diff
> >>>
> >>> 
> ==
> >>> --- cfe/trunk/docs/UndefinedBehaviorSanitizer.rst (original)
> >>> +++ cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Tue Jul 25 12:34:23
> 2017
> >>> @@ -130,11 +130,11 @@ Available checks are:
> >>>  it is often unintentional, so UBSan offers to catch it.
> >>>   -  ``-fsanitize=vla-bound``: A variable-length array whose bound
> >>>  does not evaluate to a positive value.
> >>> -  -  ``-fsanitize=vptr``: Use of an object whose vptr indicates that
> >>> - it is of the wrong dynamic type, or that its lifetime has not
> >>> - begun or has ended. Incompatible with ``-fno-rtti``. Link must
> >>> - be performed by ``clang++``, not ``clang``, to make sure
> >>> C++-sp

[PATCH] D36101: Fix usage of right shift operator in fold expressions

[Blitz Rakete via Phabricator via cfe-commits]

Rakete created this revision.

The right shift operator was not seen as a valid operator in a fold expression, 
which is PR32563.


https://reviews.llvm.org/D36101

Files:
  lib/Parse/ParseExpr.cpp
  test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp


Index: test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp
===
--- test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp
+++ test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp
@@ -0,0 +1,12 @@
+// RUN: %clang_cc1 -std=c++1z -verify %s
+
+// PR32563
+template
+constexpr int right_shift(int value, Ts... args) {
+  return (value >> ... >> args); // expected-no-diagnostics
+}
+
+void test_folds() {
+  static_assert(right_shift(10, 2) == 2);
+}
+
Index: lib/Parse/ParseExpr.cpp
===
--- lib/Parse/ParseExpr.cpp
+++ lib/Parse/ParseExpr.cpp
@@ -270,7 +270,7 @@
   return Level > prec::Unknown && Level != prec::Conditional;
 }
 static bool isFoldOperator(tok::TokenKind Kind) {
-  return isFoldOperator(getBinOpPrecedence(Kind, false, true));
+  return isFoldOperator(getBinOpPrecedence(Kind, true, true));
 }
 
 /// \brief Parse a binary expression that starts with \p LHS and has a


Index: test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp
===
--- test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp
+++ test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp
@@ -0,0 +1,12 @@
+// RUN: %clang_cc1 -std=c++1z -verify %s
+
+// PR32563
+template
+constexpr int right_shift(int value, Ts... args) {
+  return (value >> ... >> args); // expected-no-diagnostics
+}
+
+void test_folds() {
+  static_assert(right_shift(10, 2) == 2);
+}
+
Index: lib/Parse/ParseExpr.cpp
===
--- lib/Parse/ParseExpr.cpp
+++ lib/Parse/ParseExpr.cpp
@@ -270,7 +270,7 @@
   return Level > prec::Unknown && Level != prec::Conditional;
 }
 static bool isFoldOperator(tok::TokenKind Kind) {
-  return isFoldOperator(getBinOpPrecedence(Kind, false, true));
+  return isFoldOperator(getBinOpPrecedence(Kind, true, true));
 }
 
 /// \brief Parse a binary expression that starts with \p LHS and has a
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo created this revision.
Herald added subscribers: kristof.beyls, rengolin, aemerson.

https://reviews.llvm.org/D36100

Files:
  include/clang/Basic/Attr.td
  test/Sema/dllimport.c


Index: test/Sema/dllimport.c
===
--- test/Sema/dllimport.c
+++ test/Sema/dllimport.c
@@ -2,6 +2,7 @@
 // RUN: %clang_cc1 -triple x86_64-win32   -fsyntax-only -fms-extensions 
-verify -std=c11 -DMS %s
 // RUN: %clang_cc1 -triple i686-mingw32   -fsyntax-only -fms-extensions 
-verify -std=c11 -DGNU %s
 // RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions 
-verify -std=c99 -DGNU %s
+// RUN: %clang_cc1 -triple aarch64-win32  -fsyntax-only -fms-extensions 
-verify -std=c99 -DMS %s
 
 // Invalid usage.
 __declspec(dllimport) typedef int typedef1;
Index: include/clang/Basic/Attr.td
===
--- include/clang/Basic/Attr.td
+++ include/clang/Basic/Attr.td
@@ -268,10 +268,10 @@
 def TargetMSP430 : TargetArch<["msp430"]>;
 def TargetX86 : TargetArch<["x86"]>;
 def TargetAnyX86 : TargetArch<["x86", "x86_64"]>;
-def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
   let OSes = ["Win32"];
 }
-def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb", 
"aarch64"]> {
   let CXXABIs = ["Microsoft"];
 }
 


Index: test/Sema/dllimport.c
===
--- test/Sema/dllimport.c
+++ test/Sema/dllimport.c
@@ -2,6 +2,7 @@
 // RUN: %clang_cc1 -triple x86_64-win32   -fsyntax-only -fms-extensions -verify -std=c11 -DMS %s
 // RUN: %clang_cc1 -triple i686-mingw32   -fsyntax-only -fms-extensions -verify -std=c11 -DGNU %s
 // RUN: %clang_cc1 -triple x86_64-mingw32 -fsyntax-only -fms-extensions -verify -std=c99 -DGNU %s
+// RUN: %clang_cc1 -triple aarch64-win32  -fsyntax-only -fms-extensions -verify -std=c99 -DMS %s
 
 // Invalid usage.
 __declspec(dllimport) typedef int typedef1;
Index: include/clang/Basic/Attr.td
===
--- include/clang/Basic/Attr.td
+++ include/clang/Basic/Attr.td
@@ -268,10 +268,10 @@
 def TargetMSP430 : TargetArch<["msp430"]>;
 def TargetX86 : TargetArch<["x86"]>;
 def TargetAnyX86 : TargetArch<["x86", "x86_64"]>;
-def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetWindows : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
   let OSes = ["Win32"];
 }
-def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb"]> {
+def TargetMicrosoftCXXABI : TargetArch<["x86", "x86_64", "arm", "thumb", "aarch64"]> {
   let CXXABIs = ["Microsoft"];
 }
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang accepted this revision.
mgrang added a comment.
This revision is now accepted and ready to land.

LGTM.


https://reviews.llvm.org/D36098



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309607 - [Driver] Allow users to silence the warning that is issued when the

[Akira Hatanaka via cfe-commits]

Author: ahatanak
Date: Mon Jul 31 12:16:40 2017
New Revision: 309607

URL: http://llvm.org/viewvc/llvm-project?rev=309607&view=rev
Log:
[Driver] Allow users to silence the warning that is issued when the
deployment target is earlier than iOS 11 and the target is 32-bit.

This is a follow-up to r306922.

rdar://problem/32230613

Modified:
cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/lib/Driver/ToolChains/Darwin.cpp
cfe/trunk/test/Driver/darwin-version.c

Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td?rev=309607&r1=309606&r2=309607&view=diff
==
--- cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td Mon Jul 31 12:16:40 
2017
@@ -138,9 +138,10 @@ def err_drv_cc_print_options_failure : E
 def err_drv_lto_without_lld : Error<"LTO requires -fuse-ld=lld">;
 def err_drv_preamble_format : Error<
 "incorrect format for -preamble-bytes=N,END">;
-def err_invalid_ios_deployment_target : Error<
+def warn_invalid_ios_deployment_target : Warning<
   "invalid iOS deployment version '%0', iOS 10 is the maximum deployment "
-  "target for 32-bit targets">;
+  "target for 32-bit targets">, InGroup,
+  DefaultError;
 def err_drv_conflicting_deployment_targets : Error<
   "conflicting deployment targets, both '%0' and '%1' are present in 
environment">;
 def err_arc_unsupported_on_runtime : Error<

Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=309607&r1=309606&r2=309607&view=diff
==
--- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Mon Jul 31 12:16:40 2017
@@ -153,6 +153,9 @@ def GNUFlexibleArrayUnionMember : DiagGr
 def GNUFoldingConstant : DiagGroup<"gnu-folding-constant">;
 def FormatExtraArgs : DiagGroup<"format-extra-args">;
 def FormatZeroLength : DiagGroup<"format-zero-length">;
+
+def InvalidIOSDeploymentTarget : DiagGroup<"invalid-ios-deployment-target">;
+
 def CXX1zCompatMangling : DiagGroup<"c++1z-compat-mangling">;
 // Name of this warning in GCC.
 def NoexceptType : DiagGroup<"noexcept-type", [CXX1zCompatMangling]>;

Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Darwin.cpp?rev=309607&r1=309606&r2=309607&view=diff
==
--- cfe/trunk/lib/Driver/ToolChains/Darwin.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains/Darwin.cpp Mon Jul 31 12:16:40 2017
@@ -1179,7 +1179,7 @@ void Darwin::AddDeploymentTarget(Derived
   Driver::GetReleaseVersion(iOSVersion->getValue(), Major, Minor, Micro,
 HadExtra) &&
   Major > 10)
-getDriver().Diag(diag::err_invalid_ios_deployment_target)
+getDriver().Diag(diag::warn_invalid_ios_deployment_target)
 << iOSVersion->getAsString(Args);
 
   // Add a macro to differentiate between m(iphone|tv|watch)os-version-min=X.Y 
and
@@ -1228,7 +1228,7 @@ void Darwin::AddDeploymentTarget(Derived
 Driver::GetReleaseVersion(iOSTarget.c_str(), Major, Minor, Micro,
   HadExtra) &&
 Major > 10)
-  getDriver().Diag(diag::err_invalid_ios_deployment_target)
+  getDriver().Diag(diag::warn_invalid_ios_deployment_target)
   << std::string("IPHONEOS_DEPLOYMENT_TARGET=") + iOSTarget;
 
 // If there is no command-line argument to specify the Target version and
@@ -1298,6 +1298,15 @@ void Darwin::AddDeploymentTarget(Derived
   break;
 case llvm::Triple::IOS:
   getTriple().getiOSVersion(Major, Minor, Micro);
+
+  // iOS 10 is the maximum deployment target for 32-bit targets. If the
+  // inferred deployment target is iOS 11 or later, set it to 10.99.
+  if (getTriple().isArch32Bit() && Major >= 11) {
+Major = 10;
+Minor = 99;
+Micro = 99;
+  }
+
   OSTarget = &iOSTarget;
   break;
 case llvm::Triple::TvOS:
@@ -1393,13 +1402,6 @@ void Darwin::AddDeploymentTarget(Derived
 HadExtra || Major >= 100 || Minor >= 100 || Micro >= 100)
   getDriver().Diag(diag::err_drv_invalid_version_number)
   << iOSVersion->getAsString(Args);
-// iOS 10 is the maximum deployment target for 32-bit targets. If the
-// inferred deployment target is iOS 11 or later, set it to 10.99.
-if (getTriple().isArch32Bit() && Major >= 11) {
-  Major = 10;
-  Minor = 99;
-  Micro = 99;
-}
   } else if (Platform == TvOS) {
 

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo created this revision.
Herald added subscribers: kristof.beyls, rengolin, aemerson.

https://reviews.llvm.org/D36099

Files:
  test/Preprocessor/init.c


Index: test/Preprocessor/init.c
===
--- test/Preprocessor/init.c
+++ test/Preprocessor/init.c
@@ -1236,13 +1236,13 @@
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-apple-ios7.0 < 
/dev/null | FileCheck -match-full-lines -check-prefix AARCH64-DARWIN %s
 //
 // AARCH64-DARWIN: #define _LP64 1
-// AARCH64-NOT: #define __AARCH64EB__ 1
+// AARCH64-DARWIN-NOT: #define __AARCH64EB__ 1
 // AARCH64-DARWIN: #define __AARCH64EL__ 1
-// AARCH64-NOT: #define __AARCH_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __AARCH_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __ARM_64BIT_STATE 1
 // AARCH64-DARWIN: #define __ARM_ARCH 8
 // AARCH64-DARWIN: #define __ARM_ARCH_ISA_A64 1
-// AARCH64-NOT: #define __ARM_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __ARM_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __BIGGEST_ALIGNMENT__ 8
 // AARCH64-DARWIN: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
 // AARCH64-DARWIN: #define __CHAR16_TYPE__ unsigned short


Index: test/Preprocessor/init.c
===
--- test/Preprocessor/init.c
+++ test/Preprocessor/init.c
@@ -1236,13 +1236,13 @@
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-apple-ios7.0 < /dev/null | FileCheck -match-full-lines -check-prefix AARCH64-DARWIN %s
 //
 // AARCH64-DARWIN: #define _LP64 1
-// AARCH64-NOT: #define __AARCH64EB__ 1
+// AARCH64-DARWIN-NOT: #define __AARCH64EB__ 1
 // AARCH64-DARWIN: #define __AARCH64EL__ 1
-// AARCH64-NOT: #define __AARCH_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __AARCH_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __ARM_64BIT_STATE 1
 // AARCH64-DARWIN: #define __ARM_ARCH 8
 // AARCH64-DARWIN: #define __ARM_ARCH_ISA_A64 1
-// AARCH64-NOT: #define __ARM_BIG_ENDIAN 1
+// AARCH64-DARWIN-NOT: #define __ARM_BIG_ENDIAN 1
 // AARCH64-DARWIN: #define __BIGGEST_ALIGNMENT__ 8
 // AARCH64-DARWIN: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
 // AARCH64-DARWIN: #define __CHAR16_TYPE__ unsigned short
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.

Windows/ARM64 is a LLP64 environment, so don't set this default define.


https://reviews.llvm.org/D36098

Files:
  lib/Basic/Targets/AArch64.cpp
  test/Preprocessor/init.c

Index: test/Preprocessor/init.c
===
--- test/Preprocessor/init.c
+++ test/Preprocessor/init.c
@@ -1424,6 +1424,167 @@
 // AARCH64-DARWIN: #define __WINT_WIDTH__ 32
 // AARCH64-DARWIN: #define __aarch64__ 1
 
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=aarch64-windows-msvc < /dev/null | FileCheck -match-full-lines -check-prefix AARCH64-MSVC %s
+//
+// AARCH64-MSVC: #define _INTEGRAL_MAX_BITS 64
+// AARCH64-MSVC-NOT: #define _LP64 1
+// AARCH64-MSVC: #define _M_ARM64 1
+// AARCH64-MSVC: #define _WIN32 1
+// AARCH64-MSVC: #define _WIN64 1
+// AARCH64-MSVC: #define __AARCH64EL__ 1
+// AARCH64-MSVC: #define __ARM_64BIT_STATE 1
+// AARCH64-MSVC: #define __ARM_ACLE 200
+// AARCH64-MSVC: #define __ARM_ALIGN_MAX_STACK_PWR 4
+// AARCH64-MSVC: #define __ARM_ARCH 8
+// AARCH64-MSVC: #define __ARM_ARCH_ISA_A64 1
+// AARCH64-MSVC: #define __ARM_ARCH_PROFILE 'A'
+// AARCH64-MSVC: #define __ARM_FEATURE_CLZ 1
+// AARCH64-MSVC: #define __ARM_FEATURE_DIRECTED_ROUNDING 1
+// AARCH64-MSVC: #define __ARM_FEATURE_DIV 1
+// AARCH64-MSVC: #define __ARM_FEATURE_FMA 1
+// AARCH64-MSVC: #define __ARM_FEATURE_IDIV 1
+// AARCH64-MSVC: #define __ARM_FEATURE_LDREX 0xF
+// AARCH64-MSVC: #define __ARM_FEATURE_NUMERIC_MAXMIN 1
+// AARCH64-MSVC: #define __ARM_FEATURE_UNALIGNED 1
+// AARCH64-MSVC: #define __ARM_FP 0xE
+// AARCH64-MSVC: #define __ARM_FP16_ARGS 1
+// AARCH64-MSVC: #define __ARM_FP16_FORMAT_IEEE 1
+// AARCH64-MSVC: #define __ARM_PCS_AAPCS64 1
+// AARCH64-MSVC: #define __ARM_SIZEOF_MINIMAL_ENUM 4
+// AARCH64-MSVC: #define __ARM_SIZEOF_WCHAR_T 4
+// AARCH64-MSVC: #define __BIGGEST_ALIGNMENT__ 16
+// AARCH64-MSVC: #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
+// AARCH64-MSVC: #define __CHAR16_TYPE__ unsigned short
+// AARCH64-MSVC: #define __CHAR32_TYPE__ unsigned int
+// AARCH64-MSVC: #define __CHAR_BIT__ 8
+// AARCH64-MSVC: #define __CONSTANT_CFSTRINGS__ 1
+// AARCH64-MSVC: #define __DBL_DECIMAL_DIG__ 17
+// AARCH64-MSVC: #define __DBL_DENORM_MIN__ 4.9406564584124654e-324
+// AARCH64-MSVC: #define __DBL_DIG__ 15
+// AARCH64-MSVC: #define __DBL_EPSILON__ 2.2204460492503131e-16
+// AARCH64-MSVC: #define __DBL_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __DBL_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __DBL_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __DBL_MANT_DIG__ 53
+// AARCH64-MSVC: #define __DBL_MAX_10_EXP__ 308
+// AARCH64-MSVC: #define __DBL_MAX_EXP__ 1024
+// AARCH64-MSVC: #define __DBL_MAX__ 1.7976931348623157e+308
+// AARCH64-MSVC: #define __DBL_MIN_10_EXP__ (-307)
+// AARCH64-MSVC: #define __DBL_MIN_EXP__ (-1021)
+// AARCH64-MSVC: #define __DBL_MIN__ 2.2250738585072014e-308
+// AARCH64-MSVC: #define __DECIMAL_DIG__ __LDBL_DECIMAL_DIG__
+// AARCH64-MSVC: #define __FINITE_MATH_ONLY__ 0
+// AARCH64-MSVC: #define __FLT_DECIMAL_DIG__ 9
+// AARCH64-MSVC: #define __FLT_DENORM_MIN__ 1.40129846e-45F
+// AARCH64-MSVC: #define __FLT_DIG__ 6
+// AARCH64-MSVC: #define __FLT_EPSILON__ 1.19209290e-7F
+// AARCH64-MSVC: #define __FLT_EVAL_METHOD__ 0
+// AARCH64-MSVC: #define __FLT_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __FLT_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __FLT_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __FLT_MANT_DIG__ 24
+// AARCH64-MSVC: #define __FLT_MAX_10_EXP__ 38
+// AARCH64-MSVC: #define __FLT_MAX_EXP__ 128
+// AARCH64-MSVC: #define __FLT_MAX__ 3.40282347e+38F
+// AARCH64-MSVC: #define __FLT_MIN_10_EXP__ (-37)
+// AARCH64-MSVC: #define __FLT_MIN_EXP__ (-125)
+// AARCH64-MSVC: #define __FLT_MIN__ 1.17549435e-38F
+// AARCH64-MSVC: #define __FLT_RADIX__ 2
+// AARCH64-MSVC: #define __INT_MAX__ 2147483647
+// AARCH64-MSVC: #define __LDBL_DECIMAL_DIG__ 17
+// AARCH64-MSVC: #define __LDBL_DENORM_MIN__ 4.9406564584124654e-324L
+// AARCH64-MSVC: #define __LDBL_DIG__ 15
+// AARCH64-MSVC: #define __LDBL_EPSILON__ 2.2204460492503131e-16L
+// AARCH64-MSVC: #define __LDBL_HAS_DENORM__ 1
+// AARCH64-MSVC: #define __LDBL_HAS_INFINITY__ 1
+// AARCH64-MSVC: #define __LDBL_HAS_QUIET_NAN__ 1
+// AARCH64-MSVC: #define __LDBL_MANT_DIG__ 53
+// AARCH64-MSVC: #define __LDBL_MAX_10_EXP__ 308
+// AARCH64-MSVC: #define __LDBL_MAX_EXP__ 1024
+// AARCH64-MSVC: #define __LDBL_MAX__ 1.7976931348623157e+308L
+// AARCH64-MSVC: #define __LDBL_MIN_10_EXP__ (-307)
+// AARCH64-MSVC: #define __LDBL_MIN_EXP__ (-1021)
+// AARCH64-MSVC: #define __LDBL_MIN__ 2.2250738585072014e-308L
+// AARCH64-MSVC: #define __LITTLE_ENDIAN__ 1
+// AARCH64-MSVC: #define __LONG_LONG_MAX__ 9223372036854775807LL
+// AARCH64-MSVC: #define __LONG_MAX__ 2147483647L
+// AARCH64-MSVC-NOT: #define __LP64__ 1
+// AARCH64-MSVC: #define __NO_INLINE__ 1
+// AARCH64-MSVC: #define __OBJC_BOOL_IS_BOOL 0
+// AARCH64-MSVC: #define __ORDER_BIG_ENDI

[PATCH] D36074: [x86][inline-asm]Allow a pack of Control Debug to be properly picked

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


Repository:
  rL LLVM

https://reviews.llvm.org/D36074



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

[David Blaikie via cfe-commits]

On Thu, Jul 27, 2017 at 8:30 AM Dehao Chen via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> danielcdh marked an inline comment as done.
> danielcdh added a comment.
>
> Thanks for the review!
>
> In https://reviews.llvm.org/D35746#822498, @chandlerc wrote:
>
> > LGTM with a tiny tweak below.
> >
> > Would be good to add a test that this flag is being honored, either in
> this patch or in a follow-up.
>
>
> I'll add the test in a follow-up patch. Could you help suggest how to add
> a test for this? Shall I just invoke "clang -cc1
> -fexperimental-new-pass-manager" and check if discriminator is generated?
> That seems an integration test.
>

Yeah, things that interact between Clang and LLVM that aren't part of IR
basically slip through the cracks of the nice separation of testing here.
Either they go untested, or are tested in a more 'integration' like test -
though trying to find the minimal thing to examine that's not testing all
the features, etc.

If there's a clang argument that dumps the pass sequence? Or some other
'earlier' observable property like that? (how's the
-fexperimental-new-pass-manager flag tested, for example? maybe it isn't)


>
>
> https://reviews.llvm.org/D35746
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35449: [X86] Implement __builtin_cpu_is

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In https://reviews.llvm.org/D35449#826381, @craig.topper wrote:

> @erichkeane are you ok with this code for now? I think validateCPUIs gives 
> you what you need at least for Sema support for target attribute. You'll 
> probably need to refactor the CG code to make your ifunc resolver. But I 
> think you need to do that for the existing feature code that's similar 
> anyway. And from our side conversation it sounds like you're not ready for 
> that yet.


Thats correct.  I think this is right based on what I currently understand, 
though you/I will likely need to make some additional modifications to support 
my features.


https://reviews.llvm.org/D35449



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

[Han Shen via Phabricator via cfe-commits]

shenhan added a comment.

Ping? Can we make a decision on this? 
I've this simple one D35849: [UBSan] Provide default blacklist filename for 
UBSan  which, depending on this, shall be 
discarded or move forward.
If this CL stalls, I'll seek to proceed with https://reviews.llvm.org/D35849. 
Any how, https://reviews.llvm.org/D35849 gets wiped out whence this CL 
(https://reviews.llvm.org/D32842) is submitted.


https://reviews.llvm.org/D32842



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35449: [X86] Implement __builtin_cpu_is

[Craig Topper via Phabricator via cfe-commits]

craig.topper added a comment.

@erichkeane are you ok with this code for now? I think validateCPUIs gives you 
what you need at least for Sema support for target attribute. You'll probably 
need to refactor the CG code to make your ifunc resolver. But I think you need 
to do that for the existing feature code that's similar anyway. And from our 
side conversation it sounds like you're not ready for that yet.


https://reviews.llvm.org/D35449



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

[Taewook Oh via Phabricator via cfe-commits]

twoh updated this revision to Diff 108967.
twoh added a comment.

Update documentation. Please let me know if I need to update other documents as 
well. Thanks!


https://reviews.llvm.org/D34796

Files:
  docs/ClangCommandLineReference.rst
  include/clang/Driver/Options.td
  include/clang/Frontend/CodeGenOptions.def
  lib/CodeGen/BackendUtil.cpp
  lib/Driver/ToolChains/Clang.cpp
  lib/Frontend/CompilerInvocation.cpp
  test/CodeGen/Inputs/freorder-functions.prof
  test/CodeGen/freorder-functions.c
  test/Driver/function-sections.c

Index: test/Driver/function-sections.c
===
--- test/Driver/function-sections.c
+++ test/Driver/function-sections.c
@@ -6,6 +6,8 @@
 // CHECK-NODS-NOT: -fdata-sections
 // CHECK-US-NOT: -fno-unique-section-names
 // CHECK-NOUS: -fno-unique-section-names
+// CHECK-RF-NOT: -fno-reorder-functions
+// CHECK-NORF: -fno-reorder-functions
 
 // RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1   \
 // RUN: -target i386-unknown-linux \
@@ -72,3 +74,13 @@
 // RUN: -target i386-unknown-linux \
 // RUN: -fno-unique-section-names \
 // RUN:   | FileCheck --check-prefix=CHECK-NOUS %s
+
+// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1\
+// RUN: -target i386-unknown-linux \
+// RUN: -freorder-functions \
+// RUN:   | FileCheck --check-prefix=CHECK-RF %s
+
+// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1\
+// RUN: -target i386-unknown-linux \
+// RUN: -fno-reorder-functions \
+// RUN:   | FileCheck --check-prefix=CHECK-NORF %s
Index: test/CodeGen/freorder-functions.c
===
--- /dev/null
+++ test/CodeGen/freorder-functions.c
@@ -0,0 +1,22 @@
+// REQUIRES: x86-registered-target
+
+// RUN: %clang_cc1 -triple x86_64-pc-linux -S -O3 -ffunction-sections -fprofile-sample-use=%S/Inputs/freorder-functions.prof -o - < %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-pc-linux -S -O3 -ffunction-sections -fprofile-sample-use=%S/Inputs/freorder-functions.prof -fno-reorder-functions -o - < %s | FileCheck --check-prefix=CHECK-NOPREFIX %s
+
+// opt tool option precedes driver option.
+// RUN: %clang_cc1 -triple x86_64-pc-linux -S -O3 -ffunction-sections -fprofile-sample-use=%S/Inputs/freorder-functions.prof -fno-reorder-functions -mllvm -profile-guided-section-prefix=true -o - < %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-pc-linux -S -O3 -ffunction-sections -fprofile-sample-use=%S/Inputs/freorder-functions.prof -freorder-functions -mllvm -profile-guided-section-prefix=false -o - < %s | FileCheck --check-prefix=CHECK-NOPREFIX %s
+
+void hot_func() {
+  return;
+}
+
+void cold_func() {
+  hot_func();
+  return;
+}
+
+// CHECK: .section .text.hot.hot_func,"ax",@progbits
+// CHECK: .section .text.unlikely.cold_func,"ax",@progbits
+// CHECK-NOPREFIX: .section .text.hot_func,"ax",@progbits
+// CHECK-NOPREFIX: .section .text.cold_func,"ax",@progbits
Index: test/CodeGen/Inputs/freorder-functions.prof
===
--- /dev/null
+++ test/CodeGen/Inputs/freorder-functions.prof
@@ -0,0 +1,5 @@
+hot_func:1000:0
+ 1: 0
+cold_func:0:0
+ 1: 1
+ 2: 1
Index: lib/Frontend/CompilerInvocation.cpp
===
--- lib/Frontend/CompilerInvocation.cpp
+++ lib/Frontend/CompilerInvocation.cpp
@@ -647,6 +647,8 @@
OPT_fno_data_sections, false);
   Opts.UniqueSectionNames = Args.hasFlag(OPT_funique_section_names,
  OPT_fno_unique_section_names, true);
+  Opts.ReorderFunctions =
+  Args.hasFlag(OPT_freorder_functions, OPT_fno_reorder_functions, true);
 
   Opts.MergeFunctions = Args.hasArg(OPT_fmerge_functions);
 
Index: lib/Driver/ToolChains/Clang.cpp
===
--- lib/Driver/ToolChains/Clang.cpp
+++ lib/Driver/ToolChains/Clang.cpp
@@ -2899,6 +2899,10 @@
 options::OPT_fno_unique_section_names, true))
 CmdArgs.push_back("-fno-unique-section-names");
 
+  if (!Args.hasFlag(options::OPT_freorder_functions,
+options::OPT_fno_reorder_functions, true))
+CmdArgs.push_back("-fno-reorder-functions");
+
   Args.AddAllArgs(CmdArgs, options::OPT_finstrument_functions);
 
   addPGOAndCoverageFlags(C, D, Output, Args, CmdArgs);
Index: lib/CodeGen/BackendUtil.cpp
===
--- lib/CodeGen/BackendUtil.cpp
+++ lib/CodeGen/BackendUtil.cpp
@@ -429,6 +429,7 @@
   Options.FunctionSections = CodeGenOpts.FunctionSections;
   Options.DataSections = CodeGenOpts.DataSections;
   Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;
+  Options.ReorderFunctions = CodeGenOpts.ReorderFunctions;
   Options.EmulatedTLS = CodeGenOpts.EmulatedTLS;
   Options.DebuggerTuning = CodeGenOpts.getDe

Re: [PATCH] D35783: Ignore shadowing for declarations coming from within macros.

[David Blaikie via cfe-commits]

On Tue, Jul 25, 2017 at 1:19 AM Roman Lebedev via Phabricator via
cfe-commits  wrote:

> lebedev.ri added a comment.
>
> How does this relate to the gcc behavior?
> I suspect not everyone would want to have this relaxed `-Wshadow` mode.
>

Generally I think the goal hasn't been to allow a clang user to keep their
code GCC warning clean - if a warning has too many false positives, it
can/will be changed in clang, even if it means it misses cases GCC will
flag. (for example -Wreturn-type, which pops up a lot in the LLVM codebase
when it fires on code that's probably unreachable that Clang is nice enough
to assume won't be reached (code after a fully covered switch over enum,
where each case returns))

Though it's not unheard of to bisect the diagnostic space to provide these
variations if suitable - but I wouldn't suggest doing so 'just' for
compatibility with GCC.


> Perhaps it could be hidden under some new flag, which is not going to be
> automatically enabled by `-Weverything`.
>

Nothing is ever not going to be automatically enabled by -Weverything (the
intent is that it's really, always, everything). Or perhaps you meant
-Wall? (which isn't everything & that ship's already sailed, so usually
more nuanced choices are made about what goes in there, etc)


> Like, `-Wshadow-in-macros` which does nothing compared to `-Wshadow`, and
> then `-Wno-shadow-in-macros` which enables this relaxed mode?
>
>
> https://reviews.llvm.org/D35783
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309496 - Improve readability of CXX method overrides list

[David Blaikie via cfe-commits]

Test coverage?

On Sun, Jul 30, 2017 at 5:52 AM Lenar Safin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: lll
> Date: Sat Jul 29 13:42:58 2017
> New Revision: 309496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309496&view=rev
> Log:
> Improve readability of CXX method overrides list
>
> Summary:
> Separate CXX method overrides list entries with commas.
>
> Reviewers: lhames
>
> Reviewed By: lhames
>
> Subscribers: llvm-commits
>
> Differential Revision: https://reviews.llvm.org/D35800
>
>
> Modified:
> cfe/trunk/lib/AST/ASTDumper.cpp
>
> Modified: cfe/trunk/lib/AST/ASTDumper.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=309496&r1=309495&r2=309496&view=diff
>
> ==
> --- cfe/trunk/lib/AST/ASTDumper.cpp (original)
> +++ cfe/trunk/lib/AST/ASTDumper.cpp Sat Jul 29 13:42:58 2017
> @@ -1184,7 +1184,7 @@ void ASTDumper::VisitFunctionDecl(const
>   I != E; ++I)
>dumpCXXCtorInitializer(*I);
>
> -  if (const CXXMethodDecl *MD = dyn_cast(D))
> +  if (const CXXMethodDecl *MD = dyn_cast(D)) {
>  if (MD->size_overridden_methods() != 0) {
>auto dumpOverride =
>  [=](const CXXMethodDecl *D) {
> @@ -1199,11 +1199,14 @@ void ASTDumper::VisitFunctionDecl(const
>  dumpOverride(*FirstOverrideItr);
>  for (const auto *Override :
> llvm::make_range(FirstOverrideItr + 1,
> -MD->end_overridden_methods()))
> +MD->end_overridden_methods())) {
> +  OS << ", ";
>dumpOverride(Override);
> +}
>  OS << " ]";
>});
>  }
> +  }
>
>if (D->doesThisDeclarationHaveABody())
>  dumpStmt(D->getBody());
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxxabi] r309349 - [demangler] Fix some overzealous -Wreturn-type errors

[David Blaikie via cfe-commits]

On Thu, Jul 27, 2017 at 6:35 PM Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

> Author: epilk
> Date: Thu Jul 27 18:35:14 2017
> New Revision: 309349
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309349&view=rev
> Log:
> [demangler] Fix some overzealous -Wreturn-type errors
>

I'm guessing this is GCC's -Wreturn-type after a
fully-covered-all-returning switch?

That's usually addressed by using llvm_unreachable after the switch, rather
than a dead return. (not sure if you've something like llvm_unreachable in
libcxxabi to use?)


>
> Modified:
> libcxxabi/trunk/src/cxa_demangle.cpp
>
> Modified: libcxxabi/trunk/src/cxa_demangle.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=309349&r1=309348&r2=309349&view=diff
>
> ==
> --- libcxxabi/trunk/src/cxa_demangle.cpp (original)
> +++ libcxxabi/trunk/src/cxa_demangle.cpp Thu Jul 27 18:35:14 2017
> @@ -896,6 +896,7 @@ public:
>  case SpecialSubKind::iostream:
>return StringView("basic_iostream");
>  }
> +return StringView();
>}
>
>void printLeft(OutputStream &S) const override {
> @@ -944,6 +945,7 @@ public:
>  case SpecialSubKind::iostream:
>return StringView("iostream");
>  }
> +return StringView();
>}
>
>void printLeft(OutputStream &S) const override {
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

[Vedant Kumar via cfe-commits]

+ Nico, sorry I missed your email in the reply-all. Here's a revised version of 
the warning:

https://reviews.llvm.org/D36096 

vedant

> On Jul 31, 2017, at 10:18 AM, Vedant Kumar via cfe-commits 
>  wrote:
> 
> The bot should start working again with -fsanitize=vptr,null.
> 
> The warning can be improved. If we find -fno-sanitize=null in the argument 
> list, we might say:
> implicitly disabling vptr sanitizer because "-fno-sanitize=null" was specified
> 
> Otherwise we might say:
> implicitly disabling vptr sanitizer because null checking wasn't enabled, try 
> specifying -fsanitize=null or -fsanitize=undefined
> 
> I'll send out a patch for review.
> 
> vedant
> 
>> On Jul 31, 2017, at 9:37 AM, Hans Wennborg  wrote:
>> 
>> /sub
>> 
>> I believe Vedant asked for this to be merged to 5.0, so I'd like to
>> merge the resolution too.
>> 
>> On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits
>>  wrote:
>>> Hi Vedant,
>>> 
>>> after this change our ubsanvptr bot fails like so:
>>> 
>>> clang-6.0: error: implicitly disabling vptr sanitizer because null checking
>>> wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer]
>>> 
>>> The bot uses -fsanitize=vptr. I have no idea what this warning is supposed
>>> to tell me. Maybe it could be reworded, or maybe it shouldn't be emitted?
>>> 
>>> Thanks,
>>> Nico
>>> 
>>> On Tue, Jul 25, 2017 at 3:34 PM, Vedant Kumar via cfe-commits
>>>  wrote:
 
 Author: vedantk
 Date: Tue Jul 25 12:34:23 2017
 New Revision: 309007
 
 URL: http://llvm.org/viewvc/llvm-project?rev=309007&view=rev
 Log:
 [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)
 
 The instrumentation generated by -fsanitize=vptr does not null check a
 user pointer before loading from it. This causes crashes in the face of
 UB member calls (this=nullptr), i.e it's causing user programs to crash
 only after UBSan is turned on.
 
 The fix is to make run-time null checking a prerequisite for enabling
 -fsanitize=vptr, and to then teach UBSan to reuse these run-time null
 checks to make -fsanitize=vptr safe.
 
 Testing: check-clang, check-ubsan, a stage2 ubsan-enabled build
 
 Differential Revision: https://reviews.llvm.org/D35735
 
 https://bugs.llvm.org/show_bug.cgi?id=33881
 
 Modified:
   cfe/trunk/docs/ReleaseNotes.rst
   cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
   cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
   cfe/trunk/include/clang/Basic/DiagnosticGroups.td
   cfe/trunk/lib/CodeGen/CGExpr.cpp
   cfe/trunk/lib/Driver/SanitizerArgs.cpp
   cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp
   cfe/trunk/test/CodeGenCXX/ubsan-devirtualized-calls.cpp
   cfe/trunk/test/CodeGenCXX/ubsan-type-checks.cpp
   cfe/trunk/test/CodeGenCXX/ubsan-vtable-checks.cpp
   cfe/trunk/test/Driver/fsanitize.c
   cfe/trunk/test/Driver/rtti-options.cpp
 
 Modified: cfe/trunk/docs/ReleaseNotes.rst
 URL:
 http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNotes.rst?rev=309007&r1=309006&r2=309007&view=diff
 
 ==
 --- cfe/trunk/docs/ReleaseNotes.rst (original)
 +++ cfe/trunk/docs/ReleaseNotes.rst Tue Jul 25 12:34:23 2017
 @@ -155,7 +155,9 @@ Static Analyzer
 Undefined Behavior Sanitizer (UBSan)
 
 
 -...
 +The C++ dynamic type check now requires run-time null checking (i.e,
 +`-fsanitize=vptr` cannot be used without `-fsanitize=null`). This change
 does
 +not impact users who rely on UBSan check groups (e.g
 `-fsanitize=undefined`).
 
 Core Analysis Improvements
 ==
 
 Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
 URL:
 http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UndefinedBehaviorSanitizer.rst?rev=309007&r1=309006&r2=309007&view=diff
 
 ==
 --- cfe/trunk/docs/UndefinedBehaviorSanitizer.rst (original)
 +++ cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Tue Jul 25 12:34:23 2017
 @@ -130,11 +130,11 @@ Available checks are:
 it is often unintentional, so UBSan offers to catch it.
  -  ``-fsanitize=vla-bound``: A variable-length array whose bound
 does not evaluate to a positive value.
 -  -  ``-fsanitize=vptr``: Use of an object whose vptr indicates that
 - it is of the wrong dynamic type, or that its lifetime has not
 - begun or has ended. Incompatible with ``-fno-rtti``. Link must
 - be performed by ``clang++``, not ``clang``, to make sure
 C++-specific
 - parts of the runtime library and C++ standard libraries are present.
 +  -  ``-fsanitize=vptr``: Use of an object whose vptr indicates that it
 is of
 + the

[PATCH] D35564: Suppress -pedantic warnings about GNU extension StmtExpr in glibc's assert macro

[Khem Raj via Phabricator via cfe-commits]

raj.khem added a comment.

There is a proposed fix for glibc's assert here

https://sourceware.org/ml/libc-alpha/2017-07/msg00227.html

despite that, this patch in general seems useful.


https://reviews.llvm.org/D35564



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36096: [ubsan] Make the 'vptr check disabled' warning more helpful

[Vedant Kumar via Phabricator via cfe-commits]

vsk created this revision.

If -fsanitize=vptr is passed without -fsanitize=null being specified, it will 
say:

  warning: implicitly disabling vptr sanitizer because null checking wasn't 
enabled (try specifying -fsanitize=null or -fsanitize=undefined)

Otherwise if the vptr check is enabled and null checking is explicitly 
disabled, it will say:

warning: implicitly disabling vptr sanitizer because null checking wasn't 
enabled (try removing -fno-sanitize=null)

See the mailing list thread re: r309007


https://reviews.llvm.org/D36096

Files:
  include/clang/Basic/DiagnosticDriverKinds.td
  lib/Driver/SanitizerArgs.cpp
  test/Driver/fsanitize.c


Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -58,9 +58,10 @@
 // RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -fno-rtti %s -### 
2>&1 | FileCheck %s --check-prefix=CHECK-UNDEFINED-NO-RTTI
 // CHECK-UNDEFINED-NO-RTTI-NOT: vptr
 
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined 
-fno-sanitize=null %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-NO-NULL
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=vptr %s -### 2>&1 | 
FileCheck %s --check-prefix=CHECK-VPTR-NO-NULL
-// CHECK-VPTR-NO-NULL: warning: implicitly disabling vptr sanitizer because 
null checking wasn't enabled
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined 
-fno-sanitize=null %s -### 2>&1 | FileCheck %s 
--check-prefix=CHECK-VPTR-EXPLICIT-NO-NULL
+// CHECK-VPTR-EXPLICIT-NO-NULL: warning: implicitly disabling vptr sanitizer 
because null checking wasn't enabled (try removing -fno-sanitize=null)
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=vptr %s -### 2>&1 | 
FileCheck %s --check-prefix=CHECK-VPTR-IMPLICIT-NO-NULL
+// CHECK-VPTR-IMPLICIT-NO-NULL: warning: implicitly disabling vptr sanitizer 
because null checking wasn't enabled (try specifying -fsanitize=null or 
-fsanitize=undefined)
 
 // RUN: %clang -target x86_64-linux-gnu -fsanitize=address,thread -fno-rtti %s 
-### 2>&1 | FileCheck %s --check-prefix=CHECK-SANA-SANT
 // CHECK-SANA-SANT: '-fsanitize=address' not allowed with '-fsanitize=thread'
Index: lib/Driver/SanitizerArgs.cpp
===
--- lib/Driver/SanitizerArgs.cpp
+++ lib/Driver/SanitizerArgs.cpp
@@ -311,7 +311,7 @@
   // instrumentation is broken without run-time null checks).
   if ((Kinds & Vptr) && !(Kinds & Null)) {
 Kinds &= ~Vptr;
-D.Diag(diag::warn_drv_disabling_vptr_no_null_check);
+D.Diag(diag::warn_drv_disabling_vptr_no_null_check) << !!(AllRemove & 
Null);
   }
 
   // Check that LTO is enabled if we need it.
Index: include/clang/Basic/DiagnosticDriverKinds.td
===
--- include/clang/Basic/DiagnosticDriverKinds.td
+++ include/clang/Basic/DiagnosticDriverKinds.td
@@ -232,7 +232,7 @@
   "implicitly disabling vptr sanitizer because rtti wasn't enabled">,
   InGroup;
 def warn_drv_disabling_vptr_no_null_check : Warning<
-  "implicitly disabling vptr sanitizer because null checking wasn't enabled">,
+  "implicitly disabling vptr sanitizer because null checking wasn't enabled 
(try %select{specifying -fsanitize=null or -fsanitize=undefined|removing 
-fno-sanitize=null}0)">,
   InGroup;
 def warn_drv_object_size_disabled_O0 : Warning<
   "the object size sanitizer has no effect at -O0, but is explicitly enabled: 
%0">,


Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -58,9 +58,10 @@
 // RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -fno-rtti %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-UNDEFINED-NO-RTTI
 // CHECK-UNDEFINED-NO-RTTI-NOT: vptr
 
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -fno-sanitize=null %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-NO-NULL
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=vptr %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-NO-NULL
-// CHECK-VPTR-NO-NULL: warning: implicitly disabling vptr sanitizer because null checking wasn't enabled
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -fno-sanitize=null %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-EXPLICIT-NO-NULL
+// CHECK-VPTR-EXPLICIT-NO-NULL: warning: implicitly disabling vptr sanitizer because null checking wasn't enabled (try removing -fno-sanitize=null)
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=vptr %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-VPTR-IMPLICIT-NO-NULL
+// CHECK-VPTR-IMPLICIT-NO-NULL: warning: implicitly disabling vptr sanitizer because null checking wasn't enabled (try specifying -fsanitize=null or -fsanitize=undefined)
 
 // RUN: %clang -target x86_64-linux-gnu -fsanitize=address,thread -fno-rtti %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANA-SANT
 // CHECK-SANA-SANT: '-fsanitize=addr

[PATCH] D36072: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

[Martin Storsjö via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL309598: [Targets] Move addCygMingDefines into the 
arch-independent Targets.cpp (NFC) (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D36072?vs=108865&id=108954#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D36072

Files:
  cfe/trunk/lib/Basic/Targets.cpp
  cfe/trunk/lib/Basic/Targets.h
  cfe/trunk/lib/Basic/Targets/X86.h


Index: cfe/trunk/lib/Basic/Targets/X86.h
===
--- cfe/trunk/lib/Basic/Targets/X86.h
+++ cfe/trunk/lib/Basic/Targets/X86.h
@@ -691,30 +691,6 @@
   }
 };
 
-static void addCygMingDefines(const LangOptions &Opts, MacroBuilder &Builder) {
-  // Mingw and cygwin define __declspec(a) to __attribute__((a)).  Clang
-  // supports __declspec natively under -fms-extensions, but we define a no-op
-  // __declspec macro anyway for pre-processor compatibility.
-  if (Opts.MicrosoftExt)
-Builder.defineMacro("__declspec", "__declspec");
-  else
-Builder.defineMacro("__declspec(a)", "__attribute__((a))");
-
-  if (!Opts.MicrosoftExt) {
-// Provide macros for all the calling convention keywords.  Provide both
-// single and double underscore prefixed variants.  These are available on
-// x64 as well as x86, even though they have no effect.
-const char *CCs[] = {"cdecl", "stdcall", "fastcall", "thiscall", "pascal"};
-for (const char *CC : CCs) {
-  std::string GCCSpelling = "__attribute__((__";
-  GCCSpelling += CC;
-  GCCSpelling += "__))";
-  Builder.defineMacro(Twine("_") + CC, GCCSpelling);
-  Builder.defineMacro(Twine("__") + CC, GCCSpelling);
-}
-  }
-}
-
 // x86-32 MinGW target
 class LLVM_LIBRARY_VISIBILITY MinGWX86_32TargetInfo
 : public WindowsX86_32TargetInfo {
Index: cfe/trunk/lib/Basic/Targets.h
===
--- cfe/trunk/lib/Basic/Targets.h
+++ cfe/trunk/lib/Basic/Targets.h
@@ -42,6 +42,10 @@
 LLVM_LIBRARY_VISIBILITY
 void addMinGWDefines(const clang::LangOptions &Opts,
  clang::MacroBuilder &Builder);
+
+LLVM_LIBRARY_VISIBILITY
+void addCygMingDefines(const clang::LangOptions &Opts,
+   clang::MacroBuilder &Builder);
 } // namespace targets
 } // namespace clang
 #endif // LLVM_CLANG_LIB_BASIC_TARGETS_H
Index: cfe/trunk/lib/Basic/Targets.cpp
===
--- cfe/trunk/lib/Basic/Targets.cpp
+++ cfe/trunk/lib/Basic/Targets.cpp
@@ -73,6 +73,30 @@
 Builder.defineMacro("__tune_" + CPUName + "__");
 }
 
+void addCygMingDefines(const LangOptions &Opts, MacroBuilder &Builder) {
+  // Mingw and cygwin define __declspec(a) to __attribute__((a)).  Clang
+  // supports __declspec natively under -fms-extensions, but we define a no-op
+  // __declspec macro anyway for pre-processor compatibility.
+  if (Opts.MicrosoftExt)
+Builder.defineMacro("__declspec", "__declspec");
+  else
+Builder.defineMacro("__declspec(a)", "__attribute__((a))");
+
+  if (!Opts.MicrosoftExt) {
+// Provide macros for all the calling convention keywords.  Provide both
+// single and double underscore prefixed variants.  These are available on
+// x64 as well as x86, even though they have no effect.
+const char *CCs[] = {"cdecl", "stdcall", "fastcall", "thiscall", "pascal"};
+for (const char *CC : CCs) {
+  std::string GCCSpelling = "__attribute__((__";
+  GCCSpelling += CC;
+  GCCSpelling += "__))";
+  Builder.defineMacro(Twine("_") + CC, GCCSpelling);
+  Builder.defineMacro(Twine("__") + CC, GCCSpelling);
+}
+  }
+}
+
 void addMinGWDefines(const LangOptions &Opts, MacroBuilder &Builder) {
   Builder.defineMacro("__MSVCRT__");
   Builder.defineMacro("__MINGW32__");


Index: cfe/trunk/lib/Basic/Targets/X86.h
===
--- cfe/trunk/lib/Basic/Targets/X86.h
+++ cfe/trunk/lib/Basic/Targets/X86.h
@@ -691,30 +691,6 @@
   }
 };
 
-static void addCygMingDefines(const LangOptions &Opts, MacroBuilder &Builder) {
-  // Mingw and cygwin define __declspec(a) to __attribute__((a)).  Clang
-  // supports __declspec natively under -fms-extensions, but we define a no-op
-  // __declspec macro anyway for pre-processor compatibility.
-  if (Opts.MicrosoftExt)
-Builder.defineMacro("__declspec", "__declspec");
-  else
-Builder.defineMacro("__declspec(a)", "__attribute__((a))");
-
-  if (!Opts.MicrosoftExt) {
-// Provide macros for all the calling convention keywords.  Provide both
-// single and double underscore prefixed variants.  These are available on
-// x64 as well as x86, even though they have no effect.
-const char *CCs[] = {"cdecl", "stdcall", "fastcall", "thiscall", "pascal"};
-for (const char *CC : CCs) {
-  std::string GCCSpelling = "__attribute__((__";
-  GCCSpelling += CC;
-  GCCSpelling += "__)

r309598 - [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

[Martin Storsjo via cfe-commits]

Author: mstorsjo
Date: Mon Jul 31 11:17:38 2017
New Revision: 309598

URL: http://llvm.org/viewvc/llvm-project?rev=309598&view=rev
Log:
[Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

This fixes a dependency inconsistency, where addMinGWDefines in Targets.cpp
(used from other architectures than X86) called the addCygMingDefines function
in X86.h.

This was inconsistently split in SVN r308791 (D35701).

Differential Revision: https://reviews.llvm.org/D36072

Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Basic/Targets.h
cfe/trunk/lib/Basic/Targets/X86.h

Modified: cfe/trunk/lib/Basic/Targets.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=309598&r1=309597&r2=309598&view=diff
==
--- cfe/trunk/lib/Basic/Targets.cpp (original)
+++ cfe/trunk/lib/Basic/Targets.cpp Mon Jul 31 11:17:38 2017
@@ -73,6 +73,30 @@ void defineCPUMacros(MacroBuilder &Build
 Builder.defineMacro("__tune_" + CPUName + "__");
 }
 
+void addCygMingDefines(const LangOptions &Opts, MacroBuilder &Builder) {
+  // Mingw and cygwin define __declspec(a) to __attribute__((a)).  Clang
+  // supports __declspec natively under -fms-extensions, but we define a no-op
+  // __declspec macro anyway for pre-processor compatibility.
+  if (Opts.MicrosoftExt)
+Builder.defineMacro("__declspec", "__declspec");
+  else
+Builder.defineMacro("__declspec(a)", "__attribute__((a))");
+
+  if (!Opts.MicrosoftExt) {
+// Provide macros for all the calling convention keywords.  Provide both
+// single and double underscore prefixed variants.  These are available on
+// x64 as well as x86, even though they have no effect.
+const char *CCs[] = {"cdecl", "stdcall", "fastcall", "thiscall", "pascal"};
+for (const char *CC : CCs) {
+  std::string GCCSpelling = "__attribute__((__";
+  GCCSpelling += CC;
+  GCCSpelling += "__))";
+  Builder.defineMacro(Twine("_") + CC, GCCSpelling);
+  Builder.defineMacro(Twine("__") + CC, GCCSpelling);
+}
+  }
+}
+
 void addMinGWDefines(const LangOptions &Opts, MacroBuilder &Builder) {
   Builder.defineMacro("__MSVCRT__");
   Builder.defineMacro("__MINGW32__");

Modified: cfe/trunk/lib/Basic/Targets.h
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.h?rev=309598&r1=309597&r2=309598&view=diff
==
--- cfe/trunk/lib/Basic/Targets.h (original)
+++ cfe/trunk/lib/Basic/Targets.h Mon Jul 31 11:17:38 2017
@@ -42,6 +42,10 @@ void defineCPUMacros(clang::MacroBuilder
 LLVM_LIBRARY_VISIBILITY
 void addMinGWDefines(const clang::LangOptions &Opts,
  clang::MacroBuilder &Builder);
+
+LLVM_LIBRARY_VISIBILITY
+void addCygMingDefines(const clang::LangOptions &Opts,
+   clang::MacroBuilder &Builder);
 } // namespace targets
 } // namespace clang
 #endif // LLVM_CLANG_LIB_BASIC_TARGETS_H

Modified: cfe/trunk/lib/Basic/Targets/X86.h
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets/X86.h?rev=309598&r1=309597&r2=309598&view=diff
==
--- cfe/trunk/lib/Basic/Targets/X86.h (original)
+++ cfe/trunk/lib/Basic/Targets/X86.h Mon Jul 31 11:17:38 2017
@@ -691,30 +691,6 @@ public:
   }
 };
 
-static void addCygMingDefines(const LangOptions &Opts, MacroBuilder &Builder) {
-  // Mingw and cygwin define __declspec(a) to __attribute__((a)).  Clang
-  // supports __declspec natively under -fms-extensions, but we define a no-op
-  // __declspec macro anyway for pre-processor compatibility.
-  if (Opts.MicrosoftExt)
-Builder.defineMacro("__declspec", "__declspec");
-  else
-Builder.defineMacro("__declspec(a)", "__attribute__((a))");
-
-  if (!Opts.MicrosoftExt) {
-// Provide macros for all the calling convention keywords.  Provide both
-// single and double underscore prefixed variants.  These are available on
-// x64 as well as x86, even though they have no effect.
-const char *CCs[] = {"cdecl", "stdcall", "fastcall", "thiscall", "pascal"};
-for (const char *CC : CCs) {
-  std::string GCCSpelling = "__attribute__((__";
-  GCCSpelling += CC;
-  GCCSpelling += "__))";
-  Builder.defineMacro(Twine("_") + CC, GCCSpelling);
-  Builder.defineMacro(Twine("__") + CC, GCCSpelling);
-}
-  }
-}
-
 // x86-32 MinGW target
 class LLVM_LIBRARY_VISIBILITY MinGWX86_32TargetInfo
 : public WindowsX86_32TargetInfo {


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

It might make sense to add a breakpoint at `PartialDiagnostic(unsigned DiagID, 
StorageAllocator &Allocator)`, I'll check how that works.

I reckon it should be possible to have a script that could find the name of all 
emitted diagnostics. Let's say we'd like to run clang with `-cc1 main.cpp`.
If we run it in LLDB and put a breakpoint at DiagnosticsEngine::Report, we 
could add a command to that breakpoint that would print a unique string and the 
diagnostic id.
The script would redirect the stdout from LLDB/Clang, but it would replace the 
occurrence of the unique string and diagnostic id with the name of the 
diagnostic by evaluating some `diagtool` that maps the id back to the 
diagnostic (If there are multiple same diagnostics it could also add an id and 
then we could extend this script to stop at the Nth specific diagnostic).


Repository:
  rL LLVM

https://reviews.llvm.org/D36083



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

[Hans Wennborg via cfe-commits]

Thanks! r309588.

On Mon, Jul 31, 2017 at 10:25 AM, Craig Topper  wrote:
> We can merge all three patches to 5.0.
>
> ~Craig
>
> On Mon, Jul 31, 2017 at 9:59 AM, Hans Wennborg  wrote:
>>
>> Craig, Simon asked for this to be merged to 5.0 together with r309382
>> and r309383 for PR33830. What do you think?
>>
>> On Sat, Jul 29, 2017 at 8:33 AM, Simon Pilgrim via cfe-commits
>>  wrote:
>> > Author: rksimon
>> > Date: Sat Jul 29 08:33:34 2017
>> > New Revision: 309488
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=309488&view=rev
>> > Log:
>> > [X86][AVX] Ensure vector non-temporal load/store intrinsics force
>> > pointer alignment (PR33830)
>> >
>> > Clang specifies a max type alignment of 16 bytes on darwin targets
>> > (annoyingly in the driver not via cc1), meaning that the builtin 
>> > nontemporal
>> > stores don't correctly align the loads/stores to 32 or 64 bytes when
>> > required, resulting in lowering to temporal unaligned loads/stores.
>> >
>> > This patch casts the vectors to explicitly aligned types prior to the
>> > load/store to ensure that the require alignment is respected.
>> >
>> > Differential Revision: https://reviews.llvm.org/D35996
>> >
>> > Modified:
>> > cfe/trunk/lib/Headers/avx2intrin.h
>> > cfe/trunk/lib/Headers/avx512fintrin.h
>> > cfe/trunk/lib/Headers/avxintrin.h
>> > cfe/trunk/test/CodeGen/x86-nontemporal.c
>> >
>> > Modified: cfe/trunk/lib/Headers/avx2intrin.h
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/avx2intrin.h?rev=309488&r1=309487&r2=309488&view=diff
>> >
>> > ==
>> > --- cfe/trunk/lib/Headers/avx2intrin.h (original)
>> > +++ cfe/trunk/lib/Headers/avx2intrin.h Sat Jul 29 08:33:34 2017
>> > @@ -832,7 +832,8 @@ _mm256_xor_si256(__m256i __a, __m256i __
>> >  static __inline__ __m256i __DEFAULT_FN_ATTRS
>> >  _mm256_stream_load_si256(__m256i const *__V)
>> >  {
>> > -  return (__m256i)__builtin_nontemporal_load((const __v4di *)__V);
>> > +  typedef __v4di __v4di_aligned __attribute__((aligned(32)));
>> > +  return (__m256i)__builtin_nontemporal_load((const __v4di_aligned
>> > *)__V);
>> >  }
>> >
>> >  static __inline__ __m128 __DEFAULT_FN_ATTRS
>> >
>> > Modified: cfe/trunk/lib/Headers/avx512fintrin.h
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/avx512fintrin.h?rev=309488&r1=309487&r2=309488&view=diff
>> >
>> > ==
>> > --- cfe/trunk/lib/Headers/avx512fintrin.h (original)
>> > +++ cfe/trunk/lib/Headers/avx512fintrin.h Sat Jul 29 08:33:34 2017
>> > @@ -9035,25 +9035,29 @@ _mm512_kxor (__mmask16 __A, __mmask16 __
>> >  static __inline__ void __DEFAULT_FN_ATTRS
>> >  _mm512_stream_si512 (__m512i * __P, __m512i __A)
>> >  {
>> > -  __builtin_nontemporal_store((__v8di)__A, (__v8di*)__P);
>> > +  typedef __v8di __v8di_aligned __attribute__((aligned(64)));
>> > +  __builtin_nontemporal_store((__v8di_aligned)__A,
>> > (__v8di_aligned*)__P);
>> >  }
>> >
>> >  static __inline__ __m512i __DEFAULT_FN_ATTRS
>> >  _mm512_stream_load_si512 (void *__P)
>> >  {
>> > -  return (__m512i) __builtin_nontemporal_load((const __v8di *)__P);
>> > +  typedef __v8di __v8di_aligned __attribute__((aligned(64)));
>> > +  return (__m512i) __builtin_nontemporal_load((const __v8di_aligned
>> > *)__P);
>> >  }
>> >
>> >  static __inline__ void __DEFAULT_FN_ATTRS
>> >  _mm512_stream_pd (double *__P, __m512d __A)
>> >  {
>> > -  __builtin_nontemporal_store((__v8df)__A, (__v8df*)__P);
>> > +  typedef __v8df __v8df_aligned __attribute__((aligned(64)));
>> > +  __builtin_nontemporal_store((__v8df_aligned)__A,
>> > (__v8df_aligned*)__P);
>> >  }
>> >
>> >  static __inline__ void __DEFAULT_FN_ATTRS
>> >  _mm512_stream_ps (float *__P, __m512 __A)
>> >  {
>> > -  __builtin_nontemporal_store((__v16sf)__A, (__v16sf*)__P);
>> > +  typedef __v16sf __v16sf_aligned __attribute__((aligned(64)));
>> > +  __builtin_nontemporal_store((__v16sf_aligned)__A,
>> > (__v16sf_aligned*)__P);
>> >  }
>> >
>> >  static __inline__ __m512d __DEFAULT_FN_ATTRS
>> >
>> > Modified: cfe/trunk/lib/Headers/avxintrin.h
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/avxintrin.h?rev=309488&r1=309487&r2=309488&view=diff
>> >
>> > ==
>> > --- cfe/trunk/lib/Headers/avxintrin.h (original)
>> > +++ cfe/trunk/lib/Headers/avxintrin.h Sat Jul 29 08:33:34 2017
>> > @@ -3590,7 +3590,8 @@ _mm_maskstore_ps(float *__p, __m128i __m
>> >  static __inline void __DEFAULT_FN_ATTRS
>> >  _mm256_stream_si256(__m256i *__a, __m256i __b)
>> >  {
>> > -  __builtin_nontemporal_store((__v4di)__b, (__v4di*)__a);
>> > +  typedef __v4di __v4di_aligned __attribute__((aligned(32)));
>> > +  __builtin_nontemporal_store((__v4di_aligned)__b,
>> > (__v4di_aligned*)__a);
>> >  }
>> >
>> >  /// \brief Moves double-precision values from a 256-bit vector o

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

[don hinton via Phabricator via cfe-commits]

hintonda added a comment.

Cool, I'll try to play with this later today.

BTW, since the call to DiagnosticsEngine::Report is delayed when using 
PartialDiagnostic, would it make sense to add them as well?  Also, this doesn't 
seem to solve the initial problem of finding the Diag name in the first place.

Eventually, I'd like a scan-build like tool that let you rerun a particular 
compilation command (without needing to construct the -cc1 command yourself), 
that adds breakpoints for all warning/error diagnostics seen before invoking 
lldb -- perhaps even leveraging the compilation database, a la clang-tidy.


Repository:
  rL LLVM

https://reviews.llvm.org/D36083



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

[Craig Topper via cfe-commits]

We can merge all three patches to 5.0.

~Craig

On Mon, Jul 31, 2017 at 9:59 AM, Hans Wennborg  wrote:

> Craig, Simon asked for this to be merged to 5.0 together with r309382
> and r309383 for PR33830. What do you think?
>
> On Sat, Jul 29, 2017 at 8:33 AM, Simon Pilgrim via cfe-commits
>  wrote:
> > Author: rksimon
> > Date: Sat Jul 29 08:33:34 2017
> > New Revision: 309488
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=309488&view=rev
> > Log:
> > [X86][AVX] Ensure vector non-temporal load/store intrinsics force
> pointer alignment (PR33830)
> >
> > Clang specifies a max type alignment of 16 bytes on darwin targets
> (annoyingly in the driver not via cc1), meaning that the builtin
> nontemporal stores don't correctly align the loads/stores to 32 or 64 bytes
> when required, resulting in lowering to temporal unaligned loads/stores.
> >
> > This patch casts the vectors to explicitly aligned types prior to the
> load/store to ensure that the require alignment is respected.
> >
> > Differential Revision: https://reviews.llvm.org/D35996
> >
> > Modified:
> > cfe/trunk/lib/Headers/avx2intrin.h
> > cfe/trunk/lib/Headers/avx512fintrin.h
> > cfe/trunk/lib/Headers/avxintrin.h
> > cfe/trunk/test/CodeGen/x86-nontemporal.c
> >
> > Modified: cfe/trunk/lib/Headers/avx2intrin.h
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/
> avx2intrin.h?rev=309488&r1=309487&r2=309488&view=diff
> > 
> ==
> > --- cfe/trunk/lib/Headers/avx2intrin.h (original)
> > +++ cfe/trunk/lib/Headers/avx2intrin.h Sat Jul 29 08:33:34 2017
> > @@ -832,7 +832,8 @@ _mm256_xor_si256(__m256i __a, __m256i __
> >  static __inline__ __m256i __DEFAULT_FN_ATTRS
> >  _mm256_stream_load_si256(__m256i const *__V)
> >  {
> > -  return (__m256i)__builtin_nontemporal_load((const __v4di *)__V);
> > +  typedef __v4di __v4di_aligned __attribute__((aligned(32)));
> > +  return (__m256i)__builtin_nontemporal_load((const __v4di_aligned
> *)__V);
> >  }
> >
> >  static __inline__ __m128 __DEFAULT_FN_ATTRS
> >
> > Modified: cfe/trunk/lib/Headers/avx512fintrin.h
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/
> avx512fintrin.h?rev=309488&r1=309487&r2=309488&view=diff
> > 
> ==
> > --- cfe/trunk/lib/Headers/avx512fintrin.h (original)
> > +++ cfe/trunk/lib/Headers/avx512fintrin.h Sat Jul 29 08:33:34 2017
> > @@ -9035,25 +9035,29 @@ _mm512_kxor (__mmask16 __A, __mmask16 __
> >  static __inline__ void __DEFAULT_FN_ATTRS
> >  _mm512_stream_si512 (__m512i * __P, __m512i __A)
> >  {
> > -  __builtin_nontemporal_store((__v8di)__A, (__v8di*)__P);
> > +  typedef __v8di __v8di_aligned __attribute__((aligned(64)));
> > +  __builtin_nontemporal_store((__v8di_aligned)__A,
> (__v8di_aligned*)__P);
> >  }
> >
> >  static __inline__ __m512i __DEFAULT_FN_ATTRS
> >  _mm512_stream_load_si512 (void *__P)
> >  {
> > -  return (__m512i) __builtin_nontemporal_load((const __v8di *)__P);
> > +  typedef __v8di __v8di_aligned __attribute__((aligned(64)));
> > +  return (__m512i) __builtin_nontemporal_load((const __v8di_aligned
> *)__P);
> >  }
> >
> >  static __inline__ void __DEFAULT_FN_ATTRS
> >  _mm512_stream_pd (double *__P, __m512d __A)
> >  {
> > -  __builtin_nontemporal_store((__v8df)__A, (__v8df*)__P);
> > +  typedef __v8df __v8df_aligned __attribute__((aligned(64)));
> > +  __builtin_nontemporal_store((__v8df_aligned)__A,
> (__v8df_aligned*)__P);
> >  }
> >
> >  static __inline__ void __DEFAULT_FN_ATTRS
> >  _mm512_stream_ps (float *__P, __m512 __A)
> >  {
> > -  __builtin_nontemporal_store((__v16sf)__A, (__v16sf*)__P);
> > +  typedef __v16sf __v16sf_aligned __attribute__((aligned(64)));
> > +  __builtin_nontemporal_store((__v16sf_aligned)__A,
> (__v16sf_aligned*)__P);
> >  }
> >
> >  static __inline__ __m512d __DEFAULT_FN_ATTRS
> >
> > Modified: cfe/trunk/lib/Headers/avxintrin.h
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/
> avxintrin.h?rev=309488&r1=309487&r2=309488&view=diff
> > 
> ==
> > --- cfe/trunk/lib/Headers/avxintrin.h (original)
> > +++ cfe/trunk/lib/Headers/avxintrin.h Sat Jul 29 08:33:34 2017
> > @@ -3590,7 +3590,8 @@ _mm_maskstore_ps(float *__p, __m128i __m
> >  static __inline void __DEFAULT_FN_ATTRS
> >  _mm256_stream_si256(__m256i *__a, __m256i __b)
> >  {
> > -  __builtin_nontemporal_store((__v4di)__b, (__v4di*)__a);
> > +  typedef __v4di __v4di_aligned __attribute__((aligned(32)));
> > +  __builtin_nontemporal_store((__v4di_aligned)__b,
> (__v4di_aligned*)__a);
> >  }
> >
> >  /// \brief Moves double-precision values from a 256-bit vector of [4 x
> double]
> > @@ -3609,7 +3610,8 @@ _mm256_stream_si256(__m256i *__a, __m256
> >  static __inline void __DEFAULT_FN_ATTRS
> >  _mm256_stream_pd(double *__a, __m256d __b)
> >  {
> > -  __builtin_nontemporal_store((__v4df)__b

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

In https://reviews.llvm.org/D36095#826275, @bkramer wrote:

> lg (it could use a test case though)


Will add a test case in one of further commits.


Repository:
  rL LLVM

https://reviews.llvm.org/D36095



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309484 - Fix incorrect assertion condition.

[Vedant Kumar via cfe-commits]

Thank you!

vedant

> On Jul 29, 2017, at 1:18 AM, Victor Leschuk via cfe-commits 
>  wrote:
> 
> Author: vleschuk
> Date: Sat Jul 29 01:18:38 2017
> New Revision: 309484
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=309484&view=rev
> Log:
> Fix incorrect assertion condition.
> 
> Modified:
>cfe/trunk/lib/CodeGen/CGBuiltin.cpp
> 
> Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
> URL: 
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=309484&r1=309483&r2=309484&view=diff
> ==
> --- cfe/trunk/lib/CodeGen/CGBuiltin.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp Sat Jul 29 01:18:38 2017
> @@ -643,8 +643,8 @@ struct CallObjCArcUse final : EHScopeSta
> 
> Value *CodeGenFunction::EmitCheckedArgForBuiltin(const Expr *E,
>  BuiltinCheckKind Kind) {
> -  assert(Kind == BCK_CLZPassedZero ||
> - Kind == BCK_CTZPassedZero && "Unsupported builtin check kind");
> +  assert((Kind == BCK_CLZPassedZero || Kind == BCK_CTZPassedZero)
> +  && "Unsupported builtin check kind");
> 
>   Value *ArgValue = EmitScalarExpr(E);
>   if (!SanOpts.has(SanitizerKind::Builtin) || 
> !getTarget().isCLZForZeroUndef())
> 
> 
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

[Vedant Kumar via cfe-commits]

The bot should start working again with -fsanitize=vptr,null.

The warning can be improved. If we find -fno-sanitize=null in the argument 
list, we might say:
implicitly disabling vptr sanitizer because "-fno-sanitize=null" was specified

Otherwise we might say:
implicitly disabling vptr sanitizer because null checking wasn't enabled, try 
specifying -fsanitize=null or -fsanitize=undefined

I'll send out a patch for review.

vedant

> On Jul 31, 2017, at 9:37 AM, Hans Wennborg  wrote:
> 
> /sub
> 
> I believe Vedant asked for this to be merged to 5.0, so I'd like to
> merge the resolution too.
> 
> On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits
>  wrote:
>> Hi Vedant,
>> 
>> after this change our ubsanvptr bot fails like so:
>> 
>> clang-6.0: error: implicitly disabling vptr sanitizer because null checking
>> wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer]
>> 
>> The bot uses -fsanitize=vptr. I have no idea what this warning is supposed
>> to tell me. Maybe it could be reworded, or maybe it shouldn't be emitted?
>> 
>> Thanks,
>> Nico
>> 
>> On Tue, Jul 25, 2017 at 3:34 PM, Vedant Kumar via cfe-commits
>>  wrote:
>>> 
>>> Author: vedantk
>>> Date: Tue Jul 25 12:34:23 2017
>>> New Revision: 309007
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=309007&view=rev
>>> Log:
>>> [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)
>>> 
>>> The instrumentation generated by -fsanitize=vptr does not null check a
>>> user pointer before loading from it. This causes crashes in the face of
>>> UB member calls (this=nullptr), i.e it's causing user programs to crash
>>> only after UBSan is turned on.
>>> 
>>> The fix is to make run-time null checking a prerequisite for enabling
>>> -fsanitize=vptr, and to then teach UBSan to reuse these run-time null
>>> checks to make -fsanitize=vptr safe.
>>> 
>>> Testing: check-clang, check-ubsan, a stage2 ubsan-enabled build
>>> 
>>> Differential Revision: https://reviews.llvm.org/D35735
>>> 
>>> https://bugs.llvm.org/show_bug.cgi?id=33881
>>> 
>>> Modified:
>>>cfe/trunk/docs/ReleaseNotes.rst
>>>cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
>>>cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
>>>cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>>>cfe/trunk/lib/CodeGen/CGExpr.cpp
>>>cfe/trunk/lib/Driver/SanitizerArgs.cpp
>>>cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp
>>>cfe/trunk/test/CodeGenCXX/ubsan-devirtualized-calls.cpp
>>>cfe/trunk/test/CodeGenCXX/ubsan-type-checks.cpp
>>>cfe/trunk/test/CodeGenCXX/ubsan-vtable-checks.cpp
>>>cfe/trunk/test/Driver/fsanitize.c
>>>cfe/trunk/test/Driver/rtti-options.cpp
>>> 
>>> Modified: cfe/trunk/docs/ReleaseNotes.rst
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNotes.rst?rev=309007&r1=309006&r2=309007&view=diff
>>> 
>>> ==
>>> --- cfe/trunk/docs/ReleaseNotes.rst (original)
>>> +++ cfe/trunk/docs/ReleaseNotes.rst Tue Jul 25 12:34:23 2017
>>> @@ -155,7 +155,9 @@ Static Analyzer
>>> Undefined Behavior Sanitizer (UBSan)
>>> 
>>> 
>>> -...
>>> +The C++ dynamic type check now requires run-time null checking (i.e,
>>> +`-fsanitize=vptr` cannot be used without `-fsanitize=null`). This change
>>> does
>>> +not impact users who rely on UBSan check groups (e.g
>>> `-fsanitize=undefined`).
>>> 
>>> Core Analysis Improvements
>>> ==
>>> 
>>> Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UndefinedBehaviorSanitizer.rst?rev=309007&r1=309006&r2=309007&view=diff
>>> 
>>> ==
>>> --- cfe/trunk/docs/UndefinedBehaviorSanitizer.rst (original)
>>> +++ cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Tue Jul 25 12:34:23 2017
>>> @@ -130,11 +130,11 @@ Available checks are:
>>>  it is often unintentional, so UBSan offers to catch it.
>>>   -  ``-fsanitize=vla-bound``: A variable-length array whose bound
>>>  does not evaluate to a positive value.
>>> -  -  ``-fsanitize=vptr``: Use of an object whose vptr indicates that
>>> - it is of the wrong dynamic type, or that its lifetime has not
>>> - begun or has ended. Incompatible with ``-fno-rtti``. Link must
>>> - be performed by ``clang++``, not ``clang``, to make sure
>>> C++-specific
>>> - parts of the runtime library and C++ standard libraries are present.
>>> +  -  ``-fsanitize=vptr``: Use of an object whose vptr indicates that it
>>> is of
>>> + the wrong dynamic type, or that its lifetime has not begun or has
>>> ended.
>>> + Incompatible with ``-fno-rtti`` and ``-fno-sanitize=null``. Link
>>> must be
>>> + performed by ``clang++``, not ``clang``, to make sure C++-specific
>>> parts of
>>> + the runtime library and C++ standard libraries are present.
>>> 
>>> You can also use the following 

[PATCH] D34158: For standards compatibility, preinclude if the file is available

[Fedor Sergeev via Phabricator via cfe-commits]

fedor.sergeev added inline comments.



Comment at: test/Driver/stdc-predef.c:15
+  /* In this test, the file stdc-predef.h is missing from the installation */
+#if _STDC_PREDEF_H
+  #error "stdc-predef.h should not be included"

I would rather see a real check on include file inclusion (say, checking -H 
output) than a check for a macro.
Exact macro guard name is not a public interface at all. You might be lucky 
with current stdc-predef.h on Linux, but on other platforms it could be named 
differently.


Repository:
  rL LLVM

https://reviews.llvm.org/D34158



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r309585 - [clangd] Allow to get vfs::FileSystem used inside codeComplete.

[Ilya Biryukov via cfe-commits]

Author: ibiryukov
Date: Mon Jul 31 10:09:29 2017
New Revision: 309585

URL: http://llvm.org/viewvc/llvm-project?rev=309585&view=rev
Log:
[clangd] Allow to get vfs::FileSystem used inside codeComplete.

Summary: This is useful for managing lifetime of VFS-based caches.

Reviewers: bkramer, krasimir

Reviewed By: bkramer

Subscribers: klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D36095

Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/ClangdServer.h

Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/ClangdServer.cpp?rev=309585&r1=309584&r2=309585&view=diff
==
--- clang-tools-extra/trunk/clangd/ClangdServer.cpp (original)
+++ clang-tools-extra/trunk/clangd/ClangdServer.cpp Mon Jul 31 10:09:29 2017
@@ -192,7 +192,8 @@ void ClangdServer::forceReparse(PathRef
 
 Tagged>
 ClangdServer::codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents) {
+   llvm::Optional OverridenContents,
+   IntrusiveRefCntPtr *UsedFS) {
   std::string DraftStorage;
   if (!OverridenContents) {
 auto FileContents = DraftMgr.getDraft(File);
@@ -203,8 +204,11 @@ ClangdServer::codeComplete(PathRef File,
 OverridenContents = DraftStorage;
   }
 
-  std::vector Result;
   auto TaggedFS = FSProvider.getTaggedFileSystem(File);
+  if (UsedFS)
+*UsedFS = TaggedFS.Value;
+
+  std::vector Result;
   Units.runOnUnitWithoutReparse(File, *OverridenContents, ResourceDir, CDB,
 PCHs, TaggedFS.Value, [&](ClangdUnit &Unit) {
   Result = Unit.codeComplete(

Modified: clang-tools-extra/trunk/clangd/ClangdServer.h
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/ClangdServer.h?rev=309585&r1=309584&r2=309585&view=diff
==
--- clang-tools-extra/trunk/clangd/ClangdServer.h (original)
+++ clang-tools-extra/trunk/clangd/ClangdServer.h Mon Jul 31 10:09:29 2017
@@ -175,10 +175,14 @@ public:
   /// will be scheduled and a draft for \p File will not be updated.
   /// If \p OverridenContents is None, contents of the current draft for \p 
File
   /// will be used.
-  /// This method should only be called for currently tracked files.
+  /// If \p UsedFS is non-null, it will be overwritten by vfs::FileSystem used
+  /// for completion.
+  /// This method should only be called for currently tracked
+  /// files.
   Tagged>
   codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents = llvm::None);
+   llvm::Optional OverridenContents = llvm::None,
+   IntrusiveRefCntPtr *UsedFS = nullptr);
   /// Get definition of symbol at a specified \p Line and \p Column in \p File.
   Tagged> findDefinitions(PathRef File, Position Pos);
 


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

[Phabricator via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL309585: [clangd] Allow to get vfs::FileSystem used inside 
codeComplete. (authored by ibiryukov).

Repository:
  rL LLVM

https://reviews.llvm.org/D36095

Files:
  clang-tools-extra/trunk/clangd/ClangdServer.cpp
  clang-tools-extra/trunk/clangd/ClangdServer.h


Index: clang-tools-extra/trunk/clangd/ClangdServer.h
===
--- clang-tools-extra/trunk/clangd/ClangdServer.h
+++ clang-tools-extra/trunk/clangd/ClangdServer.h
@@ -175,10 +175,14 @@
   /// will be scheduled and a draft for \p File will not be updated.
   /// If \p OverridenContents is None, contents of the current draft for \p 
File
   /// will be used.
-  /// This method should only be called for currently tracked files.
+  /// If \p UsedFS is non-null, it will be overwritten by vfs::FileSystem used
+  /// for completion.
+  /// This method should only be called for currently tracked
+  /// files.
   Tagged>
   codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents = llvm::None);
+   llvm::Optional OverridenContents = llvm::None,
+   IntrusiveRefCntPtr *UsedFS = nullptr);
   /// Get definition of symbol at a specified \p Line and \p Column in \p File.
   Tagged> findDefinitions(PathRef File, Position Pos);
 
Index: clang-tools-extra/trunk/clangd/ClangdServer.cpp
===
--- clang-tools-extra/trunk/clangd/ClangdServer.cpp
+++ clang-tools-extra/trunk/clangd/ClangdServer.cpp
@@ -192,7 +192,8 @@
 
 Tagged>
 ClangdServer::codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents) {
+   llvm::Optional OverridenContents,
+   IntrusiveRefCntPtr *UsedFS) {
   std::string DraftStorage;
   if (!OverridenContents) {
 auto FileContents = DraftMgr.getDraft(File);
@@ -203,8 +204,11 @@
 OverridenContents = DraftStorage;
   }
 
-  std::vector Result;
   auto TaggedFS = FSProvider.getTaggedFileSystem(File);
+  if (UsedFS)
+*UsedFS = TaggedFS.Value;
+
+  std::vector Result;
   Units.runOnUnitWithoutReparse(File, *OverridenContents, ResourceDir, CDB,
 PCHs, TaggedFS.Value, [&](ClangdUnit &Unit) {
   Result = Unit.codeComplete(


Index: clang-tools-extra/trunk/clangd/ClangdServer.h
===
--- clang-tools-extra/trunk/clangd/ClangdServer.h
+++ clang-tools-extra/trunk/clangd/ClangdServer.h
@@ -175,10 +175,14 @@
   /// will be scheduled and a draft for \p File will not be updated.
   /// If \p OverridenContents is None, contents of the current draft for \p File
   /// will be used.
-  /// This method should only be called for currently tracked files.
+  /// If \p UsedFS is non-null, it will be overwritten by vfs::FileSystem used
+  /// for completion.
+  /// This method should only be called for currently tracked
+  /// files.
   Tagged>
   codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents = llvm::None);
+   llvm::Optional OverridenContents = llvm::None,
+   IntrusiveRefCntPtr *UsedFS = nullptr);
   /// Get definition of symbol at a specified \p Line and \p Column in \p File.
   Tagged> findDefinitions(PathRef File, Position Pos);
 
Index: clang-tools-extra/trunk/clangd/ClangdServer.cpp
===
--- clang-tools-extra/trunk/clangd/ClangdServer.cpp
+++ clang-tools-extra/trunk/clangd/ClangdServer.cpp
@@ -192,7 +192,8 @@
 
 Tagged>
 ClangdServer::codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents) {
+   llvm::Optional OverridenContents,
+   IntrusiveRefCntPtr *UsedFS) {
   std::string DraftStorage;
   if (!OverridenContents) {
 auto FileContents = DraftMgr.getDraft(File);
@@ -203,8 +204,11 @@
 OverridenContents = DraftStorage;
   }
 
-  std::vector Result;
   auto TaggedFS = FSProvider.getTaggedFileSystem(File);
+  if (UsedFS)
+*UsedFS = TaggedFS.Value;
+
+  std::vector Result;
   Units.runOnUnitWithoutReparse(File, *OverridenContents, ResourceDir, CDB,
 PCHs, TaggedFS.Value, [&](ClangdUnit &Unit) {
   Result = Unit.codeComplete(
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

[Fedor Sergeev via Phabricator via cfe-commits]

fedor.sergeev added a comment.

ping?


https://reviews.llvm.org/D35755



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309503 - PR33902: Invalidate line number cache when adding more text to existing buffer.

[Hans Wennborg via cfe-commits]

r309580. Thanks!

On Sat, Jul 29, 2017 at 11:33 PM, Richard Smith  wrote:
> We should take this fix for Clang 5.
>
> On 29 July 2017 at 23:31, Richard Smith via cfe-commits
>  wrote:
>>
>> Author: rsmith
>> Date: Sat Jul 29 23:31:29 2017
>> New Revision: 309503
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=309503&view=rev
>> Log:
>> PR33902: Invalidate line number cache when adding more text to existing
>> buffer.
>>
>> This led to crashes as the line number cache would report a bogus line
>> number
>> for a line of code, and we'd try to find a nonexistent column within the
>> line
>> when printing diagnostics.
>>
>> Modified:
>> cfe/trunk/lib/Lex/ScratchBuffer.cpp
>> cfe/trunk/test/Misc/caret-diags-multiline.cpp
>>
>> Modified: cfe/trunk/lib/Lex/ScratchBuffer.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/ScratchBuffer.cpp?rev=309503&r1=309502&r2=309503&view=diff
>>
>> ==
>> --- cfe/trunk/lib/Lex/ScratchBuffer.cpp (original)
>> +++ cfe/trunk/lib/Lex/ScratchBuffer.cpp Sat Jul 29 23:31:29 2017
>> @@ -35,6 +35,14 @@ SourceLocation ScratchBuffer::getToken(c
>> const char *&DestPtr) {
>>if (BytesUsed+Len+2 > ScratchBufSize)
>>  AllocScratchBuffer(Len+2);
>> +  else {
>> +// Clear out the source line cache if it's already been computed.
>> +// FIXME: Allow this to be incrementally extended.
>> +auto *ContentCache = const_cast(
>> +SourceMgr.getSLocEntry(SourceMgr.getFileID(BufferStartLoc))
>> + .getFile().getContentCache());
>> +ContentCache->SourceLineCache = nullptr;
>> +  }
>>
>>// Prefix the token with a \n, so that it looks like it is the first
>> thing on
>>// its own virtual line in caret diagnostics.
>>
>> Modified: cfe/trunk/test/Misc/caret-diags-multiline.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/caret-diags-multiline.cpp?rev=309503&r1=309502&r2=309503&view=diff
>>
>> ==
>> --- cfe/trunk/test/Misc/caret-diags-multiline.cpp (original)
>> +++ cfe/trunk/test/Misc/caret-diags-multiline.cpp Sat Jul 29 23:31:29 2017
>> @@ -232,3 +232,8 @@ void multiple_ranges(int a, int b) {
>>b
>>);
>>  }
>> +
>> +#define pr33902_a(b) #b
>> +#define pr33902_c(d) _Pragma(pr33902_a(d))
>> +#define pr33902_e(f) pr33902_c(GCC warning #f)
>> +pr33902_e() pr33902_e()
>>
>>
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

[Benjamin Kramer via Phabricator via cfe-commits]

bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.

lg (it could use a test case though)


https://reviews.llvm.org/D36095



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

[Tim Northover via Phabricator via cfe-commits]

t.p.northover added a comment.

Ping.


https://reviews.llvm.org/D35817



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

[Hans Wennborg via cfe-commits]

Craig, Simon asked for this to be merged to 5.0 together with r309382
and r309383 for PR33830. What do you think?

On Sat, Jul 29, 2017 at 8:33 AM, Simon Pilgrim via cfe-commits
 wrote:
> Author: rksimon
> Date: Sat Jul 29 08:33:34 2017
> New Revision: 309488
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309488&view=rev
> Log:
> [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer 
> alignment (PR33830)
>
> Clang specifies a max type alignment of 16 bytes on darwin targets 
> (annoyingly in the driver not via cc1), meaning that the builtin nontemporal 
> stores don't correctly align the loads/stores to 32 or 64 bytes when 
> required, resulting in lowering to temporal unaligned loads/stores.
>
> This patch casts the vectors to explicitly aligned types prior to the 
> load/store to ensure that the require alignment is respected.
>
> Differential Revision: https://reviews.llvm.org/D35996
>
> Modified:
> cfe/trunk/lib/Headers/avx2intrin.h
> cfe/trunk/lib/Headers/avx512fintrin.h
> cfe/trunk/lib/Headers/avxintrin.h
> cfe/trunk/test/CodeGen/x86-nontemporal.c
>
> Modified: cfe/trunk/lib/Headers/avx2intrin.h
> URL: 
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/avx2intrin.h?rev=309488&r1=309487&r2=309488&view=diff
> ==
> --- cfe/trunk/lib/Headers/avx2intrin.h (original)
> +++ cfe/trunk/lib/Headers/avx2intrin.h Sat Jul 29 08:33:34 2017
> @@ -832,7 +832,8 @@ _mm256_xor_si256(__m256i __a, __m256i __
>  static __inline__ __m256i __DEFAULT_FN_ATTRS
>  _mm256_stream_load_si256(__m256i const *__V)
>  {
> -  return (__m256i)__builtin_nontemporal_load((const __v4di *)__V);
> +  typedef __v4di __v4di_aligned __attribute__((aligned(32)));
> +  return (__m256i)__builtin_nontemporal_load((const __v4di_aligned *)__V);
>  }
>
>  static __inline__ __m128 __DEFAULT_FN_ATTRS
>
> Modified: cfe/trunk/lib/Headers/avx512fintrin.h
> URL: 
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/avx512fintrin.h?rev=309488&r1=309487&r2=309488&view=diff
> ==
> --- cfe/trunk/lib/Headers/avx512fintrin.h (original)
> +++ cfe/trunk/lib/Headers/avx512fintrin.h Sat Jul 29 08:33:34 2017
> @@ -9035,25 +9035,29 @@ _mm512_kxor (__mmask16 __A, __mmask16 __
>  static __inline__ void __DEFAULT_FN_ATTRS
>  _mm512_stream_si512 (__m512i * __P, __m512i __A)
>  {
> -  __builtin_nontemporal_store((__v8di)__A, (__v8di*)__P);
> +  typedef __v8di __v8di_aligned __attribute__((aligned(64)));
> +  __builtin_nontemporal_store((__v8di_aligned)__A, (__v8di_aligned*)__P);
>  }
>
>  static __inline__ __m512i __DEFAULT_FN_ATTRS
>  _mm512_stream_load_si512 (void *__P)
>  {
> -  return (__m512i) __builtin_nontemporal_load((const __v8di *)__P);
> +  typedef __v8di __v8di_aligned __attribute__((aligned(64)));
> +  return (__m512i) __builtin_nontemporal_load((const __v8di_aligned *)__P);
>  }
>
>  static __inline__ void __DEFAULT_FN_ATTRS
>  _mm512_stream_pd (double *__P, __m512d __A)
>  {
> -  __builtin_nontemporal_store((__v8df)__A, (__v8df*)__P);
> +  typedef __v8df __v8df_aligned __attribute__((aligned(64)));
> +  __builtin_nontemporal_store((__v8df_aligned)__A, (__v8df_aligned*)__P);
>  }
>
>  static __inline__ void __DEFAULT_FN_ATTRS
>  _mm512_stream_ps (float *__P, __m512 __A)
>  {
> -  __builtin_nontemporal_store((__v16sf)__A, (__v16sf*)__P);
> +  typedef __v16sf __v16sf_aligned __attribute__((aligned(64)));
> +  __builtin_nontemporal_store((__v16sf_aligned)__A, (__v16sf_aligned*)__P);
>  }
>
>  static __inline__ __m512d __DEFAULT_FN_ATTRS
>
> Modified: cfe/trunk/lib/Headers/avxintrin.h
> URL: 
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/avxintrin.h?rev=309488&r1=309487&r2=309488&view=diff
> ==
> --- cfe/trunk/lib/Headers/avxintrin.h (original)
> +++ cfe/trunk/lib/Headers/avxintrin.h Sat Jul 29 08:33:34 2017
> @@ -3590,7 +3590,8 @@ _mm_maskstore_ps(float *__p, __m128i __m
>  static __inline void __DEFAULT_FN_ATTRS
>  _mm256_stream_si256(__m256i *__a, __m256i __b)
>  {
> -  __builtin_nontemporal_store((__v4di)__b, (__v4di*)__a);
> +  typedef __v4di __v4di_aligned __attribute__((aligned(32)));
> +  __builtin_nontemporal_store((__v4di_aligned)__b, (__v4di_aligned*)__a);
>  }
>
>  /// \brief Moves double-precision values from a 256-bit vector of [4 x 
> double]
> @@ -3609,7 +3610,8 @@ _mm256_stream_si256(__m256i *__a, __m256
>  static __inline void __DEFAULT_FN_ATTRS
>  _mm256_stream_pd(double *__a, __m256d __b)
>  {
> -  __builtin_nontemporal_store((__v4df)__b, (__v4df*)__a);
> +  typedef __v4df __v4df_aligned __attribute__((aligned(32)));
> +  __builtin_nontemporal_store((__v4df_aligned)__b, (__v4df_aligned*)__a);
>  }
>
>  /// \brief Moves single-precision floating point values from a 256-bit vector
> @@ -3629,7 +3631,8 @@ _mm256_stream_pd(double *__a, __m256d __
>  stati

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov created this revision.

This is useful for managing lifetime of VFS-based caches.


https://reviews.llvm.org/D36095

Files:
  clangd/ClangdServer.cpp
  clangd/ClangdServer.h


Index: clangd/ClangdServer.h
===
--- clangd/ClangdServer.h
+++ clangd/ClangdServer.h
@@ -175,10 +175,14 @@
   /// will be scheduled and a draft for \p File will not be updated.
   /// If \p OverridenContents is None, contents of the current draft for \p 
File
   /// will be used.
-  /// This method should only be called for currently tracked files.
+  /// If \p UsedFS is non-null, it will be overwritten by vfs::FileSystem used
+  /// for completion.
+  /// This method should only be called for currently tracked
+  /// files.
   Tagged>
   codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents = llvm::None);
+   llvm::Optional OverridenContents = llvm::None,
+   IntrusiveRefCntPtr *UsedFS = nullptr);
   /// Get definition of symbol at a specified \p Line and \p Column in \p File.
   Tagged> findDefinitions(PathRef File, Position Pos);
 
Index: clangd/ClangdServer.cpp
===
--- clangd/ClangdServer.cpp
+++ clangd/ClangdServer.cpp
@@ -192,7 +192,8 @@
 
 Tagged>
 ClangdServer::codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents) {
+   llvm::Optional OverridenContents,
+   IntrusiveRefCntPtr *UsedFS) {
   std::string DraftStorage;
   if (!OverridenContents) {
 auto FileContents = DraftMgr.getDraft(File);
@@ -203,8 +204,11 @@
 OverridenContents = DraftStorage;
   }
 
-  std::vector Result;
   auto TaggedFS = FSProvider.getTaggedFileSystem(File);
+  if (UsedFS)
+*UsedFS = TaggedFS.Value;
+
+  std::vector Result;
   Units.runOnUnitWithoutReparse(File, *OverridenContents, ResourceDir, CDB,
 PCHs, TaggedFS.Value, [&](ClangdUnit &Unit) {
   Result = Unit.codeComplete(


Index: clangd/ClangdServer.h
===
--- clangd/ClangdServer.h
+++ clangd/ClangdServer.h
@@ -175,10 +175,14 @@
   /// will be scheduled and a draft for \p File will not be updated.
   /// If \p OverridenContents is None, contents of the current draft for \p File
   /// will be used.
-  /// This method should only be called for currently tracked files.
+  /// If \p UsedFS is non-null, it will be overwritten by vfs::FileSystem used
+  /// for completion.
+  /// This method should only be called for currently tracked
+  /// files.
   Tagged>
   codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents = llvm::None);
+   llvm::Optional OverridenContents = llvm::None,
+   IntrusiveRefCntPtr *UsedFS = nullptr);
   /// Get definition of symbol at a specified \p Line and \p Column in \p File.
   Tagged> findDefinitions(PathRef File, Position Pos);
 
Index: clangd/ClangdServer.cpp
===
--- clangd/ClangdServer.cpp
+++ clangd/ClangdServer.cpp
@@ -192,7 +192,8 @@
 
 Tagged>
 ClangdServer::codeComplete(PathRef File, Position Pos,
-   llvm::Optional OverridenContents) {
+   llvm::Optional OverridenContents,
+   IntrusiveRefCntPtr *UsedFS) {
   std::string DraftStorage;
   if (!OverridenContents) {
 auto FileContents = DraftMgr.getDraft(File);
@@ -203,8 +204,11 @@
 OverridenContents = DraftStorage;
   }
 
-  std::vector Result;
   auto TaggedFS = FSProvider.getTaggedFileSystem(File);
+  if (UsedFS)
+*UsedFS = TaggedFS.Value;
+
+  std::vector Result;
   Units.runOnUnitWithoutReparse(File, *OverridenContents, ResourceDir, CDB,
 PCHs, TaggedFS.Value, [&](ClangdUnit &Unit) {
   Result = Unit.codeComplete(
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309575 - [OPENMP] Change the name of outer non-debug function in debug mode, NFC.

[Alexey Bataev via cfe-commits]

Author: abataev
Date: Mon Jul 31 09:43:06 2017
New Revision: 309575

URL: http://llvm.org/viewvc/llvm-project?rev=309575&view=rev
Log:
[OPENMP] Change the name of outer non-debug function in debug mode, NFC.

Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp

Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp?rev=309575&r1=309574&r2=309575&view=diff
==
--- cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Mon Jul 31 09:43:06 2017
@@ -448,9 +448,11 @@ CodeGenFunction::GenerateOpenMPCapturedS
   if (!NeedWrapperFunction || !HasUIntPtrArgs)
 return F;
 
+  SmallString<256> Buffer;
+  llvm::raw_svector_ostream Out(Buffer);
+  Out << "__nondebug_wrapper_" << CapturedStmtInfo->getHelperName();
   FunctionOptions WrapperFO(&S, /*UIntPtrCastRequired=*/true,
-/*RegisterCastedArgsOnly=*/true,
-".nondebug_wrapper.");
+/*RegisterCastedArgsOnly=*/true, Out.str());
   CodeGenFunction WrapperCGF(CGM, /*suppressNewContext=*/true);
   WrapperCGF.disableDebugInfo();
   Args.clear();


___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

[David Li via Phabricator via cfe-commits]

davidxl added a comment.

The patch is missing documentation  change.


https://reviews.llvm.org/D34796



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

[Hans Wennborg via cfe-commits]

/sub

I believe Vedant asked for this to be merged to 5.0, so I'd like to
merge the resolution too.

On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits
 wrote:
> Hi Vedant,
>
> after this change our ubsanvptr bot fails like so:
>
> clang-6.0: error: implicitly disabling vptr sanitizer because null checking
> wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer]
>
> The bot uses -fsanitize=vptr. I have no idea what this warning is supposed
> to tell me. Maybe it could be reworded, or maybe it shouldn't be emitted?
>
> Thanks,
> Nico
>
> On Tue, Jul 25, 2017 at 3:34 PM, Vedant Kumar via cfe-commits
>  wrote:
>>
>> Author: vedantk
>> Date: Tue Jul 25 12:34:23 2017
>> New Revision: 309007
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=309007&view=rev
>> Log:
>> [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)
>>
>> The instrumentation generated by -fsanitize=vptr does not null check a
>> user pointer before loading from it. This causes crashes in the face of
>> UB member calls (this=nullptr), i.e it's causing user programs to crash
>> only after UBSan is turned on.
>>
>> The fix is to make run-time null checking a prerequisite for enabling
>> -fsanitize=vptr, and to then teach UBSan to reuse these run-time null
>> checks to make -fsanitize=vptr safe.
>>
>> Testing: check-clang, check-ubsan, a stage2 ubsan-enabled build
>>
>> Differential Revision: https://reviews.llvm.org/D35735
>>
>> https://bugs.llvm.org/show_bug.cgi?id=33881
>>
>> Modified:
>> cfe/trunk/docs/ReleaseNotes.rst
>> cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
>> cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
>> cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>> cfe/trunk/lib/CodeGen/CGExpr.cpp
>> cfe/trunk/lib/Driver/SanitizerArgs.cpp
>> cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp
>> cfe/trunk/test/CodeGenCXX/ubsan-devirtualized-calls.cpp
>> cfe/trunk/test/CodeGenCXX/ubsan-type-checks.cpp
>> cfe/trunk/test/CodeGenCXX/ubsan-vtable-checks.cpp
>> cfe/trunk/test/Driver/fsanitize.c
>> cfe/trunk/test/Driver/rtti-options.cpp
>>
>> Modified: cfe/trunk/docs/ReleaseNotes.rst
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNotes.rst?rev=309007&r1=309006&r2=309007&view=diff
>>
>> ==
>> --- cfe/trunk/docs/ReleaseNotes.rst (original)
>> +++ cfe/trunk/docs/ReleaseNotes.rst Tue Jul 25 12:34:23 2017
>> @@ -155,7 +155,9 @@ Static Analyzer
>>  Undefined Behavior Sanitizer (UBSan)
>>  
>>
>> -...
>> +The C++ dynamic type check now requires run-time null checking (i.e,
>> +`-fsanitize=vptr` cannot be used without `-fsanitize=null`). This change
>> does
>> +not impact users who rely on UBSan check groups (e.g
>> `-fsanitize=undefined`).
>>
>>  Core Analysis Improvements
>>  ==
>>
>> Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UndefinedBehaviorSanitizer.rst?rev=309007&r1=309006&r2=309007&view=diff
>>
>> ==
>> --- cfe/trunk/docs/UndefinedBehaviorSanitizer.rst (original)
>> +++ cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Tue Jul 25 12:34:23 2017
>> @@ -130,11 +130,11 @@ Available checks are:
>>   it is often unintentional, so UBSan offers to catch it.
>>-  ``-fsanitize=vla-bound``: A variable-length array whose bound
>>   does not evaluate to a positive value.
>> -  -  ``-fsanitize=vptr``: Use of an object whose vptr indicates that
>> - it is of the wrong dynamic type, or that its lifetime has not
>> - begun or has ended. Incompatible with ``-fno-rtti``. Link must
>> - be performed by ``clang++``, not ``clang``, to make sure
>> C++-specific
>> - parts of the runtime library and C++ standard libraries are present.
>> +  -  ``-fsanitize=vptr``: Use of an object whose vptr indicates that it
>> is of
>> + the wrong dynamic type, or that its lifetime has not begun or has
>> ended.
>> + Incompatible with ``-fno-rtti`` and ``-fno-sanitize=null``. Link
>> must be
>> + performed by ``clang++``, not ``clang``, to make sure C++-specific
>> parts of
>> + the runtime library and C++ standard libraries are present.
>>
>>  You can also use the following check groups:
>>-  ``-fsanitize=undefined``: All of the checks listed above other than
>>
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td?rev=309007&r1=309006&r2=309007&view=diff
>>
>> ==
>> --- cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td Tue Jul 25
>> 12:34:23 2017
>> @@ -230,7 +230,10 @@ def warn_drv_enabling_rtti_with_

Re: r308996 - [coroutines] Add serialization/deserialization of coroutines

[Hans Wennborg via cfe-commits]

Richard, Gor asked for this to be merged to 5.0. What do you think?

On Tue, Jul 25, 2017 at 11:01 AM, Gor Nishanov via cfe-commits
 wrote:
> Author: gornishanov
> Date: Tue Jul 25 11:01:49 2017
> New Revision: 308996
>
> URL: http://llvm.org/viewvc/llvm-project?rev=308996&view=rev
> Log:
> [coroutines] Add serialization/deserialization of coroutines
>
> Reviewers: rsmith
>
> Reviewed By: rsmith
>
> Subscribers: EricWF, cfe-commits
>
> Differential Revision: https://reviews.llvm.org/D35383
>
> Added:
> cfe/trunk/test/PCH/coroutines.cpp
> Modified:
> cfe/trunk/include/clang/AST/StmtCXX.h
> cfe/trunk/include/clang/Serialization/ASTBitCodes.h
> cfe/trunk/lib/AST/StmtCXX.cpp
> cfe/trunk/lib/Serialization/ASTReaderStmt.cpp
> cfe/trunk/lib/Serialization/ASTWriterStmt.cpp
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

[Taewook Oh via Phabricator via cfe-commits]

twoh added a comment.

Ping. Thanks!


https://reviews.llvm.org/D34796



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits