[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

compnerd added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:122-131 if (TC.getArch() == llvm::Triple::x86) CmdArgs.push_back("i386pe"); - if (TC.getArch() == llvm::Triple::x86_64) + else if (TC.getArch() == llvm::Triple::x86_64) CmdArgs.push_back("i

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added inline comments. Comment at: lib/Driver/ToolChain.cpp:808 + continue; + } else if (XOpenMPTargetNoTriple) +// Passing device args: -Xopenmp-target -opt=val. Please include {} around this else-if code, even though it is not nec

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea updated this revision to Diff 109904. gtbercea added a comment. Don't exclude flags when host matches offload toolchain. https://reviews.llvm.org/D34784 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Options.td include/clang/Driver/ToolChain.h lib/Dr

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

rjmccall added inline comments. Comment at: include/clang/Basic/AttrDocs.td:138 +Additionally, for block pointers, the same restriction apply to copies of +blocks. For example: + ``` Additionally, when the parameter is a `block pointer

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea updated this revision to Diff 109903. gtbercea added a comment. New way to handle OpenMP target flags. https://reviews.llvm.org/D34784 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Options.td include/clang/Driver/ToolChain.h lib/Driver/Compilation.c

Re: [PATCH] D24933: Enable configuration files in clang

On 07/24/2017 10:18 AM, Serge Pavlov wrote: I am thinking about reducing the patch further to leave only the ability to include config file when clang is called as `target-clang-drivermode`. It is still useful for cross compilation tasks because: - It is a convenient way to switch between sup

[PATCH] D36362: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

This revision was automatically updated to reflect the committed changes. Closed by commit rL310191: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D36362?vs=109896&id=109902#toc Repository:

r310191 - [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

Author: ctopper Date: Sat Aug 5 16:35:54 2017 New Revision: 310191 URL: http://llvm.org/viewvc/llvm-project?rev=310191&view=rev Log: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part Summary: On older processors this instruction encoding is treated as a NOP.

[PATCH] D36362: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D35450: [analyzer] Support generating and reasoning over more symbolic constraint types

ddcc added a comment. @NoQ ping https://reviews.llvm.org/D35450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines

jtbandes added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:650 +for (unsigned i = 0; i < Newlines; ++i) + Text.append(UseCRLF ? " \\\r\n" : " \\\n"); +return; djasper wrote: > Note that when you have an empty line, this would turn i

[PATCH] D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines

jtbandes updated this revision to Diff 109898. jtbandes added a comment. @djasper ok, done https://reviews.llvm.org/D36019 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D36362: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

craig.topper updated this revision to Diff 109896. craig.topper added a comment. Add test case https://reviews.llvm.org/D36362 Files: include/clang/Basic/BuiltinsX86.def test/CodeGen/pause.c Index: test/CodeGen/pause.c === --

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. The machine name `arm64pe` passed to the linker is completely made up; gnu binutils doesn't (afaik) support this, so it only has to match what the corresponding (not yet merged) lld linker s

[PATCH] D36363: [test] Remove an unintentional -x cl flag in an aarch64-windows test

mstorsjo created this revision. Herald added subscribers: kristof.beyls, Anastasia, rengolin, aemerson. This test was only intended to test compiling C, not OpenCL. https://reviews.llvm.org/D36363 Files: test/Preprocessor/predefined-macros.c Index: test/Preprocessor/predefined-macros.c

[PATCH] D36362: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

RKSimon added a comment. Codegen test case on no-sse2 target? https://reviews.llvm.org/D36362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh added a comment. I think it is generally good to match what GCC does to not to confuse people. https://reviews.llvm.org/D34796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36362: [X86] Enable isel to use the PAUSE instruction even when SSE2 is disabled. Clang part

craig.topper created this revision. On older processors this instruction encoding is treated as a NOP. MSVC doesn't disable intrinsics based on features the way clang/gcc does. Because the PAUSE instruction encoding doesn't crash older processors, some software out there uses these intrinsics w

[PATCH] D36353: Instantiate constexpr function when it is used

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. The current behaviour is correct according to the latest discussions of CWG. We shouldn't be delaying instantiation; we just need to fix the recent regression for functions where we

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

davidxl added a comment. The patch itself is fine. The meta question is whether we expect this option to be generally useful? https://reviews.llvm.org/D34796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D35782: [C++2a][Preprocessor] Implement p0306 __VA_OPT__ (Comma omission and comma deletion)

faisalv updated this revision to Diff 109883. faisalv marked 7 inline comments as done. faisalv added a comment. Hi Richard, This patch attempts to incorporate all the changes you requested. You asked for some consideration on the rationale for sticking with my approach (as opposed to the a

[PATCH] D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

krasimir created this revision. Herald added a subscriber: klimek. This handles a case where the trailing '*/' of a multiline jsdoc eding in a comment pragma wouldn't be put on a new line. https://reviews.llvm.org/D36359 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h li

[PATCH] D35847: clang-format: Fix left pointer alignment after delctype/typeof

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Please reformat the newly added code blocks with `clang-format` before submitting. Comment at: lib/Format/TokenAnnotator.cpp:1402 + FormatToken *TokenBe

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete created this revision. This adds a new error for missing parentheses around lambdas in delete operators. int main() { delete []() { return new int(); }(); } This will result in: test.cpp:2:10: error: missing parentheses around lambda expression delete []() { return new

Re: r305903 - Function with unparsed body is a definition

This problem is addressed by https://reviews.llvm.org/D36353. Thanks, --Serge 2017-08-05 8:44 GMT+07:00 Alexander Kornienko : > Thank you for the analysis! It would be nice if you could implement a > short term workaround to avoid crashes. Maybe Richard has ideas on what a > proper solution shou

[PATCH] D36353: Instantiate constexpr function when it is used

sepavloff created this revision. Previous behavior was to instantiate constexpr function always, even if it is used in the body of a template. For instance, in the following code: template constexpr T foo(T x) { return x; } template T bar(T x) { return foo(0); } the function template special