[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:308 const Record = *Opts[I]; if (!isa(R.getValueInit("ValuesCode"))) { OS << "{\n"; You can flip the condition to do early continue. Comment at:

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi updated this revision to Diff 111611. yamaguchi marked 3 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/autocomplete.c llvm/utils/TableGen/OptParserEmitter.cpp

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added inline comments. Comment at: include/clang/Sema/Sema.h:5466 + /// ActOnLambdaTemplateParameterList - This is called after parsing + /// the explicit template parameter list (if it exists) in C++2a. Avoid listing the name of the function:

[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

STL_MSFT created this revision. This is a minimally intrusive change, which I've verified works for both x86 and x64. The idea is to add another bool data member, `IsDevDivInternal`. (This could be unified with `IsVS2017OrNewer`, since it's a 3-way setting. Either a build is DevDiv-internal,

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann updated this revision to Diff 111606. euhlmann marked an inline comment as done. euhlmann edited the summary of this revision. euhlmann added a comment. Eliminated redundancy in tests by fixing test::messUp which was incorrectly merging lines. Fixing the issue Mark brought up regarding

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added a comment. Well, we don't currently have a concept of a non-canonical qualifier, but I think it probably wouldn't be difficult to support; you would just need ASTContext::getQualifiedType to be aware of it. https://reviews.llvm.org/D35082

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete updated this revision to Diff 111602. Rakete added a comment. Thanks! Agreed, your wording is better than mine :) https://reviews.llvm.org/D36855 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

vsk added inline comments. Comment at: lib/Lex/PPDirectives.cpp:570 + // We'll warn about reaching the end of file later. + if (C == '\0' || C == '\r' || C == '\n') +break; efriedma wrote: > This doesn't really handle backslash-escaped newlines

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

vsk updated this revision to Diff 111596. vsk marked an inline comment as done. vsk added a comment. - Address Eli's comment. https://reviews.llvm.org/D36642 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPDirectives.cpp test/CoverageMapping/preprocessor.c test/Index/skipped-ranges.c

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL311141: AMDGPU: add missing amdgcn processors and tests (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D36771?vs=111270=111595#toc Repository: rL LLVM

r311141 - AMDGPU: add missing amdgcn processors and tests

Author: kzhuravl Date: Thu Aug 17 18:13:39 2017 New Revision: 311141 URL: http://llvm.org/viewvc/llvm-project?rev=311141=rev Log: AMDGPU: add missing amdgcn processors and tests - gfx600 - gfx601 - gfx703 - gfx902 - gfx903 Differential Revision: https://reviews.llvm.org/D36771

Re: r310983 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Thanks for a quick response, "#include " indeed helped. On Thu, Aug 17, 2017 at 5:41 PM Richard Smith wrote: > On 17 August 2017 at 17:28, Petr Hosek via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> We're seeing a build failure in WebKit which appears to be

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith added a comment. Oh, and you'll need an accompanying test case before this can be committed (look at the existing tests in test/SemaCXX for ideas). https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith added a comment. Thanks! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4091 "%select{rvalue|lvalue}1">; +def ext_pointer_to_const_ref_member_on_rvalue : ExtWarn< + "pointer-to-member to const& function on an rvalue is a C++2a extension">, I

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl added a comment. In https://reviews.llvm.org/D35082#844620, @rjmccall wrote: > The meaning we've agreed on for LangAS::Default is to be the address space of > local declarations, which corresponds quite well to __private in OpenCL. I > think your concern about diagnostics is better

Re: r310983 - PR19668, PR23034: Fix handling of move constructors and deleted copy

On 17 August 2017 at 17:28, Petr Hosek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > We're seeing a build failure in WebKit which appears to be have been > introduced by this change: > > ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF >

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete created this revision. This patch allows pointer to const& member functions on rvalues for C++20, and as an extension for prior versions. This is P0704r1 . https://reviews.llvm.org/D36855 Files:

Re: r311137 - GlobalISel (AArch64): fix ABI at border between GPRs and SP.

On 17 August 2017 at 16:14, Tim Northover via cfe-commits wrote: > Author: tnorthover > Date: Thu Aug 17 16:14:01 2017 > New Revision: 311137 > > URL: http://llvm.org/viewvc/llvm-project?rev=311137=rev > Log: > GlobalISel (AArch64): fix ABI at border between GPRs and

r311140 - Revert r311137 (GlobalISel ABI commit).

Author: tnorthover Date: Thu Aug 17 17:33:24 2017 New Revision: 311140 URL: http://llvm.org/viewvc/llvm-project?rev=311140=rev Log: Revert r311137 (GlobalISel ABI commit). It was committed by mistake since it was in the same monorepo as the LLVM change I was working on. Modified:

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Confirmed, this changes is harmless. The failure we're seeing seems to have been introduced by Clang in r310983, sorry about the confusion. On Thu, Aug 17, 2017 at 4:35 PM Shoaib Meenai wrote: > See Petr's follow-up. It doesn't look like this was the responsible change. > > > >

Re: r310983 - PR19668, PR23034: Fix handling of move constructors and deleted copy

We're seeing a build failure in WebKit which appears to be have been introduced by this change: ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF obj/apps/web_view/web_view_test.test_webview.o.d -DTOOLCHAIN_VERSION=4e89c701396412a50a901115ab4a2a09145f3777

[PATCH] D36853: [Parser] Correct initalizer typos before lambda capture type is deduced.

vsapsai created this revision. This is the same assertion as in https://reviews.llvm.org/D25206 that is triggered when RecordLayoutBuilder tries to compute the size of a field (for capture "typo_boo" in the test case) whose type hasn't been deduced. The fix is to add CorrectDelayedTyposInExpr

[PATCH] D36851: [analyzer] Fix modeling of ctors

alexshap added a comment. >One alternative we discussed was performing this logic in RegionStore instead and skipping the default binding there >if we saw that the base region was empty. What do you think of that approach? (We would have to be careful for exactly the reasons described in

[PATCH] D36851: [analyzer] Fix modeling of ctors

dcoughlin added a comment. Thanks for the patch! @NoQ and I were discussing this approach this morning. One alternative we discussed was performing this logic in RegionStore instead and skipping the default binding there if we saw that the base region was empty. What do you think of that

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

See Petr's follow-up. It doesn't look like this was the responsible change. From: Eric Fiselier Date: Thursday, August 17, 2017 at 4:02 PM To: Petr Hosek Cc: cfe-commits , Marshall Clow , Hans Wennborg

[PATCH] D36851: [analyzer] Fix modeling of ctors

alexshap created this revision. Herald added a subscriber: xazax.hun. This diff attempts to fixe analyzer's crash (triggered assert) on the newly added test case. The assert being discussed is assert(!B.lookup(R, BindingKey::Direct)) in lib/StaticAnalyzer/Core/RegionStore.cpp, however the root

r311137 - GlobalISel (AArch64): fix ABI at border between GPRs and SP.

Author: tnorthover Date: Thu Aug 17 16:14:01 2017 New Revision: 311137 URL: http://llvm.org/viewvc/llvm-project?rev=311137=rev Log: GlobalISel (AArch64): fix ABI at border between GPRs and SP. If a struct would end up half in GPRs and half on SP the ABI says it should actually go entirely on the

[clang-tools-extra] r311136 - [clang-tidy] Add modernize-use-equals-default.IgnoreMacros option

Author: alexfh Date: Thu Aug 17 16:07:59 2017 New Revision: 311136 URL: http://llvm.org/viewvc/llvm-project?rev=311136=rev Log: [clang-tidy] Add modernize-use-equals-default.IgnoreMacros option Added: clang-tools-extra/trunk/test/clang-tidy/modernize-use-equals-default-macros.cpp Modified:

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

probably shouldn't merge this then. On Aug 17, 2017 4:54 PM, "Petr Hosek via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > This broke our build of WebKit with the following build failure: > > ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF >

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Yeah, I spent some time scratching my head about how my change would be causing that issue :) Let me know if it turns out to be related in any way and I'll look into it more. From: Petr Hosek Date: Thursday, August 17, 2017 at 4:04 PM To: Hans Wennborg ,

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Actually nevermind, it seems like it was a different change and this one is harmless (I'm still bisecting libc++ to find out which is causing the error below). On Thu, Aug 17, 2017 at 3:54 PM Petr Hosek wrote: > This broke our build of WebKit with the following build

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

This broke our build of WebKit with the following build failure: ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF obj/apps/web_view/web_view_test.test_webview.o.d -DTOOLCHAIN_VERSION=4e89c701396412a50a901115ab4a2a09145f3777 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DCAIRO_HAS_FC_FONT=0

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

morehouse updated this revision to Diff 111570. morehouse added a comment. - Extract shared condition. - Add ATTRIBUTE_INTERFACE. - Rename variable to __sancov_lowest_stack. - Add driver test for -fsanitize-coverage=stack-depth. https://reviews.llvm.org/D36839 Files:

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

dcoughlin added a comment. Other than my question above, this looks good to me. https://reviews.llvm.org/D35216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1104 +// expression classes separately. +if (!isa(Ex)) + for (auto Child : Ex->children()) { What is special about ObjCBoxedExpr here? Naively I would

[PATCH] D36750: [analyzer] RetainCount: When diagnosing overrelease, mention if it's coming from a nested block.

dcoughlin added a comment. I forgot to say this looks like a nice usability improvement! https://reviews.llvm.org/D36750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

ps4-buildslave2 will be disconnected from master

ps4-buildslave2 will be temporary disconnected from build master for debugging purposes. It will be done approximately at 6:00 PM PDT 18, Aug (Friday). -- Best Regards, Victor Leschuk | Software Engineer |Access Softek ___ cfe-commits mailing list

[PATCH] D36848: [CodeGen] Use RefCntTimer to time IR generation

modocache created this revision. Use the reference-counted timer abstraction from https://reviews.llvm.org/D36847 instead of manually keeping track of the number of times `startTimer()` and `stopTimer()` should be called. Test plan: Run `clang -ftime-report` and confirm the time measurements are

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

morehouse added inline comments. Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:31 ATTRIBUTE_INTERFACE uintptr_t __sancov_trace_pc_pcs[fuzzer::TracePC::kNumPCs]; vitalybuka wrote: > Why this does not need ATTRIBUTE_INTERFACE? Not sure why it works without it.

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

mgrang updated this revision to Diff 111557. mgrang retitled this revision from "[clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization" to "[clang] Remove unit test which uses reverse-iterate flag". mgrang edited the summary of this revision.

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:314 for (const std::string : R.getValueAsListOfStrings("Prefixes")) { -OS << "bool ValuesWereAdded = "; +OS << "ValuesWereAdded = "; OS << "Opt.addValues(";

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

ruiu added inline comments. Comment at: clang/include/clang/Driver/CC1Options.td:104 + ValuesCode<[{ +const char* Values = +#define GET_CHECKERS `const char* Values` -> `const char *Values` Comment at:

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

joerg added a comment. divtc3 and friends. https://reviews.llvm.org/D36764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:314 for (const std::string : R.getValueAsListOfStrings("Prefixes")) { -OS << "bool ValuesWereAdded = "; +OS << "ValuesWereAdded = "; OS << "Opt.addValues(";

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi updated this revision to Diff 111549. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/autocomplete.c llvm/utils/TableGen/OptParserEmitter.cpp

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

yamaguchi updated this revision to Diff 111548. yamaguchi added a comment. const char* Values -> const char *Values https://reviews.llvm.org/D36782 Files: clang/include/clang/Driver/CC1Options.td clang/lib/Driver/DriverOptions.cpp clang/test/Driver/autocomplete.c

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

yamaguchi updated this revision to Diff 111547. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36782 Files: clang/include/clang/Driver/CC1Options.td clang/lib/Driver/DriverOptions.cpp clang/test/Driver/autocomplete.c

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r311115 - PR34161: support evaluation of 'void()' expressions in C++14 onwards.

Author: rsmith Date: Thu Aug 17 12:35:50 2017 New Revision: 35 URL: http://llvm.org/viewvc/llvm-project?rev=35=rev Log: PR34161: support evaluation of 'void()' expressions in C++14 onwards. Modified: cfe/trunk/lib/AST/ExprConstant.cpp

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. ping https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added a comment. The meaning we've agreed on for LangAS::Default is to be the address space of local declarations, which corresponds quite well to __private in OpenCL. I think your concern about diagnostics is better addressed by changing the pretty-printer than by changing Sema to

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:559 // trace-pc w/o func/bb/edge implies edge. if ((CoverageFeatures & Extract if (!(CoverageFeatures & InsertionPointTypes)) { } Comment at:

Re: [clang-tools-extra] r309936 - ClangdTests: Try to unbreak the case CLANG_DEFAULT_CXX_STDLIB=libc++.

Merged to 5.0 in r311109. On Thu, Aug 3, 2017 at 6:30 AM, NAKAMURA Takumi via cfe-commits wrote: > Author: chapuni > Date: Thu Aug 3 06:30:43 2017 > New Revision: 309936 > > URL: http://llvm.org/viewvc/llvm-project?rev=309936=rev > Log: > ClangdTests: Try to unbreak

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

morehouse created this revision. Herald added subscribers: hiraditya, kubamracek. Augment SanitizerCoverage to insert maximum stack depth tracing for use by libFuzzer. The new instrumentation is enabled by the flag -fsanitize-coverage=stack-depth and is compatible with the existing

Re: r310776 - PR34163: Don't cache an incorrect key function for a class if queried between

Merged in r311105. On Mon, Aug 14, 2017 at 10:07 AM, Hans Wennborg wrote: > Sounds good to me. Let's give it another day and see how it goes. > > On Fri, Aug 11, 2017 at 6:48 PM, Richard Smith wrote: >> Hi Hans, >> >> I'd like to get this into Clang 5,

[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

erik.pilkington updated this revision to Diff 111528. erik.pilkington added a comment. Ah, good point. This new patch does that. Thanks, Erik https://reviews.llvm.org/D36777 Files: lib/Sema/SemaDeclAttr.cpp test/SemaObjC/unguarded-availability.m Index:

Re: r310672 - [Sema][ObjC] Fix spurious -Wcast-qual warnings.

Okay, merged in r311095. On Tue, Aug 15, 2017 at 11:50 AM, Akira Hatanaka wrote: > Hans, is it okay to merge this to 5.0? > >> On Aug 10, 2017, at 5:06 PM, Akira Hatanaka via cfe-commits >> wrote: >> >> Author: ahatanak >> Date: Thu Aug 10

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

nemanjai added a comment. In https://reviews.llvm.org/D36764#844486, @joerg wrote: > Because PPC uses the TC variant. Sorry, I don't understand this comment. What is the "TC variant"? https://reviews.llvm.org/D36764 ___ cfe-commits mailing list

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

joerg added a comment. Because PPC uses the TC variant. https://reviews.llvm.org/D36764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM with a test for warnings. See test/Driver/mips-abicalls.c for reference. Repository: rL LLVM https://reviews.llvm.org/D35982 ___

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

nemanjai added a comment. In https://reviews.llvm.org/D36764#843778, @saugustine wrote: > Anyone have any opinions on this? I don't see an issue with providing these functions on PowerPC as there doesn't seem to be anything in the implementation that PowerPC would have an issue with.

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: lib/Sema/SemaType.cpp:6969 + if (state.getSema().getLangOpts().OpenCL && + !hasOpenCLAddressSpace && type.getAddressSpace() == 0 && Anastasia wrote: > yaxunl wrote: > >

[PATCH] D34992: Emit static constexpr member as available_externally definition

mehdi_amini marked an inline comment as done. mehdi_amini added a comment. Bi-weekly ping! (@rsmith) https://reviews.llvm.org/D34992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu added inline comments. Comment at: clang/include/clang/Driver/Options.td:2254 + ValuesCode<[{ +const char* Values = +#define LANGSTANDARD(id, name, lang, desc, features) name "," ruiu wrote: > I think Raphael suggested indenting embedded code with at least

[PATCH] D36670: misc-misplaced-widening-cast: fix assertion

alexfh accepted this revision. alexfh added a comment. LG. Thank you for the fix! Comment at: test/clang-tidy/misc-misplaced-widening-cast-explicit-only.cpp:63 + enum Type {}; + static char *m_fn1() { char p = (Type)( - m_fn1()); } +}; xazax.hun wrote: >

[PATCH] D36822: [clang-tidy] Ignore statements inside a template instantiation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311086: [clang-tidy] Ignore statements inside a template instantiation. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D36822 Files:

[PATCH] D36822: [clang-tidy] Ignore statements inside a template instantiation.

hokein updated this revision to Diff 111510. hokein marked an inline comment as done. hokein added a comment. Remove the CHECK-MESSAGE-NOT. https://reviews.llvm.org/D36822 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/modernize-make-unique.cpp Index:

r311088 - Unguarded availability diagnoser should use TraverseStmt instead of

Author: arphaman Date: Thu Aug 17 07:22:27 2017 New Revision: 311088 URL: http://llvm.org/viewvc/llvm-project?rev=311088=rev Log: Unguarded availability diagnoser should use TraverseStmt instead of Base::TraverseStmt when visiting the then/else branches of if statements This ensures that the

[clang-tools-extra] r311086 - [clang-tidy] Ignore statements inside a template instantiation.

Author: hokein Date: Thu Aug 17 07:12:38 2017 New Revision: 311086 URL: http://llvm.org/viewvc/llvm-project?rev=311086=rev Log: [clang-tidy] Ignore statements inside a template instantiation. Reviewers: alexfh Reviewed By: alexfh Subscribers: JDevlieghere, xazax.hun, cfe-commits Differential

[PATCH] D36822: [clang-tidy] Ignore statements inside a template instantiation.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: test/clang-tidy/modernize-make-unique.cpp:459 + std::unique_ptr t2 = std::unique_ptr(new T); + // CHECK-MESSAGE-NOT: warning: + t2.reset(new

r311085 - Print enum constant values using the original source formatting

Author: arphaman Date: Thu Aug 17 06:41:55 2017 New Revision: 311085 URL: http://llvm.org/viewvc/llvm-project?rev=311085=rev Log: Print enum constant values using the original source formatting if possible when creating "Declaration" nodes in XML comments rdar://14765746 Added:

[PATCH] D36824: [mips] Rename getSupportedNanEncoding() to getIEEE754Standard() (NFC)

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM with comment addressed. Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:328 +mips::IEEE754Standard mips::getIEEE754Standard(StringRef ) { + // Strictly speaking,

[PATCH] D36828: Updated a usage of createTemporaryFile that does not expect file to be created.

ilya-biryukov added a comment. A change to llvm repository is here: https://reviews.llvm.org/D36827 https://reviews.llvm.org/D36828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36828: Updated a usage of createTemporaryFile that does not expect file to be created.

ilya-biryukov created this revision. This fixes a usage of createTemporaryFile in clang repo after a change in llvm repo. https://reviews.llvm.org/D36828 Files: unittests/Tooling/ToolingTest.cpp Index: unittests/Tooling/ToolingTest.cpp

[PATCH] D35200: Don't use mmap on Windows

joerg added a comment. The primary reason for using mmap is not so much performance, but reduced memory foot print. https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

abeserminji updated this revision to Diff 111492. abeserminji added a comment. On @atanasyan 's suggestion, part of the patch is separated here https://reviews.llvm.org/D36824. Comments resolved. Repository: rL LLVM https://reviews.llvm.org/D35982 Files:

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6342 +&& !isa(FD)) { + Args = Args.slice(1); +} nik wrote: > bkramer wrote: > > assert that FD is a static method. > Just stumbled here because I was looking into

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

nik added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6342 +&& !isa(FD)) { + Args = Args.slice(1); +} bkramer wrote: > assert that FD is a static method. Just stumbled here because I was looking into

[PATCH] D36824: Rename getSupportedNanEncoding() to getIEEE754Standard() (NFC)

abeserminji created this revision. As function getSupportedNanEncoding() relies on IEEE 754 Standard, new suggested name is getIEEE754Standard() which is more convenient to use in decision non related to NaN encoding. Repository: rL LLVM https://reviews.llvm.org/D36824 Files:

[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

arphaman added a comment. Thanks! There are two issues that I see: Comment at: lib/Sema/SemaDeclAttr.cpp:7519 +// to any useful diagnostics. +for (Stmt *Child : llvm::drop_begin(CS->children(), 1)) + if (!Base::TraverseStmt(Child)) GNU case

[PATCH] D36822: [clang-tidy] Ignore statements inside a template instantiation.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. https://reviews.llvm.org/D36822 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/modernize-make-unique.cpp

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:295 + std::string DEFAULT_SOURCE_EXTENSIONS[] = { ".cpp", ".c", ".cc", ".cxx", +".c++", ".C", ".m", ".mm" }; + std::string DEFAULT_HEADER_EXTENSIONS[] = { ".h", ".hh", ".hpp", ".hxx",

[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311078: [clang-tidy] Don't generate fixes for initializer_list constructor in… (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D36786 Files:

[clang-tools-extra] r311078 - [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

Author: hokein Date: Thu Aug 17 03:14:52 2017 New Revision: 311078 URL: http://llvm.org/viewvc/llvm-project?rev=311078=rev Log: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check. Summary: The current fix will break the compilation -- because braced list is

[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

hokein updated this revision to Diff 111485. hokein marked 2 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D36786 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h

[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

alexfh accepted this revision. alexfh added a comment. Still LG with one comment. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.h:60 - void replaceNew(DiagnosticBuilder , const CXXNewExpr *New, + /// Returns whether the fixes for replacing CXXNewExpr are generated. +

[PATCH] D35200: Don't use mmap on Windows

ilya-biryukov added a comment. In https://reviews.llvm.org/D35200#844132, @yvvan wrote: > The files might also be removed. > I checked that with qtcreator from git. Switching to the different branch > started reparse of some files. > When I frequently switched branches back and forth I got

[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

hokein marked an inline comment as done. hokein added inline comments. Comment at: test/clang-tidy/modernize-make-unique.cpp:253 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead - // CHECK-FIXES: std::unique_ptr PE2 = std::make_unique({1, 2});

[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

hokein updated this revision to Diff 111481. hokein added a comment. Add CHECK-FIXES, and fix an uncaught issue. https://reviews.llvm.org/D36786 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h test/clang-tidy/modernize-make-unique.cpp Index:

[PATCH] D35200: Don't use mmap on Windows

yvvan added a comment. The files might also be removed. I checked that with qtcreator from git. Switching to the different branch started reparse of some files. When I frequently switched branches back and forth I got lock issues. With mmap turned off this did not happen.

[PATCH] D35200: Don't use mmap on Windows

ilya-biryukov added a comment. This looks strange. AFAIK, memory mapping files in Windows does no 'locking' by itself. I've just written a small program to check that it's possible to modify the file, memory-mapped using Win32 API. What is specific problem you ran into?

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

nik created this revision. Looks like this one was forgotten for clang_parseTranslationUnit*, as LIBCLANG_NOTHREADS is checked for/in: clang_saveTranslationUnit() clang_reparseTranslationUnit() clang_codeCompleteAt() clang_indexTranslationUnit() clang_indexSourceFile()

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi created this revision. Add support for autocompleting values of -std= by including LangStandards.def. This patch relies on https://reviews.llvm.org/D36782, and is using two-stage code generation. https://reviews.llvm.org/D36820 Files: clang/include/clang/Driver/Options.td

r311070 - Fix undefined behavior that is caused by not always initializing a bool.

Author: djasper Date: Wed Aug 16 23:33:46 2017 New Revision: 311070 URL: http://llvm.org/viewvc/llvm-project?rev=311070=rev Log: Fix undefined behavior that is caused by not always initializing a bool. The fix in r310994 is incomplete, as moveFromAndCancel can set the pointer without