vlad.tsyrklevich updated this revision to Diff 115528.
vlad.tsyrklevich added a comment.
Address @eugenis' comments
https://reviews.llvm.org/D37925
Files:
include/clang/Basic/SanitizerBlacklist.h
include/clang/Basic/SanitizerSpecialCaseList.h
lib/AST/Decl.cpp
lib/Basic/CMakeLists.txt
vlad.tsyrklevich added inline comments.
Comment at: include/clang/Basic/SanitizerSpecialCaseList.h:33
+
+ bool inSection(SanitizerMask Mask, StringRef Prefix, StringRef Query,
+ StringRef Category = StringRef()) const;
eugenis wrote:
> Please
hfinkel added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:442
+SmallString<256> Name = llvm::sys::path::relative_path(II.getFilename());
+SmallString<256> FullPath = llvm::sys::path::root_path(II.getFilename());
hfinkel added a comment.
Please add a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D37913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aheejin
Date: Fri Sep 15 18:07:43 2017
New Revision: 313430
URL: http://llvm.org/viewvc/llvm-project?rev=313430=rev
Log:
[WebAssembly] Restore __builtin_wasm_rethrow builtin
Summary:
Restore the `__builtin_wasm_rethrow` builtin deleted in D37931. On second
thought, it appears it can be
compnerd added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:477
Context.getTypeSizeInChars(Context.getWideCharType()).getQuantity();
- assert((LangOpts.ShortWChar ||
- llvm::TargetLibraryInfoImpl::getTargetWCharSize(Target.getTriple())
==
Author: inglorion
Date: Fri Sep 15 17:16:13 2017
New Revision: 313425
URL: http://llvm.org/viewvc/llvm-project?rev=313425=rev
Log:
[docs] add Windows examples to ThinLTO.rst
Reviewers: pcc, ruiu
Reviewed By: ruiu
Subscribers: mehdi_amini, eraman, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313425: [docs] add Windows examples to ThinLTO.rst (authored
by inglorion).
Changed prior to commit:
https://reviews.llvm.org/D37943?vs=115522=115524#toc
Repository:
rL LLVM
MatzeB added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:477
Context.getTypeSizeInChars(Context.getWideCharType()).getQuantity();
- assert((LangOpts.ShortWChar ||
- llvm::TargetLibraryInfoImpl::getTargetWCharSize(Target.getTriple())
==
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
inglorion created this revision.
Herald added subscribers: eraman, mehdi_amini.
https://reviews.llvm.org/D37943
Files:
clang/docs/ThinLTO.rst
Index: clang/docs/ThinLTO.rst
===
--- clang/docs/ThinLTO.rst
+++
eugenis added inline comments.
Comment at: include/clang/Basic/SanitizerSpecialCaseList.h:33
+
+ bool inSection(SanitizerMask Mask, StringRef Prefix, StringRef Query,
+ StringRef Category = StringRef()) const;
Please add a comment on the
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
efriedma added inline comments.
Comment at: lib/Frontend/PrintPreprocessedOutput.cpp:566
+ MoveToLine(Loc);
+ OS << "#pragma " << "clang assume_nonnull end";
+ setEmittedDirectiveOnThisLine();
Extra "<<"?
Comment at:
erichkeane abandoned this revision.
erichkeane added a comment.
This has likely gone stale, and my employer has decided to tell customers to
modify their code.
https://reviews.llvm.org/D32051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313418: [X86] Use native shuffle vector for the perm2f128
intrinsics (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D37892?vs=115427=115518#toc
Repository:
rL LLVM
Author: ctopper
Date: Fri Sep 15 16:00:59 2017
New Revision: 313418
URL: http://llvm.org/viewvc/llvm-project?rev=313418=rev
Log:
[X86] Use native shuffle vector for the perm2f128 intrinsics
This patch replaces the perm2f128 intrinsics with native shuffle vectors.
This uses a pretty simple
craig.topper created this revision.
This arranges more of the Intel and AMD CPUs into fallthrough positions based
on their features. We may be able to merge this new AMD set with the BTVER or
BDVER sets but I didn't look that closely.
https://reviews.llvm.org/D37941
Files:
tra added a comment.
I'm not particularly familiar with OpenMP internals. Could you elaborate on why
libdevice would not be needed with -c for the OpenMP case?
Is that because it would only apply to the host compilation and that nothing
will be compiled for the openmp targets?
Does openmp allow
craig.topper created this revision.
For a lot of older CPUs we have a 1:1 mapping between CPU name and enum name.
But many of them are effectively aliases of each other and as a result are
always repeated together at every usage
This patch removes most of the duplication. It also uses
compnerd updated this revision to Diff 115510.
compnerd added a comment.
Try to clarify the logic for APCS ABI.
Repository:
rL LLVM
https://reviews.llvm.org/D37891
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Basic/LangOptions.def
erichkeane added a comment.
I don't know? I don't have a really good way of repro'ing that. Do you have
any ability to grab me a preprocessed reproducer of that one? Godbolt doesn't
have Windows headers for this.
https://reviews.llvm.org/D32049
rnk added a comment.
Would this help with https://bugs.llvm.org/show_bug.cgi?id=32021 ?
https://reviews.llvm.org/D32049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane abandoned this revision.
erichkeane added a comment.
This has likely gone stale, and my employer has decided to tell customers to
modify their code.
https://reviews.llvm.org/D32050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: zturner
Date: Fri Sep 15 15:10:46 2017
New Revision: 313407
URL: http://llvm.org/viewvc/llvm-project?rev=313407=rev
Log:
Resubmit "[lit] Force site configs to run before source-tree configs"
This is a resubmission of r313270. It broke standalone builds of
compiler-rt because we were not
Author: zturner
Date: Fri Sep 15 15:10:46 2017
New Revision: 313407
URL: http://llvm.org/viewvc/llvm-project?rev=313407=rev
Log:
Resubmit "[lit] Force site configs to run before source-tree configs"
This is a resubmission of r313270. It broke standalone builds of
compiler-rt because we were not
erichkeane abandoned this revision.
erichkeane added a comment.
This has likely gone stale, and my employer has decided to tell customers to
modify their code.
https://reviews.llvm.org/D32049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
erichkeane abandoned this revision.
erichkeane added a comment.
This has likely gone stale, and my employer has decided to tell customers to
modify their code.
https://reviews.llvm.org/D32052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: aheejin
Date: Fri Sep 15 15:01:22 2017
New Revision: 313402
URL: http://llvm.org/viewvc/llvm-project?rev=313402=rev
Log:
Remove __builtin_wasm_rethrow builtin
Summary:
Remove `__builtin_wasm_rethrow` builtin. I thought it was required to implement
`__cxa_rethrow` function in libcxxabi,
vlad.tsyrklevich updated this revision to Diff 115509.
vlad.tsyrklevich added a comment.
Run clang-format.
https://reviews.llvm.org/D37925
Files:
include/clang/Basic/SanitizerBlacklist.h
include/clang/Basic/SanitizerSpecialCaseList.h
lib/AST/Decl.cpp
lib/Basic/CMakeLists.txt
gtbercea updated this revision to Diff 115502.
gtbercea added a comment.
Fix diff.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
chh added a comment.
Thanks for this change.
Could you take a look of https://reviews.llvm.org/D35743 too?
This outputs a space before and after "&" or "&&", like this
"auto & [...", "auto && [..."
Could we remove one of the space to a format like the following?
"auto& [...", "auto&&
gtbercea updated this revision to Diff 115500.
gtbercea added a comment.
Add test.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
gtbercea updated this revision to Diff 115497.
gtbercea added a comment.
Fix tests.
https://reviews.llvm.org/D37912
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
compnerd added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:2659
+
+ const bool IsAPCSABI =
+ IsARM && (IsGNUEnvironment || IsNetBSD ||
rnk wrote:
> This target detection logic is insanely complicated, and I'm not convinced
> it's simpler
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:62
+std::pair Process() const {
+ assert(C != Criteria::None && "invalid criteria");
+
JonasToth wrote:
> You acces `Critera` always scoped. I
lebedev.ri updated this revision to Diff 115482.
lebedev.ri marked 13 inline comments as done.
lebedev.ri added a comment.
Address most of the @JonasToth's review notes.
Repository:
rL LLVM
https://reviews.llvm.org/D36836
Files:
clang-tidy/readability/CMakeLists.txt
tra added a comment.
Now we just need a test case to make sure this works as intended.
https://reviews.llvm.org/D37914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 115481.
gtbercea added a comment.
Fix condition.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
---
vlad.tsyrklevich added a comment.
Not included in this change:
- Updating the sanitizer documentation to use section headers. It's worth doing
for the CFI documentation to let people know they can break down blacklist
entries by CFI mode, but is it worth pushing users to specify '[address]',
Author: ctopper
Date: Fri Sep 15 13:27:59 2017
New Revision: 313392
URL: http://llvm.org/viewvc/llvm-project?rev=313392=rev
Log:
[X86] Disable _mm512_maskz_set1_epi64 intrinsic on 32-bit targets to prevent a
backend isel failure.
The __builtin_ia32_pbroadcastq512_mem_mask we were previously
vlad.tsyrklevich created this revision.
Herald added a subscriber: mgorny.
This is the follow-up patch to https://reviews.llvm.org/D37924.
This change refactors clang to use the the newly added section headers
in SpecialCaseList to specify which sanitizers blacklists entries
should apply to,
Author: vivekvpandya
Date: Fri Sep 15 13:09:55 2017
New Revision: 313389
URL: http://llvm.org/viewvc/llvm-project?rev=313389=rev
Log:
This patch fixes https://bugs.llvm.org/show_bug.cgi?id=32352 LLVM code change
is as per https://reviews.llvm.org/D33514
Modified:
Author: vsapsai
Date: Fri Sep 15 12:51:42 2017
New Revision: 313386
URL: http://llvm.org/viewvc/llvm-project?rev=313386=rev
Log:
[Sema] Error out early for tags defined inside an enumeration.
This fixes PR28903 by avoiding access check for inner enum constant. We
are performing access check
This revision was automatically updated to reflect the committed changes.
vsapsai marked an inline comment as done.
Closed by commit rL313386: [Sema] Error out early for tags defined inside an
enumeration. (authored by vsapsai).
Changed prior to commit:
Author: george.karpenkov
Date: Fri Sep 15 12:51:26 2017
New Revision: 313385
URL: http://llvm.org/viewvc/llvm-project?rev=313385=rev
Log:
[Analyzer] Check function name size before indexing.
https://reviews.llvm.org/D37908
Modified:
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
In https://reviews.llvm.org/D37822#872291, @Anastasia wrote:
> Could you please explain a bit more why the alignment have to be put
> explicitly in the struct? I am just not very convinced this is general enough.
The captured
Nebiroth updated this revision to Diff 115462.
Nebiroth marked an inline comment as done.
Nebiroth added a comment.
Fixed a few comments.
Rebased on latest clangd version.
https://reviews.llvm.org/D37150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
craig.topper added a comment.
I'm going to go ahead and remove __builtin_ia32_pbroadcastq512_mem_mask from
clang and change _mm512_maskz_set1_epi64 to be disabled in 32-bit mode. I want
to nominate this for 5.0.1 because using it in 32-bit mode causes the compile
to throw a cannot select
JonasToth added inline comments.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:27
+ // Here are all the possible reasons:
+ enum Criteria : unsigned char {
+None = 0,
JonasToth wrote:
> i think clarifying which language constructs
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Basic/Targets/AMDGPU.h:194
+Info.setAllowsRegister();
+Name = S.data() - 1;
+return true;
arsenm wrote:
> I'm not sure I understand these data() - 1s.
The caller
tra added a comment.
In https://reviews.llvm.org/D37912#872318, @gtbercea wrote:
> In https://reviews.llvm.org/D37912#872294, @tra wrote:
>
> > Shouldn't this temp .cubin file go into the temporary directory, as opposed
> > to the same directory as the input file?
>
>
> That is indeed the
gtbercea updated this revision to Diff 115447.
gtbercea added a comment.
Fix parantheses.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
---
gtbercea updated this revision to Diff 115444.
gtbercea added a comment.
Contract check.
https://reviews.llvm.org/D37914
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
---
Author: smeenai
Date: Fri Sep 15 11:49:34 2017
New Revision: 313377
URL: http://llvm.org/viewvc/llvm-project?rev=313377=rev
Log:
[libc++] Account for Microsoft CRT const overloads
Microsoft's CRT already provides the const overloads, and it defines the
`_CRT_CONST_CORRECT_OVERLOADS` macro to
gtbercea added a comment.
In https://reviews.llvm.org/D37912#872294, @tra wrote:
> Shouldn't this temp .cubin file go into the temporary directory, as opposed
> to the same directory as the input file?
That is indeed the intention. The filename already contains the "/tmp/" I just
make sure
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:505-508
+if ((DeviceOffloadingKind == Action::OFK_OpenMP &&
+ DriverArgs.hasArg(options::OPT_S)) ||
+(DeviceOffloadingKind == Action::OFK_OpenMP &&
+
gtbercea created this revision.
If we only use the compiler front-end, do not throw an error about the cuda
device library not being found. This allows the front-end to be run on systems
where no Cuda installation is found.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
Files:
tra added a comment.
Shouldn't this temp .cubin file go into the temporary directory, as opposed to
the same directory as the input file?
Repository:
rL LLVM
https://reviews.llvm.org/D37912
___
cfe-commits mailing list
Anastasia added a comment.
Could you please explain a bit more why the alignment have to be put explicitly
in the struct? I am just not very convinced this is general enough.
Comment at: lib/CodeGen/CGBlocks.cpp:314
assert(elementTypes.empty());
-
gtbercea created this revision.
Enable the -nocudalib flag for the OpenMP device offloading toolchain as well.
Currently it can only be used for the CUDA toolchain.
Repository:
rL LLVM
https://reviews.llvm.org/D37913
Files:
lib/Driver/ToolChains/Cuda.cpp
Index:
gtbercea created this revision.
When composing the output file name, the path to the file is being dropped. The
full path is required.
Repository:
rL LLVM
https://reviews.llvm.org/D37912
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:7251
+if (const auto *rhproto = dyn_cast(rhptee))
+ rhptee = S.removeNoEscapeFromFunctionProto(lhproto, rhproto);
+
rjmccall wrote:
> ahatanak wrote:
> > rjmccall wrote:
> > > I think the
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - please can you update the
avx-intrinsics-fast-isel.ll/avxs-intrinsics-fast-isel.ll cases to match the
*-builtins.c as well (either now or if/when you add the intrinsics to
arsenm added inline comments.
Comment at: lib/Basic/Targets/AMDGPU.h:124
+ /// {sn}, {s[n]}
+ /// {S} , wheere S is a special register name
+ {v[n:m]}
Typo wheere
Comment at: lib/Basic/Targets/AMDGPU.h:194
+Info.setAllowsRegister();
Author: tra
Date: Fri Sep 15 10:30:53 2017
New Revision: 313369
URL: http://llvm.org/viewvc/llvm-project?rev=313369=rev
Log:
[CUDA] Work around a new quirk in CUDA9 headers.
In CUDA-9 some of device-side math functions that we need are conditionally
defined within '#if _GLIBCXX_MATH_H'. We need
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313369: [CUDA] Work around a new quirk in CUDA9 headers.
(authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D37906?vs=115415=115422#toc
Repository:
rL LLVM
It's supposed to tell you whether the target arch supports it. So it's
definitely something the compiler knows better than the C library, which is
why I didn't just work around this myself
Clang may not be correct right now, but if that's true, (a) it's already
lying to us through the other
pirama added a comment.
In https://reviews.llvm.org/D37302#871794, @joerg wrote:
> So what about targets that don't support subnormals? I'm moderately sure ARM
> falls into this category given the right phase of the moon.
Clang defines `__FLT_HAS_DENORM__` and friends unconditionally, so I
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
> BTW, this change essentially augments the job that the "#undef GNUC" above
> used to do in older CUDA versions. CUDA9 replaced GNUC with _GLIBCXX_MATH_H
> in CUDA-9 in some places.
Ah,
tra added a comment.
I don't think we really care why they do it for nvcc.
My understanding is that nvcc needs to avoid name clashes between their
implementation of functions and the ones that come from the host headers and
that's why they have to tread really carefully around host includes.
chh added a comment.
ping.
https://reviews.llvm.org/D35743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:477
Context.getTypeSizeInChars(Context.getWideCharType()).getQuantity();
- assert((LangOpts.ShortWChar ||
- llvm::TargetLibraryInfoImpl::getTargetWCharSize(Target.getTriple())
==
jlebar added a comment.
This is a bit of a Chesterton's Fence -- do we know why they're doing this?
I guess it's probably going to be OK because our overriding semantics will make
it OK, and our test-suite tests (should) exercise all of math.h. But I'm still
a little worried about it.
tra created this revision.
Herald added a subscriber: sanjoy.
In CUDA-9 some of device-side math functions that we need are conditionally
defined within '#if _GLIBCXX_MATH_H'. We need to temporarily undo the guard
around inclusion of math_functions.hpp
https://reviews.llvm.org/D37906
Files:
compnerd added a comment.
We could leave the defaults there as they stand, and only have the new flags
alter the default. However, it seems that just paying the cost of adjusting
the tests once isn't too bad. To me, it seems that having one instance of the
horrible logic for determining the
rnk added a comment.
I do remember recommending this approach over IRC, but I thought we concluded
that we should leave all the defaults in lib/Basic/Targets/ and make the -cc1
-fwchar-type= and -f[no-]signed-wchar overrides that affected all targets
equally. That would avoid the need for
Author: erichkeane
Date: Fri Sep 15 09:03:35 2017
New Revision: 313364
URL: http://llvm.org/viewvc/llvm-project?rev=313364=rev
Log:
Fix the __interface inheritence rules to work better with IUnknown and IDispatch
__interface objects in MSVC are permitted to inherit from __interface types,
and
JonasToth added a comment.
I did read through it now. In general, the code is sound with my understanding
of the complexity metric and there is a almost one to one wording to the
document, which is nice.
Since we chatted in IRC directly, i would give a short summary to avoid
forgetting what we
frutiger added a comment.
**Please note**:
- this change means that versions of `libclang` built prior to the introduction
of `clang_getExpansionLocation` will not work.
- this change alters the behavior of `clang_getSpellingLocation` to return the
spelling location
I would appreciate advice
frutiger created this revision.
o) Enhance 'CursorLocation' with four additional properties that can
retrieve spelling location information.
o) Update the implementation to use 'clang_getExpansionLocation'
instead of the deprecated 'clang_getInstantiationLocation', which
has been present
curdeius created this revision.
Herald added a subscriber: klimek.
NamespaceEndCommentsFixer did not fix namespace comments when the brace opening
the namespace was not on the same line as the "namespace" keyword.
It occurs in Allman, GNU and Linux styles and whenever
werbitt created this revision.
When 'buffer-file-name' is nil 'call-process-region' returned a segmentation
fault error.
This was a problem when using clang-format-buffer on an orgmode source code
editing buffer.
I fixed this problem by excluding the '-assume-filename' argument when
JonasToth added a comment.
Looking up to the Visitor, i will do this next.
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:27
+ // Here are all the possible reasons:
+ enum Criteria : unsigned char {
+None = 0,
i think clarifying
barancsuk added a comment.
@alexfh, would you mind taking a look at the changes that have been introduced
in the new patch?
The main improvements are:
- The checker has been shifted to the module `readability`.
- It is checked, whether implicit type conversion is possible from the argument
to
aaron.ballman added reviewers: sbenza, JonasToth.
aaron.ballman added a comment.
Adding a few reviewers to hopefully help Roman get some feedback.
Repository:
rL LLVM
https://reviews.llvm.org/D36836
___
cfe-commits mailing list
xazax.hun added a comment.
Any further reviews?
What are the criteria to accept this patch? Who or how many people should
accept this?
https://reviews.llvm.org/D34512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
boris added a comment.
Ping.
https://reviews.llvm.org/D37299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313355: [clang-tidy] Fixed misc-unused-parameters omitting
parameters square brackets (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D37846?vs=115369=115395#toc
Repository:
Author: alexfh
Date: Fri Sep 15 04:28:28 2017
New Revision: 313355
URL: http://llvm.org/viewvc/llvm-project?rev=313355=rev
Log:
[clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets
Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=34449
**Problem:**
Clang-tidy check
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313354: [clang-format] New flag -
BraceWrapping.AfterExternBlock (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D37845?vs=115240=115394#toc
Repository:
rL LLVM
xazax.hun added a comment.
I have some comments and questions but maybe you do not want to address those
until Devin, NoQ, or Anna approved the general directions.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:107
+/** Recursively check if variable is changed in code. */
Author: krasimir
Date: Fri Sep 15 04:23:50 2017
New Revision: 313354
URL: http://llvm.org/viewvc/llvm-project?rev=313354=rev
Log:
[clang-format] New flag - BraceWrapping.AfterExternBlock
Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=34016 - **"extern C part"**
**Problem:**
Due to the
PriMee added a comment.
Thank you!
https://reviews.llvm.org/D37846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. I'll commit the patch for you.
https://reviews.llvm.org/D37846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
danielmarjamaki added a comment.
In https://reviews.llvm.org/D37897#871858, @xazax.hun wrote:
> Out of curiosity, does the false positive disappear after making the static
> variables const?
Yes that fixes the false positive
Repository:
rL LLVM
https://reviews.llvm.org/D37897
xazax.hun added a comment.
Out of curiosity, does the false positive disappear after making the static
variables const?
Repository:
rL LLVM
https://reviews.llvm.org/D37897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
danielmarjamaki updated this revision to Diff 115385.
danielmarjamaki added a comment.
Minor cleanups. Changed names. Updated comments.
Repository:
rL LLVM
https://reviews.llvm.org/D37897
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
RKSimon added a comment.
Also, there currently isn't any testing of the zero vector case.
https://reviews.llvm.org/D37892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki created this revision.
I saw a false positive where the analyzer made wrong conclusions about a static
variable.
Static variables that are not written have known values (initialized values).
This is the (simplified) code that motivated me to create this patch:
static char
1 - 100 of 110 matches
Mail list logo
