r314194 - [XRay] Avoid actual linking when testing the driver

Author: dberris Date: Mon Sep 25 21:29:25 2017 New Revision: 314194 URL: http://llvm.org/viewvc/llvm-project?rev=314194=rev Log: [XRay] Avoid actual linking when testing the driver Use -### in the command to see just look for the output of -v. Follow-up to D38226. Modified:

r314193 - [XRay] Run command once without piping to FileCheck

Author: dberris Date: Mon Sep 25 21:17:37 2017 New Revision: 314193 URL: http://llvm.org/viewvc/llvm-project?rev=314193=rev Log: [XRay] Run command once without piping to FileCheck This allows us to debug the failures that come up from the build bots. Follow-up to D38226. Modified:

r314191 - [XRay] Only run shared tests when 'enable_shared' is true

Author: dberris Date: Mon Sep 25 21:07:45 2017 New Revision: 314191 URL: http://llvm.org/viewvc/llvm-project?rev=314191=rev Log: [XRay] Only run shared tests when 'enable_shared' is true Follow-up to D38226. Modified: cfe/trunk/test/Driver/XRay/lit.local.cfg

r314190 - [XRay] Remove -fPIC from shared build test.

Author: dberris Date: Mon Sep 25 21:00:41 2017 New Revision: 314190 URL: http://llvm.org/viewvc/llvm-project?rev=314190=rev Log: [XRay] Remove -fPIC from shared build test. Follow-up to D38226. Modified: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp Modified:

r314189 - [XRay] Stop running tests for 'amd64', and remove -fPIE from tests.

Author: dberris Date: Mon Sep 25 20:45:37 2017 New Revision: 314189 URL: http://llvm.org/viewvc/llvm-project?rev=314189=rev Log: [XRay] Stop running tests for 'amd64', and remove -fPIE from tests. Follow-up to D38226. Modified: cfe/trunk/test/Driver/XRay/lit.local.cfg

r314188 - [XRay][Driver] Do not link in XRay runtime in shared libs

Author: dberris Date: Mon Sep 25 20:18:11 2017 New Revision: 314188 URL: http://llvm.org/viewvc/llvm-project?rev=314188=rev Log: [XRay][Driver] Do not link in XRay runtime in shared libs Summary: This change ensures that we don't link in the XRay runtime when building shared libraries with

r314187 - CodeGenModule: Adapt to LLVM TargetLibraryInfo changes

Author: matze Date: Mon Sep 25 19:37:23 2017 New Revision: 314187 URL: http://llvm.org/viewvc/llvm-project?rev=314187=rev Log: CodeGenModule: Adapt to LLVM TargetLibraryInfo changes Adapt to LLVM TargetLibraryInfo changes in r314185. See also https://reviews.llvm.org/D38106 and

r314178 - Revert "[XRay][Driver] Do not link in XRay runtime in shared libs"

Author: dberris Date: Mon Sep 25 17:41:08 2017 New Revision: 314178 URL: http://llvm.org/viewvc/llvm-project?rev=314178=rev Log: Revert "[XRay][Driver] Do not link in XRay runtime in shared libs" Reverts r314177. Removed: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp Modified:

Re: [PATCH] D38208: Add support for remembering origins to ExternalASTMerger

Updated the diff.  Unfortunately reviews.llvm.org is down, so I'll try updating that page in the morning. Sean On 9/25/17 5:04 AM, Bruno Cardoso Lopes via Phabricator wrote: bruno added inline comments. Comment at: lib/AST/ExternalASTMerger.cpp:79 + return

r314177 - [XRay][Driver] Do not link in XRay runtime in shared libs

Author: dberris Date: Mon Sep 25 16:40:33 2017 New Revision: 314177 URL: http://llvm.org/viewvc/llvm-project?rev=314177=rev Log: [XRay][Driver] Do not link in XRay runtime in shared libs Summary: This change ensures that we don't link in the XRay runtime when building shared libraries with

r314172 - clang-format/java: Always put space after `assert` keyword.

Author: nico Date: Mon Sep 25 15:42:49 2017 New Revision: 314172 URL: http://llvm.org/viewvc/llvm-project?rev=314172=rev Log: clang-format/java: Always put space after `assert` keyword. Previously, it was missing if the expression after the assert started with a (. Modified:

r314171 - Allow specifying sanitizers in blacklists

Author: vlad.tsyrklevich Date: Mon Sep 25 15:11:12 2017 New Revision: 314171 URL: http://llvm.org/viewvc/llvm-project?rev=314171=rev Log: Allow specifying sanitizers in blacklists Summary: This is the follow-up patch to D37924. This change refactors clang to use the the newly added section

[PATCH] D37914: [OpenMP] Don't throw cudalib not found error if only front-end is required.

gtbercea reopened this revision. gtbercea added a comment. This revision is now accepted and ready to land. Open. Repository: rL LLVM https://reviews.llvm.org/D37914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37913: [OpenMP] Enable the existing nocudalib flag for OpenMP offloading toolchain.

gtbercea updated this revision to Diff 116621. gtbercea added a comment. Split line. https://reviews.llvm.org/D37913 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

r314159 - [x86] make assertions less strict in avx512f test file

Author: spatel Date: Mon Sep 25 14:31:08 2017 New Revision: 314159 URL: http://llvm.org/viewvc/llvm-project?rev=314159=rev Log: [x86] make assertions less strict in avx512f test file Missed a line in r314158. Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified:

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

eugenis updated this revision to Diff 116618. eugenis added a comment. Switched to SetLLVMFunctionAttributes https://reviews.llvm.org/D37656 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/cfi-check-thumb.c llvm/lib/Transforms/IPO/CrossDSOCFI.cpp

r314158 - [x86] make assertions less strict in avx512f test file

Author: spatel Date: Mon Sep 25 14:27:37 2017 New Revision: 314158 URL: http://llvm.org/viewvc/llvm-project?rev=314158=rev Log: [x86] make assertions less strict in avx512f test file I'm not sure why yet, but there may be differences depending on the host? Modified:

[PATCH] D38259: [OpenMP] Fix translation of target args

Hahnfeld created this revision. ToolChain::TranslateArgs() returns nullptr if no changes are performed. This would currently mean that OpenMPArgs are lost. Patch fixes this by falling back to simply using OpenMPArgs in that case. https://reviews.llvm.org/D38259 Files:

[PATCH] D38258: [OpenMP] Fix passing of -m arguments to device toolchain

Hahnfeld created this revision. AuxTriple is not set if host and device share a toolchain. Also, removing an argument modifies the DAL which needs to be returned for future use. (Move tests back to offload-openmp.c as they are not related to GPUs.) https://reviews.llvm.org/D38258 Files:

[PATCH] D38257: [OpenMP] Fix memory leak when translating arguments

Hahnfeld created this revision. Parsing the argument after -Xopenmp-target allocates memory that needs to be freed. Associate it with the final DerivedArgList after we know which one will be used. https://reviews.llvm.org/D38257 Files: include/clang/Driver/ToolChain.h

[PATCH] D37903: Fix assume-filename handling in clang-format.el

werbitt updated this revision to Diff 116605. werbitt added a comment. Cleanup Docs - The first line of of an emacs docstring should be a complete sentence. -Specify that "-assume-filname" is a clang-format option https://reviews.llvm.org/D37903 Files: tools/clang-format/clang-format.el

[PATCH] D37903: Fix assume-filename handling in clang-format.el

werbitt reclaimed this revision. werbitt added a comment. This revision is now accepted and ready to land. It looks like I just uploaded a diff against a bad branch, and I can't figure out how to undo it. Sorry about that. https://reviews.llvm.org/D37903

[PATCH] D38209: [Sema] Correct nothrow inherited by noexcept

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In https://reviews.llvm.org/D38209#880553, @STL_MSFT wrote: > > do you think `__declspec(nothrow)` calling the terminate handler in Clang > > is a bug? > > It's certainly a behavior difference with potential performance

[PATCH] D38209: [Sema] Correct nothrow inherited by noexcept

STL_MSFT added a comment. > do you think `__declspec(nothrow)` calling the terminate handler in Clang is > a bug? It's certainly a behavior difference with potential performance impact, although I don't think it can be viewed as a bug, strictly speaking. MSVC treats `__declspec(nothrow)` as

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. Ping. https://reviews.llvm.org/D36806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r314145 - Reinstall the patch "Use EmitPointerWithAlignment to get alignment information of the pointer used in atomic expr" after fixing PR31620.

Author: wmi Date: Mon Sep 25 12:57:59 2017 New Revision: 314145 URL: http://llvm.org/viewvc/llvm-project?rev=314145=rev Log: Reinstall the patch "Use EmitPointerWithAlignment to get alignment information of the pointer used in atomic expr" after fixing PR31620. This is to fix PR34347.

[PATCH] D38250: [libunwind] Implement the Get/SetTopOfFunctionStack functions via a __thread TLS variable

mstorsjo created this revision. When targeting apple platforms, these functions are implemented in Unwind_AppleExtras.cpp, but there's previously no implementation for other platforms. Does `__thread` have any specific runtime requirements on e.g. windows? https://reviews.llvm.org/D38250

[PATCH] D38249: [libunwind] Skip building unused parts when targeting SJLJ

mstorsjo created this revision. Herald added subscribers: kristof.beyls, aemerson. When SJLJ exceptions are used, those functions aren't used. This fixes build failures on ARM with SJLJ enabled, such as armv7/iOS. https://reviews.llvm.org/D38249 Files: src/UnwindLevel1.c

[PATCH] D36737: [analyzer] Store design discussions in docs/analyzer for future use.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D36737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:134 +else if (I->isUnsigned()) + OS << I->getZExtValue() << ", which is"; +else Please print single quotes around the value.

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

zaks.anna added a comment. Sorry for the wait! Repository: rL LLVM https://reviews.llvm.org/D30295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38247: [libunwind] Correct data types in the _Unwind_FunctionContext struct

mstorsjo created this revision. This makes it match the definition used within llvm and in libgcc, we previously got the wrong layout on 64 bit. https://reviews.llvm.org/D38247 Files: src/Unwind-sjlj.c Index: src/Unwind-sjlj.c

r314142 - Revert "[NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.", rL314135.

Author: jlebar Date: Mon Sep 25 12:41:56 2017 New Revision: 314142 URL: http://llvm.org/viewvc/llvm-project?rev=314142=rev Log: Revert "[NVPTX] added match.{any,all}.sync instructions, intrinsics & builtins.", rL314135. Causing assertion failures on macos: > Assertion failed: (Num <

[PATCH] D38214: [analyzer] Fix crash on modeling of pointer arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rL314141: [analyzer] Fix crash on modeling of pointer arithmetic (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D38214?vs=116455=116590#toc Repository: rL LLVM

r314141 - [analyzer] Fix crash on modeling of pointer arithmetic

Author: alexshap Date: Mon Sep 25 12:32:33 2017 New Revision: 314141 URL: http://llvm.org/viewvc/llvm-project?rev=314141=rev Log: [analyzer] Fix crash on modeling of pointer arithmetic This patch fixes analyzer's crash on the newly added test case (see also

[PATCH] D37530: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked

This revision was automatically updated to reflect the committed changes. Closed by commit rL314138: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D37530?vs=114429=116587#toc Repository: rL

r314138 - [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked

Author: mstorsjo Date: Mon Sep 25 12:24:45 2017 New Revision: 314138 URL: http://llvm.org/viewvc/llvm-project?rev=314138=rev Log: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked Differential Revision: https://reviews.llvm.org/D37530 Added:

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

krasimir added a comment. ping https://reviews.llvm.org/D37695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38191: [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL314135: [NVPTX] added match.{any,all}.sync instructions, intrinsics & builtins. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38191?vs=116578=116584#toc Repository: rL LLVM

[PATCH] D36487: Emit section information for extern variables.

eandrews updated this revision to Diff 116581. eandrews added a comment. I've modified the patch to emit a warning for re-declarations only. I also removed the isUsed check. https://reviews.llvm.org/D36487 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenModule.cpp

r314135 - [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

Author: tra Date: Mon Sep 25 11:53:57 2017 New Revision: 314135 URL: http://llvm.org/viewvc/llvm-project?rev=314135=rev Log: [NVPTX] added match.{any,all}.sync instructions, intrinsics & builtins. Differential Revision: https://reviews.llvm.org/D38191 Modified:

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

chh added a comment. ping. https://reviews.llvm.org/D35743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38191: [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

tra added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9603 +Value *Pred = Builder.CreateSExt(Builder.CreateExtractValue(ResultPair, 1), + PredOutPtr.getElementType()); +Builder.CreateStore(Pred, PredOutPtr);

[PATCH] D38191: [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

tra updated this revision to Diff 116578. tra marked an inline comment as done. tra added a comment. Addressed Justin's comments. https://reviews.llvm.org/D38191 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Headers/__clang_cuda_intrinsics.h

[PATCH] D38191: [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

jlebar added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:419 +TARGET_BUILTIN(__nvvm_match_any_sync_i64, "WiUiWi", "", "ptx60") +// These return a pair {value, predicate} which requires custom lowering. +TARGET_BUILTIN(__nvvm_match_all_sync_i32p,

[PATCH] D38188: [CUDA] Fix names of __nvvm_vote* intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL314129: [CUDA] Fix names of __nvvm_vote* intrinsics. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38188?vs=116400=116576#toc Repository: rL LLVM

r314129 - [CUDA] Fix names of __nvvm_vote* intrinsics.

Author: tra Date: Mon Sep 25 10:55:26 2017 New Revision: 314129 URL: http://llvm.org/viewvc/llvm-project?rev=314129=rev Log: [CUDA] Fix names of __nvvm_vote* intrinsics. Also fixed a syntax error in activemask(). Differential Revision: https://reviews.llvm.org/D38188 Modified:

[PATCH] D38188: [CUDA] Fix names of __nvvm_vote* intrinsics.

tra added a comment. In https://reviews.llvm.org/D38188#880318, @jlebar wrote: > Should we add tests to the test-suite? Or, are these already caught by the > existing tests we have? That's the plan. Once clang can compile CUDA headers, I'll add CUDA-9 specific tests to the testsuite and

[PATCH] D38243: [clang-format] Add ext/ to google include categories

krasimir created this revision. Herald added a subscriber: klimek. This adds an ext/ header include category for google style. https://reviews.llvm.org/D38243 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === ---

[PATCH] D38188: [CUDA] Fix names of __nvvm_vote* intrinsics.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Should we add tests to the test-suite? Or, are these already caught by the existing tests we have? https://reviews.llvm.org/D38188 ___

r314124 - [Sema] Null check in BuildDeclarationNameExpr

Author: kongyi Date: Mon Sep 25 10:36:54 2017 New Revision: 314124 URL: http://llvm.org/viewvc/llvm-project?rev=314124=rev Log: [Sema] Null check in BuildDeclarationNameExpr Qualtype may point to null if we cannot infer its type yet. Fixes PR33843 Differential Revision:

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL314124: [Sema] Null check in BuildDeclarationNameExpr (authored by kongyi). Changed prior to commit: https://reviews.llvm.org/D38158?vs=116279=116571#toc Repository: rL LLVM

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D38158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38225: [clangd] Fix missing "message" key when responding with unsupported method

This revision was automatically updated to reflect the committed changes. Closed by commit rL314119: [clangd] Fix missing "message" key when responding with unsupported method (authored by d0k). Repository: rL LLVM https://reviews.llvm.org/D38225 Files:

[clang-tools-extra] r314119 - [clangd] Fix missing "message" key when responding with unsupported method

Author: d0k Date: Mon Sep 25 10:16:47 2017 New Revision: 314119 URL: http://llvm.org/viewvc/llvm-project?rev=314119=rev Log: [clangd] Fix missing "message" key when responding with unsupported method The language server protocol dictates that a ResponseError should have a [message string][1]

[PATCH] D38158: [Sema] Null check in BuildDeclarationNameExpr

kongyi added a comment. ping... Repository: rL LLVM https://reviews.llvm.org/D38158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38225: [clangd] Fix missing "message" key when responding with unsupported method

rwols added a comment. No, I don't have commit access. Feel free to merge. https://reviews.llvm.org/D38225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

danielmarjamaki added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D30295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

Anastasia added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:311 +// The header is basically 'struct { int; int; generic void *; +// custom_fields; }'. Assert that that struct is packed. +auto GenPtrAlign = CharUnits::fromQuantity( remove

Re: r314079 - Fix implicit-fallthrough warning by adding missing break

Is there also missing test coverage here? On Sun, Sep 24, 2017 at 8:19 AM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Sun Sep 24 08:17:46 2017 > New Revision: 314079 > > URL: http://llvm.org/viewvc/llvm-project?rev=314079=rev > Log: > Fix

[libclc] r314112 - Rework atomic ops to use clang builtins rather than llvm asm

Author: jvesely Date: Mon Sep 25 09:07:34 2017 New Revision: 314112 URL: http://llvm.org/viewvc/llvm-project?rev=314112=rev Log: Rework atomic ops to use clang builtins rather than llvm asm reviewer: Aaron Watry Signed-off-by: Jan Vesely Added:

[libclc] r314111 - prepare_builtins: Fix compile breakage with older LLVM

Author: jvesely Date: Mon Sep 25 09:04:37 2017 New Revision: 314111 URL: http://llvm.org/viewvc/llvm-project?rev=314111=rev Log: prepare_builtins: Fix compile breakage with older LLVM Fixes r314050 reviewer: Tom Stellard Signed-off-by: Jan Vesely Modified:

[PATCH] D38226: [XRay][Driver] Do not link in XRay runtime in shared libs

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good https://reviews.llvm.org/D38226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36973: [libclang] Add support for querying cursor availability

jbcoe added inline comments. Comment at: bindings/python/tests/cindex/test_cursor.py:407 +# AvailabilityKind.DEPRECATED +tu = get_tu('#include \n void test(char* s) { std::gets(s); }', lang='cpp') +cursor = get_cursor(tu, 'gets') It might be better

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

Anastasia added a comment. I think we should add a test case when the same block is both called and enqueued. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:113 + +llvm::Value *CGOpenCLRuntime::emitOpenCLEnqueuedBlock(CodeGenFunction , +

[PATCH] D38225: [clangd] Fix missing "message" key when responding with unsupported method

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. Do you have commit access? https://reviews.llvm.org/D38225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Nebiroth updated this revision to Diff 116559. Nebiroth added a comment. Fixed inverted compile_commands check logic that made tests fail. More readable command arg checks. https://reviews.llvm.org/D37150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

bader accepted this revision. bader added a comment. LGTM. Thanks! https://reviews.llvm.org/D37804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r314107 - Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON

Author: sylvestre Date: Mon Sep 25 07:08:35 2017 New Revision: 314107 URL: http://llvm.org/viewvc/llvm-project?rev=314107=rev Log: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON Reviewers: malaperle, malaperle-ericsson, bkramer Reviewed By: bkramer Subscribers: bkramer, mgorny,

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

Anastasia updated this revision to Diff 116548. Anastasia added a comment. Addressed comments from Alexey. https://reviews.llvm.org/D37804 Files: lib/CodeGen/CGBuilder.h lib/CodeGen/CGExpr.cpp test/CodeGenOpenCL/vectorLoadStore.cl Index: test/CodeGenOpenCL/vectorLoadStore.cl

[PATCH] D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D38228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38171: Implement clang-tidy check aliases.

lebedev.ri added a comment. In https://reviews.llvm.org/D38171#880025, @xazax.hun wrote: > In https://reviews.llvm.org/D38171#880022, @lebedev.ri wrote: > > > A mail [0] posted by @JonasToth is about the similar problem, i think we > > can continue there. > > > Great! Could you summarize your

r314104 - [Clang] Adding missing feature to goldmont

Author: mzuckerm Date: Mon Sep 25 06:49:32 2017 New Revision: 314104 URL: http://llvm.org/viewvc/llvm-project?rev=314104=rev Log: [Clang] Adding missing feature to goldmont Change-Id: I6c22478d16b8e02ce60dae2f8c80d43bc5ab3a9c Modified: cfe/trunk/lib/Basic/Targets/X86.cpp

[PATCH] D38231: fixing a bug in mask[z]_set1

This revision was automatically updated to reflect the committed changes. Closed by commit rL314102: fixing a bug in mask[z]_set1 intrinsic (authored by jina.nahias). Changed prior to commit: https://reviews.llvm.org/D38231?vs=116513=116545#toc Repository: rL LLVM

r314102 - fixing a bug in mask[z]_set1 intrinsic

Author: jina.nahias Date: Mon Sep 25 06:38:08 2017 New Revision: 314102 URL: http://llvm.org/viewvc/llvm-project?rev=314102=rev Log: fixing a bug in mask[z]_set1 intrinsic Differential Revision: https://reviews.llvm.org/D38231 Change-Id: I80bbff9cbe93e4be54d8a761ef9723edf3f57c57 Modified:

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth added a comment. In https://reviews.llvm.org/D36150#879194, @ilya-biryukov wrote: > Looks good. > Do you want me to submit this patch for you? Yes please. https://reviews.llvm.org/D36150 ___ cfe-commits mailing list

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

NoQ updated this revision to Diff 116542. NoQ added a comment. @dcoughlin: You're right, my reasoning and understanding was not correct, and your explanation is much more clear. My code still makes sense to me though, so i updated the comments to match. And moved the unusual logic for the

[PATCH] D38171: Implement clang-tidy check aliases.

xazax.hun added a comment. In https://reviews.llvm.org/D38171#880022, @lebedev.ri wrote: > A mail [0] posted by @JonasToth is about the similar problem, i think we can > continue there. Great! Could you summarize your points there as well? Thanks in advance. https://reviews.llvm.org/D38171

[PATCH] D38171: Implement clang-tidy check aliases.

alexfh added a comment. In https://reviews.llvm.org/D38171#878814, @lebedev.ri wrote: > On a somewhat related note, since this is already talking about aliases > > I feel like the current handling of the clang-tidy check aliases needs > adjusting. > If one enables all the checks (`Checks:

[PATCH] D38171: Implement clang-tidy check aliases.

lebedev.ri added a comment. In https://reviews.llvm.org/D38171#880016, @xazax.hun wrote: > In https://reviews.llvm.org/D38171#878814, @lebedev.ri wrote: > > > I feel like the current handling of the clang-tidy check aliases needs > > adjusting. > > If one enables all the checks (`Checks:

[PATCH] D38171: Implement clang-tidy check aliases.

xazax.hun added a comment. In https://reviews.llvm.org/D38171#878808, @alexfh wrote: > András, that's definitely an interesting idea. However, it might be > interesting to explore a more principled approach: > > 1. Make `clang-diagnostic-*` checks first-class citizens and take full > control

[PATCH] D38209: [Sema] Correct nothrow inherited by noexcept

aaron.ballman added a comment. I'm not certain we have the semantics of `__declspec(nothrow)` exactly correct -- a simple test shows that `__attribute__((nothrow))`, `__declspec(nothrow)`, and `noexcept(true)` are subtly different. When I run this with MSVC 2017, the terminate handler is not

[PATCH] D38171: Implement clang-tidy check aliases.

xazax.hun added a comment. @leanil : Could you add a test case where the warnings are explicitly disabled in the compilation command and also one where only the aliased warning is explicitly disabled? In https://reviews.llvm.org/D38171#878814, @lebedev.ri wrote: > I feel like the current

[PATCH] D38231: fixing a bug in mask[z]_set1

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38205: [Sema] Warn on attribute nothrow conflicting with language specifiers

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1411 +def warn_nothrow_attr_disagrees_with_exception_specification +: ExtWarn<"Attribute nothrow ignored, it disagrees with language specified " + "exception

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

lebedev.ri added a comment. Nice! /home/eenitot/new_llvm/llvm/lib/Support/ConvertUTFWrapper.cpp:38:26: warning: do not cast pointers into more strictly aligned pointer types [cert-exp36-c] UTF16 *targetStart = reinterpret_cast(ResultPtr); ^ Hmm, the

[PATCH] D38203: [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor testing nit, LGTM! Thanks! Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:20 + } + void __attribute__((nothrow)) SomeThrow()

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2692 + let Content = [{ +Clang supports the GNU style ``__attribute__((nothrow))`` attribute as an +equivilent of `noexcept` on function declarations. This attribute informs the

[PATCH] D32520: Support __fp16 vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rL314056: Promote storage-only __fp16 vector operands to float vectors. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D32520?vs=116275=116533#toc Repository: rL LLVM

[PATCH] D38214: [analyzer] Fix crash on modeling of pointer arithmetic

alexfh added a comment. Thanks for the fix! Repository: rL LLVM https://reviews.llvm.org/D38214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36737: [analyzer] Store design discussions in docs/analyzer for future use.

NoQ updated this revision to Diff 116520. NoQ added a comment. Update to use `.rst` formatting. https://reviews.llvm.org/D36737 Files: docs/analyzer/DesignDiscussions/InitializerLists.rst Index: docs/analyzer/DesignDiscussions/InitializerLists.rst

[PATCH] D38118: [CodeGen][ObjC] Build the global block structure before emitting the body of global block invoke functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL314029: [CodeGen][ObjC] Build the global block structure before emitting the (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D38118?vs=116135=116524#toc Repository: rL LLVM

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

NoQ updated this revision to Diff 116512. NoQ added a comment. Fix some comments in tests. Devin: ok to commit? I hope i didn't miss anything in my reasoning about boxed expressions. https://reviews.llvm.org/D35216 Files: lib/StaticAnalyzer/Core/ExprEngine.cpp

[PATCH] D38231: fixing a bug in mask[z]_set1

jina.nahias updated this revision to Diff 116513. https://reviews.llvm.org/D38231 Files: lib/Headers/avx512vlintrin.h test/CodeGen/avx512vl-builtins.c Index: test/CodeGen/avx512vl-builtins.c === ---

[PATCH] D38231: fixing a bug in mask[z]_set1

jina.nahias created this revision. https://reviews.llvm.org/D38231 Files: lib/Headers/avx512vlintrin.h Index: lib/Headers/avx512vlintrin.h === --- lib/Headers/avx512vlintrin.h +++ lib/Headers/avx512vlintrin.h @@ -5761,15

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

NorenaLeonetti updated this revision to Diff 116510. Repository: rL LLVM https://reviews.llvm.org/D33826 Files: clang-tidy/cert/AvoidPointerCastToMoreStrictAlignmentCheck.cpp clang-tidy/cert/AvoidPointerCastToMoreStrictAlignmentCheck.h clang-tidy/cert/CERTTidyModule.cpp

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

NorenaLeonetti added a comment. In https://reviews.llvm.org/D33826#866145, @lebedev.ri wrote: > In https://reviews.llvm.org/D33826#866133, @NorenaLeonetti wrote: > > > In https://reviews.llvm.org/D33826#861226, @aaron.ballman wrote: > > > > > Have you run this check over any large code bases to

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

xazax.hun added a comment. In https://reviews.llvm.org/D30691#878830, @r.stahl wrote: > For my purposes I replaced the return statement of the > compareCrossTUSourceLocs function with: > > return XL.getFileID() < YL.getFileID(); > > > A more correct fix would create only one unique diagnostic

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

xazax.hun updated this revision to Diff 116502. xazax.hun added a comment. Herald added a subscriber: baloghadamsoftware. - Fixed an issue with source locations - Updated to latest trunk https://reviews.llvm.org/D30691 Files: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h

[PATCH] D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON

sylvestre.ledru created this revision. Herald added subscribers: ilya-biryukov, mgorny. https://reviews.llvm.org/D38228 Files: clangd/tool/CMakeLists.txt Index: clangd/tool/CMakeLists.txt === --- clangd/tool/CMakeLists.txt +++

  1   2   >