rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
ahatanak created this revision.
This is a follow-up patch to r314370.
Rather than throwing away the enclosing parentheses in maybeUndoReclaimObject,
this patch walks down the expression until an ARCReclaimReturnedObject cast is
found and removes just the cast, preserving the syntactic sugar exp
Author: vedantk
Date: Fri Oct 6 18:42:09 2017
New Revision: 315142
URL: http://llvm.org/viewvc/llvm-project?rev=315142&view=rev
Log:
[Driver] Fix -static-libsan / -shared-libsan on Darwin
Don't ignore these flags on Darwin. The old behavior of using the
dynamic runtime when neither flag is passe
ahatanak updated this revision to Diff 118119.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D36918
Files:
lib/Sema/SemaAccess.cpp
test/SemaCXX/access.cpp
Index: test/SemaCXX/access.cpp
===
--- t
ahatanak added inline comments.
Comment at: lib/Sema/SemaAccess.cpp:1798
+ EffectiveContext EC(CurScope->getEntity());
+ if (IsAccessible(*this, EC, Entity) == ::AR_accessible)
+return AR_accessible;
Rakete wrote:
> You don't need that scope resolution
Carrot created this revision.
Herald added a subscriber: nemanjai.
Usually compare expression should return i1 type, so EmitScalarConversion is
called before return
return EmitScalarConversion(Result, CGF.getContext().BoolTy, E->getType(),
E->getExprLoc());
But when ppc intrinsic is called t
jkorous-apple updated this revision to Diff 118115.
jkorous-apple added a comment.
Solved issues from CR.
https://reviews.llvm.org/D38643
Files:
lib/Index/USRGeneration.cpp
test/Index/USR/array-type.cpp
Index: test/Index/USR/array-type.cpp
=
jkorous-apple added a comment.
Replied and going to delete the end delimiter.
Comment at: lib/Index/USRGeneration.cpp:819
}
+if (const ArrayType *const AT = dyn_cast(T)) {
+ Out << "{";
arphaman wrote:
> You can use `const auto *` here.
That's wha
kcc added a comment.
In https://reviews.llvm.org/D38642#891125, @morehouse wrote:
> In https://reviews.llvm.org/D38642#891074, @kcc wrote:
>
> > If you can *easily* share main() with the one in LLVM -- do it, otherwise
> > don't bother.
>
>
> Does the fuzzer main come from LLVM or compiler-rt no
arphaman added a comment.
Thanks, it looks much better! A couple more comments:
Comment at: lib/Index/USRGeneration.cpp:819
}
+if (const ArrayType *const AT = dyn_cast(T)) {
+ Out << "{";
You can use `const auto *` here.
Comment
compnerd closed this revision.
compnerd added a comment.
SVN r315126
Repository:
rL LLVM
https://reviews.llvm.org/D37891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Fri Oct 6 16:09:55 2017
New Revision: 315126
URL: http://llvm.org/viewvc/llvm-project?rev=315126&view=rev
Log:
Driver: hoist the `wchar_t` handling to the driver
Move the logic for determining the `wchar_t` type information into the
driver. Rather than passing the single
compnerd added inline comments.
Comment at: lib/Basic/Targets/AArch64.cpp:47-51
+ bool IsNetBSD = getTriple().getOS() == llvm::Triple::NetBSD;
+ bool IsOpenBSD = getTriple().getOS() == llvm::Triple::OpenBSD;
+ if (!getTriple().isOSDarwin() && !IsNetBSD && !IsOpenBSD)
+WCha
jkorous-apple updated this revision to Diff 118104.
jkorous-apple added a comment.
Ammenended as suggested.
https://reviews.llvm.org/D38643
Files:
lib/Index/USRGeneration.cpp
test/Index/USR/array-type.cpp
Index: test/Index/USR/array-type.cpp
===
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good with nits
Comment at: lib/Basic/Targets/AArch64.cpp:47-51
+ bool IsNetBSD = getTriple().getOS() == llvm::Triple::NetBSD;
+ bool IsOpenBSD = getTriple().getOS() == llvm
morehouse added a comment.
In https://reviews.llvm.org/D38642#891074, @kcc wrote:
> If you can *easily* share main() with the one in LLVM -- do it, otherwise
> don't bother.
Does the fuzzer main come from LLVM or compiler-rt now? There's still
FuzzerMain.cpp, but I'm not sure if we should be
kcc added a reviewer: vitalybuka.
kcc added a comment.
conceptually ok, but please let Vitaly review the cmake part.
https://reviews.llvm.org/D38642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
morehouse updated this revision to Diff 118097.
morehouse added a comment.
- Revert "Remove dummy main and link with -fsantize=fuzzer."
https://reviews.llvm.org/D38642
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ClangFuzzer.cpp
clang/tools/clang-fuzzer/DummyCla
kcc added a comment.
grrr. I am sorry, I've just contradicted myself. :(
The goal here is to build the fuzz targets always and use them as tests, which
includes building with any toolchain, including toolchains that don't support
-fsanitize=fuzzer
your original change actually solved this.
morehouse updated this revision to Diff 118087.
morehouse added a comment.
- Remove dummy main and link with -fsantize=fuzzer.
https://reviews.llvm.org/D38642
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/proto-to-cxx/CMakeLists.txt
Index: clang/tools/clang-fuzzer
compnerd updated this revision to Diff 118085.
compnerd added a comment.
Split the defaulting back to all the various targets.
Repository:
rL LLVM
https://reviews.llvm.org/D37891
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
include/clang/Basic/LangOptions.def
include/clang/Dri
Author: rnk
Date: Fri Oct 6 14:28:21 2017
New Revision: 315111
URL: http://llvm.org/viewvc/llvm-project?rev=315111&view=rev
Log:
Revert "For dllexport class templates, export specializations of member
functions (PR34849)"
This reverts r315025, it caused http://crbug.com/772461
Modified:
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315107: [MS] Raise the default value of _MSC_VER to 1911,
which is VS 2017 (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D38646?vs=118079&id=118080#toc
Repository:
rL LLVM
htt
Author: rnk
Date: Fri Oct 6 14:02:28 2017
New Revision: 315107
URL: http://llvm.org/viewvc/llvm-project?rev=315107&view=rev
Log:
[MS] Raise the default value of _MSC_VER to 1911, which is VS 2017
Summary:
This raises our default past 1900, which controls whether char16_t is a
builtin type or not
rnk updated this revision to Diff 118079.
rnk added a comment.
- go to 1911, 1910 was the preview
- add release notes
https://reviews.llvm.org/D38646
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Driver/ToolChains/MSVC.cpp
Index: clang/lib/Driver/ToolChains/MSVC.cpp
===
kcc added a comment.
We often suggest to code owners to implement their own dummy main to run fuzz
targets as regression tests.
But for ourselves (LLVM) this recommendations makes less sense since libFuzzer
is part of LLVM and we can use it's main directly.
https://reviews.llvm.org/D38642
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks!
Should probably get a release note too.
https://reviews.llvm.org/D38646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: arphaman
Date: Fri Oct 6 13:51:04 2017
New Revision: 315103
URL: http://llvm.org/viewvc/llvm-project?rev=315103&view=rev
Log:
-Wdocumentation should allow '...' params in variadic function type aliases
rdar://34811344
Modified:
cfe/trunk/lib/AST/CommentSema.cpp
cfe/trunk/test/Se
rnk created this revision.
This raises our default past 1900, which controls whether char16_t is a
builtin type or not.
Implements PR34243
https://reviews.llvm.org/D38646
Files:
clang/lib/Driver/ToolChains/MSVC.cpp
Index: clang/lib/Driver/ToolChains/MSVC.cpp
===
arphaman added inline comments.
Comment at: lib/Index/USRGeneration.cpp:820
+if (const ArrayType *const AT = dyn_cast(T)) {
+ VisitType(AT->getElementType());
+ Out << "[";
We should probably follow the other types and just set `T =
AT->getElementT
morehouse added a comment.
In https://reviews.llvm.org/D38642#890969, @kcc wrote:
> I'd like to know more.
> At least simple cases work fine:
You're right. I was trying to add `-fsanitize=fuzzer` to `CMAKE_CXX_FLAGS`
right before the link command, which was causing a later compilation to gi
jkorous-apple updated this revision to Diff 118066.
jkorous-apple added a comment.
Uploaded full diff.
https://reviews.llvm.org/D38643
Files:
lib/Index/USRGeneration.cpp
test/Index/USR/array-type.cpp
Index: test/Index/USR/array-type.cpp
yaxunl updated this revision to Diff 118064.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Revise by Anastasia's comments.
https://reviews.llvm.org/D38134
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGOpenCLRuntime.cpp
lib/CodeGen/CGOpenCLRuntime.h
lib/CodeGen/CodeGe
arphaman added a comment.
Thanks for working on this!
Could you please post the patch with full context (`git diff -U99`)?
Comment at: test/Index/USR/array-type.cpp:1
+// RUN: c-index-test core -print-source-symbols -- %s | grep
"function(Gen,TS)/C++" | grep foo | cut -s -
Rakete added inline comments.
Comment at: lib/Sema/SemaAccess.cpp:1798
+ EffectiveContext EC(CurScope->getEntity());
+ if (IsAccessible(*this, EC, Entity) == ::AR_accessible)
+return AR_accessible;
You don't need that scope resolution operator there. Al
kcc added a comment.
>> Will we be able to reuse some of Justin's code instead of creating one more
>> main() function?
>
> This reuses the code that Justin moved to FuzzMutate/FuzzerCLI. That's why
> the main is so short. But perhaps we could move the main itself into
> FuzzerCLI?
Yes, hav
morehouse added a comment.
In https://reviews.llvm.org/D38642#890963, @kcc wrote:
> It's not about coverage instrumentation (not) being present, but about
> libFuzzer's main() being present, right?
Yes.
> Will we be able to reuse some of Justin's code instead of creating one more
> main() fu
kcc added a comment.
It's not about coverage instrumentation (not) being present, but about
libFuzzer's main() being present, right?
Will we be able to reuse some of Justin's code instead of creating one more
main() function?
Or, why not link with libFuzzer (-fsanitize=fuzzer at link time) eve
jkorous-apple created this revision.
Added array type mangling to USR generation. Included test from bug report.
Repository:
rL LLVM
https://reviews.llvm.org/D38643
Files:
lib/Index/USRGeneration.cpp
test/Index/USR/array-type.cpp
Index: test/Index/USR/array-type.cpp
===
morehouse created this revision.
Herald added a subscriber: mgorny.
Build with DummyClangFuzzer.cpp as entry point when coverage
instrumentation isn't present.
https://reviews.llvm.org/D38642
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ClangFuzzer.cpp
clang/too
erichkeane updated this revision to Diff 118058.
erichkeane marked 5 inline comments as done.
erichkeane added a comment.
All requested changes AFAIK. Also, discovered that I wasn't calling cpu-init
at the beginning of my resolver, so added that.
Note: Virtual functions seem to have a bunch of
erichkeane marked 31 inline comments as done.
erichkeane added a subscriber: rnk.
erichkeane added a comment.
Weew... I think I got everything. Thanks for the review you three! I've got
another patch coming momentarily with what I believe is all your suggestions.
Comment at:
Author: arphaman
Date: Fri Oct 6 12:49:29 2017
New Revision: 315095
URL: http://llvm.org/viewvc/llvm-project?rev=315095&view=rev
Log:
Revert r315087
clang-refactor crashes on some bots after this commit
Removed:
cfe/trunk/include/clang/Tooling/Refactoring/RefactoringOption.h
cfe/trunk/i
arsenm closed this revision.
arsenm added a comment.
r315094
Comment at: test/CodeGenOpenCL/convergent.cl:130
+// CHECK: attributes #0 = { noinline norecurse nounwind "
+// CHECK: attributes #1 = { {{[^}]*}}convergent{{[^}]*}} }
+// CHECK: attributes #2 = { {{[^}]*}}convergent{
Author: arsenm
Date: Fri Oct 6 12:34:40 2017
New Revision: 315094
URL: http://llvm.org/viewvc/llvm-project?rev=315094&view=rev
Log:
OpenCL: Assume functions are convergent
This was done for CUDA functions in r261779, and for the same
reason this also needs to be done for OpenCL. An arbitrary
fun
Author: arphaman
Date: Fri Oct 6 12:24:26 2017
New Revision: 315093
URL: http://llvm.org/viewvc/llvm-project?rev=315093&view=rev
Log:
[ObjC] Don't warn on readwrite properties with custom setters that
override readonly properties from protocols
rdar://34192541
Added:
cfe/trunk/test/SemaObjC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315090: [docs] Mention that SjLj works on any OS on the
archs where supported by the… (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D38576?vs=117778&id=118054#toc
Repository
Author: mstorsjo
Date: Fri Oct 6 12:14:07 2017
New Revision: 315090
URL: http://llvm.org/viewvc/llvm-project?rev=315090&view=rev
Log:
[docs] Mention that SjLj works on any OS on the archs where supported by the
compiler
Differential Revision: https://reviews.llvm.org/D38576
Modified:
libun
kosarev added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:55
#include "llvm/IR/Module.h"
+#include "llvm/IR/Verifier.h" // TODO
#include "llvm/ProfileData/InstrProfReader.h"
Oops. Will be removed.
https://reviews.llvm.org/D38126
___
kosarev updated this revision to Diff 118045.
kosarev edited the summary of this revision.
kosarev added a comment.
Re-based on top of the previous refinements: https://reviews.llvm.org/D38404,
https://reviews.llvm.org/D38408, https://reviews.llvm.org/D38456,
https://reviews.llvm.org/D38460, htt
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdUnit.cpp:81
+ std::map takeIncludeMap() {
+return std::move(IncludeMap);
takeIncludeLocationMap?
==
Nebiroth updated this revision to Diff 118046.
Nebiroth added a comment.
Fixed accidental removal of CheckSourceHeaderSwitch test
https://reviews.llvm.org/D38639
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
unittests/clangd/ClangdTests.cpp
Index: unittests/c
arphaman added inline comments.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:73
+template
+class OptionRequirement : public RefactoringOptionsRequirement {
+public:
ioeric wrote:
> nit: `OptionRequirement` sounds more genera
This revision was automatically updated to reflect the committed changes.
arphaman marked 3 inline comments as done.
Closed by commit rL315087: [refactor] add support for refactoring options
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D37856?vs=117124&id=118044#toc
Author: arphaman
Date: Fri Oct 6 11:12:29 2017
New Revision: 315087
URL: http://llvm.org/viewvc/llvm-project?rev=315087&view=rev
Log:
[refactor] add support for refactoring options
This commit adds initial support for refactoring options. One can now use
optional and required std::string options
Nebiroth created this revision.
ctrl-clicking on #include statements now opens the file being pointed by that
statement.
https://reviews.llvm.org/D38639
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
unittests/clangd/ClangdTests.cpp
Index: unittests/clangd/Cl
arphaman updated this revision to Diff 118042.
arphaman marked 5 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D38402
Files:
include/clang/Frontend/CommandLineSourceLoc.h
test/Refactor/tool-apply-replacements.cpp
arphaman added inline comments.
Comment at: test/Refactor/tool-apply-replacements.cpp:6
+
+class RenameMe { // CHECK: class {
+};
ioeric wrote:
> Why is the result `class {`?
Sorry, the test was broken. Fixed!
Repository:
rL LLVM
https://reviews.llvm.org/D38
Author: zturner
Date: Fri Oct 6 10:54:46 2017
New Revision: 315085
URL: http://llvm.org/viewvc/llvm-project?rev=315085&view=rev
Log:
[lit] Improve tool substitution in lit.
This addresses two sources of inconsistency in test configuration
files.
1. Substitution boundaries. Previously you would
Author: zturner
Date: Fri Oct 6 10:54:27 2017
New Revision: 315084
URL: http://llvm.org/viewvc/llvm-project?rev=315084&view=rev
Log:
Run pyformat on lit code.
Modified:
cfe/trunk/test/lit.cfg.py
Modified: cfe/trunk/test/lit.cfg.py
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit
ahatanak added a comment.
ping
https://reviews.llvm.org/D36918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
In https://reviews.llvm.org/D35082#890359, @Anastasia wrote:
> In https://reviews.llvm.org/D35082#890162, @rjmccall wrote:
>
> > Okay. I think I see your point about why it would be better to have a
> > canonical __private address space that is different from the impli
arphaman added inline comments.
Comment at: test/CodeCompletion/call.cpp:22
// CHECK-CC1: COMPLETION: Pattern : dynamic_cast<<#type#>>(<#expression#>)
- // CHECK-CC1: f(N::Y y, <#int ZZ#>)
+ // CHECK-CC1: f(Y y, <#int ZZ#>)
// CHECK-CC1-NEXT: f(int i, <#int j#>, int k)
--
Author: probinson
Date: Fri Oct 6 10:12:28 2017
New Revision: 315078
URL: http://llvm.org/viewvc/llvm-project?rev=315078&view=rev
Log:
For Windows, allow .exe extension in a test.
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/baremetal.cpp
URL:
http://llvm.o
Author: abataev
Date: Fri Oct 6 10:00:28 2017
New Revision: 315076
URL: http://llvm.org/viewvc/llvm-project?rev=315076&view=rev
Log:
[OPENMP] Do not capture local static variables.
Previously we may erroneously try to capture locally declared static
variables, which will lead to crash for target
lebedev.ri added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8719
+ // Type limit values are handled later by CheckTautologicalComparison().
+ if (IsTypeLimit(S, Other, Constant, ConstValue) && (!OtherIsBooleanType))
return;
lebedev.ri wrote:
>
arphaman added inline comments.
Comment at: include/clang/Sema/Scope.h:129
+/// We are between inheritance colon and the real class/struct definition
scope
+ClassInheritanceScope = 0x40,
};
Could you please rebase this patch? There's another scope
davidxl added a comment.
Can you add a test case with shared libraries?
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chill added a comment.
FYI, there is a similar issue in
`test/std/utilities/variant/variant.helpers/variant_alternative.fail.cpp` added
by the
same commit
git hash: a12318f5ae0aae44eb17f376d3598717b45f7a5f
"Added failing tests for index out of range for tuple_element> and
variant_alternativ
Author: erichkeane
Date: Fri Oct 6 09:40:45 2017
New Revision: 315075
URL: http://llvm.org/viewvc/llvm-project?rev=315075&view=rev
Log:
Split X86::BI__builtin_cpu_init handling into own function[NFC]
The Cpu Init functionality is required for the target
attribute, so this patch simply splits it
elsteveogrande added a comment.
Hi @bruno, @rsmith, does this approach look ok?
I couldn't easily figure out a better way to store inherited-default-info;
doing it alongside the default value seemed the cleanest.
Note: I saw there are three ways to store these data inside the
`DefaultArgStorag
Author: abataev
Date: Fri Oct 6 09:17:25 2017
New Revision: 315074
URL: http://llvm.org/viewvc/llvm-project?rev=315074&view=rev
Log:
[OPENMP] Capture references to global variables.
In C++11 variable to global variables are considered as constant
expressions and these variables are not captured
ilya-biryukov added a comment.
I hope the whole design doesn't seem overly complicated. Very much open to
suggestions on how to simplify it :-)
https://reviews.llvm.org/D38629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
ilya-biryukov created this revision.
https://reviews.llvm.org/D38629
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
Index: clangd/ClangdServer.h
===
--- clangd/ClangdServer.h
+++ clangd/ClangdServer.h
@@ -252,6 +252,14 @@
ilya-biryukov updated this revision to Diff 118008.
ilya-biryukov added a comment.
- Fix to ForwardBinder.
- Add UniqueFunction(nullptr) constructor.
- Added missing STL headers to Function.h
https://reviews.llvm.org/D38627
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/Funct
yaxunl marked 6 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:144
+ if (auto *I = dyn_cast(V)) {
+// If the block literal is emitted as an instruction, it is an alloca
+// and the block invoke function is stored to GEP
rogfer01 updated this revision to Diff 118005.
rogfer01 retitled this revision from "Mark test as unsupported in C++98 as
well" to "Mark tests as unsupported in C++98 as well".
rogfer01 added a comment.
ChangeLog:
- I wanted to mark two tests but forgot to add one in the previous change
https:
rogfer01 created this revision.
https://reviews.llvm.org/D38628
Files:
test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp
Index: test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp
===
--- test/
r.stahl added a comment.
In https://reviews.llvm.org/D34512#877643, @xazax.hun wrote:
> - Unittests now creates temporary files at the correct location
> - Temporary files are also cleaned up when the process is terminated
> - Absolute paths are handled correctly by the library
I think there is
szepet added a comment.
Hello Daniel!
It is a great feature to add, thanks for working on this!
I have just small comments (rather questions) on the code.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:155
+ Children.push(FuncBody);
+ while (!Children.empty()) {
+con
ilya-biryukov created this revision.
They are now used in ClangdScheduler instead of deferred std::async
computations.
The results of `std::async` are much less effective and do not provide
a good abstraction for similar purposes, i.e. for storing additional callbacks
to clangd async tasks. The ac
Author: ibiryukov
Date: Fri Oct 6 07:39:39 2017
New Revision: 315065
URL: http://llvm.org/viewvc/llvm-project?rev=315065&view=rev
Log:
[clangd] Run clang-format on the source code. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Modified: clang-tools-extra/trunk/clangd/Clangd
baloghadamsoftware added a comment.
I am considering to restrict the assumptions to nodes marked as interesting and
to the location of the bug. However, I have difficulties with the latter, it
seems that the bug location itself is not part of the bug path.
https://reviews.llvm.org/D34508
__
baloghadamsoftware added a comment.
I think that the acceptable false positive rate of a compiler warning is much
lower than that of a Tidy check. So I understand that the fronted patch will
not handle the indirect cases (which are the most important in my opinion) or
the cases where there are
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: include/clang/AST/Decl.h:2226
+ MultiVersionKind getMultiVersionKind() const {
+return static_cast(this->MultiVersion);
+ }
Drop the `this->`
yvvan updated this revision to Diff 117988.
yvvan added a comment.
Fix according to the review comment
https://reviews.llvm.org/D38618
Files:
include/clang/Sema/Scope.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaCodeComplete.cpp
test/Index/complete-super.cpp
Index: test/Index/complete-su
baloghadamsoftware added a comment.
It seems that Artem's suggestion is not enough (or I misunderstood it). So two
options remain: either we drop this and revert to the local solution in the
Iterator Checkers or we extend the type when rearranging the comparison. Which
way to go?
https://revi
ilya-biryukov resigned from this revision.
ilya-biryukov added a comment.
I'm not actually familiar with `CXCursor`, so can't really help with reviewing
this.
https://reviews.llvm.org/D38615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
erikjv added a comment.
lgtm, but someone else will probably have to review it too.
Comment at: lib/Parse/ParseDeclCXX.cpp:3196
if (Tok.is(tok::colon)) {
+ParseScope ClassScope(this, Scope::ClassScope|Scope::DeclScope |
Scope::ClassInheritanceScope);
+
On Fri, Oct 6, 2017 at 9:27 AM, Alexander Kornienko wrote:
>
>
> On 6 Oct 2017 14:59, "Aaron Ballman via cfe-commits"
> wrote:
>
> Author: aaronballman
> Date: Fri Oct 6 05:57:28 2017
> New Revision: 315057
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev
> Log:
> Fix nested name
Author: aaronballman
Date: Fri Oct 6 06:27:59 2017
New Revision: 315060
URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev
Log:
Renaming a test to start with the name of the check based on post-commit review
feedback; NFC.
Added:
clang-tools-extra/trunk/test/clang-tidy/google-rea
On 6 Oct 2017 14:59, "Aaron Ballman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: aaronballman
Date: Fri Oct 6 05:57:28 2017
New Revision: 315057
URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev
Log:
Fix nested namespaces in google-readability-nested-namespace-comment
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
erikjv updated this revision to Diff 117986.
https://reviews.llvm.org/D38578
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPDirectives.cpp
lib/Lex/Preprocessor.cpp
lib/Serialization/ASTReader.cpp
lib/Serialization/ASTWriter.cpp
test/Index/preamble-conditionals-inverted.cpp
test/I
Author: aaronballman
Date: Fri Oct 6 06:14:28 2017
New Revision: 315059
URL: http://llvm.org/viewvc/llvm-project?rev=315059&view=rev
Log:
Fixing the command line for a test and switching from tabs to spaces.
Modified:
clang-tools-extra/trunk/test/clang-tidy/google-readability-nested-namespa
ilya-biryukov added a comment.
Sorry for the delay.
The patch does not apply cleanly on top of the current head. Mostly conflicts
with `switchHeaderSource` for me.
Could you please rebase your change with head and resubmit it?
Another note: current implementation does not seem to handle macros
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D38113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
On Fri, Oct 6, 2017 at 3:15 PM, Erik Viktorsson via cfe-commits
wrote:
Hi.
> Committing a patch to Bugzilla 31373
>
> A novice programmer so hopefully it complies with the coding policy.
I think it may be better to put it to Phabricator, see
https://llvm.org/docs/Phabricator.html#id3
Please do n
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r315057. Thank you!
https://reviews.llvm.org/D38284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Fri Oct 6 05:57:28 2017
New Revision: 315057
URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev
Log:
Fix nested namespaces in google-readability-nested-namespace-comments.
Fixes PR34701.
Patch by Alexandru Octavian Buțiu.
Added:
clang-tools-extra/trunk
1 - 100 of 127 matches
Mail list logo
