[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

hfinkel updated this revision to Diff 119103. hfinkel added a comment. Rebased. https://reviews.llvm.org/D32199 Files: include/clang/Basic/Sanitizers.def include/clang/Driver/SanitizerArgs.h lib/CodeGen/BackendUtil.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp

[PATCH] D35782: [C++2a][Preprocessor] Implement p0306 __VA_OPT__ (Comma omission and comma deletion)

faisalv abandoned this revision. faisalv marked 12 inline comments as done. faisalv added a comment. committed as r315840. https://reviews.llvm.org/rL315840 Repository: rL LLVM https://reviews.llvm.org/D35782 ___ cfe-commits mailing list

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

rwols created this revision. This changes the onShutdown handler to do essentially nothing (for now), and instead exits the runloop when we receive the exit notification from the client. Some clients may wait on the reply from the shutdown request before sending an exit notification. If we exit

[libcxx] r315882 - Fix last_write_time.pass.cpp to work with clang-3.9 and earlier

Author: lebedevri Date: Sun Oct 15 14:52:53 2017 New Revision: 315882 URL: http://llvm.org/viewvc/llvm-project?rev=315882=rev Log: Fix last_write_time.pass.cpp to work with clang-3.9 and earlier At least with clang-3.9 and earlier, -Wunknown-pragmas is also needed. Modified:

[libcxx] r315876 - Really do make sure that last_write_time.pass.cpp still works with old clang

Author: lebedevri Date: Sun Oct 15 13:46:12 2017 New Revision: 315876 URL: http://llvm.org/viewvc/llvm-project?rev=315876=rev Log: Really do make sure that last_write_time.pass.cpp still works with old clang I *did* try to check that such kind of an issue was not introduced by the rL315874, but

r315871 - Convert clang::LangAS to a strongly typed enum

Author: arichardson Date: Sun Oct 15 11:48:14 2017 New Revision: 315871 URL: http://llvm.org/viewvc/llvm-project?rev=315871=rev Log: Convert clang::LangAS to a strongly typed enum Summary: Convert clang::LangAS to a strongly typed enum Currently both clang AST address spaces and target specific

[libcxx] r315874 - Silence clang's -Wtautological-constant-compare in last_write_time.pass.cpp

Author: lebedevri Date: Sun Oct 15 13:12:42 2017 New Revision: 315874 URL: http://llvm.org/viewvc/llvm-project?rev=315874=rev Log: Silence clang's -Wtautological-constant-compare in last_write_time.pass.cpp Previously this broke the builders, when D38101 was committed. Silence the warning so

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

This revision was automatically updated to reflect the committed changes. Closed by commit rL315875: [Sema] Re-land: Diagnose tautological comparison with type's min/max values (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D38101?vs=118835=119095#toc Repository:

r315875 - [Sema] Re-land: Diagnose tautological comparison with type's min/max values

Author: lebedevri Date: Sun Oct 15 13:13:17 2017 New Revision: 315875 URL: http://llvm.org/viewvc/llvm-project?rev=315875=rev Log: [Sema] Re-land: Diagnose tautological comparison with type's min/max values The first attempt, rL315614 was reverted because one libcxx test broke, and i did not

[PATCH] D38796: [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

kosarev updated this revision to Diff 119089. kosarev edited the summary of this revision. kosarev added a comment. - Fixed handling of explicit casts. - Added a test case. https://reviews.llvm.org/D38796 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp

[PATCH] D38796: [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

kosarev added a comment. With this patch applied we fail on bootstrapping stages of release builds (meaning enabled TBAA). The reason is that for some casts we do not generate TBAA info that corresponds to the target type and leave them with TBAA info for the cast's operand expression. This

[PATCH] D38704: [libunwind] Abstract rwlocks into a class, provide a SRW lock implementation for windows

mstorsjo updated this revision to Diff 119094. mstorsjo retitled this revision from "[libunwind] Emulate pthread rwlocks via SRW locks for windows" to "[libunwind] Abstract rwlocks into a class, provide a SRW lock implementation for windows". mstorsjo edited the summary of this revision.

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added inline comments. Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:76 + // So either static out-of-line or non-static in-line. + const std::array Msgs = {{ + // FIXME: these messages somehow trigger an assertion:

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 119091. lebedev.ri marked 9 inline comments as done and an inline comment as not done. lebedev.ri added a comment. @aaron.ballman, thank you for the review! Rebased, addressed most of review notes. Repository: rL LLVM https://reviews.llvm.org/D36836

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

This revision was automatically updated to reflect the committed changes. Closed by commit rL315871: Convert clang::LangAS to a strongly typed enum (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D38816?vs=118915=119090#toc Repository: rL LLVM

[PATCH] D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer.

sylvestre.ledru added a comment. For the record, this found 5 actual useless variables in Firefox code. Repository: rL LLVM https://reviews.llvm.org/D38678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

martell added inline comments. Comment at: cfe/trunk/test/Driver/cl-options.c:524 +// RUN: %clang_cl -fmsc-version=1900 -TP -std:c++17 -### -- %s 2>&1 | FileCheck -check-prefix=STDCXX17 %s +// STDCXX14: -std=c++17 + This was incorrect, it should have been

r315868 - Fix test case regresstion from rL315864

Author: martell Date: Sun Oct 15 11:01:28 2017 New Revision: 315868 URL: http://llvm.org/viewvc/llvm-project?rev=315868=rev Log: Fix test case regresstion from rL315864 The patch should have been checking against STDCXX17 not STDCXX14. Modified: cfe/trunk/test/Driver/cl-options.c Modified:

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

mstorsjo added inline comments. Comment at: docs/index.rst:55 NetBSD x86_64 Clang, GCC DWARF CFI -Windows i386 ClangDWARF CFI +Windows i386, x86_64 ClangDWARF CFI

r315867 - Driver: use ld64.lld when -fuse-ld=lld for darwin

Author: martell Date: Sun Oct 15 10:53:45 2017 New Revision: 315867 URL: http://llvm.org/viewvc/llvm-project?rev=315867=rev Log: Driver: use ld64.lld when -fuse-ld=lld for darwin When using lld on macOS the current level of detection between ld and ld64 forces us to rename lld to ld. For ELF

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

This revision was automatically updated to reflect the committed changes. Closed by commit rL315865: MACHO: ld64.lld alias for the MACHO LLD target (authored by martell). Changed prior to commit: https://reviews.llvm.org/D38290?vs=116801=119087#toc Repository: rL LLVM

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

martell added a comment. Landed, @rnk I missed this message in my travels from Ireland back to Mountain View. Just catching up with everything now :) Repository: rL LLVM https://reviews.llvm.org/D38123 ___ cfe-commits mailing list

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

This revision was automatically updated to reflect the committed changes. Closed by commit rL315864: [driver] [cl] Add/fix c++17/c++latest (authored by martell). Changed prior to commit: https://reviews.llvm.org/D38123?vs=116154=119086#toc Repository: rL LLVM

r315864 - [driver] [cl] Add/fix c++17/c++latest

Author: martell Date: Sun Oct 15 10:27:58 2017 New Revision: 315864 URL: http://llvm.org/viewvc/llvm-project?rev=315864=rev Log: [driver] [cl] Add/fix c++17/c++latest Patch by: daxpedda Differential Revision: https://reviews.llvm.org/D38123 Modified:

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

martell added inline comments. Comment at: docs/index.rst:55 NetBSD x86_64 Clang, GCC DWARF CFI -Windows i386 ClangDWARF CFI +Windows i386, x86_64 ClangDWARF CFI

Re: r315856 - Add -f[no-]double-square-bracket-attributes as new driver options to control use of [[]] attributes in all language modes. This is the initial implementation of WG14 N2165, which is a pr

On Sun, Oct 15, 2017 at 12:52 PM, Saleem Abdulrasool wrote: > > > On Sun, Oct 15, 2017 at 8:01 AM, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Sun Oct 15 08:01:42 2017 >> New Revision: 315856 >> >> URL:

Re: r315856 - Add -f[no-]double-square-bracket-attributes as new driver options to control use of [[]] attributes in all language modes. This is the initial implementation of WG14 N2165, which is a pr

On Sun, Oct 15, 2017 at 8:01 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Sun Oct 15 08:01:42 2017 > New Revision: 315856 > > URL: http://llvm.org/viewvc/llvm-project?rev=315856=rev > Log: > Add -f[no-]double-square-bracket-attributes as

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

aaron.ballman added a comment. (I've not had the chance to complete a full review, but these are some thoughts thus far.) Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:76 + // So either static out-of-line or non-static in-line. + const std::array

r315856 - Add -f[no-]double-square-bracket-attributes as new driver options to control use of [[]] attributes in all language modes. This is the initial implementation of WG14 N2165, which is a propos

Author: aaronballman Date: Sun Oct 15 08:01:42 2017 New Revision: 315856 URL: http://llvm.org/viewvc/llvm-project?rev=315856=rev Log: Add -f[no-]double-square-bracket-attributes as new driver options to control use of [[]] attributes in all language modes. This is the initial implementation of

[PATCH] D37436: Initial implementation of C attributes (WG14 N2137)

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. I've commit in r315856, thank you for the reviews! Comment at: ../llvm/tools/clang/include/clang/Driver/Options.td:609-616 +def fdouble_square_bracket_attributes

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

dkrupp requested changes to this revision. dkrupp added a comment. This revision now requires changes to proceed. Please fix the incompatibility between analyze-build and lib/CrossTU in the format of externalFnMap.txt mappfing file. Comment at:

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

aaron.ballman added inline comments. Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:104 + + diag(Tok.getLocation(), + "calling an inherited constructor other than the copy constructor") szdominik wrote: > aaron.ballman wrote: > > Insteaad of

[PATCH] D38704: [libunwind] Emulate pthread rwlocks via SRW locks for windows

mstorsjo added a comment. In https://reviews.llvm.org/D38704#897935, @majnemer wrote: > I don't think we should depend on LLVM for the locking stuff. This sort of > infrastructure is in the same bucket as the demangler which we haven't really > solved. > > I *do* find it weird to do it this

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

mstorsjo updated this revision to Diff 119068. mstorsjo added a comment. Use `__SIZEOF_POINTER__` instead of checking `__LP64__` together with `_WIN64`. Changed `_WIN32` into `_WIN64` within the assembly sources for consistency/clarity. Removed one type definition ifdef by just using

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

mstorsjo added inline comments. Comment at: include/unwind.h:125 uintptr_t private_2; // holds sp that phase1 found for phase2 to use -#ifndef __LP64__ +#if !defined(__LP64__) && !defined(_WIN64) // The implementation of _Unwind_Exception uses an attribute mode on the