[PATCH] D38683: [X86][AVX512] lowering broadcastm intrinsic - clang part

2017-11-05 Thread jina via Phabricator via cfe-commits
jina.nahias added a comment. commit in https://reviews.llvm.org/rL317456 https://reviews.llvm.org/D38683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

2017-11-05 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. Herald added a subscriber: aprantl. Adds `-fseh-exceptions` and `-fdwarf-exceptions` to compliment `-fsjlj-exceptions`. This makes the exception personality configurable at runtime rather then just compile time. If nothing is passed to cc1 we default to

r317456 - lowering broadcastm

2017-11-05 Thread Jina Nahias via cfe-commits
Author: jina.nahias Date: Sun Nov 5 23:04:12 2017 New Revision: 317456 URL: http://llvm.org/viewvc/llvm-project?rev=317456=rev Log: lowering broadcastm Change-Id: I0661abea3e3742860e0a03ff9e4fcdc367eff7db Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

2017-11-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/Basic/TargetInfo.h:944 + /// \brief Whether target supports variable-length arrays. + bool isVLASupported() const { return VLASupported; } + Hahnfeld wrote: > rjmccall wrote: > > Hahnfeld wrote: > > >

[PATCH] D39502: [Driver] Make clang/cc conforms to UNIX standard

2017-11-05 Thread Justin Lebar via Phabricator via cfe-commits
jlebar requested changes to this revision. jlebar added a comment. This revision now requires changes to proceed. > Note the host clang side has the inputs "test.cu" and "test-c3378c.fatbin". > Which means if the device side compilation failed, the host side will not > compile because InputOk

[PATCH] D39665: Support __has_c_attribute

2017-11-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. We have the __has_cpp_attribute builtin macro to determine when an attribute is supported with C++ [[]] syntax, and this patch adds the analogous __has_c_attribute builtin macro so that users can test whether a given [[]] attribute is available in C when

[PATCH] D39633: Remove \brief from doxygen comments in PrettyPrinter.h

2017-11-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317443: Remove \brief from doxygen comments in PrettyPrinter.h (authored by adrian). Changed prior to commit: https://reviews.llvm.org/D39633?vs=121603=121663#toc Repository: rL LLVM

r317443 - Remove \brief from doxygen comments in PrettyPrinter.h

2017-11-05 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Sun Nov 5 13:52:36 2017 New Revision: 317443 URL: http://llvm.org/viewvc/llvm-project?rev=317443=rev Log: Remove \brief from doxygen comments in PrettyPrinter.h Patch by @xsga! Differential Revision: https://reviews.llvm.org/D39633 Modified:

[PATCH] D39664: [clang-diff] patching: implement updates

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. This allows to patch nodes that have been updated. We use a LCS algorithm to determine which tokens changed, and update accordingly. https://reviews.llvm.org/D39664 Files: lib/Tooling/ASTDiff/ASTPatch.cpp

[PATCH] D39663: [clang-diff] Split source ranges at points where nodes are inserted.

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. This enables inserting into empty CompoundStmt nodes, for example. Previously the insertion would occur only after the closing parenthesis. https://reviews.llvm.org/D39663 Files: lib/Tooling/ASTDiff/ASTPatch.cpp

[PATCH] D37005: [clang-diff] Initial implementation of patching

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 121656. johannes added a comment. update https://reviews.llvm.org/D37005 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTPatch.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/ASTPatch.cpp

[PATCH] D39662: [clang-diff] Enable postorder traversal

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39662 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp Index: lib/Tooling/ASTDiff/ASTDiff.cpp === ---

[PATCH] D39661: [clang-diff] Move printing of changes to the ASTDiff library

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39661 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D39660: [clang-diff] Don't ignore nodes from other files

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39660 Files: lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D39659: [clang-diff] Store changes within ASTDiff::Impl

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. This way we avoid modifying SyntaxTree::Impl except during construction. https://reviews.llvm.org/D39659 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp tools/clang-diff/ClangDiff.cpp

[PATCH] D39658: [clang-diff] Treat QualType / TypeLoc as a node

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39658 Files: lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-bottomup.cpp test/Tooling/clang-diff-heuristics.cpp

[PATCH] D37003: [clang-diff] Support templates

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 121650. johannes added a comment. update https://reviews.llvm.org/D37003 Files: lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp

[PATCH] D36688: [clang-diff] Fix matching for unnamed NamedDecs

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 121649. johannes added a comment. update https://reviews.llvm.org/D36688 Files: lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-heuristics.cpp Index: test/Tooling/clang-diff-heuristics.cpp

[PATCH] D39656: [clang-diff] Remove getNodeValue

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39656 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-bottomup.cpp

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 121647. johannes added a comment. use raw source code of owned tokens instead https://reviews.llvm.org/D37001 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-basic.cpp

[PATCH] D39655: [clang-diff] Expose Node::getSourceRange()

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39655 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-json.cpp Index: test/Tooling/clang-diff-json.cpp

[PATCH] D39653: [clang-diff] Add utility functions, forbid copying Node

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39653 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp Index: lib/Tooling/ASTDiff/ASTDiff.cpp === ---

[PATCH] D36997: [clang-diff] Honor macros

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 121642. johannes added a comment. update https://reviews.llvm.org/D36997 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-ast.cpp

[PATCH] D36687: [clang-diff] Match nodes with the same parent and same value

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes updated this revision to Diff 121641. johannes added a comment. update https://reviews.llvm.org/D36687 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-bottomup.cpp test/Tooling/clang-diff-heuristics.cpp

[PATCH] D39652: [clang-diff] NFC: factor out getCompilationDatabase()

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. https://reviews.llvm.org/D39652 Files: tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp === --- tools/clang-diff/ClangDiff.cpp +++ tools/clang-diff/ClangDiff.cpp @@ -84,27

[PATCH] D39651: [clang-diff] NFC: renames, moves

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39651 Files: lib/Tooling/ASTDiff/ASTDiff.cpp Index: lib/Tooling/ASTDiff/ASTDiff.cpp === --- lib/Tooling/ASTDiff/ASTDiff.cpp +++

[PATCH] D39650: [clang-diff] Make getSourceRangeOffsets a member of Node

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39650 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D39649: [clang-diff] Split findPositionInParent

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. This makes findPositionInParent() a member of Node. Additionally, the function that computes the new position that is dependent on insertions and deletions of siblings, is now a member of ASTDiff::Impl.

[PATCH] D39648: [clang-diff] NFC: organise header

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39648 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp Index: lib/Tooling/ASTDiff/ASTDiff.cpp === ---

[PATCH] D39647: [clang-diff] NFC: remove Mapping

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. Store it within ASTDiff::Impl instead. https://reviews.llvm.org/D39647 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D39646: [clang-diff] Rename ChangeKind::None to NoChange

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39646 Files: include/clang/Tooling/ASTDiff/ASTDiff.h tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp === ---

[PATCH] D39645: [clang-diff] NFC: replace const Node & with a typedef'd NodeRef

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D39645 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D39644: [clang-diff] Use references to Node instead of NodeId

2017-11-05 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added a subscriber: klimek. This adds to each node a reference to its syntax tree. As a result, instead of passing around the tree plus the node ID, we just use a reference to the node. This removes some potential for errors. Users will almost always use

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

2017-11-05 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. Thanks. Could someone please commit it for me? https://reviews.llvm.org/D39640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39633: Remove \brief from doxygen comments in PrettyPrinter.h

2017-11-05 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Repository: rL LLVM https://reviews.llvm.org/D39633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

2017-11-05 Thread Sanjay Patel via Phabricator via cfe-commits
spatel created this revision. Herald added a subscriber: mcrosier. Splitting cbrt and fma off from https://reviews.llvm.org/D39611, so we can deal with complex.h separately. I've also gone ahead with a 'fix' for the fma case in CodeGenFunction::EmitBuiltinExpr(). But as noted previously,

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

2017-11-05 Thread Rainer Orth via Phabricator via cfe-commits
ro created this revision. Herald added a subscriber: fedor.sergeev. During make check-all on Solaris, lit complains llvm-lit: /vol/gcc/src/llvm/llvm/dist/tools/clang/test/Unit/lit.cfg.py:57: warning: unable to inject shared library path on 'SunOS' The following patch avoids this: Solaris uses

[PATCH] D39611: [CodeGen] make cbrt and fma constant (never set errno); document complex calls as always constant

2017-11-05 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added a comment. In https://reviews.llvm.org/D39611#915812, @hfinkel wrote: > In the C specification, 7.12 specifies the requirements for functions in > math.h. For those functions, 7.12.1 (Treatment of error conditions) says that > overflows do set ERANGE, and that it's implementation

r317434 - [clang-diff] NFC: format

2017-11-05 Thread Johannes Altmanninger via cfe-commits
Author: krobelus Date: Sun Nov 5 03:53:18 2017 New Revision: 317434 URL: http://llvm.org/viewvc/llvm-project?rev=317434=rev Log: [clang-diff] NFC: format Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp URL:

[PATCH] D39631: [X86] Fix the spelling of 3dnow and 3dnowa in isValidFeatureName

2017-11-05 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo updated this revision to Diff 121623. mstorsjo retitled this revision from "[X86] Add 3dnow and 3dnowa to the list of valid target features" to "[X86] Fix the spelling of 3dnow and 3dnowa in isValidFeatureName". mstorsjo edited the summary of this revision. mstorsjo added a comment.

[PATCH] D39638: [NVPTX] Implement __nvvm_atom_add_gen_d builtin.

2017-11-05 Thread Justin Lebar via Phabricator via cfe-commits
jlebar updated this revision to Diff 121620. jlebar added a comment. Fix tests. https://reviews.llvm.org/D39638 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-nvptx-ptx50.cu llvm/include/llvm/IR/IntrinsicsNVVM.td

[PATCH] D39638: [NVPTX] Implement __nvvm_atom_add_gen_d builtin.

2017-11-05 Thread Justin Lebar via Phabricator via cfe-commits
jlebar created this revision. Herald added subscribers: hiraditya, sanjoy, jholewinski. This just seems to have been an oversight. We already supported the f64 atomic add with an explicit scope (e.g. "cta"), but not the scopeless version. https://reviews.llvm.org/D39638 Files: