krytarowski added inline comments.
Comment at: compiler-rt/lib/xray/xray_x86_64.cc:25
+ size_t Len = 0;
+ if (sysctlbyname("hw.cpufrequency_max", &CPUFreq, &Len, NULL, 0) == -1) {
+Report("Unable to determine CPU frequency for TSC accounting; errno =
%d\n",
---
JVApen added a comment.
Looking at the documentation and the examples, it is unclear to me what the
behavior of checking is when you call a function without throw/noexcept if you
can't see the implementation. (Other cpp file)
https://reviews.llvm.org/D33537
sylvestre.ledru added a comment.
@davidxl David, is that ok with you? Can you sign off this change? Thanks
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
tk1012 updated this revision to Diff 124124.
tk1012 added a comment.
Hello there,
I update the diff and add `void f() { declToImport().m(); }` after
`declToImport` definition.
I leave the matcher for private in the test file, so I don't update the
documentation.
https://reviews.llvm.org/D3972
szepet updated this revision to Diff 124123.
szepet added a comment.
Updating the usage of `ImportTemplateArgumentListInfo`.
https://reviews.llvm.org/D38694
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
===
sammccall edited reviewers, added: ioeric; removed: ilya-biryukov.
sammccall added a comment.
Oops, Eric is most likely to have this stuff in cache :-)
Sorry this is huge and ugly, -500 lines though!
I think the `Protocol` code could be a lot tighter (there's still a lot of
repeated "is this an
szepet updated this revision to Diff 124119.
szepet marked 6 inline comments as done.
szepet added a comment.
Herald added a subscriber: rnkovacs.
Updated based on review comments.
Hello Aleksei,
Thank for the review and the code snippet as well!
https://reviews.llvm.org/D38845
Files:
lib/AS
sammccall created this revision.
- Converted Protocol.h parse() functions to take JSON::Expr. These no longer
detect and log unknown fields, as this is not that useful and no longer free. I
haven't changed the error handling too much: fields that were treated as
optional before are still option
malaperle added a comment.
In https://reviews.llvm.org/D38425#922408, @ioeric wrote:
> Drive-by comment: in general, have you considered reusing the existing
> declarations and occurrences finding functionalities in clang-rename? AFAIK,
> it deals with templates and macros pretty well.
>
> o
>
Nebiroth updated this revision to Diff 124116.
Nebiroth marked 32 inline comments as done.
Nebiroth added a comment.
Minor code cleanup and improvements
getRawCommentForDeclNoCache() now called for every Decl and only once per Decl
getHover() now properly handles templates
https://reviews.llvm.o
+Dimitry.
On 11/23/2017 12:50 PM, Benjamin Kramer wrote:
I'm afraid I can't really help you here. You can try twiddling the
code a bit by creating the pair explicitly and moving it into the
vector, just to avoid the brokenness in the standard library. Not sure
if that will help though.
On Thu,
szepet added a comment.
Hello Aleksei,
Thank you for the review! (and sorry for the late update)
Comment at: lib/AST/ASTImporter.cpp:5510
+ UnresolvedSet<8> ToDecls;
+ for (Decl *D : E->decls()) {
+if (NamedDecl *To = cast_or_null(Importer.Import(D)))
a.
szepet updated this revision to Diff 124115.
szepet marked 7 inline comments as done.
szepet added a comment.
Herald added a subscriber: rnkovacs.
Updates based on review comments.
https://reviews.llvm.org/D38694
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unitt
saar.raz requested changes to this revision.
saar.raz added a comment.
This revision now requires changes to proceed.
Also add:
In ASTDumper
+void VisitConceptTemplateDecl(const ConceptTemplateDecl *D);
Implementation:
void ASTDumper::VisitConceptTemplateDecl(const ConceptTemplateDecl *
sammccall updated this revision to Diff 124105.
sammccall added a comment.
While here, fix a duplicated test.
https://reviews.llvm.org/D40399
Files:
clangd/JSONExpr.h
unittests/clangd/JSONExprTests.cpp
Index: unittests/clangd/JSONExprTests.cpp
==
mattd created this revision.
In the case of ill-formed templates, a value dependent name can reach the
integral constant expression (ICE) check. After an error occurs following an
ill-formed template, an ICE check can be performed on a template definition.
That definition might contain an expre
I'm afraid I can't really help you here. You can try twiddling the
code a bit by creating the pair explicitly and moving it into the
vector, just to avoid the brokenness in the standard library. Not sure
if that will help though.
On Thu, Nov 23, 2017 at 7:05 PM, Krzysztof Parzyszek
wrote:
> There
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:997
+ DocumentHighlightKind Kind;
+ switch (Roles) {
+ case (unsigned)index::SymbolRole::Read:
With this code, I always get "text" kind. It's because index::SymbolRoleSet is
a bitf
There has been some problem with std::pair on FreeBSD (due to some ABI
compatibility issue), but I don't know much about what it was.
Commenting the reserve doesn't help, unfortunately. The same problem is
now flagged in emplace_back.
-Krzysztof
On 11/23/2017 11:47 AM, Benjamin Kramer wrote
jkorous-apple added a comment.
Sorry for delays, I'm working on this on and off when there's nothing more
important.
Let me specify a little narrower scope of this change:
- Make code completion contain constructor item for out-of-line constructor
definition: struct foo { foo(); }; foo:: // re
That looks like a bug in the standard library. Does removing the call
to reserve fix it? It's not really necessary, that code isn't
performance sensitive at all.
On Thu, Nov 23, 2017 at 6:36 PM, Krzysztof Parzyszek
wrote:
> Hi,
> This broke build on FreeBSD 11:
>
> [100%] Building CXX object
> to
Hi,
This broke build on FreeBSD 11:
[100%] Building CXX object
tools/clang/tools/extra/include-fixer/find-all-symbols/CMakeFiles/findAllSymbols.dir/HeaderMapCollector.cpp.o
cd /w/bld/org/tools/clang/tools/extra/include-fixer/find-all-symbols &&
/w/c/clang+llvm-5.0.0-x86_64-unknown-freebsd11/bin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318928: [clangd] Tracing improvements (authored by
sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D40132
Files:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-extra/trunk/clan
Author: sammccall
Date: Thu Nov 23 09:12:04 2017
New Revision: 318928
URL: http://llvm.org/viewvc/llvm-project?rev=318928&view=rev
Log:
[clangd] Tracing improvements
Summary:
[clangd] Tracing improvements
Compose JSON using JSONExpr
Allow attaching metadata to spans (and avoid it if tracing is o
Author: sammccall
Date: Thu Nov 23 09:09:04 2017
New Revision: 318927
URL: http://llvm.org/viewvc/llvm-project?rev=318927&view=rev
Log:
[clangd] Make completion scores use 0-1 floats internally.
Summary:
This scale is much easier to mix with other signals, such as fuzzy match
strength.
Mostly NF
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318927: [clangd] Make completion scores use 0-1 floats
internally. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D40089?vs=124044&id=124099#toc
Repository:
rL LLVM
https
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318926: [clang-tidy] rename_check.py misc-argument-comment
bugprone-argument-comment (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D40392?vs=124079&id=124098#toc
Repository:
Author: alexfh
Date: Thu Nov 23 09:02:48 2017
New Revision: 318926
URL: http://llvm.org/viewvc/llvm-project?rev=318926&view=rev
Log:
[clang-tidy] rename_check.py misc-argument-comment bugprone-argument-comment
Summary: + manually convert the unit test to lit test.
Reviewers: hokein
Reviewed By:
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:1245
+
+ for (unsigned I = 0; I < DocHighlightsFinder->getSourceRanges().size(); I++)
{
+HighlightLocations.push_back(
malaperle wrote:
> replace all this code (1242-1265) by moving it in Do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318925: [clangd] Drop impossible completions (unavailable or
inaccessible) (authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D39836
Files:
clang-tools-extra/trunk/clangd/ClangdLS
Author: sammccall
Date: Thu Nov 23 08:58:22 2017
New Revision: 318925
URL: http://llvm.org/viewvc/llvm-project?rev=318925&view=rev
Log:
[clangd] Drop impossible completions (unavailable or inaccessible)
Summary: (There must be some reason why D38077 didn't just do this, but I don't
get it!)
Rev
sammccall updated this revision to Diff 124096.
sammccall marked 15 inline comments as done.
sammccall added a comment.
Addressing review comments and generally improving comments.
https://reviews.llvm.org/D40060
Files:
clangd/CMakeLists.txt
clangd/FuzzyMatch.cpp
clangd/FuzzyMatch.h
uni
sammccall added a comment.
Thanks for the review, and sorry for the subtlety of the code and sparse
comments.
It should be a little better now, please let me know which parts aren't clear
enough.
Comment at: clangd/FuzzyMatch.cpp:69
+: NPat(std::min(MaxPat, Pattern.size()
klimek marked an inline comment as done.
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1504
: Style.PenaltyBreakComment;
- unsigned RemainingSpace = ColumnLimit - Current.UnbreakableTailLength;
+ // Stores whethe
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:67
);
+
if (Params.rootUri && !Params.rootUri->file.empty())
extra line
klimek updated this revision to Diff 124095.
klimek added a comment.
Pull out getRemainingLength.
https://reviews.llvm.org/D40310
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
unittests/Format/Forma
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/DefaultArgumentsCheck.cpp:35-38
+SourceRange RemovalRange(
+ Lexer::getLocForEndOfToken(D->getLocation(), 0,
+*Result.SourceManager, Result.Context->getLangOpts()),
+ D->get
aaron.ballman added a comment.
In https://reviews.llvm.org/D39722#933838, @xazax.hun wrote:
> In https://reviews.llvm.org/D39722#933828, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D39722#933699, @a.sidorin wrote:
> >
> > > Hello Takafumi,
> > >
> > > This is almost OK to me but there
a.sidorin added a comment.
Oh, sorry! I was thinking that a matcher is still in ASTMatchers.h (in previous
revisions it was there). If matcher is internal (current revision), there is no
need to update docs.
https://reviews.llvm.org/D39722
___
cfe
xazax.hun added a comment.
In https://reviews.llvm.org/D39722#933828, @aaron.ballman wrote:
> In https://reviews.llvm.org/D39722#933699, @a.sidorin wrote:
>
> > Hello Takafumi,
> >
> > This is almost OK to me but there is an inline comment we need to resolve
> > in order to avoid Windows buildbo
aaron.ballman added a comment.
In https://reviews.llvm.org/D39722#933699, @a.sidorin wrote:
> Hello Takafumi,
>
> This is almost OK to me but there is an inline comment we need to resolve in
> order to avoid Windows buildbot failures.
> In addition, as Gabor pointed, when we add a new matcher,
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
ilya-biryukov added inline comments.
Comment at: clangd/JSONRPCDispatcher.h:78
llvm::Optional ID;
+ std::unique_ptr Tracer;
};
ilya-biryukov wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > Why do we need `unique_ptr`? Are `Span`s non-movable?
> > Sp
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:198
+ "Getting the length of a part of the string literal indicates that "
+ "the code tries to reflow it.");
+ return UnbreakableTailLength + Postfix.size() +
klimek wrote
kosarev updated this revision to Diff 124084.
kosarev added a comment.
Rebased.
https://reviews.llvm.org/D40176
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/CodeGenTBAA.cpp
lib/CodeGen/CodeGenTBAA.h
Index: lib/CodeGen/CodeGenTBA
schroedersi added a comment.
Ping
https://reviews.llvm.org/D30946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asb marked an inline comment as done.
asb added a comment.
In https://reviews.llvm.org/D39963#931026, @apazos wrote:
> Can you push this as a patch to review/commit instead of RFC? It has received
> a lot of comments/corrections already and I think it is getting in a shape we
> can merge.
I m
alexfh created this revision.
Herald added subscribers: xazax.hun, mgorny.
+ manually convert the unit test to lit test.
https://reviews.llvm.org/D40392
Files:
clang-tidy/bugprone/ArgumentCommentCheck.cpp
clang-tidy/bugprone/ArgumentCommentCheck.h
clang-tidy/bugprone/BugproneTidyModule.cp
klimek added a comment.
In https://reviews.llvm.org/D33589#933746, @Typz wrote:
> with this setting, a "non wrapped" comment will actually be reflown to
> ColumnLimit+10...
Isn't the same true for code then, though? Generally, code will protrude by 10
columns before being broken?
https://re
klimek added a comment.
In https://reviews.llvm.org/D33589#933746, @Typz wrote:
> > @klimek wrote:
> > In the above example, we add 3 line breaks, and we'd add 1 (or more)
> > additional line breaks when reflowing below the column limit.
> > I agree that that can lead to different overall outc
Author: alexfh
Date: Thu Nov 23 06:59:19 2017
New Revision: 318922
URL: http://llvm.org/viewvc/llvm-project?rev=318922&view=rev
Log:
[clang-tidy] rename_check.py: fix a bug in check presence detection
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: clang-tools-extra/tr
On Thu, Nov 23, 2017 at 1:47 AM, Kim Gräsman wrote:
>
>
> Den 21 nov. 2017 11:24 em skrev "Aaron Ballman via cfe-commits"
> :
>
> Author: aaronballman
> Date: Tue Nov 21 14:24:13 2017
> New Revision: 318809
>
> URL: http://llvm.org/viewvc/llvm-project?rev=318809&view=rev
> Log:
> Silence some MSVC
Author: aaronballman
Date: Thu Nov 23 06:57:24 2017
New Revision: 318921
URL: http://llvm.org/viewvc/llvm-project?rev=318921&view=rev
Log:
Fixing a typo; NFC.
Modified:
clang-tools-extra/trunk/clangd/JSONExpr.cpp
Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp
URL:
http://llvm.org/vie
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/ClangdUnit.cpp:425
+const uint32_t SignBit = ~(~uint32_t{0} >> 1);
+return U & SignBit ? 0 - U : U + SignBit;
+ }
sammccall
Author: marshall
Date: Thu Nov 23 06:50:56 2017
New Revision: 318919
URL: http://llvm.org/viewvc/llvm-project?rev=318919&view=rev
Log:
Update C++2a status and add Glen to CREDITS.TXT. Reviewed as
https://reviews.llvm.org/D40379
Modified:
libcxx/trunk/CREDITS.TXT
libcxx/trunk/www/cxx2a_st
baloghadamsoftware added a comment.
Let us summarize the possibilities:
1. Type extension approach. I tested it, all tests pass, and also in Devin's
examples we do not infer narrower range than we should. (Wider do not matter.)
I think this is the most complete solution and many checkers could
klimek added a comment.
In https://reviews.llvm.org/D37813#930065, @Typz wrote:
> ping?
Argh, very sorry for the delay in response.
In https://reviews.llvm.org/D37813#905257, @Typz wrote:
> In https://reviews.llvm.org/D37813#876227, @klimek wrote:
>
> > I think instead of introducing more and
Typz added a comment.
> @klimek wrote:
> In the above example, we add 3 line breaks, and we'd add 1 (or more)
> additional line breaks when reflowing below the column limit.
> I agree that that can lead to different overall outcomes, but I don't see
> how the approach of this patch really fixe
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:198
+ "Getting the length of a part of the string literal indicates that "
+ "the code tries to reflow it.");
+ return UnbreakableTailLength + Postfix.size() +
krasimir wrote
klimek updated this revision to Diff 124075.
klimek marked 10 inline comments as done.
klimek added a comment.
Address review comments.
https://reviews.llvm.org/D40310
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
unittests/Format/F
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D40302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ilya-biryukov updated this revision to Diff 124074.
ilya-biryukov added a comment.
- Fixed a typo.
https://reviews.llvm.org/D40302
Files:
include/clang/Frontend/PrecompiledPreamble.h
lib/Frontend/PrecompiledPreamble.cpp
Index: lib/Frontend/PrecompiledPreamble.cpp
=
bkramer added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:101
/// is accessible.
+ /// For in-memory preambles, PrecompiledPreamble instance continues to owns
+ /// the MemoryBuffer with the Preamble after this method returns. The caller
---
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/JSONRPCDispatcher.h:78
llvm::Optional ID;
+ std::unique_ptr Tracer;
};
sammccall wrote:
> ilya-biryukov wrote:
> >
Author: alexfh
Date: Thu Nov 23 06:05:32 2017
New Revision: 318918
URL: http://llvm.org/viewvc/llvm-project?rev=318918&view=rev
Log:
[clang-tidy] rename_check.py: Update '=...' line in the docs.
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: clang-tools-extra/trun
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D33537#902242, @JonasToth wrote:
>
> Will this check find stuff like this (or is it part of the frontend)
>
> int throwing() {
> throw int(42);
> }
>
> int not_throwing() noexcept {
> throwing();
> }
Yes,
alexfh created this revision.
Herald added subscribers: xazax.hun, mgorny.
https://reviews.llvm.org/D40389
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/DanglingHandleCheck.cpp
clang-tidy/bugprone/DanglingHandleCheck.h
clang-tid
a.sidorin added a comment.
Hello Takafumi,
This is almost OK to me but there is an inline comment we need to resolve in
order to avoid Windows buildbot failures.
In addition, as Gabor pointed, when we add a new matcher, we need to update
matcher documentation as well. To update the docs, you sh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318916: [clang-tidy] rename_check.py misc-string-constructor
bugprone-string-constructor (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D40388?vs=124065&id=124070#toc
Repositor
Author: alexfh
Date: Thu Nov 23 05:49:14 2017
New Revision: 318916
URL: http://llvm.org/viewvc/llvm-project?rev=318916&view=rev
Log:
[clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor
Summary:
Rename misc-string-constructor to bugprone-string-constructor +
manually u
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
baloghadamsoftware closed this revision.
baloghadamsoftware added a comment.
Closed by commit https://reviews.llvm.org/rL318913.
https://reviews.llvm.org/D39370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: baloghadamsoftware
Date: Thu Nov 23 05:12:25 2017
New Revision: 318913
URL: http://llvm.org/viewvc/llvm-project?rev=318913&view=rev
Log:
[clang-tidy] Detect bugs in bugprone-misplaced-operator-in-strlen-in-alloc even
in the case the allocation function is called using a constant function
sammccall added inline comments.
Comment at: clangd/JSONRPCDispatcher.h:78
llvm::Optional ID;
+ std::unique_ptr Tracer;
};
ilya-biryukov wrote:
> Why do we need `unique_ptr`? Are `Span`s non-movable?
Spans aren't movable, they have an explicitly declared des
sammccall updated this revision to Diff 124069.
sammccall marked an inline comment as done.
sammccall added a comment.
Address review comment.
https://reviews.llvm.org/D40132
Files:
clangd/ClangdUnit.cpp
clangd/JSONRPCDispatcher.cpp
clangd/JSONRPCDispatcher.h
clangd/Trace.cpp
clangd/T
baloghadamsoftware closed this revision.
baloghadamsoftware added a comment.
Closed by commit https://reviews.llvm.org/rL318912.
https://reviews.llvm.org/D39367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: baloghadamsoftware
Date: Thu Nov 23 04:56:23 2017
New Revision: 318912
URL: http://llvm.org/viewvc/llvm-project?rev=318912&view=rev
Log:
[clang-tidy] Add support for operator new[] in check
bugprone-misplaced-operator-in-strlen-in-alloc
The check now recognizes error cases like `new char
baloghadamsoftware closed this revision.
baloghadamsoftware added a comment.
Closed by commit https://reviews.llvm.org/rL318909.
https://reviews.llvm.org/D39366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: baloghadamsoftware
Date: Thu Nov 23 04:43:20 2017
New Revision: 318909
URL: http://llvm.org/viewvc/llvm-project?rev=318909&view=rev
Log:
[ASTMatchers] Matchers for new[] operators
Two new matchers for `CXXNewExpr` are added which may be useful e.g. in
`clang-tidy` checkers. One of them is
sammccall updated this revision to Diff 124066.
sammccall added a comment.
Address review comments
https://reviews.llvm.org/D39836
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
cla
baloghadamsoftware closed this revision.
baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added a comment.
https://reviews.llvm.org/rL318906 and https://reviews.llvm.org/rL318907
https://reviews.llvm.org/D39121
___
cfe-commits
Author: baloghadamsoftware
Date: Thu Nov 23 04:33:12 2017
New Revision: 318907
URL: http://llvm.org/viewvc/llvm-project?rev=318907&view=rev
Log:
[clang-tidy] Misplaced Operator in Strlen in Alloc
A possible error is to write `malloc(strlen(s+1))` instead of
`malloc(strlen(s)+1)`. Unfortunately th
Author: baloghadamsoftware
Date: Thu Nov 23 04:26:28 2017
New Revision: 318906
URL: http://llvm.org/viewvc/llvm-project?rev=318906&view=rev
Log:
[clang-tidy] Misplaced Operator in Strlen in Alloc
A possible error is to write `malloc(strlen(s+1))` instead of
`malloc(strlen(s)+1)`. Unfortunately th
hokein accepted this revision.
hokein added a comment.
LGTM.
https://reviews.llvm.org/D40388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LG!
https://reviews.llvm.org/D40388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
alexfh created this revision.
Herald added subscribers: xazax.hun, mgorny.
Rename misc-string-constructor to bugprone-string-constructor +
manually update the lenght of '==='s in the doc file.
https://reviews.llvm.org/D40388
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugpr
Author: alexfh
Date: Thu Nov 23 04:08:53 2017
New Revision: 318905
URL: http://llvm.org/viewvc/llvm-project?rev=318905&view=rev
Log:
clang-tidy/rename_check.py: support for moving between modules
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: clang-tools-extra/trunk/c
sammccall added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:169
+ clangd::CodeCompleteOptions CCOpts;
+ CCOpts.EnableSnippets = EnableSnippets;
+ CCOpts.IncludeIneligibleResults = IncludeIneligibleResults;
ilya-biryukov wrote:
> We should also set
klimek added a comment.
In https://reviews.llvm.org/D33589#933568, @klimek wrote:
> In https://reviews.llvm.org/D33589#931723, @Typz wrote:
>
> > In https://reviews.llvm.org/D33589#925903, @klimek wrote:
> >
> > > I think this patch doesn't handle a couple of cases that I'd like to see
> > > han
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:250
+ // Verify if path has value and is a valid path
+ if (Params.settings.compilationDatabasePath.hasValue()) {
+CDB.setCompileCommandsDir(
Replace `Settings` instead of `Params.s
AlexeySotkin added a comment.
https://reviews.llvm.org/D39936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader accepted this revision.
bader added a comment.
LGTM. Thanks!
https://reviews.llvm.org/D39936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tk1012 updated this revision to Diff 124057.
tk1012 added a comment.
Hello there,
I update the diff, reflecting the comments.
Updates:
1. Use ImportContainerChecked() for importing TypeSourceInfo.
2. Modify `bool ToValue = (...) ? ... : false;`.
3. Add a test case for the value-dependent `TypeT
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318902: Allow to set locale on Windows. (authored by
mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D40181?vs=123923&id=124055#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40181
Author: mstorsjo
Date: Thu Nov 23 02:38:18 2017
New Revision: 318902
URL: http://llvm.org/viewvc/llvm-project?rev=318902&view=rev
Log:
Allow to set locale on Windows.
Fix the problem PR31516 with setting locale on Windows by wrapping
_locale_t with a pointer-like class.
Reduces 74 test failures
klimek added a comment.
In https://reviews.llvm.org/D40068#931679, @Typz wrote:
> Generally, this indeed improves the situation (though I cannot say much about
> the code itself, it is still too subtle for my shallow knowledge of
> clang-format).
>
> But it seems to give some strange looking re
klimek added a comment.
In https://reviews.llvm.org/D33589#931802, @Typz wrote:
> Btw, another issue I am having is that reflowing does not respect the
> alignment. For exemple:
>
> enum {
> Foo,///< This is a very long comment
> Bar,///< This is shorter
> BarBar, ///<
klimek added a comment.
In https://reviews.llvm.org/D33589#931723, @Typz wrote:
> In https://reviews.llvm.org/D33589#925903, @klimek wrote:
>
> > I think this patch doesn't handle a couple of cases that I'd like to see
> > handled. A counter-proposal with different trade-offs is in
> > https://
halyavin added a comment.
@EricWF, could you please commit this change?
https://reviews.llvm.org/D40181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clangd/FuzzyMatch.cpp:69
+: NPat(std::min(MaxPat, Pattern.size())), NWord(0),
+ ScoreScale(0.5f / NPat) {
+ memcpy(Pat, Pattern.data(), NPat);
Why .5?
Comment at: clangd/FuzzyMatch.cpp:88
+
1 - 100 of 111 matches
Mail list logo
