nik added reviewers: ilya-biryukov, cameron314.
nik added a comment.
Anyone?
https://reviews.llvm.org/D39903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
Could you please explain what category means? Could i disable all of
`cppcoreguidelines` with something like `// NOLINT (cppcoreguidelines-*)`?
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:297
+ if (NolintIndex != StringRef::npos) {
+a
Author: phosek
Date: Thu Nov 30 22:34:33 2017
New Revision: 319523
URL: http://llvm.org/viewvc/llvm-project?rev=319523&view=rev
Log:
[libcxx] Support getentropy as a source of randomness for std::random_device
Use this source use on Fuchsia where this is the oficially way
to obtain randomness. Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319523: [libcxx] Support getentropy as a source of
randomness for std::random_device (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40319?vs=123842&id=125076#toc
Repository:
bob.wilson added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465
if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 ||
getTriple().getArch() == llvm::Triple::x86_64))
Platform = IPhoneOSSimulator;
if (TvOSVersion
vsk planned changes to this revision.
vsk added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
efriedma wrote:
> vsk wr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319515: Include AddLLVM needed for tests in the right
context (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40280?vs=123711&id=125072#toc
Repository:
rL LLVM
https://revie
Author: phosek
Date: Thu Nov 30 19:16:50 2017
New Revision: 319515
URL: http://llvm.org/viewvc/llvm-project?rev=319515&view=rev
Log:
Include AddLLVM needed for tests in the right context
AddLLVM is needed for several functions that are used in tests and
as such needs to be included from the right
efriedma added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
vsk wrote:
> efriedma wrote:
> > Unfortunately, this won'
vsk added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
efriedma wrote:
> Unfortunately, this won't catch cases where
efriedma added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:2756
SourceLocation EndLoc) {
+ if (FI.isNoReturn()) {
+// Noreturn functions don't return.
Unfortunately, this won't catch cases where the caller ha
vsk updated this revision to Diff 125071.
vsk added a comment.
- Leave out an unrelated change in the handling of NakedAttr.
https://reviews.llvm.org/D40698
Files:
docs/UndefinedBehaviorSanitizer.rst
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/C
vsk created this revision.
Herald added subscribers: dberris, kubamracek.
This is a test and a wording update for the clang change:
https://reviews.llvm.org/D40698
https://reviews.llvm.org/D40700
Files:
lib/ubsan/ubsan_handlers.cc
test/ubsan/TestCases/Misc/unreachable.cpp
Index: test/ubs
vsk updated this revision to Diff 125069.
vsk retitled this revision from "[ubsan] Diagnose reached-unreachable after
noreturn calls" to "[ubsan] Diagnose noreturn functions which return".
vsk edited the summary of this revision.
vsk added a comment.
- Emit the check in the noreturn function, so
vsk planned changes to this revision.
vsk added a comment.
Ah, I've found a problem while writing run-time tests. I'll need to take
another cut at this.
https://reviews.llvm.org/D40698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: rsmith
Date: Thu Nov 30 18:13:10 2017
New Revision: 319513
URL: http://llvm.org/viewvc/llvm-project?rev=319513&view=rev
Log:
[c++2a] P0515R3: Support for overloaded operator<=>.
No CodeGen support for MSABI yet, we don't know how to mangle this there.
Added:
cfe/trunk/test/CodeGenCXX
arphaman added a comment.
In https://reviews.llvm.org/D40562#940201, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D40562#939950, @arphaman wrote:
>
> > This change breaks cached completions for declarations in namespaces in
> > libclang. What exactly are you trying to achieve here? We cou
vsk created this revision.
It's possible to reach an 'unreachable' instruction if a call to a
noreturn function returns. Diagnose this behavior.
Note: Most of the changes in this patch -- passing empty SourceLocations
in places where they are either not needed or do not apply -- are NFC.
Testing
arphaman added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465
if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 ||
getTriple().getArch() == llvm::Triple::x86_64))
Platform = IPhoneOSSimulator;
if (TvOSVersion &
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:414
+def ext_decomp_decl_cond : ExtWarn<
+ "decomposed condition is a Clang extension">;
def err_decomp_decl_spec : Error<
Phrase this as "ISO C++17 does not permit structured
Author: rsmith
Date: Thu Nov 30 17:07:10 2017
New Revision: 319509
URL: http://llvm.org/viewvc/llvm-project?rev=319509&view=rev
Log:
[c++2a] P0515R3: lexer support for new <=> token.
Added:
cfe/trunk/test/Lexer/cxx2a-spaceship.cpp
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds
bob.wilson requested changes to this revision.
bob.wilson added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465
if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 ||
getTrip
compnerd added inline comments.
Comment at: include/__config:1267
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
+# pragma comment(lib, "c++d.lib")
smeenai wrote:
> compnerd wrote:
> > smeenai wrote:
> > > I guess `_D
Author: zturner
Date: Thu Nov 30 16:53:10 2017
New Revision: 319505
URL: http://llvm.org/viewvc/llvm-project?rev=319505&view=rev
Log:
Mark all library options as hidden.
These command line options are not intended for public use, and often
don't even make sense in the context of a particular tool
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D40563#940536, @ioeric wrote:
> In https://reviews.llvm.org/D40563#939964, @arphaman wrote:
>
> > If nothing uses `getCXXScopeSpecifier` right now we can't reall
kcc updated this revision to Diff 125045.
kcc added a comment.
Rename the new tool to HWASAN
Repository:
rC Clang
https://reviews.llvm.org/D40568
Files:
docs/HardwareAssistedAddressSanitizerDesign.rst
docs/index.rst
Index: docs/index.rst
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319499: [libc++abi] Add install-cxxabi-stripped target
(authored by smeenai).
Repository:
rL LLVM
https://reviews.llvm.org/D40681
Files:
libcxxabi/trunk/src/CMakeLists.txt
Index: libcxxabi/trunk/s
Author: smeenai
Date: Thu Nov 30 15:25:51 2017
New Revision: 319499
URL: http://llvm.org/viewvc/llvm-project?rev=319499&view=rev
Log:
[libc++abi] Add install-cxxabi-stripped target
LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for inst
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319498: [libunwind] Switch to add_llvm_install_targets
(authored by smeenai).
Repository:
rL LLVM
https://reviews.llvm.org/D40685
Files:
libunwind/trunk/src/CMakeLists.txt
Index: libunwind/trunk/s
Author: smeenai
Date: Thu Nov 30 15:24:08 2017
New Revision: 319498
URL: http://llvm.org/viewvc/llvm-project?rev=319498&view=rev
Log:
[libunwind] Switch to add_llvm_install_targets
This gains us the install-unwind-stripped target, to perform stripping
during installation.
Differential Revision:
smeenai created this revision.
Herald added subscribers: mgorny, dberris.
This gains us the install-*-stripped targets, to strip binaries during
installation. These targets otherwise mimic the existing install targets.
https://reviews.llvm.org/D40687
Files:
cmake/Modules/AddCompilerRT.cmake
Author: sammccall
Date: Thu Nov 30 15:21:34 2017
New Revision: 319497
URL: http://llvm.org/viewvc/llvm-project?rev=319497&view=rev
Log:
[clangd] Logger implicitly adds newline
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.
On Thu, Nov 30, 2017 at 10:21 AM, Dan Olson via Phabricator <
revi...@reviews.llvm.org> wrote:
> dolson added a comment.
>
> Hello,
>
> In the process of upgrading from clang 3.6.1 to a newer version, I ran
> into this new error and thus imported the new intrinsics from intrin.h for
> rep movsb an
Author: sammccall
Date: Thu Nov 30 15:16:23 2017
New Revision: 319496
URL: http://llvm.org/viewvc/llvm-project?rev=319496&view=rev
Log:
[clangd] Log file compile commands
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp
URL:
htt
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
smeenai created this revision.
Herald added a subscriber: mgorny.
This gains us the install-unwind-stripped target, to perform stripping
during installation.
https://reviews.llvm.org/D40685
Files:
src/CMakeLists.txt
Index: src/CMakeLists.txt
=
Author: rsmith
Date: Thu Nov 30 15:07:29 2017
New Revision: 319495
URL: http://llvm.org/viewvc/llvm-project?rev=319495&view=rev
Log:
Update website to mention that you still need -frelaxed-template-template-args
to enable the corresponding C++17 feature in Clang 5.
Modified:
cfe/trunk/www/cx
efriedma added a comment.
Still worried about the effect on tools which parse clang diagnostics... please
send a message to cfe-dev. Hopefully we'll get responses there.
https://reviews.llvm.org/D33765
___
cfe-commits mailing list
cfe-commits@list
arphaman created this revision.
r316380 added support for the 'simulator' environment to LLVM's triple. Clang's
driver should pass this to the compiler when `-msimulator-version-min`
option is specified so that the compiler can avoid using OS & arch specific
checks.
Repository:
rC Clang
ht
smeenai created this revision.
Herald added a subscriber: mgorny.
LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for install-distribution, all
potential distribution components should have stripped installation
targets. LLVM has a functi
smeenai updated this revision to Diff 125034.
smeenai added a comment.
Don't add deprecated target names, since clients should be switching over to
the new ones.
https://reviews.llvm.org/D40680
Files:
include/CMakeLists.txt
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
smeenai created this revision.
Herald added a subscriber: mgorny.
LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for install-distribution, all
potential distribution components should have stripped installation
targets. LLVM has a functi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319489: [clang] Use add_llvm_install_targets (authored by
smeenai).
Changed prior to commit:
https://reviews.llvm.org/D40675?vs=125013&id=125026#toc
Repository:
rC Clang
https://reviews.llvm.org/D40
Author: smeenai
Date: Thu Nov 30 14:35:02 2017
New Revision: 319489
URL: http://llvm.org/viewvc/llvm-project?rev=319489&view=rev
Log:
[clang] Use add_llvm_install_targets
Use this function to create the install targets rather than doing so
manually, which gains us the `-stripped` install targets
Author: eugenezelenko
Date: Thu Nov 30 14:33:48 2017
New Revision: 319487
URL: http://llvm.org/viewvc/llvm-project?rev=319487&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/CXXInheritance.h
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D40675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
hubert.reinterpretcast added inline comments.
Comment at: test/Sema/_Float128.cpp:1
+// RUN: %clang_cc1 -verify -std=gnu++11 %s
+// RUN: %clang_cc1 -verify -std=c++11 %s
GCC documents that it does not support `_Float128` in C++ mode, and I think
their decision m
Author: tra
Date: Thu Nov 30 14:22:21 2017
New Revision: 319485
URL: http://llvm.org/viewvc/llvm-project?rev=319485&view=rev
Log:
[CUDA] Tweak CUDA wrappers to make cuda-9 work with libc++
CUDA-9 headers check for specific libc++ version and ifdef out
some of the definitions we need if LIBCPP_VER
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319485: [CUDA] Tweak CUDA wrappers to make cuda-9 work with
libc++ (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D40198?vs=123421&id=125021#toc
Repository:
rL LLVM
https://rev
vsapsai created this revision.
It covers the cases when the sentry object returns false and when an exception
was thrown. Corresponding standard paragraph is C++14 [istream.unformatted]p9:
[...] In any case, if n is greater than zero it then stores a null
character into the next successive lo
sammccall added a comment.
This is pretty bikesheddy, but I wonder what you think about passing Ctx as the
first vs last parameter.
First has some advantages (maybe I just read too much Go though):
- it's a short expr, and F(short, long) tends to format better than F(long,
short). Particularly
efriedma added a comment.
> _Float128 is only *sometimes* the same type as __float128.
But we don't have hppa or IA-64 backends, so we're fine for now, I think. :)
Comment at: lib/Frontend/InitPreprocessor.cpp:817
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat()
smeenai created this revision.
Herald added a subscriber: mgorny.
Use this function to create the install targets rather than doing so
manually, which gains us the `-stripped` install targets to perform
stripped installations.
Repository:
rC Clang
https://reviews.llvm.org/D40675
Files:
cma
sammccall added a comment.
@ilya-biryukov We should get this landed.
I'm happy (my comments were addressed a few rounds ago) - any concerns?
https://reviews.llvm.org/D39430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
sammccall added a comment.
@ilya-biryukov Ping... this is the patch we wanted to land this week, so long
result sets are correct for user testing next week.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39882
___
cfe-commits maili
sammccall updated this revision to Diff 125009.
sammccall added a comment.
Herald added a subscriber: klimek.
Rebase and remove debug output.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39882
Files:
clangd/ClangdUnit.cpp
unittests/clangd/ClangdTests.cpp
Index: unittests
xgsa updated this revision to Diff 125008.
xgsa added a reviewer: dcoughlin.
xgsa added a comment.
Update the diff to contain the full context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40671
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
test/clang-tidy/nolint.cpp
rsmith added a comment.
Per https://gcc.gnu.org/onlinedocs/gcc/Floating-Types.html, this doesn't appear
to be correct: `_Float128` is only *sometimes* the same type as `__float128`.
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-c
Author: eugenezelenko
Date: Thu Nov 30 13:42:27 2017
New Revision: 319479
URL: http://llvm.org/viewvc/llvm-project?rev=319479&view=rev
Log:
[Documentation] Style fixes for Objective-C checks documentation to follow
C/C++ example.
Release Notes should just repeat first sentence from documentation
sammccall accepted this revision.
sammccall added a comment.
Nice!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
LGTM for the CUDA test changes.
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319478: [clangd] New conventions for JSON-marshalling
functions, centralize machinery (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D40596?vs=124715&id=125004#toc
Repositor
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE319478: [clangd] New conventions for JSON-marshalling
functions, centralize machinery (authored by sammccall).
Changed prior to commit:
https://reviews.llvm
Author: sammccall
Date: Thu Nov 30 13:32:29 2017
New Revision: 319478
URL: http://llvm.org/viewvc/llvm-project?rev=319478&view=rev
Log:
[clangd] New conventions for JSON-marshalling functions, centralize machinery
Summary:
- JSON<->Obj interface is now ADL functions, so they play nicely with enu
sammccall marked 3 inline comments as done.
sammccall added inline comments.
Comment at: clangd/JSONExpr.h:71
+// The convention is to have a deserialize function findable via ADL:
+// deserialize(const json::Expr&, T&)->bool
+// Deserializers are provided for:
--
lebedev.ri added a comment.
Please upload patches with full context (`-U99`)
Also, you probably want to add some reviewers, see CODE_OWNERS.txt e.g.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40671
___
cfe-commits mailing li
mibintc created this revision.
mibintc added a project: clang.
Fedora27 is using a new version of glibc that refers to the _Float128 type.
This patch adds that name as an alias to __float128. I also added some
predefined macro values for the digits, mantissa, epilon, etc (FloatMacros).
For the
juliehockett updated this revision to Diff 125000.
juliehockett marked 4 inline comments as done.
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
clang-tidy/fuchsia/MultipleIn
xgsa created this revision.
xgsa added a project: clang-tools-extra.
The NOLINT directive was extended to support the "NOLINT(category)" and
"NOLINT(*)" syntax. Also it is possible to specify a few categories separated
with comma "NOLINT(cat1, cat2)"
Repository:
rCTE Clang Tools Extra
https
saugustine closed this revision.
saugustine added a comment.
Committed as https://reviews.llvm.org/rL319474.
https://reviews.llvm.org/D36431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
malaperle added inline comments.
Comment at: clangd/ClangdServer.cpp:526
+if (!AST)
+ llvm::make_error(
+ "invalid AST",
missing return?
I get a warning that looks legit:
./tools/clang/tools/extra/clangd/ClangdServer.cpp:526:7: warning: igno
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:228
llvm::toString(Items.takeError()));
+
C.reply(json::ary(Items->Value));
---
vsk created this revision.
There is no way to apply sanitizer suppressions to ObjC blocks. A
reasonable default is to have blocks inherit their parent's sanitizer
options.
rdar://32769634
https://reviews.llvm.org/D40668
Files:
lib/CodeGen/CGBlocks.cpp
test/CodeGenObjC/no-sanitize.m
Index
malaperle requested changes to this revision.
malaperle added a comment.
This revision now requires changes to proceed.
very minor comments
Comment at: clangd/ClangdServer.h:288
+ /// Get document highlights for a symbol hovered on.
+ llvm::Expected>>
+ findDocumentHighlight
smeenai added a comment.
I'm fine with future proofing, but not if it doesn't actually work in the
present :)
Comment at: include/__config:1267
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
+# pragma comment(lib, "c++d.lib")
-
compnerd updated this revision to Diff 124983.
compnerd added a comment.
@rnk/@smeenai don't want future proofing
Repository:
rCXX libc++
https://reviews.llvm.org/D40660
Files:
include/__config
Index: include/__config
===
--
compnerd added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
smeenai wrote:
> rnk wrote:
> > smeenai wrote:
> > > This feels more lik
saugustine closed this revision.
saugustine added a comment.
Committed as R319464.
https://reviews.llvm.org/D36555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
rnk wrote:
> smeenai wrote:
> > This feels more like a Windows (or perhap
rnk added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
smeenai wrote:
> This feels more like a Windows (or perhaps COFF) thing than
smeenai added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
This feels more like a Windows (or perhaps COFF) thing than a Microsoft A
compnerd updated this revision to Diff 124976.
compnerd added a comment.
Fix pragma, ensure that we do not try to recursively link.
https://reviews.llvm.org/D40660
Files:
include/__config
Index: include/__config
===
--- include
Wizard updated this revision to Diff 124972.
Wizard added a comment.
restore file names
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNSErrorInitCheck.cpp
clang-tidy/objc/AvoidNSErrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319460: add new check to find NSError init invocation
(authored by Wizard).
Changed prior to commit:
https://reviews.llvm.org/D40528?vs=124972&id=124973#toc
Repository:
rL LLVM
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319459: add new check to find NSError init invocation
(authored by Wizard).
Changed prior to commit:
https://reviews.llvm.org/D40528?vs=124972&id=124974#toc
Repository:
rL LLVM
https://reviews.llvm.
Wizard updated this revision to Diff 124971.
Wizard added a comment.
change file name cases
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNSEErrorInitCheck.cpp
clang-tidy/objc/AvoidNSEErrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319458: [OpenMP] Diagnose undeclared variables on declare
target clause (authored by kli).
Repository:
rC Clang
https://reviews.llvm.org/D40588
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/declare_t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319458: [OpenMP] Diagnose undeclared variables on declare
target clause (authored by kli).
Changed prior to commit:
https://reviews.llvm.org/D40588?vs=124811&id=124969#toc
Repository:
rL LLVM
https:
Author: kli
Date: Thu Nov 30 10:52:06 2017
New Revision: 319458
URL: http://llvm.org/viewvc/llvm-project?rev=319458&view=rev
Log:
[OpenMP] Diagnose undeclared variables on declare target clause
Clang asserts on undeclared variables on the to or link clause in the declare
target directive. The pat
sammccall added a comment.
Thanks @ilya-biryukov, @inspirer, @klimek for the helpful comments!
I've addressed hopefully the most important and added more rigorous testing.
Sorry for the large delta, the most invasive change was of course adding the
extra dimension to the scoring table. (Which fi
sammccall updated this revision to Diff 124968.
sammccall marked 5 inline comments as done.
sammccall added a comment.
- added more VSCode tests, and made test assert matched characters. This
uncovered algorithm problems
- cache now includes "did previous character match" in the key (scoring depe
dolson added a comment.
Hello,
In the process of upgrading from clang 3.6.1 to a newer version, I ran into
this new error and thus imported the new intrinsics from intrin.h for rep movsb
and friends. I see several discussions in this thread about how having the
registers solely in the inputs
compnerd created this revision.
Herald added a subscriber: cfe-commits.
The MSVC driver and clang do not link against the C++ runtime
explicitly. Instead, they rely on the auto-linking via the pragma
(through `use_ansi.h`) to link against the correct version of the C++
runtime. Attempt to do som
Author: abataev
Date: Thu Nov 30 10:01:54 2017
New Revision: 319450
URL: http://llvm.org/viewvc/llvm-project?rev=319450&view=rev
Log:
[OPENMP] Fix possible assert for target regions with incorrect inner
teams region.
If the inner teams region is not correct, it may cause an assertion when
process
aaron.ballman added a comment.
Ping.
https://reviews.llvm.org/D40448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:35-36
+ StringRef Name = Node->getIdentifier()->getName();
+ if (InterfaceMap.count(Name)) {
+isInterface = InterfaceMap.lookup(Name);
+return true;
One lookup is
saugustine added a comment.
In https://reviews.llvm.org/D36431#940169, @nemanjai wrote:
> This has been sitting in approved state for more than 2 months. As far as I
> can tell, it wasn't committed. Do you plan to commit this soon or are you
> abandoning it for some reason?
My apologies. I ha
krasimir added inline comments.
Comment at: unittests/Format/FormatTest.cpp:10007
+format("// foo foo foo foo foo foo foo foo foo foo foo foo\n",
+ Style));
}
Could you also add a test with line comments surrounded by stuff,
Nebiroth updated this revision to Diff 124951.
Nebiroth marked 6 inline comments as done.
Nebiroth added a comment.
Minor code cleanup
getDeclarationLocation now returns llvm::Optional
operator< for DocumentHighlight struct now properly compares the kind field
Repository:
rCTE Clang Tool
1 - 100 of 136 matches
Mail list logo
